- 27 May, 2020 40 commits
-
-
Aya ElAttar authored
As this policy was needed for the transition from public session to managed-guest session and since M73 public sessions are no longer used, So this policy should be deprecated. Bug: 1086429 Change-Id: Ic8c047c54b5e6b2c20949cf83c282ccea0b1dc45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215811 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#772201}
-
Anastasiia Nikolaienko authored
Send AccountManager.EduCoexistence.FlowResult to record the last completed step in the flow. The value is updated when active screen is changed in the flow, and stored in InlineLoginHandlerDialogChromeOS. When dialog is getting closed, we send UMA with last set flow result. It allows us to track on which screens users close the dialog. See go/cros-beaker-metrics. Bug: 1082791 Change-Id: I422ea8c751f569b716f79dd3fe85a34c054c7df1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208982 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#772200}
-
Dominic Farolino authored
This CL adds an async script scheduling test, mainly to document the current scheduling behavior of async scripts with respect to other scripts. It indicates that currently, async scripts are allowed to load before: - First Paint - The Document is Finished Parsing A follow-up CL (https://crrev.com/c/2213343) implements the delaying of async script execution until: - Finished Parsing - First Paint or Finished Parsing ... and asserts that the implementation affects the output of this test accordingly. The test has to be hosted in wpt_internal/, because we need to use WPT server features such as the trickle pipe, that are not available for use in regular web_tests. Bug: 1086227 Change-Id: I2562df28efbba2c8ab5c21fe55d82a2e44676f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213354Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#772199}
-
Olesia Marukhno authored
Added permission chip to location bar. The permission chip is shown on the permission request. The permission bubble is anchored by the chip instead of the location icon. Bug: 1019129 Change-Id: I0477ed5d1244b99ca399b0bbd280b84e950d4e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193773 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#772198}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a5e07cc3db44..e309651f3330 2020-05-27 jonaso@webrtc.org Don't SetNeedsIceRestartFlag if widening candidate filter when surface_ice_candidates_on_ice_transport_type_changed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iff0b06e08b3a1c9ef6a234cbf1411ba3366fe5e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214047Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772197}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/09f5f6d7..72edaabd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifbb2904f1fd6a6522486089a38963e8ce46e47a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217867Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772196}
-
Antonio Gomes authored
BUG=919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ia1d237955345a66881d75627f18b734d243b69c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216593Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#772195}
-
Antonio Gomes authored
... instead of its Blink API wrapper WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: I402e0b38edc5d52bda41eac592b3fd9355db850f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216046Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#772194}
-
Sergey Poromov authored
As the class only accesses local state, it could directly get it from g_browser_process and be a static helper class. Bug: 383695 Test: Run tryjobs Change-Id: I69e7e3e63b00e507b2b3ef36d3ab4d4678ae5f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215322Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#772193}
-
Aya ElAttar authored
Changed UpdatePublicAccountDisplayName to check for kUserDisplayName in local state before trying to get the display name from the policy broker. Bug: 1079220 Change-Id: Ibbc81e5c8449f6304e8142083a3493380b6f42b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210500 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772192}
-
Nigel Tao authored
Bug: 1070409 Change-Id: I15d324e82d7c5b8e8aa069207ce528a14e8eb0aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214652Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#772191}
-
Yuichiro Hanada authored
It no longer exists. Change-Id: I4f6f08d6b2ae3c3bdafccf71b03f91e6d68bc47b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215547Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#772190}
-
Roman Sorokin authored
GaiaOAuthClient does not support concurrent requests. So when focusing different pods user selection screen might try to check several tokens at the same time. Fixed: 1085612 Change-Id: I017dee8944db0e82194626c9b0abeefe65d335ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213536Reviewed-by:
-
Henrique Ferreiro authored
Uses of those includes appear all over Blink. Consolidate all DEPS include_rules regarding callbacks into third_party/blink/DEPS. Change-Id: I83907a44a2409a7d24ccbdbaf084c6e9e9a3b795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213535 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
Raphael Kubo da Costa authored
We were occasionally hitting a DCHECK in AmbientLightSensor's illuminance accessor after commit 2f0fc46c ("[sensors] Round off Ambient Light Sensor readouts to the nearest 50 Lux") when running the Generic Sensors web tests. We assumed that if Sensor::hasReading() returns true, then Sensor::OnSensorReadingChanged() would have been called first and |latest_reading_| would always be set. It turns out there is a small window when this is not true, when one sensor has been fully initialized by the time it received a "reading" event, but other sensors of the same type might not have had OnSensorReadingChanged() be called on them yet. Fix it by overriding Sensor::hasReading() in AmbientLightSensor: an ALS' definition of "having a reading" depends on whether |latest_reading_| has already been set (which means OnSensorReadingChanged() has been called and the value has been properly processed). Bug: 606766, 1078172 Change-Id: I115233e745b402e97e4223fffd4d68a4350451ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199287 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#772187}
-
Roman Aleksandrov authored
Bug: 1049959 Change-Id: Ic0ff0f33c61ad479fca631a6e98bc88aa84b674a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216213Reviewed-by:
-
Henrique Ferreiro authored
Introduce DragOperation enum, typemapped to blink::WebDragOperation and AllowedDragOperations struct typemapped to blink::WebDragOperationsMask. Bug: 1039255 Change-Id: Idc292bf21cb0a7ac06c7bdcd63f543497d83bf77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196167 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#772185}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ea2ee251f623..2d4ee009038b 2020-05-27 kimanh@chromium.org Add test for scope names during wasm debugging If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1043034 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I571ff1d361d1b760b60b3ef2eee80ab22676babe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217464Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1a97f7367f83..6f8823b42515 2020-05-27 skyostil@google.com Merge "docs: Add guide on making a new SDK release" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I26eeec08ab6d4e1030ee218198830070e2862f9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216922Reviewed-by:
-
Richard Townsend authored
Previously, there were two main ways to parse HTML: * The HTMLDocumentParser's PumpTokenizer method, used for HTML fragment parsing (foreground parser) * The BackgroundHTMLParser, used for page loading (background parser). This CL changes HTMLDocumentParser::PumpTokenizer so that it can yield to other tasks during page loading, adding a third way of parsing (synchronous, budgeted foreground HTML parsing). It does this either when a really important page loading task needs to run, or when a (budget-controlled) chunk of HTML has been processed. Because it can be interrupted, it can replace the BackgroundHTMLParser's functionality whilst being less complicated and offering a faster time-to-first paint. Enable with --enable-blink-features=ForceSynchronousHTMLParsing Design doc: https://docs.google.com/document/d/1ecupQAUrvnAxpGmAitrudaLFd0jN7DAf5dgYSpXFoqI Bug: 901056 Change-Id: I14b8c4bede28479911951181f85395eb617b8b16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1333755Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#772182}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eaf51ab50b85..8a08a7ccdeec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jdoerrie@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1044639 Tbr: jdoerrie@google.com Change-Id: I1d88c6ae6535dd17616cd0c6c2db28ba6c2fd8fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217461Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772181}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5b4c627389a6..f9826008618a 2020-05-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 0c4ea014bf28 to 2bc4fcd9eba5 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I5dd66e0429bb847b3728555d24db52a7ca8a295c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217462Reviewed-by:
-
Maksim Ivanov authored
Disable the non-fatal logging, because fuzzing triggers tons of such messages, which are useless and only slow down the fuzzing. Note that some of the logging spam - mainly caused by the SYSLOG macros - stays intact, since there's no easy way to disable those. Bug: 811690 Change-Id: I9f93b0e2450d8ff9ec7c7a9a8c88c3c23947e7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215827Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#772179}
-
Jan Wilken Dörrie authored
TBR=mcasas Bug: 1086872 Change-Id: Iacb2b15812e91c24bf66f167a0f720d2a3096147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216773Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#772178}
-
Friedrich Horschig authored
With this CL, the autofill popup isn't kept open anymore while unlocking the account suggestions. Instead, the flow changes to: 1. Store the popup state 2. Close the popup 3. Complete the reauth required for the unlocking 4. Reopen the popup from the stored state 5. Pin the popup so it waits for _potential_ updates Screencast in the linked bug. TBR=boliu@chromium.org,noyau@chromium.org TBR Reason: This change wraps the parameters for ShowAutofillPopup into a data object. It hides unused parameters but doesn't change anything on non-Desktop platforms. Bug: 1086170 Change-Id: I8220ca4fe1d57840c95dc2ee7bdf5f15f931f03c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214391Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#772177}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I53e24ce80afe150ddaffe569537fd0cabdd7eed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215862Reviewed-by:
-
Stephan Hartmann authored
Move assigment operator in ui::ColorSet is noexcept. Because this class has a member of type base::flat_map, move assignment operators of base::flat_map and base::flat_tree must be noexcept too. base::flat_tree noexcept is conditional to avoid build failure with NaCl. Otherwise GCC fails like this: ../../ui/color/color_set.cc:14:11: error: function 'ui::ColorSet& ui::ColorSet::operator=(ui::ColorSet&&)' defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification '' 14 | ColorSet& ColorSet::operator=(ColorSet&&) noexcept = default; | ^~~~~~~~ Bug: 819294 Change-Id: I10ce31851effc9ce78f2b5cbbb7148c339f065a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179245 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#772175}
-
arthursonzogni authored
A DumpWithoutCrashing was added in CheckSandboxFlags. I suspected computing the sandbox flags from the browser process won't work on the first time, despite passing all the tests. It turns out this doesn't always work. The reason is unknown yet. The DumpWithoutCrashing() is triggered a lot. This patch removes it for now. TBR=mkwst@chromium.org BUG=1086734 Change-Id: I08497d51f80c1e9ffb3a37b64b6227fb01e2330c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217553Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#772174}
-
Rouslan Solomakhin authored
Before this patch, C++ payment app implementations used an enum to denote their type to be used for app-specific logic, while Java used "instanceof". This prevented encapsulating multiple types of payment apps in a single wrapper, e.g., service_worker_payment_app.cc and android_payment_app.cc in a single JniPaymentApp.java wrapper. This patch expands the number of payment apps, exposes the payment app enum to Java, adds the type enum to PaymentApp.java class, and replaces "instanceof" with enum comparison in PaymentRequestImpl.java, where it makes sense. After this patch, both C++ and Java payment app types are defined in an enum, so JniPaymentApp.java can wrap multiple types of C++ payment apps internally. Design: https://bit.ly/cross-platform-pay-app-factory Bug: 1022512 Change-Id: I3636f83cda85c29113ad6bd0671b430c70c67a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213405 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#772173}
-
Victor Hugo Vianna Silva authored
Bug: None Change-Id: I4382aa74e2c1de1f4186590bf35865491ad2e5c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214554 Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#772172}
-
Javier Ernesto Flores Robles authored
Updating preferred ContentSize inside updateViewConstraints was causing the popover arrow to not be pointing to the right place. Instead update the preferred size when the trait collection changes and before the view appears. There is still a bit offset when the bar button is bigger than the popover arrow and the button is on the screen margin. This is caused by the popover being also layout at the margin without space to center the arrow. Bug: N/A Change-Id: I10017b379c7688bea2cd6e514d0bf98a176c9c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215332Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c1f72606..09f5f6d7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2baaa5c5c1b6f04a42e9c464b4108df530499c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215920Reviewed-by:
-
Anders Hartvoll Ruud authored
There's currently a bug where a transition on an element with appearance can cause these flags to disappear. This is because the cascade is applied (in full) _twice_ for style resolves where the base computed style optimization is not in use: the first apply produces the base computed style, and the second apply is the same as the first apply, except that it also includes animation effects. The problem is that the second apply can reset the flags if there's a transition (for example) for the property or properties to be set in the first apply round. For example, assume there's a regular declaration background-color:green. This causes HasAuthorBackground to be set after the first apply round. Then, in the second apply round, if there's an animation effect on background-color, then CascadeResolver::AuthorFlags will not have kBackground set, since transitions are not author declarations, and therefore the flag will be set back to false. Instead this CL makes the flags monotonic, such that we're not overwriting the flags later. This fixes a regression where artifacts are shown when transitioning UI elements. Note that it may seem weird that transition/animation declarations don't count as author declarations in this context, but this was done to match the old Blink behavior where transitions/animations also had no effect on the flags. Note also that the now-removed logic regarding Find/Reject/etc. in the if-statement is no longer needed. It was there because forced colors mode used a separate StyleCascade instance previously, which made matters a bit more complicated. However, this has since been changed, so the logic can be simplified. Bug: 1086732 Change-Id: I6e588a7e1d6805ab0a59a9a92bec0eb26e7120eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214552Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#772169}
-
Yoshifumi Inoue authored
This patch changes "drag-selected-image-to-contenteditable.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: If75f018f18e30b392c8837c52f26ed267c17c5df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195861 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#772168}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590537495-1aec0e09840eb111f0a85749393637fa50872c10.profdata to chrome-win32-master-1590566295-b6fe751361b0ee5373100e3cddc0b82fdbd8c8ba.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I814b2b36b3e20eb5194dff1e905a1ed4f0f6bda8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216921Reviewed-by:
-
Omer Katz authored
These objects were never marked as fully constructed. Bug: 986235 Change-Id: Ia71abf4f8c118df29ccbd1e008d3ac484bdd6668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212162Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#772166}
-
Takuto Ikuta authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/7e8636295f47..90c5e17a8261 $ git log 7e8636295..90c5e17a8 --date=short --no-merges --format='%ad %ae %s' 2020-05-27 tikuta client: update cacert.pem 2020-05-21 tikuta client: update isolated client 2020-05-20 yekuang Cleanup: use assertNotIn instead of assertFalse 2020-05-20 yekuang Add @maybe_inject_user_agent decorator for the HTTP engines 2020-05-20 tikuta client: update isolated client Created with: roll-dep src/tools/swarming_client Bug: 944944 Change-Id: Ibacf839f4249b9aeabeda58ce4774fbd62e89373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216106 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Cr-Commit-Position: refs/heads/master@{#772165}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I6588232fe0a6e6d33a245fae9edf2598db34f950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215660Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#772164}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590551922-893b4e02197be5d53e80dcc9648783993fdfcda3.profdata to chrome-mac-master-1590566295-92309f25158961ce5d340e659f77e189eb24879f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I3e5a5db88312f2a7d7c253bb1f9a13446ae935dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217463Reviewed-by:
-
Rijubrata Bhaumik authored
base/run_loop.h is only used in the test files, so use specific_include_rules in the DEPS accordingly. + some nits Bug: 897297 Change-Id: Ied0079aa6369c6b458e725a07458050ba8761588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214894Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#772162}
-
