- 29 Jul, 2020 40 commits
-
-
Etienne Bergeron authored
This CL is fixing the trace events of the HandleVerifier for a non components build. For a static build, there are two instances of the HandleVerifier 1) chrome.exe!HandleVerifier 2) chrome.dll!HandleVerifier At chrome startup, chrome.exe!InstallVerifier set a global singleton which start tracking ScopedHandle objects. After the initialisation, chrome.dll is loaded. The call of chrome.dll::InstallVerifier() is fetching the singleton from 1) and is storing it as a global singleton into chrome.dll. Calls to the chrome.dll!VerifierTraits::StartTracking() and chrome.dll!VerifierTraits::StopTracking are forwarded to the chrome.exe!HandleVerifier instance. Since TraceLog is also part of base, there is also two instances in each module. There are two instances of categories array that specify which categories are enabled but only one is used by chrome tracing. A trace event executed in chrome.exe will never be enabled. This is explaining why trace events from chrome.exe!HandleVerifier are not emitted unless the build is a component build. To solve this issue, this CL is lifting the trace events before entering the code that forward the call to chrome.exe. This way trace events are using the right instance of TraceLog (e.g. chrome.dll). Bug: 1110507 Change-Id: I61ee1e18b849d32f90d2430759da6d1c8666c854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324873 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#792764}
-
Ella Ge authored
When a violation occurs with the flag on, the TWA will run the callback to the client app to "crash" (client app should throw a RuntimeException) If the client app knows how to handle the crash message, finish the activity. Bug: 1109609 Change-Id: I30c50861f80bee11f917a447800a3687f521fc73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318532 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#792763}
-
Guillaume Jenkins authored
This reverts commit 21497283. Reason for revert: It seems the timeouts are still happening, see the builder page here: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests Original change's description: > Re-enable the RightClickMenuShowsCopyUrl test on mac. > > Test timeout on CQ seems to have mysteriously fixed itself. > > Bug:988323 > Fixed:988323 > > Change-Id: Ia96d8a687bc161cf74f67fbf819ffaf7bb896755 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325330 > Auto-Submit: Glen Robertson <glenrob@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792705} TBR=estade@chromium.org,glenrob@chromium.org Change-Id: I5de2c6b986703f81b43977072951f1923ce3bb8f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 988323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326733Reviewed-by:
Guillaume Jenkins <gujen@google.com> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#792762}
-
Lan Wei authored
Since we will not use this experimental feature to transfer user activation through post message to autoplay videos in a cross-origin subframe without any user activation. We will delete the transfer_user_activation function from all the transferable message classes, which indicated whether we want to transfer user activation through post message. We will also clean up the frame interfaces in browser/renderer in a follow-up CLs. Bug: 1067307 Change-Id: Iaa969632cb4132993512b28db97d648d6abffdc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295984Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#792761}
-
Mohamed Amir Yosef authored
This is one step in the process of injecting only the required dependencies to HttpPasswordStoreMigrator instead of the whole client. The objective of this refactoring is to make HttpPasswordStoreMigrator Butter-compatible. Bug: 1107741 Change-Id: Ieecfa4b8c79cbc1890f0d1c9aa1d413f031af4f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315034Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#792760}
-
Ewann authored
This CL fixes some style issue related to context menu. Bug: 1093302 Change-Id: I53966504a431b9545c4d79ebaf6bbbdfdda77d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325615 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#792759}
-
Ella Ge authored
This CL adds the TWA quality enforcement on 404 pages. When the page is in scope(verified origin) is 404, it will show a toast and run a CustomTabsCallback to notify the client app the issue. This CL also changes one of the test pages in TrustedWebActivityTest. The test was 404 because the test file is not included in the chrome_public_test_apk package in chrome/android/BUILD.gn. So change to another similar test page. Bug: 1109609 Change-Id: I2dff19f115a4efc9f42c9acf7663a0b8988bf4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311010 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
The test is flaky. Bug: 1110048, 1110890 Change-Id: I1a0613d4f33df0f22472733e8238f6c16b507714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324849 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Avi Drissman authored
Bug: 1105907 Change-Id: I509290b67e64369e63a076097a8095347d38a957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324175 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#792756}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I28cd4d958b4767b052c2821ec1032beb09579b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324899 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#792755}
-
vidorteg authored
This change will introduce a new initial module (i18n): https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2309709 We need to disable this test to land the mentioned change and then reenable the test. Change-Id: I49253181104afe38ec2cebfbec4f54c7f79a1b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324492 Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#792754}
-
Rakib M. Hasan authored
It will be easier to automate updating weblayer versions tested for skew in variants.pyl than in test_suites.pyl. Ignore-CQ-Freeze: Only affects CI and optional try jobs Bug: 1041619 Change-Id: I09a288ffc0dfacb6002aa7a694d9be98585e0323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316411 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#792753}
-
Maksim Sadym authored
Bug: 1090802 Change-Id: I407f0dee4271797c9524f574b7fd311f02de850c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317956Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Maksim Sadym <sadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#792752}
-
Mohamed Amir Yosef authored
in FilterDuplicates() for better clarity. No behavioral change is introduced. Bug: 1093286 Change-Id: I07cfa7a0c7403920d5af163fdae562f33a73accd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325617Reviewed-by:
-
Manas Verma authored
Ensuring that neither autofill_manager nor client is null when creating InternalAuthenticator instance. If either is null, then return nullptr (which is already gracefully handled). Bug: 949269 Change-Id: I217b7c2766675c5cae7a632acd0db16b1a287b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324116Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#792750}
-
Xiyuan Xia authored
Add StartDataCollection/StopDataCollection to start/stop gathering the data reported by ui::ThroughputTracker. The API will be used by tast tests via AutotestPrivateAPI to calculate animation frame rate sub score. Bug: 1098555 Change-Id: I1e871fd6575f54101bbe701d42960d5259b749e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305013 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#792749}
-
Avi Drissman authored
As Blink isn't used on iOS, OS_MAC more correctly captures the intent of the old OS_MACOSX. Bug: 1105907 Change-Id: I662ff61f1fe3ec7cf9f63b303632310fde149b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324864Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792748}
-
Luke Zielinski authored
c086a216. It also fixes the names of the tests to reflect their new location Bug: 1110003 Change-Id: I5fb544769396e79fe9bd98bcb49738b4f72a80f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326210 Auto-Submit: Luke Z <lpz@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#792747}
-
Ben Pastene authored
I'm having a tough time finding context behind the "pyelftools" dependency. It might no longer be relevant, in which case we could restrict chromite to only CrOS checkouts. Worth a shot. Bug: 937821 Change-Id: I96ae00a272390042b466ae50defb18e9bf3eafc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323823 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#792746}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I48aa3d9629494bb584abd98a6194aa6776b43afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326300Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792745}
-
Alex Butzier authored
BUG=b:160351836 TEST=Built Chrome OS and tested a few domains and they worked. Change-Id: Ife4a37f27692dc9deaff6a1933f17162b35f3d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314029Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Auto-Submit: Alex Butzier <abutzier@google.com> Cr-Commit-Position: refs/heads/master@{#792744}
-
Arno Renevier authored
There can be multiple wrappers around the same C++ object (See https://drive.google.com/file/d/0B1obCOyvTnPKQmJEWkVtOEN2TmM/view) So when visiting the heap, it's possible that the same traceable ends up being visited twice. If that's the case, we return early from VisitPersistentHandleInternal BUG: 1110463 Change-Id: I51b0cea26d142b2d043b44f17c1342563a7ebcee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324888Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Arnaud Renevier <arenevier@fb.com> Cr-Commit-Position: refs/heads/master@{#792743}
-
Michael van Ouwerkerk authored
Change-Id: I190c05f6636c5b6f4b16f0d70885a38e5baf5f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324250Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#792742}
-
Daniel Murphy authored
Disables the legacy finalizer (extensions sync) on all profiles before starting any sync tests. This should deflake everything but the app ordinal test. This also does an experimental change to UninstallSynced, where instead of using the helper methods for listeining, it manually pre-creates the listener. If this is successful in deflaking this test, and the others continue to flake with timeouts, that means that there is a race between the observer and the install/uninstall, and the helper methods need to be removed. R=loyso@chromium.org, phillis@chromium.org Bug: 1108172,1091867,1099847 Change-Id: I9b3792ece3ddeacb1adb518085c2df6a160f8bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323703 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#792741}
-
Aya ElAttar authored
Changed PolicyMap::Set to the newer version to pass value as base::value instead of unique_ptr. Bug: 1092469 Change-Id: I588b042406a1d3de5ca49f60b1b98ce896a5db83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320788Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iebf8823d4c000b7ad2ad2400b79046191656d321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325763Reviewed-by:
-
Alex Ilin authored
The account picker isn't supposed to be shown to single-profile users. This change would also make it easier to write browser tests that enable the features::kNewProfilePicker flag, since they will land directly in the browser. Bug: 1063856 Change-Id: Id947d21686503bb068d4ce7b83c2f88889b064ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324847Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792738}
-
Eugene But authored
According to Session.WebStates.NavigationItem.SerializedURLSize and Session.WebStates.NavigationItem.SerializedReferrerURLSize histograms stored URLs might be very long, which can have negative impact on stability. InvalidUrlTabHelper will not allow navigations to URLs longer than kMaxURLChars, so there is no point in storing navigation items with such long URLs. InvalidUrlTabHelper depends on UseJSForErrorPage flag and will be enabled some time this fall. Bug: 1082279 Change-Id: I2839bc6fbe8a1335c710e6afe28352f0f886698b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324724Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#792737}
-
Dave Tapuska authored
Part of progressively moving SynchronizeVisualProperties into WidgetBase. This change moves zoom handling into blink. When the browser sends an UpdateVisualProperties the call sequence used to be: WidgetBase::UpdateVisualProperties -> WidgetBaseClient::UpdateVisualProperties -> WebFrameWidgetBase::UpdateVisualProperties -> WidgetClient::UpdateVisualProperties -> RenderWidget::UpdateVisualProperties -> RenderFrameImpl::SetZoomLevelOnRenderView -> RenderViewImpl::SetZoomLevel -> WebViewImpl::SetZoomLevel With this change the sequence is: WidgetBase::UpdateVisualProperties -> WidgetBaseClient::UpdateVisualProperties -> WebFrameWidgetBase::UpdateVisualProperties -> WebViewImpl::SetZoomLevel Notification of RenderFrameProxies (which are RemoteFrameClients) is moved into blink. Previously it would iterate the observer list and tell each RenderFrameProxy under the RenderWidget in the frame tree about the adjusted zoom level. Instead of a observer list we iterate the frame tree directly starting at the local root for the widget. BUG=1097816 Change-Id: If4918e49c157dfa80ad7bd648d72fa67e8e54b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311118 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Will Cassella authored
PlatformVerificationFlow::ChallengeCallback was previously unspecified as to whether it was a base::OnceCallback or base::RepeatingCallback (base::Callback aliases base::RepeatingCallback and should not be used). Since it's really a base::OnceCallback, this CL changes it to be that and adjusts the surrounding code appropriately. Bug: 1007635 Change-Id: Idf531ef4e2048cc31ed4d6ce15559dd3543725f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321793Reviewed-by:
-
phillis authored
This moves AppshortcutManager::DeleteSharedAppShims to OsIntegrationManager and also removes observing of |OnWebAppProfileWillBeDeleted| from shortcut manager and filehandler manager, instead makes registrar call |OsIntegrationManager::UnisntallOsHooks| on profile being deleted. Bug: 1098027 Change-Id: I629126d7661e2fdbbaff8645a46382d59c93dca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320997Reviewed-by:
-
Evan Stade authored
DisplayCutoutController is moved to //components. Fixed: 1095714 Change-Id: I3994afeecaa9d555514b571727da8d0efae2a55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309036Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#792733}
-
Avi Drissman authored
Bug: 1105907 Change-Id: If14ea9353e4698482d5bc45304277e39dc4b59bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324950Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792732}
-
Tommy Li authored
This CL updates SearchSuggestionParser to look for and parse the "h" sublist under the "google:headertexts" metadata. The "h" sublist is used to populate the vector of group IDs that should be hidden by default. Only integers are accepted out of the list. All non-integers are discarded. Bug: 1106096 Change-Id: Iffad7c7a08f09d18abd027c5c7ccec5b4043da82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324890Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#792731}
-
Yuke Liao authored
This CL makes two changes: 1. Make use_xvfb imply use_ash_chrome. 2. Mark test targets to use xvfb and ash_chrome if needed. Bug: 1104318 Change-Id: I7128b31b83e2389e92e5507093396aaf537dfdf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324765Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#792730}
-
Avi Drissman authored
This migrates: defined(OS_MACOSX) -> defined(OS_APPLE) defined(OS_MACOSX) && !defined(OS_IOS) -> defined(OS_MAC) !defined(OS_MACOSX) || defined(OS_IOS) -> !defined(OS_MAC) Bug: 1105907 Change-Id: I0590b7f22dd27637d7220ba4a09837421457638f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321508Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792729}
-
Peter Wen authored
Lint is no longer implicitly run as part of an apk or bundle target. If a specific apk or bundle wants to turn on its own lint and have that run automatically on every build, the enable_lint flag can be used. See: "boundary_interface_example_apk". A new target //chrome/android:android_lint (or simply "android_lint") has been added. This currently runs either monochrome_public_bundle's lint task or a list of default targets if such a list is defined. For chrome apk/bundle targets based on chrome_public_apk_tmpl.gni, they will automatically get a data_dep added on the new unified lint target so most devs' workflow will not need to change. APKs in for {remoting,cronet,cast} have enable_lint added explicitly in this CL to preserve their existing behaviour. NewApi and VisibleForTests checks have been disabled for test apks, with a TODO for turning at least NewApi back on. Bug: 1108791 Fixed: 1108791 Change-Id: I6534fcd6dc7af1d7a12720a98f8d0d09bee8f161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318549 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#792728}
-
yilkal authored
This cl sets "playStoreMode" policy to restrict child user from toggling Play Store account. This cl updates "applications" policy's value for playStore to also restrict the child user from toggling Play Store account. Both values have to be set because there is a race condition that exists between the two policies. The policies are updated from the client side and not from the server side because the client has enough information to set the values. In addition, sending the additional policy values from the server will unnecessarily incur bandwidth costs overtime (few bytes sent per policy update per child adds up overtime). Test: The CL has Unit tests to cover the changes. It has also been manually tested on device. Bug: 1106901 Change-Id: I56d95d955c8fe54b84ea7c94cabea302d7d8378f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304996Reviewed-by:
Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#792727}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 34d4eecd. With Chromium commits locally applied on WPT: 3bd086b0 "Make CSP default-src without 'unsafe-eval' block eval in iframes" 6d63b58a "Split iceGatheringState tests into separate files & update expectations" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I4867302416bb1c698c14486e55dbf9653ea49ae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324147Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792726}
-
Jonathan Ross authored
This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2321334 The test is falling across multiple configurations. Extending the scope of the expectation to be all Win NVidia Passthrough tests until it can be updated. TBR=ynovikov@chromium.org TEST=conformance/glsl/misc/shader-with-non-reserved-words.html Bug:1109977 Change-Id: I8ba716410799ba3fe149f22a055918931f1af093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326090 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#792725}
-
