GitLab

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9fe571c9..2239a88c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I5519d637acb60a4db87304ce5f402f8ce23e0100
Reviewed-on: https://chromium-review.googlesource.com/962344Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543081}

BUG=817286
TEST=perf bot falls back to D3D9
R=geofflang@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Icd19277b6074178be8e26312be20ec02dd0b01c0
Reviewed-on: https://chromium-review.googlesource.com/961489Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543080}

There was a crash in debug if you use calc()
mixing fixed and percentage values due to the wrong DCHECK
in GapLength constructor. The patch fixes this assert.

In addition LayoutGrid::GridGap() was also wrong and didn't consider
calc() either. The fix is again easy just using the proper check.

Regarding testing, the parsing tests have been updated to include
this combination of fixed and percentage values in calc().
At the same time, the patch actually uses "grid-" prefixed properties
in the tests that were supposed to test those.
Last, two new tests are added to verify the proper behavior of calc()
with mixed values on a grid layout container.

BUG=816300
TEST=external/wpt/css/css-align/gaps/column-gap-parsing-001.html
TEST=external/wpt/css/css-align/gaps/gap-parsing-001.html
TEST=external/wpt/css/css-align/gaps/grid-column-gap-parsing-001.html
TEST=external/wpt/css/css-align/gaps/grid-gap-parsing-001.html
TEST=external/wpt/css/css-align/gaps/grid-row-gap-parsing-001.html
TEST=external/wpt/css/css-align/gaps/row-gap-parsing-001.html
TEST=external/wpt/css/css-grid/alignment/grid-gutters-011.html
TEST=external/wpt/css/css-grid/alignment/grid-gutters-012.html

Change-Id: I4c9fe6b2525a253c6bb00cbda727c2bf1ae6e90b
Reviewed-on: https://chromium-review.googlesource.com/962148
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Reviewed-by: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#543079}

Fix errorprone StaticGuardedByInstance warnings and make
sure it is treated as error after this CL.

http://errorprone.info/bugpattern/StaticGuardedByInstance

Bug: 803625
Change-Id: Ica786979670c8ec58c07691122e225acc56e62df
Reviewed-on: https://chromium-review.googlesource.com/961041
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543078}

Due to historical reasons scheduler uses Chromium code style instead of
Blink one. Before patch 954622 it was enforced by scheduler using
camel_case for file names.

This patch restores the exception after the said patch started to apply
webkit style checks to camel_case filenames.

TBR=dcheng@chromium.org,tkent@chromium.org

Change-Id: I7c81e7e1dfcca264f1491529c28659b6e90a3f37
Reviewed-on: https://chromium-review.googlesource.com/962422Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543077}

The 'sourceSets' block adds '{' symbol without any conditions. But related '}' symbol is added under some 'if' statement. So there is set of input params with which 'generate_gradle.py' doesn't closes 'sourceSets'.
The solution is moving '}' under conditions.

R=agrieve@chromium.org

Change-Id: I82a3998cf9e4c06b43eefa43400d084fa3a6d833
Reviewed-on: https://chromium-review.googlesource.com/962445Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543076}

This is mainly for taking performance improvement of jinja2.
http://jinja.pocoo.org/docs/2.10/changelog/#version-2-10

Manually edited files:
  README.chromium
  get_jinja2.sh

And I regenerate build/android/test_runner.pydeps

* For the record,
With Jinja 2.10, running time of idl_compiler for generate_bindings_core_v8_interfaces is like below on Z840 Linux.
5.050s
4.945s
5.077s

With Jinja 2.8, running time of idl_compiler for generate_bindings_core_v8_interfaces is like below on Z840 Linux.
6.675s
6.575s
6.574s

Bug: 821256
Change-Id: I127e3db94edb22e3ac22a3662872d99b4b91c2a8
Reviewed-on: https://chromium-review.googlesource.com/917930Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@google.com>
Cr-Commit-Position: refs/heads/master@{#543075}

Using wpt-import in Chromium 7f9a64d3.
With Chromium commits locally applied on WPT:
ad9cc156 "Add WPT tests for feature policy frame policy"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13840

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
kojii@chromium.org:
  external/wpt/css/css-text/line-break

TBR=leon.han@intel.com

No-Export: true
Change-Id: I75a7369414f6594b2fb3bb9cdd0a4a031d13391c
Reviewed-on: https://chromium-review.googlesource.com/962343
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543074}

mojom generator uses jinja2 template.
If we update jinja2 library, jinja2 may update api/internal structure.
In such case, all mojom generator using jinja2 may need to re-run.

I added jinja2_sources for such case and use it as inputs dependency for mojom generator action.
It is recommended by gn.
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/reference.md#target-declarations-action_declare-a-target-that-runs-a-script-a-single-time-inputs

* Minor fix
Update README.chromium to pass current presubmit check.

Change-Id: I8b7f126c3a807ac211db01c90437d584c9c39f85
Reviewed-on: https://chromium-review.googlesource.com/961763Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@google.com>
Cr-Commit-Position: refs/heads/master@{#543073}

Code in //ui/ozone/platform/wayland/fake_server.cc|h is quite
convoluted today. This a 3/n of a series of patches that clean it up.

Particularly, CL changes the wayland unittest's code to use the "bleh_"
terminology rather than "bleh" for class member declaration, as per
Chromium's coding style.

BUG=None
TBR=rjkroege@chromium.org

Change-Id: I3534937d2ed842b0723e622f39668d4ac6c557c0
Reviewed-on: https://chromium-review.googlesource.com/961143
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#543072}

Pass the flag to the renderer and have the renderer pass the setting
down as a context attribute. This keeps the client and service side of
the command buffer in sync (e.g. use RasterImplementation with
RasterDecoder and GLES2Implementation with GLES2Decoder).

I've kept the GpuPreference plumbing from browser to GPU process in
place so that a compromised renderer cannot unilaterally turn on the
RasterDecoder.

Bug: 789238
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ia8923f1adfe41495d818d83b3ff6c9c0e62f255c
Reviewed-on: https://chromium-review.googlesource.com/952080
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543071}

Change-Id: Idfb16f09178adcd7399601d035870b51bacef84c
Reviewed-on: https://chromium-review.googlesource.com/962143Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543070}

TBR=tedchoc@chromium.org

Bug: 821750
Change-Id: I81595ac2b47961a2e5112a119b686ec9f09c6b55
Reviewed-on: https://chromium-review.googlesource.com/962443Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543069}

Normally, sinks are stopped when they are removed from the sink cache,
but unhealthy sinks aren't cached, so we must make sure they are
stopped before deletion.

Bug: 819277
Change-Id: I76724e21bc0f129edb03ff109b093faecfa04861
Reviewed-on: https://chromium-review.googlesource.com/962124
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543068}

https://webrtc.googlesource.com/src.git/+log/e63afff36496..31a12c557dcd

$ git log e63afff36..31a12c557 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=None,None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I8c0d39963bc29a0d4aabf6774b5747bcd6ce6f15
Reviewed-on: https://chromium-review.googlesource.com/962341
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543067}

This ensures that SafeBrowsing reports from Android are complete.
Right now, those reports only contain data about the top-level page
but nothing from subframes. ThreatDOMDetails is responsible for
capturing data from the subframes.

Bug: 811567
Change-Id: I540574b41e646b79805ef3d3166d49e386daf803
Reviewed-on: https://chromium-review.googlesource.com/959381Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543066}

The LayoutBox associated with a block node will *normally* be the
containing block (on the legacy side) of its children (on the NG side),
but this isn't an invariant. Multicol and list item markers are
two examples.

Remove the kembo DCHECK, since it seems impossible to come up with a
complete list of exceptions to the rule (that the node's box should be
the containing block of the child nodes' boxes). Instead always get the
right containing block from legacy layout. Don't use that of the node.

With the DCHECK removed, a lot of tests stop crashing, and some just
start passing instead. One known effect of this change is that floats
that are direct children of multicol containers are painted correctly.
They used to be added to the float list of the multicol container,
rather than that of the flow thread, which caused two problems: paint
order (regular blocks got painted on top of them), and that they
appeared unfragmented (they just overflowed the multicol container
instead). Added a test for that.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I1ee926c39fbedfd52d87e9cf790996909914efb2
Reviewed-on: https://chromium-review.googlesource.com/960027
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543065}

This CL adds TCP socket API to network service.
This is partly based on mandoline implementation
(https://codereview.chromium.org/1873463003/)

Two TCP socket interfaces are added.
- TCPConnectedSocket
- TCPServerSocket

Change in reland:
- adds logging to TCPSocketTest.ReadAndWriteMultiple to investigate
  the test timeout observed in crbug.com/821232
- Modifies TestServer slightly to own all client connections instead
  of only the latest one.

R=mmenke@chromium.org
TBR=miu@chromium.org
TBR=tsepez@chromium.org

Bug: 721401
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I0426a7aeda30cce7a2a1e84afae5208958dc4a10
Reviewed-on: https://chromium-review.googlesource.com/960250
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543064}

The window selector gets names from Aura windows. Propagate titles from
app names to the aura window titles, as the web content itself may not
have a title.

This is split out from the CL to test all widgets and views for
nameless focusable objects. See crrev.com/c/951933.

Bug: 819350
Change-Id: Id61d9398824b836a644c57813f1521faf1aae70f
Reviewed-on: https://chromium-review.googlesource.com/961093Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543063}

Previously popup bubbles remain with insufficient state after the shelf
position is changed. This CL adds the code to explicitly recreate bubbles
so that it works correctly even after the shelf position is updated.

Bug: 820400
Test: manual test (checked the repro steps in the issue)
Change-Id: I7c196614c2a148eda53650cae145b544af9bbded
Reviewed-on: https://chromium-review.googlesource.com/960681Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543062}

To have the correct behavior when a submenu
is opened via a HoverButton, the HoverButton
class is transformed into a subclass of
MenuButton.

HoverButton can now function as both, a normal
button and a menu button.

Visible changes in the user menu:
 - When the submenu is opened, the button stays
 highlighted.
 - When the submenu closes, the button loses its
 highlighting.

Video from before:
https://drive.google.com/file/d/1QONj3SZv-zAwQ2r7WqF4Ww7UKo0wVcJ2/view?usp=sharing
Video from after:
https://drive.google.com/file/d/1dwh_68A0cjiK2kiPnHwCvSdQX6RByVY5/view?usp=sharing

Bug: 814809
Change-Id: I6401cb39d20fca9c3590a67bd0fbeff5a2043b83
Reviewed-on: https://chromium-review.googlesource.com/953623Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543061}

Having WebRtcEventLogManager in content/ produces some issues:
1. JS hooks leading to it need to go through WebRtcLoggingHandlerHost,
   which lives in chrome/browser/media/webrtc/, from which there is
   no access to content/.
2. The code for chrome://webrtc-logs/ is accessible from chrome/, but
   not from content/.
3. Uploading is easier and more natural from chrome/, where
   g_browser_process->system_request_context() is available for
   the URLFetcher.

To make this change possible, it was necessary to extend
TestingProfileManager to also allow the directory for the profiles
to be set by the user of the class, so as to support unit tests
relating to handling of files from previous Chrome sessions.

Follow-up work to be done by future CLs:
* While in content/, the context within which files and tabs lived
  was the BrowserContext. Having moved to chrome/, Profile (which
  inherits from BrowserContext) is a more natural entity to focus on.

Bug: 775415
Change-Id: I9c9617fbd9cd597223721bb74fbfdb258a846cce
Reviewed-on: https://chromium-review.googlesource.com/955653
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543060}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e704dea0..9fe571c9

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I4c529faa1db2aa294ba85008fa92a28830efb975
Reviewed-on: https://chromium-review.googlesource.com/961348Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543059}

The test is still crashing on linux_chromium_rel_ng and blocking WPT
imports:
* https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/45486
* https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/45507
* https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/45582
* https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/45602
* https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/45638
* https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/45651
* https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/45722

TBR=lukasza,leon.han@intel.com

Bug: 801992
Change-Id: Ie51d1c04d9ed23ff7aeea1a4f3e485ab97acd3bc
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/962146Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#543058}

Using wpt-import in Chromium d8206c55.
With Chromium commits locally applied on WPT:
ad9cc156 "Add WPT tests for feature policy frame policy"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13838

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
domenic@chromium.org, ricea@chromium.org:
  external/wpt/streams
jsbell@chromium.org:
  external/wpt/encoding

TBR=leon.han@intel.com

No-Export: true
Change-Id: I8e0d5cc349664f81db088e3f201af475d2811a0e
Reviewed-on: https://chromium-review.googlesource.com/961903
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543057}

https://chromium.googlesource.com/catapult.git/+log/7b53f088f8e8..f73167a6894a

$ git log 7b53f088f..f73167a68 --date=short --no-merges --format='%ad %ae %s'
2018-03-13 mythria Ignore i-frame navigationStart events when computing LoadExpectation

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Ia5bf0114b5db0de84b728867560e78c0e6f69e9d
Reviewed-on: https://chromium-review.googlesource.com/961284Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543056}

Just a simple copy/paste error, I'm afraid.

Intent to Experiment: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/3MYKIKqyaNA

Bug: chromium:776327
Change-Id: I07191b2c1c4a3c3eff69d9b4a5abd604ee6ba01a
Reviewed-on: https://chromium-review.googlesource.com/958906Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543055}

A few tests have started to pass.

newmulticol/unresolvable-percent-max-height-2.html because of
https://chromium-review.googlesource.com/c/chromium/src/+/960085

The rest because of
https://chromium-review.googlesource.com/c/chromium/src/+/960403

TBR=kojii@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I48694ad07ab78550068950982d40f9e80de60d4a
Reviewed-on: https://chromium-review.googlesource.com/962003
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543054}

See https://crbug.com/820959 for more informations.
This CL temporarily disable
BrowserSideNavigationBaseBrowserTest.CancelRequestAfterReadyToCommit on
Windows with NavigationMojoResponse.

Bug: 820959
Change-Id: I2b7f774baf161275834ae969532fa5abef292043
Reviewed-on: https://chromium-review.googlesource.com/958904Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543053}

Previously, setVirtualTimePolicy was always returning a zero virtual
time base when wait_for_navigation was set. This meant, even if virtual
time was enabled before, the client's known virtual time base could be
overridden with an invalid one. Instead, return the previously
initialized virtual time base when it is known, even if
wait_for_navigation is set.

Change-Id: I391232f7310b81c4fc3b033e7ba4c186b32560d3
Reviewed-on: https://chromium-review.googlesource.com/960761
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543052}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2e73d43870dd..1c9c003404cd

$ git log 2e73d4387..1c9c00340 --date=short --no-merges --format='%ad %ae %s'
2018-03-14 iannucci [led] Bump to support CIPD Recipes.

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I5f15a257ad83d83b8e823253e3a3881c82d2c3aa
Reviewed-on: https://chromium-review.googlesource.com/961904Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543051}

Make text-size-adjust animatable, as it is supposed be so according to:
drafts.csswg.org/css-size-adjust/#adjustment-control

R=nainar@chromium.org, shend@chromium.org, smcgruer@chromium.org

Bug: 818526
Change-Id: I0c3b98c4726f6898599aa5626ad2fec876057ec0
Reviewed-on: https://chromium-review.googlesource.com/956462Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543050}

This patch reviewed failures of wpt/css/css-text, grouped and
sorted, with following modifications:

1. Skip importing features with no active contributors.
   When we have plans or contributors, we can unskip them.

2. Following tests were removed because they are based on
   old versions of Unicode. According to the most recent
   spec at:
https://www.unicode.org/Public/UNIDATA/extracted/DerivedLineBreak.txt
css3-text-line-break-opclns-013 U+23B4 is AL, not CL
css3-text-line-break-opclns-048 U+FD3E is CL, not OP
css3-text-line-break-opclns-118 U+23B5 is AL, not CL
css3-text-line-break-opclns-154 U+FD3F is OP, not CL
css3-text-line-break-opclns-216 U+30FC is CJ, not NS
css3-text-line-break-opclns-224 U+FF70 is CJ, not NS

3. Following tests were removed because they hard code pixel
   widths, and their cases are covered by other tests.
word-break-normal-002

4. Following tests were removed because they are based on JLREQ,
   a W3C notes that explains traditional Japanese typography, but
   not defined in the CSS spec nor in Unicode spec.
line-break-normal-025
line-break-strict-018a
line-break-strict-018b

Bug: 817781, 817778, 817776
Change-Id: I92b1abc99fa8019e5d514e485f6c4733075216ba
Reviewed-on: https://chromium-review.googlesource.com/960683Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543049}

Make Zip Archiver to forget password when requested to resume, as well
as returning error to make VolumeManager remove the persisted provided
volume info.
Remove all code for persisting zip mount state.

Bug: 789073,803752
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Icb9a6e9ca04b7ed633480a17973d1dcb126d02e0
Reviewed-on: https://chromium-review.googlesource.com/940742
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543048}

This CL fixes the highlighting behavior of
HoverButton by turning on highlight on focus.

Bug: 821354
Change-Id: I3d89aa1febd2dc1cd4e82d2291983eb09e7fbab4
Reviewed-on: https://chromium-review.googlesource.com/960024
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543047}

We had a TODO in IndefiniteSizeStrategy::MinLogicalWidthForChild()
that was always using 0 as margin of the item.
The patch just changes that for a call
to GridLayoutUtils::MarginLogicalWidthForChild()
(like we do in the DefiniteSizeStrategy version).

BUG=816762
TEST=external/wpt/css/css-grid/grid-items/grid-items-minimum-width-001.html
TEST=external/wpt/css/css-grid/grid-items/grid-items-minimum-width-002.html

Change-Id: I743584aff234625f2d00327c711c0577ffeab457
Reviewed-on: https://chromium-review.googlesource.com/955062
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#543046}

A switch is added to clang tool calls from traffic annotation auditor,
to ignore constant comparisons.
Some tests compare constants to prevent future regressions, but clang
sees these as unnecessary comparisons and issues error.

Bug: 690323
Change-Id: Iaa194641f2d6a8cd66ae61f514703bccc28967da
Reviewed-on: https://chromium-review.googlesource.com/958518
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543045}

For determinism of animated gifs, set kDisableImageAnimationResync.

Change-Id: Ia609396083534935f0c36d9b7328b50bfc164f8d
Reviewed-on: https://chromium-review.googlesource.com/962122Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543044}

https://skia.googlesource.com/skia.git/+log/d8853ec0fd01..0bf59e459772

$ git log d8853ec0f..0bf59e459 --date=short --no-merges --format='%ad %ae %s'
2018-03-14 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 690c8eb7f..fccebffe6 (1 commit)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=stephana@chromium.org

Change-Id: I1b97a460dedd11e249bdae17d8941eae212d8b22
Reviewed-on: https://chromium-review.googlesource.com/961972
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543043}

Bug: 729800
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic81f291fd9ea34647f0260d4d4dd88f3c90504d0
Reviewed-on: https://chromium-review.googlesource.com/881586Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543042}