- 29 Dec, 2020 40 commits
-
-
Alexander Surkov authored
Inspect tools provide option to show internal ids of accessible objects, which is a handy feature for debugging and event recording. Platform tree formatters rely on internal accessible trees to retrieve object ids. It should be avoided, because the tree formatters should operate on external trees to produce same results not depending on how a tree formatter was initiated (whether by tests or by ax_dump_tree tool). WebKit exposes AXIdentifier attribute, which looks like a great match for this case. However, no comments from Apple so far about what exactly this attribute is for, so let's move with ChromeIdentifier attribute for now. Later it can be revisited. Bug: 1134623 Change-Id: I367158bc8802734d0e9311c9739eb8da13ff0cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602356 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#839602}
-
Matt Reynolds authored
The HID spec allows a device to group its functionality into separate top-level collections within the HID report descriptor. On Windows, each top-level collection is represented in the system registry as a separate logical device node. This CL identifies when a device exposes multiple top-level collections and merges them into a single HIDDevice instance. Bug: 1009715 Change-Id: I0524fee04b5e530dfa5ff724b57d2442187946be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592149 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#839601}
-
Junbo Ke authored
Bug: internal b/156555613 Test: cast_base_unittests Change-Id: I5087a0a2df39559cf510ff5f9712ac9ece6a5b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605591Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#839600}
-
Jeffrey Kardatzke authored
Since we haven't enabled the new CDM with HW HEVC support yet overall, we need to condition adding the HEVC codecs in EME on the same flag as the CDM being enabled. BUG=b:176202075 TEST=GPM playback works with default Alcatraz CDM Change-Id: I626cb1e33973b812dce59edc514c086a578b45bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605292 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#839599}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8db531ffa636..9c73806bc052 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ia3aec89d2ef653871b95315f69436e1f2db34eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605597Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839598}
-
Monica Basta authored
This CL enables editing the local profile name from the picker's main view. A hover state is added to guide the user of the possibility of the inling editing. On click, the local profile name is editable. Bug: 1159740 Change-Id: I2fba0602944b9e7334ee32663c081b5c308428b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599869Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#839597}
-
Maks Orlovich authored
This is semantically more correct, and avoids a bug in ::String with non-ASCII bytes that led to loss of this setting on restore and quickly growing memory use. (I'll fix that separately). Bug: 1161142 Change-Id: If998dab411d41e18f844d79f0dea12ea1fbcade7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602380Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#839596}
-
Mike Taylor authored
Bug: 1162205 Change-Id: Iff1144b300c8b414cc2534fbf6aacdf94a318a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606366 Commit-Queue: Lily Chen <chlily@chromium.org> Auto-Submit: Mike Taylor <miketaylr@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#839595}
-
Clark DuVall authored
This improves the behavior a bit by: - Running the compile as a deferred startup task instead of right after startup completes, which makes sure it doesn't interfere with the first page load, and makes sure the base dex is not invalidated before starting child processes. - Removing the "-f" option for force compiling the dex. This prevents recompiling the base dex if it is already correctly compiled. - Using "-r shared" instead of explicitly passing the compile mode, so the system can figure out what mode to compile shared APKs in. Bug: 1159608 Change-Id: Ib15c626bc3c85f882046b806cde5e7b872d25e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602837Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#839594}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2813dd74be34..f3b4fc743758 2020-12-29 saklein@chromium.org service/dependency: collapse cache parsing functions 2020-12-29 chrome-bot@chromium.org Update config settings by config-updater. 2020-12-29 vapier@chromium.org toolchain_util: stop hardcoding master branch If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ie5cbb652c50bc90bef8f2be08e94fda1116b4fef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606365Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839593}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d1b593f446d3..c85bce8ea6c8 2020-12-29 bsalomon@google.com Revert "Make textures used with alpha-only color-types produce 0s for RGB" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: djsollen@google.com Change-Id: I126b3126e0a7bb56687069bed1ac27efa6111380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606310Reviewed-by:
-
Trent Begin authored
This change fixes the CaptivePortal routine problems and a misspelling. Bug: none Change-Id: I4e5226bb27ee179830b3544edd45eb87bb3a8dfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602114Reviewed-by:
Kartik Hegde <khegde@chromium.org> Commit-Queue: Trent Begin <tbegin@chromium.org> Cr-Commit-Position: refs/heads/master@{#839591}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6005f1179a65..355e9766ff81 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I45874a937cee3afaf7a2556b38deff6876e9fcad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606108Reviewed-by:
-
Chris Lu authored
It is not guaranteed that upon a badge tap that the associated Infobar still exists. The Messages implementation has a similar issue, but Objc nil object selector executions are no-ops. Thus, an explicit nil check is necessary before attempting to present an Infobar modal overlay. Fixed: 1041375 Change-Id: I072879ef4ab2a163223cc896ea3a59288c09998e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605400 Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#839589}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012290600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/gYicacAmlNBTfmj5bqOqzRfHBhSEG6KBAY2UtDyAakQC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: I42705f082d530b2fc23f44546a6fb5b3b55c89a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605593Reviewed-by:
-
Danila Kuzmin authored
Bug: 1162262 Change-Id: I44c5a9041eb384a654dffd962cb7aa4487f49dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603755Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#839587}
-
Danila Kuzmin authored
Bug: 1159430 Change-Id: I9923cc0a1590a26a2fa9988a6bbd5220d40fa9e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604911 Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Reviewed-by:
-
Yang Guo authored
We are renaming "online" to "no throttling" for the network throttling setting. We need to rebaseline the test expectation when the rename rolls from devtools-frontend into chromium. Bug: 1028078 Change-Id: Icb1db48350401d697a62b57e9dd6f825377c9c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606344 Commit-Queue: Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#839585}
-
Nico Weber authored
...at least once there's an arm cipd binary. gclient's DEPS variables have a host_cpu variable (backed by detect_host_arch.py in depot_tools, which even correctly returns "arm64" on M1s), but it can't be queried via Var() in DEPS (and even if that was possible, the x64 value is "x64" and not "amd64" like we'd need for the cipd package name) and we can't use it in a gclient `condition` here either since we'd have to do something like 'src/buildtools/mac': { ...'gn/gn/mac-amd64' condition: 'host_os == "mac" and host_cpu == "x64"' } 'src/buildtools/mac': { ...'gn/gn/mac-arm64' condition: 'host_os == "mac" and host_cpu == "arm64"' } and then gclient would complain that we have two entries for the key 'src/buildtools/mac'. So gclient variables and cipd deps don't synergize very well here. However, cipd has a bunch of built-in variables too, and ${arch} is populated based on runtime.GOARCH and that is "amd64" in x64 and "arm64" on arm64, so we can use that: https://chromium.googlesource.com/infra/luci/luci-go/+/master/cipd/client/cipd/ensure/doc.go (In fact, we could use `gn/gn/${{platform}}` and remove the conditional on host_os. That might confuse linux/arm and windows/arm machines since we might not have gn prebuilts for those, but trying to build on those platforms probably doesn't work great for other reasons already?) Bug: 1103319 Change-Id: I2d445a02e5e05f9553929404a3d569f7fe7a2213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602663 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#839584}
-
Monica Basta authored
Bug: 1161528 Change-Id: I80dd4f0e2950f0cbaba864fd7529dab10e15cbce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602430 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#839583}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I622f5e4593f3365a4e0d93076f39aaaafb5775bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606208Reviewed-by:
-
Henrique Ferreiro authored
Additionally remove blink::DragOperation in favor of the Mojo type. Follow-up CLs will move blink.mojom.AllowedDragOperations and unify the rest of the drag-and-drop types with these definitions. Bug: 1093536, 919392 Change-Id: Iddcf7298a6656a6cec9be3bb60ba8177581e68bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587049 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#839581}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6005f1179a65..355e9766ff81 2020-12-29 fmayer@google.com Merge "Use packages.list to read profileability." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic9bbf240aef6bb7b1cd2374be9e2e14eca41dd17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606307Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609221064-1228ab180b0732d4cc578b7cded2cefd740548bb.profdata to chrome-mac-master-1609241635-1a5deaa23ae88856f623544afdac379b41a9d7db.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I89dcf68275bcb730e001292f2282020abfe3b376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606304Reviewed-by:
-
Yunke Zhou authored
We noticed that the system will hang up when ChromeVox dialog is shown on the welcome screen during OOBE. Disable the feature first for further investigation. Bug: 1161107, b/176129191 Change-Id: I5b14db099000fa217a062362b40070e24974e25a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603754Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609221064-24424bfd2155989c442b2a02c4811561491f33e6.profdata to chrome-linux-master-1609241635-e4b96f72ae58e1971ec4cf3bb5311f454317b912.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2a9ad3948ecdb3a131c682543e20a36dbeb1032c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606220Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2382e63de188..8db531ffa636 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I7a70e5048828673662742bada46715c620e6d345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605418Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b5f42f1dedca..c6a4cc37015a 2020-12-29 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4ce86ea5b1e7cc0fa5a46b138d47e96684e6abd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606217Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609124291-e7a0465f695fe158abf9ec0e9104d31fe42b886f.profdata to chrome-win64-master-1609221064-65e0288b21a9cea51e4f1fac1a8b654b327fc015.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6be5402fa1653bf63a397d32465415f4c1bf4964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605811Reviewed-by:
-
Thomas Tellier authored
Bug: 1101326 Change-Id: I0a43e246b5e659f4e246bf0ec3eb32e3d627c1a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603572 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1f0df96659ae..5994a16ca076 2020-12-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b264ce95..0afd0128 (839451:839551) 2020-12-28 deadbeef@webrtc.org Correct "DSAWithSHA256" OID. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I913a3426afc8b6f2e45648f9ae89d6517d9b39a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606206Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/220642a93da1..095fd1d3ad25 2020-12-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e02e8b37 to aba6331a (134 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: If1498e4636469af2c292b9e23c46977a1a524dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605810Reviewed-by:
-
Henrique Ferreiro authored
effectAllowed and dropEffect are limited to at most 9 different strings. Additionally, since drag-and-drop is only used in the UI thread, it should be thread-safe. Given these conditions, AtomicString will be more efficient and safe to use. This was mentioned as a TODO in https://bugs.webkit.org/show_bug.cgi?id=33607#c9. Bug: 1093536 Change-Id: I161ee9ad5d772aa70f0c2f7615abe23c0ec624c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599533 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#839570}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I50448436c46e54a58698f5b117f5c1ee9c32da38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605592Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839569}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/41dde25e96c5..2382e63de188 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I4db7d55eb7ff3a0cfae62c74e2a3061cecfc1b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604303Reviewed-by:
-
Sergey Poromov authored
Some tests were already disabled in https://crrev.com/c/2605403 But others are still failing: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20CFI/19334/overview TBR=jdarpinian@chromium.org Bug: 1162117 Change-Id: I615aaba11b736e81c9051dc867c2605ddcdd1615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602435Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#839567}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bcfb0a5a..ef6c6121 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id8e79cd0faaaef97317de4dfecff0dfcc3a688d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603466Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839566}
-
Sergey Poromov authored
The test is flaky: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests Sample run: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21913/overview TBR=dmazzoni@chromium.org TBR=dtseng@chromium.org Bug: 1162238 Change-Id: I05ea294ec4cfb46761552b1fc972895444a7987b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605747Reviewed-by:
-
Kuo Jen Wei authored
This CL introduce following |#mode-selector| changes: 1. Set the fadding effect area to 24px. 2. Fine tune scrollbar height, color, border-radius. 3. Makes gap between |.mode-item| to 16px, 4. Remove 5px top/bottom padding of #mode-group, let the gap between scrollbar and |.mode-items| solely determined by top/bottom margin of |.mode-times| and avoid focus ring overlapped with scrollbar. Bug: b/172340037 Test: Manuall verify with UX spec. Change-Id: I52db56f1a309748d1bfcaa585143301e09ca7233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600432Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#839564}
-
Danila Kuzmin authored
Bug: 1156662 Change-Id: I2be68f5013ddad64c16c8036d53c0be9ef437e59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600746 Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Reviewed-by:
-
