GitLab

https://skia.googlesource.com/skia.git/+log/f9af55641a6d..1946aaf15ca0

$ git log f9af55641..1946aaf15 --date=short --no-merges --format='%ad %ae %s'
2017-12-06 kjlubick Disable ThermalManager for Nexus5x

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=rmistry@chromium.org

Change-Id: I5d9cba8dc120bd45ba413943d8f8df03148a32f0
Reviewed-on: https://chromium-review.googlesource.com/810924Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522090}

The use of WaitForGetFavicon() is unnecessary and misleading because
it introduces a nested runloop where many things can happen, including
model changes that call
BookmarksMatchVerifierChecker::IsExitConditionSatisfied() and hence
make it reentrant.

It is unnecessary because, starting with
55b3fe20, a loading favicon is
guaranteed to ultimately notify a model change, which will trigger
MultiClientStatusChangeChecker::OnStateChanged() and hence
IsExitConditionSatisfied().

Bug: 783774
Change-Id: I02c7623e3bb173b25b9c715b7bdf9c646300e3ee
Reviewed-on: https://chromium-review.googlesource.com/785091
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522089}

Repurpose spell checking code that was testing for the mojo channel
to common code. Write a test that causes the showGuessPanel selector
to be sent and verify the panel is requested to be shown.

BUG=782836

Change-Id: I9d8ac59ac3bf96bbcd7e538f794eac71e0bc7553
Reviewed-on: https://chromium-review.googlesource.com/786260
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Rachel Blum <groby@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522088}

https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/7f8fefabedf2..f1a87d73fc60

$ git log 7f8fefabe..247a3d8e5 --date=short --no-merges --format='%ad %ae %s'
2017-11-07 whame@users.noreply.github.com Fixes issue #826 by treating MinGW as "non-Windows" when determining colored output
2017-10-29 thielen@hs-worms.de remove markdown stars (bold) from code examples
2017-10-25 arkady.shapkin@gmail.com Enable CI for VS2017
2016-10-21 romain.geissler@gmail.com Remove gcc 6 misleading indentations.
2017-06-08 arkady.shapkin@gmail.com Fix gmock tests when std::unary_function unavailable
2017-05-03 arkady.shapkin@gmail.com Fix tests with VS2015 and VS2017
2017-05-03 arkady.shapkin@gmail.com Enable C++11 features for VS2015 and VS2017
2017-10-17 manojgupta@google.com googletest: Add GTEST_API_ attribute to ThreadLocal class.
2017-10-18 gennadiycivil@users.noreply.github.com Workaround for Travis issue https://goo.gl/d5eV8o
2017-10-18 gennadiycivil@users.noreply.github.com Revert "Workaround for Travis issue https://github.com/travis-ci/travis-ci/is…"
2017-10-18 gennadiycivil@users.noreply.github.com Workaround for Travis issue https://github.com/travis-ci/travis-ci/issues/8552
2017-10-14 dariusz.ostolski@gmail.com #1282: Doc typo fix
2017-10-07 joe@robotgoblin.co.uk Updated README with information about C runtime dynamic/static linking issues in Windows
2017-09-27 jwakely@redhat.com Use gender-neutral pronouns in comments and docs
2017-09-21 gennadiycivil@users.noreply.github.com Revert "Allow macros inside of parametrized test names."
2017-09-19 stkhapugin@chromium.org Swap reinterpret_cast for static_cast
2017-09-16 benjamin.kircher@gmail.com Remove redundant declaration
2017-09-14 31530391+ly2048@users.noreply.github.com Add explicit `CMAKE_DEBUG_POSTFIX` option
2017-09-01 sokolov@google.com Make the failure messages from EXPECT_EQ and friends actually symmetric,
2017-09-08 31780593+yursha@users.noreply.github.com Fix ellipsis position in examples
2017-09-07 thielen@hs-worms.de use GTEST_ATTRIBUTE_UNUSED_ instead of dummy function
2017-09-07 gaspardpetit@gmail.com Removed flush scopes around GTEST_LOG(FATAL) and exit call since FATAL is expected to abort()
2017-09-05 thielen@hs-worms.de remove unused variables from travis environment
2017-09-05 thielen@hs-worms.de drop unused valgrind package from installation
2017-09-05 thielen@hs-worms.de reset ccache statistics at install
2017-09-05 thielen@hs-worms.de show ccache statistics in log
2017-09-05 thielen@hs-worms.de call clang via ccache on Linux
2017-09-05 stkhapugin@google.com add a cast
2017-09-05 thielen@hs-worms.de remove obsolete link_directories command
2017-09-04 thielen@hs-worms.de limit processors to use in Travis build to 4
2017-09-04 thielen@hs-worms.de install ccache on travis osx build slave
2017-09-04 thielen@hs-worms.de set MAKEFLAGS to use multiple processors on Travis CI
2017-09-02 thielen@hs-worms.de cache ccache
2017-08-30 thielen@hs-worms.de avoid warning about unused variable
2017-09-04 thielen@hs-worms.de avoid -Wshadow warning on GCC
2016-02-10 bauerb@chromium.org Add a non-parametrized test.
2016-02-04 bauerb@chromium.org Allow macros inside of parametrized test names.
2017-08-30 thielen@hs-worms.de treat all warnings as errors for GCC (-Werror)
2017-08-30 thielen@hs-worms.de switch one build to Release mode
2016-12-30 lebedev.ri@gmail.com CMake: use threads if allowed and found, not just if found.
2017-08-31 thielen@hs-worms.de change links from former code.google.com to current github repository
2017-08-31 thielen@hs-worms.de fix example's comment
2016-09-05 arkady.shapkin@gmail.com AppVeyor MinGW-w64 test build
2017-08-30 thielen@hs-worms.de create different python based tests for single and multi configuration build generators
2017-08-30 thielen@hs-worms.de Revert "ask cmake for per-configuration output subdir"
2017-08-30 thielen@hs-worms.de ask cmake for per-configuration output subdir
2017-08-30 thielen@hs-worms.de remove obsolete comment regarding python tests on linux
2017-08-30 thielen@hs-worms.de use upper-case build type
2017-08-30 thielen@hs-worms.de use build type set in .travis.yml
2017-08-29 thielen@hs-worms.de remove non-existing gmock_build_samples switch
2017-05-09 thielen@hs-worms.de remove unused TestCase import
2017-08-14 gaspard.petit@eidosmontreal.com Removed extra colon in error log
2017-08-14 gaspard.petit@eidosmontreal.com Use GTEST_LOG instead of printf
2017-07-02 chehsunliu@gmail.com Update googletest README.md
2017-02-13 olivier.clavel@gmail.com googlemock version must be changed as well
2017-02-13 olivier.clavel@gmail.com Wrong version reported (1.7.0 should be 1.8.0)
2016-10-08 adriyetichaves@gmail.com Fix WhenSorted() documentation example
2016-08-30 claus.stovgaard@gmail.com Moved the ignoring of *.pyc files to top level for also covering googlemock python scripts.
2016-05-22 tobbi.bugs@googlemail.com Performance fixes reported by cppcheck

Created with:
  roll-dep ./src/third_party/googletest/src

Bug: 
Change-Id: I72edf5c1ec21f34aab852f661fec6a58bedbd365
Reviewed-on: https://chromium-review.googlesource.com/681214
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522087}

Update to the new way of getting the HTTP and HTTPS ports for the
WebPageReplay server, which was introduced in:
https://chromium-review.googlesource.com/c/catapult/+/796863

Bug: 792421
Change-Id: I62b8b18043aff03781fcfba2ac63eaf0e5921b28
Reviewed-on: https://chromium-review.googlesource.com/810967Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522086}

This adds two histograms to MediaEngagementPreloadedList. The first is
used when the list is loaded and will allow us to see if the loads are
failing and why. The second is used when the list is checked and will
allow us to see if the list has not been loaded or is empty, as well
as how often the list is matching.

BUG=787464

Change-Id: I935405ef56aa197a2f32fbd85df7c9ae4851b12a
Reviewed-on: https://chromium-review.googlesource.com/808305
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522085}

There is currently no logging for any events in AutomaticRebootManager
and due to that it's hard to investigate issues with non-rebooting
devices.
These logs will be triggered on Chrome OS devices only:
 * on AutomaticRebootManager initialization
 * when reboot policies "UpdateLimit" or "RebootAfterUpdate" change
 * reboot is required due to an update

BUG=b/69546724

Change-Id: I488bb3b1b398d390f8ff2e5613a532e8494449bf
Reviewed-on: https://chromium-review.googlesource.com/808886Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522084}

There were a few cases where due to mismatch between policy defintions
and entries in the policy_tests_cases.json file. The tests have failed
when Chrome was uprevved. This CL aims at making this a little harder
by enforcing a proper match between policy lifetime and their tests.

BUG: 791125
TEST: browser_tests.exe --gtest_filter=PolicyPrefsTest.PolicyToPrefsMapping
Change-Id: I75fdef47081c27184c05ded7cd2bc6a3e355ac79
Reviewed-on: https://chromium-review.googlesource.com/808184
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522083}

Bug: 615313
Change-Id: Ie608f427083303af5afd98e8939dcfc43a266942
Reviewed-on: https://chromium-review.googlesource.com/805395Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522082}

Latest spec has used USVString instead of DOMString for url argument.
 - spec: https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers

This CL replaces DOMString type with USVString type according to the spec.

Bug: 790860
Change-Id: I179144780bd345bc71e9b9beeaea3470a8e3d302
Reviewed-on: https://chromium-review.googlesource.com/781320Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#522081}

This reverts commit f9eaa531.

Reason for revert: Suspected cause of Win8 Tester failures
https://build.chromium.org/deprecated/chromium.webrtc/builders/Win8%20Tester/builds/38865

Original change's description:
> Win video capture: use IMFCaptureEngine for Media Foundation
> 
> - Full rewrite of the MediaFoundation implementation video part to use
> IMFCaptureEngine
> - Implementation of takePhoto, setPhotoOptions and getPhotoCapabilities
> - takePhoto triggers a still image capture with the highest available
> resolution without stopping the video stream thanks to IMFCaptureEngine
> 
> TEST=adapted video_capture_device_unittest.cc and
> webrtc_image_capture_browsertest.cc; launch Chrome with
> --force-mediafoundation on Win8+ and capture video using
> e.g. https://webrtc.github.io/samples/src/content/getusermedia/gum/
> 
> R=​mcasas@chromium.org
> 
> Bug: 730068
> Change-Id: Ib8e7f475d8120a63dd08c7b215c1eaf2c6f3d800
> Reviewed-on: https://chromium-review.googlesource.com/734042
> Commit-Queue: Christian Fremerey <chfremer@chromium.org>
> Reviewed-by: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: Christian Fremerey <chfremer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521435}

TBR=mcasas@chromium.org,chfremer@chromium.org,alaoui.rda@gmail.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 730068
Change-Id: I439af305a6bb45c26efb1b395e69088344a71536
Reviewed-on: https://chromium-review.googlesource.com/810624Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522080}

Using wpt-import in Chromium e184205c.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/6970

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
domenic@chromium.org, ricea@chromium.org, tyoshino@chromium.org:
  external/wpt/streams

TBR=robertma

No-Export: true
Change-Id: I6f434687ef6249d16f63db28a6d0d95593a1513a
Reviewed-on: https://chromium-review.googlesource.com/809732
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522079}

I think this should fix the reason this originally was reverted
https://chromium-review.googlesource.com/c/chromium/src/+/810324
I have removed the last two lines of ComputedStyleCSSValueMapping::Get.

This CL also changes the behavior for ColumnRuleColor.
It used to call VisitedDependentColor(CSSPropertyOutlineColor),
but that seemed wrong so I changed it to use
VisitedDependentColor(CSSPropertyColumnRuleColor).

There will be more CLs immediately following to finish Ribbonizing
this class. Please ping me for a link to the design doc.

Bug: 775360
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I0bca0a6ef9dde73d20aad9f733d7f63ce194a50e
Reviewed-on: https://chromium-review.googlesource.com/810001Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Renée Wright <rjwright@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522078}

The two workarounds that were fixing strikethrough issues introduced in
iOS 10.3 and iOS 11 seem to no longer be necessary with iOS 11.2.

correctly struck through. Try typing in the omnibox and navigating
to and from such a website; only "https" should be struck through.

Bug: 711367, 760964
TEST: Navigate to a website with bad SSL and observe that "https" is
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id4f73b49281df024e2fbb621a74243440759b138
Reviewed-on: https://chromium-review.googlesource.com/805276Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522077}

Rename variables to be clearer in their intention, use a switch
statement instead of an if/else if/else blocks and wrap the whole thing
as a step function to properly catch failing asserts.

Bug: 
Change-Id: I89c92d7a5071728bfdd8c9827f08ae3af94377db
Reviewed-on: https://chromium-review.googlesource.com/809425Reviewed-by: Anita Woodruff <awdf@chromium.org>
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522076}

Bug: 598854
Change-Id: Icb9b7586a8b14772dded0b4c1c323a3668dba371
Reviewed-on: https://chromium-review.googlesource.com/804350Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522075}

Also rearrange parameter ordering in AIDI::Create. Both of these
changes are to simplify callback binding for the new factory in
https://chromium-review.googlesource.com/c/chromium/src/+/771196.

Bug: 653871
Change-Id: I825b519e664c0e4cafecff85f199d3bc145c8fda
Reviewed-on: https://chromium-review.googlesource.com/795970
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522074}

https://chromium.googlesource.com/catapult.git/+log/a9cf2fa54a33..307c9f954dc5

$ git log a9cf2fa54..307c9f954 --date=short --no-merges --format='%ad %ae %s'
2017-12-06 perezju [Telemetry] Cleanup android_forwarder code

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I49d420746ee0dcba3eb77afd52d0427dafb322c4
Reviewed-on: https://chromium-review.googlesource.com/809721
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522073}

in preparation for using it in more tests (UI tests in particular).
Also contains some other minor cleanups.

Bug: 791066
Change-Id: I5bd2c7e3e99655e3ff453fc447c69f1484ce3d5b
Reviewed-on: https://chromium-review.googlesource.com/808764Reviewed-by: Chris Pickel <sfiera@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522072}

Make the trailingAnchor of the stackView inside bookmarkTableCell always
equals to contentView's trailingAnchor.  This can prevent
crbug.com/778231 where the stackView's width doesn't grow as expected
when editing folder name on iOS 10.

Bug: 791976
Change-Id: I71fac7e335561fe7f54beb1062602976b0b2a280
Reviewed-on: https://chromium-review.googlesource.com/809988Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Marti Wong <martiw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522071}

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/5c4b603461a7..e494ee7de6e2

$ git log 5c4b60346..e494ee7de --date=short --no-merges --format='%ad %ae %s'
2017-12-01 ljusten authpolicy: Add GetUserStatusRequest and OU errors

R=ljusten@chromium.org

Created with:
  roll-dep src/third_party/cros_system_api

BUG=chromium:782695

Change-Id: I14032dae5bcbd811fb9afa0561b2e6d4173167df
Reviewed-on: https://chromium-review.googlesource.com/809112
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522070}

This is in preparation for ReplaceTrack. When we have ReplaceTrack, the
WebRTCRtpSender is modifiable. Having an internal ref counted class
ensures that if one WebRTCRtpSender is modified, this is reflected in
all shallow copies of the class.

In other words, this CL enables content::RTCRtpSender having internal
modifiable states separate from the webrtc::RtpSenderInterface.

Made some misc fly-by changes like renaming "webrtc_rtp_sender"
variables/methods to "webrtc_sender" and making
WebRTCRtpSender::Track() return by value instead of pointer (since
there is a "null" value).

Bug: 790007
Change-Id: I3f11b2af7457b6c3b9e6de5d97c32085bf050280
Reviewed-on: https://chromium-review.googlesource.com/806161Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522069}

Add a tool to generate preload data in DAFSA format and
add a MediaEngagementPreloadedList class to read it.

BUG=787464

TBR=dpranke@chromium.org

Change-Id: If0d99a2e1091d0b23699f2173d8146582173ee54
Reviewed-on: https://chromium-review.googlesource.com/803994
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522068}

This relands crrev.com/c/691663 which confirms that nostate prefetch
sets cookies on all fetches. In the interim a test for cross-domain
fetches has been added.

The original CL was reverted due to flakes on windows. I could not
reliably reproduce the flakes, but in addition to the usual CQ, I've
run this several times on the windows bots, and it is no longer
flaking. Perhaps commit e23356c2 which moved browser_test_utils to
mojo access of cookies removed whatever race existed, or perhaps using
PostDelayedTask instead of sleeping fixed it.

Bug: 
Change-Id: I71ef3053c71da53e21093dc57d977e3992d279ef
Reviewed-on: https://chromium-review.googlesource.com/695221
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522067}

Bug: 788289
Change-Id: I20634f6dc7ad2ef0e7313c647da746e745c29f79
Reviewed-on: https://chromium-review.googlesource.com/788862Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522066}

- Add a call on ThreadHeap for manual calls
- Emit function call after fast flag checks in Member

Bug: chromium:757440
Change-Id: I8d019d0e9d1bae5a23bf6ed5e8f6a1d818c713b6
Reviewed-on: https://chromium-review.googlesource.com/808244
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522065}

This includes making SharedMemory::GetReadOnlyHandle() const.
Getting a handle with write permissions is currently const, so it makes
no sense at all that getting a handle with read only permissions is not
const :).

Bug: 653871
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie98fde38535f5ffe0ae51949ae043c38c9791eb8
Reviewed-on: https://chromium-review.googlesource.com/806655
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522064}

The stack view button is only needed on iPhone. The iPad have the tab
switcher button.

Bug: 791456
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie2f0044d59218d27f8253b3b44bea1c5fbc7ef19
Reviewed-on: https://chromium-review.googlesource.com/808864Reviewed-by: Elodie Banel <lod@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522063}

This CL adds a warning to be displayed before the user can export
their passwords.

Mocks:
https://docs.google.com/presentation/d/1nIm5OmaOnb85ZAwMZPSVqHT0vkFbsRYZhOzbmznWU_c/edit#slide=id.g289b1efcd8_0_21

Note: the mock shows slightly different styling, but with the UX
designer we settled on using a standard dialog style already existing
in Chromium and checking separately whether that style needs fixing,
rather than introducing inconsistent styling among Chrome's dialogs.

Design: go chrome-pwd-export

Screenshot: https://crbug.com/788701#c7

Bug: 788701
Change-Id: I3a2dbdc24429c5662fdc2b178630a8e45ba603a1
Reviewed-on: https://chromium-review.googlesource.com/803955
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522062}

Mocks: go chrome-pwd-export-mocks-android (Google-internal only)

Screencast after the change: https://crbug.com/788701#c3

The CL adds a reauthentication step before the user can trigger
exporting passwords.

In addition to that, the CL also wraps the check for screen lock
availability in ReauthenticationManager.isScreenLockSetUp, to
make it possible to override for testing.

Also, this CL adds two tests for viewing passwords, because one
of earlier iterations of this CL broke something for the viewing
passwords feature and such tests would have caught it.

Bug: 788701
Change-Id: Ibfa37192e26bc5797236ba9378aa1eb0f17f79cc
Reviewed-on: https://chromium-review.googlesource.com/797453
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522061}

The clean toolbar buttons should have the same size and positioning
as the current toolbar.
This CL ensures this is happening.

Before: https://drive.google.com/file/d/1vorlHlUZvIZMV94iplEcPWdIPigV5Hgs/view
After: https://drive.google.com/file/d/1E1s8PKtyWILCvaO-fy8OX8-UJi_BoAK1/view

Bug: 791978
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie46f44c8eec3cb4fc194127d3092d8ea9328bd69
Reviewed-on: https://chromium-review.googlesource.com/809105
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522060}

Tests are needed for viewing passwords in settings. Those tests need
an easy way to mock PasswordUIView, which communicates with C++ in the
production version.

Therefore this CL does:
(1) Define an interface, PasswordManagerHandler, for the public methods of
    PasswordUIView to be mocked in the tests (coming in
    https://crrev.com/c/797453).
(2) Create PasswordManagerHandlerProvider which encapsulates the logic
    for managing observers, life-time and test-replacement of the
    PasswordManagerHandler implementations.
(3) Lift SavedPasswordEntry to top level for reasons explained in its
    class comment.

This CL should not change any functionality, so current test coverage
is assumed to be sufficient for the new code.
The new tests are postponed until https://crrev.com/c/797453, which
also introduces other test utilities to make writing them less of a
pain.

Bug: 788701
Change-Id: I2b90a613065df50cad85de85ffa620a88df61a6e
Reviewed-on: https://chromium-review.googlesource.com/806155
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522059}

1. Upstream crossorigin.html to wpt
2. Remove tests from [1] infavor of the web platform tests in [2]
[1]: media/track/opera/interfaces/HTMLElement/HTMLMediaElement/
[2]: external/wpt/html/semantics/embedded-content/media-elements
	/interfaces/HTMLElement/HTMLMediaElement

Bug: 782555
Change-Id: I9f5ce13d2782ab2313b6026307e0e031485b177d
Reviewed-on: https://chromium-review.googlesource.com/807757Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#522058}

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id605c1ab97e273ae9e783e3925457e5ca87daf5c
Reviewed-on: https://chromium-review.googlesource.com/809126
Commit-Queue: Chris Pickel <sfiera@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522057}

This reverts commit c47b4d11.

BUG=chromium:791131
TEST=video_ChromeRTCHWDecodeUsed on peach_pit
Reason for revert: This CL breaks video_ChromeRTCHWDecodeUsed

Original change's description:
> WebRTC: Migrate completely to new video codec factories API
> 
> This CL makes the Chromium HW video factories implement the new
> interfaces directly. It also adds SW codecs, simulcast, and SW fallback
> codecs manually, instead of relying on WebRTC to do this. This will
> give Chromium more flexibility in the future, and will allow us to
> simplify the WebRTC code, since it's only Chromium that uses some of
> these features.
> 
> Bug: webrtc:7925
> Change-Id: I2bbd8b9a8c52bfe963d601f34188faf47d59e67e
> Reviewed-on: https://chromium-review.googlesource.com/788410
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Emircan Uysaler <emircan@chromium.org>
> Commit-Queue: Magnus Jedvert <magjed@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520062}

TBR=haraken@chromium.org,emircan@chromium.org,magjed@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:7925
Change-Id: I081f9f5d961707924fe6eed4a97ead9c9f5ed12c
Reviewed-on: https://chromium-review.googlesource.com/810429Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522056}

This is a second reland attempt for
07edac9e after a fix for the
underlying issue has landed:
https://chromium-review.googlesource.com/c/chromium/src/+/807664

Original change's description:
> Migrate away from deprecated RunLoop API
>
> Instead, we keep around an instance of base::RunLoop and pass it
> explicitly for Quit(), which makes sure the code quits the intended loop
> and not a nested one.
>
> Bug: 783774
> Change-Id: I3ea5092699bbae127f581e5c955cb27904d98f0a
> Reviewed-on: https://chromium-review.googlesource.com/784790
> Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519664}

TBR=pavely@chromium.org

Bug: 783774
Change-Id: I615b4a92ff59a8f4cf871d63327bb8ba063d1cfc
Reviewed-on: https://chromium-review.googlesource.com/803314Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522055}

Bug: NONE
Change-Id: I5e79a366942948f8361f25db0d2cae68a412c016
Reviewed-on: https://chromium-review.googlesource.com/809107
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522054}

TBR=chrome-os-gardeners@google.com

Change-Id: I95aacbb926d1b3923e51160be0a40a004bc93a67
Reviewed-on: https://chromium-review.googlesource.com/809823Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522053}

First create an EGLImage from a given gl texture.
Then export the EGLImage as dmabuf.

In addition to the new unit test included in this CL,
this will be useful for the subsequent CL,
https://chromium-review.googlesource.com/c/chromium/src/+/766787
which will enable existing VaapiDrmPicture when passing --use-gl=egl.
While existing VaapiTFPPicture(X11) will be left for --use-gl=desktop.

Added unit test ui/gl/gl_image_native_pixmap_unittest.cc
The test is enabled on non-ozone but should work on ozone too.
If any of the pre-conditions fail then the test is skipped.
Specifically it requires the extension EGL_MESA_image_dma_buf_export.
So it works on Intel, AMDGPU and nouveau drivers but skipped on NVIDIA.

Bug: 785201
Test: gl_unittests --gtest_filter=*NativePixmap*

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id9b4e56aaaaf5fd9994f4b144ce74a234d848253
Reviewed-on: https://chromium-review.googlesource.com/766687
Commit-Queue: Julien Isorce <julien.isorce@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522052}

We have not supported valgrind for some time (it was never ported to
the GN build IIUC, and has been obsoleted by ASan/MSan/TSan).

BUG=791518

Change-Id: I9d6f5125de817b9334b295a8a78589004bb08294
Reviewed-on: https://chromium-review.googlesource.com/809132
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522051}