- 20 Sep, 2018 40 commits
-
-
Egor Pasko authored
TBR=perezju@chromium.org Bug: 887546 Change-Id: Ia96997eb631402aab7f5fe1ad4ede733d383969d Reviewed-on: https://chromium-review.googlesource.com/1236278Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#592869}
-
Dmitry Gozman authored
Bug: 841739 Change-Id: I6e61a5c11253096d80aeafb4b83ce653fbcfa0f0 Reviewed-on: https://chromium-review.googlesource.com/1235119 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#592868}
-
Adam Kallai authored
It used 'json' output-format which is not supported. This change intents to removes 'json' output-format from the options in order to fix an invalid format assert. Add self to AUTHORS Change-Id: I3c7ea4ff54cb23dbadbce57e0e41d4fefc97de54 Reviewed-on: https://chromium-review.googlesource.com/1136639 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#592867}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /gpu. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=piman@chromium.org Bug: 874080 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I94991868b2383b0f5b359399ea97597518ebea7f Reviewed-on: https://chromium-review.googlesource.com/1191410Reviewed-by:Antoine Labour <piman@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#592866}
-
Nicolas Pena authored
Per discussion with tdresser@, add an OWNERS file. We'll add more reviewers over time and as needed. Also while at it, rename progressive-web-metrics to speed-metrics-dev, see: https://groups.google.com/a/chromium.org/forum/#!topic/speed-metrics-dev/hPP-T56fUvE Change-Id: Ic48b3970393c558b3ade0334891bf1485d6b5e1f Reviewed-on: https://chromium-review.googlesource.com/1231395Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#592865}
-
Scott Violet authored
In hopes of having base::debug::Alias work better on ChromeOS. BUG=867035 TEST=none Change-Id: I509efc3bcafe71beaa86c9f5180043255e3ec3db Reviewed-on: https://chromium-review.googlesource.com/1219889Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#592864}
-
Javier Ernesto Flores Robles authored
Bug: 878388 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ie114d9a6d540ee69a085024b023de70047578223 Reviewed-on: https://chromium-review.googlesource.com/1230679 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#592863}
-
Luke Sorenson authored
Bug: chromium:887533 Test: No test necessary. Change-Id: I9fb495308c2f64796dd529fc1fcfec795957d042 Reviewed-on: https://chromium-review.googlesource.com/1236734Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#592862}
-
David 'Digit' Turner authored
Add a way to detect system libraries, and fallback to the system linker whenever they need to be loaded. This is needed because Chrome probes a few system libraries like libEGL.so to check that certain GL-related symbols are available. It does that by using dlopen() + multiple dlsym() + dlclose(), which end up being performed through the crazy linker wrappers (e.g. WrapDlopen()). When enabling the crazy linker, it seems this happens everytime the user navigates to a different web page! Due to the way the code works before this CL, this ended up loading said system libraries with the crazy linker, which is problematic because: - If the system library was already loaded in the Zygote, this would create a duplicate copy, loaded at a different address. Also this is much slower than simply incrementing the reference-count of an existing system library entry. - This creates pending RDebug-related tasks, which happen to be racy, and the source of runtime crashes. By detecting system libraries properly, the code can now always fall back to use the system linker to load them, avoiding these two problems entirely. In particular, it is hoped that this will decrease the amount of runtime crashes described in 831403. BUG=843987,831403 R=pasko@chromium.org, agrieve@chromium.org, rcmilroy@chromium.org Change-Id: I86d89d6a812b778cf962aa5da028449b2b79f1fa Reviewed-on: https://chromium-review.googlesource.com/1236656Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#592861}
-
Steven Bennetts authored
This reverts commit 09a198c9. Reason for revert: <INSERT REASONING HERE> Original change's description: > KeyboardController: Integrate code from keyboard_util.cc > > This CL: > * Moves KeyboardConfig and the global instance and setter/getter to > KeyboardController > * Moves KeyboardControlEvent and LogKeyboardControlEvent to > KeyboardController (which is the only consumer) > * Moves KeyboardOverscrolOverride and SetKeyboardOverscrolOverride > to KeyboardController > * Removes keyboard::IsKeyboardVisible (only one non test call which > already checks enabled() separately) > * Moves InsertText to KeyboardController > * Makes some changes to KeyboardController to improve alignment of > header definitions and implementations. > * Removes keyboard_util.h from keyboard_controller.h and removes > unnecessary keyboard_util.h includes. > > For trivial code removal from component_loader.cc: > TBR=benwells@chromium.org > > Bug: 843332 > Change-Id: I5226380a80bba1286b36d5d68c5e30c74f4cd9ad > Reviewed-on: https://chromium-review.googlesource.com/1225853 > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Shu Chen <shuchen@chromium.org> > Reviewed-by: Darren Shen <shend@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592483} TBR=jamescook@chromium.org,stevenjb@chromium.org,shuchen@chromium.org,shend@chromium.org Change-Id: Id568f0bdc20c3093f6757c644a6a9b8311f06e3a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843332 Reviewed-on: https://chromium-review.googlesource.com/1236841Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#592860}
-
Steven Bennetts authored
This reverts commit c1e2f785. Reason for revert: desktopui_MashLogin is crashing Original change's description: > Remove KeyboardController::ui() > > This removes direct access to KeyboardUI outside of tests while > the code is re-factored for Mash. > > Bug: 843332 > Change-Id: Ic6b60032512b36b7ff1ae05bb8d12060db8f8d29 > Reviewed-on: https://chromium-review.googlesource.com/1227171 > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Darren Shen <shend@chromium.org> > Reviewed-by: Shu Chen <shuchen@chromium.org> > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592526} TBR=jamescook@chromium.org,stevenjb@chromium.org,shuchen@chromium.org,shend@chromium.org Change-Id: I2708807e60023d952792e96ac58841c89a0353bc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843332 Reviewed-on: https://chromium-review.googlesource.com/1236465Reviewed-by:
-
Steven Bennetts authored
This reverts commit cedf185f. Reason for revert: Crashes in desktopui_MashLogin Original change's description: > keyboard_util: Remove flag/switch wrappers > > This CL moves some common flag/switch wrappers into the callers to > remove unnecessary dependencies on keyboard_util.h. With the upcoming > Chrome/Ash separation, the wrappers cause more confusion than they > improve readability. > > This CL also moves some keyboard_util.cc code only used in > KeyboardController to that class. > > Bug: 843332 > Change-Id: I042928bebfe4f9ea93ccb4fb7a24f8fc46f555cf > Reviewed-on: https://chromium-review.googlesource.com/1226191 > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Darren Shen <shend@chromium.org> > Reviewed-by: Shu Chen <shuchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592545} TBR=stevenjb@chromium.org,shuchen@chromium.org,shend@chromium.org Change-Id: I0875394e434c6beeceb11e93a64b16f1a5a42b7c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843332 Reviewed-on: https://chromium-review.googlesource.com/1236466Reviewed-by:
-
Dominik Röttsches authored
Fallback to FreeType on Mac OS < 10.13 as there is no support for COLR/CPAL layered fonts in CoreText before this version. Bug: 882844 Change-Id: I80ed16d1e6e23ee36dd5ad179e7712a53381e7c4 Reviewed-on: https://chromium-review.googlesource.com/1235995 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#592857}
-
yileili authored
This is a reland of c9b5d530 The internal repo uprev has landed in public HEAD. Original change's description: > Refresh access token only for auth error. > > Bug: b:114756954 > Test: Manual > Change-Id: I1d58906771ad789232d8c01f6de06ea44ad8e3f8 > Reviewed-on: https://chromium-review.googlesource.com/1226527 > Commit-Queue: Yilei Li <yileili@google.com> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592467} Bug: b:114756954 Change-Id: I695953226bfaea3f332cccb7b61a98be2c541297 Reviewed-on: https://chromium-review.googlesource.com/1235330Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yilei Li <yileili@google.com> Cr-Commit-Position: refs/heads/master@{#592856}
-
dpapad authored
These seem to have been fixed at r591110, but they were not properly re-enabled. Bug: 875452 Change-Id: Icdab27f5afd81a8e8c2c7a30b1ab76ec05ee8d8e Reviewed-on: https://chromium-review.googlesource.com/1235285Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592855}
-
Mark Cogan authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I785464f847ff6344201a5ac8f7aa2a6a1aa2f3f5 Reviewed-on: https://chromium-review.googlesource.com/1233701 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#592854}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/52c63fdabb72..7b11354810a9 git log 52c63fdabb72..7b11354810a9 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 mtklein@google.com add a bot that oughta fail Created with: gclient setdep -r src/third_party/skia@7b11354810a9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: Ic05e70f49f6496ad6ff979829f7be1a2d6b7dc16 Reviewed-on: https://chromium-review.googlesource.com/1236513Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592853}
-
Steven Bennetts authored
This reverts commit 2457438e. Reason for revert: desktopui_MashLogin is still failing Original change's description: > Mash: Protect virtualKeyboard events for null KeyboardController > > Currently the code is triggering a crash indesktopui_MashLogin: > http://ubercautotest.corp.google.com/tko/retrieve_logs.cgi?job=/results/239691238-chromeos-test/chromeos4-row2-rack3-host12/debug/ > > Bug: 843332 > For extensions change: > TBR=benwells@chromium.org > > Change-Id: I51d94a6924407fffbb49994ff4cb02718b517866 > Reviewed-on: https://chromium-review.googlesource.com/1235206 > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592620} TBR=jamescook@chromium.org,stevenjb@chromium.org Change-Id: If44890c68926d991d4642fde4566408b6ce57fa0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843332 Reviewed-on: https://chromium-review.googlesource.com/1236837Reviewed-by:
-
Kyle Milka authored
Bug: None Change-Id: Ie03079ca73e9e2593b73ff0e17e13c47bc077d3e Reviewed-on: https://chromium-review.googlesource.com/1231987Reviewed-by:
-
Antoine Labour authored
This reverts commit 1e9e40b7. Reason for revert: crbug.com/887263 and crbug.com/887398 Original change's description: > Use SharedImageInterface for gpu and OOP raster > > This wires up SharedImageInterface all the way to cc, and uses it for OOP and GPU raster. > This also adds memory accounting in SharedImageFactory/SharedImageStub. > > Bug: 870116 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I37eba221bc2aeb4d03b7d4d93bde772482dc681b > Reviewed-on: https://chromium-review.googlesource.com/1178977 > Commit-Queue: Antoine Labour <piman@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592419} TBR=sadrul@chromium.org,boliu@chromium.org,piman@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 870116 Change-Id: Ie4fbd60787c6fc3cefbc695595bc80234be6cfc1 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1236457Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fd2e62420dba..84df59e3758f Created with: gclient setdep -r src-internal@84df59e3758f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6af9fafd8ee5b759d036de631d57440e4662e976 Reviewed-on: https://chromium-review.googlesource.com/1236873Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592849}
-
Peter Kasting authored
Per markchang@, this is dead. Bug: none Change-Id: I56751472d648fce8df797f860f0bf088dbc7b5f5 Reviewed-on: https://chromium-review.googlesource.com/1235310Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#592848}
-
Khushal authored
We deserialize skia data while holding a lock, which we block on if skia tries to delete a handle as this data is creating new entries in the strike cache. R=ericrk@chromium.org Bug: 887422, 887152 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id32cb071834186e7de0dac16902c452c3ccdb102 Reviewed-on: https://chromium-review.googlesource.com/1236455Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#592847}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d511948b9f82..52ea49706fd7 git log d511948b9f82..52ea49706fd7 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 jmadill@chromium.org Vulkan: Enable a few BufferDataTests. Created with: gclient setdep -r src/third_party/angle@52ea49706fd7 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I9c4dd0eaec2f340de1304de2b5085ec4ed773ce7 Reviewed-on: https://chromium-review.googlesource.com/1236519Reviewed-by:
-
Guido Trotter authored
Since legacy supervised users are unsupported assume any call returns false and simplify the code accordingly. IsSupervised() calls are for now not affected Signed-off-by:
Guido Trotter <ultrotter@chromium.org> Bug: 882802 Change-Id: Id2f382aed0f919970dde46544bfacadde9247935 Reviewed-on: https://chromium-review.googlesource.com/1233577Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#592845}
-
Francois Doray authored
Bug: 833989 Change-Id: Id97ab3cf302067670b5a90e38d2077f1b7b3e89e Reviewed-on: https://chromium-review.googlesource.com/1231299Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#592844}
-
Lei Zhang authored
Change-Id: I6d2cc26c552a6f9947ebbc19066304446a9e3a44 Reviewed-on: https://chromium-review.googlesource.com/1235342Reviewed-by:
Ben Wagner <bungeman@google.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#592843}
-
Christian Biesinger authored
It's somewhat expensive to compute it. R=mstensho@chromium.org,ikilpatrick@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic1fc1b7b2e11c18a96a268fb731716d074940a36 Reviewed-on: https://chromium-review.googlesource.com/1235213Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#592842}
-
Jordan Demeulenaere authored
Bug: 806868 Change-Id: I64212a92405c2021e42b37f7c8b60ae28cc86aca Reviewed-on: https://chromium-review.googlesource.com/1233699Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#592841}
-
Lukasz Anforowicz authored
Cross-Origin Read Blocking (CORB) was enabled by default in 68.0.3410.0. Since this feature has shipped quite a while ago, it seems that now is a good time to remove the code responsible for enabling/disabling the feature. Bug: 802835 Change-Id: I11b3058447607b31cb27a3e7dbc8db137411d7b8 Reviewed-on: https://chromium-review.googlesource.com/1228485Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#592840}
-
Xiyuan Xia authored
- Add content_browsertests in single process mash mode to bots; - Add a filter file of the failed/flaky tests; Bug: 874089 Change-Id: I806556b0de0b4ee154d03395a566d0e6610eb5c3 Reviewed-on: https://chromium-review.googlesource.com/1234258Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592839}
-
Gauthier Ambard authored
This CL removes the class triggering the animations for the tools menu button in the toolbar. It is now directly triggered by the BVC. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I19feafb03776741bbde51fe54ace27b990811b2e Reviewed-on: https://chromium-review.googlesource.com/1236655 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592838}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5e97145328bd..3d81f7cc222b git log 5e97145328bd..3d81f7cc222b --date=short --no-merges --format='%ad %ae %s' 2018-09-20 dtu@chromium.org [pinpoint] Add try job and latency stats. Created with: gclient setdep -r src/third_party/catapult@3d81f7cc222b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:887168 TBR=sullivan@chromium.org Change-Id: I182425628bb8f5540341ea21ff8da31cfca3104b Reviewed-on: https://chromium-review.googlesource.com/1236516Reviewed-by:
-
Mugdha Lakhani authored
when one of the settled fetches has a response with a bad status. Bug: 876691 Change-Id: I45af6b792a6a43e5b091bc5fe6f40d011bdabac5 Reviewed-on: https://chromium-review.googlesource.com/1233693Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#592836}
-
Rune Lillesveen authored
Change-Id: I7d928fc9847413805dd3179d49b13736fb8f6450 Reviewed-on: https://chromium-review.googlesource.com/1235993Reviewed-by:
Anders Ruud <andruud@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#592835}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/207cfdfbd889..0ad0c27a0bce git log 207cfdfbd889..0ad0c27a0bce --date=short --no-merges --format='%ad %ae %s' 2018-09-20 buildbot@webrtc.org Roll chromium_revision cc7b9c68..a7544fa3 (592452:592771) Created with: gclient setdep -r src/third_party/webrtc@0ad0c27a0bce The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4f478b6b1fd08dfe415a8435c5f5b28c32ea3f23 Reviewed-on: https://chromium-review.googlesource.com/1236515Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5d2918e8ee83..e6dfe41ffa6e git log 5d2918e8ee83..e6dfe41ffa6e --date=short --no-merges --format='%ad %ae %s' 2018-09-20 hjd@google.com perfetto-ui: Rename rawQuery to query 2018-09-20 hjd@google.com Merge "perfetto-ui: Remove engine worker proxy hacks" Created with: gclient setdep -r src/third_party/perfetto@e6dfe41ffa6e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I524fc5b7b49b9ec91b5d513f48d0344d937e38c2 Reviewed-on: https://chromium-review.googlesource.com/1236474Reviewed-by:
-
Finnur Thorarinsson authored
The SelectableListToolbar is setting FocusInTouchMode to true for all its children. This is problematic for the Done button, as it then requires two taps to click. Also, while I was at it, use the same styling for the Done button as the Done button in the Contacts Picker. Bug: 813422, 656015 Change-Id: I277626563885621b3bf677697d464a3299e6658f Reviewed-on: https://chromium-review.googlesource.com/1236435 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#592832}
-
Weiliang Chen authored
Skip GLImageNativePixmap tests and GLSurfaceEGLTest.SurfaceFormatTest for MSAN. TBR=kbr Bug: 886995 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1b29243bd8219e81187aa0e8c5d8f50371423126 Reviewed-on: https://chromium-review.googlesource.com/1236833 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#592831}
-
Sergey Poromov authored
AuthFailure was remembered in OnAuthFailure() by a pointer and was freed after that leading to strange failure reason on next read. It was introduced 5 years ago in https://crrev.com/22900017 [719:719:0918/112724.240220:ERROR:auth_status_consumer.h(95)] NOTREACHED() hit. [Reason: info:NOTREACHED()] [719:719:0918/112724.240293:ERROR:device_event_log_impl.cc(159)] [11:27:24.240] Login: cryptohome_authenticator.cc:725 Login failed: [719:719:0918/112724.240371:ERROR:login_performer.cc(63)] Login failure, reason=0, error.state=0 [719:719:0918/112724.240414:ERROR:kiosk_profile_loader.cc(202)] NOTREACHED() hit. [Reason: info:NOTREACHED()] [719:719:0918/112724.240458:ERROR:auth_status_consumer.h(95)] NOTREACHED() hit. [Reason: info:NOTREACHED()] [719:719:0918/112724.240445:ERROR:kiosk_profile_loader.cc(188)] Kiosk auth failure: error= [719:719:0918/112724.240674:ERROR:kiosk_profile_loader.cc(50)] NOTREACHED() hit. [Reason: info:NOTREACHED()] [719:719:0918/112724.240732:ERROR:app_launch_controller.cc(526)] Kiosk launch failed, error=4 Bug: 885346 Change-Id: I46ca3b3630aa42e25a25d9cfecb3a16e3c361b9f Reviewed-on: https://chromium-review.googlesource.com/1236265Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#592830}
-
