GitLab

Bug: 516866
Change-Id: I8f1fce1850629fef4f7d2eb81adc57a6f74429ea
Reviewed-on: https://chromium-review.googlesource.com/c/1292879
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601904}

Change method API to take resulting FilePath as input pointer, and
return bool to indicate success or otherwise since it is not
guaranteed that input will always convert.

Bug: 878324
Change-Id: I17f99201c2c4b5105cceb48d6a3c0d57b80c5f7b
Reviewed-on: https://chromium-review.googlesource.com/c/1295634
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601903}

Using wpt-import in Chromium 9f335772.
With Chromium commits locally applied on WPT:
f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26606

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
binji@chromium.org:
  external/wpt/wasm
mstensho@chromium.org:
  external/wpt/css/css-multicol

NOAUTOREVERT=true
TBR=markdittmer

No-Export: true
Change-Id: I7b2098968d56e8bb52fa36cf8b02451e7b1ad4ad
Reviewed-on: https://chromium-review.googlesource.com/c/1296061
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601902}

When NetworkService/ServiceWorkerServicification is on, MimeSniffingThrottle is
used for responses from service workers. Previously, downloading is skipped when
any of throttles handle the response, so using MimeSniffingThrottle undesirably
prevented downloading. This CL is to make downloading work properly when a
service worker serves the response.

Also, when a response is NOT served from ResourceDispatcherHost,
DownloadManagerImpl needs to be created in NavigationRequest. Currently it
happens only when NetworkService is on. This CL adds a condition where S13nSW is
on and a service worker serves the response there.

TBR=jam@chromium.org

Bug: 896696
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I222d8148cf65d15492393ebcd6ed582deb14022f
Reviewed-on: https://chromium-review.googlesource.com/c/1290434
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601901}

Lifecycle dispatching is important for modularization and decoupling.
Currently we see activities having heaps of code in lifecycle methods
touching lots of different classes. These classes often pass the events
further down to their dependencies. To have less coupling, classes should
be able to subscribe to lifecycle events and handle them on their own.

This is especially important for the destruction event. Having a public
destroy() method and relying on some other object to call it is unreliable
and easily produces memory leaks. See, for example,
https://chromium-review.googlesource.com/c/chromium/src/+/1172425/4/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

With DI, this is even more important. Whereas without DI whoever creates an
object "owns" it, and is responsible for destroying it, with DI there
is no such ownership (at least for scoped classes), as the instances are
created and held by Components. At the same time, DI makes implementing
lifecycle dispatching easy.

In this CL I introduce the lifecycle dispatching and provide a simple
usage example in Contextual Suggestions classes. Another example
can be seen in the upcoming CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1281102/1/chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityUi.java

Bug: 887926
Change-Id: I81a43406df320544bc55732f622704109631a232
Reviewed-on: https://chromium-review.googlesource.com/c/1283256
Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601900}

Before: Reconfigure Sync only when the *last* handle is released.
After: Reconfigure Sync whenever a handle is released, whether there
are any others or not.

On desktop, this fixes the case where a chrome://settings/syncSetup
tab is left open and forgotten somewhere, which previously prevented
Sync from ever applying new settings.

On Android/iOS, only one Sync setup UI can be visible at a time, so
this doesn't change any behavior. However, we now need to be careful
not to needlessly re-create the handle.

Bug: 884159
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ib61d063ac8b6e76d05a5b72d17de7b1e031a51dd
Reviewed-on: https://chromium-review.googlesource.com/c/1280208
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601899}

This reverts commit 56d26cfc.

Reason for revert: Crashes in Canary - https://crbug.com/897576#c3

Original change's description:
> sqlite: Upgrade from 3.24.0 to 3.25.2
> 
> The new release changes how ALTER TABLE RENAME is implemented, and
> requires an update to WebSQL's SQLite authorizer. This CL includes the
> update, and extends the LayoutTest for the authorizer to cover the
> newly implemented column renaming functionality.
> 
> Bug: 892852
> Change-Id: I58fdc2927cacb6ccc84a741d7fc519fb2e5b8721
> Reviewed-on: https://chromium-review.googlesource.com/c/1266881
> Reviewed-by: Chris Mumford <cmumford@chromium.org>
> Commit-Queue: Victor Costan <pwnall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600637}

TBR=cmumford@chromium.org,pwnall@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 892852
Change-Id: I6f5ace9dcb431d5423232880e8f1b2cf0873066a
Reviewed-on: https://chromium-review.googlesource.com/c/1296062
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601898}

Http caches are owned by network service when network service is enabled
otherwise they are owned by browser thread. HttpCaches are cleared by
StoragePartitionHttpDataRemover on browser thread when network service
is not enabled. However, with network service enabled they are cleared by
a different mechanism by the network service.

GeneratedCodeCaches are owned by the browser process and clearing them
should be cleared by the browser process. Hence clearing the
GeneratedCodeCache along with HttpCaches in StoragePartitionDataRemover
doesn't work. This cl refactors the clearing of code caches into a separate
class, so it can be used both with and without network service.

Bug: chromium:892652
Change-Id: I5238de412f35f3dc90ae69c37b76e83d34a0d089
Reviewed-on: https://chromium-review.googlesource.com/c/1270946Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601897}

ElapsedTimer is a small useful utility class for measuring time.
As a wise Greek may put it: "The unmeasured time is not worth having".

Here is discussion that inspired this CL: https://chromium-review.googlesource.com/c/chromium/src/+/951922#message-fca340ea66b052ad7ee1d6e92d42b61ac549456d

Change-Id: Iebd3d49c1965fd0b1a16ad0eeee7af302a6afbf3
Reviewed-on: https://chromium-review.googlesource.com/c/1295177Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601896}

https://android.googlesource.com/platform/external/perfetto.git/+log/d28f8451a549..1c752c1ef387


git log d28f8451a549..1c752c1ef387 --date=short --no-merges --format='%ad %ae %s'
2018-10-23 primiano@google.com UI: seamlessly migrate to catapult UI for legacy traces


Created with:
  gclient setdep -r src/third_party/perfetto@1c752c1ef387

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:117977226
TBR=perfetto-bugs@google.com

Change-Id: Iba831326e2c67abc5a3a3f3a15a7df3dc8899849
Reviewed-on: https://chromium-review.googlesource.com/c/1295741Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601895}

Preparation to create a new SettingsSwitchItem for TableView.

Bug: 894791
Change-Id: Icd88aa0a5af519172b0750782f3b029ac2cc7d29
Reviewed-on: https://chromium-review.googlesource.com/c/1296189Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601894}

This CL adds UMA to the re-registration flow to observe number of
triggered, successful and unsuccessful re-registrations attempts.

DD: go/handle-purged-user-sessions

Bug: 870616
Change-Id: Ic963d321fb84cac55a61571b49e4a41554872589
Reviewed-on: https://chromium-review.googlesource.com/c/1283026
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601893}

This matches how we create constraint spaces, and is more efficient.

Change-Id: Ifd52cf754efd9d921d8042175756988909db15f8
Reviewed-on: https://chromium-review.googlesource.com/c/1292563
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601892}

We've recently received reports of DCHECK failures reflecting an
inconsistent state in the processor's tracker. The problematic scenario
is as follows:
1. There's a pending local creation, which starts with a temporary
   server ID. At the processor/tracker level, this means an empty ID.

2. A remote deletion is received for the same entity (same client tag
   hash), which is treated as conflict.

3. The default conflict resolution will choose to "undelete" the entity,
   that is, the creation should prevail over the deletion. However, the
   temporary server ID must be overriden with the real one as provided
   in the remote update (deletion).

Prior to this patch, ProcessorEntityTracker::RecordIgnoredUpdate() did
partially handle this scenario because the server ID in |metadata_| was
updated. However, the analogous ID in cached |commit_data_| also needs
to be updated.

The underlying issue has been around for very long but was reproduced
consistently with recent ongoing experiments that exercise local
deletions far more often.

Bug: 896138
Change-Id: I53a4e0447d2b809c5691a739a220046c8642156a
Reviewed-on: https://chromium-review.googlesource.com/c/1296169
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601891}

Also convert a call to SigninManagerBase::IsAuthenticated() to
IdentityManager::HasPrimaryAccount().

Bug: 887462
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Id2d40b7d6e9064a7fa2d64dc3d9a8914d18e795b
Reviewed-on: https://chromium-review.googlesource.com/c/1288542
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601890}

Bug: chromium:897074
Change-Id: Id9dd6a634fce75e39f1d01f832337ff8702e042c
Reviewed-on: https://chromium-review.googlesource.com/c/1293452Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601889}

R=mek@chromium.org

Bug: 897764
Change-Id: I256e6d3a051f56fff9f07a4b09b490086a6474d5
Reviewed-on: https://chromium-review.googlesource.com/c/1296190Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601888}

About to be deleted, see
https://webrtc-review.googlesource.com/c/src/+/107303

Bug: None
Change-Id: I1c92b62d7007ccf47ca13c5b22571530d4168494
Reviewed-on: https://chromium-review.googlesource.com/c/1293611
Commit-Queue: Niels Möller <nisse@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601887}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/59681844cbb6..6e40cdcfce94


Created with:
  gclient setdep -r src-internal@6e40cdcfce94

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I8f210131a5b108a6518ef35ea394b3847297ae36
Reviewed-on: https://chromium-review.googlesource.com/c/1295740Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601886}

This code assumes that the WebContents owning a RenderFrameHost
outlives the RenderFrameHost, since otherwise RenderFrameHost would
have a dangling |delegate_| pointer. This is apparently false, so
this CL makes sure the RenderFrameAudio{In,Out}putStreamFactory
refers to the ForwardingAudioStreamFactory by a weak pointer.

Test: In addition to CQ, AudioPlayerBrowserTest.ChangeTracks was
repeated 1000 times locally with CrOS/ASAN to ensure it didn't flake.

Bug: 897043
Change-Id: I77925403e95ba8edc7cfaa5db23dc8fe5fd70f93
Reviewed-on: https://chromium-review.googlesource.com/c/1293572Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601885}

Bug: 888447
Change-Id: I3170ed456f8ccc08912e490cdfb1200789533b66
Reviewed-on: https://chromium-review.googlesource.com/c/1283040Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601884}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/12724252ffc5..f4c4ce79c2d8


git log 12724252ffc5..f4c4ce79c2d8 --date=short --no-merges --format='%ad %ae %s'
2018-10-23 derat@chromium.org cbuildbot: Clean up cros_run_tast_vm_test mention.


Created with:
  gclient setdep -r src/third_party/chromite@f4c4ce79c2d8

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I473d3fe5452082e97c9ea1742513a8ba02a908e5
Reviewed-on: https://chromium-review.googlesource.com/c/1295738Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601883}

When using import mode, we used to assign output_fds last, during
the call to AssignEGLImage(). However this can also be done ahead of
time in ImportBufferForPictureTask(). Doing so allows us to stop passing
the DMABUF FDs as an argument to AssignEGLImage(), simplifying its
interface as well as the code in ImportBufferForPictureTask().

BUG=792790
TEST=Checked that VDA unittest was passing on Hana, in import and
non-import mode, with rendering enabled or not.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I95b66f7b3b4ee31147b2eb34a19499c39ad4efa8
Reviewed-on: https://chromium-review.googlesource.com/c/1288497Reviewed-by: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601882}

Using wpt-import in Chromium e680714f.
With Chromium commits locally applied on WPT:
f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26605

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=markdittmer

No-Export: true
Change-Id: Ibfd8e1c24df1f008382c275654664dbfed11c7c7
Reviewed-on: https://chromium-review.googlesource.com/c/1296056
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601881}

https://skia.googlesource.com/skia.git/+log/e023ae7c5540..1b07dffd979d


git log e023ae7c5540..1b07dffd979d --date=short --no-merges --format='%ad %ae %s'
2018-10-23 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset


Created with:
  gclient setdep -r src/third_party/skia@1b07dffd979d

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@chromium.org

Change-Id: I9fe258c29f0b0cb3d5036ab7f11d9bc468f38557
Reviewed-on: https://chromium-review.googlesource.com/c/1295736Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601880}

1. Tested on Mac and verify everything works as expected.
2. Removed the unnecessary call of GetNativeWindow().

Change-Id: I377e6bfb004548887b9623b0094da91fa36b4d1c
Reviewed-on: https://chromium-review.googlesource.com/c/1279301Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601879}

ClientTagBasedModelTypeProcessor should never reset |model_error_|,
which is believed to be an accidental behavioral change in
https://chromium-review.googlesource.com/923982

The rationale is, a USS model is not expected to be recoverable after
an error has occurred (e.g. I/O error).

In most cases, this makes little difference because the processor
reports the error to ModelTypeController, and the FAILED state is not
recoverable.

Semi-related, we should immediately disconnect from the sync engine
(ModelTypeWorker), because further remote changes should be ignored.

In addition to all this, we also now expose the error state in
interface ModelTypeChangeProcessor, for bridges that need to be aware
of this error state, and may want to stop further work.

Bug: 870624
Change-Id: I404ccff60fcadf7f5a2b8fe4a76882ba1c7edd52
Reviewed-on: https://chromium-review.googlesource.com/c/1293579
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601878}

If drivefs needs to restart there is no need to redo all the job for
oauth token minting as the previous one should still be good.

BUG=chromium:897558

Change-Id: I4e1737a94a70476c6312ff11c04b8f3f233e4512
Reviewed-on: https://chromium-review.googlesource.com/c/1293058
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601877}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7cc69c43..a50f4057

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ie4bbeb083976053c97611a6e3a2682333191cf58
Reviewed-on: https://chromium-review.googlesource.com/c/1296055Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601876}

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: I91647355e2e9d955fcf62020fca175182f35e467
Reviewed-on: https://chromium-review.googlesource.com/c/1293258Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601875}

It is not used for now.

Bug: 875698
Change-Id: I2de44ec120deccebb36a2f031843122963bd13f4
Reviewed-on: https://chromium-review.googlesource.com/c/1295759Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601874}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/102fbc903296..59681844cbb6


Created with:
  gclient setdep -r src-internal@59681844cbb6

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: If4a3367659801055791b476812624f9d1cef3a55
Reviewed-on: https://chromium-review.googlesource.com/c/1295737Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601873}

Using AXTableInfo to dynamically compute some table properties
was a good idea, but the interface to it was too complicated,
it required clients to understand how AXTableInfo is computed
on-demand.

Instead, create a high-level API to retrieve table info
on AXNode that makes use of AXTableInfo behind the scenes.
That simplifies all of the code in content/browser/accessibility
and chrome/renderer/extensions that previously needed to know
how AXTableInfo worked.

Bug: 832289

Change-Id: Ie57ef9652ac471498f4c0766e9550fd8b8165794
Reviewed-on: https://chromium-review.googlesource.com/c/1145769
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601872}

It is not a general purpose substitute for the default std::string
constructor. Do the same for base::EmptyString16() and base::string16().

Change-Id: I49016d1a97f40818e9387d4cd16e859e19d6eed3
Reviewed-on: https://chromium-review.googlesource.com/c/1295181Reviewed-by: Shu Chen <shuchen@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601871}

This CL removes a FormData -> timeticks map that was tracking the
timestamp at which a given form instance was loaded/parsed. This
is superfluous with the timestamp tracking provided by FormStructure.

This memory used by this map was sufficiently large to show up in the
heap profiler analyses as a top potential memory leak.

Bug: 885390
Change-Id: If44d18d54e26a745d678c5a8b5387cc2fb5dbbf0
Reviewed-on: https://chromium-review.googlesource.com/c/1286438
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601870}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I1dd74a4212ecb0d3cb4e7386507b179a9ef2a4ce
Reviewed-on: https://chromium-review.googlesource.com/c/1295739Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601869}

Before creating the constraint space for child layout, we need to
calculate the line-left offset for the child. This requires us to
calculate the inline margins. If there are no auto inline margins and no
special alignment involved, we have everything we need, and can defer
fully resolving the margins until right after child layout (when we
actually do know the inline size of the child).

Only create a temporary constraint space for margin resolution if we
need to calculate the inline size of the fragment before layout to
calculate the line-left offset.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: If84e4d6360c537a8c3a662c2617bef9dece7a644
Reviewed-on: https://chromium-review.googlesource.com/c/1286425Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601868}

DRP currently handles this by modifying the proxy list to only have a
specific proxy in the ProxyDelegate if the request is for a warmup
URL. This change implements equivalent functionality when using the
network service by creating a new NetworkContext with only the relevant
proxy set in the custom proxy config, and using that context when
making the warmup request.

Bug: 721403
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I10e2ae5a7493526c24ac35c6db9a4d33dbbc6c8c
Reviewed-on: https://chromium-review.googlesource.com/c/1289165
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601867}

https://chromium.googlesource.com/angle/angle.git/+log/5a2069501490..19603b9e7b20


git log 5a2069501490..19603b9e7b20 --date=short --no-merges --format='%ad %ae %s'
2018-10-23 jiajia.qin@intel.com ES31: Allow function call, unary, ternary operators in SSBO


Created with:
  gclient setdep -r src/third_party/angle@19603b9e7b20

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: I8b92d7713d6088f42ea3e0539136510805137473
Reviewed-on: https://chromium-review.googlesource.com/c/1295734Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601866}

Change-Id: I70abcd04649b4f91cba16ff364a61378e6ac0f0f
Reviewed-on: https://chromium-review.googlesource.com/c/1291189Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601865}