- 06 Jul, 2020 40 commits
-
-
chrome://managementOlya Kalitova authored
Adds information about Plugin VM data collection to transparency panel (chrome://management). This info is visible when Plugin VM data collection is enabled on user's device. Test: manually using YAPS Bug: b/150908305 Change-Id: I99e7b66cc3a765166d216ea6f24cfb32f16eb6d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279119Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Greg Levin <glevin@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#785353}
-
Xida Chen authored
This is a code health CL, no behavior change is expected. Bug: 1007635 Change-Id: Id17a2384f61dff048d56a70cbe296133a77d5877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278438 Auto-Submit: Xida Chen <xidachen@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#785352}
-
WangHui authored
Use the compositor which was find by the id from ParentDrawData. Bug:None Signed-off-by:
WangHui <wanghui210@huawei.com> Change-Id: I9325261220e8882ce9cfeb4f00231142edaff671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279290 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#785351}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594014961-7d45cb9775a1becec1c537c70e86c3de2e101ea0.profdata to chrome-mac-master-1594035519-bdce305e14959d596c45f90edc11488f647eb05b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,jeffyoon@google.com Change-Id: I071bbf6b8ae7864a14e6240e19e9b2ec23012a98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282854Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785350}
-
Xida Chen authored
This is a code health CL, no behavior change is expected. Bug: 1007635 Change-Id: Ia55e2b9bc6a372602acf987cbc40a2412c4d9533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278352Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Auto-Submit: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#785349}
-
Takashi Toyoshima authored
The metric was already expired, but code was mistakenly remained. This CL also marks the relevant enum as removed. Bug: 1050617 Change-Id: I73fec865c8e54b955ee0a21d530a5f42f33eecd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282823 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#785348}
-
Alex Rudenko authored
The test was disabled for a DevTools roll in: https://chromium-review.googlesource.com/c/chromium/src/+/2279816 Bug: 829319 Change-Id: I6a2c24feeecb2f12a09d6406bd2123b0b70dd437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282803 Auto-Submit: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#785347}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d7d2f27b1bb5..c7f0dff19180 2020-07-06 sdefresne@chromium.org Convert GN libs lists to frameworks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1052560 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic2469b3fd92daf8762a33afaf62d5db3bf0e8d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282852Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785346}
-
Koji Ishii authored
This patch simplifies |DirtyLinesFromNeedsLayout| to check |NeedsLayout| of top-level children only. The previous code tried to reuse more lines, e.g.: <div><span>many lines of text</span></div> Most lines are reusable when appending to the end of "text". But supporting this case complicates the logic, especially when culled inline is involved. The new logic can't reuse lines in the above case, but still can reuse liens if the `<span>` does not exist, and should cover most common cases. Bug: 1102083 Change-Id: I4f76e154b834c8c00e5ce04ab251c4f1fcdabab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282821Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#785345}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6e0f4bee6932..f38168a9107e 2020-07-06 janscheffler@chromium.org Fix stylelint-config-standard issues in profiler/heapProfiler.css 2020-07-06 tvanderlippe@chromium.org Fix generated tsconfig in devtools_entrypoint 2020-07-06 kprokopenko@google.com [issues] Update protocol for surfacing CSP issues in issue tab 2020-07-06 yangguo@chromium.org Fix stylelint-config-standard issues in protocolMonitor.css 2020-07-06 alexrudenko@chromium.org Fix stylelint-config-standard issues in sources/navigatorTree.css 2020-07-06 yangguo@chromium.org Fix stylelint-config-standard issues in timeline/timelinePanel.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1061037,chromium:1082628,chromium:1083142,chromium:1098730,chromium:1101738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I28ce7f081ab511f23a7c209cf025a6af5c2202e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282848Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785344}
-
Sylvain Defresne authored
Since gn now generates a project that wraps the invocation of ninja in a script converting relative paths to absolute paths, there is nothing blocking the use of the New Build System. Bug: 852522 Change-Id: I9b4ca343dc9434efb64a3866ca88d6b7c4065760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276281Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#785343}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1593970160-b868b25d854d27d062f6932d7e877d2efc883cc1.profdata to chrome-win64-master-1594014961-b33fec47337d1f487e4dacf5d1b618dace5d3422.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Id6594e1f30e6b02561ae7d27cad48ac6f2fd388d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282275Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785342}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/350be7ea7229..9c6d11136851 2020-07-06 ilkos@google.com Do not emit metadata if empty If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I22eb39294529fbcedec53e35b170eb3b7c08e623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282847Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785341}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib2d79f1059a09f190ca8d3ebc4a7170fa2e6d5a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283041Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785340}
-
Antonio Gomes authored
API clean up: the helper function isn't strictly needed anymore. BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ifbded32ccc9c06fd4bd1a5953acac236c89dd0be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280223 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#785339}
-
arthursonzogni authored
On Oreo, disable the test: org.chromium.chrome.browser.signin.SigninFragmentTest#testClickingSettingsDoesNotSetFirstSetupComplete TBR=triploblastic@chromium.org Bug: 1102296 Change-Id: I8b4fb32d75488ab322e0108ad94b6e5c60be9452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282585Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#785338}
-
Yuki Yamada authored
VectorBackedLinkedList::clear() is called during IntersectionObserver's custom weak processing. In current implementation, it clears everything and then add back the anchor node, but we can avoid the allocation using Vector::ShrinkCapacity(). Bug: 1100257 Change-Id: I2cb00b4a1ac32d1b61ac3d81c13323634fd31cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279296 Commit-Queue: Yuki Yamada <yukiy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#785337}
-
Vikas Soni authored
1. Refactor SharedImageVideo backing to use SharedImageBackingAndroid and SharedImageRepresentationSkiaVkAndroid. 2. Move GetAhardwareBuffer and VkImage creation from Representation's BeginRead to ProduceSkia. Bug: 1091945 Change-Id: Ic08616f37754c864d0059c38b0a64f1f296b1ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281478 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#785336}
-
arthursonzogni authored
The following tests were flaky on Marshmallow the last ~10 build: org.chromium.chrome.browser.payments ├──ExpandablePaymentHandlerChangePaymentMethodTest │ ├──testDetails │ ├──testDetailsBasicCard │ ├──testReject │ └──testThrow ├──ExpandablePaymentHandlerChangePaymentMethodTest │ └──testThrowBasicCard ├──ExpandablePaymentHandlerTest │ ├──testNavigateBackWithSystemBackButton │ ├──testSecureConnectionShowUi__CERT_AUTO │ ├──testSecureConnectionShowUi__CERT_COMMON_NAME_IS_DOMAIN │ └──testSecureConnectionShowUi__CERT_OK_BY_INTERMEDIATE ├──PaymentHandlerChangePaymentMethodTest │ ├──testDetails │ ├──testDetailsBasicCard │ ├──testNoEventHandlerBasicCard │ ├──testReject │ ├──testRejectBasicCard │ └──testThrow ├──PaymentHandlerEnableDelegationsTest │ ├──testPartialDelegationContactInfoNotSupported │ ├──testShippingAndContactInfoDelegation │ └──testShippingDelegation ├──PaymentRequestPaymentMethodIdentifierTest │ └──testAddMasterCard └──PaymentRequestRemoveBillingAddressTest └──testPayWithCard TBR=rouslan@chromium.org Bug: 1102320 Change-Id: I182afa734c763abb5d377c5fde8a2510e85b6794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283162Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#785335}
-
Vikas Soni authored
Add initial read fence to SharedImageRepresentationAndroidSkiaVk to wait on before reading vulkan image. Bug: 1091945 Change-Id: Ie35002f717e3719eeda5b3e0a50996077ad56151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281729Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#785334}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/62032d45924e..d7d2f27b1bb5 2020-07-06 eshr@google.com [Adaptation] Adaptation holds restrictions 2020-07-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 33c9ff52..a9cc4f47 (785166:785286) 2020-07-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a245a047..33c9ff52 (785063:785166) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I07a6f5e5b0a5bbb008310d746bac194f7b087a56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282846Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785333}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4efe8f9cce59..6e0f4bee6932 2020-07-06 kimanh@chromium.org Fix stylelint-config-standard issues in 2020-07-06 petermarshall@chromium.org Disable eslint test name check 2020-07-06 tvanderlippe@chromium.org Temporarily fix TypeScript verification build 2020-07-06 petermarshall@chromium.org Disable flaky e2e tests that are blocking trybots 2020-07-06 yangguo@chromium.org Fix stylelint-config-standard issues in ui/treeoutline.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1073406,chromium:108314,chromium:1083142,chromium:1102324 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4b82fd63fc346a6565aa2a0a213823481b42672d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282844Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785332}
-
Yoshifumi Inoue authored
This patch changes |StartOfSentencePosition()| to return null-position for null-position to avoid to hit DcHECK for non-null position in |TextSegments::FindBoundaryBackward()|. Bug: 1100971 Change-Id: Iacaa706be454ef0334c1524703eaeddf56bfe1dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280978 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#785331}
-
Victor Hugo Vianna Silva authored
This CL updates TODOs pointing to closed b4p bugs to point to the newly filed follow-up bugs. Bug: None Change-Id: I86ba9fb58a83f7cba33c6d001e4cd00008d7f3ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282582Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#785330}
-
arthursonzogni authored
Disabled tests: org.chromium.chrome.browser.keyboard_accessory... ...AutofillKeyboardAccessoryIntegrationTest #testSelectSuggestionHidesKeyboardAccessory__default ...ManualFillingIntegrationTest #testAccessoryHiddenAfterTappingAutoGenerationButton #testAccessorySheetHiddenWhenRefocusingField #testInfobarReopensOnPressingBack #testInfobarStaysHiddenWhenOpeningSheet #testKeyboardAccessoryDisappearsWithKeyboard #testKeyboardAccessoryHiddenUntilKeyboardShows #testMovesUpSnackbar #testPressingBackButtonHidesAccessorySheet #testSelectingNonPasswordInputDismissesAccessory ...ManualFillingUiCaptureTest #testCaptureKeyboardAccessoryV2WithPasswordsRTL #testCaptureKeyboardAccessoryWithPasswords #testCaptureKeyboardAccessoryWithPasswordsRTL ...sheet_tabs.PasswordAccessoryIntegrationTest #testPasswordSheetDisplaysProvidedItems TBR=fhorschig@chromium.org Bug: 1102302 Change-Id: I537c30a59dd01e9de9e0abb93e1e367cc58dfdbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282802Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#785329}
-
Maksim Ivanov authored
Move the ScopedAllowBlockingForTesting into the TestCertificateProviderExtension class where needed, so that its consumers in tests don't have to worry about it (and also so that the scoped IO allowance is used in the smallest possible scope). This is a pure refactoring CL. Bug: 1067683 Change-Id: I164bd520c3ea9191a58838412628336147029eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280000Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#785328}
-
Maksim Ivanov authored
Create a test mixin ExtensionForceInstallMixin that helps in testing of force-installed extensions. In this initial version, only device policy faked via DevicePolicyCrosTestHelper is supported; the extension has to be already packed into a CRX file. The mixin hosts the CRX file in an embedded test server, generates and hosts an update manifest XML and configures the device policy. Also partially migrate signin_profile_extensions_policy_browsertest.cc to the new mixin. Bug: 1090941 Change-Id: Ic2b82dc15d0bfcf18e68d267d78312ce2311789f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277812Reviewed-by:
Omar Morsi <omorsi@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#785327}
-
Richard Knoll authored
This component will render a preview of the to-be-shared content. This might be an image or some text for example. For now it renders a placeholder image and a title text below it. This component will be used from the confirmation-page and discovery-page. Bug: 1099710 Change-Id: I6331fa196a54d02662cd621e3c28ef15cb65de5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277734Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#785326}
-
Javier Ernesto Flores Robles authored
Removes DCHECK as success = false is now expected sometimes. Logs the error to UMA to be analyzed in the future. Bug: 1091927, 1095620 Change-Id: I64e1a662d9f936d8891c3e31eb2e2c14573829c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275896 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#785325}
-
Eugene Zemtsov authored
Apparently macros don't support histograms with suffixes, and we need to use a function for roughness, otherwise it triggers a DCHECK when the name changes. Bug: 1101907 Change-Id: Ie64da90f3a1929653f5c1a6453b680aad4646990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280465Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#785324}
-
Philipp Hancke authored
BUG=chromium:894057 Change-Id: Ibeb60e70c08fccc45886476ed4f459cd09ae9b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282921Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#785323}
-
Stephan Hartmann authored
'-Wdelete-non-abstract-non-virtual-dtor' is a clang-only flag. Switch pragma diagnostic from GCC to clang. Bug: None Change-Id: Ic4488d9f95b351bcf74eeb4dba5bf568405948e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279981Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#785322}
-
Bartek Nowierski authored
The USE_PARTITION_ALLOC_AS_MALLOC check encompassed too code in AllocFromBucket, effectively disabling memset(kUninitializedByte). This CL makes it more precise so that it only disables cookies and nothing else. Rename Partition*FreePointerAdjust -> Partition*PointerAdjustSubtract while at it, for consistency with the rest of the functions. Bug: 998048 Change-Id: Id0615de9537caf5274ce38a344a07af68c98fd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279269 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#785321}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7231d11baf46..4efe8f9cce59 2020-07-06 alexrudenko@chromium.org Fix stylelint-config-standard issues in sources/watchExpressionsSidebarPane.css 2020-07-06 sawallner@chromium.org Fix stylelint-config-standard issues in ui/viewContainers.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9ce287f13db240fc2db515a3f231d06756094786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282843Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785320}
-
Stepan Khapugin authored
Cleans up a few more now-unused methods in guts protocols. Bug: 1045660 Change-Id: I244ef31eb8ea7ef413f64328c3515a0dac7de9c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279884Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#785319}
-
Carlos Caballero authored
Defer cache lookup to until sandbox checks have been performed. Bug: 1051491 Change-Id: I8f31e8301b7270050bf324c04bcd853f4638670e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277882 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#785318}
-
Sigurd Schneider authored
The new unittest is here: https://crrev.com/c/2282504 Bug: chromium:1060613 Change-Id: I258aa87e3637322eb4aa7b7c2a5d4b2374142a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282923Reviewed-by:
Yang Guo <yangguo@chromium.org> Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#785317}
-
Maggie Cai authored
This CL creates an app service file tasks to allow the files app to query sharing task from app service intent handling backend. This is for testing the backend and it is behind a flag. It might need to be modified after link up with unified sharesheet UI. BUG=1092784 Change-Id: I4ba54f7b2ee9e9ae3fd89184b808c1040a01c288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279411 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#785316}
-
Ella Ge authored
Bug: 1007635 Change-Id: I49ae4220e8b139025e14c63500faff75db75db5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276480Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#785315}
-
Andy Paicu authored
Bug: 1094356 Change-Id: Ie49d2e0d59e851b3b9792370cff2dfeeacf880fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282743Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Auto-Submit: Andy Paicu <andypaicu@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#785314}
-