GitLab

Avoid possibly long blocking times in the Windows SetupDi function
calls made to enumerate devices by offloading to the FILE thread.
Now that we can be sure that a stray request to the device won't
block the UI additional calls to get the device's product and serial
number strings can be made.

BUG=457899

Review URL: https://codereview.chromium.org/936603003

Cr-Commit-Position: refs/heads/master@{#316939}

Also convert FormStructure::GetFieldTypePredictions() to return its data instead of using an out parameter.

Review URL: https://codereview.chromium.org/934863003

Cr-Commit-Position: refs/heads/master@{#316938}

The current mechanism is to clean all cache, which is very misleading.

Everytime we call LinkProgram, we simply delete the Program in the map,
getting rid of all cahces, and create a new Program.

BUG=429053
TEST=gpu_unittests
R=bajones@chromium.org

Review URL: https://codereview.chromium.org/933393003

Cr-Commit-Position: refs/heads/master@{#316937}

DEPENDENT on 914813002

* Combines app_banner_metrics_ids.*, app_banner_utilities.*, and
  app_banner_metrics_id_list.* into the app_banner_metrics.* files.

* Gets rid of the Java-side metrics because we can control and react
  to them entirely from native-side calls now.

* Updates the histograms accordingly.

BUG=457416
TBR=thakis

Review URL: https://codereview.chromium.org/929533002

Cr-Commit-Position: refs/heads/master@{#316936}

BUG=415689

Review URL: https://codereview.chromium.org/580233002

Cr-Commit-Position: refs/heads/master@{#316935}

This was reverted due to high crash rates on 10.10.2 (where we don't
full crash reports). This was tested on branch and didn't affect the
crash rate. The next step is to forward the event to the renderer.

BUG=452592

Review URL: https://codereview.chromium.org/940733002

Cr-Commit-Position: refs/heads/master@{#316934}

Many ClientSession unittests assume that the first video frame always
contains video dimensions. When running under valgrind the keep-alive timer
may fire before the first video frame is sent and this breaks the tests.

Fixed VideoFramePump to start sending keep-alive messages only after the
first real frame is sent. Also made the keep-alive timer non-repeating.
This ensures that the pump doesn't try sending a keep-alive message until
the previous one has been sent.

BUG=458691

Review URL: https://codereview.chromium.org/936553003

Cr-Commit-Position: refs/heads/master@{#316933}

Start running connect-to-localhost and connection-alive-after-focus-lost tests for v2 web-app on Linux.
Also, reactivating v2 web-app Auth test on Linux, now that http://crbug/447778 has been fixed.

BUG=

Review URL: https://codereview.chromium.org/941493002

Cr-Commit-Position: refs/heads/master@{#316932}

(Temporarily) copy app compat thumb drawables to chrome/android/java/res. These
were missed in the original CL to fix the app compat switch thumb not always being
drawn (crbug.com/455327).

BUG=459782

Review URL: https://codereview.chromium.org/937903002

Cr-Commit-Position: refs/heads/master@{#316931}

BUG=459400

Review URL: https://codereview.chromium.org/930413003

Cr-Commit-Position: refs/heads/master@{#316930}

BUG=417532

Review URL: https://codereview.chromium.org/927443004

Cr-Commit-Position: refs/heads/master@{#316929}

BUG=405305

Review URL: https://codereview.chromium.org/927483002

Cr-Commit-Position: refs/heads/master@{#316928}

BUG=459649
TBR=calamity@chromium.org

Review URL: https://codereview.chromium.org/939813002

Cr-Commit-Position: refs/heads/master@{#316927}

Adds an ellipsis to the 'Create shortcuts' and 'Remove' buttons, which
both require additional user input.

BUG=448359

Review URL: https://codereview.chromium.org/926993002

Cr-Commit-Position: refs/heads/master@{#316926}

This is a minimal fix to prevent silently doing the wrong thing.
A better fix would resolve names, and use the URL itself as a fallback.

BUG=none

Review URL: https://codereview.chromium.org/938853002

Cr-Commit-Position: refs/heads/master@{#316925}

The plugin is allowed to use Pepper without having bound a PPB_MessageLoop
to the calling thread, which means MessageLoop::current won't be valid.
Instead, we should just post to the Pepper main thread.

BUG=459671

Review URL: https://codereview.chromium.org/938843002

Cr-Commit-Position: refs/heads/master@{#316924}

Uses BrowserURLHandler since this depends on components and can't
live in content.

BUG=449829
TEST=See bug for repro steps.

Review URL: https://codereview.chromium.org/923183003

Cr-Commit-Position: refs/heads/master@{#316923}

r2031: Reland "msvs/ninja win: Fix support for ImageHasSafeExceptionHandlers"
r2032: msvs: Prefer x64 toolset if we are running on 64-bit
r2033: Make msvs-ninja work for target-arch=x64
r2034: ninja/posix: Introduce support for arflags variable.

BUG=453195
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/937843002

Cr-Commit-Position: refs/heads/master@{#316922}

The existing code ends up moving values between threads, whether by
value or hidden in a callback, causing instability and races in edge-
cases, for example when abruptly cancelling the load.

This patch introduces a PendingNotificationTracker, which completely
lives on the same thread as NotificationManager and will store all
information associated with the notification, ensuring that it never
inadvertently leaves the thread.

The NotificationImageLoader lives on the main thread and is in charge
of doing the actual fetch. Rather than storing either a callback with
the Notification's data, it knows a pending notification id given to
it by the PendingNotificationTracker. This allows us to re-associate
the data when the fetched resource(s) are available.

I'm adding some layout tests in the following patch to exercise the
image loader in a number of additional cases. Unit tests will be added
in a follow-up patch.

https://codereview.chromium.org/933153003/

BUG=458640

Review URL: https://codereview.chromium.org/939513002

Cr-Commit-Position: refs/heads/master@{#316921}

Allows using crash key system for android cast shell similiar to how
it's used for chrome

BUG=internal b/18763538

Review URL: https://codereview.chromium.org/923263004

Cr-Commit-Position: refs/heads/master@{#316920}

skia and mojo dependencies were missing and were thus
added.

BUG=459399

Review URL: https://codereview.chromium.org/937863002

Cr-Commit-Position: refs/heads/master@{#316919}

Checking if the displays are suspended in
DisplayConfigurator::RunPendingConfiguration is exposing a race
condition in the interaction between chrome and powerd.  The original
reason for adding the check was to ensure that chrome did not attempt to
perform any modesets while the chrome os device was in a dark resume.
Since this really only happens when the display configuration changes,
we can move the check into OnConfigurationChanged.  Also, to deal with
the possbility that the configuration timer was started right before the
system suspended, stop the timer in SuspendDisplays.  The
DisplayConfigurator will force a probe and re-configuration on resume
anyway so stopping the timer at suspend time will not really make a
difference.

BUG=chrome-os-partner:36723,459783

Review URL: https://codereview.chromium.org/932203002

Cr-Commit-Position: refs/heads/master@{#316918}

Note that Chromium won't allow any non-zero value for |timeout| in WebGL 2.

If Nacl decides differently on this, we can revisit the code in the future.

This command has a GLuint64.  Instead of upgrading command buffer to be 64 bit,
we use a Union to decode the 64bit value to two 32bit values on the client side,
and encode them back into one 64bit value on the service side.

BUG=429053
TEST=gpu_unittests
R=piman@chromium.org

Review URL: https://codereview.chromium.org/932963003

Cr-Commit-Position: refs/heads/master@{#316917}

for tracking the frames received on the headers stream which arrived early.

Review URL: https://codereview.chromium.org/937803002

Cr-Commit-Position: refs/heads/master@{#316916}

As discussed in https://codereview.chromium.org/866163002/, this change will
allow consumer of the metrics component to configure the metrics uploader endpoint
without modifying the component.

BUG=453987

Review URL: https://codereview.chromium.org/886173002

Cr-Commit-Position: refs/heads/master@{#316915}

We're not moving the bitmap after injected cursor moves. This regressed
in r312018 ("ozone: dri: Synchronize the cursor state").

BUG=459447
TEST=Connect via remoting to freon chromebook & move cursor. Cursor
     displayed on remote system should track movement closely.

Review URL: https://codereview.chromium.org/933363003

Cr-Commit-Position: refs/heads/master@{#316914}

DuplicateFinder now aggregates stats over its lifetime.

MediaImportHandler was changed to create a DuplicateFinder instance per import, so stats relating to duplicate-finding are reported per import session (instead of per-file).

Other changes are just straight-up addition of analytics logging code.

BUG=457736

Review URL: https://codereview.chromium.org/918713003

Cr-Commit-Position: refs/heads/master@{#316913}

WebContentsImpl::RouteMessageEvent is called in the UI thread, and it called
MessagePortService::UpdateMessagePort which assumed to be called in the IO
thread. Oops.

BUG=459115

Review URL: https://codereview.chromium.org/940493002

Cr-Commit-Position: refs/heads/master@{#316912}

This still breaks Clang-Win, as it seems Clang-Win mimics MSVS.

BUG=

Review URL: https://codereview.chromium.org/913223006

Cr-Commit-Position: refs/heads/master@{#316911}

Note that target_subarch=both is already set on the tryserver and Mac main waterfalls.

BUG=458398

Review URL: https://codereview.chromium.org/926443002

Cr-Commit-Position: refs/heads/master@{#316910}

Offscreen surfaces are implemented in different ways on different devices.
Using a framebuffer object allows gpu_perftests to run where a drawable offscreen surface is not available (i.e: mac) and in general to have a more consistent behavior across different drivers.

BUG=423481

Review URL: https://codereview.chromium.org/939553002

Cr-Commit-Position: refs/heads/master@{#316909}

Due to a recent threading changes, the Ozone SystemInputInjector must be
created on the UI thread.

This CL moves the creation of the input injector and input controller on
to the browser UI thread.

BUG=458314

Committed: https://crrev.com/9c59eedd7720845a5bc93b6dbc72639305c52ea7
Cr-Commit-Position: refs/heads/master@{#316883}

Review URL: https://codereview.chromium.org/931393003

Cr-Commit-Position: refs/heads/master@{#316908}

This is a followup to
https://chromium.googlesource.com/chromium/src/+/4ee38944c67548f1314f9fc1ef1363797b28bf02

BUG=None
TEST=trybots - GYP and GN builds still works.
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/940643002

Cr-Commit-Position: refs/heads/master@{#316907}

WebRTC 8413:8421
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/27b46ae..bec05b6

Libjingle 8411:8417
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/ea35ab3..e8e2384

TBR=niklase@chromium.org

Review URL: https://codereview.chromium.org/934363002

Cr-Commit-Position: refs/heads/master@{#316906}

Verify that the page transition matches the navigation type with RendererDidNavigate[New|Auto]Subframe.

BUG=none
TEST=should all stay green

Review URL: https://codereview.chromium.org/814563004

Cr-Commit-Position: refs/heads/master@{#316905}

[Telemetry] Rename test methods in page_test_results_unittest to follow existing convention of telemetry

Review URL: https://codereview.chromium.org/937783002

Cr-Commit-Position: refs/heads/master@{#316904}

When the plugin params don't include a MIME type, and there is no
plugin found, the first menu item will be blank.

This patch just removes the first menu item if there is no mime type.

BUG=354197

Review URL: https://codereview.chromium.org/937823002

Cr-Commit-Position: refs/heads/master@{#316903}

R=mbarbella@chromium.org
TBR=tsepez@chromium.org
BUG=450268

Review URL: https://codereview.chromium.org/932103003

Cr-Commit-Position: refs/heads/master@{#316902}

It should be be updated for each platform, in the same way the menu
item to bring it up is.

BUG=447384

Review URL: https://codereview.chromium.org/932023002

Cr-Commit-Position: refs/heads/master@{#316901}

BUG=437277

Review URL: https://codereview.chromium.org/937713004

Cr-Commit-Position: refs/heads/master@{#316900}