- 05 Dec, 2020 40 commits
-
-
Liquan (Max) Gu authored
PaymentRequestUi is the details of PaymentUiService and so CPRService should not have access to it. This CL hides PaymentRequestUi from CPRService. After the CL, CPRService uses it by the proxy of PaymentUiService. For the methods that have been moved into PaymentUiService, this CL adds the null-check in them. Bug: 1155582 Change-Id: Iaf5a8624232226c5c9c6fe29c411e377f10e8735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574777 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#834029}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607147157-7253fb93519f47883631135ae2487e5bf63d1c0b.profdata to chrome-win64-master-1607158109-cb59c5163bb73c4e3a2267188e86d32f6337beac.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib96f3c3ed24293030f77035a02ab961c91752976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576093Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834028}
-
Abigail Klein authored
observer. This CL does two things: 1. Do not notify SODAInstallerObservers when the component has not been updated. The crash was initiated when the component updater sent a status update saying that the SODA component was up-to-date, which occurred while SODA was running and not when it was installing. These up-to-date messages should not be relayed to the SODAInstallerObservers. 2. Remove the CaptionsHandler from the SODAInstaller observer list when the CaptionsHandler is destructed. The crash occurred because the CaptionsHandler had not properly removed itself as an observer. Before this CL, the CaptionsHandler removed itself when javascript was disallowed, which was assumed to occur when the CaptionsHandler was destructed. On testing, it turns out that this is not the case, so this CL ensures that the CaptionsHandler is removed as an observer on destruction. Bug: 1055150, 1155625 Change-Id: Icb2073a1380f1d1cefc25690d84aa840804ff29c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575005Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#834027}
-
Scott Violet authored
onOffsetsChanged() does nothing if fullscreen. This changes the code to call to setControlsOffset() so that the offsets are correctly updated. BUG=1149335 TEST=testTopViewRemainsHiddenOnFullscreenRotation Change-Id: I419f629292caf5f4454a04920c6a9778c8f16731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575898Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#834026}
-
Aaron Leventhal authored
Also unify HasARIAOwns() logic, while ensuring that different types of aria-owns are handled. Bug: 1155617 Change-Id: If2f76e35ca8b444a620ca052281953258937a9f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575445 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
-
Eric Lawrence authored
The specification says that Referrer policies should only permit a comma delimited list when delivered via the HTTP header, but not via the meta tag. Match other browsers and ignore a meta-specified policy if it contains commas. Bug: 1093914, 1111447 Change-Id: Ie2528c968e1e45a2209d611aee37fa406987074c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567572Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#834024}
-
Liquan (Max) Gu authored
MinimalUi is the implementation details of PaymentUiService and so should not be exposed to the payment request service. This CL encapsulate the MinimalUI logic in PaymentUiService so that PaymentUiService no longer provides the MinimalUICoordinator instance. Bug: 1155582 Change-Id: Ica49ae9190248d400f29ef8102c9a4394356ad85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575342 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a488b77c17f5..952584d5b9bb 2020-12-05 tvanderlippe@chromium.org Upgrade third_party/codemirror to 5.58.3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2bd83a4ae7d1838ce05772b0f8ef632b572da6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576337Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607147157-f5b7556f12cc4a67a4d86e796b1f10a124355671.profdata to chrome-linux-master-1607166734-e9365668558fc300c935cf3532da06f65c9b06bd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2dcb3562abb37d16c52cfd3cdb217f84b655eb2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576095Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607147157-05c119e40ba733e24d2e3874fc8b53f1f41ca77b.profdata to chrome-mac-master-1607166734-69b9a909cc2088c22879c6c9e7f8fd519f4237d8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6a9fe6c5f2e5bc0af5b613e456cd03d0b237de82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576091Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ab784e384be6..a488b77c17f5 2020-12-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2674f71d5424ba7dd4bdd86532825244b9e92aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576318Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1607061555-42057a46d6898e28766e44cc3eff7a0d211d34f4.profdata to chrome-win32-master-1607147157-aa03f5071526bec501a925219d4b546c82550b2e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie723dd7b8f069ff3804172a808e70458aea1b419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576084Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607126042-eec6b76e1d472288c9c26f1dc48d90cf1137b5cd.profdata to chrome-win64-master-1607147157-7253fb93519f47883631135ae2487e5bf63d1c0b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iacc8355f38a43809fa185378d2c95a90812a32f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575807Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d3455123dc42..d9042e3e6082 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Iaa5d13f3d08624a45bbbe8431c2d2df2c2007d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576086Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834016}
-
wutao authored
Bug: b/173476225 Test: manual Change-Id: Id108f71d73062d1158fa7175bcbb0b80f9a327b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574259 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#834015}
-
Hans Wennborg authored
This reverts commit 3d519f44. Reason for revert: This caused a 15% build time increase (see second bug). Original change's description: > Move CanExecuteScripts() to V8ScriptRunner::CompileAndRunScript() > > To unify how CanExecuteScripts() is checked across > classic script evaluation code paths. > > This CL doesn't change the behavior. > > Bug: 1111134 > Change-Id: If95a32043c52767eda05f16f9630edee26c5e75f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544938 > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832649} TBR=yukishiino@chromium.org,hiroshige@chromium.org,dom@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1111134, 1155843 Change-Id: I7531522623086a7e9903364288a557341208d84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576236Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#834014}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Id252c3be8bfaa30e170738b05fc080707d19a97d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575008Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834013}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/aafe855f7f51..251ba5cb119f 2020-12-05 syoussefi@chromium.org Vulkan: Fix transform feedback with in-render-pass clears 2020-12-05 zentaro@chromium.org Mark classes with final dtors as final 2020-12-05 syoussefi@chromium.org Vulkan: Support for geometry shader with max_vertices=0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:999886 Tbr: ianelliott@google.com Test: Test: no errors building Change-Id: I28a264ccafd777333994d11d5670716a0defceeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576026Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ibd5440d101a9db5bb4017135da5bb0a111e81446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576021Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607126042-accdd94f2839e19c977142b92f1ccbe3b6368bd6.profdata to chrome-linux-master-1607147157-f5b7556f12cc4a67a4d86e796b1f10a124355671.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifa7a91759a06f0380b8d6ef9ebe4450557c324c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576032Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607126042-3a5b481c1c794ae044b96bf2fc778aeb692519cf.profdata to chrome-mac-master-1607147157-05c119e40ba733e24d2e3874fc8b53f1f41ca77b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I055d26dfdf25556300c2bbc4d83fce99ca6a1396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576031Reviewed-by:
-
Aaron Leventhal authored
Remove RemapAriaRolesDueToParent: - It's harmless to have cells, rows etc. exist without a parent table. Having code in Blink to remap these roles causes complexity and issues with aria-owns. Adding any complexity to do this is more trouble than it's worth - Remapping kListBoxOption to a kMenuItem when it's in a kMenu is related to old code inherited from WebKit. WebKit made efforts to try to change role=option or <option> elements inside a role=menu to menuitems, but this is just not worth it. Also, 2 old tests that failed now pass, so the -expected.txt files are removed -- the expectations were only there to allow the failures. Bug: 1150481 Change-Id: I7342e3c15bf2dd3d877f90e682db7d68bf8c9142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568365Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b364bad6550e..d3455123dc42 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I3506dd759cdf78c55ba05a50f3dbeb3914e6073f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576023Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/46ab28975e89..ab784e384be6 2020-12-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9324e7c0d69783d9e7fbe4355c230a71d0cf2e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576024Reviewed-by:
-
Fergal Daly authored
The call in SetRenderFrameHost was useless because the speculative RFH has already been move out of place so the validation exits early. This change moves the validation into a static method that takes 2 frames as arguments, so that it can be used even in this case. https://crrev.com/c/2564933/1 shows that this passes all tests even with SkipEarlyCommitPendingForCrashedFrame. Bug: 1146573 Change-Id: I59574bd78a93534ec7e0ae603589e82c2e87a119 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564933Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#834005}
-
Jimmy Gong authored
Provide more context on where the setting buttons is routed to. Screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/ad7a89eaab68906ed5e04fc18cf4f6cacd1ef94c Fixed: 1152781 Change-Id: I0fef47d663c41f20ba3842820d661967bbc08066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570328 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#834004}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/bae138de13ac..f36e874ade1d 2020-12-04 ynovikov@chromium.org Add CQ configuration. 2020-12-04 amaiorano@google.com Add unit test for ENABLE_RR_EMIT_ASM_FILE 2020-12-04 amaiorano@google.com Kokoro: isolate flag enabling for incremental builds 2020-12-04 amaiorano@google.com Kokoro: upgrade Linux build from gcc 7 to 9 2020-12-04 capn@google.com Fix stringification of macro value 2020-12-04 capn@google.com Allow configuring Reactor's anonymous mmap name 2020-12-04 capn@google.com Remove named anonymous mmap for GL/VK allocations If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1069673 Tbr: swiftshader-team+autoroll@google.com Change-Id: I04dbaac1b45e94cd3eb56271132bb6bb076961d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575801Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607115559-44871aa53f914203e8d0d24a90c015a255200321.profdata to chrome-win64-master-1607126042-eec6b76e1d472288c9c26f1dc48d90cf1137b5cd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6a0151fde119a2bb4835ba0a694017511352fedb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576100Reviewed-by:
-
wutao authored
It was not handled that when a media session info is changed from paused to playing, the string animation will not restart. This patch simplifies the logic, when the media is paused, it will only set the visibility to false, but not stop the animation, when the media resumes, it is still animating. Bug: b/173804133 Test: manual and modified test Change-Id: Ic2a935b2bc52d8379189395dd3fd1213eefd48a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573682Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4bd742c8f043..b364bad6550e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1155769 Tbr: Change-Id: Id9ca082baae51205cdfbf54bb8a66e8aa2e85f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576101Reviewed-by:
-
Ken Buchanan authored
This adds plumbing to WebID federation requests to generate dialogs for user permission and IDP sign-in. The prototype dialog implementations will be added later. Bug: 1141125 Change-Id: I37d26d8d376482c3e285907bd3eb0f56b450613b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569379 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#833999}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/30217950419d..e0dee01043d1 2020-12-05 michaelludwig@google.com Remove support for deprecated kDontClipToLayer_SaveLayerFlag If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: I16fd8a6c1f61db885886cd33809840b7798f345e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575215Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c859c0ac81bb..aafe855f7f51 2020-12-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 78187c02 to 6991410b (262 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I2038dde0c841018bd907bf186ff90e638ca18046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575434Reviewed-by:
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Iad750ef52b3a42cc0339e8e6fdb682c4cf397b16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550844Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#833996}
-
Aleks Totic authored
Inside table-layout:fixed, columns always take precedence over cells. Updated wpt column widths test. Bug: 958381, 832323 Change-Id: I07e682d9e41218774889d9517a0e4d652bbecd68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575724Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#833995}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b97d85b7ca18..46ab28975e89 2020-12-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I113ddb461fa1becf4f43f8b9ab3e23d237f3eb75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576099Reviewed-by:
-
Sammie Quon authored
The crash was because a new screenshot is requested when the current screenshot is about to get scrolled out of bounds. It was using a fixed number threshold, meaning displays that are not the same size could get out of sync easily, leading to a CHECK failure. This CL addresses that by requesting screenshot on all displays if even one of them needs one. Another approach would be change the spacing and threshold to be based on the display width instead of fixed number, but that could be prone to roundoff error which may cause a similar issue. Also noticed visible desk metric was double counting when there are multiple displays. Added a TODO for that one as it is lower priority. Bug: 1154868 Test: manual, added regression test Change-Id: I48f5ef62d3284b710f44a2808f75c95686bc9b3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570551 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#833993}
-
Austin Eng authored
Bug: none Change-Id: I81a2d9a274f35b10f232ba060a6cd2e6b46673e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574808Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#833992}
-
Jimmy Gong authored
This disables the Silence Phone quick action in the Phone Hub UI if the user's phone is setup with a work profile. Bug: 1155244 Test: local, ash_unittest Change-Id: Ia29af3f40d69f00af74362015393d32730d2a58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575344 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: I858cb99880732091438d592e406e60c8d1a15dea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574789Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833990}
-
