- 22 Jun, 2018 40 commits
-
-
David Valleau authored
Change-Id: I92425dc2d51b4b2397651e31fe55aaa604265ab9 Reviewed-on: https://chromium-review.googlesource.com/1110842Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: David Valleau <valleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#569661}
-
Theresa authored
Replace menu_bg and edge_menu_bg with a new modern popup_bg. BUG=823531 Change-Id: Idec73e189527363cb8186e006e22657a4b5dad8d Reviewed-on: https://chromium-review.googlesource.com/1108924Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#569660}
-
Oksana Zhuravlova authored
This change moves Device*EventPump classes and appropriate unit tests to third_party/blink/renderer/modules/device_orientation. Their instances are now created in relevant Device*Dispatcher methods with a LocalFrame* passed to be used for Mojo interface creation. Some updates were required to satisfy blink dependencies limitations and for consistency: - base::RepeatingTimer was replaced by TaskRunnerTimer which has to be initialized with a base::SingleThreadTaskRunner, so the constructors were extended with a new parameter; - base::Time -> WTF::Time; - base::BindOnce -> WTF::Bind, base::Unretained -> WTF::Unretained; - device::mojom:: -> device::mojom::blink::; - in the unit tests, device::mojom::SensorProviderPtrInfo is wrapped into device::mojom::blink::SensorProviderPtr since FakeSensorProvider implements device::mojom::SensorProvider Bug: 850997 Change-Id: I440b9379f50ab42fc50b9d92490c2615ef8c3cc9 Reviewed-on: https://chromium-review.googlesource.com/1099492 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#569659}
-
Bailey Berro authored
- SmbService encodes whether a share was mounted with ChromAD Kerberos or not when creating the FileSystemId string. - Removes old ctor from FileSystemId Bug: chromium:757625 Change-Id: I735dbc15cd4ea1eef45e81f09244dc2b91863014 Reviewed-on: https://chromium-review.googlesource.com/1093963 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#569658}
-
Sadrul Habib Chowdhury authored
Add a ctor for BeginFrameAck that initializes itself from a BeginFrameArgs so that it can be used to ack a begin-frame. BUG=855328 TBR=flackr@ for trivial mechanical blink updates. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I92dd7c2bcb64bc2f29faba83297731996f058ff2 Reviewed-on: https://chromium-review.googlesource.com/1111458 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#569657}
-
Nico Weber authored
Bug: 855573 Change-Id: Ia62bf4d471589b6eb3916277746af4fd7e388ec1 Reviewed-on: https://chromium-review.googlesource.com/1111614Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#569656}
-
Vasilii Sukhanov authored
Bug: 851021 Change-Id: Ia69cea98783f2b077b628e0975e22913f3e17d61 Reviewed-on: https://chromium-review.googlesource.com/1112004 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569655}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/87eefd4f1143..e3b12b3e7d98 git log 87eefd4f1143..e3b12b3e7d98 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 perezju@chromium.org [Telemetry] Fix and re-enable StartupTracingTest Created with: gclient setdep -r src/third_party/catapult@e3b12b3e7d98 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:854212 TBR=sullivan@chromium.org Change-Id: Ibd0c21dd2e8139f038212adaccdf40a5b24fa8e0 Reviewed-on: https://chromium-review.googlesource.com/1111921Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569654}
-
Kyle Lund authored
This CL adds mocks for the asyncronous methods in RemoteDevice that were not yet mocked. Bug: None Test: Run cast_bluetooth_unittests. Change-Id: Ic5257e9797d47aa61274811d3a623d6d0fe942a9 Reviewed-on: https://chromium-review.googlesource.com/1111205Reviewed-by:
Bailey Forrest <bcf@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Kyle Lund <kylelund@google.com> Cr-Commit-Position: refs/heads/master@{#569653}
-
Nico Weber authored
Bug: 855588 Change-Id: If19e6d5131fd60796ad524852b5a974e71d8dc4d Reviewed-on: https://chromium-review.googlesource.com/1112041Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#569652}
-
sczs authored
- Creates TableViewEmptyView class. - Adds addEmptyTableViewWithMessage:image: to ChromeTableVC, these 2 methods add or remove a TableViewEmptyView used to signal an empty state on the TableView. Screenshot: https://drive.google.com/open?id=1O17v-bVjJktj7bdlMBpVT8Ew-SdY8Mjn Bug: 838579 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ifd9e69c1b187e1fffa9cc62f233777718481b57c Reviewed-on: https://chromium-review.googlesource.com/1101827Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#569651}
-
Pete Williamson authored
We have permission to take P2P Offline sharing to 100%. In conjunction with the finch change, we turn on the feature by default, so we can set and end date on the finch experiment. Bug: 758690 Change-Id: Icd0e886ea4a8a64456abb7a5a40ce9dac11a9143 Reviewed-on: https://chromium-review.googlesource.com/1110601Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#569650}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4c506633. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19959 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=robertma No-Export: true Change-Id: Ie639f1ae90f0457d75ae9efc7b810b8d2f35d559 Reviewed-on: https://chromium-review.googlesource.com/1111907 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#569649}
-
Suproteem Sarkar authored
Implemented value changing control patterns in IAccessibleEx, allowing for manipulation of basic fields with values R=nektar@chromium.org,dmazzoni@chromium.org Bug: 852965 Change-Id: I080188507ac4dd0bd7548bec89a9ec069e581b85 Reviewed-on: https://chromium-review.googlesource.com/1101837 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#569648}
-
Alexandros Frantzis authored
Use the output surface gpu fence when scheduling any and all overlay planes, to ensure the planes are correctly synchronized for display even if the root render pass is skipped. Bug: 840805 Test: viz_unittests and chrome --use-gpu-fences-for-overlay-planes on Ozone-DRM Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I4939c36a8b7d334ccef5ab2bad2eee90ffeb07d8 Reviewed-on: https://chromium-review.googlesource.com/1104695Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#569647}
-
Ryan Hamilton authored
Change-Id: I852ca097fcb27b88e8e3473c79b87ae455222ad3 Reviewed-on: https://chromium-review.googlesource.com/1111573 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#569646}
-
Philip Rogers authored
This patch only invalidates the child clipping mask layer if the size actually changes. https://crrev.com/564140 regressed performance by calling this unconditionally. Because the same bug was made in https://crrev.com/565415, this patch also updates the two GraphicsLayer::SetSize callsites from that patch. Bug: 851105 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I74bcda83054e8e21332e723d0fc816910086e2e4 Reviewed-on: https://chromium-review.googlesource.com/1111208Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569645}
-
Mathieu Perreault authored
Bug: 841772 Change-Id: I9b311730c66e3d6ad99e0db5c908425957becaa3 Reviewed-on: https://chromium-review.googlesource.com/1111906Reviewed-by:
-
Alex Newcomer authored
Move all app command id enums to app_menu_constants.h. Bug: 853927 Change-Id: Ib269c5b35dfad205912a4d69eb84d84fd7c86857 Reviewed-on: https://chromium-review.googlesource.com/1107199Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#569643}
-
Colin Blundell authored
We've made the decision that IdentityManager APIs that query account information should take in account IDs, with those that *return* information continuing to return full AccountInfo structs. This CL changes the one remaining API that takes in an AccountInfo (RemoveAccessTokenFromCache()) to take in the account ID instead. Bug: 796544 Change-Id: I1d6894fa40045fa54956f777723e1e2d3383098d Reviewed-on: https://chromium-review.googlesource.com/1110224 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#569642}
-
Samuel Huang authored
This CL adds llvm-bcanalyzer to the list of files packaged and downloaded by download_objdump.py. This is needed for extracting data from .o files (which are LLVM Bitcode Files) under LLD-LTO. Bug: 723798 Change-Id: I87ef05b17399d56f85ca51e042cbc5415edb8bce Reviewed-on: https://chromium-review.googlesource.com/1106903Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#569641}
-
David Roger authored
Change-Id: I4d36c589cfdbd55784d31da65083c9f2fb724bd1 Bug: 807824 Reviewed-on: https://chromium-review.googlesource.com/1071289Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#569640}
-
Kyle Milka authored
Add icons as SVG files, and update the css to use the new icons. chrome.svg: monochrome Chrome logo photos.svg: Google Photo's logo upload.svg: upload arrow wallpapers.svg: Chrome wallpapers logo Bug: 851336 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie4e724144c0889b70cbed1905e9ca86cd1c88d86 Reviewed-on: https://chromium-review.googlesource.com/1109598Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#569639}
-
Andrew Grieve authored
Bug: 854878 Change-Id: Ia8936dc875e6d577f702e83fb8e112a0ee0dd8ba Reviewed-on: https://chromium-review.googlesource.com/1110747Reviewed-by:
David Turner <digit@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#569638}
-
Ioana Pandele authored
This replaces the current command line flags. Bug:835234 Change-Id: If4950182bbf53c18dfb8da887df183a1c8e53e52 Reviewed-on: https://chromium-review.googlesource.com/1110370Reviewed-by:
-
Marc Treib authored
This method set some state on the StartupController which was equivalent to calling TryStart(/*force_immediate=*/true), only that it was also sticky, i.e. it'd also affect later TryStart(false) calls. This was confusing and hard to reason about, and not actually required for anything, so this CL gets rid of it. Bug: 854978 Change-Id: Id3bf77dc56689b33904c60f178264b0e3e8629c4 Reviewed-on: https://chromium-review.googlesource.com/1111850 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#569636}
-
Matthew Cary authored
These all appear to be due to a strict mode violation on android M 64 bit. TBR=dtrainor@chromium.org Bug: 855389 Change-Id: I20297e805bee3d775632530a8653acfd9e2dcf90 Reviewed-on: https://chromium-review.googlesource.com/1112009Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#569635}
-
Quentin Fiard authored
Bug: 825255 Change-Id: Id5d24421a3bda868fec711dff50aeab4b13eecd8 Reviewed-on: https://chromium-review.googlesource.com/1110368Reviewed-by:
-
Jerry Lin authored
This CL remove hard code SID in function |ChromeContentBrowserClient::GetAppContainerSidForSandboxType|. The SIDs are moved to structure |InstallConstants| and helper function |GetSandboxSid| are added for getting SID from that structure. Bug: 845876 Change-Id: I553663ffd6613fe61ebe6c3a36c233dce42d3fc5 Reviewed-on: https://chromium-review.googlesource.com/1094576 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#569633}
-
John Budorick authored
Bug: 850652 Change-Id: I5493037339fb7675aa942893c5e9654c653b071a Reviewed-on: https://chromium-review.googlesource.com/1106483 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569632}
-
Kevin Schoedel authored
Bug: b/73383411 Test: TBD Change-Id: If9218005c2925ea66b67164435c552965d09b554 Reviewed-on: https://chromium-review.googlesource.com/1110944Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#569631}
-
Zoe Clifford authored
Currently there is a virtual time deadlock between HTML imports and PendingScript. I'm not sure about modules, but at least classic PendingScript is effected. * PendingScript will keep virtual time paused until it's ready to be executed (Until the document is not script-blocking). * Script execution will be paused on the document until the HTML import has finished. * The HTML import will not finish unless virtual time is unpaused (It fires an immediate timer to update it's state) The deadlock happens because timers (even immediate ones) will not fire if they were scheduled after virtual time was paused. To resolve this this CL unpauses PendingScript's virtual time pauser earlier; once the script is marked "ready". This means that PendingScript will unpause virtual time before waiting for HTML import to finish, and the deadlock is resolved. Change-Id: I1763229bd73096000bc461c678b061a345c3b530 Reviewed-on: https://chromium-review.googlesource.com/1104314Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Zoe Clifford <zoeclifford@chromium.org> Cr-Commit-Position: refs/heads/master@{#569630}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6e6a25be184c..0212faf7c41e git log 6e6a25be184c..0212faf7c41e --date=short --no-merges --format='%ad %ae %s' 2018-06-22 hjd@google.com trace_processor: Fix size issues Created with: gclient setdep -r src/third_party/perfetto@0212faf7c41e The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I50489b3d6b31e796a580c455fafdf69b9842d61c Reviewed-on: https://chromium-review.googlesource.com/1111920 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569629}
-
Mihai Sardarescu authored
ProfileDownloader is responsible to download the picture of an account. To do the fetch, it uses the account picture URL that is fetched by the AccountFetcherService (from https://www.googleapis.com/oauth2/v1/userinfo ) and stored in AccountTrackerService as an AccountInfo. If the user info dictionary fetched from the userinfo endpoint does not contain any picture URL, then it sets the picture URL to "NO_PICTURE_URL" in the AccountInfo. ProfileDownloader does not check whether the profile picture URL is invalid before creating the URLFetcher to fetch this image. So if the picture URL of the account is "NO_PICTURE_URL", then it will attempt to fetch it via an invalid URL which leads to the crash described in the bug. This CL gracefully handles the case when the picture URL is invalid. Bug: 854907 Change-Id: Iea79b120cd8e4e830fa1a4cc074793418914b155 Reviewed-on: https://chromium-review.googlesource.com/1111846 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#569628}
-
John Abd-El-Malek authored
The problem was that empty filesystem objects weren't calling URLLoaderClient::OnReceiveResponse. Bug: 769401 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I3e9266848642f9fa7d761b605370335441d94511 Reviewed-on: https://chromium-review.googlesource.com/1110275Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#569627}
-
Khushal authored
The JPEGDecoder ceils when rounding floats for mip level sizes while the cc code floors. This results in 1 pixel differences in the scaled sizes when using decode to scale. Avoid this by switching the cc mip size calculations to match the decoder. R=ericrk@chromium.org, chrishtr@chromium.org Bug: 761565,558070 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I07069a4eff582ffbb621388ccae32b18aedebd3a Reviewed-on: https://chromium-review.googlesource.com/1107049 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569626}
-
Rune Lillesveen authored
SetPseudoElement created a PseudoElementData even if the input was a nullptr. Early out for null input to avoid unnecessary allocation. Bug: 836126 Change-Id: If21c9ff8db2f20427b32f124ea0b129ebbebfe80 Reviewed-on: https://chromium-review.googlesource.com/1109962Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#569625}
-
Friedrich Horschig authored
This CL renders the options provided by the native backend. To do that, it introduces new |Item.Type|s. Bug: 853747 Change-Id: I6fcd833a1674d55da4e4e44d9517e3aff35da823 Reviewed-on: https://chromium-review.googlesource.com/1110217 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#569624}
-
Gayane Petrosyan authored
These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I31665bf71e42f703b38dad45da0891bd81ac669c Reviewed-on: https://chromium-review.googlesource.com/1111475Reviewed-by:Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Kyle Milka authored
When a background tile is selected apply the proper border and check mark. Then remove this stlying when the tile is de-selected. Bug: 850675 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib1b05121bc6beaae5af6591e3963d59584a1f2af Reviewed-on: https://chromium-review.googlesource.com/1110352Reviewed-by:
-
