GitLab

This adds the initial support to MB to be able to build and run
a binary under swarming easily. It builds on the existing code
in MB for building and isolating targets, and just adds uploading
the isolate, triggering the task, waiting for and collecting the
results.
e
The end goal is that it should be this easy to reproduce a failure
in a bot config:

    $ fetch chromium && python src\tools\mb\mb.py run --swarmed \
        --master tryserver.chromium.win \
        --builder win-msvc-rel \
        out\Release base_unittests

Adding this gives us a starting framework that we can build on
for the bit.ly/chromium-test-runner-api cleanup work.

R=jbudorick@chromium.org, maruel@chromium.org
BUG=794783

Change-Id: I160706b1a563bceb36b8465857d32692a3ca004d
Reviewed-on: https://chromium-review.googlesource.com/825925
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524568}

Currently, ExtensionService unittests explicitly look at the value of
the "state" pref in an extension's preference entry to check if it was
an externally-uninstalled extension. This is bad because it is fragile
and relies entirely on implementation details of ExtensionPrefs.

Instead, use ExtensionPrefs::IsExternalExtensionUninstalled() to verify
uninstalled external extensions and
ExtensionPrefs::GetInstalledExtensionInfo to look for install state.

Bug: 794205
Change-Id: I14ea2ce0390c37ccdcdbeea4e23b48b968baaebb
Reviewed-on: https://chromium-review.googlesource.com/825943
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524567}

Now that opus is supported in containers outside of ogg, we shouldn't
allow negative timestamp fixups to imply the need for chained ogg
support. I.e. we shouldn't apply chained ogg workarounds to mp4
files or any other container that opus is allowed in now.

This has been broken for a while, but h264+bframes and opus is not
common, so the issue hasn't arisen before. The fix is simply to
separate these workaround flags and restrict the chained ogg one
to only content which we expect to support.

BUG=795392
TEST=new unittest.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I3a7465110fd1f1defe4b41f1f471e5050d8c469a
Reviewed-on: https://chromium-review.googlesource.com/830831
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524566}

Previously the order of std::move() versus dereference to fetch the
|indexed_db_observer_|'s TaskRunner was unspecified, potentially leading
to a null dereference.

Bug: 794842
Change-Id: If08358fcf017bfebe0d615c9230f8af7a02177c9
Reviewed-on: https://chromium-review.googlesource.com/827603Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524565}

This CL contains several fixes related to prerendered pages:
- Updates the scroll view padding for replaced Tabs.
- Updates FullscreenWebStateListObserver, WebScrollViewMainContentUIForwarder,
  and LegacyToolbarUIUpdater to account for replaced active WebStates.
- Updates FullscreenWebStateObserver to stop observing destroyed WebStates.
- Updates FullscreenWebStateObserver to use ScopedFullscreenDisablers to
  prevent unbalanced increment/decrement disabled counter calls.
- Updates DCHECKs in MainContentUIState that failed for side-swipes.
- Creates TestFullscreenController for internal disabling tests.


Bug: 793891, 793966, 793989
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7ed1cd0607e23f34f0991b06386d7d66bf8d86ed
Reviewed-on: https://chromium-review.googlesource.com/826266
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524564}

This change also does not force extension popup close upon inspect session
termination.

Bug: 795403
Change-Id: I9ab3e8f0f6b5360f1475f302ab34d18b5b53939f
Reviewed-on: https://chromium-review.googlesource.com/830983Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524563}

In order to utilize Instant Tethering, Android phones must have their
"Google Play Services" notifications enabled. When a Chrome OS device
contacts an Android phone without these notifications, the phone returns
a special error code.

This CL adds information to be displayed in the settings page when this
occurs so that the user will know the steps needed to use Instant
Tethering, but for now, this information is never displayed.

A follow-up CL will integrate this code with the handler for the special
error code returned by the phone.

Bug: 765966, 672263
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I318ebf00301301142bcb73e34b5be2e9c208c737
Reviewed-on: https://chromium-review.googlesource.com/827564
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524562}

https://chromium.googlesource.com/angle/angle.git/+log/9d4d7f06facb..647dca7672f7

$ git log 9d4d7f06f..647dca767 --date=short --no-merges --format='%ad %ae %s'
2017-12-15 jmadill Revert "Vulkan: Roll loader/validation layers SDK. (2/2)"
2017-11-01 fjhenigman Support ozone/gbm back end in standalone gn build.
2017-12-11 fjhenigman Add angle_link_glx arg to standalone gn build.
2017-12-13 brandon1.jones Fix Bug in Intel Workaround
2017-12-06 xinghua.cao ES31: Implement image state query
2017-12-04 oetuaho Always create TVariables for TIntermSymbol nodes
2017-12-12 jmadill D3D11: Fix program uniform buffer dity bits.
2017-11-16 jiawei.shao ES31: Remove support of GL_OES_geometry_shader in compiler
2017-12-13 jmadill Vulkan: Roll loader/validation layers SDK. (2/2)

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I1c856a03f0c73ae666ea199b2a475e63060d089e
Reviewed-on: https://chromium-review.googlesource.com/831129Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524561}

This CL fixes the font family when overriding a <button> element with
is="cr-link-row". <button> was defaulting to Arial. This CL will inherit
its parents font family, which for MD WebUI is Roboto (with some fallbacks).

Bug: 795362
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3303425f2dd2e10c95a7f30bf6b919ec7140d4be
Reviewed-on: https://chromium-review.googlesource.com/830651Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524560}

Bug: 794794
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I021ce4292149c6d86302d7b3285f062decff4fd1
Reviewed-on: https://chromium-review.googlesource.com/827590
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524559}

https://pdfium.googlesource.com/pdfium.git/+log/667fa571db51..175f01bb081b

$ git log 667fa571d..175f01bb0 --date=short --no-merges --format='%ad %ae %s'
2017-12-16 thestig Configure CQ to use Windows ASAN bots.

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I9c380f5b1b60a7d6f3be4837a8f151288f736a7d
Reviewed-on: https://chromium-review.googlesource.com/831208
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524558}

TBR=boliu@chromium.org,mkwst@chromium.org,mseaborn@chromium.org,rdsmith@chromium.org,yuweih@chromium.org

Change-Id: I9df8549cd56a2a1977b704f091cefe1738bdaf11
Reviewed-on: https://chromium-review.googlesource.com/830979
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524557}

This is a variant of CopyDirectory which refuses to overwrite
files that already exist in the destination directory.

Bug: 768003
Test: existing + new unit tests
Change-Id: I29ba308158d13b90f21928b76104eb671ab8a728
Reviewed-on: https://chromium-review.googlesource.com/754266
Commit-Queue: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524556}

This creates an ApplicationTestRunner.resetState() method to reset storage state
and is added to the beginning of every test that relies on a storage API.

This makes ClearDataForOrigin more robust by making it explicit that it's
asynchronous and (mostly) fixing the race condition.

The callback doesn't guarantee the storage has actually been deleted but
at least it has been scheduled (see storage_partition.h), whereas before
it returned with a success response immediately.

We could update third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js
to actually wait for this callback to be called to update the UI when the user
clicks on the clear storage button rather than rely on a 500ms timeout,
but let's defer this for a follow-up patch.

Bug: 667560
Change-Id: Ia7b70aebabd970957ae3581e47ee31a10992c657
Reviewed-on: https://chromium-review.googlesource.com/792534
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524555}

This unblocks moving DevToolsAgent to blink.

Bug: 776009
Change-Id: Ie366481cc3913d864f773aa07007dd90aec0dc8d
Reviewed-on: https://chromium-review.googlesource.com/828145
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524554}

These will run side-by-side the non-Swarmed ones until they're green,
at which point they'll be renamed to replace the old ones.

BUG=754875
TBR=dpranke@chromium.org
NOTRY=true

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I1b84a56a6242085c8f11510515aee2b0acbd2d02
Reviewed-on: https://chromium-review.googlesource.com/831153Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524553}

In 2014, CodeMirror had poor support for auto-closing quotes. In
response to bug 411238, a custom implementation of auto-closing
quotes was added. This assumed a US keyboard layout, and broke
some international keyboards.

CodeMirror has much better support for auto-closing quotes now,
so this patch removes the legacy code.

Bug: 578852
Change-Id: I9b80e6f628adadc7b37c39dab7be5eaa0c76d7a9
Reviewed-on: https://chromium-review.googlesource.com/830650Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524552}

Bug: 762125
Change-Id: I010c4608ecd2fd86149bcbd17a86c991575d01f2
Reviewed-on: https://chromium-review.googlesource.com/827673Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524551}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/41d9d87e9653..d3f769a71026

$ git log 41d9d87e9..d3f769a71 --date=short --no-merges --format='%ad %ae %s'
2017-12-15 thestig Change "ldap" to "username".

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=phajdan.jr@chromium.org

Change-Id: I28546c9d25183ccffb8e96240aabc3635a037050
Reviewed-on: https://chromium-review.googlesource.com/831172Reviewed-by: depot-tools-roller . <depot-tools-roller@chromium.org>
Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524550}

This CL removes the superfluous PIXEL_FORMAT_I422, synonym of the
older PIXEL_FORMAT_YV16.

This format was landed in crrev.com/2571163002 with a comment that
"Apart from how the buffer is allocated the format is basically
idential to I422 (a.k.a YU16).", but I can't see any difference
from the code, i.e. both PIXEL_FORMAT_YV16 and PIXEL_FORMAT_I422
are treated the same everywhere.

Note that usually we should not roll back VideoPixelFormat's
PIXEL_FORMAT_MAX but PIXEL_FORMAT_I422 was never added to enums.xml,
so UMA knows nothing about it [1], and we can just pretend it was
never there and was never logged [2] (it'd be logged as some hash
name)

[1] https://cs.chromium.org/chromium/src/tools/metrics/histograms/enums.xml?type=cs&q=histograms+enums.xml+y16&sq=package:chromium&l=43271
[2] https://uma.googleplex.com/timeline_v2?sid=deaff528e0268c7d0fdaa405130a075f

TBR=reveman@chromium.org for the autochange in video_resource_updater.cc

Bug: 795424
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9e5d52d8013bc4f6d237c8274ceb63327d78fa30
Reviewed-on: https://chromium-review.googlesource.com/830769
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524549}

Convert the "Extension options" row to a cr-link-row and leverage the existing
styling for the disabled case.

Bug: 794756
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7139e20a17d5e0ac5c85f0e1da7a5ad3bd2ab3d9
Reviewed-on: https://chromium-review.googlesource.com/826484
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524548}

Bug: 795012
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifab4bd719569504821dc18db8ac785fadfaa71b3
Reviewed-on: https://chromium-review.googlesource.com/828461
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524547}

Using wpt-import in Chromium b0c1909e.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/7815

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/encoding

TBR=foolip

No-Export: true
Change-Id: If3d920c7f2e742fa5d422359590d6f0a863e88a6
Reviewed-on: https://chromium-review.googlesource.com/830929
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524546}

- introduce a scoped setter which enables the keyboard during spoken
feedback's lifetime
- remove restriction/message from ChromeVox disclaimer asking user to
enable a11y vk
- re-map some Search-like-function keys
1. Search+Left/Right -> Home/End
2. Search+Shift+Left/Right -> Shift Home/End
3. Search+Ctrl+Left/Right -> Ctrl+Home/End
4. Search+Shift+Ctrl+Left/Right -> Shift+Ctrl+Home/End
- re-map braille commands to edit key commands as follows:
1. dot 3/6 chord -> previous/nextCharacter -> Left/Right
2. dot 2/5 chord -> previous/nextWord -> Ctrl+Left/Right
3. dot 1/4 chord -> previous/nextObject -> Up/Down
4. dot 2-3/5-6 chord -> previous/nextGroup -> Ctrl+Up/Down

(jumpToTop/Bottom remain dots 1-2-3/4-5-6 and trigger ordinary edit key command
mappings).

notes:
we use the vk codepath because it handles compatibility down the stack
for us and potentially triggers other side effects such as auto
complete/IME

Test: with a braille display, ensure a11y vk off. Press incrementally
Ctrl + t; verify new tab shows up.  In Google Docs, press
Search+Left/Right (and all other combos enumerated above). Verify proper
caret/selection afterwards. Turn on sticky mode. Verify Search nav
performs ChromeVox commands rather than send keys.

Do all of the same with a braille display inside of Docs. Verify ability
to edit and navigate directly from display.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4878c8a930cd643c406294b7f302c9ad2c07ee9f
Reviewed-on: https://chromium-review.googlesource.com/823578
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524545}

Disabling this RenderFrameHostImplBrowserTest on this configuration as
it's frequently hanging and blocking the CQ.

BUG=795326
TBR=avi@chromium.org

Change-Id: I88e5b4158de3c92113b767b00b64d88e11ae09ca
Reviewed-on: https://chromium-review.googlesource.com/831127Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524544}

This reverts commit 0a2853de.

Reason for revert: Fixed the underlying problem on O bot.

Original change's description:
> Disable ChromeHomeAppMenuTest#testPromoAppMenuHeader on O
> 
> TBR=mdjones@chromium.org
> BUG=786454
> 
> Change-Id: Ia87e8cbba360cc98ae5bf70a68d757fe147b3c90
> Reviewed-on: https://chromium-review.googlesource.com/825306
> Reviewed-by: Theresa <twellington@chromium.org>
> Reviewed-by: Matthew Jones <mdjones@chromium.org>
> Commit-Queue: Theresa <twellington@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523849}

TBR=twellington@chromium.org,mdjones@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 786454
Change-Id: I9c1f6ce1992573fb894f5ee203995fe0ccb5481f
Reviewed-on: https://chromium-review.googlesource.com/831227Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524543}

https://chromium-review.googlesource.com/752006 added an IsolatedCopy()
call but the SecurityOrigin can be null when
WebLocalFrameImpl::SetIsolatedWorldSecurityOrigin() is called from
TestRunnerForSpecificView::SetIsolatedWorldSecurityOrigin().

Bug: 793649, 779730
Change-Id: I017eec29cc6c8cc9a753181c9b6f335569cccb9f
Reviewed-on: https://chromium-review.googlesource.com/825653
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524542}

It was introduced to resume other pages in the same render process
when the page paused on breakpoint is closed.

This now works due to Mojo connection error handler triggering
detach automatically and unpausing as a result.

Removing content-specific code from DevToolsAgent unblocks
migrating it to blink.

Bug: 776009
Change-Id: I20113df99a947eeaeabfb59886a07fc3f866ea27
Reviewed-on: https://chromium-review.googlesource.com/830977Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524541}

This CL creates CachedMetadataHandler when a response is received,
instead of creating when a Resource is constructed.

This is to
- Prepare for removing the reference from CachedMetadataHandler to
  Resource in [1]. The data needed for CachedMetadataHandler is
  available when a response is received, but not available when
  the Resource is created. Also, this CL makes the lifetime of
  CachedMetadataHandler match with the period where the corresponding
  ResourceResponse is set in Resource::response_.
- Enable CachedMetadataHandler even after revalidation.
  Previously, CachedMetadataHandler was cleared on failed revalidation
  and was never re-created after that.
  This CL creates a new CachedMetadataHandler everytime a
  ResourceResponse is received, and thus re-creates a
  CachedMetadataHandler on failed revalidation.

[1] https://chromium-review.googlesource.com/791494

Bug: 784875
Change-Id: Ia32f5772cbd5970734f67098f235c2a1428b46ea
Reviewed-on: https://chromium-review.googlesource.com/786410
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524540}

WebRtcEventLogManager can now handle locally-bound WebRTC event logs.
Once we add handling of remote-bound logs, it would be good to have
clear separation of the logic that handles locally-bound and remote-
bound logs. This CL does just that.

Bug: 775415
Change-Id: If7113d2fdbb7f8f240cceb4c309f6032da86341f
Reviewed-on: https://chromium-review.googlesource.com/822938Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524539}

After CL 827548, margins are always copied to Legacy.
Additional copy in LayoutNGBlockFlow is no longer needed.
Ian says so.

Bug: 740993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: If1aee4b15a966d58bd62f66190fdf00f035ed0b4
Reviewed-on: https://chromium-review.googlesource.com/830474Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524538}

This change updates a few characteristic removed tests to use the new
test API. This will allow the tests to be migrated into the wpt/
directory.

BUG=509038

Change-Id: I7ee5735d4052168f380437e9389546cd4d29a72f
Reviewed-on: https://chromium-review.googlesource.com/822522Reviewed-by: Conley Owens <cco3@chromium.org>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Commit-Queue: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524537}

Replace with calls to SetLayoutManager(make_unique...);
This is for consistency with other layout manager types now that we have a
safer scoped_ptr way to set the layout manager.

GridLayout's members have been updated to use C++11 initialization.

Change-Id: Ief98beea9e473cec1550642c4d2b6e8d40c9e14f
Reviewed-on: https://chromium-review.googlesource.com/830675
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524536}

The freetype unbundle build file is out-of-date, and trying to use it
will result in errors like this:

ERROR Unresolved dependencies.
//third_party:freetype_harfbuzz(//build/toolchain/linux/unbundle:default)
  needs //third_party/freetype:freetype_source(//build/toolchain/linux/unbundle:default)

This CL changes the unbundled build file to simply toggle the
use_system_freetype flag.

R=thestig@chromium.org
CC=phajdan.jr@chromium.org

Change-Id: If38ccc51098857cd479707879562b23f8f32e85f
Reviewed-on: https://chromium-review.googlesource.com/830974Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524535}

Moving the PdfToEmfConverter interface to the printing service.
As a result, simplified the client of that interface in
chrome/browser/printing/pdf_to_emf_converter.cc:
- merging PdfConverterUtilityProcessHostClient and PdfConverterImpl.
- calls on the service can now happen on the UI thread instead of the
  IO thread

Renamed the mojom::PdfToEmfConverter implementation from
PdfToEmfConverterImpl to PdfToEmfConverter as is now preferred naming
style for Mojo interface implementation.

Bug: 766451
Change-Id: Ic748547f56bb193a558210f97558640ef8d6e44b
Reviewed-on: https://chromium-review.googlesource.com/826308Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524534}

Now that all the tests have been migrated to the new integration test
framework, we can remove the remaining bits of the legacy framework.

There were a few references to inspector files in a handful of network
tests, which have been updated to their respective devtools' resources files.

Also found a (disabled) virtual test that slipped through the cracks:
virtual/threaded/http/tests/devtools/tracing/idle-callback.js

Bug: 667560
Change-Id: I2fddfee0af766c7f672bd118ff3fc75d23418d89
Reviewed-on: https://chromium-review.googlesource.com/828268Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524533}

Bug: 795333
Change-Id: Iec3bfa4f6ed0f10813f20fbc93e3422cd094334a
Reviewed-on: https://chromium-review.googlesource.com/830606Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524532}

This CL adds the blink unit tests (blink_heap_unittests,
blink_platform_unittests, webkit_unit_tests, webkit_python_unittests,
wtf_unittests) to a bunch of mac, linux, win, chromeos, and fyi
bots where they should've been running but weren't, by removing a
bunch of test_suite_exceptions. All of these tests are fast so there
should be no significant impact on capacity or cycle time.

There are still a bunch of exceptions for android, memory, and clang
bots that we'll address in a follow-up CL.

R=jbudorick@chromium.org, foolip@chromium.org
BUG=560435, 795306

Change-Id: I38c5b72b49e47014017cf671dd22c4bf52b5869d
Reviewed-on: https://chromium-review.googlesource.com/829874
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524531}

* reattach-after-editing-styles.html - migrated into a protocol test.
* shadow-dom-rules-restart.html - migrated into a protocol test.
* injected-script-discard.html - migrated into a protocol test.
* tabbed-pane-closeable-persistence-restore.html - removed. It required an
unusual testing API and has adequate coverage from tabbed-pane-closeable-persistence.js
and browser test "DevToolsSanityTest.TestSettings"
* open-close-open.html - tried migrating into a browser test, but found a race condition
with quickly opening, closing, and re-opening DevTools window. This test covered a very
specific regression and had a very specific implementation fix which doesn't seem applicable
anymore: https://bugs.webkit.org/show_bug.cgi?id=56747

Bug: 667560
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I41b0ea3e7837dee5049cc973354c431d09d9ae7f
Reviewed-on: https://chromium-review.googlesource.com/827647Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524530}

Bug: 739418
Change-Id: Idc340923293ac257c15045c047da08c3c18281a6
Reviewed-on: https://chromium-review.googlesource.com/831147Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524529}