- 08 Nov, 2018 40 commits
-
-
Daniel Bratell authored
A change included an internal blink header in the public api layer which then leaked parts of blink's internal out into the wild dangerous world outside. This is a quick fix to close that leak. Might need some tuning. Bug: 902022 Change-Id: I076f4c5d0a27cd4c3070d8fe8a5be97f2f65e1e0 Reviewed-on: https://chromium-review.googlesource.com/c/1323715 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#606409}
-
Javier Ernesto Flores Robles authored
Creates and logs user actions for the following actions. ManualFallback_Close ManualFallback_ClosePopover ManualFallback_OpenPassword ManualFallback_OpenCreditCard ManualFallback_OpenProfile ManualFallback_Password_SelectUsername ManualFallback_Password_SelectPassword ManualFallback_Password_OpenOtherPassword ManualFallback_Password_OpenManagePassword Bug: 845472, 881734 Change-Id: If251294575be60b9c27296e79e06a394a277762e Reviewed-on: https://chromium-review.googlesource.com/c/1317914Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#606408}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 12dbcc93. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams hbos@chromium.org, hta@chromium.org: external/wpt/webrtc meade@chromium.org: external/wpt/web-animations NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic9532b352ac67df15f3784e65b5c289a19cd402a Reviewed-on: https://chromium-review.googlesource.com/c/1325563 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606407}
-
Yi Su authored
Current implementation of search_engine.js finds Open Search <link> when the Js file is injected without a check on page's loading status. This CL adds a check for document.readyState, so that the finding process will only be executed when the page is fully loaded. Bug: 433824 Change-Id: I3384081dd3079f15dba6a727cf1373edc4b593ba Reviewed-on: https://chromium-review.googlesource.com/c/1323716 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#606406}
-
Tomas Popela authored
Currently when the stubs code is used outside of the Chromium (i.e. in WebRTC) the build will fail because of the missing implementation of VLOG() - it's defined in the //base/logging.h, but WebRTC can't use that as it uses its own //base_rtc/logging.h with RTC_LOG() functions. To make it buildable there add a two new options to the generate_stubs.py. The first one '--logging-function' or '-l' is used for passing the function call for logging. Its default value is set to 'VLOG(1)' so the current code doesn't need to be updated. The second one is '--logging-include' or '-n' that is used for passing the header file where the function from the '--logging-function' is defined. Change-Id: Iafc898deb818c0a140d177d0190f4db52294df0d Reviewed-on: https://chromium-review.googlesource.com/c/1317918Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> Cr-Commit-Position: refs/heads/master@{#606405}
-
Boris Sazonov authored
1. Revised how Preferences activity gets argument bundle to pass to a subpage fragment. PreferencesLauncher methods got Bundle argument, so EXTRA_SHOW_FRAGMENT and EXTRA_SHOW_FRAGMENT_ARGUMENTS are package-private now. 2. The type of PreferencesLauncher.launchSettingsPage fragment parameter is changed to Class<? extends Fragment> to get compile-time checks. 3. A bunch of callers are changed to use launchSettingsPage instead of createIntentForSettingsPage followed by startActivity. 4. DataReductionPreferences and PasswordEntryEditor now get their parameters using fragment arguments instead of intent extras. Bug: None Change-Id: Ic0ae700149d721ab9194ed36c311c8f8b47bea1e Reviewed-on: https://chromium-review.googlesource.com/c/1323071Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#606404}
-
philipel authored
Cleanup related to https://webrtc-review.googlesource.com/c/src/+/108861 Bug: webrtc:9946 Change-Id: Iae472e30fa5e574c7e23b53c5dc7af767838b98f Reviewed-on: https://chromium-review.googlesource.com/c/1323091Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Philip Eliasson <philipel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606403}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/acacecec..5c68fccf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id9448a19f02186e23422d76db01009b1add0fe59 Reviewed-on: https://chromium-review.googlesource.com/c/1325941Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606402}
-
Mathias Carlen authored
Before this change we only had a fork of the payment request logic, not the UI underneath. This makes customizing the UI tricky without exposing larger parts of the Payment Request UI to Autofill Assisatnt. This patch tries to fork the PaymentRequestUI in a non invasive way. This includes the java classes and the corresponding xml. We accept the potential of being broken by changes in payments/ to non-forked parts and will fix that on the Autofill Assistant side as needed and merge back later if that makes sense. As an example of how to customize the UI on the Autofill Assistant side, this patch includes a customized PaymentRequestBottomBar (java and xml). The buttons need more styling, which will be done in an upcoming change. R=gogerald@chromium.org, twellington@chromium.org another use case. It should go away once we refactor the existing API and share more code. Binary-Size: Increase is temporary due to a payment request UI reuse for Bug: 806868 Change-Id: Iec801cc7d667e39c58e3604c0f62ea8289e90a1e Reviewed-on: https://chromium-review.googlesource.com/c/1316730 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:Theresa <twellington@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#606401}
-
Khushal authored
Currently text blobs are cached in the GPU process in the ServiceTransferCache during OOP raster. This approach has 2 shortcomings: 1) While it gives us cache hits in skia's internal caching keyed on these blobs, we still reserialize the blobs each time. This is because the client side tracking of an entry in ClientTransferCache can get more expensive than serializing the entry itself for these small entries. 2) The ServiceTransferCache budget is based on the assumption that it will be used for images, which is much larger than needed for this use-case. And because the eviction is also only done when we hit the cache limit, even if the renderer creating the entries is now invisible, the cache gets filled with stale data that may have already been purged on the client and will never be reused. This change adds a new client driven cache for these paint data type (text blobs and paths), with a much smaller budget and something that is cleared during our normal context idle cleanup or on visibility change. Lookup and additions to the cache are also slightly cheaper than transfer cache since it avoids allocating discardable handles for cross process ref-counting and the need to track entries which need to be unref-ed after every raster. TBR=tsepez@chromium.org R=enne@chromium.org, piman@chromium.org Change-Id: Ibc4039ec5ab20e45c1ae67aec20367c20371458f Bug: 898910,894200 Reviewed-on: https://chromium-review.googlesource.com/c/1321190 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606400}
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/f56830ed406f..fb0d66d04c4d $ git log f56830ed4..fb0d66d04 --date=short --no-merges --format='%ad %ae %s' 2018-11-07 bungeman [truetype] Fix VF check from 2018-09-12 (#54973). 2018-11-06 wl [pshinter] Fix numeric overflow. 2018-11-06 wl [psaux] Fix timeout in old CFF engine. 2018-11-04 apodtele Minor. 2018-11-04 apodtele * src/truetype/ttgxvar.c: Use enum definitions. 2018-11-03 apodtele * src/truetype/ttgxvar.c (ft_var_apply_tuple): Adjust condition. 2018-11-03 apodtele * src/truetype/ttgxvar.c (ft_var_apply_tuple): Tracing tweaks. 2018-11-03 apodtele Revert due to specs: [truetype] Speed up variation IUP. 2018-11-03 apodtele Revert "[truetype] Speed up variation IUP." 2018-11-02 apodtele * src/truetype/ttgxvar.c (ft_var_get_item_delta): Fixed logic. 2018-11-02 shailesh.mistry [autofit] Prevent SEGV. 2018-10-31 apodtele [truetype] Speed up variation IUP. 2018-10-31 apodtele * src/type1/t1load.c (t1_set_mm_blend): Optimized. 2018-10-31 apodtele * src/truetype/ttgxvar.c (ft_var_get_item_delta): Optimized. 2018-10-29 wl [base] Fix numeric overflow. 2018-10-29 wl [cff] Fix numeric overflow. 2018-10-28 apodtele Comment on timestamp storage. 2018-10-26 apodtele [sfnt] Make `head' timestamps unsigned. 2018-10-26 apodtele Revert "Align FreeType with standard C memory management." 2018-10-27 wl [psaux] Fix numeric overflow. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng PDFium-Issue: pdfium:1191 Bug: chromium:902759 Change-Id: I9cecc7b01263a068b81e7692962cd92ec60fccc6 Reviewed-on: https://chromium-review.googlesource.com/c/1323793 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#606399}
-
Marc Treib authored
One less custom subclass of FakeSyncService :) Bug: 859874 Change-Id: Idfafda6dcb3ab705a6c6410d27dd4087b0d91699 Reviewed-on: https://chromium-review.googlesource.com/c/1318979 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#606398}
-
Marc Treib authored
One less subclass of FakeSyncService to maintain :) Bug: 859874 Change-Id: I29d0f367227f59c2ab3b08eefefbd1b21bb35019 Reviewed-on: https://chromium-review.googlesource.com/c/1318922Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#606397}
-
Mark Cogan authored
-tabLoadComplete just tells the tab model to save asynchronously; this CL just has call sites do that directly. Change-Id: Ic7306d20505de61ca412f08794719fdd8c0057e6 Reviewed-on: https://chromium-review.googlesource.com/c/1323052 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#606396}
-
Alexey Baskakov authored
We parse them from manifest during installability check. Bug: 891172 Change-Id: I891dd48f29e6f43386c028a14f92c08db630da5e Reviewed-on: https://chromium-review.googlesource.com/c/1325580 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#606395}
-
Nico Weber authored
This reverts commit 58730f7f. Reason for revert: There's no tot bot for this config (https://crbug.com/903078) Original change's description: > Promote win-libfuzzer-asan-rel CQ bot out of experimental. > > Cycle time and failure rate looks good. > > Bug: 893614 > Change-Id: I43fcdf7f8e1b920ec784c0c67025e72aa7169873 > Reviewed-on: https://chromium-review.googlesource.com/c/1299973 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603113} TBR=dpranke@chromium.org,bpastene@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 893614 Change-Id: I10200022b338edf0cc0ee7100f7ff417b7c19eb8 Reviewed-on: https://chromium-review.googlesource.com/c/1325982Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#606394}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bd8b72d215eb..6b82a698270f Created with: gclient setdep -r src-internal@6b82a698270f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I05e3cf9fdf741a3b2a2dce3050eba8475438ea58 Reviewed-on: https://chromium-review.googlesource.com/c/1325376Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606393}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2f8889b876d3..23d1f94faac1 git log 2f8889b876d3..23d1f94faac1 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@23d1f94faac1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I07b09336847b1d21e54c779a02af902c55bca8ce Reviewed-on: https://chromium-review.googlesource.com/c/1325861Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606392}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/026f83d49289..f04a3a61ad90 git log 026f83d49289..f04a3a61ad90 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 dpranke@chromium.org Update the expectation parser in TYP to match the new format. Created with: gclient setdep -r src/third_party/catapult@f04a3a61ad90 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:835690 TBR=sullivan@chromium.org Change-Id: I342f7d89d9cd55f70eaad8659ac9d56450d4ddf5 Reviewed-on: https://chromium-review.googlesource.com/c/1325653Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606391}
-
Alexandre Courbot authored
This document used to be maintained as a Google Docs, but having it available in the Chromium repository makes it much easier to access for partners. BUG=None TEST=Generated and checked HTML using Markdown. Change-Id: I790504be2720150cebee151a585a2435ac35a494 Reviewed-on: https://chromium-review.googlesource.com/c/1322174 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#606390}
-
Yuzu Saijo authored
This CL allows detection-only mode for oom intervention in order to gather data from finch, while not actually triggering intervention (or the infobar). Change-Id: I511bf3ccd51218521a526ea001de2a823e1c16bc Reviewed-on: https://chromium-review.googlesource.com/c/1325583Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#606389}
-
Yoichi Osato authored
We used to invalidate always LayoutSVGText even local selection rect was empty before inserting early return of L342. That caused regression that selection in svg text is not invalidated. This patch fixes the regression by invalidating LayoutSVGText always as before. Bug: 897752 Change-Id: I534959ccb461d55d38e85e053c9b9c478b3878b3 Reviewed-on: https://chromium-review.googlesource.com/c/1314019 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#606388}
-
Gauthier Ambard authored
This CL removes the -closeAllIncognitoTabs command as it is not used. Bug: 902781 Change-Id: I583e53095fcddf03c899d6b44779b38daced32a3 Reviewed-on: https://chromium-review.googlesource.com/c/1323670Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#606387}
-
Arthur Sonzogni authored
After sending: URLLoaderClient::OnReceiveResponse(response_head), not all URLLoader are sending: URLLoaderClient::OnStartLoadingResponseBody(response_body). It even happens to send URLLoaderClient::OnComplete(net::OK) after that, which may confuse the URLLoaderClient. Most URLLoader not sending a response's body datapipe are the one with an empty response. For consistency, always send a response's body datapipe, even if it doesn't contains data. This CL updates every tests not aligned with this. Once every URLLoader and tests are consistent. DCHECK enforcing this will be added. This CL is a prerequisite for: https://chromium-review.googlesource.com/c/chromium/src/+/1172290 Bug: 826868, 831155 Change-Id: Id3434ea442c93b47bd200d15322cc21cd0c0b89f Reviewed-on: https://chromium-review.googlesource.com/c/1323092Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#606386}
-
Hayato Ito authored
This bug number is not related to the content of TODO comment. TBR=rakina@chromium.org Change-Id: Ifd8563c8104a00134d91c176d8418b93592098da Reviewed-on: https://chromium-review.googlesource.com/c/1325284Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#606385}
-
yoshiki iguchi authored
This CL is almost reverts of the following CL: crrev.com/c/1315207 This test has been disabled on Chrome OS because of flakiness: crbug.com/901235. The flakiness is fixed by the recent change (crrev.com/c/1316986) so that this CL re-enable it. TBR=mlamouri@chromium.org, vitaliii@chromium.org Bug: 901235 Test: trybots pass Change-Id: I1cec695988728ae40bd1f6031135efaf07c760b3 Reviewed-on: https://chromium-review.googlesource.com/c/1325597Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#606384}
-
John Z Wu authored
1. Add API to enable explicit updates of expiration dates. This is needed to handle cases where user was issued a new card where only the expiration date and CVCs changed. 2. Remove CWVCreditCardVerifierErrorMessageKey and use NSLocalizedDescriptionKey instead. Change-Id: Iff1dbed037d991be8d582c5e734d49e33916de99 Reviewed-on: https://chromium-review.googlesource.com/c/1325282 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#606383}
-
David Jean authored
These helpers create a bridge between manual fill credit card and payments' FullCardRequester to let user 'unlock' server side credit card by entering correct cvc. Bug: 845472 Change-Id: I9fcf013a0352673659d77291c03faa8aa31a9980 Reviewed-on: https://chromium-review.googlesource.com/c/1304413Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#606382}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/28451dd1..acacecec Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I67d87ebec9b223023d4665986c066d27fc07bc0a Reviewed-on: https://chromium-review.googlesource.com/c/1325416Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606381}
-
Camillo Bruni authored
This CL updates a couple of system_health wprgo archives. Simple failing GET requests have been manually added to reduce the number of network failures in the benchmarks. Improvements in network requests: play:media:soundcloud:2018 41 down to 8 load:search:taobao:2018 10 down to 3 multitab:misc:typical24:2018 110 down to 96 browse:news:reddit:2018 16 down to 13 load:news:cnn:2018 no change Bug: 878390 Change-Id: I2b2e15e84fe9688a1db72d9216491ed290c94c6a Reviewed-on: https://chromium-review.googlesource.com/c/1323053 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#606380}
-
Yuta Kitamura authored
This CL simplifies lengthy function calls via Platform::Current() that obtain the current, main or compositor thread by using Thread:: Current(), Thread::MainThread() or Thread::CompositorThread(). Bug: 826203 Change-Id: I791712e02848b8792204b598fc7fa19114ae36cd Reviewed-on: https://chromium-review.googlesource.com/c/1319395Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#606379}
-
Nigel Tao authored
This is a reland of f3fe6cc9 with additional changed files: chrome/browser/chromeos/apps/intent_helper/apps_navigation_throttle.cc chrome/browser/chromeos/apps/intent_helper/apps_navigation_throttle.h chrome/browser/chromeos/apps/intent_helper/apps_navigation_types.h chrome/browser/ui/views/intent_picker_bubble_view.h to fix some #include lines not being updated for the file renames, which then required these DEPS changes: chrome/browser/chromeos/DEPS chrome/browser/ui/views/DEPS Original change's description: > Move the app_service code to //chrome/services > > The app_service code was originally created under //chrome/browser, > specifically //chrome/browser/apps/foundation. This was because of an > early concern that the app_service implementation would need to be > tightly coupled to browser concepts, especially a Profile. More recent > prototyping suggests that this won't be the case. > > This is just a "git mv" plus some semi-mechanical clean-up, e.g. keeping > "#include" lines sorted. > > Change-Id: I0e511f5cab636afb7ac5e5235139873d75230377 > Reviewed-on: https://chromium-review.googlesource.com/c/1312435 > Reviewed-by: Dominic Battré <battre@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Nigel Tao <nigeltao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605876} Change-Id: I27729734618c7e023074b5e420c6350225d0774e Reviewed-on: https://chromium-review.googlesource.com/c/1321530Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#606378}
-
Hayato Ito authored
It would be better to remove the author field. See https://crrev.com/c/1322179 for the context. TBR=tkent@chromium.org Change-Id: Id97a9603b1cee3f31058e864ee3e0ff92c1d741e Reviewed-on: https://chromium-review.googlesource.com/c/1325287Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#606377}
-
Jinho Bang authored
This patch adds a use counter to number of calling updateWith() without shippingOptions dictionary member on ShippingAddressChange and ShippingOptionChange events. Bug: 902291 Change-Id: Iac779040dc1a7245dcfe4db795e09d4ecbca9b90 Reviewed-on: https://chromium-review.googlesource.com/c/1319653 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#606376}
-
Tarun Bansal authored
For default search engine pages, give higher weight to cross-origin anchor elements. For non-default search engine pages, give higher weight to same-origin anchor elements. Change-Id: I6de3037d9b28dbb770032255f8f22a7c2e6342a6 Bug: 899098 Reviewed-on: https://chromium-review.googlesource.com/c/1300594 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#606375}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/448b99f1a580..905ee08219fa git log 448b99f1a580..905ee08219fa --date=short --no-merges --format='%ad %ae %s' 2018-11-08 syoussefi@chromium.org Vulkan: Fix cleanup race condition on Context destroy Created with: gclient setdep -r src/third_party/angle@905ee08219fa The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I72a3bbd07553babdf9562fd32b6e3f766080966f Reviewed-on: https://chromium-review.googlesource.com/c/1325335Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606374}
-
Yuki Shiino authored
We've been allowing cross-origin named access on Window just in order to keep the backward compatibility for a while. This patch finally fixes it and ignores cross-origin window name when performing named access on Window. Basically, this is a revert of https://codereview.chromium.org/2753773003 Bug: 538562 Change-Id: I3856bb5c655a9415c2d0b87d1ec4b3743b94d076 Reviewed-on: https://chromium-review.googlesource.com/c/1314021Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#606373}
-
John Abd-El-Malek authored
Remove some duplicate code between NavigationURLLoaderImpl and ResourceDispatcherHostImpl::BeginNavigationRequest. Change-Id: I7befae9ca3d332d5d31a5d0424de8eeb355a8810 Reviewed-on: https://chromium-review.googlesource.com/c/1325151 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#606372}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c248c0542bc1..2f8889b876d3 git log c248c0542bc1..2f8889b876d3 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 1bf18ce9e2ca..448b99f1a580 (1 commits) 2018-11-07 mtklein@google.com Reland "Revert "hide nested hinting enum"" Created with: gclient setdep -r src/third_party/skia@2f8889b876d3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I84d82a9be38b63e9069d494e0f2b4cc26c6a7769 Reviewed-on: https://chromium-review.googlesource.com/c/1325652Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606371}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/991ed76c8331..bd8b72d215eb Created with: gclient setdep -r src-internal@bd8b72d215eb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia59d1db40325c22f70f1f86477e9a6b94c2092a2 Reviewed-on: https://chromium-review.googlesource.com/c/1325656Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606370}
-