GitLab

AAGUID length received from AuthenticatorGetInfo response must be of
length 16[1]. Add this check when parsing response from device and if
AAGUID length is any number other than 16, return base::nullopt.

[1]: https://fidoalliance.org/specs/fido-v2.0-rd-20170927/fido-client-to-authenticator-protocol-v2.0-rd-20170927.html#authenticatorgetinfo-0x04

Bug: 872217
Change-Id: I58e86942ef7eedd3075dabcf49c25407ce3c3050
Reviewed-on: https://chromium-review.googlesource.com/1167798
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582069}

Adds a bunch of tests with high-probability flake due to timeout or
crash, to existing lists of very similar tests that were already
disabled.

Tbr: mgiuca@chromium.org
Bug: 873045, 838057, 856601, 869818
Change-Id: I66e14994ef4551d5690d3a66d51fce84a1eaf456
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1170450Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582068}

The touchevent.clientX is in CSS pixel, and TrackWidth is in CSS * zoom.
This causes when drag on the timeline element by touch, the position set
is wrong.

Bug: 871146
Change-Id: I6ca3c199fc9ad9eede6eea9ae92bb946fdd2fbca
Reviewed-on: https://chromium-review.googlesource.com/1165320Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582067}

caused by frame change

* Set the NONE targeting policy to the subtree of the
shell surface so that WindowEventDispatcher does not
generate syntheiszed events when window is moved during
frame change (in WindowEventDispatcher::OnWindowBoundsChanged)

This will be updated in next version of ARC++.

Bug: b/111319005
Test: covered by unittests. also tested manually on nami device.
Change-Id: I40b86983857ef3ca564d8e3504bf23b448f0626b
Reviewed-on: https://chromium-review.googlesource.com/1170389Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582066}

Some changes in http://crrev.com/c/1111743 had made the default
referrer policy the only referrer policy used for fetching module
workers and worklet scripts, when in fact the spec indicates the
referrer policy of the fetch client settings object ("outer settings"
in the spec") should be used in the case where a ScriptFetchOptions'
referrer policy was not explicitly set. This CL ensures that we fallback
to the fetch client settings object's referrer policy in the appropriate
cases. It is a follow-up to the WPT fixes made in both:
 - https://github.com/web-platform-tests/wpt/pull/12321
 - https://github.com/web-platform-tests/wpt/pull/12330

Remaining failures are due to, and tracked by https://crbug.com/786862,
which revolves around SecurityPolicy::GenerateReferrer not taking into
account a request's origin when determining whether a request is same-origin
or not.

R=kinuko@chromium.org, kouhei@chromium.org, nhiroki@chromium.org, yhirano@chromium.org

Bug: 863769
Change-Id: If493b728df5410a332b064265bbea30527ec9e0f
Reviewed-on: https://chromium-review.googlesource.com/1164648Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Dominic Farolino <domfarolino@gmail.com>
Cr-Commit-Position: refs/heads/master@{#582065}

There's a "move these two files" comment in that list that should only
apply to two files.

Change-Id: Ic09f71fb8a41de2e2a8b99dc2f41c7e547c79b01
Reviewed-on: https://chromium-review.googlesource.com/1168942Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582064}

The following text failures:
  paint/invalidation/reflection/scroll-fixed-layer-with-reflection.html
  paint/invalidation/scroll/scroll-fixed-layer-with-transformed-parent-layer.html
  paint/invalidation/scroll/scroll-in-fixed-layer.html
  paint/invalidation/scroll/scroll-in-transformed-layer.html
  paint/invalidation/scroll/scroll-with-transformed-parent-layer.html
were added to FlagExpectations in the maintenance CL:1166930,
but they are improvements. Their invalidation images match,
and has one less object.

Reviewed the test result of build 8758.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I7665a49b24ab94f6871722f9cd172743d662ba63
Reviewed-on: https://chromium-review.googlesource.com/1170443
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582063}

- Gesture can be accidentally locked to scroll if user performs pinch
  gesture at right or bottom of the screen. This CL removes gesture
  lock.
- Gesture lock was implemented to avoid blurry scroll but it seems that
  it's not happening with gesture centered pinch zoom.

      screen and confirm that it works.

Bug: 870635
Test: Manually tested. Perform pinch gesture on right or bottom of the
Change-Id: I79893d8f7ef23b51b7339aa3930771aebec78a07
Reviewed-on: https://chromium-review.googlesource.com/1168712Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582062}

Following bot results are included.
8704 8705 8708 8711 8718 8723 8729 8731 8734 8737 8738 8739
8745 8750 8755 8758

3 lines were removed and 5 lines were deflaked by consecutive
results since 8718.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I7e5f08221d619f8f9d473cc0c7dcf7becae15f74
Reviewed-on: https://chromium-review.googlesource.com/1166930
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582061}

This patch changes NGLineBreaker not to give the text before
the start of the line to ICU TextBreakIterator.

It looks like ICU computes all the text from the beginning of
the given text. Giving the block text content makes ICU to
perform much slower, especially when LayoutNG re-creates
break iterators on each line.

This patch improves ArabicLineLayout.html by more than double.
Also it is expected to improve all 16-bit cases.

For break-anywhere, this patch relies on r581771 (CL:1165276)
that adds StringView to NonSharedCharacterBreakIterator.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I32f6d214e0b64a728ec4d91c1cd9e8a1870745ba
Reviewed-on: https://chromium-review.googlesource.com/1168279
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582060}

Change-Id: If706b5db0ca42234156430bb3ff2c8ab15e388af
Reviewed-on: https://chromium-review.googlesource.com/1168191
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582059}

Bug: 789577
Change-Id: Ib228eed68a8ab418f5a7922a3e1f0f3e4f311c0f
Reviewed-on: https://chromium-review.googlesource.com/1168947
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582058}

The  img.decode() api shipped in M64
https://chromium-review.googlesource.com/721771
https://www.chromestatus.com/feature/5637156160667648

BUG=705669

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I79ea70305d2746794b4ddc0d0af608c32291ce14
Reviewed-on: https://chromium-review.googlesource.com/1165042Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582057}

This CL moves all the logic from the FormInputAccessoryViewController
that is not directly related to managing its view to a new mediator.
Creates a consumer for the communication the the view controller.
Updates tests to use this mediator instead.
Removes the dependency on the CRWWebViewProxy.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1b0f6c595f069ea45e04c9dacdc4437dbfe9041a
Bug: 661622, 727716, 845472, 847408
Reviewed-on: https://chromium-review.googlesource.com/1130522Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582056}

element_ can be null, so adding IsNull() checks to prevent crashes.

Bug: 862044

Change-Id: Ibcbf445684b6f221729e7a6f4259c84ed8ed8127
Reviewed-on: https://chromium-review.googlesource.com/1169435
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582055}

This reverts commit af00b29e.

Reason for revert: Suspect for https://crbug.com/873015

I have low confidence that this is the culprit but it's my best guess.

Original change's description:
> Delete constructor for creating empty CSSStyleSheets
> 
> Currently, empty CSSStyleSheets can be constructed either with a constructor or with Document.createEmptyCSSStyleSheet.
> This CL deletes the constructor so that they can only be produced by Document.createEmptyCSSStyleSheet.
> 
> Document.createEmptyCSSStyleSheet is considered to be more desirable, as CSSStyleSheets produced by Document.createEmptyCSSStyleSheet can be tied to documents in the future. This means that their use can be limited in the documents where they were produced, resulting in higher security.
> 
> Note:
> The constructed CSSStyleSheet is not currently tied to the Document yet
> 
> Link to related comments in discussion:
> https://github.com/WICG/construct-stylesheets/issues/23#issuecomment-379180786
> https://github.com/WICG/construct-stylesheets/issues/15#issuecomment-391216056
> 
> Bug: 807560
> Change-Id: I767e15e83e1f31eb278bc81233c8b579d0f511c7
> Reviewed-on: https://chromium-review.googlesource.com/1164876
> Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
> Reviewed-by: Hayato Ito <hayato@chromium.org>
> Commit-Queue: Momoko Sumida <momon@google.com>
> Cr-Commit-Position: refs/heads/master@{#581836}

TBR=hayato@chromium.org,rakina@chromium.org,momon@google.com

Change-Id: Iea70ff4dcc3a5ecf3a806b417572fd8f88e2e58b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 807560, 873015
Reviewed-on: https://chromium-review.googlesource.com/1170462Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582054}

This function runs the crostini installer GUI to install the default
crostini vm and container and perform sshfs mount.  Callback executes
when installation is complete.

Bug: 854401
Change-Id: Iafee8161b159fb5d2430d46b3cbb0e0ac5f7527a
Reviewed-on: https://chromium-review.googlesource.com/1166765
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582053}

PerformancePaintTiming shipped in M60
https://codereview.chromium.org/2905543002
https://www.chromestatus.com/feature/5688621814251520

BUG=720055

Change-Id: I528c714cb7a913bc9b8e453096aa92ec8eae5e5a
Reviewed-on: https://chromium-review.googlesource.com/1164969Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582052}

The sizing is not perfect by any stretch though.  The size is
smaller by what appears to be the status bar height.  While
this is not ideal, it is still progressing towards being
actually usable.

BUG=704070

Change-Id: Ieae588fd9a5fc43b700adba399b86fb4e888349d
Reviewed-on: https://chromium-review.googlesource.com/1169976
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582051}

Bug: 873025
Change-Id: Ibbf85f4a9645f0e4bde132ae39e541416c6a4073
Reviewed-on: https://chromium-review.googlesource.com/1170154Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582050}

Bug: 868555
Change-Id: I5e96263d5d3cea491a65b9b94b69ad89fdf5eb5a
Reviewed-on: https://chromium-review.googlesource.com/1164575
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582049}

This CL is for debugging the root cause of https://crbug.com/856818 .
Instead of propagating the bad state and crash later, we will abort when
the bad state is assigned, in hope to collect more context from the
crash trace.

BUG=856818

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I41bfa2946396f157f72b79d867dc4717c926169a
Reviewed-on: https://chromium-review.googlesource.com/1168135Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582048}

I switched to use gomacc injection for chromeos toolchain in below CL.
https://chromium-review.googlesource.com/c/chromium/src/+/1151040

But simple chrome build also uses host compiler that does not know GOMACC_PATH
envvar. This CL revived goma's power for such toolchain.

This CL should be landed after cros side fix.
https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1168277

And above CL was rolled.
https://chromium-review.googlesource.com/1168416

Bug: 872536
Change-Id: I938de4aea6c39b633a31cf1668ac147a9c6d0807
Reviewed-on: https://chromium-review.googlesource.com/1168275Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582047}

Bug: 872364
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib45390dab6120e74d51564760433972f17dae9dc
Reviewed-on: https://chromium-review.googlesource.com/1167882Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582046}

This CL fixes a bug where LayerTreeHostImpl::OnPurgeMemory() causes
TextureLayerImpl to register duplicate SharedBitmapIds. OnPurgeMemory()
ends up calling TextureLayerImpl::ReleaseResources(), which assumed that
the LayerTreeFrameSink was lost if it was called. SharedBitmapIds should
only be reregistered if the LayerTreeFrameSink is actually lost.

Add new OnPurgeMemory() function on LayerImpl. This will by default keep
the old behaviour by calling ReleaseResources() but TextureLayerImpl can
override it to not do anything.

Bug: 862584
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I32cd4e45d629b2f8410adff80f712f1b517a1407
Reviewed-on: https://chromium-review.googlesource.com/1169430Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582045}

New CallStackSidebarPane tries to finally split model and view by using
live locations more.
With new implementation each item maintains own state based on live
location updates and schedule updates of correspond list item.

drive-by: removed BlackboxManager.isRawLocationBlackboxed method.

R=lushnikov@chromium.org

Bug: none
Change-Id: I19adde997652754e5f90869ee41ab41899bf8ec4
Reviewed-on: https://chromium-review.googlesource.com/1168384
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582044}

Pipeline throttling for iframes with loading sheets shipped in M56
https://codereview.chromium.org/2488213005
https://www.chromestatus.com/feature/5640551701413888

The flag RenderingPipelineThrottlingLoadingIframes is no longer needed.

BUG=663193

Change-Id: Ieba672a8f7a8e3e0702a182aacf9931fec54a3d9
Reviewed-on: https://chromium-review.googlesource.com/1166747
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582043}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/15a5a77db412..284b5e0c60ac


git log 15a5a77db412..284b5e0c60ac --date=short --no-merges --format='%ad %ae %s'
2018-08-10 recipe-roller@chromium.org Roll recipe dependencies (nontrivial).
2018-08-09 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-08-09 iannucci@chromium.org [osx_sdk] Add mac_toolchain based osx_sdk module.


Created with:
  gclient setdep -r src/third_party/depot_tools@284b5e0c60ac

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Ia35a53873c5576541eef1bcce633baa62f7b4b15
Reviewed-on: https://chromium-review.googlesource.com/1170284Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#582042}

This CL introduces SetRestoredBoundsInPixels/GetRestoredBoundsInPixels
in PlatformWindow to communicate with DesktopWindowTreeHostPlatform
and makes DesktopWindowTreeHostPlatform use PlatformWindow::
GetRestoredBoundsInPixels() to get restored bounds.

When WaylandWindow is created, HandleSurfaceConfigure() is always
called without any state setting and |state_| is normal at first.
In order to know the right time when the state is changed, this
patch also updates the initial value for |state_| of WaylandWindow
to 'PLATFORM_WINDOW_STATE_NORMAL'. With this, it clears
|restored_bounds_| correctly.

--ozone-platform=wayland --in-process-gpu, see crbug.com/848131
for more details.

Test: ozone_unittests and manual testing with ./out/ozone/chrome
Bug: 848131, 578890
Change-Id: Ifc27e60e24865a2237a0a49d5dc0f1452702c716
Reviewed-on: https://chromium-review.googlesource.com/1080354Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#582041}

https://pdfium.googlesource.com/pdfium.git/+log/60627d6eafd0..4174b5ab6ac9


git log 60627d6eafd0..4174b5ab6ac9 --date=short --no-merges --format='%ad %ae %s'
2018-08-10 tsepez@chromium.org Add CFX_DIBSource::GetWritableScanline().
2018-08-09 tsepez@chromium.org Move all utf8 decoding under fx_string.h


Created with:
  gclient setdep -r src/third_party/pdfium@4174b5ab6ac9

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Id740ab3447b12f44c2d3d1ecbab50da62dd3e9b2
Reviewed-on: https://chromium-review.googlesource.com/1170283Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#582040}

Capacity issue on Nexus6 Webview has been resolved, so this may be ok to reenable
the benchmarks on this platform now

TBR=ksakamoto@chromium.org
NOTRY=true

Bug: 676612
Change-Id: I8f6a93767d47f94ba66a8a9df43b8d3a0b03b951
Reviewed-on: https://chromium-review.googlesource.com/1170422Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#582039}

The class is refcounted and uses Mojo pipes. It could execute tasks as
a result of Mojo callbacks after its refcount was 0, while there was a
task to delete itself posted. Those tasks, if executed, would grab
another reference (incrementing it from 0 to 1). That would result in
use-after-frees and double deletion, once the already posted delete
task was executed.

This CL fixes that by getting rid of the callbacks executed from Mojo,
and removing the weak reference used in another call. The downside of
this approach is that Mojo errors are only lazily detected, which could
result in displaying an extra error page in the case of network service
crash.

Bug: 870942
Change-Id: Ic7b00de6e7c623dc62098118292290666c91b1a7
Reviewed-on: https://chromium-review.googlesource.com/1164302Reviewed-by: Chong Zhang <chongz@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582038}

Bug:873033, 873032
Change-Id: Iff4749c56872f8a56322bce4e353b31bb59f454f

TBR=kouhei@chromium.org, ksakamoto@chromium.org
NOTRY=true

Change-Id: Iff4749c56872f8a56322bce4e353b31bb59f454f
Reviewed-on: https://chromium-review.googlesource.com/1170400Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#582037}

The current code assumes that a frame-less window does not need shadow.
However, it's important for the CrOS wallpaper picker to remain
frame-less to support wallpaper preview in tablet mode (spec [1]), and
have a shadow in clamshell mode. It should makes sense to delete this
logic since wallpaper picker is the only component extension that needs
this behavior, and no current public apps are able to use the API.

[1] https://drive.google.com/corp/drive/folders/0B_2Uyb2Rhx2ObU5VTFJVWHR2WW8

Bug: 835205
Change-Id: I96c9b14806f8f03ea2278d11031a33b08e7a68e8
Reviewed-on: https://chromium-review.googlesource.com/1135577
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582036}

This CL creates the option to call setPictureInPictureControls() on an
HTML video element with the desired info for custom controls. An
example of the form this takes can be seen below:

await videoElement.setPictureInPictureControls([
  {
    id: "thumbs-up",
    label: "Thumbs up",
    icons: [
      {
      src: "http://dummyimage.com/96x96",
      sizes: "96x96",
      type: "image/png"
      }
    ]
  }
]);

The actual addition of these controls to the PiP window will come in a
future CL.

Bug: 863967
Change-Id: I6f6e65a28b546ba31ed67dd4ac92c550a0249b40
Reviewed-on: https://chromium-review.googlesource.com/1138640
Commit-Queue: Steven Sawtelle <sawtelle@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582035}

Move auth related metrics recording from LoginMetricsRecorder in ash
to LoginAuthRecorder in chrome, because fingerprint attempt is observed
in chrome. Extend existing uma to support fingerprint case and also
add some new uma.
Detail is listed in crbug.com/862295#c2

Bug: 862295
Change-Id: I460ea4edcd8798c54998b5afe7e6691f65ebbb06
Reviewed-on: https://chromium-review.googlesource.com/1166462
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582034}

Embedded CSP enforcement shipped in M61
https://chromium-review.googlesource.com/525693
https://www.chromestatus.com/features/5750241810710528

BUG=647588

Change-Id: I90e82d7b3427015f7f173338001e2e473fa2fff3
Reviewed-on: https://chromium-review.googlesource.com/1165045Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582033}

Whitelist the new Highlights app for chromeosInfoPrivate and public
sessions.

There are two versions of this app.

Bug: 841089
Change-Id: Ie893d5f697c4cca36a5d7ca7427419eb4d3e8b2a
Reviewed-on: https://chromium-review.googlesource.com/1152291Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Ivan Šandrk <isandrk@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582032}

BrowserGpuClientDelegate might have been destroyed when
OnEstablishGpuChannel callback is run. Although this callback does not
use |this| and just runs the other callback passed to it, it is
technically an undefined behavior. Making it a non-member function,
helps us avoid this undefined behavior.

BUG=872140,872219,872244

Change-Id: Id7641c6c3ff2dcb153e9ed9b245013e878cc947a
Reviewed-on: https://chromium-review.googlesource.com/1169964Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582031}

Bug: b/111748671
Test: Manual
Change-Id: I9dcd0800903309e8984f9a88d52f4bc49c316ca7
Reviewed-on: https://chromium-review.googlesource.com/1170162Reviewed-by: Muyuan Li <muyuanli@chromium.org>
Reviewed-by: Yue Li <updowndota@chromium.org>
Commit-Queue: Muyuan Li <muyuanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582030}