- 06 Jun, 2019 13 commits
-
-
Peter Kasting authored
This will make it more feasible to replace child_count() with children().size(). This has a large number of followon effects. Bug: 956419 Change-Id: I2c4d1700571a7cd00cef926beb525661c7073e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636254 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#666538}
-
Sam Dallstream authored
Intent to ship discussion on blink-dev: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/wXbIl5mq4eo/GSyt-hXeBQAJ Bug: 923556 Change-Id: I805175cff562fe127a674b079023ff7dbc8ed32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627697 Commit-Queue: Samuel Dallstream <sadallst@microsoft.com> Reviewed-by:
Daniel Bratell <bratell@opera.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#666537}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ee7921db7153..8a3738936814 git log ee7921db7153..8a3738936814 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@8a3738936814 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ica5fe67c92119e60a564c70c81800caeacea9d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647179Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666536}
-
Lucas Tenório authored
This change adds the "Details" and "All Set" pages to the flow, as well as a class to manage the (now multiple) onboarding states. Another change is that we stop removing some webview listeners when we stop loading the page. This was causing the webview to never finish loading subsequent pages, getting stuck in the first blocking listener. Bug: 958995 Change-Id: Ib28f8d271263ffa832e05a5c6cefb7f7675b02a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630223 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#666535}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/f5edb4f542e1..31200def0dec git log f5edb4f542e1..31200def0dec --date=short --no-merges --format='%ad %ae %s' 2019-06-05 absl-team@google.com Googletest export 2019-06-05 misterg@google.com Googletest export 2019-05-30 misterg@google.com Merge pull request #2264 from mbrobbel:suppress-cmp0048-warning 2019-05-30 absl-team@google.com Googletest export Created with: gclient setdep -r src/third_party/googletest/src@31200def0dec The AutoRoll server is located here: https://autoroll.skia.org/r/googletest-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official TBR=isamsonov@google.com Change-Id: If4828c107a6a91f05fdb178bbcb54c77794c0bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644763Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Staphany Park <staphany@chromium.org> Commit-Queue: Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#666534}
-
Collin Baker authored
Currently, ImageButton::SetImage() only schedules a paint when |for_state| matches the current state. However, this is wrong: any state that doesn't have an image falls back to the STATE_NORMAL image. Instead, this CL makes SetImage() always call SchedulePaint(). Bug: 920576 Change-Id: I8119a44b63754a11426db804394593e0e0c0d495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644014 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#666533}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Idc197bf8e16f3055fb445754cec196452d7dcf07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646659Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666532}
-
Yusuke Sato authored
The feature was punted to a later milestone. This CL put the following features behind the flag: * 'External storage preferences' submenu in chrome://settings/storage * "OPEN SETTINGS" button in the Files.app notification. * "Open settings" link in the Files.app toast. BUG=936814 TEST=try TEST=Show chrome://settings/storage, verify the new UI is hidden TEST=Plug a USB storage device, verify the new UI is hidden in Files.app Change-Id: I31eb74f673455b83ae0f56f2479a044072156970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636810 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#666531}
-
Piotr Bialecki authored
TransformationMatrix should not be used as a member in classes allocated on Oilpan heap. Bug: 970348 Change-Id: I21b6fa68e4e37a7ef95432e685b635c5915db174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642981Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#666530}
-
Oystein Eftevaag authored
R=ssid@chromium.org CC=etienneb@chromium.org Change-Id: If3d32313d8202889a6765a4eef80a799b99d1508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630232 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#666529}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3c4538b3. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" abf2ac5e "webrtc wpt: avoid race conditions" 1bbbd106 "Add feature policy for client hints, used for third-party subresources." ab94a58b "Add the remaining Client Hints to Feature Policy." a5b31124 "DetachLayoutTree clear hover/active state on dom removal." 04c3df15 "Canvas::TestMetrics: Measure the TextMetrics info after loading the font" 6222cc8d "[ElementTiming] Text support part 2" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-grid external/wpt/css/css-ui NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I86168cadbe68fcf3027ef8d5210c1f2213fa1f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646372Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666528}
-
Min Qin authored
"Accept-Ranges" header are not required for servers supporting range requests. This CL changes the accept_range field in DownloadCreateInfo to use an enum so that we can experiment parallel download even if range support is unsure. BUG=917366 Change-Id: I9d6d444437650957b12225da0cada85d0cce5473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645480Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#666527}
-
Lambros Lambrou authored
This updates the Mac postflight script to ignore errors from the config-upgrade tool, so that installation is successful in case of network failure or a missing config file. Bug: 971392 Change-Id: Ib7f487ff71c8a4ab636fbd938f36f11034f33541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647135 Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#666526}
-
- 05 Jun, 2019 27 commits
-
-
Gabriel Charette authored
This is more consistent with other Vectors held in DEFINE_STATIC_LOCAL R=andruud@chromium.org, yosin@chromium.org Change-Id: I284527e376c7b7d31d986ca2e6fabdf72f353ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645832 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#666525}
-
Kristi Park authored
Content width is calculated using the number of columns of MV tiles. This is inaccurate as of M69 since the tile width was changed. Update column count and content width to match the new tile width. Old content width: https://drive.google.com/open?id=1SbbJAa40gmfRG0tYT9UcR2q4Wy7cPBfq New content width: https://drive.google.com/open?id=1Ac6KlDH8-95YDdwbvpQ4PJtKSGI4TSXe Change-Id: I00d6113f48e7230a852ce0e1072f682615992ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642374Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#666524}
-
François Degros authored
Bug: 778674 Change-Id: I9b59fc0838db3998a17183e915c3c4f5264364d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644932 Auto-Submit: François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#666523}
-
Aga Wronska authored
Making base class for ShelfView abstract simplifies a inheritance logic and allows to move some more code to derived classes. Bug: 948953 Change-Id: I3ebeffd91f856e7d4c3bda76a9df2a3994745ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642134 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#666522}
-
François Degros authored
Bug: 778674 Change-Id: Id0050985b19a05a2a73a87f429468f93f5ba70b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645112 Auto-Submit: François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#666521}
-
Brandon Goddard authored
For users who don't use screen readers, the icon in the data grid communicates information about the type of document in the data grid. However, this icon lacked the document type information. This change adds the name of the type to the icon so it can be read via a screen reader. Bug: 963183 Change-Id: I6b3e717b270467327856c502e6ba47329386b31a https: //imgur.com/F0HyQ1L https: //imgur.com/xo1kz07 Change-Id: I6b3e717b270467327856c502e6ba47329386b31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644380Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#666520}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9b38f4ebe59f..900e4713287f Created with: gclient setdep -r src-internal@900e4713287f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:803846,chromium:957284,chromium:803846,chromium:803846 TBR=xidachen@google.com,gayane@google.com,calamity@google.com,kinuko@google.com Change-Id: If813b4c46aa545ffe3d94349176ae15b1247e38c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647013Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666519}
-
May Lippert authored
If the "Surprise Me" feature has never been activated, the 'sync-daily-refresh-info-key' value from Chrome sync will be empty. This causes a JSON.parse exception which then causes an early return from the chrome.storage.onChanged listener. BUG=687722 Change-Id: I6837faee9d8b5738425e1d760badd9abf4e27f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633025Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Commit-Queue: May Lippert <maybelle@chromium.org> Auto-Submit: May Lippert <maybelle@chromium.org> Cr-Commit-Position: refs/heads/master@{#666518}
-
Eric Aleshire authored
These two ChromeEarlGrey shared helpers are only used in these tests, so they can be moved to be private helpers. Bug: 922813 Change-Id: I5e4e70837aa8a8b24d78e4307793594cc03c80be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646133 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#666517}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e0d90c84e42f..6b43c30cd702 git log e0d90c84e42f..6b43c30cd702 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 mtklein@google.com add mad_unorm8 instruction 2019-06-05 mtklein@google.com use u32 in mul_unorm8 2019-06-05 mtklein@google.com tidy up register allocation Created with: gclient setdep -r src/third_party/skia@6b43c30cd702 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Change-Id: Ieb1d0f381d488539549978a12e36fb9012d3c083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646895Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666516}
-
Xianzhu Wang authored
We are already using physical coordinates for frame and document geometries. This CL just changes the type of the geometry data. This includes - removal of LayoutRect/LayoutPoint version of frame coordinate mapping functions, - change callsites of frame coordinate mapping functions to use physical coordinate types, - change of type of ScrollIntoView parameter and return values. R=bokan@chromium.org,skobes@chromium.org TBR=aboxhall@chromium.org for simple passive change under renderer/modules/accessibility TBR=fserb@chromium.org for simple passive change under renderer/modules/canvas Bug: 969383 Change-Id: Id6e70c672cc1a6402cf2baff55e62ffd076d3736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639527 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#666515}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8d38d709..c843aa75 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia2b1b707b2e06646b339a8a7ef90665f665284d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646913Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666514}
-
Luum Habtemariam authored
DDoc: go/cups-plugin This socket manager handles the actual proxying of the IPP requests to the CUPS daemon, via the default named UNIX domain socket, /run/cups/cups.sock. Bug: chromium:945409 Test: Passes added unittests. Change-Id: I3ed529bf0dc55f8aa1ee9eadbc0accf236f47000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600132Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#666513}
-
Alex Danilo authored
CL:154436 added a flag to control the feedback panel for FilesApp. This CL removes 'new' from the description and code comments as that was flagged in the original CL after merge. Bug: 947388 Change-Id: Iec61c601acfb56d8baf5fb2405958cfbd3f2bd1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644712Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#666512}
-
Mei Liang authored
Change-Id: I7b9f5952f1cf16a2bc60699f8862ffe859f59837 Bug: 970267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643107 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#666511}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/affd410d415a..ee7921db7153 git log affd410d415a..ee7921db7153 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-06-05 ehmaldonado@chromium.org Reland "gclient: Require a target ref when applying patches." Created with: gclient setdep -r src/third_party/depot_tools@ee7921db7153 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:956807 TBR=agable@chromium.org Change-Id: I026c89dbe960a4d55a5593737e086452ce3ec798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646559Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666510}
-
Darin Fisher authored
This meant exposing a service BackgroundTracingAgent from child processes that the browser processs can use to configure the reporting of background tracing back to the browser via BackgroundTracingAgentClient. As part of this change, background tracing is disabled for pepper plugins (nacl and flash) as these are deprecated technologies, and we are not deriving much benefit from background tracing of these processes. Change-Id: Id940dbf4646c315c01f1ca311b66b721a6648706 Bug: 967834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621067Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#666509}
-
Lucas Tenório authored
In this change we are simply listening for the ARC app instance connection status and reporting it back to Kiosk Next Home. This is similar to a different approach we tried in the past: https://chromium-review.googlesource.com/c/chromium/src/+/1570287 But in this change we are not making major changes to the GetAndroidId method implementation. Bug: 959326 Change-Id: I0827ac588a4eb62b4b9b5dc9902a5e75a8b22db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643928Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Cr-Commit-Position: refs/heads/master@{#666508}
-
Sharon Yang authored
logging::LogMessage has a special-case to write LOG_ERROR messages to stderr, even if LOG_TO_STDERR is not enabled, to make ERROR and FATAL messages more visible, especially in tests. Restrict this behaviour to apply only if LOG_TO_FILE is set, so that binaries which only LOG_TO_SYSTEM_DEBUG_LOG will never emit logspam to stderr. Tested by adding a unit test for this case. Bug: 968387 Change-Id: Icfe094e7d7bf9697a70a589eab48edbe79c36091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638782 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#666507}
-
Xianzhu Wang authored
Use physical coordinates in HitTestLocation, HitTestResult, and let hit test functions use and produce physical coordinates. This doesn't change PositionForPoint. This CL temporarily flips the hit test result for PositionForPoint in legacy layout to meet the current requirements. Change-Id: I8675745483926116990ffa9fbd17b97ef9c8a392 Bug: 969383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626656 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#666506}
-
Akihiro Ota authored
This reverts commit 718c6717. Reason for revert: Causing some full-screen videos to vibrate constantly in WebView. This is likely because the event for slider value changes was changed from a Scrolled event to a Selected event. Original change's description: > Android: Fix talkback silence when changing slider value > > Previously, Talkback would not report the new value of a slider > when adjusted; in order to hear Talkback report the new value, user > had to un-focus and re-focus the slider. Changed the AccessibilityEvent > that is fired when detecting a slider value-change from > TYPE_VIEW_SCROLLED to TYPE_VIEW_SELECTED, which triggers Talkback to > report value of the focused item. This mimics Talkback behavior > of native Android sliders. > > Bug: 836554 > Change-Id: I4bb3bfafdb4d077f80e1ba4f3c9eecf8a7536497 > Reviewed-on: https://chromium-review.googlesource.com/c/1308978 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604021} TBR=dmazzoni@chromium.org,akihiroota@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 836554 Change-Id: I0c64141654c084318cf0a45e8d551fdadd746cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643235Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#666505}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/01927c1c5000..b933eedeb03d git log 01927c1c5000..b933eedeb03d --date=short --no-merges --format='%ad %ae %s' 2019-06-05 cjmcdonald@chromium.org chromeos_config: Add APAC reviewers to config OWNERS Created with: gclient setdep -r src/third_party/chromite@b933eedeb03d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ib2b86059dc80efaf951963f8ccd0276fc30c16a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646894Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666504}
-
Kinuko Yasuda authored
It looks it's only used by the browser-side code now. Bug: N/A Change-Id: Id045ce703c71e38a381d246e24eeb6e4a0ae3e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644953 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#666503}
-
Olivier Yiptong authored
These features are no longer part of the spec. This code removes their implementation. Bug: 968552 Change-Id: I089254cac5ebc52a989194c69236497d347260d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643892 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#666502}
-
Nick Diego Yamane authored
Remove unused header includes in settings_provider{_gtk}.h No behavioral changes. Change-Id: I0d43f3c7240ef00d03accd015ee7518b2428c67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646074 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#666501}
-
Collin Baker authored
This implements basic session restore functionality for tab groups. Currently, only whole browser session restore is supported; restoring a window or a tab from the history menu won't restore groups. Bug: 905491 Change-Id: Ib6ad643c7efd75f468bb518fa5881b17a3d9f05f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627947Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#666500}
-
Caroline Rising authored
This change considers 'scrubbed' to mean a tab that is activated for <= 1.5 seconds before the user navigates away. We are making the assumption that when a tab is 'scrubbed' it is likely that the user did not navigate to that tab to use it. The goal is to see this metric go down with use of the tab hover cards feature. This would show that tab hover cards help users find the tab they are looking for without having to activate as many tabs as they would have without the feature. Bug: 910739 Change-Id: Ia00b0e5ec4ce0969bd8807ac1564fceed0682651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636346 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#666499}
-