- 07 Dec, 2020 40 commits
-
-
Tom Anderson authored
* Now that every request is made by XProto, x11::Connection::Request::sequence is no longer needed. Now sequences can be determined by (their index in the queue) + x11::Connection::first_request_id_. * This makes it easier to work with requests out-of-order, which will be necessary for creating property/window caches in the future. * Move some xcb calls from xproto_types.cc into connection.cc. I want to dlopen() libxcb in the future to make it possible to run Chrome on systems without any X11 libraries, so having everything consolidated will make that easier. * Add Future::Wait(). Similar to Sync(), this blocks until a response is received, but instead of returning the response, it calls the installed response handler out-of-order. R=sky Bug: 739898 Change-Id: I10c4c18d3c3090ba09d660a5090fd7c0f01830f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565440 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#834386}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/48b2aad780bf..3efbe10ffd42 2020-12-07 marcinoc@google.com Merge "Fix SQL query to compute frames in SysUI CUJs" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie71cbd65782c1121d4af4dd2c75bc83178ae0e88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577796Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834385}
-
Ionel Popescu authored
Bug: 1148986 Change-Id: I816c94a2e12044fad3d8cef762848420f9652488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565393 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#834384}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1607331580-9909f67f911bba407df7ff9d177d8d5f0f5ef14c.profdata to chrome-win32-master-1607353071-d7cc2aeaf74b32bdf69634e0f6483d7e4b0ffed2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I45e40bb2a53eb9ac7f0ddb0f37640a52eb708e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576623Reviewed-by:
-
Aaron Leventhal authored
Don't walk ancestor chain to check if aria-hidden, unless the cached flag is_inert_or_aria_hidden is already set. Bug: None Change-Id: Idbef78dd4f4735d506b7263564056c9ba48560dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551693 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#834382}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7da2cc8b..5a377bcb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I32abc3a436ec3cac8fa0b583ae1a6a8614a617d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576429Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834381}
-
Jun Mukai authored
Fixed: 1142489 Test: none Change-Id: Ia768ab9f25380744f7050c643e5df9dfe9db9cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576940Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#834380}
-
Jeffrey Kardatzke authored
This was checking <= 31 for a bit shift, and it should be <= 30 since we are shifting 1 that many bits and it's a signed integer. BUG=chromium:1155846 TEST=Fuzzer passes Change-Id: Id70dbe809ba4b63ae91217c67e46d2bfc29f092a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575812 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#834379}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607341806-af6783e2515ff922f8cbb2f88290f0ca953ce5b4.profdata to chrome-win64-master-1607353071-6048a593794456949e3ffd6a87397fecfdc4317e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0781abdde68b2915bc06610623707543d9d18014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577603Reviewed-by:
-
dpapad authored
Bug: 1148478,1155076 Change-Id: I45421d6e0673d4d56b783f843bb12470c7a47202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570992Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#834377}
-
Javier Fernández García-Boente authored
The following tests are now passing thanks to the fix for the issue https://crbug.com/779105. alignment/grid-self-alignment-non-static-positioned-items-009.html alignment/grid-self-alignment-non-static-positioned-items-010.html alignment/grid-self-alignment-non-static-positioned-items-012.html These tests are still failing in Legacy layout, though, since the above mentioned fix affected only LayoutNG. There are still some failures for one of the tests, but they seem unrelated to the root cause described in the issue 779105. Hence, this test still has some failing expected results: alignment/grid-self-alignment-non-static-positioned-items-011.html I've filed issue 1156225 as root cause of these failures: Bug: 1152497 Change-Id: I2ffa920951fb340418939dae53d2a3b12a9d14c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577222Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#834376}
-
Alex Turner authored
This will expand the number of IdentifiableSurfaces trivially constructible from the FontIndexer's output, namely digests with type kLocalFontLoadPostScriptName and kLocalFontExistenceByUniqueNameOnly. Bug: 1155635 Change-Id: I6b602c808f1c22ed3e14d87e91dfdc5d7c77aae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575004 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#834375}
-
Lan Wei authored
Use testdriver Action API to simulate mouse actions in css/selectors/focus-visible-002.html. Bug: 1145677 Change-Id: Iff8d1700db152b97ab3af61a8f3e75d4ca6053bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548723Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#834374}
-
Elly Fong-Jones authored
This reverts commit 28c5ad9b. Reason for revert: suspect culprit for PrecisionSamplerShadersCompile/PrecisionSamplerShaderPixelTest.ShadersCompile/* failures on linux-tests-dbg: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/93470 Original change's description: > Switch cc_unittests/viz_unittests to SwANGLE > > This cl changes the software backend used for > running viz_unittests and cc_unittests from > SwiftShader GL to SwANGLE (ANGLE on SwiftShader > Vulkan). Other tests suites may be affected. > > From this cl, performance expectations for test > runs will likely change. For example, cc_unittests > appears to run faster, while viz_unittests and > views_unittests appear to run slower. Note that > this is still using the validating command decoder, > and once the OOP Raster tests can run on the > passthrough command decoder, we'll be able to use > it and gain some performance on all these test runs. > > Bug: chromium:1060139 > Change-Id: Ia243f05f3e9f54dc6f6dfaa3041021fc28818b2f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532042 > Commit-Queue: Alexis Hétu <sugoi@chromium.org> > Reviewed-by: weiliangc <weiliangc@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> > Cr-Commit-Position: refs/heads/master@{#834246} TBR=sugoi@chromium.org,kbr@chromium.org,weiliangc@chromium.org,khushalsagar@chromium.org,jonahr@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,sugoi@google.com Change-Id: I815d610741c258a66dc360b2d302d2f663a3bf4c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1060139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577957Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#834373}
-
adoneria authored
Use Mac-11.0 only. Remove Mac-10.16 swarming dimension which does not exist anymore. Bug: 1156252 Change-Id: Ie8e146cfa6f7e3d6e78756d34e1d661e7b1c8564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577759Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#834372}
-
Jae Hoon Kim authored
Bug is fixed and stale logging + TODO lingering. BUG=chromium:851151 Change-Id: I9366d12c40a37fb55fa0c099c1dbf89c3dfb740e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575878Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Cr-Commit-Position: refs/heads/master@{#834371}
-
Adam Langley authored
https://github.com/w3c/webauthn/pull/1530 specifies a method for encoding language and direction information in strings that will be stored on authenticators. Since we may start to see this in credentials in the wild, this change adds examples to the UI test so that we see what they'll look like. (On Linux, at least, they at least don't render as garbage or crash. However the zh-Hant example doesn't display, possibly because I'm missing suitable fonts.) Change-Id: I9e778a08df85b8ae34032341c6bcd84291ff210c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576795 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#834370}
-
Ben Pastene authored
Many of these were disabled during failures while the tests were fixed. And after fixing, they were never re-enabled. So this aggressively re-enables any that are now passing. Bug: 1097630 Bug: 1051059 Bug: 1062289 Bug: 1056163 Bug: 1059426 Bug: 1073084 Bug: 1114654 Bug: 1098810 Bug: 1114752 Bug: 1131304 Bug: 11484015 Change-Id: If3270bdfc4f4516af762ae1d92b3215e4b3cffa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570538 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#834369}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607341806-34092e6e948e6283aae1770f567faca0b14a9512.profdata to chrome-linux-master-1607363880-fd3f1baf2a5dc6b74a86d40eb9ec18d09a3815d8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie02b3d373fcf71ed8e53d217a2c2a5602ba83005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575773Reviewed-by:
-
Moe Ahmadi authored
A previous CL with the same title added trial testing config for Desktop only. This CL adds the same config for Android. Prestable experiment: http://shortn/_ZyDTi78UyT Bug: 1096615 Change-Id: I2fb5b8752b814d70e1ad549f95381e3c9aa17947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575041Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#834367}
-
Moe Ahmadi authored
This reverts commit 3bfb8a37. Reason for revert: crbug.com/1156059 Fixed: 1156059 Original change's description: > [realbox] Makes all text in realbox impossible to select > > crrev.com/c/2566505 made all text in realbox dropdown unselectable. > > This CL extends that to the realbox placeholder as well. Note that > non-placeholder text in the realbox input remains selectable after > this change. > > Fixed: 1154576 > Change-Id: I80d13521680a165c56e2a7d98eff82c885ff3da4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572680 > Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833512} TBR=mahmadi@chromium.org,tiborg@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ic569859f08ba8ee7bc0d82cd4671088f3f4348d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577600Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#834366}
-
Morten Stenshorne authored
We *should* indeed consider moving the code for handling hits outside of atomic inlines, but NGPhysicalBoxFragment::PositionForPoint() isn't the right place for it. If we have an inline-block with a child text node that overflows it, and we hit such overflowing text, we'll perform NGPhysicalBoxFragment::PositionForPoint() directly on the inline block (from HitTestResult::GetPosition()), even if it's the text that we hit. We cannot require that we are within the border box of the inline-block in such cases. This check needs to be performed before entering non-atomic inline children - probably in NGInlineCursor::PositionForPointInChild(). At some point, that code should stop calling LayoutObject::PositionForPoint(), and rather call NGPhysicalBoxFragment::PositionForPoint(). That would be a good time to clean up this. Bug: 1155948 Change-Id: I0391f87d4bbf97c7cdd6a15ab2648aefa2d2abbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577199Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#834365}
-
Chris Thompson authored
The new Sogou hostname supports HTTPS without certificate errors. Bug: 869667 Change-Id: I6e8d9e8149bb995be4d91aae12eeda6dfb4d6ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570118Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#834364}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I57985e0d4c6c14f46583b8d882cf232874a52e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575600Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by:
-
Reid Kleckner authored
The compile step currently takes around 10 hours. We get more value from this bot cycling more quickly than we get from the extra coverage of building all targets. Make this bot build the chromium_builder_asan target instead of `all` to match the Windows ASan bots and the main Mac ASan bot. R=aeubanks@google.com, hans@chromium.org Bug: 1151435 Change-Id: I1b954427126e36f5f83826b259d785bd84c8ff86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555699Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#834362}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c56ea91f6bd1..e1502e7972cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I353eab6f3e9169af9b6e8a678230ff3c4b8184f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577604Reviewed-by:
-
Alison Maher authored
It was decided that the containing block chain goes directly from a column spanner to the multi-column container. Thus, if an absolute positioned element is nested inside a spanner, we should begin looking for its containing block starting with the multi-column container, as well. This is an update to the previous legacy behavior, and the related web test has been updated to reflect the new behavior. Bug: 1079031 Change-Id: Ia9f60107417158c32d78e12a1d414181411ecb0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568852 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#834360}
-
Norman Rosas authored
and removed duplicated metadata from OWNERS files Bug: 1113033 Change-Id: I51e9d4560200bfe305c4bdbfd6ecdf9c1c78f802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573676Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#834359}
-
Robbie McElrath authored
This CL renames most of WebLayer's Site Settings files to just Settings in preparation of introducing more Settings UIs. This introduces a new ISettingsFragment rather than renaming ISiteSettingsFragment because renaming the interface results in a "SecurityException: Binder invocation to an incorrect interface" exception when launching Site Settings. Bug: 1106393 Change-Id: Ifbeb15a8ff51776a901e0136dfbdcb4b19543a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572689 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
Reilly Grant authored
The manual data transfer tests are known to work on all platforms while the tests which generate error conditions do not. Break these up in order to simplify regression testing. Bug: 884928 Change-Id: I8b8e5559fe7babf21395b3c836ff8ff0f60be8b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576080 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#834357}
-
Ben Pastene authored
crrev.com/i/3452789 allocates the machines for this. Bug: 1146481 Change-Id: I0c271016eae64d0e99f205b31efe635cf707cd4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576949Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#834356}
-
Jan Wilken Dörrie authored
This change prepares //mojo and //ipc for the upcoming switch of base::string16 to std::u16string by replacing current Windows only usages of base::string16 with std::wstring. Furthermore, it adds a std::wstring specialization of IPC::ParamTraits. Bug: 911896 Change-Id: If09078ba43a381f7210f89bba04a729024812d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572842Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#834355}
-
Azeem Arshad authored
This fixes issue with eSIM networks incorrectly appearing in pSIM group. This was caused because the eid property was not being checked properly. Bug: 1093185 Change-Id: I9c3f2f72810e186dd35f47dedff61bf7efd2c06b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575149Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#834354}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I1924d3f068ef89f8c5b48a5e628083c020056700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575766Reviewed-by:
-
Tibor Goldschwendt authored
This is a reland of 0b7367ff with a fix for msan builders, which failed on the original change. See https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/26482/steps?succeeded=false&debug=false Original change's info: > Change-Id: I735506c3e0efff1f92582498400bea0a914cf215 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566374 > Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Reviewed-by: Caitlin Fischer <caitlinfischer@google.com> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833561} TBR=caitlinfischer@chromium.org,mahmadi@chromium.org Bug: 1110075 Change-Id: Ic311a03eb09860d0cc8b40c55f93bb97caa095bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576788Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#834352}
-
Ken Rockot authored
Bug: 1004256 Change-Id: I5e835e779fcd6e6096886d7bf38869ae19e25bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569384Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#834351}
-
manukh authored
This does not enable the drive feature by default as it's currently limited to enterprise users. Sets: - DocumentUseClientScore to true - DocumentProviderMaxQueryLength to 200 - DebounceDocumentProviderDelayMs to 300 Change-Id: Idf85fcf6b25a844b196fa5ae82d5ac7617e6dad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575378 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#834350}
-
Shawn Gallea authored
This removes the burden of parsing from the client. Bug: b/169054926 Test: On device Change-Id: If02b37169aca921429658305284e94738350a822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574999Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Shawn Gallea <sagallea@google.com> Cr-Commit-Position: refs/heads/master@{#834349}
-
Shrek Shao authored
Reland "Fix readPixels incorrectly allowing RGBA / UNSIGNED_SHORT without EXT_texture_norm16 support" This is a reland of 80b096ab The culprit was identified in Issue 1154356. Original change's description: > Fix readPixels incorrectly allowing RGBA / UNSIGNED_SHORT without EXT_texture_norm16 support > > Add readPixels validation for RGBA / UNSIGNED_SHORT combination. This is > only valid with EXT_texture_norm16 extension enabled. > > Bug: 1152259 > Change-Id: I0e10b7d29f3b362c4054500270bbad87dcde599f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559797 > Commit-Queue: Shrek Shao <shrekshao@google.com> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832141} Bug: 1152259, 1154356 Change-Id: Ie9ceed14e705380e9d1d07f008f4ec86ea7b7421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575048Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#834348}
-
Sebastien Lalancette authored
- Increased LinkGeneration timeout from 200ms to 500ms, - Added a new kTimeout LinkGenerationError enum value, - Added LinkGeneration latency UMA logging. - Lots of plumbing of the latency value to allow logging from the same scenario-aware location. - Added a way to force timing out JavaScript execution requests in the FakeFrame class. Bug: 1155329 Change-Id: I396457db946a756c799a4fddb0d7185c3e12b30b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577002Reviewed-by:Tommy Martino <tmartino@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#834347}
-
