GitLab

The Bluetooth FeaturePod button can be disabled in certain cases (e.g. when the
screen is locked) so the current "Toggle Bluetooth" and "Show Bluetooth
settings" tooltips are not appropriate.

BUG=987933

Change-Id: I2d534f3e99525847a1e4164e510996bd90b0a096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729565Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683303}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=rbpotter@chromium.org

Bug: 968047
Change-Id: I105e2965f7d21583f68174683a8e76823f7f3065
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729077
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683302}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=rbpotter@chromium.org

Bug: 968047
Change-Id: I1849e7c28ee90650814e7a7f8e53b0075511da63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729081
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683301}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0aee86d1e39c..7e33a7e91b89


Created with:
  gclient setdep -r src-internal@7e33a7e91b89

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None,chromium:None,chromium:None
Change-Id: I8f744285e3b52ba28be55bb5230f860b9c945096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731752Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683300}

Fix an issue that auto Download resumption is not in reduced mode if native resumption handler is enabled

We need to check the job type to see which feature flag is used.

BUG=990052

Change-Id: I3c2ee43f923eca3249e2ce293bf9818978321713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730852
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683299}

We sometimes change the actual delay after which a periodicsync event is fired
based on other registrations for the origin. Update what we show in Devtools so
it corresponds to the actual delay_until set on the registration.

Bug: 989524
Change-Id: I9ba06f9c5f65d93775b0a9bf9d934f1d9b5b5ce6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730921Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683298}

http/tests/fetch/serviceworker-proxied/thorough/cookie-base-https-other-https.html
http/tests/fetch/serviceworker-proxied/thorough/nocors-base-https-other-https.html
http/tests/fetch/serviceworker-proxied/thorough/redirect-loop-base-https-other-https.html
http/tests/fetch/serviceworker/thorough/cookie-nocors-base-https-other-https.html
http/tests/fetch/serviceworker/thorough/nocors-base-https-other-https.html
http/tests/fetch/serviceworker/thorough/redirect-credentials-base-https-other-https.html
http/tests/fetch/serviceworker/thorough/redirect-loop-base-https-other-https.html
http/tests/fetch/serviceworker/thorough/scheme-blob-base-https-other-https.html
virtual/blink-cors/http/tests/fetch/serviceworker-proxied/thorough/nocors-base-https-other-https.html
virtual/blink-cors/http/tests/fetch/serviceworker/thorough/redirect-credentials-base-https-other-https.html
virtual/blink-cors/http/tests/fetch/serviceworker/thorough/scheme-blob-base-https-other-https.html
virtual/streaming-preload/http/tests/fetch/serviceworker-proxied/thorough/auth-base-https-other-https.html
virtual/streaming-preload/http/tests/fetch/serviceworker-proxied/thorough/nocors-base-https-other-https.html
virtual/streaming-preload/http/tests/fetch/serviceworker-proxied/thorough/redirect-loop-base-https-other-https.html
virtual/streaming-preload/http/tests/fetch/serviceworker/thorough/access-control-base-https-other-https.html
virtual/streaming-preload/http/tests/fetch/serviceworker/thorough/cookie-nocors-base-https-other-https.html
virtual/streaming-preload/http/tests/fetch/serviceworker/thorough/cors-preflight2-base-https-other-https.html [ Pass Failure ]
virtual/streaming-preload/http/tests/fetch/serviceworker/thorough/nocors-base-https-other-https.html [ Pass Failure ]
virtual/streaming-preload/http/tests/fetch/serviceworker/thorough/redirect-credentials-base-https-other-https.html [ Pass Failure ]
virtual/streaming-preload/http/tests/fetch/serviceworker/thorough/redirect-loop-base-https-other-https.html [ Pass Failure ]

Bug: 989863
Change-Id: Ie63e6a41555e5c8fa956f583df787df5159e241f
TBR: skym@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731134Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683297}

Currently PDFiumEngine::LoadPageInfo() loads pages into PDFiumEngine
only in a single-view layout. However, in the future LoadPageInfo() will
be able to load pages in a two-up view layout as well.

This CL extracts the logic for formatting pages in single-view and
appending them to |pages_| to a helper function
PDFiumEngine::LoadPagesInSingleView(). This helps manage the complexity
of LoadPageInfo().

Bug: 51472
Change-Id: I087f171308e4425dd3bae8b8abe5f0f70e0c0eed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728059Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Jeremy Chinsen <chinsenj@google.com>
Cr-Commit-Position: refs/heads/master@{#683296}

Create a class that listens to PowerManagerClient for changes in the
battery level of Bluetooth HID devices, and update the corresponding
device::BluetoothDevice battery percentage field.

Design doc at go/cros-bt-battery.

Bug: 785758
Change-Id: I3519d6d19c7a24abafc353d4afd3d059034e808b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721087
Commit-Queue: Alberto Herrera <ahrfgb@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683295}

Assign a unique ID to the notification when a new device gets paired to
the computer. The new ID uses a prefix and the device's address to be
unique. This allows to show a notification for each paired device.

Bug: 965685
Change-Id: I52ff160b76470edb86ad45368b52054c2c4061bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729843Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Alberto Herrera <ahrfgb@google.com>
Cr-Commit-Position: refs/heads/master@{#683294}

This CL adds two new ways to specify edge case behavior for FlexLayout
that will make some use cases much easier.

1. SetTargetArea(LayoutTargetArea) - specifies whether the host view's
insets are treated as inviolable (default and older behavior) or whether
they're considered part of the internal margins of the host view for
layout purposes. The new (optional) behavior allows certain cases where
a child view with internal padding cannot currently get close enough to
a host view border, inkdrop, or focus ring.

2. Set[Main|Cross]AxisMarginsPolicy(LayoutMarginPolicy) - specifies
whether child margins apply when they abut the edge of the host view.
The new (optional) behavior allows much simpler code when spacing between
views needs to be different than spacing at the edges of the host view.

OPEN QUESTIONS:
 - Should we just make the new behavior for (1) the default?

Bug: 898632
Change-Id: I5d336ed19b32a791f944f8ced615a099a0729802
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676736
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683293}

We were dismissing the launcher when logging in via tablet mode.

Check for tablet mode before dismissing.

Bug: 988378
Change-Id: Ie956dabd899be4dc849e2eed845a02dbd4d0e7b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730765Reviewed-by: Matthew Mourgos <mmourgos@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683292}

The PdfIsolation feature was enabled by default in March 2019
and has stuck.

Bug: 988616
Change-Id: I1a17c9ddcec6c9fbf29c435354a6091aa333ed63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725389Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683291}

The SurfaceSynchronization feature is enabled on all platforms and we
don't support disabling it. Remove the base::Feature and make
IsSurfaceSynchronizationEnabled() always return true so we can start
deleting code.

This CL also removing some now dead code for the plumbing of
OnFirstSurfaceActivation() to OOPIFs, offscreen canvas, etc.

Bug: 985009
Change-Id: I1a1c9228beca2cc1d36ce637d79b982287a31389
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729836Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683290}

This CL implements windows.create for SW based extensions.
For SW based extensions:
  - Calling windows.create with {setSelfAsOpener: true} from a
    worker script will return an error.
  - Calling windows.create from an extension frame, setSelfAsOpener
    should continue to work. This CL doesn't add test for this.

This CL expands ExtensionApiTest.TabCurrentWindow test to
extension Service Workers, that exercises chrome.windows.create API.

Bug: 984350
Test: SW extensions can use chrome.windows.create.
Change-Id: Id74feed7e6f56da1833751c4f4abbeb2cca58cd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703187
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683289}

https://android.googlesource.com/platform/external/perfetto.git/+log/d7729a4533da..bf0e385cd6fb

git log d7729a4533da..bf0e385cd6fb --date=short --no-merges --format='%ad %ae %s'
2019-08-01 treehugger-gerrit@google.com Merge "perfetto_cmd: do not start incident reports for empty traces"

Created with:
  gclient setdep -r src/third_party/perfetto@bf0e385cd6fb

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I6b7ef01ab4df922707bcfa202366c2b92fdf49d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730597Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683288}

Remove code that is not used anymore with the network service enabled.

BUG=989104

Change-Id: I908bf3518a53a3d03bf587c1058f9c21eb7b2663
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727111
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683287}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Icfef59cfa39b0a5c56a6344bcd90c75429353b10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731101Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683286}

This merges all of the functionality that was in the anonymizer in
debugd into the one that is in Chrome. The plan is to remove the one in
debugd because anything run through that anonymizer is also getting run
through the one in Chrome.

Specifically, this changes:
1. Add anonymization of Android storage paths
2. Add preservation of anonymous MACs
3. Change formatting of anonymized MACs

Bug: 921388
Test: Unit tests pass
Change-Id: I1882ac2cbc10a0911257d04188f225ebca52db82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726672
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683285}

Using IsFirstSetupComplete() to determine whether sync metadata should
be cleared does not work well for transport-only mode, where sync the
feature itself is not enabled and hence IsFirstSetupComplete() actually
never becomes true.

Therefore, prior to this patch, sync metadata (including the cache GUID)
were cleared on every browser restart, if in transport mode.

Instead, we leverage sync disable reasons to determine whether metadata
should be cleared.

Bug: 955989
Change-Id: I63d2b1e682193cd981c7cef72581a4c6e4057e49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715822
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683284}

During Autofill captured sites tests, when there is a new popup,
it appears the RenderFrameHost is not always owned by the current WebContents.
This may be a further issue with the way current_main_rfh_ but this change
just ensures that the pointer exists before attempting to retrieve
it's autofill_manager instance.

This fixes 2 existing Autofill captured sites tests.

Bug: 988532
Change-Id: I0b60679843900c8313fc18f71e00cd64faf78528
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724494
Commit-Queue: Ian Struiksma <ianstruiksma@google.com>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683283}

To try out this code with the Microsoft OpenXR Runtime in Chromium, perform the
following steps.
    - Install 'Mixed Reality OpenXR Developer Preview' from the Microsoft Store
    - If prompted also download the compatibility pack

Add the following to custom_vars in .gclient, located at the root of the
chromium clone:
    "checkout_openxr": True
Add the following to args.gn, located in the out folder:
    enable_openxr = true

gclient sync and build

Once you've built and installed Chromium go to about:flags and:
    - Enable WebVR or WebXR
    - Enable 'OpenXR Support'

Bug: 976432
Change-Id: Ie4aa927afc7389c0a88e818889bfbcee75e4feea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693842Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Zheng Qin <zheqi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#683282}

Add support for injecting resident credentials via the DevTools API. This was
missed in the original implementation. Resident Credentials need to store the
Relying Party ID and User Handle, so these two parameters are added. The
Relying Party ID hash is made redundant and therefore removed.

This is one in a series of patches intended to create a Testing API for
WebAuthn, for use in Web Platform Tests and by external webauthn tests.

For an overview of overall design, please see
https://docs.google.com/document/d/1bp2cMgjm2HSpvL9-WsJoIQMsBi1oKGQY6CvWD-9WmIQ/edit?usp=sharing

Bug: 922572
Change-Id: Ifee5edb0150593238e425fc3b2963ed04dda1609
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728423
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683281}

As is, a few variables are sometimes in one coordinate space and
sometimes in another. Tweak the code so these variables always hold
values in screen coordinates, and add "_in_screen" to their names.

Change-Id: Idf84a449be85ef26de6b960b1e3796b99946f0b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725260Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683280}

This CL renames *_struct_traits.* to *_mojom_traits.* in //chrome

*_struct_traits.* => *_mojom_traits.*

Bug: 806965
Change-Id: I99494c2ac8160149abd126b36995551df9585b27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730152Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#683279}

The test has no control over production code changing preferences and
these changes being sync-ed too. Hence, let's relax the requirements and
verify that at least one UMA metric is emitted.

TBR=treib@chromium.org

Bug: 988404
Change-Id: Iaeb1907935ef040ab81967c4061075198e7b6d31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731490Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683278}

https://dawn.googlesource.com/dawn.git/+log/351ea23830db..56f3a7b90d37

git log 351ea23830db..56f3a7b90d37 --date=short --no-merges --format='%ad %ae %s'
2019-08-01 cwallez@chromium.org WrapIOSurface: Add support for RGBA8

Created with:
  gclient setdep -r src/third_party/dawn@56f3a7b90d37

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Bug: None
Change-Id: I55a2220c36be040ed4123e43abd484a853642c8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731435Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683277}

This will be used for litepages in a follow up CL.

Bug: 971918
Change-Id: I7faf3f8e0bc51fa1fff8235226f5832876c7492a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730767Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683276}

Forwarding only the discrete events (rather than all events) should
avoid the performance issues produced by crrev.com/676446.

Bug: 914500
Change-Id: Ic2ac27e35012e8faa7d447857c33054b0c6b4fab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715230Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Auto-Submit: Tom McKee <tommckee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683275}

This patch ensures that we don't dispose plugins that are scheduled for
disposal during CreateAndAttachShadowRoot (which can happen via a call
to RemovedFromFlatTree). Since this function is acting in the script-
forbidden state, and plugins can run script on disposal (see referenced
bug), it causes a CHECK in certain cases. The fix here is to hoist
the disposal up to post forbidden scope state in CreateAndAttachShadowRoot
by suspending the disposal prior to suspending script.

This is consistent with things like UpdateStyleAndLayoutTree,
UpdateStyle, and Document::Shutdown, all of which suspend plugin
disposal prior to forbidding script.

R=masonfreed@chromium.org

Bug: 988318
Change-Id: Ib6363ce48eeb49f64691a519b8b542e805aa6527
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728714Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683274}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=bbudge@chromium.org

Bug: 968047
Change-Id: Ifb12f9278a02a0a821a6b92cb6625cf6e57d8b31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728885
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683273}

This is a reland of b58c0181

The original CL used an unset class variable rather than the callback
being passed into the function.

The reland solves this by using the correct function variable and adds
better unittesting to confirm the correct behavior.

Original change's description:
> [Previews] Add offline check before HintsFetch.
>
> Only attempt to fetch hints if the network is available.
>
> Note: The Optimization Guide does not support iOS but is in components
> due to supporting Previews. A future refactor of Previews may allow for
>  moving Optimization Guide to the browser layer. An assertion was added
> to the BUILD.gn file to make the iOS decision more clear.
>
> Bug: 986817
> Change-Id: Iafa4101b42147530e0b38f2d6a4eb36a7ddac37c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715505
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: Robert Ogden <robertogden@chromium.org>
> Commit-Queue: Michael Crouse <mcrouse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#681180}

TBR=webrtc-chromium-sheriffs-robots@google.com,kinuko@google.com

Bug: 986817
Change-Id: I4a2e51c8eb7b498b3d9cb542da265e5ebc15431f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729053
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683272}

Using wpt-import in Chromium 32f3c453.
With Chromium commits locally applied on WPT:
250461b3 "Worker: Register a service worker just once for worker subresource interception tests"
bf4ad57e "Experimental CookieStore API: some additional browser-side validation"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I5ba611e1e453b28de01ebacdeac04e4cda6b8053
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731589Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683271}

$ git log 14eba7add..81aef9014 --date=short --no-merges --format='%ad %ae %s'
2018-06-29 jonathan.wright Add Arm NEON implementation of h2v2_upsample
2018-06-28 jonathan.wright Add Arm NEON implementation of h2v1_upsample
2019-07-30 jonathan.wright Add list of Arm NEON patches to README

Created with:
  roll-dep src/third_party/libjpeg_turbo

Change-Id: I5e6f794de8690065e896f5219f41d90b499f66a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730055
Commit-Queue: Chris Blume <cblume@chromium.org>
Reviewed-by: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683270}

Bug: 901183
Change-Id: I14d43f32d571ff1a2fb23ce05c1d36e8ebd6541e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713042Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683269}

https://skia.googlesource.com/skia.git/+log/69e1462010af..80e7bd03d473

git log 69e1462010af..80e7bd03d473 --date=short --no-merges --format='%ad %ae %s'
2019-08-01 fmalita@chromium.org [skottie] Suppress placeholder range selector warnings
2019-08-01 robertphillips@google.com Disable LUM16F support for all Adreno devices

Created with:
  gclient setdep -r src/third_party/skia@80e7bd03d473

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=benjaminwagner@google.com

Bug: None
Change-Id: I51b149c70ea40ece085e08ff7ba5c6ad7264d3ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730575Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683268}

This CL renews this flag which was marked as expired for M77 in
https://crrev.com/c/1729449. Just a few days prior to that CL,
https://crrev.com/c/1721072 updated the expiry milestone for the flag in
flag-metadata.json, but it seems this change was not picked up at the
time of running tools/flags/list-flags.py.

Now, tools/flags/list-flags.py --expired-by 77 doesn't list this flag.

Test: None
Bug: 868400
Change-Id: I9ecc0bd52469b1c2fd1aeece11003f036e2b56df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731174
Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683267}

https://webrtc.googlesource.com/src.git/+log/bd3f30535c33..59a041db7e50

git log bd3f30535c33..59a041db7e50 --date=short --no-merges --format='%ad %ae %s'
2019-08-01 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4b9d9012..9c759119 (683063:683187)

Created with:
  gclient setdep -r src/third_party/webrtc@59a041db7e50

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: Ied83beffb3a546687c1b996d4cba1eed00237d29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730576Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683266}

Add CHECK's to STreamTextureFactory and StreamTextureHostAndroid to
debug - https://bugs.chromium.org/p/chromium/issues/detail?id=984309.

Bug: 984309
Change-Id: I6c63bb6ee0e595e06c1368babb06966bea0238c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729832Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683265}

Change-Id: Ideb0ee78b9be02c6acda3e1eddbae8dc9065fa15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731616
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683264}