GitLab

Given that the metrics reporting pref is labelled in the UI as requiring
a restart to apply, this is a much simpler way of gating Domain
Reliability uploads on it.

We simply don't create the Service (so we don't collect data and upload
it) if the pref is false.

This will need to be revisited when we also start using the Monitor for
JavaScript hooks (e.g. the Navigation Error Logging API).

BUG=407170

Review URL: https://codereview.chromium.org/525303004

Cr-Commit-Position: refs/heads/master@{#293226}

BUG=163393
NOTRY=true

Review URL: https://codereview.chromium.org/542483002

Cr-Commit-Position: refs/heads/master@{#293225}

After sending an email to the native-client-discuss list, it was determined
that this feature for redirecting stdout and stderr to JavaScript isn't very
useful. This drops support for that feature; a follow up change to the NaCl
repository will remove support there (and the SRPC message).

BUG=406558

Review URL: https://codereview.chromium.org/513273003

Cr-Commit-Position: refs/heads/master@{#293224}

Restrict the number of cases where we force the compositor to do a synchronous paint to resizing and restore/maximize operations.

Forcing the compositor to do a synchronous paint in window size changed notifications sends over
a synchronous IPC to the GPU process which blocks the UI thread. We have been seeing cases where
Chrome seems to freeze while performing operations like typing in the omnibox, etc.

BUG=397633
R=sky,cpu

Review URL: https://codereview.chromium.org/528173002

Cr-Commit-Position: refs/heads/master@{#293223}

Currently there is not enough unit test cases available to cover
the functionality of Paste Popup menu behavior. This patch covers
essential unit test cases for the same.

BUG=

Review URL: https://codereview.chromium.org/534343002

Cr-Commit-Position: refs/heads/master@{#293222}

BUG=409938

Review URL: https://codereview.chromium.org/538543004

Cr-Commit-Position: refs/heads/master@{#293221}

- Initialize URL standard schemes on load.
- Use NULL-resistant string conversions.

BUG=410374

Review URL: https://codereview.chromium.org/536023003

Cr-Commit-Position: refs/heads/master@{#293220}

Test plan:

First: download chrome-mac.zip from https://download-chromium.appspot.com/?platform=Mac

Then:

$ unzip chrome-mac.zip
$ cd chrome-mac
$ find . -name "*.pak" | grep chrome
./Chromium.app/Contents/Versions/39.0.2136.0/Chromium Framework.framework/Resources/chrome_200_percent.pak
./Chromium.app/Contents/Versions/39.0.2136.0/Chromium Framework.framework/Resources/chrome_100_percent.pak

$ find . | grep content
0 # no results

Check with python:

$ cd ~/chromium/src/tools/grit
$ python
>>> from grit.format import data_pack
>>> pack = data_pack.ReadDataPack('
~/Download/chrome-mac/Chromium.app/Contents/Versions/39.0.2136.0/Chromium
Framework.framework/Resources/chrome_100_percent.pak')
>>> pack.resources[4700]
>>>'\x89PNG\r\n\x1a\n\x00\x00\x00\rIHDR\x00\x00\x00\x0e\x00\x00\x00\x10\x08\x06\x00\x00\x00&\x94N:\x00\x00\x01\x87IDAT(S\x8d\x90I/CQ\x18\x86\xbf\xb5_\x84\xa5\x84\x9f6XX\xb3\xb0\xb7"$j\xe8\xc05T\xe7\x95H\x8cM\xec\xc4XA\xd5\x90\xe2VU\x1a\xa5\x86xb8\xb4h\xaf\xd7\xf9\x0e\xb7Q\xb9\xa2o\xf2,\xce9\xcf\xb39\x14\x08\x04P\nDTF?\xe7\xf7\x07\xa0e?\xf0\x981\xe7)\xa3CQ\x14\xb0W\x14\xfb|~\x9c\xdf\xe98N\xe7LI\xde\xbc\xcb\x90\xc7n!\xf6z\xbd8\xb9\xd6\x119}\x93\x183\xcej\xea\xb5\x10\xf2\xd8\x97\xb1\xdb\xedA\xfcJ\xc7v\xe2\x15\xbf\xc7wG"\xb4\xd9lEpC.\x97[\x86f\xdb\x8ag\x11\x89k\xb8\xb8\xcb\xe1^\xcbK\xf8?\xb8!\xa7s\x0c\xf1K\x1d\x1b\xc7/\xa6\x84O2\xd8Ofqp\xf6E\xeaV\x0774:\xeaD,\x9dGH}.\tv\xb9\xa1\xe1\xe1\x11\xa8\xe2\xb0v\xa8\x95\x04\xbb\xa2!R\x94!\xa8\x17y\xacD\xb5\x02\xcb\xd1G\xccD\xa2\x08\xee\xc4\x8a\xee\x19\xe1rC48\xa8\xe0H\x84\x8b{\x0f\x12Oh\x1e\xb5\xe3\xe5\xa8\x9b\xac\x904\xcf5b6\xac\x1a\xef$\\n\x88\x1c\x8e\x01\x1c\x9e\xe7\xb1\xb0\xfb\x00\xdb\x92W\xc8\x95\x85\xc8\xa0~\xb2\n\x13\x9b\x11\x12\x0e\tW6d\xb7;d\xe8Z\r\x9aF\xdfP\xc3T5\xcd\x85\x13\x1c\x82\x1b\xb2Z\xedXO\xa4\xd18]\xf3gd\xd0\x12lB4\xf5\x0en\xa8\xbf\xdf\x8a\xb6\x85\xd6\x7f#\xe3\xaew\xad\x07\xbd\xd6>Pgg\x17\xda\xdb;\xcc\xa0\x1f\x14\xbdu[,\xf8\x04*e\x8e;5\xb6\x8b\x00\x00\x00\x00IEND\xaeB`\x82'

NOTE: 4700 is the ID of IDR_BROKENIMAGE defined in
out/Debug/gen/content/app/resources/grit/content_resources.h, which
shows content_resources_100_percent.pak gets included within
chrome_100_percent.pak

BUG=176960
TEST=see test plan above
R=tony@chromium.org

Review URL: https://codereview.chromium.org/521473002

Cr-Commit-Position: refs/heads/master@{#293219}

When a pop-up is opened the window size is 367 and content size is 451
and scrollbar of thumblength 202 is created. Pop-Window height has been
resized to 451 because of JS . Before resizing of Pop-Window scrollbar
thumb_length of 202 is been applied. After resizing Pop-Window vertical
scrollbar is disabled during UpdateScrollbarGeometry(has_thumb_ = false).

Now When PaintedScrollbarLayer::UpdateThumbAndTrackGeometry is called
after pop-up window resize, as has_thumb_ = false , UpdateProperty on
thumb_length_ is not applied, due to which we are seeing the unwanted
scrollbar

BUG=400136

Review URL: https://codereview.chromium.org/524373003

Cr-Commit-Position: refs/heads/master@{#293218}

Review URL: https://codereview.chromium.org/539633002

Cr-Commit-Position: refs/heads/master@{#293217}

Apart from the places which expect a SyncLoadResult, it's only read in
RedirectToFileResourceHandler. In that case, it's always net::OK;
ResourceLoader checks request_->status().is_success() first in
OnResponseStarted before calling CompleteResponseStarted().

BUG=none

Review URL: https://codereview.chromium.org/517853004

Cr-Commit-Position: refs/heads/master@{#293216}

Two main cases:
1. <label> not wrapping input + span
2. for accessibility -- for=<selector-id> should instead use aria-labelledby

BUG=409938

Review URL: https://codereview.chromium.org/536703002

Cr-Commit-Position: refs/heads/master@{#293215}

This matches the logic in nss_ssl_util.cc.

Note: this CL has a test which only affects Windows XP. We
have no try coverage on XP, so if the XP bots break, please
revert.

BUG=405630

Review URL: https://codereview.chromium.org/495663002

Cr-Commit-Position: refs/heads/master@{#293214}

This is a re-work of palmer's patch at https://codereview.chromium.org/515023002/ which has more context, but comes down to stricter bounds checking.

We also correct an arithmetic bug when copying the image behind a control that is positioned before the origin of the image.

BUG=398384

Review URL: https://codereview.chromium.org/519873002

Cr-Commit-Position: refs/heads/master@{#293213}

R=dmazzoni@chromium.org
BUG=408405
TEST=keyboard navigate to bookmark star, press space: bookmark deletes and focus still exists.

Review URL: https://codereview.chromium.org/510213002

Cr-Commit-Position: refs/heads/master@{#293212}

Trying to initialize it causes content_shell --enable-browser-side-navigation
to crash on startup.

It corresponds to ResourceRequestInfo::GetVisibilityState, but that's only used
for categorizing requests made from prerender which needs a different bit
(WebPageVisiblityStatePrerender vs. others), so we'll need to revisit it
anyway.

BUG=376014

Review URL: https://codereview.chromium.org/534393002

Cr-Commit-Position: refs/heads/master@{#293211}

BUG=

Review URL: https://codereview.chromium.org/537573004

Cr-Commit-Position: refs/heads/master@{#293210}

unset GYP_DEFINES
python build/gyp_chromium
ninja -C out/Release -t commands base >gyp.txt

gn gen out/gn --args="is_debug=false is_component_build=false"
ninja -C out/gn -t commands base >gn.txt

python tools/gn/bin/gyp_flag_compare.py gyp.txt gn.txt >flags.txt

Outputs this at the moment: https://gist.github.com/sgraham/93e159eba1601a9e3668

(only work on Linux because of lack of handling @rsp files)

NOTRY=true
R=ajwong@chromium.org, brettw@chromium.org

Review URL: https://codereview.chromium.org/539603003

Cr-Commit-Position: refs/heads/master@{#293209}

Remove unused QUIC_VERSION_20.

We are already speaking QUIC_VERSION_21 in the wild, and QUIC_VERSION_20
was never intended to be used. Not much code removed in this CL, but
should make end to end tests a bit faster.

Merge internal change: 74594489
https://codereview.chromium.org/532093002/

Change GetLeastUnacked() to return the next packet that could be sent
when there are no packets in flight instead of 0.

This should help solve the problem we are seeing in trace logs from
internal servers where the ack line drops to 0.

Merge internal change: 74396185
https://codereview.chromium.org/530343002/

Change IsRetransmittable to not check transmission type but instead let
ShouldDiscardPacket check it directly.

Merge internal change: 74359363
https://codereview.chromium.org/536743002/

Change the QUIC CongestionMap to be based on a vector.

Saves ~0.75% CPU when profiling.

Merge internal change: 74321352
https://codereview.chromium.org/528083004/

Some improvements to quic_client_bin.
  - user can supply specific version
  - added a number of comments
  - added a number of descriptive ERROR logs on failure
  - removed unneeded flow control options (SetDefaults covers this)

Merge internal change: 74309904
https://codereview.chromium.org/532073002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/530343003

Cr-Commit-Position: refs/heads/master@{#293208}

This callback has the reentrance issue as calling MediaPlayerBridge::Release() will call into function.
The worst case happens when BrowserMediaPlayerManager dtor is called. In that case, this function will be called on each player, while BMPM is in a partially destroyed state.
Since BMPM controls the lifetime of the players, it can call OnMediaResourcesReleased() when it calls Release() on a player.
For MSE case, we also simplified the situation here since we can check MSP::IsSurfaceInUse(). This CL also fixes that call.

BUG=410096

Review URL: https://codereview.chromium.org/534063002

Cr-Commit-Position: refs/heads/master@{#293207}

These were failing on Android Builder (dbg) FYI bot.

BUG=409152
TBR=qinmin@chromium.org

Review URL: https://codereview.chromium.org/522943003

Cr-Commit-Position: refs/heads/master@{#293206}

Adds a DebugInfo message to the DistilledPageProto. The data for this message
is copied from the DomDistillerResult proto DebugInfo.

For now, only a field for the distiller log exists.

Depends on https://codereview.chromium.org/493853006/

BUG=409274

Review URL: https://codereview.chromium.org/504263002

Cr-Commit-Position: refs/heads/master@{#293205}

The CL https://codereview.chromium.org/415343002/ accidentally
introduced new files in //chrome/chrome_browser.gypi without
adding a newline.

This CL just cleans up the style of the .gypi.

BUG=383630

Review URL: https://codereview.chromium.org/533173003

Cr-Commit-Position: refs/heads/master@{#293204}

This keeps the "Visit Website" link from showing up in chrome://extensions,
which makes sense because shared modules are automatically installed.

BUG=408927

Review URL: https://codereview.chromium.org/532973002

Cr-Commit-Position: refs/heads/master@{#293203}

The notable changes:
. Do not allow horizontal dragging of the split windows.
. Do not show the 'Split' button when dragging a non-split window. Instead,
  highlight the split windows as drop targets.
. When a window is dropped on top of a left/right split window, switch to that
  window in that part of the split.

BUG=404119
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/537073002

Cr-Commit-Position: refs/heads/master@{#293202}

TBR=xians@chromium.org
BUG=409485
NOTRY=true

Review URL: https://codereview.chromium.org/534373002

Cr-Commit-Position: refs/heads/master@{#293201}

This dialog explains the implications of accepting remote
assistance and provides a way for the user to decline
assistance.

This ensures that even if the caller (Hangouts) is compromised,
it won't be able to control the user's desktop without user
interaction.

BUG=405139

Review URL: https://codereview.chromium.org/503063004

Cr-Commit-Position: refs/heads/master@{#293200}

Some checkouts have the build directory mounted, which causes the script
to throw an exception when it attempts to remove the directory itself.

Review URL: https://codereview.chromium.org/532323002

Cr-Commit-Position: refs/heads/master@{#293199}

Initial ExtensionManagement class implementation, with legacy preference parsing and interface for obtaining basic structure of extension management settings.

BUG=177351
TEST=new unit test

Review URL: https://codereview.chromium.org/499313002

Cr-Commit-Position: refs/heads/master@{#293198}

This CL removes the passed parameter of device_scale_factor and in BrowserPlugin::UpdateDeviceScaleFactor since it's not used.

This CL also removes GetSizeParams because it's only used once.

Repaints are now set whenever the device scale factor changes.

Also remove all calls to .get() on scoped_ptrs which are unnecessary.

BUG=none
TBR=creis@chromium.org for trivial render_view_impl change.

Review URL: https://codereview.chromium.org/528383003

Cr-Commit-Position: refs/heads/master@{#293197}

When in overview mode, if a window is closed, then the rest of the windows
that behind the closed window in the stack are moved on step forward. However,
if there are no windows behind the closed window, then move the windows in
front of the closed window backward one step.

BUG=408280
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/531093003

Cr-Commit-Position: refs/heads/master@{#293196}

We are removing the corresponding runtime flag in Blink, as it currently
has no effect. This patch removes its usage in Chromium side.

Blink side: https://codereview.chromium.org/535463002/

BUG=None

Review URL: https://codereview.chromium.org/530353002

Cr-Commit-Position: refs/heads/master@{#293195}

The gmock log spam was annoying.

Review URL: https://codereview.chromium.org/535253002

Cr-Commit-Position: refs/heads/master@{#293194}

The iOS6-style APIs have been deprecated, but the replacements are
more verbose and brittle so this category wraps the replacements in
methods similar to the iOS6-style APIs.

This category lives in a new target and directory: src/ui/ios, so
this CL sets up all the gyp/DEPS stuff and only adds a single
method. There will be more methods added in subsequent CLs.

BUG=364419

Review URL: https://codereview.chromium.org/497503004

Cr-Commit-Position: refs/heads/master@{#293193}

DVLOG(0) is way too spammy for such a low-level function.

BUG=376450
TBR=dalecurtis

Review URL: https://codereview.chromium.org/537653002

Cr-Commit-Position: refs/heads/master@{#293192}

This CL makes sure that the renderer is initialized before being used to handle
a navigation that has just committed.

BUG=376082

Review URL: https://codereview.chromium.org/536473002

Cr-Commit-Position: refs/heads/master@{#293191}

https://skia.googlesource.com/skia/+log/937c9c7eb4e06d4d3bc495e129c7b8103a5d6c0f..74364c97740eb48c86d6e7b42520c77130eb1486

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/533263002

Cr-Commit-Position: refs/heads/master@{#293190}

https://chromium.googlesource.com/chromium/blink/+log/104ecc5a02c328914490c6c17ccc8a17d8e40fca..9d34a87dee82cbdcd5876669aa1cd1a430289e09
TBR=tkent@chromium.org,arv@chromium.org

Review URL: https://codereview.chromium.org/535233002

Cr-Commit-Position: refs/heads/master@{#293189}

The underlying issue has been fixed.

BUG=273986
TBR=andrewhayden@chromium.org

Review URL: https://codereview.chromium.org/534313002

Cr-Commit-Position: refs/heads/master@{#293188}

Revert of Changes exception for gyp files to only gyp files in build/ (patchset #1 id:1 of https://codereview.chromium.org/512693004/)

Reason for revert:
*SIGH* Encountered another problem. See
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...
. Reverting again.

Original issue's description:
> Changes exception for gyp files to only gyp files in build/
>
> I changed analyzer such that if a gyp file (or an included gypi file)
> changes all targets in the gyp file are marked as changed. This means
> I should no longer have to special case gyp files. I'm leaving the
> exception in place for any gyp files in build as any change to those
> really needs to recompile the world.
>
> BUG=109173
> TEST=none
> R=thakis@chromium.org
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/5110e8b
>
> Committed: https://chromium.googlesource.com/chromium/src/+/e53e29fc161f96871160f6db39919752a0376333

TBR=thakis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=109173

Review URL: https://codereview.chromium.org/537683002

Cr-Commit-Position: refs/heads/master@{#293187}