- 30 Nov, 2020 40 commits
-
-
Chris Sharp authored
Bug: 1018157 Change-Id: I7b32ee35d356eb9ea33e6648a86c076ff4b5ecb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551485 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#831856}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011300600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/DFP6775_ioCBTjnpyJoXzr5w-Xv6mSoZDrurJfFGpu4C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/168064736 Tbr: media-app@grotations.appspotmail.com Change-Id: I4f9a1e2f81b86263c98895c2e2233034e79a90fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564528Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831855}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c2f6edd90e95..41e380345098 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rogerta@google.com,rsorokin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rogerta@google.com,rsorokin@google.com Change-Id: Ic3d5932c8c8002da2312215fb155ce28c325b1f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564525Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/77b68e8599f0..ca92424e21e5 2020-11-30 robertphillips@google.com Remove SkBaseDevice::flush (take 2) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: I6e867dd24fc92530f712d6a7aacbbd4a3d7bb63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564527Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831853}
-
Bartek Nowierski authored
Empty slot spans are typically registered for lazy decommitting, to avoid perf regression when going back and forth between decommitted<->active states. However, we haven't observed a perf difference for single-slot slot spans, in which case better to decommit them as soon as they become free. Change-Id: I09e09055dd2b54b17a54ed35f518d72e9a16e310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549024 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#831852}
-
Jaeyong Bae authored
This patch does skip empty span when finding the first-letter text. Also, this adds the following tests. external/wpt/css/css-pseudo/first-letter-skip-empty-span.html external/wpt/css/css-pseudo/first-letter-skip-empty-span-nested.html Bug: 911093 Change-Id: Iee9c6f531771826ea8f8446cd73e2015dfc2fb23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560522Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#831851}
-
Ewann authored
This CL updates the padding between the icon and the text and also the padding between detail text and the AccessoryType. The position of the switch button is also modified in order to be correctly aligned with AccessoryType of the other items. Bug: 922511 Change-Id: I8b738a82d0b523c59344f145938be09f9022bc44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560637Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#831850}
-
Mattias Nissler authored
This reverts commit 960e7e40. Reason for revert: Stray startup_up_flags.flags reference in policy_templates.json breaks things. Original change's description: > Introduce feature flags Chrome OS device setting. > > This new device setting will supersede the existing "startup flags" > setting. The latter was storing chrome://flags feature flags as raw > command line switches, which turned out to be problematic since Chrome > can't easily map the switches back to feature flags to validate them. > Subsequent changes will add support for the new way of doing things as > well as migration logic in session_manager and Chrome. > > BUG=chromium:1073940 > TEST=None > > Change-Id: I54204286db5262e6ccc76b844db5863e69c1d8c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290730 > Commit-Queue: Mattias Nissler <mnissler@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#831789} TBR=xiyuan@chromium.org,mnissler@chromium.org,pmarko@chromium.org Change-Id: I1af63c3cca1eddc0663e1770c51edaab599ab59d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1073940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563673Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#831849}
-
Chris Hamilton authored
Currently this data is associated with frames, but it is also measured for workers. This moves the tracking class to be associated with "ExecutionContexts", which encapsulates either a frame or a worker. This also adds a little bit of syntactic sugar to the ExecutionContext machinery to make it easier to use. BUG=1085129 TBR=jkarlin@chromium.org Change-Id: Ib769c1044ff76af25fa97c804a193ccfbff89eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551154Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#831848}
-
Rune Lillesveen authored
Checking whether a ActiveStyleSheetVector has media queries more naturally belongs there, but also makes it accessible for an upcoming user css split out from StyleEngine. Also renamed the method to better explain what it does. Bug: 336876 Change-Id: I48a58f16867392345d3960304263ea2b90403bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563493Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#831847}
-
Aaron Leventhal authored
This CL progresses towards removal of ShouldUseLayoutBuilderTraversal(), simplifying AddChildren() and removing conditions that lead to lack of symmetry in child-parent relationships. Note that pseudo elements can have multiple children, including text and images. Example in test: list-marker-styles.html. Bug: None Change-Id: I204d567f4673e449ec21a91d923b0bf215b133e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563862 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#831846}
-
Alice Wang authored
This CL adds GoogleActivityController to signin.ui target. The old class will be removed after migrating the callers of the class in //clank. Bug: 1153038 Change-Id: Ia10b1d95be9b26808fe2021d4c539b5fb7b0f3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562139Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#831845}
-
Victor Hugo Vianna Silva authored
Bug: 1105795 Change-Id: Idd7efc38c149769b837fced9743731f5eb0802a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565129 Auto-Submit: Victor Vianna <victorvianna@google.com> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#831844}
-
Mugdha Lakhani authored
Example failure: https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%2064%20bit%20Tester/b8863983830613553808 The test accesses the disk with a blocking call when destroying the incognito profile. Allow blocking calls from the test to fix failure on M. Bug: 1147754 Change-Id: I7f5f00421193a7065626ba2438a77420ff8ffb6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563665Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#831843}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ie3d8881c5035acc6c17400c039fa58f17972d9dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564813Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831842}
-
David Roger authored
The label was (probably) broken because of some syntax error. Rather than fixing the aria-label, this CL uses aria-labelledby instead, because the label already exists at the top of the card element. Fixed: 1151901 Change-Id: I4dc0540bf776f7fb4c271075d047ae243b71f8bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565242 Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#831841}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ic91046cc2a69892008df51d1911b7ce2095b3cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564891Reviewed-by:
-
David Roger authored
When the user accepts the bubble, it is no longer closed immediately. Instead the buttons are disabled and a spinner is shown. Screenshot: https://drive.google.com/file/d/1yTJ2jac0rq-ly6bEZ0mxhrp5hQ3fd1Ai Bug: 1076880 Change-Id: Iff64b798ce7f11fec2c753d0642e989823a349dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563480Reviewed-by:
-
chrome://settingsAntonio Gomes authored
CL ifdef's out Lacros from using having this menu item. By doing this, Lacros pairs itself up with ash/chrome Web browser. Also, even enabled, the menu item is ineffective, since it makes use of a GTK+ functionality, only available for Desktop Linux builds. BUG=1153355 R=thomasanderson@chromium.org Change-Id: I184f65b5efb23c926b7f3a63127a24855b8de067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563919Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#831838}
-
Alice Wang authored
This CL moves UnifiedConsentServiceBridge to signin.services target for signin backend modularization. Bug: 1153046 Change-Id: I4f5c6e0848ad2c3daffdfa634217679cdf38f16d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561384Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/732b1bcf..ac4c4dc0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I58cd21acfe0803fdfd5651cf7b3b44b588de407b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564969Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831836}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606715277-7cd8080ef7943d789d7f3f75a67090679d493829.profdata to chrome-mac-master-1606737208-e8262bf3e6eb680125b6c552d8461f977d1e98a6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I06b48a5e77b3c525acfd7883ad1bc6e35318daa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564894Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606715277-5a5c0b93116eb4ed5bae16849c10b7071f9da60f.profdata to chrome-linux-master-1606737208-c1622dbc8154d000833156e031e2fb92fdbe0368.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I65465d08109fb5af1eb9404337222294b0f636bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564971Reviewed-by:
-
Maksim Sisov authored
Fixes a crash when FindDisplayNearestPoint cannot find a suitable display (if num of displays <= 1) and returns nullptr, which is then returned to ScreenOzone by value, which is illegal and results in a crash. Bug: 1135518 Change-Id: Icb1e788bcc0fbda13bc84023999b1b39eebfd1cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565119 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Auto-Submit: Maksim Sisov (GMT+2) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#831833}
-
Anton Bikineev authored
qurantine. Bug: 11297512 Change-Id: I819d323831993c36575f64f00def30a2e3686577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563766 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#831832}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/75aeca4eb9f8..633335551f5d 2020-11-30 aerotwist@chromium.org [DarkMode] Update web audio styles 2020-11-30 janscheffler@chromium.org [Recorder] Fix recorder freezes 2020-11-30 jacktfranklin@chromium.org [Dark Mode] migrate css_overview/cssOverviewSidebarPanel 2020-11-30 jacktfranklin@chromium.org [Dark Mode] migrate css_overview/CSSOverviewProcessingView 2020-11-30 jacktfranklin@chromium.org [Dark Mode]: migrate css_overview/cssOverview.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1152736 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic5f613960ba0cd9c30ed738ff7c04ad286b8f946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564893Reviewed-by:
-
Anqing Zhao authored
According to the CPP style guide, the enumerators should be named like constants, not like macros. That is, use kEnumName not ENUM_NAME. So let's improve SystemFeature accordingly. See: https://google.github.io/styleguide/cppguide.html#Enumerator_Names Bug: 1142785 Change-Id: I9b95c6ed035cf0b5016b562ee9986626e4d511c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563305Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Change the assert to use '.split('\n')' to compare the files based on a list of lines to make the error message better to understand where is the difference. Bug: 1152668 Change-Id: Ica401046a4da35f0e0fa34870af0a3ed6777c525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558101Reviewed-by:dpapad <dpapad@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#831829}
-
Rune Lillesveen authored
While working on moving user style into a separate ScopedStyleResolver, the term "author" did not make sense. It also generally didn't seem to add any value here. Bug: 336876 Change-Id: Ib70f4ace0410fc9598e45db349e866beca37bd0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563825Reviewed-by:
-
Mathias Bynens authored
The expected output will change due to [1]. We’ll re-enable the test with new expectations after the devtools-frontend change has landed and rolled into Chromium. [1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2557071 Bug: chromium:1152391 Change-Id: I6b7d5fa352b6f94b865ad2896bc1f3fa102b625f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563668 Commit-Queue: Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#831827}
-
Rune Lillesveen authored
Forcing re-adding all sheets should not be necessary. I probably was at some point. Now, the active style update process should handle all. TEST=StyleEngine.StyleMediaAttributeStyleChange TEST=StyleEngine.StyleMediaAttributeNoStyleChange Change-Id: Ie5af77ca90768b8fe5a39c3e07ddd5025f1c1056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563469Reviewed-by:
-
Jérôme Lebel authored
Remove + kTokenServiceExcludeAllSecondaryAccounts + kTokenServiceExcludedSecondaryAccounts Those pref were used before moving to WKWebView. Related to crrev.com/c/2544972 Change-Id: I84faa8721c622663e018f28e99c158407bcdbc66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563473 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
Kushagra Sinha authored
Remove `COMPONENT_EXPORT` from `account_manager::AccountType` enum. Enums do not need to be dll-exported and doing it anyways results in compilation failures on Windows buildbots. Change-Id: I883284f030d9d86657c95cfea8ede4fee0fa522e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565240Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#831824}
-
Richard Knoll authored
CrOS has a different wording (formal vs informal) than on other platforms which results in different strings in some languages. This splits the string into "chromeos" and "not chromeos" parts and adds a meaning so they end up as separate strings in the translation console. Bug: b/172205057 Change-Id: I3cd55ee68edfd30f903d6805bf43452f3dbd7611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563550Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#831823}
-
Roman Sorokin [CET] authored
This reverts commit 1fc0c31c. Reason for revert: speculative revert for BackForwardCacheBrowserTest.PageshowMetrics failure (https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/43304) Original change's description: > Two phase BackForwardCache restore > > Split the BackForwardCache restore flow into two phases: > * disable evictions (e.g. no longer evict if js executes) > * Commit navigation and unfreeze the page and run handlers (pageshow etc) > > This eliminates the existing race were a evict request arrives after > RFH have been swapped and a reload is needed. > > We add a new Lifecycle state property that controls eviction and we > commit the back navigation (and thus swap RFH instances) we wait for > the renderer to ack that eviction is disabled. At this point we can > be sure that no eviction request will arrive from the renderer and we > can commit the navigation. > > Bug: 1153126 > > Change-Id: I4e787a008881a04954b27d201e635b3a18794536 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352815 > Commit-Queue: Carlos Caballero <carlscab@google.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#831809} TBR=dcheng@chromium.org,altimin@chromium.org,arthursonzogni@chromium.org,carlscab@google.com Change-Id: Ib3b972d3644b7bc65353f37cc901e396400e89c3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1153126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564760Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#831822}
-
Bao-Duy Tran authored
This is a reland of f42aaef1 No changes from the original CL which was reverted (https://crrev.com/c/2560280) just because its parent CL (https://crrev.com/c/2550152) had to be reverted (https://crrev.com/c/2560527). That's now been relanded (https://crrev.com/c/2560448) so this reland can go head, too. Original change's description: > Remove unnecessary ime_list_ in InputMethodManagerImpl unit tests. > > Bug: 1134465 > Change-Id: I32cb2d5d67e6bd102f17578d824028527d1c9bdc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551869 > Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> > Reviewed-by: Darren Shen <shend@chromium.org> > Reviewed-by: Jing Wang <jiwan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#831202} Bug: 1134465 Change-Id: I727c3a565ccfb79a55cd85e1be0ebf98239785a4 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chromium.try:linux-chromeos-rel,linux-chromeos-dbg Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563045Reviewed-by:
Jing Wang <jiwan@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#831821}
-
Yoshisato Yanagisawa authored
This reverts commit 7e77a598. Reason for revert: Including omit python2, which I have reverted. Original change's description: > Roll Chromite from 9ed30bc3ed29 to 34d74e1ebe96 (7 revisions) > > https://chromium.googlesource.com/chromiumos/chromite.git/+log/9ed30bc3ed29..34d74e1ebe96 > > 2020-11-27 sidereal@google.com chromite: Remove code for generating guest_images.tar > 2020-11-27 chrome-bot@chromium.org Update config settings by config-updater. > 2020-11-27 chrome-bot@chromium.org Update config settings by config-updater. > 2020-11-26 vapier@chromium.org cbuildbot: do not bootstrap when using main & master > 2020-11-25 saklein@chromium.org controller/sysroot: Fix result path usage. > 2020-11-25 vapier@chromium.org cbuildbot: update tot logic to consider main & master equivalent > 2020-11-25 yyanagisawa@chromium.org omit python2 to run goma_ctl. > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/chromite-chromium-autoroll > Please CC chrome-os-gardeners@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel > Tbr: chrome-os-gardeners@google.com > Change-Id: I0ac4ea8b50283a9df37ebfea2236f3d545a26a4a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562653 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#831595} TBR=joelhockey@chromium.org,agawronska@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: If0caf42ce81cdb66122084e06ca4e6168696c0f9 Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563429Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> Cr-Commit-Position: refs/heads/master@{#831820}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/69c377e2adf6..75aeca4eb9f8 2020-11-30 jacktfranklin@chromium.org [DarkMode] migrate CSSOverviewCompletedView 2020-11-30 alcastano@google.com Refactor UISourceCodeFrame to use Icon component 2020-11-30 pfaffe@chromium.org Use bytecode offsets in wasm source GoToLine and position indicator 2020-11-30 szuend@chromium.org Implement 'monospace' and 'source-code' CSS classes with CSS variables 2020-11-30 janscheffler@chromium.org [Recorder] Add support for window.open 2020-11-30 aerotwist@chromium.org [unit test] Add debouncer test 2020-11-30 aerotwist@chromium.org Add ls import If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1150883,chromium:1152405,chromium:1152714,chromium:1152736,chromium:1153323 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I62ee8482411c78d72f53b7cfee82e507b1d1346c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564890Reviewed-by:
-
Benoit Lize authored
Bug: 998048 Change-Id: I13373f10e55c3aecfe77081e6bfb1e6b159535af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549968Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#831818}
-
Mathias Bynens authored
This patch replaces existing usages of the DevTools `setImmediate` helper with the built-in `queueMicrotask`. This enables us to remove the `setImmediate` helper in [1]. [1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2554560 Bug: chromium:1050549 Change-Id: I618a167323ce8b80cbd0249a76357606d6aa6987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563476Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#831817}
-
![Roman Sorokin [CET]'s avatar](https://secure.gravatar.com/avatar/7b28a287700b8b8659a03c33a38be1a8?s=80&d=identicon "Roman Sorokin [CET]")
