- 03 Nov, 2020 40 commits
-
-
Oleg Davydov authored
And rename it to CanUseUpdateService for the consistency. The UpdateService::CanUpdate method doesn't use much from its class (only a browser context to access one keyed service). From other side, in the future we want this method to depend on extension management, which is available for chrome/, but not for extensions/ layers. And the only usage of CanUpdate is inside ExtensionUpdaters (which is already in chrome/ layer). Therefore, it makes sense to move this method in chrome/ layer, specifically into ExtensionUpdater class. As a bonus, now this method is private. Bug: b:171782200 Change-Id: I6afd7e784e8cd95f8927aab8f818f307352f58a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503690 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#823508}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/959f41988a18..b5bf82693f85 2020-11-03 jari.komppa@siru.fi Add script to verify proper Memset template use If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I3cd4a79c53c3502fc257c9b491752be719a3a949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516388Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823507}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/71d2e1d23d49..43ef0a365b84 2020-11-03 cwallez@chromium.org ValidationTest: Make custom device creation go through a virtual method If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1138528 Tbr: cwallez@google.com Change-Id: I245ed992beaf85f57ced0076ca90534ffdcebe3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516489Reviewed-by:
-
Gyuyoung Kim authored
This CL replaces all uses of blink::MediaDeviceType with blink::mojom::MediaDeviceType in order to reduce type conversion between them. Bug: 919392 Change-Id: I37bc2effefa790a2c0a1874738e94e41dada12ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505347 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#823505}
-
Richard Knoll authored
Bug: b/171901437 Change-Id: Id0785abc0161a1f4f23e85050ab7f3c4f6007408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515682Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#823504}
-
Nicholas Verne authored
This is a reland of 6b11534a OK, this time for sure. The tast-test change below was submitted, but the relevant ChromeOS uprev was blocked for days. This is now through so we can reland again, for real this time. Original change's description: > Reland "Crostini settings string changes." > > This is a reland of da531d49 > > Now that https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/2505407 > is landed, this should be safe. > > Original change's description: > > Crostini settings string changes. > > > > Instead of "Linux (Beta)", now shows as "Developers" > > > > Bug: 1140370 > > Change-Id: Id4e076b5d918e41e22e5c59d65958da9e75a3f55 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486528 > > Commit-Queue: Nicholas Verne <nverne@chromium.org> > > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > > Reviewed-by: David Munro <davidmunro@google.com> > > Auto-Submit: Nicholas Verne <nverne@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#820205} > > Bug: 1140370 > Change-Id: Ibb5bd28f9647847dddaf109e9da86d91b17dd863 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505324 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: David Munro <davidmunro@google.com> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822525} Bug: 1140370 Change-Id: I76e0dfa45877db5d633a70126c0f5bd2a70a15f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515799Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#823503}
-
Henrik Boström authored
This class supports pixel conversions and rescaling, backed up by both libyuv functions for SW conversions and PixelBufferTransferer for HW conversions. It supports conversions from all supported capture formats (NV12, YUY2, UYVY, MJPEG) to NV12 and I420. (The pixel transfer path supports even more destination pixel formats, but libyuv's destination must be NV12 or I420, and these are the only two of interest to us.) Whether HW or SW conversion is used, the resulting buffer is put in an IOSurface-backed pixel buffer. Code paths: - When we have a pixel buffer, i.e. this is NOT MJPEG: - PixelBufferTransferer: X -> I420/NV12 in a single step. - libyuv: X -> I420 in a single step. X -> NV12 may involve an intermediate step X -> I420 -> NV12. Conversion and rescaling are done in separate steps. - MJPEG (when we only have a sample buffer): - PixelBufferTransferer: Not supported. - libyuv: MJPEG -> I420 in a single step. MJPEG -> NV12 in two steps MJPEG -> I420 -> NV12. Conversion and rescaling are done in separate steps. In a follow-up, we will do MJPEG -> NV12 in a single step based on the libyuv CL that eshr@ recently landed. Measurements show that which conversion method is most efficient is dependent on input and output pixel formats and may even be affected by cache hits/misses. In future CLs, we should wire up and measure the optimal SampleBufferTransformer configurations (in which formats to use libyuv and in which formats to use pixel transfer). Bug: chromium:1132299 Change-Id: I4f6053c65c0c3b02483d130e25bebd1f656abd89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498563 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#823502}
-
Bartek Nowierski authored
Current issues: - PA_DCHECK fires when partition page isn't 16kB - pages for quarantine bitmaps are committed unconditionally, even if the feature is never enabled These need to be addressed before re-enabling. Bug: 1144990, 11297512 Change-Id: Ia5fada4d84f5d9c28b5768322aacbccc72f5f487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515506 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cde27a683736..30ad9ea33821 2020-11-03 mathias@chromium.org Sort and reformat AUTHORS 2020-11-03 szuend@chromium.org Add Peter and myself as i18n/ owners 2020-11-03 jobay@google.com Add optional handler argument to $, $$, and waitFor 2020-11-03 bmeurer@chromium.org [wasm] Generate disassembly in chunks using the WasmParser API. 2020-11-03 soxia@microsoft.com Support page script in fetch handler If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1141781 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I06412b817f384a39631a13265f3614103bb3e2a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516480Reviewed-by:
-
Dominik Inführ authored
Bug: v8:10315 Change-Id: I6ff1be184e6f1a5b803abd673760f1cf81611c93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467998Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#823499}
-
Elad Alon authored
TL;DR: * This is an API for capturing the current tab. * This CL handles the Blink part. Explainer: https://docs.google.com/document/d/1CIQH2ygvw7eTGO__Pcds_D46Gcn-iPAqESQqOsHHfkI Design doc: go/get-current-browsing-context-media Intent-to-Prototype: https://groups.google.com/u/3/a/chromium.org/g/blink-dev/c/NYVbRRBlABI/m/MJEzcyEUCQAJ PR against spec: https://github.com/w3c/mediacapture-screen-share/pull/148 Next steps: * Implement the confirmation-box. * Implement unit-tests that rely on the confirmation-box. * Graduate this to an origin-trial. Bug: 1136942 Change-Id: I81333274075cd56d7e628a8a0eb025b1ae08645a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500841Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#823498}
-
Matthew Denton authored
Cert verification is moving out of the Network Service into a CertVerifierService for sandboxing purposes. Embedders should now include a remote to a CertVerifierService in the NetworkContextParams when creating a NetworkContext. This CL does that for Chromecast's system network context, in preparation for making the CertVerifierService enabled by default. Bug: 1015134, 1098689 Change-Id: I1b9011b7aec40326307ec11d4cde17b086c7be73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509689Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#823497}
-
Anders Hartvoll Ruud authored
This is using the exact same approach as for @property [1]: - When adding user @scroll-timeline rules, clear all rules (including author), then add user rules. - MarkDocumentDirty + SetNeedsAppendAllSheets, to ensure that we ApplyRuleSetChanges for author rules. - When adding author @scroll-timeline rules, clear all rules (including user), then add all user rules, then author rules. Marking for recalc was moved such that it only takes place if a @scroll-timeline rule is actually seen (same as for @property). This is to avoid unnecessary recalcs on media changes. [1] http://crrev.com/84a440a4818bae43a972cfc7c7c67ba4a0318003 Bug: 1074052 Change-Id: Ic081037f9a6c91fece22ee75da2f884f1902322c Fixed: 1097055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513658 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#823496}
-
Victor Hugo Vianna Silva authored
crrev.com/c/2470524 made some changes to the UI of the bubble used to offer moving a password to the account. This CL applies the same changes to its corresponding dialog in chrome://settings/passwords/device. The changes are: - Replacing the favicon elevation with a 1px border. The border is separated from the inner favicon by a 3px padding. - The borders of the avatar, favicon and computer icon share the same color, which is different in dark mode. - The favicon background changes color when in dark mode. Screenshots can be found here crbug.com/1100814#c20. Bug: 1100814 Change-Id: I05d4e5677f2fa6f4f52e70c1fdfbd38f0fa33ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514207Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#823495}
-
Anders Hartvoll Ruud authored
This reverts commit 38e15fd1. Reason for revert: Causes crash - https://crbug.com/1145094 Original change's description: > Roll ICU to 68-1 > > See https://chromium-review.googlesource.com/c/chromium/deps/icu/+/2511803 > for the actual changes and the details of the data size changes. > > > Cq-Include-Trybots: luci.chromium.try:linux-blink-heap-concurrent-marking-tsan-rel,linux_chromium_tsan_rel_ng,android-asan,linux-libfuzzer-asan-rel,linux_chromium_asan_rel_ng,linux_chromium_chromeos_asan_rel_ng,win-asan,linux_chromium_msan_rel_ng,linux_chromium_chromeos_msan_rel_ng,linux_chromium_ubsan_rel_ng,linux-gcc-rel;luci.webrtc.try:linux_tsan2,linux_asan,mac_asan,win_asan,linux_msan,linux_ubsan,linux_ubsan_vptr,linux_compile_gcc_rel > > Bug: 1138555,854201,927703 > Change-Id: I8f1b6157f2f1c13c2864836b38e36a37b8c778bf > Binary-Size: 40K ICU increase due to increase version of ICU. > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474093 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Jungshik Shin <jshin@chromium.org> > Reviewed-by: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823458} TBR=jshin@chromium.org,ftang@chromium.org Change-Id: I92d549bc306aed6e01a485faed63f02cbdd57ba7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1138555 Bug: 854201 Bug: 927703 Bug: 1145094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516560 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#823494}
-
Thomas Tellier authored
On the login screen, ADB sideloading enabled could be notified before system info such as os_version_label_text, enterprise_info_text and bluetooth_name are set, resulting into a failed DCHECK. Bug: 1141348 Change-Id: I0b607d779a1995f22d171d204cd4ca1299c2039c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515681Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#823493}
-
Christian Dullweber authored
Bug: 1077766 Change-Id: I50ab1b94060b590f01225a8891211f2266db9b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513653Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#823492}
-
Jinsuk Kim authored
ToolbarColors is a collection of public static methods that returns the right color of various toolbar ui components which gets customized when the current tab is showing NTP. This CL refactors the customized logic by moving it behind NativePage interface, so that the class doesn't have direct dependency on NewTabPage. Bug: 1127732 Change-Id: Ib1b139467a0f1cc216792d112b13b40168c44c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486526 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#823491}
-
arthursonzogni authored
Most tests about navigation defines web_contents() to avoid doing some static_cast<WebContentsImpl>(shell->web_contents()) every times the tests want to access anything. Similarly, they also define current_frame_host() for getting the current main document. For instance, see RenderFrameHostImplBrowserTest. This patch introduce the same shorthand. It makes every tests to use them. (File size reduced by ~3.5% overall). Bug: None Change-Id: I76b196ad4da8d3ce12a4fe82c076fd59f31016ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506048 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#823490}
-
Christian Dullweber authored
Bug: 1077766 Change-Id: Id80436da160c1fcb46e562713f87171415b16c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512898Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I2e8d365623cc63dae6ccae7105dcf69ac2afd4de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516379Reviewed-by:
-
Jan Wilken Dörrie authored
This change moves password_form.h and password_form.cc from /autofill/core/common to /password_manager/core/browser and fixes remaining compilation issues. TBR=vasilii,dvadym Bug: 1067347 Change-Id: I562e14ed8a0d78b5e285b9d47c98a9e036af3d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516220 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#823487}
-
Rohit Agarwal authored
This CL removes the deprecated Profile#hasOffTheRecordProfile method which invoked Profile#hasPrimaryOTRProfile internally. The remaining callers of hasOffTheRecordProfile are updated to directly call hasPrimaryOTRProfile instead. The code requiring the check of primary OTR profile would rely on invoking the method Profile#hasPrimaryOTRProfile explicitly instead. Bug: 1060940 Change-Id: I0955789b0cdb7c3ea86eccb2840d35c0e10d79d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516222Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#823486}
-
Gauthier Ambard authored
This CL makes sure that the documentURL is correctly updated, or is not updated when the user is reloading an error page with the new workflow. Bug: 1139303 Change-Id: I11d5f70eeb58077c0ed40f0b183c3f762f749ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514205 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#823485}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/037ccdfb..e0ff8ffa Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I654c9d7be80e762e6e1c0ef0a52decba1532f2d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516001Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823484}
-
Marina Ciocea authored
Make the WatchTimeReporter accessible from the Blink component WebMediaPlayerMs, used in follow-up https://crrev.com/c/2513645 to report the duration of media streams. The WatchTimeReporter is placed in Blink common/ in order to be accessible from both //media/blink/ and Blink renderer/modules, and to be able to access the MediaMetricsProvider mojom, which cannot be accessed from Blink public/web. Bug: 1077707 Change-Id: Id1f52549b6f1e791ffd0e71f7a95f12eb1cc57f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401459Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Alan Cutter authored
This CL adds a config parameter "only_for_new_users" which prevents installation of a default web app if the user profile has used Chrome already. This allows us to specifically target new users only for new default web app rollouts. Bug: 1145032 Change-Id: Id222d359b9bf9645e676de12ef9ea23039710a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515931 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#823482}
-
Anders Hartvoll Ruud authored
Similarly to how animation-play-state is ignored if play() is called using the Web Animations API, the animation-timeline property should probably be ignored if the timeline of a CSSAnimation has been replaced using the Animation.timeline attribute. Bug: 1074052 Change-Id: I5fcc16539e50ee2a6da6fe64c181f45086386e93 Fixed: 1141836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514210Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#823481}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/99a0aff93739..cde27a683736 2020-11-03 me@heardanieljames.com Add type to remoteObject when storing as global variable 2020-11-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ice1d23c8b87b42b07e09a7fd4435529dd9f5e667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516399Reviewed-by:
-
Jan Scheffler authored
The cl in devtools-frontend: https://crrev.com/c/2514438 Bug: chromium:1143648 Change-Id: Ia03277779929705a72b463f0a40f28c32547b0e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512901Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#823479}
-
Austin Tankiang authored
Bug: 1137617 Change-Id: Ib1bd0259bbea79c6806a2de74684e839bb0662b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513316Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#823478}
-
Olivier Robin authored
This flag will be used until the widget can be compiled using the standard toolchain. Change-Id: I0d7cc9187711be1d8743ea5c29093b9cefaf30f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514418 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#823477}
-
Austin Tankiang authored
The Linux files icon was changed to being a background-icon in the file list due to https://crbug.com/1075440, so its color needs to be specified in the SVG file itself. Fixed: 1145037 Change-Id: I9fc7da7a3e736da8df88e523fd76b170af9e524e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515427Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#823476}
-
Luca Hunkeler authored
If a TextView containing a link (ClickableSpan) is specified as right/left content view, the onclick of the checkbox will not trigger while clicking the TextView. To make sure it does, we need to direclty specify the onclick on the sub view. Bug: b/170293718 Change-Id: Id5498b0617fd01a507b97c3377ad79aa3d67421c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489646 Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#823475}
-
Tim Song authored
We add metrics for PhoneHub notification actions by introducing' a new PHONE_HUB notification type. This way, metrics will be logged into existing histograms. Additionally, this CL also adds a new Ash.PhoneHub.NotificationCount histogram counting the number of active PhoneHub notifications. BUG=1138137,1106937 Change-Id: I4529eb6cc0d861ec9eb720e4eeac5c6d2d6257ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505728 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#823474}
-
Shik Chen authored
Guides FFmpeg to generate regular (non-fragmented) MP4 if the output is seekable. Bug: 1140852 Test: Pass camera.CCAUIRecordVideo and camera.CCAUIIntent Change-Id: Icc1e32c9160e4734360a35738479b47345a7ab95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513810Reviewed-by:
Inker Kuo <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#823473}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e26606f95bf7..a77ad8657484 2020-11-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 47ad8b8f to c3b9f252 (386 revisions) 2020-11-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e0de282e678b to 959f41988a18 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Change-Id: I5a7ba1b075566fdaecf780e83c2f516b854d0a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516249Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604361545-eddf887b8e48f98791a455ee84436440e457a8ca.profdata to chrome-linux-master-1604382852-89adcc94b5376db481c405a47786acd9d71a0a15.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib465773801259741b293e0c10c6c456ce961217e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516171Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604361545-d42c7d02d03a39b634140e180e06bf71d35a67fd.profdata to chrome-mac-master-1604382852-9483a9470fa3ce55e504618f01ab71cbbe527541.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibba9723491036833ba0b18a31a07cbc7517713db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516169Reviewed-by:
-
Solomon Kinard authored
InitValue changed to InitFromValue. Bug: None Change-Id: I96fb88b03de83f6252c313c1ef0447552b75c61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506040 Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#823469}
-
