GitLab

This change adds support for sending screen orientation change events
to out-of-process iframes as well as fixing the Screen.orientation
property on OOPIFs.

This change adds a PageMsg_UpdateScreenInfo that updates the
ScreenInfo for subframe renderers. The screen orientation is
still updated on the ViewMsg_Resize for the main frame.

The flow of dispatching the screen orientation update is:
1. The browser sends a ViewMsg_Resize to the main frame's renderer. The browser also sends PageMsg_UpdateScreenInfo to the OOPIF renderers.
2. The main frame renderer dispatches FrameHostMsg_FrameRectsChanged back to the browser process.
3. The browser process dispatches ViewMsg_Resize to the subframe renderers.
4. The subframe renderers dispatch the screen orientation event when they receive the resize IPC.

BUG=498287

Review-Url: https://codereview.chromium.org/2832093003
Cr-Commit-Position: refs/heads/master@{#468057}

https://codereview.chromium.org/2786463004/ caused the regression.
Now we paint cell's container backgrounds as display item of row/section
instead of cell, so when cell's geometry changes we need to invalidate
the container's backgrounds.

BUG=713050
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2851553002
Cr-Commit-Position: refs/heads/master@{#468056}

BUG=716442

Review-Url: https://codereview.chromium.org/2848883002
Cr-Commit-Position: refs/heads/master@{#468055}

appbar_background was previously used to provide a grey toolbar on
phones and a white toolbar on tablets for the downloads and bookmarks
UIs. The toolbar for these UIs is always gray now, so appbar_background
is no longer needed.

BUG=687640

Review-Url: https://codereview.chromium.org/2845373003
Cr-Commit-Position: refs/heads/master@{#468054}

Moves TraceWrapperMember, SharedPersistent, IDLDictionaryBase and ToV8 to platform/bindings. Also moves some ScriptValue functions in ToV8 to ToV8ForCore as ScriptValue is not moving to platform/bindings right now.

BUG=682322

Review-Url: https://codereview.chromium.org/2843143002
Cr-Commit-Position: refs/heads/master@{#468053}

Since N, the preference directory will be created if it doesn't exist
when getSharedPreferences is called. Enable disk writes to prevent a
strict mode violation; this will only happen the first time an app is
started up.

BUG=716219

Review-Url: https://codereview.chromium.org/2846963005
Cr-Commit-Position: refs/heads/master@{#468052}

This is in preparation for actually fragmenting under multicol, in a
future patch.

BUG=648274
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2849603004
Cr-Commit-Position: refs/heads/master@{#468051}

allowThreadDiskWrites also allows reads, so it's not necessary to call
both together. Remove all the redundant allowThreadDiskReads calls.

BUG=

Review-Url: https://codereview.chromium.org/2851473007
Cr-Commit-Position: refs/heads/master@{#468050}

BUG=716480
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2848903003
Cr-Commit-Position: refs/heads/master@{#468049}

* Remove touch drag for a series of tests about tab dragging to the second display as, up to now, there's no use case.

* Each display has its own UI controller in the test, but, in ozone build, they do not share the state of mouse (down, up). When the mouse is moved to the second display, the UI controller for it does know that the mouse is down in first display. That's why the tab cannot be dragged to the second display only in ozone build. Simple solution is to move the mouse state variable outside of UI controller class.

BUG=626769

Review-Url: https://codereview.chromium.org/2836073003
Cr-Commit-Position: refs/heads/master@{#468048}

Remove NVIDIA Shield Tablet expectations,
since they also affect NVIDIA Shield TV.

Mark
conformance/textures/image_bitmap_from_video/tex-2d-rgb-rgb-unsigned_byte.html
Flaky on Nexus 5X.

BUG=701929, 716496
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2851773002
Cr-Commit-Position: refs/heads/master@{#468047}

This is the first step of Glowplug Database refactoring. As a result we should
get rid of boilerplate related to adding/removing tables from Glowplug.
The next step will be providing users the direct access to tables instead of
using Update{Resource,Redirect,etc.}Data wrappers.
The code uses templates instead of google::protobuf::MessageLite for the
type-safety.

BUG=715525

Review-Url: https://codereview.chromium.org/2851473002
Cr-Commit-Position: refs/heads/master@{#468046}

Change
https://chromium.googlesource.com/chromium/src/+/d892f9592860691ae9a782c12260c94ed6bd1a63%5E%21/#F30

caused the layout object to possibly be invalidated. Collapse the code
so that LayoutObject is correclty scoped so we don't run this risk.

BUG=712459

Review-Url: https://codereview.chromium.org/2849883002
Cr-Commit-Position: refs/heads/master@{#468045}

Move tests for parsing API calls against the expected signature from
api_binding_unittest.cc to a new api_signature_unittest.cc. This is
more correct since the parsing now happens in that file, and will also
make subsequent tests cleaner.

BUG=653596

Review-Url: https://codereview.chromium.org/2847843002
Cr-Commit-Position: refs/heads/master@{#468044}

Previously, all observers of the bottom sheet had a life cycle that
matched the bottom sheet, so it wasn't necessary to remove the. The
suggestions content, however, does have the potential to be destroyed.
This change adds a removeObserver(...) method to the bottom sheet to
handle this case.

BUG=715979

Review-Url: https://codereview.chromium.org/2844993003
Cr-Commit-Position: refs/heads/master@{#468043}

Review-Url: https://codereview.chromium.org/2843263006
Cr-Commit-Position: refs/heads/master@{#468042}

This patch ensures that we capture all relevant work that we do during
recording. This includes both the analysis (which is currently captured)
and discardable image generation (which is currently missed).

This is done via using RecordingSource, which does all of this work
during regular Chrome operations.

NOTE TO PERF SHERIFFS
=====================
This patch is expected to regress rasterize and record benchmark.
Some metrics like paint_time are expected to regress ~100%. This
is due to the fact that the current benchmark is not capturing
all of the work that the code normally does. The patch here
addresses this shortcoming by adding all of the work that needs
to be measured into the benchmark.

R=chrishtr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2851583002
Cr-Commit-Position: refs/heads/master@{#468041}

This CL had been previously landed as:
   https://chromium.googlesource.com/chromium/src/+/e012fe8a8e4d60ed8eba17fbac5df6d9fc4bcad3
but got reverted because it broke some browser tests:
  https://chromium.googlesource.com/chromium/src/+/13b26dffd848c02b1ae0f4ed86986b2a474056c1

Review-Url: https://codereview.chromium.org/2849433002
Cr-Commit-Position: refs/heads/master@{#468040}

This CL is a refactor with no intended behavior change.

Now that the class is defined on all platforms, make it a single class rather
than 3 separate classes. This allows the removal of some duplicate code in the
public interface.

BUG=713763

Review-Url: https://codereview.chromium.org/2846893003
Cr-Commit-Position: refs/heads/master@{#468039}

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/ for
the spec, or https://goo.gl/pygX5I for details of the planned
implementation in Chromium.

This CL creates a barebones ChromeReportingDelegate, initializes the
ReportingService in ProfileImplIOData::InitializeInternal, and sets the
service on the URLRequestContext.

BUG=704259

Review-Url: https://codereview.chromium.org/2769083005
Cr-Commit-Position: refs/heads/master@{#468038}

This should help keep the NaCl configuration more separate from the rest of the
build. A comment is added to prevent regressions.

Review-Url: https://codereview.chromium.org/2845943005
Cr-Commit-Position: refs/heads/master@{#468037}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e353f66b..75378bf9

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2846703006
Cr-Commit-Position: refs/heads/master@{#468036}

This CL is *mostly* a refactor with no behavioral changes.

SharedMemoryHandle is already a struct on Windows and macOS. Making it a struct
on all platforms allows the introduction of a GUID field.

This CL includes two small fixes:
Previously, the implementation of SharedMemory on POSIX was inconsistent on the
definition of a valid handle. Sometimes it would check fd > 0, sometimes it
would check fd >= 0, and sometimes it would check fd != -1. This CL standardizes
on fd >= 0.

The previous implementation of SharedMemory on NaCl would leak a fd if it
failed to copy the fd in ShareToProcessCommon.

BUG=713763
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2843113002
Cr-Commit-Position: refs/heads/master@{#468035}

This is a follow up CL to https://codereview.chromium.org/2830353003/ to
add more trace events and allow for navigation to be easily debugged
only through capturing a trace.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2846983002
Cr-Commit-Position: refs/heads/master@{#468034}

Create frame iterator for frame types except HEADER, PUSH_PROMISE and DATA. This helps use unified interface at call site.

This CL lands server change 151846071 by yasong.

BUG=488484

Review-Url: https://codereview.chromium.org/2844083003
Cr-Commit-Position: refs/heads/master@{#468033}

It is actually a server misbehavior, but currently it is unknown,
how widespread it is.

Added UMA to track such events.

Drive-by: fix reported encoding in case of unadvertised encoding
to be "REJECTED".

BUG=714514

Review-Url: https://codereview.chromium.org/2835403003
Cr-Commit-Position: refs/heads/master@{#468032}

The interface taking a raw pointer is deprecated and being removed.

BUG=690937

Review-Url: https://codereview.chromium.org/2845263002
Cr-Commit-Position: refs/heads/master@{#468031}

Split out the parts that are specific to the committed Document, and
move those to a new Document::CheckCompleted(). Most current callers of
FrameLoader::CheckCompleted() will now call Document::CheckCompleted()
instead. Rename the remainder of FrameLoader::CheckCompleted() to
DidFinishNavigation(), and have it handle the logic that is tied to
setting Frame::loading_ to false and firing DidStopLoading() callbacks.

Originally reviewed in https://codereview.chromium.org/2809733003/

BUG=

Review-Url: https://codereview.chromium.org/2837763003
Cr-Commit-Position: refs/heads/master@{#468030}

No one is using it, so we've decided to delete the code. The removals
from api.txt are safe because that code is known to be unused, partly
because it wouldn't have worked anyway.

BUG=716108
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2839413003
Cr-Commit-Position: refs/heads/master@{#468029}

The interface taking a raw pointer is deprecated and being removed.

BUG=690937

Review-Url: https://codereview.chromium.org/2851673002
Cr-Commit-Position: refs/heads/master@{#468028}

When the zygote starts it sends a "boot message" to the browser process
across a socket. If the browser has already exited or crashed the
sendmsg() will fail. We've seen this happen in the Chrome OS autotest
lab.

Instead of crashing the zygote, just log an error and cleanly exit.

BUG=692227
TEST=add sleep to zygote startup, kill browser before zygote boot
message is sent, verify zygote shuts down cleanly

Review-Url: https://codereview.chromium.org/2851473005
Cr-Commit-Position: refs/heads/master@{#468027}

BUG=716149

Review-Url: https://codereview.chromium.org/2844373003
Cr-Commit-Position: refs/heads/master@{#468026}

BUG=714827

Review-Url: https://codereview.chromium.org/2843463004
Cr-Commit-Position: refs/heads/master@{#468025}

PatchSet #1 is the state as previously reviewed and reverted.
PatchSet #2 fixes the reason for the revert.

Description of Fix:
The test "AccessIsRevokedOnSecondAccess" was flaky because had an incorrect
expectation on the order in which events from the service arrive. This is fixed
by removing this expectation.

Original CL description:

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL22b.

Note: The video capture service implementation is currently in an incomplete and
outdated state and its tests are disabled. With the refactoring of the legacy
video capture stack now being complete, the next goal is to update the service
implementation and fit it into the refactored stack.

Changes in this CL:
* Update Mojo interfaces to more closely resemble their native counterparts.
  - video_capture.mojom.Device offers functionality similar to
    VideoCaptureDeviceLauncher + LaunchedVideoCaptureDevice.
  - video_capture.mojom.DeviceFactory offers functionality similar to
    media::VideoCaptureProvider.
  - video_capture.mojom.Receiver offers functionality similar to
    media::VideoFrameReceiver.
* In the service implementation, use a VideoCaptureSystem instead of a
  VideoCaptureDeviceFactory directly.
* Add new adapter classes for plumbing between Mojo service and its usage in
  the native code.
* Re-enable existing video_capture_unittests and add a few more.

BUG=584797
TEST=
  service_unittests --gtest_filter="*Video*"
  content_unittests --gtest_filter="*Video*"
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"
TBR=emircan@chromium.org,ochang@chromium.org

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Review-Url: https://codereview.chromium.org/2843333006
Cr-Commit-Position: refs/heads/master@{#468024}

Basic dispatcher to help with ios/clean migration.  Handlers UrlLoader,
OmniboxFocuser and the WebToolbarDelegate, all used by the
GoogleLandingController.

BUG=694750

Review-Url: https://codereview.chromium.org/2829003002
Cr-Commit-Position: refs/heads/master@{#468023}

It's no longer part of the spec
(https://github.com/whatwg/fetch/commit/42464c)

intent-to-deprecate-and-remove
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/x3YXciXQWM0

BUG=645492

Review-Url: https://codereview.chromium.org/2591723003
Cr-Commit-Position: refs/heads/master@{#468022}

The throttling fix landed in https://codereview.chromium.org/2817603004/
has severely impacted rendering throughput due to the delay in
compositor round trips.  To avoid blocking the renderer script's
animation loop, we need to allow the rendering proceed when there
is still a pending frame.

BUG=716138

Review-Url: https://codereview.chromium.org/2848553003
Cr-Commit-Position: refs/heads/master@{#468021}

Followup for http://crrev.com/2844553003

R=dbeam@chromium.org
BUG=706310

Review-Url: https://codereview.chromium.org/2850663002
Cr-Commit-Position: refs/heads/master@{#468020}

Returns a specific error saying the keys are not available in the
signin profile.

BUG=715121
TEST=unit tests

Review-Url: https://codereview.chromium.org/2838423003
Cr-Commit-Position: refs/heads/master@{#468019}

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit

BUG=708584
R=gab@chromium.org
TBR=garykac@chromium.org

Review-Url: https://codereview.chromium.org/2846943002
Cr-Commit-Position: refs/heads/master@{#468018}