Commits · 8d7f254eb5df07d6601dd4b5bb0483ff82e3b2cc · eriksson monteiro / tangled

28 Sep, 2020 40 commits

Update the infra/config PRESUBMIT.py to 2.0.0. · 8d7f254e

Garrett Beaty authored Sep 28, 2020

Change-Id: I026f760b9d605d1ea29bd2a87b44990f5758a5ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432139Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811271}

8d7f254e

Roll Dawn from 145f115c5496 to 306fc502cf96 (2 revisions) · 1cbb099f

chromium-autoroll authored Sep 28, 2020

https://dawn.googlesource.com/dawn.git/+log/145f115c5496..306fc502cf96

2020-09-28 cwallez@chromium.org Use typed integers for the Fence FenceAPISerial
2020-09-28 cwallez@chromium.org Use typed integers for the Buffer MapRequestID

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I4e8238f44655cbed855d15e6be8ae8bb3ebd7b21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435488Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811270}

1cbb099f

[MBI]: Associate RenderFrameProxy with AgentSchedulingGroup · 7b6d1d4c

Dominic Farolino authored Sep 28, 2020

This CL associates RenderFrameProxy with AgentSchedulingGroup. It is a
prerequisite for making AgentSchedulingGroup a fully-fledged
RouteProvider and AssociatedInterfaceProvider.

See:
https://docs.google.com/document/d/1hnOeki8nNwZfVYi4vbid4kn12T7XS361uL0Zbb7ilSA/edit

R=haraken@chromium.org, kouhei@chromium.org, talp@chromium.org

Bug: 1111231, 1132901
Change-Id: Icb50fd9d11e7c53459172be86ca7834cad1a522f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432866
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Tal Pressman <talp@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811269}

7b6d1d4c

cbui extensions: remove close button from extension install prompt · aa009c1e

Elly Fong-Jones authored Sep 28, 2020

Bug: 1121927
Change-Id: I5abc297d2d5573d2e6dd8a887e29b9efbd573f1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422465Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811268}

aa009c1e

Updates to Clang Sheriff guide · 84ed9618

Adrian McCarthy authored Sep 28, 2020

* De-emphasize Sheriff-O'-Matic
* Add bug search link for sheriff handoffs
* Sheriff is the Lexan notetaker.

Change-Id: I58da53452bce1d59204bcebe473866a10e2043f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423750
Commit-Queue: Adrian McCarthy <amccarth@google.com>
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811267}

84ed9618

Disable SCTReportingServiceBrowserTest tests · 8246739f

Gayane Petrosyan authored Sep 28, 2020

TBR=estark@chromium.org

Bug: 1132860
Change-Id: Ibfa8c6c05d63dd868b2b6f310079ed60226bfa87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434099Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811266}

8246739f

Web Share: Only allow one share() call at a time · b73a88b6

Eric Willigers authored Sep 28, 2020

We update behavior to match spec change
https://github.com/w3c/web-share/pull/113

If a share() call is in progress and share() is called again,
the new share request fails immediately.

WebShare for ChromeOS and Windows will only ever have this
new behavior. WebShare for Android (already shipped)
would previously spin up multiple shares simultaneously.

Spec:
https://w3c.github.io/web-share/#share-method


Note: we no longer have an Android post Lollipop MR1
test for user cancellation of the dialog - the existing
test simply issues a second share request.

Bug: 1002337
Change-Id: I1bef4923cb048a28f882f9dac889c841f1fc8265
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425933Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811265}

b73a88b6

Import wpt@cdd3334e94c8543a61e116eb4f11736b9d7577d2 · 3e754ec3

Chromium WPT Sync authored Sep 28, 2020

Using wpt-import in Chromium 40d727bf.
With Chromium commits locally applied on WPT:
74e4b2fc "[COOP] access reporting: Use infinite timeout for receive."
9a583fa4 "Increase timeout of Content-Security-Policy WP test"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
nzolghadr@chromium.org, yosin@chromium.org:
  external/wpt/input-events

NOAUTOREVERT=true
TBR=robertma@google.com

No-Export: true
Change-Id: Ib7f62e7743459b1613c696dfed364f7c3761eb0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435659Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811264}

3e754ec3

Enable ink overflow DCHECK in SelfAndContents · ed2e4246

Koji Ishii authored Sep 28, 2020

Following up r811190 crrev.com/c/2433926 that enabled DCHECK
in |Self| for block fragmentation, this patch enables the
same DCHECK for |SelfAndContents|.

This DCHECK was added recently, at r811125
<crrev.com/c/2428530>.

Bug: 1132619
Change-Id: I45855e1d421cad90db135256745f9b92ab7621dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432148
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811263}

ed2e4246

Roll Chromite from ea1181f182dc to def823dfb288 (6 revisions) · 5a1d3bbf

chromium-autoroll authored Sep 28, 2020

https://chromium.googlesource.com/chromiumos/chromite.git/+log/ea1181f182dc..def823dfb288

2020-09-26 chrome-bot@chromium.org Update config settings by config-updater.
2020-09-26 chrome-bot@chromium.org Update config settings by config-updater.
2020-09-25 saklein@chromium.org BuildTargetUnitTest: Only use package atoms, not cpf.
2020-09-25 saklein@chromium.org api/validate: Add require_each validator.
2020-09-25 saklein@chromium.org api: refresh proto & fix payload unittests
2020-09-25 saklein@chromium.org api/controller: Remove redundant python version checks.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Tbr: chrome-os-gardeners@google.com
Change-Id: I06b168ba3a11c18b9315b3ac2d33249d1ca0ca23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435633Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811262}

5a1d3bbf

[iOS][Credential-Provider] Support Android Passwords · 77e6149b

Javier Ernesto Flores Robles authored Sep 28, 2020

Inject Android affiliation information and add Android credentials to
the credential provider extension.

Bug: 1090776
Change-Id: I2eea32a569203076214c8fa0a2ee70581bade3ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424201
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811261}

77e6149b

Enable test for persistent overlays · b37c27dc

Alex Rudenko authored Sep 28, 2020

The test has been implemented in [1] and now, when DevTools rolled,
it can be enabled.

[1]: crrev.com/c/2400478

Bug: 1109224
Change-Id: I43e4dffbf7d50eae856b5c78290768079094ab69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435188Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811260}

b37c27dc

Use c++11 cast · cf81a085

Mitsuru Oshima authored Sep 28, 2020

Bug: None
Change-Id: I793a6870e81b2f5f50bc8341f45f30829dc40260
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433585
Auto-Submit: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811259}

cf81a085

Revert "Introduce ScriptEvaluationResult" · 44541a20

Gayane Petrosyan authored Sep 28, 2020

This reverts commit 3a4677f6.

Reason for revert: bot failures due to crash at blink::AnimationWorkletGlobalScopeTest::RunScriptAndGetBoolean()
see https://crbug.com/chromium/1132893

Original change's description:
> Introduce ScriptEvaluationResult
>
> This CL introduces ScriptEvaluationResult with clearer uniform
> semantics that covers both classic and module script evaluation.
> ScriptEvaluationResult has ResultType enum class, to explicitly
> distinguish cases where normal exceptions are thrown (kException)
> from cases where not (kNotRun and kAborted).
>
> This CL merges ClassicEvaluationResult and ModuleEvaluationResult
> into ScriptEvaluationResult.
>
> This maps:
> - ClassicEvaluationResult::IsEmpty()
>   => ScriptEvaluationResult::GetResultType() != kSuccess
> - ModuleEvaluationResult::IsSuccess() / IsException()
>   => ScriptEvaluationResult::GetResultType() == kSuccess / != kSuccess
>
> To keep the invariant of kSuccess <=> non-empty v8::Value,
> this CL makes ModuleRecord::Evaluate() to return
> ScriptEvaluationResult with a non-empty value
> on successful evaluation + top-level await is not enabled,
> while previously it returned ModuleEvaluationResult::Empty().
> This value is not used, and thus this change doesn't change
> the behavior.
>
> Bug: 1111134, 1129743
> Change-Id: I350860171a3c3b63517641dfb9555b8788386438
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417789
> Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811244}

TBR=yukishiino@chromium.org,bashi@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,nhiroki@chromium.org,cbruni@chromium.org,dom@chromium.org

Change-Id: Iaaca1345213b1f3e4fc8ec703257217998ec0826
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1111134
Bug: 1129743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435918Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811258}

44541a20

android: create cache dir if needed. · 8a7b843c

Torne (Richard Coles) authored Sep 28, 2020

When using a subdirectory of the Android cache dir (e.g. in WebView),
explicitly create the directory in PathUtils instead of relying on any
user of the directory creating it implicitly.

Set the directory mode to 02700 which is what it currently gets set to
when created implicitly.

Fixed: 963640
Change-Id: I8e1c140241d6a2decfcd27186b767ef05e7a4320
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432447Reviewed-by: Anna Malova <amalova@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811257}

8a7b843c

[CORS-RFC1918] Add per-request ClientSecurityState. · 97d9fd6f

Titouan Rigoudy authored Sep 28, 2020

For subresource URL requests, the renderer URLLoader uses its factory's
parameters to determine the client security state of the request
initiator. Navigations however use a central URLLoaderFactory in the
browser process.

This change introduces a new trusted parameter in ResourceRequest
specifying the client security state applying to the current request,
if not was set in the factory parameters.

Regarding //services/network and BUILD.gn changes in particular:

A lot of these changes stem from the introduction of ClientSecurityState
as a new dependency of url_loader.mojom and URLRequest's typemap,
ResourceRequest. This breaks the existing layering scheme:

  mojom:url_loader_base
   -> cpp:cpp_base

Because suddenly cpp:cpp_base must depend on mojom:url_loader_base for
client_security_state.mojom.h. We break the cycle by extracting the
dependency of mojom:url_loader_base from cpp:cpp_base into its own build
target:

  cpp:cpp_base
   -> mojom:url_loader_base
     -> cpp:cross_origin_embedder_policy

Bug: chromium:1124346
Change-Id: Ie42d604b628a147a3963df0b20cc88b8b61bf98b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401523
Commit-Queue: Titouan Rigoudy <titouan@chromium.org>
Auto-Submit: Titouan Rigoudy <titouan@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811256}

97d9fd6f

Disable iframes filtering feature for supervised users · 9e410191

Aga Wronska authored Sep 28, 2020

The feature has been disabled in Chrome OS < M87 with
Finch kill-switch and in this cl we apply the same change
in Chromium repo.

Bug: 1132862
Change-Id: I7c3446b6a6d7e4d06cdf2df5f12d6cf9eec4dc24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435721Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Yilkal Abe <yilkal@chromium.org>
Auto-Submit: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811255}

9e410191

Roll Skia from ad6aeace6eee to 59d660c075bd (2 revisions) · 86ca7ef6

chromium-autoroll authored Sep 28, 2020

https://skia.googlesource.com/skia.git/+log/ad6aeace6eee..59d660c075bd

2020-09-28 ethannicholas@google.com Revert "Revert "moved SkSL BoolLiteral data into IRNode""
2020-09-28 johnstiles@google.com Update OutParams unit test to demonstrate SkSL failure.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: brianosman@google.com
Change-Id: I58a2d4c4e667f379a145bd2816313123aa079d79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435628Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811254}

86ca7ef6

Update V8 to version 8.7.206. · 736cc4b7

v8-ci-autoroll-builder authored Sep 28, 2020

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/667efcdc..685e35de

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I1efc2ba62f0ebbb7588a76c4e37787ea0c8d4800
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435658Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811253}

736cc4b7

Revert "[Profile creation] Show sync confirmation and finish the flow" · 620e7244

Gayane Petrosyan authored Sep 28, 2020

This reverts commit b8368dd1.

Reason for revert: CreateSignedInProfile test causes failures on multiple bots
Bug: 1132882

Original change's description:
> [Profile creation] Show sync confirmation and finish the flow
>
> This CL proceeds with the happy path of the signed-in profile creation
> flow:
>  1) After a successful sign-in, the current WebUI for sync confirmation
>     gets displayed;
>  2) After choosing whether to sync, the flow is finished by opening a
>     browser window for the new profile.
>
> Error handling and restyling the confirmation page is left for follow-up
> CLs.
>
> Bug: 1126913
> Change-Id: I17b43fe4ec0c0e0f2f9725b1df8e8e59d2c35f3d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421592
> Commit-Queue: Jan Krcal <jkrcal@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811140}

TBR=droger@chromium.org,jkrcal@chromium.org

Change-Id: I89cf0130e744a1feee9649df1895839e0fe4b314
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1126913
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435330
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811252}

620e7244

[sync] Do not wait for TemplateURLService in unrelated tests · fea6d3ed

Mikel Astiz authored Sep 28, 2020

This should make tests slightly faster in general, but in particular
they may help on Mac where the wait contributes to flakes.

Change-Id: I7b8711676123a7fd1ce58505dffbd29f4043b482
Bug: 1131588
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434329
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811251}

fea6d3ed

Roll DevTools Frontend from ba3d5932bb28 to 58ceb60bf6b1 (2 revisions) · 2804fdc6

chromium-autoroll authored Sep 28, 2020

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ba3d5932bb28..58ceb60bf6b1

2020-09-28 tvanderlippe@chromium.org Move compiler options into tsconfig.base.json
2020-09-28 bmeurer@chromium.org Improve error reporting for the language plugins.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1132281
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I99168aaa966b0e9f201a9c4913a5b555b592887e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435621Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811250}

2804fdc6

[COOP] access reporting: split property.https.html test. · 6bdcd688

arthursonzogni authored Sep 28, 2020

Since:
https://chromium-review.googlesource.com/c/chromium/src/+/2428976
the "receive" timeout is now infinite. It means all the tests in
property.https.html will either all succeed or if one of them fails, it
will timeout.

This patch split the test in order to get individual results. This
allow us to prevent individual regression.

Bug: 1090273
Change-Id: I5629e4130dbabde44755468bc7b28ea0d0e802f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435638Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811249}

6bdcd688

Wire GPU workarounds for VEA and VDA. · d90bffb2

Chunbo Hua authored Sep 28, 2020

Bug: 1129754
Change-Id: I6e9c50880541095008f8b71d25455e9a59128f77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397669Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Chunbo Hua <chunbo.hua@intel.com>
Cr-Commit-Position: refs/heads/master@{#811248}

d90bffb2

UnownedUserDataKey: Refactor lambda -> loops · 99b3028b

Andrew Grieve authored Sep 28, 2020

Noticed this in binary size review as having a lot of nested classes.
Also removes most explicit null checks in favor of implicit ones.

Bug: None
Change-Id: I9777788512371b497c4236f16073a2b342e1acb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419121Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811247}

99b3028b

Revert "Instrument access to HIDDevice and HIDReportItem fields." · 06655eb1

cfredric authored Sep 28, 2020

This reverts commit 35a98eb4.

Reason for revert: HIDDevice is a "leaf" API, so we should instrument
via navigator.hid.getDevices() instead.

Original change's description:
> Instrument access to HIDDevice and HIDReportItem fields.
>
> This cl causes the bindings generator to automatically collect UKM when
> these attributes are accessed. This will be used to analyze how much
> entropy leaked by this API can be used for cross-site tracking.
>
> Change-Id: I25fddca92048669e25674070b0f619368270346c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424073
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Chris Fredrickson <cfredric@google.com>
> Cr-Commit-Position: refs/heads/master@{#809753}

Change-Id: I48f17cb23f3ba7fe7d31be78d6549127f6186fa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432666
Auto-Submit: Chris Fredrickson <cfredric@google.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Chris Fredrickson <cfredric@google.com>
Cr-Commit-Position: refs/heads/master@{#811246}

06655eb1

Reenable/update tests after Skia roll (https://crbug.com/skia/10744 ) · e8dfac2e

Fredrik Söderqvist authored Sep 28, 2020

SkPictureImageFilter (as wrapped by RecordPaintFilter) now returns the
specified target/crop rect when mapping forward.

Adjust DiscardableImageMapTest.CapturesImagesInPaintFilters to reflect
this, changing the size of the RecordPaintFilter target rect to better
show that it is being applied.

Bug: skia:10744
Change-Id: I62378591dcf30694d6fe5b2d68eb31d22f2d71f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431489Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#811245}

e8dfac2e

Introduce ScriptEvaluationResult · 3a4677f6

Hiroshige Hayashizaki authored Sep 28, 2020

This CL introduces ScriptEvaluationResult with clearer uniform
semantics that covers both classic and module script evaluation.
ScriptEvaluationResult has ResultType enum class, to explicitly
distinguish cases where normal exceptions are thrown (kException)
from cases where not (kNotRun and kAborted).

This CL merges ClassicEvaluationResult and ModuleEvaluationResult
into ScriptEvaluationResult.

This maps:
- ClassicEvaluationResult::IsEmpty()
  => ScriptEvaluationResult::GetResultType() != kSuccess
- ModuleEvaluationResult::IsSuccess() / IsException()
  => ScriptEvaluationResult::GetResultType() == kSuccess / != kSuccess

To keep the invariant of kSuccess <=> non-empty v8::Value,
this CL makes ModuleRecord::Evaluate() to return
ScriptEvaluationResult with a non-empty value
on successful evaluation + top-level await is not enabled,
while previously it returned ModuleEvaluationResult::Empty().
This value is not used, and thus this change doesn't change
the behavior.

Bug: 1111134, 1129743
Change-Id: I350860171a3c3b63517641dfb9555b8788386438
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417789Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811244}

3a4677f6

Android: Introduce "mergeable_android_manifest" for Android targets · 36e2f31e

Andrew Grieve authored Sep 28, 2020

And refactors how input_jars_paths and proguard_configs works a bit.

You can now any put any of these variables on any java target's
build_config.

Bug: 1105693
Change-Id: I332c0ea5637eb7778a12d1ddca3b5fddd54f308f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431788
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811243}

36e2f31e

[PTZ] Deny mandatory PTZ constraints in basic getUserMedia constraints · e3d45995

Francois Beaufort authored Sep 28, 2020

This PR makes sure required PTZ constraints in the basic constraint set
are denied (and throw a TypeError) and PTZ capability constraints
({ zoom: true } etc.) are ideal in the basic constraint set.
Therefore, a PTZ constraint in the basic set cannot cause getUserMedia()
to fail conditionally.

Spec:
https://github.com/w3c/mediacapture-image/pull/261
https://github.com/w3c/mediacapture-main/pull/707/

Bug: 934063
Change-Id: I7324ae32b064dbf3b89325166834e2694eca593b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411946
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Eero Häkkinen <eero.hakkinen@intel.com>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811242}

e3d45995

Convert base::Closure to base::OnceClosure · 666de7af

Andrew Shulaev authored Sep 28, 2020

Context: https://docs.google.com/document/d/1J4N3V5UmzZL9BZGNrn95E4xJu4cz3ynbg21zXR-J_qA/edit#

Bug: 1007635
Change-Id: I28ba29b8360f030f62945b351555cbea69127482
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435641Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Andrew Shulaev <ddrone@google.com>
Cr-Commit-Position: refs/heads/master@{#811241}

666de7af

[iOS][OpenIn] Adds unit tests · 9b3fdb53

Ewann authored Sep 28, 2020

This CL adds parametrized tests in order to be able to test the different file types added with the kExtendOpenInFilesSupport feature.

Bug: 1117398
Change-Id: I1c7fc04cc9ce2c0ac2f9f6a135b50fea524f2267
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379716
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811240}

9b3fdb53

Revert "Add autoplay parameter to navigations." · 10565066

Gayane Petrosyan authored Sep 28, 2020

This reverts commit 1b36f1a7.

Reason for revert: causes weblayer_browsertests failure
Bug: 1132848

Original change's description:
> Add autoplay parameter to navigations.
>
> Bug: 1131881
> Change-Id: Ia152dc0a76d1f9ad6eff87f74fef2ad17b327b91
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432755
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#810932}

TBR=sky@chromium.org,jam@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1131881
Change-Id: Id853eaab83af2bc6cf4392a12d3b104bf6652442
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435718Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811239}

10565066

Disable css-rule-hover-highlights-selectors.js for DevTools roll · 47481387

Alex Rudenko authored Sep 28, 2020

Refactoring done in [1] is changing the internals of the overlay
that the test intercepts. This CL disables the test temporarily
and modifies it to intercept the new function. I have verified
that the test is passing with the new changes in [1].

[1] https://crrev.com/c/2429775

Bug: 1131801
Change-Id: Ibd586a7435270aed3c82c5b1e26946d75fd37043
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435644Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811238}

47481387

[Android][Signin] Add observer to listen to monogram update · a5707a7d

Alice Wang authored Sep 28, 2020

This CL adds an observer to update ProfileDataCache when user's profile
photo(include monogram) from IdentityManager is updated.

Bug: 1127886
Change-Id: I0c70f72708e50dceb63eb122055315f7818cba06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430984Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811237}

a5707a7d

Initialize WebStateListMetricsBrowser after SessionRestorationBrowser · c243c5e7

Olivier Robin authored Sep 28, 2020

WebStateListMetricsBrowser requires SessionRestorationBrowserAgent,
so it must be initialized earlier.

Also initialize WebStateListMetricsBrowser member variables that were
left uninitialized.

Bug: 1132784
Change-Id: I28b9d5afca58870a6273eb1c3b3418a45c9fcd69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435344
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Auto-Submit: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811236}

c243c5e7

Added new response builder to process responses · 5a9ab966

Mohamed Adel authored Sep 28, 2020

The newly added response builder returns an NSDictionary that can then
be used to process the notification and to handle interactions with it.

Bug: 1131515
Change-Id: I81703650acde994c287945cc8f6a323b1bc18c2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426586Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Commit-Queue: Mohamed Adel <adelm@google.com>
Cr-Commit-Position: refs/heads/master@{#811235}

5a9ab966

[iOS] Add Recent Tabs Context Menu EG Tests · 4d9dfce6

Sebastien Lalancette authored Sep 28, 2020

These tests cover both Recent tabs from Settings as well as from the Tab
grid. They test the Copy link, Open in New Tab and Share
functionalities.

Also disabling drag-and-drop in Recent Tabs when EarlGrey tests are
running. This fix is temporary as the EG team is working on resolving
the problem. Clean-up is being tracked in:
crbug.com/1129058

Bug: 1131831
Change-Id: I61e069102e7932e9b51860e82f0eeedbcd0459c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431786
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811234}

4d9dfce6

Update user_and_device_reporting policy descriptions · da567824

Chris Sharp authored Sep 28, 2020

Bug: 1018157
Change-Id: Ic655bd6062ee95ba1bc2e11d0b77bdac10fc322c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347036Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811233}

da567824

[Payments][Metrics] Extend expiry for ever-green metrics. · dc61429b

Danyao Wang authored Sep 28, 2020

Also updated ownership.

Bug: 1128111
Change-Id: Iba6ba54d4a47e02579faa69ff7078ba6ab012333
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426977
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811232}

dc61429b