- 23 Sep, 2020 40 commits
-
-
Domenic Denicola authored
This illustrates the issue in https://crbug.com/1099718. Bug: 1099718 Change-Id: Ie27df0a2cd5f62370332b318726bc10f965efe85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270626Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#809886}
-
Brandon Wylie authored
Bug: 1131545 Change-Id: I9617e2d26f7acd50b44a9151927aff6713cdab28 TBR=wychen@chromium.org Change-Id: I9617e2d26f7acd50b44a9151927aff6713cdab28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426489 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#809885}
-
Gabriel Marin authored
Precise attribution at instruction level helps to better understand hostspots in assembly view. Updated a few unit tests to check for the right UMA metric being incremented. BUG=b:168312716 Change-Id: I537395d5ec6714c75b4224765ebc247a6ba00ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424517Reviewed-by:
Gabriel Marin <gmx@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#809884}
-
Aaron Leventhal authored
Bug: 1131380 Change-Id: I04477396fa11afb24a89c1447e799880c857b512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426248 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#809883}
-
Eugene But authored
I learned what I want from this histogram Bug: 1117138 Change-Id: Iae2d2a95b55103f91fed2dead8c7a5bd5401af12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425011 Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#809882}
-
Aaron Leventhal authored
Bug: 1131437 Change-Id: Idf5017d82261bad5ff933b45acb54309c2eb7771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426764 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#809881}
-
cfredric authored
These lines were generated by running the following script, then running tools/metrics/histograms/update_use_counter_feature_enum.py: import sys startingValue = int(sys.argv[1]) numEntries = int(sys.argv[2]) for i in range(startingValue, startingValue + numEntries): print(' kIdentifiabilityStudyReserved%d = %d,' % (i, i)) Bug: 973801 Change-Id: I99144faf9ff05a731d08813472aab8aa8f23c008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425338Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#809880}
-
Elly Fong-Jones authored
They are too slow to run reliably in that config. Bug: 1131570 Change-Id: Id1c94616cd982d66c5c5970d08d24e47db6f2c1e Tbr: yunkez@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426491Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#809879}
-
Bence Béky authored
Change-Id: I7e9d87f3f88a3d38ee5b99c85fa3e64b06682e5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425844 Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#809878}
-
Jeff Yoon authored
enable_widevine_cdm_host_verification = false was missing from GN args for PGO Mac bots, which is causing build failures. Bug: 1128810 Change-Id: I2ccd1db80e80fd983e5f4ef0bd63908281557a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425846 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Auto-Submit: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#809877}
-
Kevin Marshall authored
This is a reland of 54ad18ef Removes the Vulkan validation library from the exclusion list, since it is not reliably present across all build configurations. Original change's description: > [fuchsia] Exclude SwiftShader and Vulkan libs from CastRunner. > > Removes large libraries that were pulled in as a result of an indirect > but necessary dep on Blink. > > The exclusions can be removed along with the Blink MessagePort > dependency, once a fix for crbug.com/1126571 lands and is > integrated with NamedMessagePortConnector. > > Bug: 1131102 > Bug: 1126571 > Change-Id: I7b25d50470d667f44424b925d3982efa268c24ae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424512 > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809544} Bug: 1131102 Bug: 1126571 Change-Id: I3a464a21cd8b9f2c958d4243a01785ac39f7eaab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424990Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#809876}
-
Kent Tamura authored
This CL ports a logic in LayoutFlexibleBox::BaselinePosition() to LayoutNG. This CL has no behavior changes because input[type=range] still uses the legacy layout. Bug: 1040826 Change-Id: If40a81d75b9fecd02c3b924501258da94b2d2369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423679 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#809875}
-
Mugdha Lakhani authored
Introduces a new component for BackgroundSync so code can be shared with WebLayer. Migrates BackgroundSyncPermissionContext and its unittest. Bug: 1087486 Change-Id: Ib2968305dfa674eec81985f4ae19780ca5d6d9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421491Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#809874}
-
Oleg Davydov authored
DeviceOffHours policy operates with a "real" clock: it has to know the exact time (day, hours, minutes) to make a decision. One of things which affect real clock is suspend: from software's perspective it's a jump into future. Therefore DeviceOffHoursController caught OnSuspendDone event from the power manager to reschedule its timer. WallClockTimer is the class which automatically reschedules after suspend, therefore instead of duplicating this logic in DeviceOffHoursController we can just reuse WallClockTimer. Also this CL makes a number of changes in tests: * An access method for fake power manager client is removed from DeviceSettingsTestBase, as tests for DeviceOffHoursController were the ones which used it. * DeviceSettingsTestBase now has an additional constructor to override time source (mocked or system) for task environment it creates. This is needed because we have to mock time to test suspend, but not all other tests support mocked time. More on that in https://crbug.com/1129894. * CheckSendSuspendDone test for DeviceOffHoursController is renamed to CheckUnderSuspend, since it simulates suspend, not only checks that sending OnSuspentEvent to DeviceOffHoursController may trigger the update. Bug: b:160682243 Change-Id: I403964452e5eeb7470fd731e6760b7b0dec27456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418816Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#809873}
-
Peng Huang authored
For remote desktop environment, when Vulkan is used, VANGLE is only used for WebGL. It is not responsible for rendering to the native windows (we will not create GLSurfaceEGL for native windows). We will use Vulkan swapchain to render on native windows. However some Vulkan drivers (NVIDIA) cannot be initialized successfully, if the $DISPLAY env variable is set, but the Xserver(remote desktop Xserver) doesn't have necessary extensions (NV-CONTROL, NV-GLX). To workaround this issue, this CL unsets the $DISPLAY env variable before initializing VANGLE and sets it back after it, if the Xserver doesn't support vulkan swapchain. Change-Id: I528a6f7d2f618123ea519f0ab4f15e788c4dd607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424519Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#809872}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I98fc3ffa4818417fc02a92407dbf35eff8c8f601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424715 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#809871}
-
Thomas Lukaszewicz authored
Add a FlexLayoutView with the various setters and getters for the FlexLayout exposed as View properties. Bug: None Change-Id: Id4380e9353c7f47774ac35a074559dc31492ab77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419135Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#809870}
-
Garrett Beaty authored
The recipe-side config for the mojo builders has already been copied to the new builder group. Bug: 1131163 Change-Id: Id1d01ccdac7f242e347db02586b04bb6927b9e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427123 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#809869}
-
Kent Tamura authored
The crash is similar to crrev.com/806062. In this case, both of |line_width| and |item.InlineOffset()| are saturated to LayoutUnit::Max(), then later width computation didn't work well. This CL fixes the crash by checking the saturation, and also adds vector index checking to prevent similar issues. Bug: 1129570 Change-Id: I7b019fb09dda68b24a70cc6f4865dfa22a70ded1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423759 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#809868}
-
Chris Thompson authored
This implements sending new SCT audit reports to the Safe Browsing servers for opted-in users. The SCTAuditingCache now sends reports using a SimpleURLLoader when new reports are sampled for sending to Safe Browsing. This reporting is configured by the SCTReportingService via a new NetworkService::ConfigureSCTAuditing() API. This redesign eliminates the round-trips between the network service and the browser process entirely by having the SCTReportingService configure which network context (and URLLoaderFactory) the SCTAuditingCache should use to send reports (in this case, we use the system network context). This also: - Removes the OnSCTReportReady Mojo API. - Moves the feature flag for opt-in SCT auditing from services/network/ into chrome/ now. - Adds the network traffic annotation for opt-in SCT auditing. - Extends the existing SCTReportingService browser tests to track whether reports sent their results to the reporting server. - Adds unittests covering reports being sent. - Adds an optimization where empty reports are stored for reports that we do not sample (and thus will never be sent to the server), rather than storing the full report object. Bug: 1082860 Change-Id: I29fd0ee1cb9c2d5c850601e0b54203363d4f8282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331755Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#809867}
-
Yulun Wu authored
ZergoQuerySearchBoxColor should be deprecated and kSearchBoxBackgroundDefault should not be used outside of the SearchBoxViewBase constructor. Bug: 1131223 Change-Id: I1f2497618d3c3bfd0fdb93c6b0f162873a2b2111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425623Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809866}
-
Elly Fong-Jones authored
Bug: 1131551 Change-Id: Ia0b99ed3a98680c7add4afe2b4f8e104d5689fda Tbr: enne@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425847Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#809865}
-
Dave Tapuska authored
This reverts commit 5aca1315. Reason for revert: TabSearch On Mac was fixed separately not needing this revert. Original change's description: > Revert "Remove a few conversion methods on WebWidgetClient." > > This reverts commit 08741021. > > Reason for revert: Breaks TabSearch on Mac. See http://crbug.com/1131162 . > > Original change's description: > > Remove a few conversion methods on WebWidgetClient. > > > > Use the WidgetBase implementations instead of going via the > > WebWidgetClient. > > > > BUG=1097816 > > > > Change-Id: Ib08b5748806fe3862ac291d354043326d3172282 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419129 > > Reviewed-by: danakj <danakj@chromium.org> > > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#809421} > > TBR=danakj@chromium.org,dtapuska@chromium.org > > Change-Id: I4a5f560c73177acfa6d01464bc37eade2a87af62 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1097816, 1131162 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424494 > Reviewed-by: Robert Liao <robliao@chromium.org> > Commit-Queue: Robert Liao <robliao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809488} TBR=danakj@chromium.org,robliao@chromium.org,dtapuska@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1097816 Bug: 1131162 Change-Id: I6cd02e4003b5f1dfccf3750a601704627e2f2cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425398Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#809864}
-
sandromaggi authored
The definition states that the icon to activate is its index, not index +1. Bug: b/168611883 Change-Id: I83349198e0ca4b555e01e7d0a713d5ce580ef41b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424138 Auto-Submit: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#809863}
-
Matthew Mourgos authored
This change adds a new announcement which occurs when chromevox is enabled and an app list item with a notification badge is focused. Bug: 1126492 Change-Id: If581feecd46141dfa5027349c6e55575829d6b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423054Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#809862}
-
David Benjamin authored
The sheet is currently being drawn on a transparent overlay when using remote Cocoa (e.g. PWA windows), which results in a number of UI issues. This was exacerbated by https://chromium-review.googlesource.com/c/chromium/src/+/2324112. Instead, add a ShowCertificateViewer() Mojo call and move the implementation to NativeWidgetNSWindowBridge. Along the way, simplify the implementation. We can now largely rely on Cocoa's built-in lifetime management for the SFCertificatePanel. Bug: 916815, 1130490 Change-Id: Ia33102417510d7c0fc6fb09cf55d9fa61efdfdff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421633Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#809861}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I9c3b6f06e7fd5c9e1bec009e0845bbbe2668bf67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424886 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#809860}
-
Wenyu Fu authored
Changing fonts to fix the glitch on the welcome screen, as Google Sans might be not available yet for the first screen. Bug: 1119990 Change-Id: Ia0e939c651b105357215357db6038ab2d10a5031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425383 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#809859}
-
Peter Wen authored
Previously, blanket suppressions were added due to lint not working. Now that android lint is working well again, we no longer need these blanket suppressions. They have been removed/fixed/or moved to the specific files that require them. Bug: 1044658,1116130 Change-Id: I249afb500c49c13f35880311d04c51391ed8cbfa Fixed: 1044658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424543 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#809858}
-
Tim Volodine authored
Extend expiration milestone for InertialSensor.* histograms. BUG=1088842 Change-Id: I890a9c2a139d123d4a9fca281067b219f5fb3997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424087Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#809857}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I627e1f0156ad7fbefadd58d832e67d121a28dc13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424505 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#809856}
-
Alan Cutter authored
This change migrates Callbacks in extensions::Blocklist to OnceCallbacks. Bug: 1007786 Change-Id: If463e8b8fb776bfd1b5fdaae5b415c0216f6419e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425863 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#809855}
-
Sammie Quon authored
Test: added Bug: 1111445 Change-Id: I0f79be1c09d4ef0eeff276e3c50f491efbe56244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380517Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#809854}
-
Ken Rockot authored
This does not implement any support for 5G detection, but merely introduces the new enum value and ensures that consumers of the ConnectionType enum are aware of its existence. Bug: 1127134 Change-Id: I7fcc214958ad8a8132ac5b062b8af3559622b7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425164Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#809853}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I39f8d765f841aae135ed543f9fc2238ec8a1837e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422184 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#809852}
-
Ian Clelland authored
With an upcoming change to Feature/Permissions Policy, the header alone will no longer be sufficient to delegate permissions to use powerful features in subframes. The iframe allow attribute must be used in conjunction with it. The header can still be used to block delegation. This change updates the screen wake lock WPTs to use the allow attribute for delegation. Bug: 1095641 Change-Id: Iecc6d0ce8840013c9dc570e76b1c02510eb89fef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424633 Commit-Queue: Ian Clelland <iclelland@chromium.org> Auto-Submit: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#809851}
-
Stephen McGruer authored
Bug: 1127055 Change-Id: I3d44e0aecc593e4cb385c65461731d0f4a461bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425459Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#809850}
-
dizg authored
to support Preserve mode correctly. Bug: 1122988 Change-Id: I2ec59f32a0e8c7b050300b78fe6336c1b12c2c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395403 Commit-Queue: Diana Zagidullina <dizg@google.com> Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#809849}
-
Mustafa Emre Acer authored
Delayed Warnings feature delays certain interstitials until the user presses a key. It presently ignores ESC key as it can be used to exit from fullscreen mode. The user can also use browser shortcuts such as Control+T to open a new tab. This CL allows modifier keys (Control, Alt etc) so that browser shortcuts don't show the interstitial. There are two exceptions made by the CL: - Shift pressed with other character keys still show the interstitial as the user may be typing uppercase letters. - Ctrl+C and Ctrl+V still show the interstitial as they are shortcuts for copy & paste. Bug: 1131149 Change-Id: I5d3532b9296beef783e01e18d14e0b7a53309fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425206Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#809848}
-
cfredric authored
This cl causes the bindings generator to automatically collect UKM when these attributes are accessed. This will be used to analyze how much entropy leaked by this API can be used for cross-site tracking. Bug: 973801 Change-Id: I29ea7ee1796c8152cab9f004229282b1b728b173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421638 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#809847}
-