- 31 Aug, 2020 40 commits
-
-
Wojciech Dzierżanowski authored
`player_id_` identifies MediaSessionControllers in MediaSessionImpl. The possibility to mutate it left the door open to failing to unregister a MediaSessionController from MediaSessionImpl on destruction. That could lead to a use-after-free of MediaSessionController in MediaSessionImpl. Bug: 1115478 Change-Id: Ib309b09345be9c6da2668a40100297942118b578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353250 Auto-Submit: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#803179}
-
Jonah Ryan-Davis authored
Since this bot has low capacity, we can try to keep the testing load a little lower. We choose to only test the validating command buffer with webgl2 tests, and the passthrough with webgl1. Also, we don't need to duplicate SwANGLE testing here since it's likely to be the same on any Mac. Bug: chromium:850252 Change-Id: Ib912758efb5e352cc746553f0a3c8d6ee9947cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363831Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#803178}
-
Nicolas Arciniega authored
This patch adds the right dependency to fix the build error described by the below bug. Bug: 1122770 Change-Id: I943e10ef4b10750d01bd4c1ce47bc9f4f0e0816c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368455Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Nicolas Arciniega <niarci@microsoft.com> Cr-Commit-Position: refs/heads/master@{#803177}
-
Kyle Horimoto authored
Before this CL, Phone Hub results would show up when searching within settings, even if the feature flag was disabled. This CL fixes this issue by checking the flag value before adding search tags. Bug: 1106937, 1123607 Change-Id: If0bd1ea23864ef9634db608c35dbd03571e332b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385781 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#803176}
-
Leonard Grey authored
Follow-up to r801401 (thanks, mehmet@!) Bug: 635853 Change-Id: I9c49650b2d6ab52b342d4aeea7771ff2abb85ca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380734Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#803175}
-
Shubham Aggarwal authored
This CL changes the behaviour of FileReader so that the result attribute is only set right before the Load event is fired. The existing web tests that covered this behaviour have their expected result changed to now be passing (the expectation file was deleted as all tests now pass). The CL also removes the kFileReaderResultBeforeCompletion feature which measured how often the result attribute was accessed before load. This feature is no longer needed. Change-Id: Ide34aa7ebe5d4caadc2c40821b1eb7cbbe7e91d7 Bug: 768972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352610Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
-
Mohammad Refaat authored
I own most of Cookies related code in the codebase, and i created system_cookie_store_util which was moved in this directory. Change-Id: Ib025b980c111f528cd0180a16a82909a70eec305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382875 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#803173}
-
Jonathan Freed authored
Bug: 1122409 Change-Id: I2f732f6ec8344dd0c91ed2935d1e8d434e425503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385756 Commit-Queue: Jonathan Freed <freedjm@chromium.org> Auto-Submit: Jonathan Freed <freedjm@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#803172}
-
Nela Kaczmarek authored
[Passwords] Affiliation Service - change SchemeHostPort to GURL type for parameters in public methods. Changes type of parameters in public methods of Affiliation Service from SchemeHostPort to GURL. This change makes AffiliationService compliant with the public interface of ChangePasswordUrlService. Bug: 1108279 Change-Id: I2b59560f991176ac94ac9a57cc2db5577bd72ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379717Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Cr-Commit-Position: refs/heads/master@{#803171}
-
Vladimir Levin authored
This patch adds two use counters to count 1. The number of times we have strict containment on an element and no content-visibility 2. The number of times we have strict+style containment and no content- visibility. The second case is a potential optimization for having an effective content-visibility (ie just skip the work automatically) The first one is more likely to be present and it _can_ be used as a content-visibility style optimization if there are no counters present on the page (or in the subtree, which is harder to check). R=chrishtr@chromium.org Change-Id: I9243a4d03217b661cb3be4cb12549a61d7e95092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382403 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#803170}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c73782c8d8ff..6c37d40bb531 2020-08-31 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I3a5e02bd415f832ef6bb8e7e9984a4ed06690acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385677Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803169}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I2fdbfa0eac5fec5e3d995888ce830bece01e02cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382815Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803168}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Nightly/media_app_202008310800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/qWERs0_B9Z--fvL8HtwVcESrcvhGQn_WW5tYzLXvrvsC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/166192181 Tbr: media-app@grotations.appspotmail.com Change-Id: I06dbf15f34c21c0d9e23ed39cb5046cd444e9d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385675Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803167}
-
Xianzhu Wang authored
This is consistent with the chromium feature which is disabled by default and is enabled when "experimental web platform feature" is enabled [1]. This prepares for letting blink feature status override chrome's default feature status. [1] https://source.chromium.org/chromium/chromium/src/+/master:content/public/common/content_switch_dependent_feature_overrides.cc;drc=02fc05043bd38d318ba9ce59ccc4c7602284f990;l=56 Bug: 1121839 Change-Id: I92b7c68ce409971ef920ce00cb0951600547ef57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382486Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#803166}
-
Andrew Xu authored
This CL does the following changes: (1) Implementing the logic of item deletion. (2) ClipboardHistoryController does not cache the clipboard history items anymore. This CL should be landed after https://crrev.com/c/2370656 Bug: 1112888 Change-Id: Id6b128f7903f814fd13aeb53f2832a4bbd06c3b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378401 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#803165}
-
Jérôme Lebel authored
AccountConsistencyService::active_cookie_manager_requests_for_testing_ is not set to 0. AccountConsistencyServiceTest fails. Related to crrev.com/c/2346664 Fixed: 1123568 Change-Id: If9842d57daef2bcc4e3c365ada38d5668ddbcc69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385516 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#803164}
-
Alice Wang authored
This CL uses correct warning icon for sign-in general error and adds render tests for the sign-in general error view. Bug: 1120308 Change-Id: Ie25b8be7fca803ea49dfbc855dac41bc2bd89f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379751Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#803163}
-
James Vecore authored
Bug: b:154865204 Change-Id: I0edd7de777ecdcade982e9dadb30449d0c4b5b77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385875Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#803162}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6ec0b23923e9..7b5439987f75 2020-08-31 jmadill@chromium.org Remove Vulkan repos from export targets ignore list. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: Ie5f8754241736c00e24cb3d542a67f17c7d96ee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385679Reviewed-by:
-
Roberto Moura authored
- Add the thumb strip coordinator to the browser coordinator. - Add a reference to the thumb strip pan handler inside the BVC so that the BVC can add the tab strip and the toolbar as animatees of the view revealing vertical pan handler. - Implement the view revealing animatee protocol: when revealing the view, the tab strip should be translated down to be hidden behind the toolbar. - Set the BVC's background colour to clear and remove the fake status bar so that the thumb strip can be visible from behind those. - Add a pan gesture recognizer to the toolbar and tab strip, the first set of entry points to the thumb strip. - Set the tab strip to be below the toolbar in the view hierarchy so that it can slide behind the toolbar during thumb strip transitions. Bug: 1094335 Change-Id: Ic749236f70f5c3a589ae70e5b6a9442e85acf517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315029 Commit-Queue: Roberto Moura <mouraroberto@google.com> Auto-Submit: Roberto Moura <mouraroberto@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#803160}
-
Mason Freed authored
When these were implemented [1] the polarity was reversed: secure origins are counted as insecure, and vice-versa. This CL fixes that swap. Since there isn't much that can easily be done with the existing data on chromestatus.com, there will be a spike/swap that happens in the data when this lands. Since the alternative is just to leave this "broken" forever, I think it'll be better to start collecting the correct data from now on. [1] https://codereview.chromium.org/1166473002/diff/40001/Source/core/html/forms/FileInputType.cpp Fixed: 994940 Change-Id: I06a7844abd7e54147d855e0b9046fe86870fa5d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380251 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#803159}
-
Side Yilmaz authored
This CL adds |mProfileSupplier| local variable that is observed for profile changes. |mProfileSupplier| is used to pass profile param to IdentityServicesProvider. By this CL; - |mProfileSupplier| notifies the class when the current profile is changed. - When current profile changes, setProfile function is triggered and mIdentityManager is updated with the new profile. - Introducing |getSyncAccountInfo| function that uses current profile (i.e., off-the-record or regular) and returns account information. This function returns null for OTR profiles. - Passing current profile to tracker instead of using always regular profile to fix unsafe usage of profile. - Adding |testIdentityDiscWithSwitchToIncognito| to test identity disc disappear when switching to incognito NTP from sign-in state. Bug: 1041781, 1075562, 1048632 Change-Id: Icd443c03033b5a20c1ba0b680f57c05dfc21222d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307253 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#803158}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ffd61ca01246..4c2928bb0d5f 2020-08-31 mtklein@google.com deserialize drawPoints() mode safely 2020-08-31 bsalomon@google.com Revert "Experiment to see if ANGLE ES2 vs ES3 perf is related to GLSL ver" 2020-08-31 johnstiles@google.com Refactor inlineCall() to take a FunctionCall and SymbolTable as input. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: I93c4847beed9cc2fc51e12b2a48c28192f9a9c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385683Reviewed-by:
-
Matt Jones authored
This patch batches all the tests in BottomSheetControllerTest. Consequently, some new methods to reset the sheet's state were added to the test support classes and BlankCTATabInitialState was updated to support any subclass of ChromeActivity. Bug: 1122163 Change-Id: I3fbb73431eff206010d93d8c5e26e4942b84adb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377664Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#803156}
-
Alex Ilin authored
This CL adds the following metrics for the profile picker: - ProfilePicker.AskOnStartup - ProfilePicker.AskOnStartupChanged - ProfilePicker.NewProfileCreateShortcut - ProfilePicker.NewProfileTheme - ProfilePicker.Shown - ProfilePicker.UserAction Fixed: 1123001 Change-Id: Idf26a17b77e748b90358f07305b2968e79bcc379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379918 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#803155}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I7308e0fe69cf248829d11125456b3f43d2b7ae01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382074Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803154}
-
Yuki Shiino authored
Disables an unittest that tests OOM allocation behaviors when USE_PARTITION_ALLOC_AS_MALLOC because PartitionAlloc-based malloc() does not return nullptr and crash instead. Bug: 998048 Change-Id: I8173667512c9041fb68a4cb441ddf11766f2dbdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374925Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#803153}
-
Christian Dullweber authored
The boolean BlockThirdPartyCookies preference was replaced by CookieControlsMode enum. Existing settings were migrated since M83. Fix handling of CookieControlsMode::kIncognitoOnly state, which is the new default, where 3p cookies are allowed in regular mode but blocked in incognito mode. Previously the extension api would not report the state correctly in incognito mode unless it is explicitly set to block or allow. Bug: 1104836 Change-Id: Idad018d7a23aca913888fe6a66eb0502e26525a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367095 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#803152}
-
Aaron Leventhal authored
Do not invalidate children all the way up to the unignored ancestor, only invalidate a single node included in tree, either |this| or the first ancestor included in the tree. This is a precursor to fixing terrible performance loading large chat rooms on chat.google.com, but it does not yet fix the issue nor the related perf_tests. In order to fix that, it will be necessary to include more nodes in the tree as well. Bug: 1107988 Change-Id: I8a1f267a243ff1eda3d186e4c872eac75b40d792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383293 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#803151}
-
Yann Dago authored
This is a reland of e0309342 Original change's description: > Policy WebUI: 'Reload Policies' button reloads google update policies > > Bug: 1119703 > Change-Id: Ib91b37dc1da4f06782caea7b67ecc6d0c8c87b2d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367673 > Commit-Queue: Yann Dago <ydago@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802644} Bug: 1119703 Change-Id: I0542a481dc512b1c214e050084114cf313c10baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382216Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#803150}
-
Sébastien Séguin-Gagnon authored
Some of the tests were not working with the new illustrated empty states. An interface needed to be added to access the feature status in Chrome app as opposed to the test app. Change-Id: I1f7bf0e3d8e3e17cdbfca8948377e5086ae78059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378714 Commit-Queue: sebsg <sebsg@chromium.org> Auto-Submit: sebsg <sebsg@chromium.org> Reviewed-by:
-
Martin Kreichgauer authored
In CL:2350026, I tried to be clever and eliminate the unused FidoDiscoveryFactory argument from SetPINHandler. However, its base FidoRequestHandlerBase ctor expects a pointer to the discovery factory and is run before initialization of the SetPINHandler data members, and so we now pass it the address of an uninitialized member. Instead, inject the FidoDiscoveryFactory from the outside, like before. Bug: 1122892 Change-Id: I8ea881c57c9dc2b3c33c1bda2f0512459f3a7c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384133Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#803148}
-
dpapad authored
Fixed: 1123225 Change-Id: Ied7432e2dfede4f126da879ce139e7cc9e883ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384910 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#803147}
-
Koji Ishii authored
This patch adds `third_party/hyphenation-patterns` from: https://android.googlesource.com/platform/external/hyphenation-patterns/ Please see README.chromium. Exceprts below: Description: Hyphenation patterns for automatic hyphenation from Android. The data is originated from TeX hyphenation patterns project at http://www.hyphenation.org, modified by Android engineers. See src/README.android. Local Modifications: * The script `build_hyb.sh` is added to generate binary data files for the minikin library. Also the `hyb` directory contains the binary data files generated by the script. * The `LICENSE` file was generated by concatenating `NOTICE` or `LICENSE` files in each locale directory. * Removed `src/OWNERS`. Bug: 1093555 Change-Id: Ie155442c902811b33f32708e53c3a7e92877979b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254498Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#803146}
-
Noah Rose Ledesma authored
This change makes the audio device picker invisible when the MediaSessionInfo object reports that changing audio devices is not possible. The MediaNotificationContainerImplView will notify the device picker UI when the support for device switching changes. The MediaNotificationService will provide the device picker UI with the support boolean when the UI is constructed. Bug: 1120620 Change-Id: I09a35135569a79800fbe5ade0c36a5f37f6bee70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368051 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#803145}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /google_apis/gcm This CL was uploaded by git cl split. R=dimich@chromium.org Bug: 1110266 Change-Id: I2403e075be078395a691fdf6ea1f04e33dc76fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370299Reviewed-by:
-
Mitsuru Oshima authored
This reverts commit 20aca0dd. Reason for revert: The issue has been resoved in crrev.com/c/2384070 Original change's description: > Revert "Chrome OS: Use layer animation browser window frame activation animation." > > This reverts commit 3a2299e5. > > Reason for revert: Suspected breaking https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38374 and https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20193 > > Original change's description: > > Chrome OS: Use layer animation browser window frame activation animation. > > > > This is a revised version of original attempt crrev.comc/c/2166804. > > Instead of creating a new layers, this clone and animate the window's layer, > > but makes sure that the animating layer is at the bottom of other layers > > within the window. > > > > * It adds a invisible view with a layer > > at the bottom of the non_client_view (no frame w/o this, so we can exclude such case). > > * Adds the animating layer as a child of this view, with > > "SetMasksToBounds(false)" so that it will not be clipped during animation. > > * Once animation is done, this animating, old layer will be removed. > > > > Bug: 1073685 > > Test: covered by unittests. > > Change-Id: Ib5ae6a218d200394c54932e5b559217fcc7f89e1 > > Fixed: 2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375686 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#802386} > > TBR=sky@chromium.org,oshima@chromium.org > > Change-Id: I10600b9bc69818257f66fb5c1ae86f7fd1119c75 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1073685 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381217 > Reviewed-by: Melissa Zhang <melzhang@chromium.org> > Commit-Queue: Melissa Zhang <melzhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802539} TBR=sky@chromium.org,oshima@chromium.org,melzhang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1073685 Change-Id: I38725fa15f79576db154db91f7ca384578f545b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385815Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#803143}
-
Ilya Nikolaevskiy authored
This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2353461 implementing suggestions on struct member types. Bug: chromium:1116430 Change-Id: I27d89e5c22b0bb258112fa68a82f97da9e87777b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375168 Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#803142}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I7c78266d7455037d4262d6c272fed1dfcd89df8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382833Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803141}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I4ea0a82440442e986e82a41206a0904223d2a858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382816Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803140}
-
