GitLab

Review URL: https://codereview.chromium.org/296043014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272670 0039d316-1c4b-4281-b951-d872f2087c98

GCMProfileService tweaks the default value of prefs::kGCMChannelEnabled
so that GCM is enabled by default on the canary/dev/custom channels only.
However, the code that uses this pref has been broken for three months
now (since http://crrev.com/253787) so that it completely ignores the
default pref value. Hence, there is no need to tweak the default.

BUG=376746
TEST=Manual

Review URL: https://codereview.chromium.org/301433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272669 0039d316-1c4b-4281-b951-d872f2087c98

Modify content SynchronousCompositor related classes to
support for content embedder to use delegated rendering. The
embedder is responsible for creating the parent compositor.
Essentially need to pass CompositorFrame and
CompositorFrameAck between embedder and
SynchronousCompositor. Also need to expose the share context
so embedder can correctly initialize a context for parent
compositor.

In android_webview implemented parent compositor for
delegated rendering while keeping the current direct
renderer working, controlled by a command line switch.

BrowserViewRenderer deals exclusively with
SynchronousCompositor (the child). And HardwareRenderer
deals exclusively with the parent compositor. The two share
data through lock protected SharedRendererState. And all are
coordinated by native AwContents.

Direct rendering path is kept alive in
HardwareRendererLegacy and code guarded by
switches::UbercompEnabled. Direct rendering path remains the
default.

BUG=344087

Review URL: https://codereview.chromium.org/287993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272668 0039d316-1c4b-4281-b951-d872f2087c98

BUG=145845

Review URL: https://codereview.chromium.org/274273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272667 0039d316-1c4b-4281-b951-d872f2087c98

There is no device owner during OOBE, so owner settings are not saved, but
language setting should be stored.

BUG=chrome-os-partner:27284
TEST=none

Review URL: https://codereview.chromium.org/299443018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272666 0039d316-1c4b-4281-b951-d872f2087c98

R=tonyg@chromium.org

BUG=

Review URL: https://codereview.chromium.org/294053016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272665 0039d316-1c4b-4281-b951-d872f2087c98

Also add regular expressions support to net::FakeURLFetcherFactory.

BUG=245075
TEST=none

Review URL: https://codereview.chromium.org/294903005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272664 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/298683008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272663 0039d316-1c4b-4281-b951-d872f2087c98

BUG=310365
TEST=browser_test & tested visually (taskamanger, running YouTube, deleting active&inactive hidden tabs, ..)

Review URL: https://codereview.chromium.org/286943005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272662 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664

Review URL: https://codereview.chromium.org/291513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272661 0039d316-1c4b-4281-b951-d872f2087c98

Caused layout test failures and out-of-memory errors on several Mac
bots on the Blink waterfall. See Issue 375206.

BUG=375206

> cc: Examine layers to determine if we're ready to activate.
> 
> This introduces a new mechanism for determining when
> we're ready to activate the pending tree. The tile
> priority is still used to determine when it's worth
> waking up the compositor thread and evaluating if
> we can activate. However, the actual check that
> determines if we're ready to activate doesn't rely
> on the state of scheduled raster tasks but is a
> synchronous call on each layer.
> 
> The result is a pending tree activation mechanism that
> is much easier to debug and validate for correctness,
> while still providing the performance benefits of the
> old mechanism by taking the "required to activate" field
> of the tile priority into account when scheduling tasks.
>  
> BUG=375206
> TEST=cc_unittests --gtest_filter=PictureLayerImplTest.AllTilesRequiredForActivationAreReadyToDraw
> 
> Review URL: https://codereview.chromium.org/287643004

TBR=reveman@chromium.org

Review URL: https://codereview.chromium.org/301493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272660 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364336

Review URL: https://codereview.chromium.org/294903007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272659 0039d316-1c4b-4281-b951-d872f2087c98

Part of the transition from rasterize_and_record_micro.fast_path.key_silk_cases
to rasterize_and_record_micro.fast_path_gpu_rasterization.key_silk_cases.

I've previously removed the old benchmark from the buildbot scripts and the bots
have been restarted since. Removing the benchmark from Telemetry.

BUG=367678

Review URL: https://codereview.chromium.org/292423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272658 0039d316-1c4b-4281-b951-d872f2087c98

bb_device_steps.py's RunTestSuites took only one options
argument that will be applied for all the running test suites.
Add another suites_options argument so that the caller can
specify options on certain test suites.


BUG=368034

Review URL: https://codereview.chromium.org/297833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272657 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272656 0039d316-1c4b-4281-b951-d872f2087c98

petarj updated them here: https://gerrit.chromium.org/gerrit/70277

BUG=none
TEST=none
TBR=wolenetz
NOTRY=true

Review URL: https://codereview.chromium.org/294383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272655 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/295223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272654 0039d316-1c4b-4281-b951-d872f2087c98

separators.

R=rockot@chromium.org

Review URL: https://codereview.chromium.org/297963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272653 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332418

Review URL: https://codereview.chromium.org/290733013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272652 0039d316-1c4b-4281-b951-d872f2087c98

And change ExtensionToolbarModel to use it instead of NOTIFICATION_EXTENSION_UNINSTALLED.

R=kalman@chromium.org
BUG=354459
TEST=unit_test

Review URL: https://codereview.chromium.org/289073008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272649 0039d316-1c4b-4281-b951-d872f2087c98

r272290 added a child window to GLSurfaceGLX, but it needs to forward
Expose events to the parent.

BUG=326995
R=ccameron@chromium.org, sadrul@chromium.org

Review URL: https://codereview.chromium.org/299143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272648 0039d316-1c4b-4281-b951-d872f2087c98

This is a merged CL containing the PrivetV2SetupFlow, PrivetV2Session,
and PrivetV2SetupOperation interfaces.

BUG=372843

Review URL: https://codereview.chromium.org/299123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272647 0039d316-1c4b-4281-b951-d872f2087c98

InterfaceImpl has a function of the same name.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/291193012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272646 0039d316-1c4b-4281-b951-d872f2087c98

BUG=303818

Review URL: https://codereview.chromium.org/252003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272645 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272640 0039d316-1c4b-4281-b951-d872f2087c98

We don't use these anymore, and they have bitrotted and probably don't
even build with recent Clang. If we want them back, we can get them back
out of SVN/git.

R=teravest@chromium.org
BUG=

Review URL: https://codereview.chromium.org/297963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272639 0039d316-1c4b-4281-b951-d872f2087c98

Caused two native crashes in contentshell_instrumentation_tests on
Android Tests (dbg) bot on Blink waterfall.

BUG=377053,371530,373360

> Re-land: cc: Fail more visibly when sync queries are not working correctly.
> 
> Instead of creating an infinite number of sync queries, which will
> eventually cause performance issues, log an error message and block
> until oldest query has passed when reaching 16 pending queries.
> 
> BUG=371530,373360
> 
> Review URL: https://codereview.chromium.org/280543003

TBR=reveman@chromium.org

Review URL: https://codereview.chromium.org/299923005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272638 0039d316-1c4b-4281-b951-d872f2087c98

The flag isn't meant to be set externally, it doesn't work on most
configs. It's only meant internally to make sure the renderer doesn't
try to use GPU when the browser is in software.

BUG=None

Review URL: https://codereview.chromium.org/300523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272636 0039d316-1c4b-4281-b951-d872f2087c98

This introduces a new mechanism for determining when
we're ready to activate the pending tree. The tile
priority is still used to determine when it's worth
waking up the compositor thread and evaluating if
we can activate. However, the actual check that
determines if we're ready to activate doesn't rely
on the state of scheduled raster tasks but is a
synchronous call on each layer.

The result is a pending tree activation mechanism that
is much easier to debug and validate for correctness,
while still providing the performance benefits of the
old mechanism by taking the "required to activate" field
of the tile priority into account when scheduling tasks.
 
BUG=375206
TEST=cc_unittests --gtest_filter=PictureLayerImplTest.AllTilesRequiredForActivationAreReadyToDraw

Review URL: https://codereview.chromium.org/287643004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272635 0039d316-1c4b-4281-b951-d872f2087c98

We would show error message on attach failure now, we used to always return true from attachWindowAndSetUpEvents().
attachWindowAndSetUpEvents() now return the value of -internal-attach call. -internal-attach did not used to return value, now it returns the status of the attachment call from BrowserPluginBindings.

Removed 3 unused variables referring to browserPluginNode.

BUG=None

Review URL: https://codereview.chromium.org/284183013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272634 0039d316-1c4b-4281-b951-d872f2087c98

Transforms HashedExtensionMetrics into a metrics::MetricsProvider, eliminating
direct knowledge of this class from MetricsLog. Renames the class to
ExtensionsMetricsProvider. Notably, changes the class to take in the
MetricsStateManager and later obtain the client ID from the manager rather than
directly taking in the ID; this change is necessary because the provider
instance is now constructed before the ID is determined.

BUG=374225

Review URL: https://codereview.chromium.org/297483008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272633 0039d316-1c4b-4281-b951-d872f2087c98

* Net.QuicSession.MaxReordering
* Net.QuicSession.MaxReorderingTime
* Net.QuicSession.MaxReorderingTimeLongRtt

Review URL: https://codereview.chromium.org/298893010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272631 0039d316-1c4b-4281-b951-d872f2087c98

 (1) Key creation (whether by importKey(), unwrapKey(), generateKey() now fails if the requested key usages are not applicable (for instance asking for 'sign' on an AES-CBC key).
 (2) When generating a key pair, the public/private key get the intersection of supported usages and requested ones.
 (3) The exceptions thrown during the import phase of unwrapKey() are now surfaced to the caller (bug 372944)

BUG=372040,372944,245025
R=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/282133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272630 0039d316-1c4b-4281-b951-d872f2087c98

If we create a WebLocalFrame and then set blink's settings, the frame
gets an inconsistent view of the settings when they change out from
underneath it.

Concretely, this leads to us doing WebViewImpl::setRootGraphicsLayer(A)
with pinch virtual viewport disabled (the default in WebSettings), when
we attach the document to the tree, then we apply the prefs to enable
pinch virtual viewport, and later setRootGraphicsLayer(NULL) to detach
the document. This causes a crash because the viewport code expects
a matching attach before the detach.

With this CL, https://codereview.chromium.org/261143003 is able to pass
on the print preview and prerender browser tests.

R=bauerb@chromium.org
BUG=376531,361729

Review URL: https://codereview.chromium.org/296983017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272628 0039d316-1c4b-4281-b951-d872f2087c98

see https://codereview.chromium.org/293853002/

BUG=354897

Review URL: https://codereview.chromium.org/299553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272627 0039d316-1c4b-4281-b951-d872f2087c98

This cleans up after r270870 following the blink-side changes.

BUG=360254

Review URL: https://codereview.chromium.org/282373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272626 0039d316-1c4b-4281-b951-d872f2087c98

BUG=345804,360246

Review URL: https://codereview.chromium.org/289063012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272625 0039d316-1c4b-4281-b951-d872f2087c98

also some other misc. changes to shorten code, remove a using directive, etc.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/291653007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272624 0039d316-1c4b-4281-b951-d872f2087c98

Reverting bacuse of failure of ClosingWindowWhilePrintingShouldNotCrash
after it was enabled by this change on Linux Tests.

> Remove kEnablePrintPreview now that the pdf plugin is part of Chromium.
> 
> R=thestig@chromium.org
> 
> Review URL: https://codereview.chromium.org/296453015

TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/299273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272622 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372829

Review URL: https://codereview.chromium.org/288693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272621 0039d316-1c4b-4281-b951-d872f2087c98