- 10 Apr, 2018 40 commits
-
-
Wei Li authored
ExtensionPopup used native windows server to draw its border beforei this change in the same way as Cocoa did. However, through hiding and showing the bubble, the shadow was not reliably drawn. Now we change to use views to draw its shadow. Other bubbles on Mac, as well as the extension popup on Cocoa, will still use native windows server to draw their shadows. BUG=821739 Change-Id: Ie4fa4f4499e9feed1f266eb79ab878e7fee92ab4 Reviewed-on: https://chromium-review.googlesource.com/1003046Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#549561}
-
Daniel Bratell authored
An accidental inclusion of a cc file caused interesting linking errors (duplicate chrome::kChromeUIPrintURL) in certain build configurations. Fix is to include the header instead of the cc file so that references to chrome::kChromeUIPrintURL will be external as intended. Change-Id: Iba69dbd17267955534609d308cef16ab0467671d Reviewed-on: https://chromium-review.googlesource.com/1005342Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#549560}
-
Xiaohan Wang authored
Description of icons: - infobar_protected_media_identifier.png: Blue icon used on the actual permission prompt. - permission_protected_media.png: Gray icon used on site settings. Optimized with: tools/resources/optimize-png-files.sh -o2 -c HEAD~ -v For historical context, previously those icons were added in https://codereview.chromium.org/2123533002 For Protected Content icon change on desktop platforms, see https://chromium-review.googlesource.com/c/chromium/src/+/1003146 Bug: 454980 Test: Manually tried it and verified on https://permission.site Change-Id: Idc74992632161ee19944146395ac87d79adee848 Reviewed-on: https://chromium-review.googlesource.com/996754 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#549559}
-
Asanka Herath authored
These values are already deprecated, but they appear in historical records. Change-Id: I4410003565ce10755c600db27db2df93c641d099 Reviewed-on: https://chromium-review.googlesource.com/1004915Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#549558}
-
Emircan Uysaler authored
This reverts commit 72de4972. Reason for revert: Caused issues with bitrate in WebRTC use of H264 encoder. Original change's description: > Reduce the frequency of key-frames of Windows MF H264 encoder > > Since WebRTC has its own key-frame management, it's not reasonable for MF H264 > encoder to generate key-frames regularly - it generates one key-frame per 30 > frames. > So this change sets CODECAPI_AVEncMPVGOPSize to UINT32_MAX to block it from > generating key-frames automatically. But this setting won't impact the key-frame > requests from WebRTC. > > Bug: chromium:769391 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I1e9e5ffdd7068c81ac02438e59ad3c92d75b8742 > Reviewed-on: https://chromium-review.googlesource.com/738916 > Commit-Queue: Zijie He <zijiehe@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#511969} TBR=sandersd@chromium.org,zijiehe@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:769391, chromium:798399 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I437d9a939fd4ae960eae278d6d13ee40330b3e46 Reviewed-on: https://chromium-review.googlesource.com/1003612 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#549557}
-
Mark Cogan authored
This CL adds support (via a gesture recognizer) for long-press-drag movement of grid cells to GridViewController. The cell movement gets the appropriate delegate plumbing so it can be fed back to the mediator. The GridViewController's consumer implementation is tweaked so that cell movement caused by user interaction doesn't trigger a collection view update (since that update has already happened as part of the move). Bug: 804592 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic8ba431d598dfee39f4a72f36f02a3d9ab52443d Reviewed-on: https://chromium-review.googlesource.com/986379 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#549556}
-
Daniel Cheng authored
As the contentDocument attribute and the getSVGDocument() method are the only IDL definitions that use CheckSecurity=ReturnValue, just modify the binding generator to emit calls to count instances of the exception being thrown. Bug: 582245 Change-Id: I4772cc225c4e2da33964b47cb8df3324a9d929f9 Reviewed-on: https://chromium-review.googlesource.com/905749Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#549555}
-
Rohit Rao authored
Also adds a shadow to the presentation controller to visually separate the recent tabs content from the background views. BUG=805154 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifde4a44c0eac0157ca02fc93c7814a78b51cca12 Reviewed-on: https://chromium-review.googlesource.com/998416 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
Justin Cohen authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I50aab0be5fae9566c4c1c3f6148407dc03063195 Reviewed-on: https://chromium-review.googlesource.com/1003034 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
https://pdfium.googlesource.com/pdfium.git/+log/e372ad7333bd..4027887ee29a $ git log e372ad733..4027887ee --date=short --no-merges --format='%ad %ae %s' 2018-04-10 dsinclair Merge CXFA_SimpleParser::{Start|Do}Parse Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I76869030265b90a8da1763f79f7f0c37ac5a88c2 Reviewed-on: https://chromium-review.googlesource.com/1005025Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549552}
-
Mustafa Çamurcu authored
OnUntranslatedIMEMessage is only implemented on Windows. This change makes it receive MSG instead of PlatformEvent so that it works for Windows/Ozone as well. Change-Id: Id11f940b8ab63af562672943f783411ff9f990a7 Reviewed-on: https://chromium-review.googlesource.com/998419Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Mustafa Çamurcu <camurcu@google.com> Cr-Commit-Position: refs/heads/master@{#549551}
-
Réda Housni Alaoui authored
enumeration MediaFoundation can't handle DirectShow virtual cameras. This is to append MediaFoundation unsupported DirectShow cameras to the camera enumeration supplied to the consumer. Bug: 730068 Change-Id: I3240e2158f822c04a193ec20a091c1f17ee2e373 Reviewed-on: https://chromium-review.googlesource.com/1000853 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#549550}
-
jkereliuk authored
This test no longer exists and was reverted here: https://chromium.googlesource.com/chromium/src/+/e9c808f26d Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Id5431c16943b83913023184c03a49a87e6d54736 Reviewed-on: https://chromium-review.googlesource.com/1005339 Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#549549}
-
arthursonzogni authored
This test has been disabled on Windows with NavigationMojoResponse: https://chromium-review.googlesource.com/c/chromium/src/+/958904 Then the issue has been fixed by: https://chromium-review.googlesource.com/998873 This CL enabled this test again. Bug: 804868 Change-Id: I77f5faaba1dd6a2e3517fe3d14df5d281a2f5e30 Reviewed-on: https://chromium-review.googlesource.com/1005347Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#549548}
-
Aga Wronska authored
Bug: 826402 Change-Id: I8fa2f91e4dae3c391568ca3a47b5fae080bf3745 Reviewed-on: https://chromium-review.googlesource.com/1000535 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#549547}
-
Aaron Leventhal authored
Fetching the tooltip in the find bar icon's constructor is causing a startup regression. Wait to fetch it once the find bar icon becomes visible for the first time. Bug: 813827 Change-Id: I87d03a6e986d14793e0f5b21781e23cc8fd28549 Reviewed-on: https://chromium-review.googlesource.com/956422 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#549546}
-
kylechar authored
Fix file names for precompiled headers in blink. The case mismatch of build/win/Precompile.h vs build/win/precompile.h was causing errors when cross compiling for Windows on Linux. Also fix some mangled files. Bug: 768828 Change-Id: I56d657a7cbd79dcdd021785fee9d4e9e8d402a9f Reviewed-on: https://chromium-review.googlesource.com/1005276 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#549545}
-
Mikel Astiz authored
Lists another tricky scenario that is currently fixed on trunk, but worth having dedicated test coverage for, considering that some discussed solutions don't work well in this scenario. Credits to pkotwciz@ for discovering. Bug: 828196 Change-Id: I97f248cff717de02ee02203994fc296af9a18dd2 Reviewed-on: https://chromium-review.googlesource.com/1000790Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#549544}
-
Misha Efimov authored
Bug: 812334 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I99f120d624916af57ccbc068e5162b920299fc89 Reviewed-on: https://chromium-review.googlesource.com/984114Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#549543}
-
Daniel Cheng authored
Change-Id: Ia41f32591c6009f2366421850903838d29e35234 Reviewed-on: https://chromium-review.googlesource.com/1005015Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#549542}
-
David Roger authored
Bug: 829218 Change-Id: I4db1e432cbe32b6a0de5a502eba5acb1af3e16d0 Reviewed-on: https://chromium-review.googlesource.com/1005035Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#549541}
-
kapishnikov authored
BUG=830634 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I7930f0578fb5f4981c99da4d36ae2fa385f51d34 Reviewed-on: https://chromium-review.googlesource.com/990154Reviewed-by:
-
Xu Xing authored
To run layout test over SkiaRenderer, need to add flag --additional-driver-flag=--use-skia-renderer. BUG=820356 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic289b19cda9cfcb96bf38217eb20b890bb808f5a Reviewed-on: https://chromium-review.googlesource.com/1001872Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#549539}
-
David Roger authored
A lot of the usage can be replaced by simple calls to the token service itself. This is better, because the delegate is not meant to be exposed. Change-Id: I8e4813308c890e0bccad03779f429fa902066178 Reviewed-on: https://chromium-review.googlesource.com/995893Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#549538}
-
arthursonzogni authored
Check using chrome.app.window.create() with the about:blank URL is not allowed. Bug: None. Change-Id: Ib8ca494921ca588540857b11e81584e686ba590e Reviewed-on: https://chromium-review.googlesource.com/995892Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#549537}
-
Sandra Sun authored
This patch enables smooth scroll for "Find" on Android. This is implemented by setting a "smooth_scroll_for_find_enabled" in WebPreferences so that it can be disabled by tests. Currently, smooth scroll is only enabled for ProgrammaticScrolls. However, "Find" is a UserScroll that doesn't scroll "overflow: hidden" scrollers. This patch also makes sure those scrollers won't be affected by the smooth scroll. Bug: 702966 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I65b5e20b2dad36bc1e6532d20162a643471d43c0 Reviewed-on: https://chromium-review.googlesource.com/978364Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#549536}
-
stkhapugin@chromium.org authored
UITextField appears to use an internal, undocumented and unprefixed -clearButton method. This conflicts with our -clearButton method causing unexpected behavior. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I54434cd143bef76975f7aea1ffe811dc9135eed1 Reviewed-on: https://chromium-review.googlesource.com/962442 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#549535}
-
Florian Uunk authored
This is a resubmit with a fix of http://crrev/960005, after it broke webgl tests. (see revert in http://crrev/1002854). Modification since original CL: In DesktopProfileSessionDurationService::OnSessionEnded, return early if total_session_timer_ is null, which is the case when there was no DesktopProfileSessionDurationService::OnSessionStarted call before it. Original description: This tracker reports the time that the user spent actively using chrome, with their associated sync and sign-in state. Definition of syncing: Having opted in to sync, and sync not being in an "error" state because of a content-area sign-out. Definition of signed in: The user is signed in to the content area. These metrics will let us track: - How long on average users spend being signed in to the content area - How long users on average spend syncing - Which proportion of a user's time is being spent signed in - Which proportion of a user's time is being spent syncing TBR reason: Small change to previously approved CL. TBR=sdefresne@chromium.org, asvitkine@chromium.org Bug: 820188 Change-Id: Ifbcd995d0d32ce4b967f9a6c215ba2fcc5477298 Reviewed-on: https://chromium-review.googlesource.com/1004675 Commit-Queue: Florian Uunk <feuunk@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#549534}
-
Elad Alon authored
AreLogParametersValid() must set the error message when it returns false. This is better ensured by a DCHECK than by a comment. Bug: 775415 Change-Id: I40c4963cc53c8751d681efeffec9f85fc35838b7 Reviewed-on: https://chromium-review.googlesource.com/1004615Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#549533}
-
rodmartin authored
This CL makes the calls to GetSessionList and DoRenameSession safe as was noted in CL 929754. Bug: 830913 Change-Id: I7ad22b5712e032f256bd46ae9f04c28255861af7 Reviewed-on: https://chromium-review.googlesource.com/996472 Commit-Queue: Martin Rodriguez <rodmartin@google.com> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#549532}
-
Christian Biesinger authored
cached_result_ is used for CurrentFragment(); we need to make sure it is up-to-date. Therefore, we can't just refuse to store a fragment if we have unpositioned floats. Instead, we just store the new fragment in these cases and handle the check when checking whether we can reuse the fragment. This supersedes https://crrev.com/c/1001722 Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I934d2290ec496da6dbdd4a8a9c5e3dc78907049e Reviewed-on: https://chromium-review.googlesource.com/1004586Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#549531}
-
Justin Donnelly authored
The existing method of determining whether upload was active was based on whether it was enabled and not protected by an encrypted passphrase. However, we need to also ensure that syncing is in the correct auth state. Using the new GetUploadToGoogleState method does this. Bug: 824090 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I442e0b3513cbfde6af9748dd82c463ffa56e7812 Reviewed-on: https://chromium-review.googlesource.com/978465Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#549530}
-
stkhapugin@chromium.org authored
Rolls MDC and updates the BUILD.gn following the changes in MDC. Bug: 831114 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ida3e76d77c68be7830575a2c261d214c51fd81dd Reviewed-on: https://chromium-review.googlesource.com/1005156Reviewed-by:
-
https://chromium.googlesource.com/angle/angle.git/+log/fe4bbe6cbec6..26084d0aae38 $ git log fe4bbe6cb..26084d0aa --date=short --no-merges --format='%ad %ae %s' 2018-04-09 jmadill Vulkan: Create TextureVk's Image lazily. 2018-04-09 jmadill Optimize Subject's binding method. 2018-03-30 jiawei.shao Use ShaderBitSet for active use bits on uniforms Created with: roll-dep src/third_party/angle BUG=chromium:829906 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I56fc6e687699170e99bd4d210db0b1ac88aedf48 Reviewed-on: https://chromium-review.googlesource.com/1005023 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549528}
-
Devlin Cronin authored
Signature parsing failed in cases where an optional parameter of a certain type was followed by a required parameter of the same type. The parsing was greedy, and would always use a parameter if it matched. This meant that passing a value like `1` to a signature that matched (optional int, int) would fail, because the `1` would be applied to the first optional int, and the second int would be missing. Tweak signature parsing to find the signature that matches the supplied arguments (if any possible signature matches) and resolve the arguments before performing parsing. Update unittests for the same. Bug: 818555 Change-Id: I57c9909ff73505467fb9d333690113bea8eea433 Reviewed-on: https://chromium-review.googlesource.com/993532Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549527}
-
David Bokan authored
This patch fixes the Android find-in-page feature when used by dragging down the tickmarks. The issue was that prior to RLS, absolute coordinates were equivalent to "document" coordinates. That meant that after scrolling, they don't change. When RLS is turned on, absolute coordinates are frame-relative so scrolling will change the location of an absolute rect. This find in page feature would scroll the text match into view and then attempt to zoom in on it. However, because of the above change, the coordinates used for the zoom have now changed. The solution here is to simply query the bounding rect after the scroll into view again. Bug: 828758 Change-Id: I807a05b89707080b1eed1bb3682147411776aa44 Reviewed-on: https://chromium-review.googlesource.com/1004010Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#549526}
-
Mikel Astiz authored
We adopt them already in some existing tests and plan to use them in future patches as part of the migration of session sync to USS. Bug: 681921 Change-Id: I91bcb5b2d0383be89bef1b905e1d3b16259f94bb Reviewed-on: https://chromium-review.googlesource.com/983918Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#549525}
-
Matthew Wang authored
This is a reland of 34f59cac Turns out it was enough to clobber the WebRTC mac builder. Original change's description: > ONC: Add FTEnabled property to WiFi > > Support FTEnabled property in ONC. > > BUG=791202 > TEST=chromeos_unittests > TEST=chrome.networkingPrivate.createNetwork with "FTEnabled":true > enables the device to connect to an FT network. Setting > "FTEnabled":false disables the device from connecting to an FT > network. > > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I2470753fd139505704987e301b18983dc51c5c47 > Reviewed-on: https://chromium-review.googlesource.com/982275 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Matthew Wang <matthewmwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549366} TBR=matthewmwang@chromium.org Bug: 791202 Change-Id: Ia7c49d75e3c7b769e5853e377ef860fef6663abc Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1005114 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#549524}
-
kylechar authored
Make OzoneGpuTestHelper::Initialize() run UI thread tasks after OnGpuProcessLaunched(). In https://crrev.com/c/980574 Ozone DRM was changed so the DRM display controller handle was only accessed on the UI thread to prevent races. This means that when GpuPlatformSupportHost OnGpuProcessLaunched() is called from the IO thread there is a UI thread task that needs to run to finish initialization. This CL adds a RunLoop that runs on the UI thread and immediately posts a task to quit that run loop. That will run any tasks on the UI thread that are pending and then continue, ensuring the Ozone DRM initialization is finished. This should be safe for other Ozone platforms as well. Bug: 830233 Change-Id: I5b2e45c36f7042d59800c0822ca97b13a60a7aab Reviewed-on: https://chromium-review.googlesource.com/1003076Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#549523}
-
Francois Doray authored
Previously, the test ran all pending tasks, waited for all stores to be equal, and then verified that the printer description was equal in all stores. It is better practice not to wait for all pending tasks to run, and instead wait for the specific condition that we want to verify. Bug: 810408 Change-Id: Ifa5fe80368285786664498991c82c1ccdecb5072 Reviewed-on: https://chromium-review.googlesource.com/1003224 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Nicolas Zea (slow) <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#549522}
-
