GitLab

This reverts commit 0b97d41c.

Reason for revert: The failures were reproduced... in many places. Hopefully enough data to help debug.
Bug: 1143207

Original change's description:
> Enable NavigationRacesWithSitelessCommitInDefaultProcess on all platforms.
>
> Unable to reproduce flakiness locally. Enabling tests and removing skip
> test logic for --site-per-process. Code was added to remove this flag in
> SetUpCommandLine() so the tests can run on all platforms.
>
> Bug: 1110497
> Change-Id: I552f82d1fe4786e59cd624edf5504b713318d523
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500280
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Commit-Queue: Aaron Colwell <acolwell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#821477}

TBR=acolwell@chromium.org,alexmos@chromium.org

Change-Id: I0d6472a0b2424b65db61559fb330275463fca9c8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1110497
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504266Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821671}

The method has been replaced by the equivalent
|FindElement|. This will enable us to report
the found element of the check to the caller.

This change is a pure refactor without any
intended behavioural changes.

Bug: b/171782156
Change-Id: I5291099cbe0bc14473f62acf43b5a6554af891ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502374
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821670}

This CL records the intent that a ChromeOS application was launched
with as part of the AppLaunchParams. This necessitates changing
AppLaunchParams to be move-only, as apps::mojom::IntentPtr is
move-only.

When a web app is launched using LaunchAppWithIntent, the intent is
passed to WebAppLaunchManager.

Bug: 1125880
Change-Id: Ib6ec233fdac7efeb5862d5759cca750832549ee1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444614Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Maggie Cai <mxcai@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821669}

- Changed clipboard data endpoint destinations
to accept a new parameter to control whether to
notify the user if the clipboard is restricted
with data leak prevention policy rules.

- Updated clipboard read references with the new
parameter according to the following:
  - If the clipboard read call is because
of a user action trying to copy-paste, then a
notification should be shown.
  - Otherwise the notification shouldn't be shown
e.g. ChromePasswordManager, ClipboardAura,
checking if the paste command is enabled for
the context menu, ...etc.

Bug: 1136290
Change-Id: I9eea9bee8d027650c56ace132e34dfed1e78d2d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452712
Commit-Queue: Aya Elsayed <ayaelattar@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821668}

This reverts commit 4fd275d3.

Reason for revert: 

Breaks the internal build:

../../clank/java/src/com/google/android/apps/chrome/banner/PhoneskyDetailsDelegate.java:27: error: symbol not found org.chromium.chrome.browser.banners.AppDetailsDelegate
import org.chromium.chrome.browser.banners.AppDetailsDelegate;
       ^
../../clank/java/src/com/google/android/apps/chrome/banner/PhoneskyDetailsDelegate.java:42: error: could not resolve AppDetailsDelegate
public class PhoneskyDetailsDelegate extends AppDetailsDelegate
                                             ^
../../clank/java/src/com/google/android/apps/chrome/banner/PhoneskyDetailsDelegate.java:71: error: could not resolve Observer
            Observer observer, String url, String packageName, String referrer, int iconSize) {
            ^
../../clank/java/src/com/google/android/apps/chrome/banner/PhoneskyDetailsDelegate.java:26: error: symbol not found org.chromium.chrome.browser.banners.AppData
import org.chromium.chrome.browser.banners.AppData;
       ^
../../clank/java/src/com/google/android/apps/chrome/banner/PhoneskyDetailsDelegate.java:83: error: could not resolve AppData
    private AsyncTask<AppData> createRetrievalTask(final Observer observer, final String url,
                      ^
../../clank/java/src/com/google/android/apps/chrome/banner/PhoneskyDetailsDelegate.java:83: error: could not resolve Observer
    private AsyncTask<AppData> createRetrievalTask(final Observer observer, final String url,
                                                         ^
../../clank/java/src/com/google/android/apps/chrome/banner/PhoneskyDetailsDelegate.java:123: error: could not resolve AppData
    private AppData parseAndVerifyAppBundle(
            ^
../../clank/java/src/com/google/android/apps/chrome/banner/PhoneskyDetailsDelegate.java:53: error: could not resolve AppData
    private final LinkedList<AsyncTask<AppData>> mQueuedRequests;
                                       ^
../../clank/java/src/org/chromium/chrome/browser/AppHooksImpl.java:39: error: symbol not found org.chromium.chrome.browser.banners.AppDetailsDelegate
import org.chromium.chrome.browser.banners.AppDetailsDelegate;
       ^
../../clank/java/src/org/chromium/chrome/browser/AppHooksImpl.java:92: error: could not resolve AppDetailsDelegate
    public AppDetailsDelegate createAppDetailsDelegate() {
           ^



Original change's description:
> [Android] Move and modularize android/banners.
>
> This CL moves AppBanner* code from:
>   chrome/android/banners
> ... to ...
>   chrome/browser/banners/android
> ... and modularizes it in the process.
>
> Bug: 1135551
> Change-Id: I8773b293e55f03ca66da15551e27a06e26e2ae96
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489917
> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
> Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#821646}

TBR=nyquist@chromium.org,finnur@chromium.org,dtrainor@chromium.org

Change-Id: Ib1570bc83be4716cabf67bc71b3d4e723333bffa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1135551
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503952Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821667}

Tbr: alcooper@chromium.org, klausw@chromium.org
Change-Id: Ib0b150b53a31ce63d3fe7dbf41ca700c81dd57cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504672Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821666}

The flag allows switching the Blink heap implementation to using V8's
version of Oilpan.

Bug: chromium:1056170
Change-Id: I56e116586b38f4cea0666074d9ecbc8a754d0eeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504252Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821665}

Bug: 1142880
Change-Id: I7e637b83bf15f6957782eb6348b87761bfe85296
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503314Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821664}

Refactor OpenFileToRead() to prepare for MTP support in ARCVM.

1. In OpenFileToRead(), the main work for MTP flow is refactored into
GenerateVirtualFileId() and OpenFileById().
2. Added 2 new FileSystemHost mojo call: GetVirtualFileId() and
HandleIdReleased().

BUG=b:158606367
TEST=As a regression test, in ARC++, a file can still be opened
with an Android app via MTP successfully.

Change-Id: Iea6cedd37903f94138428016b663e225d05138dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444757Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Cherie Cheung <cherieccy@google.com>
Cr-Commit-Position: refs/heads/master@{#821663}

TBR=bling-team@google.com

Change-Id: If3a54f33224fe1ab7f3557dbf8dfdc620c150d62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504204Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821662}

This CL replaces third_party/icu uses with base/third_party/icu.
Along with the change, base/third_party/icu/* is updated to v67.
- Extracted several macros used for char_iterator implementation.
- Removed utf8_nextCharSafeBody, as it is no longer used.

This CL is preparation to move char_iterator to base/strings
so that it can be used in new functions in base/.

Bug: 2492481
Test: Ran base_unittests.
Change-Id: I779c7384b15701dcac3feac9d258be5793ca209d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494402
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821661}

This change adds "Signed in with" row for federation credential on the
Password Details screen.

Bug: 1137807
Change-Id: Ie9e6d8b78eef253098111904306fbffe4262f897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467937
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821660}

Move `AccountManagerFacade` from //chromeos/components/account_manager
to //components/account_manager_core so that it can be depended on by
ash-chrome and lacros-chrome both.

Bug: 1117466
Change-Id: I475c0b18d8ce50698c085d841a014f33016e5a61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494938Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821659}

This CL removes the temporary fetch() UseCounters introduced in
crrev.com/c/2242205 to help with metrics collection for ServiceWorker
folks.

R=kinuko@chromium.org, yhirano@chromium.org

Bug: 1072350
Change-Id: Id3327fe1ed9792a9ed8fd3e7333c08293cca1f6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503188
Auto-Submit: Dominic Farolino <dom@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821658}

The UserInputMonitorLinux depends on X11 directly and cannot be used by
Ozone platforms because of that.

This CL introduces a new platform interface for the user input monitor,
and moves the X11 implementation to //ui/base/x.  The
UserInputMonitorLinux now uses either the X11 implementation directly
(when X11 is enabled but Ozone is not) or requests the platform
implementation when Ozone is enabled.

Bug: 1116414
Change-Id: I0a21074f2fe028fea13c7efb33ddf9d102c9f35c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489863
Commit-Queue: Alexander Dunaev <adunaev@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821657}

Currently if we open the link in a new tab (e.g. ctrl + click, context
menu, from another app), the intent picker icon will not show up even
there are apps that can handle that URL. This is because:
1. We check the browser for the web contents in navigation throttle
before the adding the web contents to tab strip model for new tab case.
2. When open new tab from new-tab page, the starting URL is empty.
This CL fixes this issue by moving these checks to only check for
automatically pop up the bubble or automatically launch the app, but
still show the icon if there are app found.

BUG=1141049, b/171260488

Change-Id: Idcf4b07c34304bf6664f874142128ceddb6d6569
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500974Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821656}

These tests prove that no additional handling is required to block
insecure private network requests targeting `file:` URLs. Indeed these
requests are already blocked for a different reason: pages loaded over
http and https are forbidden from accessing `file:` URLs.

Bug: chromium:1142505
Change-Id: I606672978c286d450cdee796aa821c07c7911c7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498526Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Arthur Hemery <ahemery@chromium.org>
Commit-Queue: Titouan Rigoudy <titouan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821655}

Bug: 1074052
Change-Id: I180f5c8822803ea14ec4b37850165322ab3082d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502340Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821654}

Bug: 1123584
Change-Id: Id90a5a6b76eb8fcfe62684015366abe9a64f9dd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485110
Commit-Queue: Stefan Holmer <holmer@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821653}

This follows up removing the sources assignment filter.

Bug: 1018739
Change-Id: I70b19a5d47145c1b231946c503fe28d9e4695fcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502181
Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821652}

These grit() targets traditionally were placed in c/b/r/BUILD.gn,
but it is more appropriate to move them to within the corresponding
WebUI subfolder.

In this CL only moving grit() targets for folders where
generate_grd() is used.

Bug: 1132403
Change-Id: I52c86feca0f20cc819240068a38e1c3d39b6acab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503189
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821651}

Preparing for ::target-text pseudo style painting.

Bug: 1136817
Change-Id: I72127c4b1042535e1c4b6cc2435a49ba3d9c9c17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484801Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821650}

The test doesn't need to handle strings consisted of control characters.
This CL makes the test 4x faster in debug build.

This CL has no behavior changes.

Bug: 1143185
Change-Id: I82c252ae3b182514cb11543a3c305a589a6366d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503763
Commit-Queue: Kent Tamura <tkent@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821649}

This CL adds fetch uploading 150Mbytes arraybuffer test.

Since similar layouttest was so slow, I decided to test it in browser
test.

Bug: 919361
Change-Id: I693e67666e71b999276f25cfe0c0ff56436c4369
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490964
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821648}

Bug: 1086388
Change-Id: Ie0ddb53e5910fb4ee32592531fbb4ea5f4a794c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500972Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#821647}

This CL moves AppBanner* code from:
  chrome/android/banners
... to ...
  chrome/browser/banners/android
... and modularizes it in the process.

Bug: 1135551
Change-Id: I8773b293e55f03ca66da15551e27a06e26e2ae96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489917
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821646}

This is in preparation for Lacros. Data structures like `Account` and
`AccountKey` need to be accessible from Lacros.
But Lacros should not have any knowledge of `AccountManager`.

Extract these data structures from `AccountManager` into their own build
target - account_manager_core.

Bug: 1117466
Test: chromeos_components_unittests --gtest_filter="*AccountManager*Test*"
Change-Id: I38cff45ceb1ca3cc058b6b26d1dafbd4f048b0d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483830Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Anastasiia N <anastasiian@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821645}

Roll Chrome Linux PGO profile from chrome-linux-master-1603842982-a956b2994ae58c7a5e5be7f92daab364455a7a77.profdata to chrome-linux-master-1603864709-80e0b66faf89b1f5bb0f1645a135a447551ec59a.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ibee39a0917f120a4c3816e3792dcf6ae12eb0a6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505113Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821644}

Roll Chrome Mac PGO profile from chrome-mac-master-1603842982-f4d76b0dbc68c465997b53b2b1abd32fd48f8f3c.profdata to chrome-mac-master-1603864709-845b29927599ab12682abdf7fcfbf1ec60b2364e.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ief323df650a11dc54a4304fcc5bfeaa211963d01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505111Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821643}

Change-Id: Icffa98b8adf72e2cb9bfca3b7aec2fba5042827f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497781
Auto-Submit: Rob Schonberger <robsc@chromium.org>
Reviewed-by: Charles . <charleszhao@chromium.org>
Commit-Queue: Rob Schonberger <robsc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821642}

This reverts commit a42b2a30.

Reason for revert: Causing failures on linux-chromeos-dbg and linux-chromeos-chrome - see https://crbug.com/1143173

Original change's description:
> [CrOS PhoneHub] Mark tether ineligible if SIM has no reception.
>
> TetherControllerImpl will now mark the tether feature ineligible if
> it is notified by the PhoneModel that the SIM state has changed to
> anything other than kSimWithReception.
>
> Fixed: 1140812
> Bug: 1106937
> Change-Id: Ia18c5e06c57805541b03b29afea1762e85b8304f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500182
> Commit-Queue: Regan Hsu <hsuregan@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#821493}

TBR=khorimoto@chromium.org,hsuregan@chromium.org

Change-Id: Id0ae4601f07b125f8e1e11b99b2de81ab0344bfd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1106937, 1143173
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504857Reviewed-by: Austin Tankiang <austinct@chromium.org>
Commit-Queue: Austin Tankiang <austinct@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821641}

This CL refactors UTF{8,16}CharIterator by using StringPiece{,16}.
- Unify constructors to just StringPiece.
- Changed the index type from int32_t to size_t.
  - Accessor methods are also updated.
  - UTF16CharIterator::char_offset() is kept int32_t intentionally
    because it is not the index within the underlying array.
- Update example to use for-statement.
- Update clients to adapt with the new constructors/accessor methods.

Bug: 1140536
Test: Ran trybots.
Change-Id: Ib29ca5ae4190217dcd39d665f6aedbca0a0b4df4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492481
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821640}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I151cdba58e32725c5da40506395906eccec7b077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504981Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821639}

This CL updates how a web app's launch URL is computed given a
launch_query_params configuration. If the launch_query_params are
already present in the start_url then they are not appended a second
time.

Bug: 1142701
Change-Id: I394c8d96ee5e6a3776ed0c3555167b672b5e50b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501107
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Glen Robertson <glenrob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821638}

Roll Chrome Win32 PGO profile from chrome-win32-master-1603680975-76e0bcad480e2e9cf63aee149b7c46a4d88220b4.profdata to chrome-win32-master-1603831993-ad45cd294d298c80e2b0aad0e49861b0d50b053b.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I1a9742da89b29016de420bb1f43826f5bc679984
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504693Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821637}

Internal cleanup to remove deprecated code.

Bug: 1110585
Test: None
Change-Id: I3574a6578233b71654bcefc1c6b638321de1f993
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465896Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Sara Kato <sarakato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821636}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome
TBR=chrome-os-gardeners@google.com

Change-Id: If4d755c5d9584f8924539fe774cde25e1918566c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503619Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821635}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d9d752771b77..e6112e17b371

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC shend@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: shend@google.com
Change-Id: I09af0770dd4906be33190c756838e87cffe72e40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504979Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821634}

https://skia.googlesource.com/skia.git/+log/784ac915d427..7b14f2f6e971

2020-10-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 98c5ff6b49b3 to ee4e0866cb85 (17 revisions)
2020-10-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 6d5913ce to 0b545254 (537 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: jcgregorio@google.com
Test: Test: Test: Manual verification with angle_perftestsTest: Test: Texture2DTestES3::ChangeTexSizeWithTexStorage
Change-Id: Ie21602194c6c54156201931c3ed7c7e0e1b6e3cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504980Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821633}

Roll ChromeOS Bigcore AFDO profile from 88-4296.0-1603705354-benchmark-88.0.4304.0-r1 to 88-4296.0-1603705354-benchmark-88.0.4305.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-bigcore-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: Icc2d51d8769674566302193ce1f79f241f54b8ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504988Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821632}