- 13 Jul, 2018 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium ab13ebac. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21203 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I1289268cce80499b7c9ca3bd34730d7d03b01a7e Reviewed-on: https://chromium-review.googlesource.com/1136590 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#574990}
-
Nico Weber authored
These sections have been around since the json files started being autogenerated. Not all _apk targets have key_removal sections, and the ones that do have different bots listed there. Omitting args probably isn't important, so don't do it. Bug: 843511 Change-Id: I42c2e0bb03d28d850bb447c62e21df62ed33eafd Reviewed-on: https://chromium-review.googlesource.com/1136516Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#574989}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0cc291365934..210610261006 git log 0cc291365934..210610261006 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 jmadill@chromium.org Vulkan: Use angle::Result error handling. 2018-07-13 jmadill@chromium.org Add gl::ErrorSet and angle::Result. Created with: gclient setdep -r src/third_party/angle@210610261006 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ie5622320e955bea3a724e263dfd212f32db36dcf Reviewed-on: https://chromium-review.googlesource.com/1136732Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574988}
-
Ian Kilpatrick authored
The UseCounter at parse time is relatively high (0.09% of page loads): https://www.chromestatus.com/metrics/feature/timeline/popularity/924 However the parser typically over-estimates these things so added a layout time UseCounter. This should have no side-effects. Change-Id: Icaa5f0603cf6b6b21494df10a88463ecaf4c6b0f Reviewed-on: https://chromium-review.googlesource.com/1136713Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#574987}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7651c1611e6c..ed1205ae20b2 git log 7651c1611e6c..ed1205ae20b2 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 robertphillips@google.com Make GrRenderTargetOpList::purgeOpsWithUninstantiatedProxies match the GrTextureOpList version 2018-07-13 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 523c5e3122ed..0cc291365934 (1 commits) 2018-07-13 bungeman@google.com Improve SkTestFontMgr. 2018-07-13 robertphillips@google.com Add bullet proofing to image_subset GM for TSAN failures Created with: gclient setdep -r src/third_party/skia@ed1205ae20b2 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I4b4796ce9c67e6946ee80731b5c30560c96b3a13 Reviewed-on: https://chromium-review.googlesource.com/1136733Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574986}
-
Charlie Harrison authored
content_settings::Observers are not robust enough for metrics capture. A few problems: 1. It is impossible to tell if a setting change is meaningful (e.g. BLOCK -> BLOCK vs BLOCK -> ALLOW) 2. Some WebUIs trigger duplicate calls into observers If crbug.com/706061 is fixed, we can probably re-add some of this code. In the meantime, I will add a metric or two to the Android Preference UI, where we really need it and can log what we care about directly. This CL also cleans up and versions the SubresourceFilter.Actions histogram, which has a bunch of deprecated / not useful buckets. TBR=msw@chromium.org Bug: 823415 Change-Id: If2d42520b226b21b6a8e875876d733ea32656b11 Reviewed-on: https://chromium-review.googlesource.com/1081370 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574985}
-
Sheng-Hao Tsao authored
This CL adds cameraMediaConsolidated as one of the preference key value pairs that can be set through chromeosInfoPrivate API. The preference is useful for determining which camera app (Chrome camera app or Google camera app) to open when users click the camera icon. cameraMediaConsolidated preference Bug: 861952 Test: Chrome extension can call chromeosInfoPrivate.set() to set Change-Id: I8960734d5bb44712a86c7998081c91e750d963cd Reviewed-on: https://chromium-review.googlesource.com/1130543 Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#574984}
-
Sandra Sun authored
This reverts commit 0fc70abb. This patch increases the no-animation wait time to reduce flakiness. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Correctly initialize and test SnapContainerData in cc." > > This reverts commit 37061f87. > > Reason for revert: > The layout tests added by this CL is failing on the CL: > https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/37804 > > Original change's description: > > Correctly initialize and test SnapContainerData in cc. > > > > This patch initializes the rect_ field in SnapContainerData in copy > > constructor and move constructor. Fixing a snapping issue in the > > composited pages. > > > > We also adds external/wpt/css/css-scroll-snap/ to the virtual/threaded > > test suite so that they are tested with the composited cases. > > > > snap-at-user-scroll-end-manual-automation.js calls > > mouseClickInTarget() of pointerevent_common_input.js. That method > > invokes programmatic scrolls. The test was written before programmatic > > scroll snapping was implemented so it worked at that time. However, > > with programmatic scroll snapping implemented, it will always snap > > in mouseClickIntarget() and cannot test whether the user scroll snaps. > > This patch adds a parameter shouldScrollToTarget to mouseClickInTarget > > to avoid invoking programmatic scrolls in the test. > > > > This patch also checks nullptr for layout_box in > > ScrollManager::SnapAtGestureScrollEnd() to fix a crash. > > > > Bug: 862406, 862571 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > > Change-Id: I6a53818cf74421a4100ad6f908158abf302a5b8e > > Reviewed-on: https://chromium-review.googlesource.com/1132386 > > Commit-Queue: Sandra Sun <sunyunjia@chromium.org> > > Reviewed-by: Majid Valipour <majidvp@chromium.org> > > Reviewed-by: Robert Flack <flackr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#574781} > > TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org > > Change-Id: I55c77c05c0381c8ac638bd106d2d18b1b4332745 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 862406, 862571 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Reviewed-on: https://chromium-review.googlesource.com/1136171 > Reviewed-by: Taiju Tsuiki <tzik@chromium.org> > Commit-Queue: Taiju Tsuiki <tzik@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574825} TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org,tzik@chromium.org Change-Id: I85550f6f01b2466d8ceb03e44c15253079a5059c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862406, 862571 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1136613 Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#574983}
-
Jared Saul authored
Bug: 848955 Change-Id: Id591e9c5a5a54a8a4745758067746272c5dcae4b Reviewed-on: https://chromium-review.googlesource.com/1134178 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#574982}
-
Tiger Oakes authored
Previously percentages and symbol counts were misreported in diff mode, as the values did not match up with the total size. Percentages are now calculated based on the total delta of bytes changed, and the pie chart has an outer ring to indicate if that type of symbol reduced or increased. Counts have been updated to be more accurate now that we have small symbol buckets. A new property has been added to the data file that indicated how many symbols a symbol represents. Most symbols omit this key and default to 1 instead. Buckets indicate how many symbols they represent. Removed dex methods have a negative count to indicate they were removed, fixing the method count mode in diff mode. Bug: 847599 Change-Id: I20073dc20b89481733aaaa319f3b4966217c6096 Reviewed-on: https://chromium-review.googlesource.com/1135698 Commit-Queue: Tiger Oakes <tigero@google.com> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#574981}
-
Ryan Daum authored
Adds a new flag 'enable-top-drag-gesture' which must be explicitly enabled to turn on the top-drag gesture. Bug: internal b/111427398 Test: manual Change-Id: I5127db35a6eb418bddebf31939cea51240ddeaf2 Reviewed-on: https://chromium-review.googlesource.com/1136644 Commit-Queue: Ryan Daum <rdaum@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#574980}
-
Devlin authored
This reverts commit fa48bec9. Reason for revert: The new CHECK() is crashing, so it seems there is more to be cleaned up. We need to investigate further. Original change's description: > Extensions: Remove temporary cleanup code from crbug.com/558299 > > In the past, there was a bug where some themes incorrectly got synced > into the EXTENSIONS data type, so we added cleanup code to remove the > bad data. That was long ago and all bad data should be long gone now, > so let's get rid of the cleanup code. > > Bug: none > Change-Id: I53fcc8ecb208e9fce6565cda70ec57cc960f9b6c > Reviewed-on: https://chromium-review.googlesource.com/1124680 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572255} TBR=rdevlin.cronin@chromium.org,treib@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: none Change-Id: If10997927100f17c505eb83221770c47e4e04b7e Reviewed-on: https://chromium-review.googlesource.com/1136614Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574979}
-
Justin Cohen authored
Bug: 863476 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I864b2c054563e3b49f7ef87c4d2e85423c04e338 Reviewed-on: https://chromium-review.googlesource.com/1136669 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#574978}
-
Min Chen authored
Bug: 847587 Change-Id: Ibdebd9fbe6a66d323d0e309815424270efd53ad2 Reviewed-on: https://chromium-review.googlesource.com/1132608 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#574977}
-
mark a. foltz authored
Media route descriptions are not intended to be used as part of a larger string. This change brings the ChromeOS system tray strings in line with the current set of media route descriptions and avoids strings that start with "Casting Casting". Before/after screenshots: https://drive.google.com/drive/folders/1yPo-Gx_a2D6OGAQM715DU7vthKl2fH1o?usp=sharing Bug: 837394 Change-Id: Iac4a443a361ad3fd457059f6b4588ab2edc4ecda Reviewed-on: https://chromium-review.googlesource.com/1128330Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#574976}
-
Kim Paulhamus authored
TBR: tkent@chromium.org Bug: 863462 Change-Id: Ibbfbf97219e2f3515f8a93f11f8c2d406d53ecd7 Reviewed-on: https://chromium-review.googlesource.com/1136727Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#574975}
-
Min Qin authored
BUG=826998 Change-Id: If087340df35a26ee81f119e2470c96b5521df412 Reviewed-on: https://chromium-review.googlesource.com/1136659Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574974}
-
Gabriel Marin authored
This is a reland of 615e0342 Fixed tcmalloc include path in file //base/debug/profiler.cc, which is used when enable_profiling = true. Original change's description: > tcmalloc: Move existing tcmalloc files under gperftools-2.0. > > Move existing tcmalloc files, both vendor and chromium, under gperftools-2.0 > in preparation for upreving tcmalloc to the most recent gperftools version. > > This CL did: > > # Create a gerftools-2.0 folder. > mkdir gperftools-2.0 > > # Move vendor/ and chromium/ under the new folder. > git mv vendor gperftools-2.0/vendor > git mv chromium gperftools-2.0/chromium > > # Update //base/allocator/BUILD.gn to have tcmalloc_dir point to > # //third_party/tcmalloc/gperftools-2.0/chromium/src. > # Update addr2line-pdb sources in tcmalloc/BUILD.gn. > # Update include paths in files under //base/process and //base/allocator. > > This is old code that uses currently banned functions. > NOPRESUBMIT=true > > BUG=724399,b:70905156 > > Change-Id: I498a6edda48e178bbacfb41e30f75e9e96e336fc > Reviewed-on: https://chromium-review.googlesource.com/1130670 > Reviewed-by: Will Harris <wfh@chromium.org> > Commit-Queue: Gabriel Marin <gmx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574346} This is old code that uses currently banned functions. NOPRESUBMIT=true Bug: 724399, b:70905156 Change-Id: Icb15af2017e7d7e1e41322df6f17be54af71c528 Reviewed-on: https://chromium-review.googlesource.com/1135672Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#574973}
-
David Black authored
Known issue: Assistant UI should relaunch after successful opt in. See bug for demo. Bug: b:110986528 Change-Id: Icc1a2c2e00b630af37eda338dfb1a2acee4cc094 Reviewed-on: https://chromium-review.googlesource.com/1135788 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#574972}
-
Tiger Oakes authored
When a method has the @UiThread annotation, a call to ThreadUtils.assertOnUiThread will be injected at the start of the method. Similarily, @WorkerThread adds a call to ThreadUtils.assertOnBackgroundThread. This allows for easily asserting that a method can only be used on the UI or worker threads. Bug: 842695 Change-Id: Ic53b5d06d6b0581a81f1dcce72b46e7ab42313c0 Reviewed-on: https://chromium-review.googlesource.com/1070592Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Tiger Oakes <tigero@google.com> Cr-Commit-Position: refs/heads/master@{#574971}
-
Kim Paulhamus authored
TBR: ellyjones@chromium.org Bug: 863296 Change-Id: Idf257bcc95b35aceaaa2288f50d6f7cc9cf72f12 Reviewed-on: https://chromium-review.googlesource.com/1136719Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#574970}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/754b096de220..a738c2067f78 git log 754b096de220..a738c2067f78 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 wangge@google.com Added python script for download chrome for major milestones Created with: gclient setdep -r src/third_party/catapult@a738c2067f78 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ifd0442fe0c5e01381084b89fb2e808c1336f8a33 Reviewed-on: https://chromium-review.googlesource.com/1136397Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574969}
-
Aga Wronska authored
This allows for easier customization and showing of network dialog from different parts of OOBE flow. The corresponding OOBE screen will be added in a following change. Bug: 862445 Test: manually Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ibdf039d1b0b43bb704b3f4daf3f8cb2d0b0eff40 Reviewed-on: https://chromium-review.googlesource.com/1132552Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#574968}
-
erikchen authored
Change-Id: Ia38e827130b7cbb553a3954c5b5df58f506a7e70 Reviewed-on: https://chromium-review.googlesource.com/1136515Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#574967}
-
Nick Burris authored
Follow-up to http://go/chromium-review/1135194 - extension_names() was unintuitive as it was not filled until FetchExtensionNames was called. Instead, FetchExtensionNames now takes a set to fill with extension names using the given profile. - Forward extension names to UI by calling FetchExtensionNames in chrome_cleanup_handler. This completes the CLs adding extension IDs to the cleaner page, which I've confirmed by having a local cleaner build report extension IDs and confirmed that their names appear in the items list. Bug: 853339 Change-Id: I8d0c34fabb6c261c7e9b48c82a59a8fdb139674c Reviewed-on: https://chromium-review.googlesource.com/1135121Reviewed-by:
proberge <proberge@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Nick Burris <nburris@google.com> Cr-Commit-Position: refs/heads/master@{#574966}
-
Greg Kraynov authored
It was missed from BUILD.gn during the move from //cc. Three tests are broken and were disabled, see bug for details. Bug: 863422 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I83381ee2063b3c826a9923db98a5802eb6130db2 Reviewed-on: https://chromium-review.googlesource.com/1136548Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#574965}
-
Sammie Quon authored
Currently if the bubble is open, you cannot focus the items in the bubble using the keyboard. Also, if there are for example 4 items in the bubble and the bubble is closed, you have to tab 4 times to get from the last item on the main shelf to the first item. This cl makes the overflow bubble activatable, and focuses it when the index is out of visible bounds on the main shelf. The main shelf regains focus when the index is out of visible bounds on the overflow shelf. This cl also fixes when the overflow bubble is closed, there will not be need to press tab extra to loop back to the beginning. Test: add tests Bug: 854313 Change-Id: Ib36939952488ae23300062300bdc43a7b2a1e5fc Reviewed-on: https://chromium-review.googlesource.com/1125317Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#574964}
-
Christian Fremerey authored
Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1120856 This CL is a pure refactoring and has no intended function change. This CL is part of a series, see Design Doc at https://docs.google.com/document/d/1ihGDZloUGdDpZ5XfmiI3AcqsSxOP9kOe5GxXOTqpHW4/edit?usp=sharing Test: capture_unittests with physical camera attached Bug: 768887 Change-Id: Ia9bb5c832066d43d3a2295e9a6c97a31ebc266ed Reviewed-on: https://chromium-review.googlesource.com/1121239Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#574963}
-
proberge authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1133300 I changed how the padding of settings_toggle_button is calculated. This caused some issues in cases where clicking the row creates a button whose height is greater than the text's height, causing the entire row to expand vertically. This change applies the padding modifications to the text label instead of the entire outerRow, preventing the padding from applying based on the button's height instead of the text height. Bug: 862916 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I489f8e38d022452e448ab452def29ca02aa0a1cb Reviewed-on: https://chromium-review.googlesource.com/1135594 Commit-Queue: proberge <proberge@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#574962}
-
glevin authored
As per crbug.com/788024 Comment 10 and other observations: - Make error text darker (#D93025) - Dialog width = 448 (for reals this time) - Remove X (Close) button from upper right Bug: 788024 Test: Get yourself into some kinda pin-needin' situation and confirm the Harmonious nature of the pin-requestin' dialog. Change-Id: I7da3bffa3ff91434f651dd316a245cdf8d3f91a1 Reviewed-on: https://chromium-review.googlesource.com/1118609Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Greg Levin <glevin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574961}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d8df8c35a463..3a83fe5cf6cf git log d8df8c35a463..3a83fe5cf6cf --date=short --no-merges --format='%ad %ae %s' 2018-07-13 thestig@chromium.org Fix FPDF_ImportNPagesToOne() documentation. Created with: gclient setdep -r src/third_party/pdfium@3a83fe5cf6cf The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I78b31f5a0bffca9600b7733c90bf1f5d8d430347 Reviewed-on: https://chromium-review.googlesource.com/1136396Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574960}
-
David Black authored
Deep link launches Chrome OS feedback. Known issues: - Feedback UI launches behind Assistant UI. - Feedback does not attach Assistant server logs. See bug for demo. Bug: b:111222894 Change-Id: I6424cfdf633c1dfdfec1e91663259c2c04d810b5 Reviewed-on: https://chromium-review.googlesource.com/1134470 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#574959}
-
Johann authored
https://aomedia.googlesource.com/aom.git/+log/1c2430a2e13a..6eecfe927de9 $ git log 1c2430a2e..6eecfe927 --date=short --no-merges --format='%ad %ae %s' 2018-07-09 ddvfinite Add obmc add avx2 code 2018-07-12 debargha Fix build for CONFIG_COLLECT_RD_STATS option 2018-07-12 debargha Ensure rd_stats skip flag is set only if rate = 0 2018-07-10 weitinglin Adjust parameters of the customized GF structure 2018-07-10 weitinglin Add a new backward reference update rule 2018-07-10 weitinglin Replacing BWDREFs with ARFs (for GF=4 only) 2018-07-02 weitinglin Allow to fix the length of GF group. 2018-07-12 wtc Delete an obsolete TODO comment. 2018-07-11 kylesiefring x86 Jnt Subpel Variance: Handle Loads Correctly 2018-07-02 weitinglin Remove the dependency of using refresh_alt2_ref for rdctrl 2018-06-27 weitinglin Refactor: Clear the logic of buffer updates 2018-06-29 yunqingwang Add automated lightfield testing 2018-07-10 deepa.kg Move the setjmp into a function by itself 2018-07-09 debargha Fix sse computation for frame edge blocks 2018-07-09 debargha Use dist/sse_norm inst. of variance in nn-rd model 2018-07-11 wtc Clear cm->width and cm->height on alloc failure. 2018-07-11 tomfinegan rtcd.pl: Simplify parse of aom_config.h. 2018-07-09 yunqingwang Refactor read_and_decode_one_tile_list() 2018-07-09 yunqingwang Advance the image iterator correctly 2018-07-11 debargha Handle rd model for high-bitdepth correctly (...) Created with: roll-dep src/third_party/libaom/source/libaom Change-Id: I7403f9bc352afecd5988011642e8c939567cce51 Reviewed-on: https://chromium-review.googlesource.com/1136577Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#574958}
-
Aldo Culquicondor authored
VR input devices behave like laser pointers, leading to movements with lower precision as opposed to a mouse or a touchpad, due to natural shakiness of users. This change increases the slop when on VR browsing, as a factor of the platform's slop. Bug: 860321 Change-Id: I47906921ab41e69b7bc4e427ebbd327ae8f7d9bf Reviewed-on: https://chromium-review.googlesource.com/1134088 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#574957}
-
Wez authored
Bug: 844016 Change-Id: I5b4a92b25ae7f02c3d298241f283345a4ac58b4e Reviewed-on: https://chromium-review.googlesource.com/1136657Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#574956}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4a17501f5bbd..7651c1611e6c git log 4a17501f5bbd..7651c1611e6c --date=short --no-merges --format='%ad %ae %s' 2018-07-13 caryclark@skia.org refresh generated includes 2018-07-13 caryclark@skia.org fix bookmaker Created with: gclient setdep -r src/third_party/skia@7651c1611e6c The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: Id9e88aa43427f7ec3e730192f9f30d7be3cba193 Reviewed-on: https://chromium-review.googlesource.com/1136394Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574955}
-
Xiangjun Zhang authored
This CL adds the implementation to check the preference of enabling/disabling media remoting. The remoting dialog is only shown when user has not set the preference. The preference can be set through the remoting dialog. Though this CL doesn't clear the preference once it is set. This will be done in a later CL. Bug: 849020 Change-Id: I89c4ed6b71a2e51bd81fae919531d15b53664b18 Reviewed-on: https://chromium-review.googlesource.com/1125355 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#574954}
-
Jialiu Lin authored
Google login page allows users to input their Gmail prefix or input the full gmail email address for sign-in. For example, user's gmail is user@gmail.com, then on https://accounts.google.com..., typing "user" or "user@gmail.com" as username have the same effect. However, current HashPasswordManager treats them as two separate accounts when saving password hashes. This CL improves the canonicalization of username by appending "@gmail.com" to PasswordHashData.username if it is a Gmail email prefix. Note that Dasher account always require full email as username. Bug: 858865 Change-Id: I9ddf23f54ee67bd73bd754953a3b80758e062ef3 Reviewed-on: https://chromium-review.googlesource.com/1135906Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#574953}
-
Tom Anderson authored
bootstrap.py does not exist in the gn.googlesource.com repo. The script gen/build.py is used instead. However, there are some differences to bootstrap.py: one obvious one is the name and location. This breaks chromium packagers relying on bootstrap.py, so this change adds the script back. In the long-term, it should forward to gen.py. BUG=859536,863459,863460 Change-Id: I59ff81acb7f409d1975f99bcf0676e6103b2d7b9 Reviewed-on: https://chromium-review.googlesource.com/1136656 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#574952}
-
Robert Sesek authored
In Mojave, apps should provide a reason string that will be shown in the OS-mediated permission prompt for protected resources (e.g., camera, microphone, location). This adds the reason string and places it in the InfoPlist.strings files. Bug: 850175 Change-Id: I1b5c250aa50a2b4086e95c34521a82fae2405ea1 Reviewed-on: https://chromium-review.googlesource.com/1135114Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#574951}
-