GitLab

TBR=noelutz
OWNER of chrome/browser/safe_browsing folder,
for trivial change of returning false instead of base class' true.
Being exercised already by other derived classes, e.g., ExtensionDisabledGlobalError

We will want to merge this to M39 once it gets added to Canary, hopefully tomorrow...
BUG=419049

Review URL: https://codereview.chromium.org/616143002

Cr-Commit-Position: refs/heads/master@{#297518}

MigrationSingleClientTest.AllTypesIndividually
MigrationSingleClientTest.AllTypesIndividuallyTriggerNotification

TBR=jam@chromium.org
BUG=403778

Review URL: https://codereview.chromium.org/616093004

Cr-Commit-Position: refs/heads/master@{#297517}

BUG=419064

Review URL: https://codereview.chromium.org/614093004

Cr-Commit-Position: refs/heads/master@{#297516}

BUG=414340
R=yoz@chromium.org

Review URL: https://codereview.chromium.org/617703002

Cr-Commit-Position: refs/heads/master@{#297515}

On small screen devices, such as one with 800x480 resolution,
time picker does not render correctly, and sometimes causes a crash.

This adds a layer of ScrollView so that time picker can be accessed
and rendered correctly.

BUG=407543

Review URL: https://codereview.chromium.org/604243002

Cr-Commit-Position: refs/heads/master@{#297514}

This is the first step toward making remote frames able to be navigated by their parent correctly, and to enable them to transition back into the same process as the parent.

This, combined with https://codereview.chromium.org/573353002/, "just work" to route a navigation request from a RemoteFrame back to its LocalFrame. However, we incorrectly commit the load into the existing LocalFrame (rather than transitioning processes again) and we assert during that commit.

BUG=

Review URL: https://codereview.chromium.org/574403002

Cr-Commit-Position: refs/heads/master@{#297513}

Revert of Ensure that the browser’s copy of page id is in sync with the renderer’s. (patchset #3 id:40001 of https://codereview.chromium.org/609943002/)

Reason for revert:
Crash data coming in, in version 40.0.2174.0.
See http://crbug.com/419129 for details.

Original issue's description:
> Ensure that the browser’s copy of page id is in sync with the renderer’s.
>
> This is likely to crash, and so has debugging statements.
>
> BUG=407376
> TEST=no crashing, we hope
>
> Committed: https://crrev.com/af3e9e0b1325f0f4aaaf784c1379ffa34a20c31e
> Cr-Commit-Position: refs/heads/master@{#297263}

TBR=rsesek@chromium.org,avi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=407376

Review URL: https://codereview.chromium.org/616163002

Cr-Commit-Position: refs/heads/master@{#297512}

BUG=none
R=
TEST=none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/604833006

Cr-Commit-Position: refs/heads/master@{#297511}

Make Page subclasses UserStory & PageSet subclasses UserStorySet.

BUG=418278

Review URL: https://codereview.chromium.org/612963002

Cr-Commit-Position: refs/heads/master@{#297510}

Review URL: https://codereview.chromium.org/616933003

Cr-Commit-Position: refs/heads/master@{#297509}

Review URL: https://codereview.chromium.org/610293003

Cr-Commit-Position: refs/heads/master@{#297508}

BUG=

Review URL: https://codereview.chromium.org/618753003

Cr-Commit-Position: refs/heads/master@{#297507}

Revert of Pending tasks in a message loop should be deleted before shutting down Blink (patchset #9 id:160001 of https://codereview.chromium.org/583043005/)

Reason for revert:
BUG=418206

broke canary AGAIN! please do NOT reland without fixing! https://code.google.com/p/chromium/issues/detail?id=418206

Original issue's description:
> Pending tasks in a message loop should be deleted before shutting down Blink
>
> Currently Blink is shut down before all the pending tasks in the message loop are deleted. This is problematic in Oilpan because a destructor of the pending tasks can touch Oilpan objects. Because Oilpan is already detached from the renderer thread at that point, touching Oilpan objects in the destructor leads to a crash. (See the bug report for a concrete scenario.)
>
> To prevent Blink objects from getting accessed after Blink is shut down, this CL deletes all pending tasks in a message loop before shutting down Blink.
>
> BUG=411026
> TEST=None. I cannot reproduce the crash.
>
> Committed: https://crrev.com/fdd5612c20f777e1279efd7c1e99d82ed04afaaf
> Cr-Commit-Position: refs/heads/master@{#296697}
>
> Committed: https://crrev.com/16d32a9f7f6d1ebb639cacedb5156272a9fec764
> Cr-Commit-Position: refs/heads/master@{#297338}

TBR=tkent@chromium.org,jochen@chromium.org,jamesr@chromium.org,ager@chromium.org,jar@chromium.org,haraken@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=411026

Review URL: https://codereview.chromium.org/614233002

Cr-Commit-Position: refs/heads/master@{#297506}

We will remove this suppression once all of the builders support the L SDK.

BUG=405174,398669,411361,411366,411367,411376,416041

Review URL: https://codereview.chromium.org/615163002

Cr-Commit-Position: refs/heads/master@{#297505}

This really handles two cases. (I want to remove these altogether, but
splitting them up helps my sanity.)

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/612903003

Cr-Commit-Position: refs/heads/master@{#297504}

Resubmitting: https://codereview.chromium.org/580293002/

Reason: bisect-perf-regression.py was renamed.

BUG=

Review URL: https://codereview.chromium.org/617963003

Cr-Commit-Position: refs/heads/master@{#297503}

Prep to create browsertest for athena. as it needs to exclude most of tests first.

BUG=None

Review URL: https://codereview.chromium.org/614173002

Cr-Commit-Position: refs/heads/master@{#297502}

BUG=418851
TBR=bauerb@chromium.org

Review URL: https://codereview.chromium.org/613333002

Cr-Commit-Position: refs/heads/master@{#297501}

The MSDN document suggests that with overlapped I/O, |lpNumberOfBytesRead|
parameter of ReadFile() API isn't reliable and shouldn't be used.
GetOverlappedResult() should be used instead, according to the doc.
See: http://msdn.microsoft.com/en-us/library/windows/desktop/aa365467(v=vs.85).aspx

This is a speculative crash fix for crbug.com/41509. The crash happens
only on Windows. The report also implies that there might be some
message duplication.It is possible if the value of |lpNumberOfBytesRead|
is wrong.

BUG=415059
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/616043003

Cr-Commit-Position: refs/heads/master@{#297500}

BUG=414808
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/615043004

Cr-Commit-Position: refs/heads/master@{#297499}

When linking with >=10.9 SDK, NSThemeFrame will have wantsLayer=YES and
wantsUpdateLayer=YES, resulting in the swizzled drawRect to be ineffective
(updateLayer is called instead of drawRect).
This patch moves the drawing of the theme image behind the tab strip area
to use a small subview instead. This subview is positioned at the top of the
window, behind its sibling views. The view will redraw when the window's
activation state changes because the theme image may be different.

NativeAppWindowCocoa is another user of the swizzled drawRect, so I'm not
removing the swizzling yet in this CL.

BUG=417872

Review URL: https://codereview.chromium.org/611453004

Cr-Commit-Position: refs/heads/master@{#297498}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/07d889d..11ceb35

TBR=zmo@chromium.org,eustas@chromium.org

Review URL: https://codereview.chromium.org/617023002

Cr-Commit-Position: refs/heads/master@{#297497}

BUG=chromedriver:906

Review URL: https://codereview.chromium.org/605143002

Cr-Commit-Position: refs/heads/master@{#297496}

Part of the PlzNavigate navigation refactoring project. This CL implements CommitNavigation on the browser side, so that the proper parameters can be passed to the renderer when navigations are ready to commit.

BUG=376091

Review URL: https://codereview.chromium.org/483773002

Cr-Commit-Position: refs/heads/master@{#297495}

This change moves mock and test classes related to DeviceInfo
datatype to components/sync_driver and removes dependencies
on chrome and content layers.

The change is mostly trivial / mechanical renaming.

BUG=396136
TBR=jyasskin@chromium.org,pkasting@chromium.org,ben@chromium.org

Review URL: https://codereview.chromium.org/612103005

Cr-Commit-Position: refs/heads/master@{#297494}

Now settings page from Chrome OS does not apply uber.css.

BUG=178819,412272

Review URL: https://codereview.chromium.org/613683004

Cr-Commit-Position: refs/heads/master@{#297493}

BUG=

Review URL: https://codereview.chromium.org/613313002

Cr-Commit-Position: refs/heads/master@{#297492}

BUG=404771

Review URL: https://codereview.chromium.org/616923002

Cr-Commit-Position: refs/heads/master@{#297491}

There is a lot of unreached image transport code due to
- TextureImageTransportSurface actually being unused
as a transport surface now (we either use delegated rendering
or composite-to-mailbox)
- Mac using delegated rendering

TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/615503004

Cr-Commit-Position: refs/heads/master@{#297490}

Currently even if a valid file is selected the OpenFileDialog is likely
to return an emtpy FilePath, depending on what is in memory after the
sole string returned by the Windows OFD. The code as written assumes
the Windows OFD will always return a null-terminated list of
null-terminated strings when returning successfully from the call to
the OFD. However if you check the MSDN documentation at:

http://msdn.microsoft.com/en-us/library/windows/desktop/ms646839(v=vs.85).aspx

You will find this is not the case, and the return value depends on the
presence of OFN_ALLOWMULTISELECT in the Flags argument. If that value
is not set, which it is not in the case of single-file selection, then
there is only a single string in |openfilename_.lpstrFile|, and the
code within OpenFileName::GetResult() blows past that single NULL and
into unitialized memory, which ::GetSingleResult then assumes means
an invalid return filename and returns the empty FilePath.

This CL repairs that situation so that GetSingleResult now DCHECKS
that the OFN_ALLOWMULTISELECT is not there and returns the string
directly, and ::GetResult() asserts that the flag is present and
continues to do its multi-value parsing that it was doing before.

BUG=418760
TEST=Launch Chrome, hit CTRL+O to open a file, chose a valid test html
file, observe that the browser doesn't crash and successfully opens that
file.

Review URL: https://codereview.chromium.org/618503002

Cr-Commit-Position: refs/heads/master@{#297489}

This CL depends on blink side CL https://codereview.chromium.org/590183003/

BUG=282016

Review URL: https://codereview.chromium.org/591363003

Cr-Commit-Position: refs/heads/master@{#297488}

BUG=

Review URL: https://codereview.chromium.org/607273002

Cr-Commit-Position: refs/heads/master@{#297487}

BUG=None

Review URL: https://codereview.chromium.org/613243002

Cr-Commit-Position: refs/heads/master@{#297486}

Allow SkiaBitLockers to specify that they should record a bitmap at
a specified scale. Callers that know that they will be replayed at a
given scale factor can specify the final scale during record.

BUG=408557

Review URL: https://codereview.chromium.org/611253004

Cr-Commit-Position: refs/heads/master@{#297485}

Remove assert() from getChildElement() to fix the bug caused by https://chromiumcodereview.appspot.com/575333002/

BUG=418532
R=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/617973002

Cr-Commit-Position: refs/heads/master@{#297484}

Reenable Valgrind runs for CastTransport unit tests.

R=miu,oshima
BUG=418767
TBR=wez@chromium.org

Review URL: https://codereview.chromium.org/598333003

Cr-Commit-Position: refs/heads/master@{#297483}

* Changes Tab::LoadIfNeeded()/Tab.loadIfNeeded() to return true
  if the call was "handled" and false if it failed.

* DevTools checks if LoadIfNeeded() fails, and bails out if it
  does.

BUG=403592

Review URL: https://codereview.chromium.org/618513002

Cr-Commit-Position: refs/heads/master@{#297482}

BUG=354261
R=brettw
TBR=piman,wtc
NOTRY=true

Review URL: https://codereview.chromium.org/603143002

Cr-Commit-Position: refs/heads/master@{#297481}

BUG=411131
R=navabi@chromium.org

Review URL: https://codereview.chromium.org/614083003

Cr-Commit-Position: refs/heads/master@{#297480}

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/612183002

Cr-Commit-Position: refs/heads/master@{#297479}