- 15 Aug, 2018 40 commits
-
-
Elly Fong-Jones authored
This change: 1) Adds logic to EventMonitorMac so that if an event is marked handled by the client of EventMonitorMac, the event is not handled further - i.e., EventMonitorMac can now eat events; 2) Renames the existing MenuPreTargetHandler to MenuPreTargetHandlerAura; 3) Adds MenuPreTargetHandlerMac which uses EventMonitorMac; 4) Adds MenuPreTargetHandler::Create to manufacture the platform-appropriate MenuPreTargetHandler instance. Bug: 867127 Change-Id: I33f7c750598b0496fa291434098f8019e4b99c47 Reviewed-on: https://chromium-review.googlesource.com/1174568 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#583254}
-
W. James MacLean authored
TBR=xidachen@chromium.org Bug: 874370 Change-Id: Iefa082753ae148d2bd72a6a1925124d6360aa1a7 Reviewed-on: https://chromium-review.googlesource.com/1175844Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#583253}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/091d6f21..e756beb7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4d77df256a6f6a4a905a2b93e11a4c946a21ce30 Reviewed-on: https://chromium-review.googlesource.com/1175700Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583252}
-
Manu Cornet authored
Bug: 805612 Change-Id: I6887eeb37f88c94b2e53b4fa6b1aad8ed95f2b76 Reviewed-on: https://chromium-review.googlesource.com/1173251Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#583251}
-
Xida Chen authored
See failure here: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/39305 TBR=wjmaclean@chromium.org NOTRY=true Bug: 832274 Change-Id: I085d84dedb9cb68814dc6c58dd71da7a1619468f Reviewed-on: https://chromium-review.googlesource.com/1175846Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583250}
-
Lan Wei authored
In GpuBenchmarking, for mouse wheel and touchpad scroll, we want to add "has_precise_scrolling_deltas" scroll option to GpuBenchmarking::SmoothScrollBy. Bug: 871970 Change-Id: I456db492e2a7fdab35263efe931d089b400a9e3d Reviewed-on: https://chromium-review.googlesource.com/1166165Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#583249}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/32c7d4dfcdca..49bb9c17d713 git log 32c7d4dfcdca..49bb9c17d713 --date=short --no-merges --format='%ad %ae %s' 2018-08-15 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 2363356f52f6..21e5e85a4976 (1 commits) 2018-08-15 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-15 bungeman@google.com Update CCPRGeometry to use pool for op. 2018-08-14 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-14 reed@google.com add tests for cubicmap 2018-08-14 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 35bc74d6d139..2363356f52f6 (1 commits) 2018-08-14 mtklein@google.com implement SkConvertPixels color xform with steps 2018-08-14 reed@google.com inline strcmp for faster json parsing 2018-08-14 bungeman@google.com Update FreeType to use isSubpixel and isVertical. 2018-08-14 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-14 brucewang@google.com Implement SubPixel mode support for FreeType COLR/CPAL 2018-08-14 robertphillips@google.com Remove unused parameter from drawPathWithMaskFilter 2018-08-14 fmalita@chromium.org [skottie] Eliminate some temp SkString allocations 2018-08-14 mtklein@google.com pass sprite opacity to color xform when blitting. Created with: gclient setdep -r src/third_party/skia@49bb9c17d713 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I085fe37fc263d923c45377767089449dca924f32 Reviewed-on: https://chromium-review.googlesource.com/1174802Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583248}
-
Keishi Hattori authored
This reverts commit bea6537a. Reason for revert: clusterfuzz found many issues crbug.com/874396 crbug.com/874420 crbug.com/874431 crbug.com/874425 crbug.com/874430 crbug.com/874429 crbug.com/874423 crbug.com/874404 Original change's description: > Change SMILTimeContainer::scheduled_animations_ to use ephemeron > > WeakMember as part of a HashMap entry can cause unexpected clearing when incremental marking is enabled. > > This CL changes SMILTimeContainer::scheduled_animations_ to use a epehemeron instead. > > Bug: 870306 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I8b653825de0bc683a5151576385716141c78c454 > Reviewed-on: https://chromium-review.googlesource.com/1166753 > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583156} TBR=pdr@chromium.org,haraken@chromium.org,keishi@chromium.org,mlippautz@chromium.org Change-Id: Id727b6da2d0a42341bde5d9f6c2c9f32a43d447e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870306 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1175881Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#583247}
-
Alexey Kozyatinskiy authored
On pause when we get expression for popover we by mistake include spread operator when we should not. R=einbinder@chromium.org Bug: chromium:797296 Change-Id: I9a5eaa5df045874ec82056081e01e4c4a308ae87 Reviewed-on: https://chromium-review.googlesource.com/1041276 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#583246}
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 520736 Change-Id: I56a80554562d29ee0b638ed95e9d0e1e713105c2 Reviewed-on: https://chromium-review.googlesource.com/1175436Reviewed-by:
-
Juan Antonio Navarro Perez authored
Add function on perf_data_generator to keep the list of active platform configurations in //docs/speed/perf_lab_platforms.md up to date. Bug: 871746 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I8d95651ad0480f7eb21b8aa6c95af5b75d37da94 Reviewed-on: https://chromium-review.googlesource.com/1166919 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#583244}
-
Fabio Tirelo authored
This CL: - Creates a new feature/flag to allow customization of the text and background colors when a field shows an Autofill suggestion; Each color is defined by its own parameter in the study. - Moves the previous style from html.css and build the CSS rules instead in LayoutTheme::ExtraDefaultStyleSheet using either the colors defined by the parameters (when the feature is enabled) or the current preview colors as a fallback (default and invalid color cases). Variations provided for the new chrome://flags entry correspond to the experiment palletes proposed by UX (see details on the bug). One alternative that I considered: - Define a single param in the study for the experiment group (so flag variations and param values would have a 1:1 correspondence); - Define a separate CSS file for each variation, similar to what's currently done LayoutThemeDefault::ExtraDefaultStyleSheet. That alternative would be less flexible, but it would be more similar cases handled in blink (in fact, I couldn't find any place where the CSS is built in the code). Please let me know if you think that alternative should be used instead. Bug: 874094 Change-Id: I257c72b9a3db32a2945ec4048e46b23e4b5dd2be Reviewed-on: https://chromium-review.googlesource.com/1174710 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#583243}
-
Philip Jägenstedt authored
TBR=chrishtr@chromium.org Bug: 866165 Change-Id: I476ba02235677f81f76dc9899e01c6436d4c5aac No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1175828Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#583242}
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 874417 Change-Id: Ide6bc7a1fd7d8cc25d96204a2e43f446d2782c3d Reviewed-on: https://chromium-review.googlesource.com/1175842 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
-
Helen Li authored
Bug: 874152 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I45441e5fdd8eaa4b0e39144cd94d610d3f98f368 Reviewed-on: https://chromium-review.googlesource.com/1174935 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583240}
-
Oskar Sundbom authored
Adds some mojo interfaces for configuring audio processing, intended for both WebRTC and system-level echo cancellation, though the latter will be less configurable. There are two parts to this change: 1. AudioProcessingSettings in media/audio, used to configure audio processing when done in the audio service. At one point, the similar AudioProcessingParameters in content will be replaced by this one. 2. AudioProcessorControls in media/webrtc; an interface used to control auxiliary audio processor functionality, specifically getting stats and starting/stopping AEC dumps. For an outline of the project this CL is part of, see: https://docs.google.com/document/d/1u4POff_ts_1LE3WDLA_wDDFnUswdlsuHL5DsiTE0a3U/edit?usp=sharing It's accessible to everyone @chromium.org. Bug: 851959 Tbr: tommi@webrtc.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0c8c934b35b93aa728a0d1b60ae76063e925ee6c Reviewed-on: https://chromium-review.googlesource.com/1167848 Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#583239}
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 874444 Change-Id: Idce66af34aa8a41d8cd300df559a48fca8409040 Reviewed-on: https://chromium-review.googlesource.com/1175699Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 220edbbe. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22761 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I10efc0a14f67840d2c7a23a756ee51c5ac857111 Reviewed-on: https://chromium-review.googlesource.com/1175694 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#583237}
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 874442 Change-Id: I4cfa885ab90c473e6b7be3212f12fbe15e2fdd03 Reviewed-on: https://chromium-review.googlesource.com/1175433 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
-
Peter Wen authored
All of these targets are now in android_deps and aliased there. No need to keep these duplicate .info files and BUILD.gn file. Bug: 868879 Change-Id: Ie449b546328486072d00a319b681cd7512b8ea5a Reviewed-on: https://chromium-review.googlesource.com/1173061Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583235}
-
Max Moroz authored
This reverts commit 893477c1. Reason for revert: fuzzing builds are broken Bug: 874440 Original change's description: > Update V8 to version 7.0.237. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/091d6f21..e756beb7 > > Please follow these instructions for assigning/CC'ing issues: > https://github.com/v8/v8/wiki/Triaging%20issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: I702f87ee6b81d81afbe4179fc51e87b2ef59f7e9 > Reviewed-on: https://chromium-review.googlesource.com/1175692 > Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#583224} TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifc29efdd8938af057ed1026cd24533ee802f7e29 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1175463Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#583234}
-
Mugdha Lakhani authored
Implement BackgroundFetch State for BackgroundFetchRegistration. Bug: 873630 Change-Id: I121f3bf55ea51bfa9b529175ccd5de951156ead9 Reviewed-on: https://chromium-review.googlesource.com/1172783 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#583233}
-
W. James MacLean authored
This CL revises a DCHECK that has been firing (erroneously) when Flash content is loaded inside a WebView. Bug: 873672 Change-Id: I75c12c67b47a5b337054a262991d23247bbbb4ea Reviewed-on: https://chromium-review.googlesource.com/1173359Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#583232}
-
Xida Chen authored
See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/4709 TBR=wjmaclean@chromium.org NOTRY=true Bug: 827209 Change-Id: Ife32a29fc4928d037246bd20488917860807366d Reviewed-on: https://chromium-review.googlesource.com/1175698 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
-
Peter E Conn authored
When a Trusted Web Activity is launched (a Custom Tab is launched with android.support.customtabs.extra.LAUNCH_AS_TRUSTED_WEB_ACTIVITY) it now launches into a CustomTabActivity instead of a WebappActivity. This CustomTabActivity has a TrustedWebActivityUi that tracks whether we are on an origin that the client is verified for, and hides the top bar if this is the case. When the client leaves the verified origin, the top bar is shown and the CustomTabActivity acts like a normal Custom Tab (including things like styling and such). This also adds a "Running in Chrome" disclosure that shows once per client app until dismissed. Bug: 871266 Change-Id: I02927501f93d49353db02f5130714a16b512b08b Reviewed-on: https://chromium-review.googlesource.com/1169604 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#583230}
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 874428 Change-Id: Ie5973dd0f214a53743f59a3bfb63553495eccfe6 Reviewed-on: https://chromium-review.googlesource.com/1175697 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
It's flaky on MacOS 10.10 TBR=lilyhoughton@chromium.org Bug: 874419 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ib6cdc760ab0c6400eec0ba3a2e6901b079412722 Reviewed-on: https://chromium-review.googlesource.com/1175799 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#583228}
-
Xida Chen authored
According to flakiness dashboard, this is flaky on all platform that is running the test https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=network_service_browser_tests&tests=AdTaggingBrowserTest.VerifyCrossOriginWithoutNavigate TBR=wjmaclean@chromium.org NOTRY=true Bug: 874424 Change-Id: Ic737edd9bb502b4472feb0163f2f823f110a2174 Reviewed-on: https://chromium-review.googlesource.com/1175696Reviewed-by:
-
Fredrik Söderquist authored
TBR=schenney@chromium.org BUG=872697 Change-Id: Ib925da7763c4091feacfd489bce1c82c752309ef Reviewed-on: https://chromium-review.googlesource.com/1175796Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#583226}
-
Makoto Shimazu authored
Shared workers are the last workers which dones't watch updates in RendererPreferences. This CL creates RendererPreferenceWatcher for shared workers and sent it on a CreateSharedWorker message. TBR=avi@chromium.org Bug: 1170673 Change-Id: I562a23ea8b87ae0fb1bc07f62cc79174fe2c455f Reviewed-on: https://chromium-review.googlesource.com/1175584 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#583225}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/091d6f21..e756beb7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I702f87ee6b81d81afbe4179fc51e87b2ef59f7e9 Reviewed-on: https://chromium-review.googlesource.com/1175692Reviewed-by:
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 873435 Change-Id: I2c68d19a86abddf00a3420850fd03a59acb26647 Reviewed-on: https://chromium-review.googlesource.com/1175695 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
-
Ned Nguyen authored
Bug: 868306 Change-Id: I211019451b72a743e306c736241aea27a5d2accc Reviewed-on: https://chromium-review.googlesource.com/1175430Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#583222}
-
Finnur Thorarinsson authored
This implements the CategoryView, showing all contacts in a list, allowing for selection and reporting back. Bug: 860467 Change-Id: I83d7e068ab7e2c6cd97631f9f79204042c49bd77 Reviewed-on: https://chromium-review.googlesource.com/1172787 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#583221}
-
Alexander Semashko authored
Now it will quit the message loop immediately after receiving the notification. Also it does not allow nested tasks anymore. Flaky test DeviceLocalAccountExternalPolicyLoaderTest.ForceInstallListSet is termporarily disabled. TBR=jam@chromium.org Bug: 668707,865453 Change-Id: I1cbceb298311a9b7905c0cec410cb82330effccd Reviewed-on: https://chromium-review.googlesource.com/1146700 Commit-Queue: Alexander Semashko <ahest@yandex-team.ru> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#583220}
-
Ned Nguyen authored
This CL remove expectations on configurations that are now obsolete: Android_One & Nexus_7 Change-Id: I61937ea92f9f165c52e63d07e4343384bfb0ea96 NOTRY=true # not affecting CQ Change-Id: I61937ea92f9f165c52e63d07e4343384bfb0ea96 Reviewed-on: https://chromium-review.googlesource.com/1175429 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
-
Morten Stenshorne authored
This reverts commit c463a13b. Reason for revert: FindIt is right. This CL made BrowserShutdownBrowserTest.ShutdownConfirmation flaky. Original change's description: > Repurpose the confirm-quit-bubble to a quit-instruction-bubble > > It was decided in [1] that the Ctrl+Shift+Q shortcut should be removed > altogether and replaced with a bubble giving an alternative way to quit using > the keyboard (similar to the "Press Alt+Left to go back" bubble). > > [1] https://docs.google.com/document/d/1mvTBrxD58GIsqFiqgiLCZiXy1iOtDpQx_Tp5OSuYWEU/edit?usp=sharing > > BUG=243164 > R=sky > > Change-Id: I47578d6b750c45fbc5d0a6e6ffe7e5f528dbe80d > Reviewed-on: https://chromium-review.googlesource.com/1173654 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583138} TBR=sky@chromium.org,thomasanderson@chromium.org Change-Id: I29ba82785756fddcd8e8c6bb30b6069c89cf58a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 243164 Reviewed-on: https://chromium-review.googlesource.com/1175801Reviewed-by:
-
Devlin Cronin authored
In order to extract apps-specific code from extensions, we'll need to be able to add extra information to the extensions client from outside extensions code. This will require having a centralized initialization for the extensions client. Introduce a single method, EnsureExtensionsClientInitialized(), which constructs and sets the ChromeExtensionsClient. Remove the old way of constructing the client, ChromeExtensionsClient::GetInstance(). Update all callers to construct the client via the new method. While we're at it, update the client to use base::NoDestructor instead of LazyInstance. Bug: 873937 Change-Id: I47147cd5f33ea44079c0a319626c57f3c5813af8 Reviewed-on: https://chromium-review.googlesource.com/1175459 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#583217}
-
Kyoko Muto authored
The tests demonstrate that nodes which are not connected to host should not be assigned to slot, and slotting API should not have any effect in auto mode. Change-Id: I9403f386f457cd198813d0f49e50cacf1ac23b4b Reviewed-on: https://chromium-review.googlesource.com/1175505 Commit-Queue: Kyoko Muto <kymuto@google.com> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#583216}
-
Morten Stenshorne authored
This reverts commit a2ce204c. Reason for revert: Sorry, still flaky; see crbug.com/874380 Original change's description: > Reenable PasswordGenerationInteractiveTest.AutoSavingGeneratedPassword. > > Bug: 791389 > Change-Id: Iea3b6e0f2ec7899e099bd9d7e23017ac4c83e459 > Reviewed-on: https://chromium-review.googlesource.com/1170908 > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582537} TBR=vasilii@chromium.org,dvadym@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 791389, 874380 Change-Id: I1551a9ae472ef3e6645622951bdfcd87f2fb74c7 Reviewed-on: https://chromium-review.googlesource.com/1175761Reviewed-by:
-
