GitLab

Prior to this CL, the load event was not being fired when the
textContent of a <style> element was changed, contrary to the
spec ([1]). Now, the load event is fired in this case.

Note that when textContent is changed, per spec [2], the children
changed steps are run. This first removes the existing <style>
contents, which once complete, fires a "load" event. Then the new
<style> contents are parsed, after which another "load" event is
fired. So in the example of 674518, two load events will now be
fired when the style is changed.

[1] https://html.spec.whatwg.org/multipage/semantics.html#update-a-style-block
[2] https://dom.spec.whatwg.org/#concept-node-children-changed-ext

Fixed: 674518

Change-Id: Idb0ddb9f0ca2478a8a35d06817928503e74fa3fb
Bug: 674518
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011133
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734147}

Following errors by eslint are not automatically fixed.
I fixed these manually.
(Used eslint-disable-next-line for redefining global object.)

/ui/file_manager/file_manager/test/js/chrome_api_test_impl.js
   13:1  error  Unexpected var, use let or const instead  no-var
  152:9  error  Unexpected var, use let or const instead  no-var
/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
  283:1  error  Unexpected var, use let or const instead  no-var
/ui/file_manager/file_manager/test/js/test_util.js
    8:1  error  Unexpected var, use let or const instead  no-var
  376:3  error  Unexpected var, use let or const instead  no-var

Bug: 778674
Test: Run browser_tests/closure_compiler
Change-Id: Ifeccd95fd0c459c5752855ef7f218d646bd6c6ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014600
Commit-Queue: Noel Gordon <noel@chromium.org>
Auto-Submit: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734146}

https://quiche.googlesource.com/quiche.git/+log/dfabdfb6884b..f579b5e51aaf

$ git log dfabdfb68..f579b5e51 --date=short --no-merges --format='%ad %ae %s'
2020-01-21 nharper Refactor TlsServerHandshaker to implement QuicCryptoServerStreamBase directly
2020-01-21 fayang Disable gfe2_restart_flag_quic_default_on_ietf_loss_detection in QuicEndpointTest.Competition while investigating the issue.
2020-01-21 wub gfe-relnote: (n/a) Change the return value of QuicUdpSocketApi::ReadMultiplePackets from number of good packets to number of total packets read. Code not used yet.
2020-01-21 bnc Use quiche_export instead of http2_export.
2020-01-21 ianswett gfe-relnote: Add a connection option(1ACK) to send only one immediate ACK in QUIC after reordering, instead of 4.  Protected by gfe2_reloadable_flag_quic_one_immediate_ack

Created with:
  roll-dep src/net/third_party/quiche/src

Change-Id: I6a3b22464f673884affc55883c090a8df1dead3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014053
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Auto-Submit: Bence Béky <bnc@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734145}

It remains disabled by default by the tracing flag
--enable-features=kEnablePerfettoSystemTracing, but when enabled will
attempt to connect to the result of GetProducerSocket().

This will be useful for people who want system wide tracing on linux
from crashed browser processes since the tracing service will be alive
even after Chrome dies.

Bug: 1007310
Change-Id: I62e67bcdc9ff720da2a59497a6d3ebf855413b8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953718
Auto-Submit: Stephen Nusko <nuskos@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734144}

This addresses a TODO in SyncServiceCrypto about honoring the result of
MarkKeysAsStale(), which is called when a previous call to FetchKeys()
returns keys that are insufficient to resolve the encryption issue.

If MarkKeysAsStale() reports true, it suggests another FetchKeys()
attempt is worth (usually meaning some local cache was invalidated).
This means another FetchKeys() call should be issued, as a second and
last attempt to resolve the encryption issue.

Bug: 1012659
Change-Id: Idd766233d0cacd2fb1030ca107e51efd667ad414
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003132
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734143}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2e45f00d3687..04ccecc2d7b2

git log 2e45f00d3687..04ccecc2d7b2 --date=short --first-parent --format='%ad %ae %s'
2020-01-22 aerotwist@chromium.org [Global] Updates references to Common.console
2020-01-22 aerotwist@chromium.org Adds e2e scripts and 'Hello, World' test
2020-01-22 aerotwist@chromium.org Migrates sources/ to ESM internally

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@04ccecc2d7b2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1006759,chromium:1044632
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I55227c4b5447b0dcdacd908ff34475edcf623800
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015144Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734142}

BUG=103745

Change-Id: Icc6e06fbcfc17b1b824ab9406f73a89a52c2b8be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993387
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734141}

Because some same-origin root ad frames have children
who are cross-origin, the current same-origin vs cross-origin
ad metric classifies the origin status of cross-origin ad
creatives with same-origin root ad frames as same-origin.

This new metric heuristically determines which frame in the ad frame
tree contains the actual ad creative by assuming it is the first
frame with a First Contentful Paint.

Test 1: chrome/test:unit_tests
--gtest_filter=*CreativeOriginStatus*

Test 2: chrome/test:browser_tests
--gtest_filter=*CreativeOriginStatus*

Bug: 1011407
Change-Id: I2571734216b5abd5facd4dac79e5b1a1ee91bdb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894168
Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734140}

TBR=eugenebut@chromium.org
BUG=1044676

Change-Id: I83a925af601b4916a69b7e737352339610a258f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014128Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734139}

This CL adds a Media.PlatformVideoDecoding.Decode histogram to the
VA-API Wrapper (a similar one could be added to others). This
histogram is used for CrOs perf testing: crrev.com/c/2013491.

Bug: 1014836
Change-Id: I0b108d9488472640b3f9e640eeeb73dc3784008f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013583Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734138}

Discovered new bug regarding windows with top insets which affects both
minimized windows and unminimzed windows. The current patch does not
make it perfect in the case of windows with top insets (especially if
they are letterboxed), but its a lot closer than before.

Test: added test, manual
Bug: 1041555
Change-Id: I3503ca4a6760517176607c50d1dc6f1a2b9ca376
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001753Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734137}

Epson printers use the "Ink" attribute instead of other commonly used
attributes like "ColorModel".

Remove unnecessary scoping in some unit tests.

Bug: 1043255
Change-Id: I3a71c0354de266cf41b99d06372e883e8b200eb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014101Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734136}

This reverts commit dbfd6f35.

Reason for revert: CrSettingsSiteSettingsPageTest.UMALoggingTestsPart2 is failing flakily.

Bug: 1044708

Original change's description:
> Revert "[Sheriff]: Revert "More Settings Page Interaction UMA""
> 
> This reverts commit 0bfc424a.
> 
> Reason for revert: Found cause of revert and fixed
> 
> Original change's description:
> > [Sheriff]: Revert "More Settings Page Interaction UMA"
> >
> > This reverts commit 561bf1af.
> >
> > Reason for revert:
> > Strongly suspect this is causing failures on the debug builders:
> > [29058:775:0117/070736.663833:ERROR:CONSOLE(49)] "Mocha test failed: PersonalizationOptionsTests_AllBuilds signinAllowedToggle
> > Error: Uncaught TypeError: Cannot read property 'PRIVACY_CHROME_SIGN_IN' of undefined (chrome://settings/privacy_page/personalization_options.js:102)
> >
> > r732804 was reverted earlier for the same reasons, but there are still failures coming from the settings code, albeit less
> >
> > Original change's description:
> > > More Settings Page Interaction UMA
> > >
> > > Move the settings enum and the call to uma to a separate browser proxy.
> > >
> > > Add UMA to all site settings subpage interactions and new toggles moved to the main settings card
> > >
> > > Bug: 1032584
> > > Change-Id: Icadd71d4511fa1f604f2d3acbda92c0e84700173
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967651
> > > Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
> > > Reviewed-by: Dan Beam <dbeam@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#732785}
> >
> > TBR=dbeam@chromium.org,harrisonsean@chromium.org
> >
> > Change-Id: Id4ee78d89487ecf7e6d1935088d02b29de89c7c8
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1032584
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007829
> > Reviewed-by: Leonard Grey <lgrey@chromium.org>
> > Commit-Queue: Leonard Grey <lgrey@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#732870}
> 
> Change-Id: Id60aa270741ac9305effac5a13587eb1a1d89102
> Bug: 1032584
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007716
> Reviewed-by: Dan Beam <dbeam@chromium.org>
> Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#733913}

TBR=dbeam@chromium.org,lgrey@chromium.org,harrisonsean@chromium.org

Change-Id: I9491e91268ed0ef59837a49161d79692e9c44ceb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1032584
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015562Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734135}

This binary is used for debugging, so there's no direct impact to Chrome.

Change-Id: Ib6a7120de8e28f135d83e816974e9ccaa3dd077a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913048
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734134}

Add trace events to all non-trivial methods of DrmThread and all
methods in DrmThreadProxy that block.

Bug: 1034559
Change-Id: I4f77dc84f0e35f2f405d2a9f4658c865800cf44e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013812Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734133}

Adding completeness check on address in UI.

Bug: b/147718960
Change-Id: I6307c420867cc9c2616b96432baaea7884e71773
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012381Reviewed-by: Clemens Arbesser <arbesser@google.com>
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Cr-Commit-Position: refs/heads/master@{#734132}

Autogenerate Polymer 3 versions of CrFingerprintProgressArc and its
tests. This will be used by chrome://settings in future.

Bug: 1042558
Change-Id: I5a628f2e2dd96bc91b607a453b862022555a04c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013630Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734131}

Bug: 648382
Change-Id: I1342c7735c5a78dbddd482de7f7a6c2ceb9b9e01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014126
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734130}

Bug: 1032778
Change-Id: I7701cdfe36f29110d1da957d87605ddbbc8b9179
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013912Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734129}

This situation may come up if policy was changed after printer was
selected. We reject printing job since silently omitting username and
filename could be confusing.

Bug: 1042798
Change-Id: Iba385503d8f7e960291728d6515ca7c236220847
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004992Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734128}

Cleanup. This feature has been enabled by default since M76.

Change-Id: I3f1009f6a749b214dec3bb72c7730e35d91f928f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008428
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734127}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=kolos@chromium.org

Bug: 1041419
Change-Id: I9f15c46d6dd88dfb97ed26c5cfe233881d2c8643
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997769
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734126}

WallClockTimer is able to run the task with wall clock delay which is not
paused when the computer is sleep.

WallClockTimer is currently in relaunch_notification component. enterprise
reporting will temporarily depends on it. WallClockTimer will be moved into
base later.

Also, removing the RequestTimer and let ReportScheduler use WallClockTimer
directly.

Bug: 1039673
Change-Id: Ic3a2c695717c9fee6af5172d7a12e2afb2ed561b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005648
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734125}

The new Style and Layout metrics correlate as expected with the
old combined metric, so it is safe to remove it.

Bug: 1044355
Change-Id: I6fb51394195d9e48c40801e946934f8a6775ed61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013496Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734124}

Parse PerAppTimeLimits policy received from the server and store
app limits data in AppActivityRegistry.
This will be followed up by processing app limits.

Bug: 1015654
Test: AppTimeTest
Change-Id: I29691e0c801762a73f01cce217826423359957eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001411Reviewed-by: Yilkal Abe <yilkal@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734123}

Bug: 648382
Change-Id: I89d44f2b4ed34827d0451db4cbfa801a6c6cf3fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013512Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734122}

This reverts commit 71932bd3.

Reason for revert:
This broke the stack_allocated.cpp test, see https://ci.chromium.org/p/chromium/builders/ci/ToTLinux/9408

Original change's description:
> blink_gc_plugin: Disallow Members for stack-allocated types
> 
> Members in stack allocated types issue redundant write-barriers. This CL
> provides an option --no-members-in-gc-allocated, which prohibits use of
> them.
> 
> Bug: 1044611
> Change-Id: Icc83756d9a1d6e414a09b705c0f008f9e79c4ae9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010986
> Commit-Queue: Anton Bikineev <bikineev@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#734022}

TBR=haraken@chromium.org,mlippautz@chromium.org,bikineev@chromium.org

Change-Id: I3ae05fc50c49a3d668a3cb4d49c0fb010225861f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1044611
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015342Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734121}

Bug: 1037085
Change-Id: Id384314ee43361434c9beade56fef7d101fb6189
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983626Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Jonathan Freed <freedjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734120}

We removed --fuzzy-diff from the default Linux configuration in:
https://chromium-review.googlesource.com/c/chromium/src/+/1989866

As a part of this we needed to disable SkiaRenderer, as this feature had
been developed with -fuzzy-diff on and we were not certain the impact.

We have since tested re-adding it, and it appears that some rebaselines
are needed. This requires 130 baseline changes in the main tests, along
with similar rebaselines for these tests which have been duplicated in
various VirtualTests.

The vast majority of the differences are small color variations in
anti-aliasing, and some gradient representations.

Some ref_tests cannot be rebaselined, issue 1043675 was filed to track
those affected by SkiaRenderer so that we can triage them accordingly.

TEST=blink_web_tests
Bug: 1039401, 1043675, 1044032

Change-Id: Idfcbdac1416067d6922b20a6cadc9180ecce82fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994088Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734119}

This became flaky after
https://chromium-review.googlesource.com/c/chromium/src/+/1986934

Using frame number to track the draw progress in a test is no longer
valid since it is possible to two commits and activations to happen
without a invalidate/draw. Use a separate count to keep track of
no-damage invalidates.

Bug: 1025695
Change-Id: I511a5af56373c417ee25ccd3bdf3eca67dc92f15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014981Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734118}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/af64a9e826bf..dc77030acc9c

The spirv-tools autoroller didn't roll this repo.

Bug: 1044061
Change-Id: I80878e58d3655f3ed42eb28664d05e101d2a9f77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014982
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734117}

Reduces some copy-pasted code.

Bug: 937821
Change-Id: Ic306e0235de76b43145a58214a95f497e5b2330c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013906Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734116}

We used to omit pseudoId from nodes that carry ids other
than those exposed in the protocol. This does not really
make sense, as in case of DOMSnapshot domain those nodes
would be misrepresented as regular nodes, and in case of
DOM agent, this would lead to inconsistency where a node
within pseudoNodes array of its parent wouldn't have the
pseudoId attribute.
With this CL, we always set pseudoId on all pseudo nodes
and move filtering to higher level when populating the
array of pseudoNodes.

As a drive-by, this also adds dom-snapshot tests to the
set of tests that run with experimental features disabled.

BUG: 1043394

Change-Id: I58fc5a15e28b30118bffea5cbb2e9620c08f0084
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007944
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Peter Kvitek <kvitekp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734115}

The AutoNightLight feature is enabled only on kohaku via the chromeos
session manager [1]. However, the session manager does not start the
guest session, and therefore, does not setup its command-line flags.

This CL adds the ability to copy a list of whitelisted features to
the guest session command-line if they are enabled in the current
session (the sign-in screen).

[1]: https://cs.corp.google.com/chromeos_public/src/platform2/login_manager/chrome_setup.cc?q=p:chromeos_+AutoNightLight&g=0&l=105

BUG=1044344
TEST=Make sure AutoNightLight is enabled on kohaku in guest sessions.

Change-Id: Ie18e9a0e98d4b54bcd753d3bdbb8ecd422fa16e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013739
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734114}

TBR=tommycli@chromium.org

Bug: 1030551
Change-Id: I6d707a3cbfd189b6d94287c995e8db8bc60a3027
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014125Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734113}

Prevents leaving user traces in Incognito while still allowing the
window to stay in sync with pinning done in non-Incognito windows.

Bug: chromium:970023
Change-Id: I68a3fe0e6b7696578a2199994ced6db5a3c71faa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990148
Auto-Submit: Peter Boström <pbos@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734112}

At the end of the remote consent flow, a Gaia page calls
OAuthConsent.setConsentResult(consentResult) JS function.
consentResult should be eventually passed to the browser.

The Gaia page is loaded within a <webview> within a Chrome-internal
identity extension. The Gaia page passes the result to the browser in
two steps:
1) Pass a string from the webview JS to the extension JS.
2) Pass a string from the extension JS to the browser.

1) is achieved using chrome.runtime.sendMessage() API as described in
https://developer.chrome.com/extensions/messaging#external-webpage.

To hide this implementation detail from Gaia, the identity extension
injects a script into the Gaia page defining
OAuthConsent.setConsentResult() function.

For 2), we add setConsentResult() function to identityPrivate extension
API. The function handler passes the result to GaiaRemoteConsentFlow
through a registered callback in extensions::IdentityAPI.

Bug: 1026237
Change-Id: I1b955fc44979249f520563bd0a33cc2d6fd0aecf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000791
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734111}

Fuchsia builds have been forcibly disabling safestack because it broke
V8 tests under Fuchsia, and forcibly enabling shadow-call-stack in
advance of it becoming the toolchain default, to gauge size impact.

Enabling shadow-call-stack under x64 is not recommended and breaks code
which uses C++ exceptions, which is true of some V8 code & tests.

Since the toolchain default should now be correct, remove the overrides
entirely.

Bug: 1028617, 821951
Change-Id: I36333f8cff5ea62584032a802337cdeb95f33466
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014407
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734110}

[1] https://www.w3.org/TR/html-aam-1.0/#html-element-role-mappings
[2] https://w3c.github.io/core-aam/#mapping_role_table

For UIA the only difference between a <form> with an accessible name
and one without is a <form> that does not have an accessible name :
  1. Has no corresponding ARIA Role.
  2. Does not have a UIA Landmark Type

Unfortunately if a role is not mapped, then the node becomes a generic
container which can break expectations for both aria-setsize and
aria-posinset because |AXTree::PopulateOrderedSetItems| cannot detect
the form without adding a check for StringAttribute::kHtmlTag and will
recursively include descendants of the form with the siblings of the
form.

In particular, not mapping a role broke :
DumpAccessibilityTreeTest.AccessibilityAriaPosinset/*
... the 2 radioButton nodes inside the form and the 2 radioButton
siblings of the form would all have setSize=6, and the posInSet of the
later 2 nodes was also offset to be 5 and 6 respectively.

Because the reasoning behind these differences is to prevent an
unlabeled form from acting as a landmark, I kept the change local to
UIA Landmark Type.

Bug: 1042420
Change-Id: I2bc4e052e81d447aea42d3585cbe65a2baa1165c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003257Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Adam Ettenberger <adettenb@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#734109}

Fix a bad cast that had existed for years (originally written by
in crrev.com/d322c5ca)

This was only recently uncovered by clusterfuzz when we added virtuals
to the WebInputEvent in crrev.com/547be407.

Fortunately the cast shouldn't have caused any issues.

BUG=1044379

Change-Id: I47463bd671b17beba9e2ebd5803ec1ea93236bb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013477Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734108}