- 14 Aug, 2020 40 commits
-
-
Ben Pastene authored
Testing what a description will look like on Milo for a staging builder. Bug: None Change-Id: I22cb9374ba60bdddc24879567d3abe6890eb68dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355275Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#798173}
-
Maksim Sisov authored
ChromeOS switched to Ozone quite some time ago and no longer supports non-Ozone/X11. However, when I started to enable use_ozone for is_linux, is_chromeos started to build use_x11 as well, which is not correct. Atm, use_x11 is not built for is_chromeos, because use_ozone = is_chromeos, and this line is just redundant. Bug: None Change-Id: I38ad54cd2febd5a8cce57bc29d092525e07cb715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353265 Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#798172}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008140800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/Fa2uaWyUkyfb0dZlfDu9CiOQue9NyZDytZiTrkZdzm0C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/163673595,b/163960769 Tbr: help-app@grotations.appspotmail.com Change-Id: Ieb24c0a2a545c73ec8d767418daf5faf1f08682d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355563Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798171}
-
Maksim Sisov authored
Change-Id: I94756241300ec1d90fdc87391ec57c2dabc7b512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355951Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#798170}
-
Lexi Stavrakos authored
Binds quota_host_ in AddedChangeListener() if not already bound so that StartObserving() can pass the listener back to the browser side. Bug: 1116316 Change-Id: I43e5bed0dc6cb931c3f950faee05b1c1f3e60ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356284Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Lexi Stavrakos <astavrakos@google.com> Cr-Commit-Position: refs/heads/master@{#798169}
-
Scott Violet authored
I was surprised to see occluded_region is in the coordiantes of the root window. This renames Window::occluded_region to make this more obvious. This also removes the SkRegion argument of WindowDelegate::OnWindowOcclusionChanged() as it's unused. I'm doing this as it is unused, but also because the coordinates are rather confusing. BUG=none TEST=none Change-Id: I99910e29e9efb1abf8c7854ae57d3d7dcc636763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336058Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#798168}
-
Yuke Liao authored
The goal is to set up a linux-lacros-rel try builder that that runs a subset of test suites from linux-lacros-tester-rel, so this CL creates a virtual CI builder for linux-lacros-rel to mirror. Bug: 1116180 Change-Id: Id9fba6c6c20d7437e4bc8b22b14dcaf28e60ee37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355003Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#798167}
-
Joe Downing authored
The current value for this policy indicates that it applies to all ChromeOS versions after M41 however this isn't right as that policy was not read on ChromeOS prior to a change I made in M86. This CL updates the 'supported on' value to match what the product actually supports. BYPASS_POLICY_COMPATIBILITY_CHECK=The previous value was incorrect but setting the correct value causes the policy checker to complain. Change-Id: I50e21fe9828cb54f6cfaa11a9a120c0f4b89ad40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354593 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#798166}
-
Peter Kotwicz authored
This CL removes the following duplicate resource text_size_medium text_size_large In both chrome/android/feed/core/java/res/values/dimens.xml and ui/android/java/res/values/dimens.xml Removal of duplicate is tracked in crbug.com/1039415 bottom_sheet_min_full_half_distance bottom_sheet_peek_height bottom_sheet_toolbar_shadow_height bottom_sheet_shadow_top_offset In both chrome/android/java/res/values/dimens.xml and components/browser_ui/android/bottomsheet/java/res/values/dimens.xml The chrome/android values should have been deleted as part of https://chromium-review.googlesource.com/c/chromium/src/+/2242112 IDS_CERTTITLE In both chrome/browser/ui/android/strings/android_chrome_strings.grd and components/browser_ui/strings/android/browser_ui_strings.grd android_chrome_strings.grd value should have been deleted as part of https://chromium-review.googlesource.com/c/chromium/src/+/2062418 IDS_LINK_COPIED In both chrome/browser/ui/android/strings/android_chrome_strings.grd and ui/android/java/strings/android_ui_strings.grd The two call sites which use the string - ChromeProvidedSharingOptionsProvider.java and Clipboard.java - display it in a org.chromium.ui.widget.Toast BUG=1093825, 1039415 Change-Id: Iee21c047453eea285dc7b0a114579666bfdd582d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355314Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#798165}
-
adoneria authored
Currently win-omaha-builder-rel is unstable and hence the new test suite is not getting triggered on win10-omaha-tester-rel. Re-enable running tests the old way so that dev testing is not halted. This gtest suite currently takes ~20s/build to run on bots. Bug: 1109373 Change-Id: Id8fbaae10c06e84066e35f9c492d25c21c646c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354627 Commit-Queue: Anjali Doneria <adoneria@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6a652f1ab5d7..27391a090ec2 2020-08-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from cda86eff6461 to abe07b943855 (1 revision) 2020-08-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from df859f77dab3 to b4c4da3e7606 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Ib5091f5d0873d04e1f8a3c8b521e2af6176b06c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355527Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798163}
-
Brian Sheedy authored
Adds the textpb necessary to start creating Android Q emulator AVD files and adds it to the list of configs that the android-avd-packager builder will use. Bug: 1112488 Change-Id: Ia5e628e6208ddb8f7b756237d085eb0c22a297ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354424Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
-
Tibor Goldschwendt authored
The generic module element implements common UI such as the header and border. The module supplies the information required to populate the common UI via its module descriptor. The generic module element also wraps the local module UI previously instantiated. Bug: 1110047 Change-Id: I4c2579bb2c0d3e19b9120c03606ad21d30dea529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336912 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#798161}
-
Dominique Fauteux-Chapleau authored
This also makes the legacy features controlling enterprise deep scanning disabled by default. Bug: 1106433 Change-Id: I3a55998a94b95d28e5640e29663d092ee1c8ceec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346741Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#798160}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I216d1b4cd0237c5f9d957a409552862ce40aafcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352305Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#798159}
-
Karel Král authored
Also support |const char* ValueType::data const| in |base::trace_event::ValueToString|. Thus support turning more types into std::string (for instance |IPC::MessageView|). This will provide more detailed information in captured traces. Bug: 1103623 Change-Id: I897325212fe2202f782e6b8c445a404aba71582a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356304Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Karel Král <karelkral@google.com> Cr-Commit-Position: refs/heads/master@{#798158}
-
Fred Mello authored
https://docs.google.com/document/d/1AhuftD0wlY1WfdatReo23d7ydx0KrQfJgrG2Jj_eNmI/ Bug: 1112872 Change-Id: Ice3a5a38c29f26251085109ad36c517762ba1533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346748Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Auto-Submit: Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#798157}
-
Mark Cogan authored
This Cl extends tab count metrics that expire after M85 to M92. Bug: 1089564 Change-Id: Id6f3cf8b6d14dcb0e99fb1849075de35879c9f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349306 Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Mark Cogan <marq@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#798156}
-
Hongbo Song authored
According to Chrome crashes, |GetDelegate().GetPageInputTiming().total_input_delay| can be |std::numeric_limits<int64_t>::min()|. I still have not figured out why this value can be negative. But I think this CL can fix the chrome crash. Change-Id: I8709239a9d96d240840f42a4b4ab661738651a53 Bug: 1105665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351379Reviewed-by:
Hongbo Song <hbsong@google.com> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Hongbo Song <hbsong@google.com> Cr-Commit-Position: refs/heads/master@{#798155}
-
Peter Kasting authored
Bug: 1104532 Change-Id: I2665571ddd1129feeb4da8ce6dd39cd42a5427e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354951 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#798154}
-
Camille Lamy authored
This CL extracts CrossOriginOpenerPolicyStatus into its own class. The struct has grown quite big, and it will allow to better encapsulate CrossOriginOpenerPolicy enforcement. This is a preparatory CL for having reports sent on redirects. Bug: 1059303 Change-Id: Ia2d71e0f592296ac6f7a89519068ac84796bf224 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353264Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#798153}
-
Luis G Garcia authored
Change-Id: I365392ad1496169e721f2cb2320aea25048c2024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356189Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Luis Garcia <luisggarcia@google.com> Cr-Commit-Position: refs/heads/master@{#798152}
-
Josh Nohle authored
Reorder the |salt| and |encrypted_metadata_key| parameters of NearbyShareEncryptedMetadataKey to align with existing data structures like Advertisement. Then, use NearbyShareEncryptedMetadataKey in GetDecryptedPublicCertificate() instead of accepting the individual |salt| and |encrypted_metadata_key| parameters. Because NearbyShareEncryptedMetadataKey verifies the expected size of the salt and encrypted key, this function signature is less error prone. Fixed: 1115123 Change-Id: I1b22b6e7755b9947355d7ea21cfa661f78cdcf81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354555 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#798151}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/35492ebf6ba2..39fbb307bc9a 2020-08-13 kevinruvalcaba@google.com Added visualization methods for dependency graph. 2020-08-13 lamontjones@chromium.org Build API: Add unit tests for package_indexes. 2020-08-13 mmortensen@google.com query_build_logs: Enable changing DATE sort order to ASC. 2020-08-13 sidereal@google.com packages: Fix manifest update for pinned uprevs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I0e12d8bc7657024f32d9aa2b05e8f6f30b186eca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355557Reviewed-by:
-
Ben Pastene authored
This reverts commit 6bc98538. Reason for revert: The linked build is 1 week old... The test is green on tot and does not warrant a revert. Original change's description: > Revert "Add several basic gtest & integration tests to new eve-arc-r bot." > > This reverts commit fc9217ef. > > Reason for revert: chrome_all_tast_tests fails on chromeos-eve-arc-r-chrome, > https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-arc-r-chrome/2498 > > > > Original change's description: > > Add several basic gtest & integration tests to new eve-arc-r bot. > > > > Bug: 1092973 > > Change-Id: I4df191266f28297cf8581f1687de87e336713363 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339580 > > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > > Commit-Queue: Ben Pastene <bpastene@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#796071} > > TBR=martiniss@chromium.org,bpastene@chromium.org,gbeaty@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1092973 > Change-Id: Ibaa98c41af45981b5d195ef41db31d541c4ed5dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355088 > Reviewed-by: Lan Wei <lanwei@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798055} TBR=lanwei@chromium.org,martiniss@chromium.org,bpastene@chromium.org,gbeaty@chromium.org # Not skipping CQ checks because this is a reland. No-Try: true Bug: 1092973 Change-Id: I5bd5c1ef4a789ae141ea8ac3fa55883cfa495c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356047 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Adlai Holler authored
This is part of a larger effort to require GrDirectContexts when performing certain operations on texture-backed SkImages. See bug for details. Bug: skia:104662 Change-Id: I0993d5e37355a8fee982995b666bb7958d0f05b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356324 Commit-Queue: Adlai Holler <adlai@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Auto-Submit: Adlai Holler <adlai@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#798148}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I15f933f9ebcdddd89cdb0c6a2c2b873109db0487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355524Reviewed-by:
-
cfredric authored
Change-Id: Ife54b3e6e5ff261d55fb56ea1674c9a5702b4a8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356244 Auto-Submit: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#798146}
-
Toni Barzic authored
When running UnlockAnimationBeforUIDestroyed, animate shelf before lock screen containers. Shelf fades out and then fades in when the unlock animation completes - i.e. in the UnlockAnimationBeforeUIDestroyed callback. If animations run immediately, the fade out and fade in animation order could get reversed if fade out animation is started after the part of unlock animation to which animation callback is passed. I'm not sure that this is actually the root cause for the linked issue, but it is a way to get to an invisible shelf (it requires zero length animation, which may happen during screen rotation). BUG=1106796 Change-Id: I8f26200666e742b249ba96b64a32ce28022634f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352905Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#798145}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/765a9826cde1..0e97afad480e 2020-08-14 alexrudenko@chromium.org Add Node change listeners to Layout pane 2020-08-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-14 petermarshall@chromium.org tests: Add an it.repeat() helper 2020-08-14 patrick.brosset@microsoft.com Layout: Display class/id-less elements just with their tagname 2020-08-14 alexrudenko@chromium.org Regenerate bridge for LayoutPane 2020-08-14 patrick.brosset@microsoft.com Force a screen reader pause between a tag name and attributes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101782,chromium:1109177,chromium:1115449,chromium:1116353 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I28bb348f938e281364f6df90e3beb85e41a5e999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355517Reviewed-by:
-
arthursonzogni authored
This make it easier to access an attribute using Javascript. This also make both the network reports and the ReportingObserver to have the same attribute names. Previously, the spec was based on CSP, which has both camelCase and hyp-hen. Today, we report thing using camelCase instead: - DocumentPolicyViolationReport, - FeaturePolicyViolationReport, - DeprecationViolationReport, - InterventionViolationReport Bug: 922191 Change-Id: Ic875163b16acf5083ed8197266fc23034f2c5005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352926Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#798143}
-
Victor-Gabriel Savu authored
Add missing entry to kKnownSettings. Bug: chromium:1116336 Change-Id: Ib00bc2f60b1d27851d1675e32f259c767da11ad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353261Reviewed-by:
-
Alex Chau authored
- last_task_completed_ should only signal if it's already shutdown, otherwise last_task_completed_ will be stuck in insignalled state when the first task completes Bug: 1116437 Change-Id: I8f2172a5af031c5073563b518d77adca29fa85bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352886 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#798141}
-
James Long authored
The package graph page is now blue, and the class graph page is now red. The favicons for each page type have been updated to reflect this, and links to the other page type have the corresponding icons in order to indicate a change in the page type. Hyperlinks remain blue, regardless of page type, to avoid confusion. Bug: 1102546 Change-Id: I23ef7fb7cb2a85678a4b29712716905523a89cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354526 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#798140}
-
David Bokan authored
Update tests for force-load-at-top DocumentPolicy to use updated false syntax. Bug: 1047900 Change-Id: I2b02b94715b0edd8dfaaf2676ff91dab01a00702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354954Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#798139}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c184cf36092f..c9c4e2e9efac 2020-08-14 fmalita@chromium.org Componentize SkAudioPlayer 2020-08-14 johnstiles@google.com Use a scoped block for inlined return statements. 2020-08-14 robertphillips@google.com Update iOS Skottie App for GrContext changes 2020-08-14 robertphillips@google.com Require a direct context to precompile shaders in DM 2020-08-14 johnstiles@google.com Enable ClangTidy flag modernize-use-override. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: I92e6793942257b113dd2ea590351c4d60b39f23a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355520Reviewed-by:
-
Orin Jaworski authored
This CL eliminates the state invalidation that was used to cause translation prompt to show, as that did not work in all cases. The translation step is changed so the prompt always shows, which is much simpler. Bug: 893183 Change-Id: I5dca3eb30032461fc8824a36c9a80a1a82f84cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354660Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#798137}
-
Scott Violet authored
To not do this means a NavigationObserver must be used as well. By having the FaviconFetcherDelegate notify on navigation means the ui for the favicon can be self contained. BUG=1076463 TEST=covered by tests Change-Id: Idf5d2a65b154e04e409b4596db9530bf28049603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352267 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#798136}
-
Russ Hamilton authored
Bug: 973801 Change-Id: I5bc5154a5aecb85b5f04a70c238f3b7ef684b8df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354668 Commit-Queue: Russ Hamilton <behamilton@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#798135}
-
Rayan Kanso authored
ImageResource's type members is a mojo_base.mojom.String16? which is typemapped to WTF::String in blink. For some reason though, passing a null WTF::String to mojom is crashing the renderer. This CL explicitly sets the image resource type to the empty string if not available, and adds a web test to make sure this doesn't happen again. Change-Id: I115666b6e42011dfc398965bd0f4e795d1869979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352878 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#798134}
-
