GitLab

https://skia.googlesource.com/skia.git/+log/7823aeb8d6da..5b6ccbb6b599

git log 7823aeb8d6da..5b6ccbb6b599 --date=short --no-merges --format='%ad %ae %s'
2019-10-31 benjaminwagner@google.com [infra] Upgrade MacBookAir to 10.15.
2019-10-31 herb@google.com ...finally!
2019-10-31 michaelludwig@google.com Move tessellation math into GrQuadUtils
2019-10-31 benjaminwagner@google.com Add Pixel4 jobs

Created with:
  gclient setdep -r src/third_party/skia@5b6ccbb6b599

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@google.com

Bug: None
Change-Id: Ib64a85da78e47841407032d75eb6d9066a2bd39f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894255Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711477}

gsync error message from alexclarke@

(inside 'host_os == "linux" and checkout_fuchsia and checkout_fuchsia_for_arm64_host')

ValueError: invalid "and": exactly 2 operands required
Bug: 1000901
Change-Id: Iea261c3cbbc65c92a3c79a43c1abfdaa1e3e1411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893190Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Stephen Roe <steveroe@google.com>
Cr-Commit-Position: refs/heads/master@{#711476}

R=robertocn@chromium.org

Bug: 1013608
Change-Id: Icf9fd7235a22d91adacc1b1595353e0060147175
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893375Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711475}

https://android.googlesource.com/platform/external/perfetto.git/+log/7aa214a27bca..f016a6633058

git log 7aa214a27bca..f016a6633058 --date=short --no-merges --format='%ad %ae %s'
2019-10-31 primiano@google.com Merge "UI: Simplify WASM interop"
2019-10-31 fmayer@google.com Merge "Fix next ID."

Created with:
  gclient setdep -r src/third_party/perfetto@f016a6633058

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: Id4939f00a44e482e6551ba5b30c42e4a31698d5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893146Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711474}

That class is specific to the Gamepad API integration that was used by
WebVR, so we can remove it now.

Bug: 1017848
Change-Id: I8b3022fbf59bd12ead6678b39b744efb2e57f428
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888120
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711473}

On Stable 1 GB corresponds to the 60th percentile for total resident
set, setting the limit to 1GB will let Chrome work fine with 3-4 tabs.

Bug: 980965
Change-Id: If4f0b6171eb159c3781290b8060617d57d399327
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893580
Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711472}

The MDM service is disabled in Chromium branded builds, but it can be
enabled in tests via the GoogleMdmEscrowServiceEnablerForTesting class.

The class used to be available only in GOOGLE_CHROME_BUILD builds.
To not use GOOGLE_CHROME_BUILD in a .h file, make the class available
always and make it a no-op in GOOGLE_CHROME builds.

That simplifies a few tests, removes a dependency on the GOOGLE_CHROME_BRANDING
buildflag header target, and makes it easy to remove GOOGLE_CHROME_BUILD
from mdm_utils.h/cc

While here, also remove the unused parameter for
GoogleMdmEscrowServiceEnablerForTesting's constructor.

Bug: 961769
Change-Id: I1dfdbdf056634d1e47272f397c11919193bf7fc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894295
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711471}

This unifies the code that decides to use the system theme, as well as
the code that uses a dark Aura theme in incognito.

Bug: none
Change-Id: If775c5eb1d3e51cfa8b2458c86736c6457828eb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887877
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711470}

This changes the paradigm on retrieving resources. Before, for these functions,
you needed to know whether your resources were compressed to know to call the
right function.

Now, we can call it without knowing if there is decompression under the covers.
This also allows others to use std::string return types for convenience, even
if they don't use compression.

TBR: trivial renaming outside of reviewed area
Bug: 1003433
Change-Id: I0200d083d4a2d8f8fef98591e9c2e4188488a471
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874514
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711469}

Use a BenchmarkConfig object to keep track of a benchmark that should be
scheduled on a platform (via a shard map). This allows us to keep track
of whether a benchmark should be abridged or not.
A followup changelist will edit the sharding scripts to use this new object.
Then later we can start marking specific benchmarks as abridged.

Bug: 965158
Change-Id: Ib8f492852a567094fa85b507d59701e188503f4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893985Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711468}

Based on the bug report, the GetTabFeatures() crashes on a line when
accessing it's own member variables which indicates the pointer maybe
empty.

Based on recent change in
https://chromium-review.googlesource.com/c/chromium/src/+/1816004

It's very likely that web_contents_data becomes nullptr in some cases.

Bug: 1017222
Change-Id: Iec58d533af478cc37f96cbedc263884e7e34bf1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884407Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Charles . <charleszhao@chromium.org>
Commit-Queue: Charles . <charleszhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711467}

Bug: internal b/143559499
Change-Id: I57244b6fb772f15ffb4c9f31c4194a2f98d55801
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894263
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Auto-Submit: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711466}

This CL is replacing the control characters with the "Replacement Codepoints".

The codepoints in that area are:

  Unicode Character Category 'Other, Control'
  a) u+0000 -> u+001f
  b) u+007f   (delete)
  c) 0080 -> 009f

The codepoints from a) and b) are already handled properly.

For codepoints from c), it is quite common to have no glyphs (win7).

"""
  Most of these characters play no explicit role in Unicode text handling.
  The characters U+0000 <control-0000> (NUL), U+0009 <control-0009> tab key (HT),
  U+000A <control-000A> newline (LF), U+000D <control-000D> (CR), and
  U+0085 <control-0085> (NEL) are commonly used in text processing as formatting
  characters.
"""


see: https://en.wikipedia.org/wiki/Unicode_control_characters
Bug: 1011818
Change-Id: I23010faf9130806db3884720e4a90c0723802893
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894041
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711465}

Fallback to new decoder after initial decode error is an important event
to understand what is happening in the media pipeline. This CL adds a
MEDIA_ERROR(WARNING) for this case.

Bug: 1020245
Change-Id: Ia1e8948c3aa0f80b7d16f5ca48dae69e27f93a1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893521
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711464}

Bug: 1019485
Change-Id: I250b837d286a12a0fed6960569c59f91753976e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889115Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711463}

R=dpapad@chromium.org

Fixed: 1020309
Change-Id: Ia2e3b95679ee9444aae0f533678fc389fff7307f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894252
Commit-Queue: Dan Beam <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711462}

Infra failures for 10b61 (Xcode 10.1 GM) due to MobileDeviceDevelopment.pkg untrusted. Upgrading XCode to 11.1 GM and fixing dimensions to Mac-10.14.

Bug: 1019931
Change-Id: I7507da8965146dfe5a66c012deac9dd36c8cda52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894261Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711461}

This gets rid of the whitelist in Module.java. Going forward DFM authors
simply have to specify native_deps in the module_desc and the native
library will be automatically loaded when first accessing the module
(when using the autogenerated module class).

See go/native-dfm-load-v2 for more context and details.

This is a reland of 06c7b1cd No changes
have been made. 06c7b1cd was reverted
due to the revert of a9dcd64a and that
CL has been fixed in c9901c6a.

TBR: cjgrant@chromium.org,mthiesse@chromium.org
Bug: 870055
Change-Id: Ib7939f43f2e3ca758c8ab039f91d6f78b6d84f22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891434Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711460}

ViewSourceWithSplitCacheEnabledTest.NetworkIsolationKeyReusedForBackNavigation
expects us to re-load a page after a back navigation (and reuse the network
isolation key while doing so), which doesn't happen when the page is
restored from bfcache. We will disable bfcache for this test, because
the reload is an essential part of the test.

Bug: 1017597
Change-Id: I92a42ab8811750c54400119f276d2a9ec3dec13e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886531Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711459}

There should be no functional changes introduced by this CL.

Renames XRInputSource-related data in mojom structs. This CL does not
attempt to fix names of other variables / functions that are used to
compute the data that will then be set on the mojom structs - this will
have to happen in a follow-up (mostly on device side, blink usage should
already be consistent).

Change-Id: I1b4888158a7ed57cecce7de87634e639cf23d6ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891455Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711458}

If the application parameter is a dummy value, do not store the
credential on the virtual authenticator.

Fixed: 1019828
Change-Id: Iacfdcff64fba895b5283bf620b4e48c11279c65b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891134
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#711457}

this fixes an ambiguous reference error when compiling with MSSTL

Change-Id: I19a56e9268cac76afc8dd3fcf391b3a2d5fe7d2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891762Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Auto-Submit: Jeremy Apthorp <jeremya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711456}

It's much clearer to have a single include rule than to include
everything in a single list, and then have exclude rules at the bottom
of the file.

Bug: None
Change-Id: Ifbb669ea13999ca9232012063ac6031065d216d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890964
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711455}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9ac8f056b7f..b0434c1ced7a


Created with:
  gclient setdep -r src-internal@b0434c1ced7a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:1019931,chromium:1014539,chromium:None,chromium:None,chromium:None
Change-Id: I51d1c4502756686114c45fd61e9c751c6dfcf826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894251Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711454}

This is a reland of 011e523c

This removes an assert which is not true when DCHECKs are disabled
(in such a case, we do not log the is_instrumented_build proto at all).

Original change's description:
> AW UMA: integration tests for more metadata fields
>
> No change to production logic.
>
> This adds tests for already-implemented UMA proto fields. This
> intentionally skips fields which don't apply to Android OS (ex.
> os.is_jailbroken, os.arc, os.kernel_version).
>
> Bug: 1011991
> Test: run_webview_instrumentation_test_apk -f AwMetricsMetadataTest.*
> Change-Id: I35fe2b75164a421a9a5dbc80df621f75ec9b5474
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889171
> Auto-Submit: Nate Fischer <ntfschr@chromium.org>
> Reviewed-by: Changwan Ryu <changwan@chromium.org>
> Commit-Queue: Nate Fischer <ntfschr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710655}

Bug: 1011991
Change-Id: Ib0ac14fb25b8a61833f32c1df36f2719c060b4f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891430
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711453}

This patch:
* Changes most raw pointers to base::WeakPtr
* Removes the IndexedDBFactory raw pointer in IndexedDBDatabase and
  instead uses callbacks to report:
  1. If blobs are in use for a given origin, and
  2. If the blob journal has been cleaned.
* Changes the IndexedDBActiveBlobRegistry to use callbacks instead of
  the IndexedDBFactory as well, and also use callbacks for calling
  ReportUnusedBlob in IndexedDBOriginFactory. This simplifies the
  testing of that class.

There are no functional changes in this patch, and while all of those
raw pointers should be safe based on the architecture of the code, it
is much safer to store them appropriately now that we have our fancy
new pointer types.

Finally, this patch also does some naming changing in
IndexedDBActiveBlobRegistry to make that class easier to understand.

Bug: 1018741,960992
Change-Id: I6fd402c68d13870f347fe934b85e6281c396901d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885094
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#711452}

- Refactor Viewport.rotateClockwise(increments) into rotateBySteps_(),
  rotateClockwise() and rotateCounterclockwise().
- Fix a typo in pdf_viewer.js to balance the braces.

Change-Id: Ic91cab4bd930fd87538da801e643c87115327135
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892672
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711451}

This reverts commit 849315dd.

Reason for revert: Suspecting this CL for compile failures on windows e.g. https://ci.chromium.org/p/chrome/builders/ci/win64-builder-perf/127136
[7893/15918] CXX obj/chrome/browser/ui/ui/app_menu_model.obj
FAILED: obj/chrome/browser/ui/ui/app_menu_model.obj
c:\b\s\w\ir\cache\goma\client\gomacc.exe ..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.e...(too long)
../../chrome/browser/ui/toolbar/app_menu_model.cc(166,21): error: no class named 'HelpMenuModel' in 'AppMenuModel'
class AppMenuModel::HelpMenuModel : public ui::SimpleMenuModel {
~~~~~~~~~~~~~~^
../../chrome/browser/ui/toolbar/app_menu_model.cc(819,41): error: unknown type name 'HelpMenuModel'; did you mean 'AppMenuModel'?
sub_menus_.push_back(std::make_unique<HelpMenuModel>(this, browser_));
^~~~~~~~~~~~~
AppMenuModel

Original change's description:
> Make AppMenuModel keep most submenus in a vector.
> 
> They are only needed for ownership, so no need to give them names and concrete
> types. Removes some forward declarations from the header and serendipitously
> happens to remove GOOGLE_CHROME_BUILD from the header as well.
> 
> No intended behavior change.
> 
> Bug: 961769
> Change-Id: Ibaaf3375bd9d367b4cc83b9a8ec3e64193750a69
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894032
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711431}

TBR=thakis@chromium.org,rsesek@chromium.org

Change-Id: I40cdc0d770d2d49ed568fb2c7d22fa791088c0a2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 961769
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893861Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711450}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome

BUG=762641
TBR=chrome-os-gardeners@google.com

Change-Id: Ied490c4b890ab553c91deaf28b9c952b22eb3d45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892999Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711449}

Bug: 983170
Change-Id: Ie165a27c52a5524ce1c41f8ec4661be45b945674
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891117
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711448}

TBR=ryansturm@chromium.org

Change-Id: Id22af52d89c0d880ce0df0c55fba0440193a3bfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894186Reviewed-by: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711447}

Merge IndicatorState::kCannotSnap{Xxx} to IndicatorState::kDragArea{Xxx}
as the distinction is whether the dragged window can be snapped in split
view, which can be determined in SplitViewDragIndicatorsView now that
the parent CL [1] has added dragged_window_ thereto.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1880201

Bug: None
Change-Id: Ic3fc184e29b8ccf30647016f57dd89a1f055909e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881331
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711446}

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OqPfCpC5RYU

For background, motivation, requirements and implementation notes, see
https://docs.google.com/document/d/1XLwNN2kUIGGTwz9LQ0NwJNkcybi9oKnynUEZB1jGA14/edit?usp=sharing

Parameterless setLocalDescription() implicitly creates an offer or answer
as appropriate based on the current signaling state. This is already
implemented in third_party/webrtc using an operations chain. This CL
reuses existing plumbing (used by SLD/SRD already) to surface state
changes when invoking the new SetLocalDescription variety.

The PeerConnectionTracker is updated to track parameterless SLD so that
it shows up in chrome://webrtc-internals/. The old SLD and SRD showed up
as events as follow:
- When SLD(sdp) is called, a "setLocalDescription" event shows up with the
  SDP as the event's value.
- When SLD(sdp) resolves, a "setLocalDescriptionOnSuccess" event shows up
  without a value.

The parameterless setLocalDescription() instead shows up in
chrome://webrtc-internals/ as:
- When SLD() is called, a "setLocalDescriptionImplicitCreateOfferOrAnswer"
  event shows up without a value.
- When SLD() resolves, a "setLocalDescriptionImplicitCreateOfferOrAnswerOnComplete"
  event shows up with the resulting SDP as the event's value.

As such, chrome://webrtc-internals/ remains useful for debugging even if
parameterless SLD is used.

Bug: chromium:980885
Change-Id: I469f63cdaab83991749d5a0d47fe751666304fe6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890420Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711445}

Bug: 1011921
Change-Id: I50ddf9493080432a1797ee2deec7517f77b42d1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893360Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711444}

DownloadPathReseavationTracker::CheckDownloadPathForExistingDownload()
is called on UI thread. However, the g_reservation_map should only be
used DPRT's own task runner. As a result, there are race conditions
that cause the method to hit a null pointer.

This CL fixes the issue by posting a task on to DPRT's own task
runner. And also remove the feature flag that is already enabled.

BUG=1019627

Change-Id: Ibff4468f5a1fbaea4479481a115c835220089653
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891734
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711443}

Have SkiaOutputSurfaceImplOnGpu check that the SharedContextState isn't
null before using it. It will return null if MakeCurrent fails.

Bug: 1019690
Change-Id: I812f805413f57d0063a1c7c66dfdd556026db70e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893988Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711442}

The method references prevent the generated JNI wrapper classes from
being fully inlined.

Bug: 993421
Change-Id: Id4771b73cd28ba462d8cdf950573575ab215f1ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893990Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711441}

https://pdfium.googlesource.com/pdfium.git/+log/6524ae660745..0fa7fef72b53

git log 6524ae660745..0fa7fef72b53 --date=short --no-merges --format='%ad %ae %s'
2019-10-31 tsepez@chromium.org Make CFDE_TextOut::CalcLogicSize() take a WideStringView
2019-10-31 thestig@chromium.org Make CPDFXFA_WidgetHandler::NewAnnotForXFA() return a std::unique_ptr.
2019-10-31 thestig@chromium.org Refactor some common code in CPDF_DIBBase.
2019-10-31 tsepez@chromium.org Avoid c_str() then strlen() in view constructor in CFWL_ComboList.

Created with:
  gclient setdep -r src/third_party/pdfium@0fa7fef72b53

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=pdfium-deps-rolls@chromium.org

Bug: None
Change-Id: I87aacf6221cd562fb61b7158ba6552ab3be42bff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894231Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711440}

Bug: 998233
Change-Id: I16030e0984e8bab91c50078805642aa956dddcf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775263
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711439}

 - SetZoomLevelForView() was not used anywhere.
 - GetZoomLevelForView() was only used in a test. Replaced with GetZoomLevel().

Bug: None
Change-Id: If481d2477e924a4119d49ba586679c63d0320fc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877647
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711438}