- 21 May, 2020 40 commits
-
-
Tim van der Lippe authored
We will soon be using `acorn.mjs`, which would previously throw errors when loading, as `type="module"` enforces strict MIMEtype checking. Bug: 1011811 Change-Id: I1eaea02f94ebf74ee8fc32678cf29dde86c25b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212124 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#771219}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1589976000-30e90b5636af5c2bba45569eb90bae781c77ad14.profdata to chrome-win64-master-1590091165-7a7a14d98fbe05f411f7ca7cd83845ea7366876a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I271e611109de452279443db9a176f9e89d3ce0d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213008Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771218}
-
Joe DeBlasio authored
This CL adds U+0A5C as a lookalike character to the digit 3. This change appears to impact no domains seen in UKM. Fixed: 1085315 Change-Id: Iea9930363d853f154e2d781646a1b0b5da7fbbfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212807 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#771217}
-
Doug Arnett authored
This includes 3 fixes determined from turning on amp carousel page translation: 1. Only try to translate subframes that are visible. 2. Adds retry count to CheckTranslateStatus (to break rare loop). 3. Fixes overall translate error code to the one for the main frame. Note that these changes are in classes only used with Feature flag so no risk to mainline regressions. Bug: 1084262 Change-Id: I03541b9ab78813b2ace55e9b5e0379a8e952f8d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211042 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#771216}
-
wutao authored
Bug: b/157229763 Test: new js test Change-Id: I759e303d43bef8ee620c51960524f26c7510f0ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212664 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#771215}
-
Xing Liu authored
Due to the introduction of ImageFetcher.Params, some old APIs can be deleted. All plumbing for fetchImage() should use the Params now. Bug: 1076515 Change-Id: I5c4cbda79c882a0b763fcad86b84625366c20018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2192379Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Luca Hunkeler <hluca@google.com> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771214}
-
Chris Harrelson authored
Change-Id: If8f9a3498573cfd17e21dc8d0819a06c58579dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208099 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#771213}
-
Bo Liu authored
WindowAndroid needs to be explicitly destroyed. Caught this while trying to add LifetimeAssert to WindowAndroid to enforce this. Bug: 1081250 Change-Id: I2e888b8875f856946abb83fb91fd32d60845304b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212793Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771212}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/6f723ebbe3b0..2cf9621d6d6f 2020-05-21 dneto@google.com Reorder member init to match decl order (#2241) 2020-05-21 40001162+alelenv@users.noreply.github.com Add support for primitive culling layout qualifier. (#2220) 2020-05-21 rharrison@google.com Replace incorrect uint32_t with correct int vars (#2235) 2020-05-21 shuizhuyuanluo@126.com Do not build glslang-testsuite when ENABLE_CTEST is disabled (#2240) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I4b5d3dfae32bd796af4a6612eafd3b9bf14225d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212358Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771211}
-
Patrick Monette authored
EnumerateSharedWorkers() is meant to allow an observer to "catch up" to the notifications it missed by registering late. This must include the OnFinalResponseURLDetermined() call. Bug: 993029 Change-Id: Ib23b269b825c878682bb920651c999bd169f09a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204519 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#771210}
-
Adenilson Cavalcanti authored
This change enables building zlib using -O3 for the remaining code [1] including the portable files (e.g. deflate.c, etc). [1] We were already using optimize_speed for the majority of SIMD code and this CL extends that to build the same code we ship to users. Bug: 1084371 Change-Id: I02b0da7d0849478714bb7e3388c0d218fd13ecda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197140Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#771209}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/00ac5d82178c..7d2f8c57ee3e 2020-05-21 rharrison@google.com Rolling 6 dependencies and update expectations (#1073) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: Id452861be41cbbca95dfaf8ab5be7f9da5896c02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212587Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771208}
-
Abhijeet Singh authored
Add a test-fixture and basic tests for QuickAnswersView. Current tests verify the view's positioning with respect to its anchor and more tests will be added in follow-up CLs. Bug: b:157182213 Test: Built and ran ash:ash_unittests on local build. Change-Id: I44634313ff6538e48ef7375641e1971bfc989ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210977Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Cr-Commit-Position: refs/heads/master@{#771207}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/48c10ec7c5b0..a662485bdfb8 2020-05-21 primiano@google.com docs: Merge back from sprint repo If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iec9c34762c533c7bc26e10d4edad6b7aa91bd242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212862Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771206}
-
Avi Drissman authored
This reverts commit d0ba8444. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Fuchsia%20x64?limit=200 The Fuchsia bot had hundreds of green builds, but starting at this roll suddenly started failing 60% of builds. Original change's description: > Roll Fuchsia SDK from 0.20200520.3.1 to 0.20200521.1.1 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll > Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Tbr: cr-fuchsia+bot@chromium.org > Change-Id: I346a244ec5937979a28740b5c6c5ad60d093e398 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211889 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#771002} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,cr-fuchsia+bot@chromium.org Change-Id: I88a6fa373b5a91c5e9ff6fb60485f6303aa97cd0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212304Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#771205}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590076755-1b22274f1ce7584ce2730bbd2446e2694cb4fc1a.profdata to chrome-mac-master-1590091165-6474854792ed84c3f97a488e2950f553c812b299.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I3c5983279507958ba9154a0d78d20e5f90e6dbcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213002Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771204}
-
Avi Drissman authored
This reverts commit e90bd0c7. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Fuchsia%20x64?limit=200 The Fuchsia bot had hundreds of green builds, but starting at the previous roll suddenly started failing 60% of builds. reverting this to revert to a working sdk Original change's description: > Roll Fuchsia SDK from 0.20200521.1.1 to 0.20200521.2.1 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll > Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Tbr: cr-fuchsia+bot@chromium.org > Change-Id: I5d573839b6ca766ef1785188e5f3ed20b2e56381 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212687 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#771132} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,cr-fuchsia+bot@chromium.org Change-Id: I9e271e66d870391e54f83bed66e40273200f56ec No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212924Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#771203}
-
Brian Sheedy authored
Updates the GPU documentation on performing a driver/OS upgrade to use the swarming OR operator instead of the synthetic swarming dimensions. Bug: 920665 Change-Id: Id510e75e34b577282ad7b45d1b1282c135e00288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212922 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#771202}
-
Lei Zhang authored
Follow up to https://crrev.com/747851 to provide good examples to readers in the documentation. Change-Id: I14e1aa32abce51c9ae1f7499737ff612e440733c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212962Reviewed-by:
Henrique Ferreiro <hferreiro@igalia.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#771201}
-
Tanya Gupta authored
Add a flag for QRCodes on clank and gate the feature behind it. Bug: 1085185 Change-Id: I06c7a8583197ec0e2dd3dfba1b690cffd1e90bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211077 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#771200}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1a4f6e1f3ce1..93fc7d718e4c 2020-05-21 jonahr@google.com Add error-handling when getting Xcb window size 2020-05-21 geofflang@google.com Don't write alpha when blitting to a framebuffer with emulated alpha. 2020-05-21 xinyi.he@arm.com Vulkan: Remove GL_BGRX8_ANGLEX from configurations 2020-05-21 cclao@google.com Vulkan: change preferAggregateBarrierCalls to accomodate ARM on linux If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1080984 Tbr: geofflang@google.com Change-Id: I3c2a37c3d72c178e41f08e505a7f0d08fe136a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212589Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771199}
-
chrome-untrusted://resourcesTommy Steimel authored
This CL adds a second SharedResourcesDataSource to URLDataManagerBackend that is used to host the resources at chrome-untrusted://resources. This allows chrome-untrusted:// frames to access shared resources. Design doc: https://docs.google.com/document/d/1vM-giNmjhKBLGQHu5wMeMHk8VaqOhDWjVa9pYAKVZKY/edit?usp=sharing Bug: 1082937 Change-Id: I808f6c3d602c6fead880cf2362963dea6646ad21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202673Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#771198}
-
Wan-Teh Chang authored
If has_alpha is false, pass skcms_AlphaFormat_Unpremul instead of skcms_AlphaFormat_Opaque to skcms_Transform(). Brian Osman explains in an email to Peter Kasting: If we don't care about the "alpha" data, then using Unpremul is (slightly) faster. Unlike Skia, skcms interprets Opaque as instructions to *guarantee* that things are treated as opaque. This means that we will load the source data, then replace the alpha with 1.0, and also set it to 1.0 before writing if the dstAlpha is opaque. With unpremul src and dst, the alpha is never used, so it just gets loaded and stored without any extra work. After this CL, skcms_AlphaFormat_Opaque is only used in third_party/skia/tools/HashAndEncode.cpp, and only for srcAlpha. Change-Id: I38062ca46583ea0586be80e6a69980a1b1e777d3 Bug: 1085550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212781 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Brian Osman <brianosman@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771197}
-
Patrick Monette authored
EnumerateDedicatedWorkers is meant to allow an observer to "catch up" to the notifications it missed by registering late. This must include the OnFinalResponseURLDetermined() call. Bug: 993029 Change-Id: I89f38db0b7a6fbf1c3bd42985d7a721dccd0fc5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204439 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#771196}
-
Mario Bianucci authored
Collecting all of the ink metadata from the event and the provided style dictionary and propagating it from blink to CC, leaving it on the LayerTreeImpl for now. Bug: 1052145 Change-Id: Ic2652fb17102419f8b8e33ebd3b46bedcca02834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174340 Commit-Queue: Mario Bianucci <mabian@microsoft.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771195}
-
Xianzhu Wang authored
This is a reland of 87e1425b The original "Reland" was reverted because it broken msan due to an uninitialized field. Fixed. Original change's description: > Reland "Preserve LCD-text in SaveLayerAlphaOp when possible" > > This reverts commit 0bd440c5. > > Fixed (mostly invisible) raster invalidation issue with > PaintOpBuffer::NeedsAdditionalInvalidationForLCDText() to invalidate > the whole layer when LCD Text under SaveLayerAlpha may change. > > Original change's description: > > Revert "Preserve LCD-text in SaveLayerAlphaOp when possible" > > > > This reverts commit 0c258cbd. > > > > Reason for revert: Flakiness of raster result. crbug.com/1082804. > > > > Original change's description: > > > Preserve LCD-text in SaveLayerAlphaOp when possible > > > > > > This achieves LCD-text under non-composited opacity when possible. Pass > > > two flags to SkCanvas::SaveLayer() for SaveLayerAlphaOp: > > > kPreserveLCDText_SaveLayerFlag to preserve LCD text, and > > > kInitWithPrevious_SaveLayerFlag to to ensure an opaque background. > > > > > > This doesn't apply when there any SaveLayer modes which would break > > > LCD text or be broken by kInitWithPrevious_SaveLayerFlag. So we disable > > > the feature for the whole layer when there is any of such effects in > > > the layer. The new operation is also a bit more expensive, so only do > > > it when there is text. For now these two conditions are applied on the > > > whole layer for simplicity. Otherwise we would need to track them in > > > SaveLayerAlpha/Restore hierarchy which would be complex and error-prone. > > > > > > Bug: 942051 > > > Change-Id: I3ab2e8051e26c5714fd72830a7921099b9170d0d > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189260 > > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#768367} > > > > TBR=wangxianzhu@chromium.org,pdr@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 942051, 1082804 > > Change-Id: I36f281df4940588d5c2b1b4da415f5d22b0aa9e3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203495 > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#769425} > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 942051, 1082804 > Change-Id: Ic4bccc769a044061238469a38edf0822a6ed16c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206213 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770920} TBR=pdr@chromium.org Bug: 942051, 1082804, 1085377 Change-Id: If7ef04d70445154d2026f6dcc50714fd601efc0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211950Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771194}
-
Yichen Zhou authored
|presentation_time_recorder| will be released with the WorkspaceWindowResizer after the drag ends. However, in TAST testing, metrics is collected before WorkspaceWindowResizer gets released. If we don't release the recorder when drag is completed, the metrics will not be collected correctly and timeout errors may occur. Bug: 1032766 Change-Id: I7c7788ffc1255a33c47b41833813226de24f6531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211882 Commit-Queue: Yichen Zhou <yichenz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#771193}
-
Mike Wittman authored
Avoids racing to make up lost samples, and the bias resulting from that behavior, in the case where the sample tasks didn't execute on the expected schedule. This can happen during system suspend or in cases of system-wide jank. The correct solution is to skip the samples and continue sampling at the regular cadence, since the system was not actively executing in the interim. Expected impacts: For the UMA case, reduced bias towards execution immediately following resume. There will still be some bias towards the first 30 seconds of execution after resume because the profile scheduling remains unaware of suspend/resume cycles. For the tracing case, aligns the sampling exactly to the specified sampling interval on average. The sampling in the existing implementation was actually occurring on average at the specified interval plus half the timer tick interval. Bug: 876063 Change-Id: I6c0894bc9909131a4632765c6a6acc4678763bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199918 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#771192}
-
Justin Cohen authored
Bug: 1085394 Change-Id: I0f4c9def4906f7a7f1e964c7cf45e208504ae3e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212488 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#771191}
-
Dylan Cutler authored
Bug: 973801 Change-Id: I981d2c828380e9eb2da14f4d9e9706f29327c59c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209814 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#771190}
-
Ramya Nagarajan authored
This reverts commit fc4093a6. Reason for revert: Step "not_site_per_process_blink_web_tests on Ubuntu-14.04" failing on 1 builder(s) List of failed builders: Builder: linux-trusty-rel https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel crbug.com/1085549 Original change's description: > Move mouse-pointer-preventdefault.html to wpt > > Move mouse pointerevents compat events to wpt > > Change-Id: I9581dde4d6016a3eb81ea16674c439e63897523c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199985 > Commit-Queue: Liviu Tinta <liviutinta@chromium.org> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771159} TBR=lanwei@chromium.org,nzolghadr@chromium.org,liviutinta@chromium.org Change-Id: I6e5514be4338e895351c767a73711dfc9e17a63e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212923Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#771189}
-
Mansi Awasthi authored
Original CL: http://crrev.com/c/2172854 Revert: http://crrev.com/c/2204841 The original CL got reverted because following browser test was failing on the Mac10.12 tests bot - PDFExtensionTest.PdfAccessibilityContextMenuAction Added missing ContextMenuWaiter in the test to fix the issue. Original description: This CL adds support for invoking context menu on PDF via AT clients. To show context menu for PDF plugin, the context menu action can be invoked on respective EMBED node. This internally takes care of showing plugin related context menu option(See ContextMenuController::ShowContextMenu() for reference). Implemented PdfAXActionTarget::ShowContextMenu() that forwards the call to RenderAccessibilityImpl::ShowPluginContextMenu() to find the EMBED object in accessibility tree and invoke ShowContextMenu() on EMBED node. This CL also includes browser test to validate E2E scenario. CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_chromium_dbg_ng Bug: 1023283 Change-Id: Ie710fd24232b8dfeb3ce4bc6c0b56250ec9fbf0d Tbr: dmazzoni@chromium.org,jochen@chromium.org Change-Id: Ie710fd24232b8dfeb3ce4bc6c0b56250ec9fbf0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210080 Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771188} -
Sasha McIntosh authored
Re-land old metric and mark as obsolete. Fix new metric naming to include *.Custom.* Metric was moved in crrev.com/c/2164695. Change-Id: Id6a3400ba8488440667cd0dc977e6d2e34ffa767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204257 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#771187}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/50cdbe3343ad..dd4d881300f8 2020-05-21 joselea@microsoft.com End to end tests: Add cross tool integration tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1079076 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9f68cd0e8bf57c4f15794ac7369ca9491c1b0f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211865Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771186}
-
Behnood Momenzadeh authored
For target embedding matching, top domains could be matched when they are embedded without token separators (e.g. googlecom). In order to be able to match them, we need to generate skeletons of top domains without token separators. This change adds these skeletons to skeletons list as well as adding a flag in |TopDomainEntry| to show if the found match was with a without-separator skeleton or a regular skeleton. Change-Id: Id1387ef438f1ae0c73190c0b1cad913f6ad51b4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205517Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Behnood Momenzadeh <behnoodm@google.com> Cr-Commit-Position: refs/heads/master@{#771185}
-
Trent Begin authored
Now that ShillPropertyManager listens for changes to the Prohibited Technology property, add a unit test that ensures NetworkHealth correctly reports the kProhibited state. Bug: chromium:1081488 Change-Id: Id4977581b439e6b634dfdad1401b595bd6681605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197149 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#771184}
-
Sonny Rao authored
We're still monitoring many of these and they can be useful in detecting regressions. Platform.SwapOutShort Platform.SwapOutLong Platform.SwapInLong Platform.SwapInShort Platform.ZramCompressedSize Platform.ZramCompressionRatioPercent Platform.ZramSavings Platform.ZramZeroPages Platform.ZramZeroRatioPercent Platform.CompressedSwapSize Platform.MeminfoShmem Platform.MeminfoMemUsedDerived Platform.MeminfoMemFreeDerived Platform.MeminfoMapped Platform.Mem Platform.MeminfoAnonPages Platform.MeminfoInactive Platform.MeminfoCached Platform.MeminfoProcessDataTotal Platform.MeminfoInactiveAnon Platform.MeminfoSwapUsedPercent Platform.MeminfoFileTotal Platform.MeminfoActiveAnon Platform.MeminfoInactiveFile Platform.MeminfoSwapUsed Platform.MeminfoBuffers Platform.MeminfoMemFree Platform.MeminfoActive Platform.Meminfo Platform.MeminfoUnevictable Platform.MeminfoActiveFile Platform.MeminfoMemTotal Platform.MeminfoSlab Platform.PageFaultsLong Platform.PageFaultsShort Bug: 1084075, 1084076, 1084077, 1084071, 1084073, 1084074 Change-Id: I525ca24ad20e6d5f98f9c0c5ebebe75a1740afc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208824Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Sonny Rao <sonnyrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#771183}
-
Sahel Sharify authored
This cl extends the expiration time of the following histogram since its event count needs to be monitored during Gpay+PH experiment roll out. PaymentRequest.ServiceWorkerStatusCodeTimeout TBR=rkaplow@chromium.org Bug: 1070245 Change-Id: I86d8402670ca88bd4260367b58abefed7651b381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212784Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#771182}
-
Reilly Grant authored
These functions may cause DLLs to be loaded for socket providers in the process of enumerating device services. This macro temporarily boosts this background thread's priority in order to avoid a priority inversion where the main thread (and others) hang while this low priority thread holds the dynamic library loader lock. Observed this hang in crash/08cf98f7a1b73d12. Bug: 973868 Change-Id: Ibb80c37c735471958f7b41460831aad2891ccf78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212671 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#771181}
-
Sonny Rao authored
These are related to CrOS performance and are still used. Platform.CpuUsage Platform.BootSectorsWritten Platform.LogicalCpuCount Platform.BootSectorsRead Platform.CpuFrequencyThermalScaling Bug: 1084067, 1084070 Change-Id: I34e62d39a5833d7c242fd7c9958871179950d1db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211018Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Sonny Rao <sonnyrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#771180}
-