- 24 Aug, 2018 40 commits
-
-
rbpotter authored
These tests were disabled by https://crrev.com/c/1176206 because they were reported as flaky on debug builds. Based on the flakiness dashboard, it appears the failures were timeouts on the Win10 Tests x64 (dbg) bot. interactive_ui_tests is marked as experimental on this bot due to crbug.com/840369. The webui_polymer2_interactive_ui_tests suite is expected to have the same behavior, so it should also be marked as experimental on this bot. Remove the tests from the blacklist, as they should pass on other bots. Bug: 875443 Change-Id: Ib5b3c99cf589b1ab9994346460e95ed746533ba6 Reviewed-on: https://chromium-review.googlesource.com/1187729Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#586066}
-
Wez authored
This is a reland of a2a4e75d with a work-around for cronet_tests' sharing libbase.so with libcronet.so in component builds. - Move some APIs off of base::TestSuite, that we unnecessarily public. - Rename the various internal TestEventListeners to express purpose. - Add CheckForLeakedGlobals check, and DisableCheckForLeakedGlobals API. The latter is called by the content::ContentTestSuiteBase, since the various browser- and ui-tests running under that suite base run more like the browser itself, and so are expected to let global singletons leak. If tests fail or flake due to this patch, then this indicates that the test is actually leaking global state that may break other tests if they happen to run in the same process, leading to hard-to-diagnose flakes. There are two main failure cases: If the test directly or indirectly uses TaskScheduler, but does not create a ScopedTaskEnvironment, then please add one to the test, or to the test base-class, as appropriate, to fix it. If the test suite cannot be fixed in this way then please add a call to DisableCheckForLeakedGlobals(), with a comment linking to a bug for the issue. TBR: gab, sky, mef Bug: 875486, 877355, 744567 Change-Id: Iaea38d24ede271c248a3abb0b3f7ee931c2538f5 Reviewed-on: https://chromium-review.googlesource.com/1187783Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#586065}
-
Steven Holte authored
This field was dropped by a revert, but we have data for it, so re-add the description. https://crrev.com/d38f4e3c1225c36574911f6fdeecdb1b236dd054 Change-Id: Ie68bc76ced75a1d6269b252801cda76baa5de9ff Reviewed-on: https://chromium-review.googlesource.com/1188765Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#586064}
-
Matt Mueller authored
Fixes network_service_content_browsertests RenderThreadImplBrowserTest.NonResourceDispatchIPCTasksDontGoThroughScheduler failing to find the utility service process exe on Windows, like: [FATAL:utility_process_host.cc(263)] Check failed: false. Unable to get utility process binary name. Bug: 876947 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ia7f51366e4b4db27ec8c3bbee3d57866c1bd67b9 Reviewed-on: https://chromium-review.googlesource.com/1185628 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#586063}
-
Steve Kobes authored
FrameViewAutoSizeInfo should not add hypothetical vertical scrollbar space when we already have a real vertical scrollbar. The real scrollbar is included in the LayoutView's preferred width (since crrev.com/397112). If the redundant accomodation makes the scrollbar detectably unnecessary, the next autosize reduces the width, making it appear again. The autosized FrameView now accomodates exactly one vertical scrollbar in this scenario, instead of infinitely bouncing between two and zero. The scrollbar could actually be removed even at this size, but the code isn't smart enough to detect that. Bug: 838150 Change-Id: I23dce5a37faed33de978e1d2182009a2fe0c6fd1 Reviewed-on: https://chromium-review.googlesource.com/1188767Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#586062}
-
Joe Downing authored
This change decouples the mouse/keyboard input monitors from ClientSessionControl and allows them to be used for other purposes. Bug: 877176 Change-Id: Idcefa8a8dd1d36bb57f83b8a27d8aba90981466f Reviewed-on: https://chromium-review.googlesource.com/1189027Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#586061}
-
Scott Little authored
The flaky tests are: external/wpt/editing/run/delete.html?1-1000 external/wpt/editing/run/delete.html?1001-2000 external/wpt/editing/run/delete.html?3001-4000 external/wpt/editing/run/delete.html?4001-5000 external/wpt/editing/run/delete.html?5001-6000 external/wpt/editing/run/delete.html?6001-last external/wpt/editing/run/forward_delete.html?1-1000 external/wpt/editing/run/forward_delete.html?1001-2000 external/wpt/editing/run/forward_delete.html?2001-3000 external/wpt/editing/run/forward_delete.html?3001-4000 external/wpt/editing/run/forward_delete.html?4001-5000 external/wpt/editing/run/forward_delete.html?5001-6000 external/wpt/editing/run/forward_delete.html?6001-last external/wpt/editing/run/delete.html?2001-3000 isn't in this list since it's already disabled elsewhere in this TestExpectations file. TBR=foolip@chromium.org Bug: 877104 Change-Id: I01dd8218bddc9c1c726da03a062a714fc4f1f56c Reviewed-on: https://chromium-review.googlesource.com/1188896Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#586060}
-
Sergey Ulanov authored
Scenic is the only ozone platform usable on fuchsia. Previously, when compiling with is_chromecast=true the cast platform was enabled, so cast_shell wasn't compiling properly. Bug: 877264 Change-Id: If40c4ad28678015a2e357f86336cf56e1c484ac7 Reviewed-on: https://chromium-review.googlesource.com/1187654Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#586059}
-
Chong Zhang authored
This patch copied 'clear_site_data_throttle.h/.cc' into 'clear_site_data_handler.h/.cc' with the following differences: 1. The new handler will be called through the |NetworkServiceClient| pipeline to work with Network Service. 2. The new handler doesn't have special handling for Service Worker. * The assumption is that the response from network process (NetworkServiceClient) won't be modified by Service Worker. 3. The new handler won't defer console messages for navigations. Future works could fix this to match current behavior (marked as TODO). 4. The new handler will always defer the request if it has 'Clear-Site-Data' header, and resume after the browser finished processing. We have to duplicate the codepath because |NetworkServiceNetworkDelegate| currently doesn't work without Network Service, and the new handler interface has no information about Service Worker. This patch fixed all Clear-Site-Data related tests (10 browser tests and 2 layout tests). crbug.com/876931 tracks remaining non-Canary blocking TODOs. Bug: 721398 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I065140ab49ab3647cba0e64717440d0f1bf42095 Reviewed-on: https://chromium-review.googlesource.com/1170200 Commit-Queue: Chong Zhang <chongz@chromium.org> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1118cfdbdcc2..92bc476c8c49 git log 1118cfdbdcc2..92bc476c8c49 --date=short --no-merges --format='%ad %ae %s' 2018-08-24 herb@google.com Rearrange templates to get ios to compile 2018-08-24 scroggo@google.com Revert "Reland "Switch SkCodec to use skcms" plus fixes" 2018-08-24 robertphillips@google.com Fix drawRect 2018-08-24 herb@google.com Have GPU and RemoteGlyphCache share mask position code 2018-08-24 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 8ca60805916f..337bd6984078 (2 commits) 2018-08-24 liyuqian@google.com Remove gclient sync from calmbench 2018-08-24 herb@google.com Add back tight scaler context managment 2018-08-24 allanmac@google.com Cut-and-paste typo was limiting concurrency 2018-08-24 scroggo@google.com Reland "Switch SkCodec to use skcms" plus fixes 2018-08-24 brianosman@google.com Reland "match sRGB primaries with skcms" 2018-08-24 ethannicholas@google.com fixed skslc's nested conditional break detection 2018-08-24 herb@google.com Reorganize TrackLayerDevice and move processGlyphRunForMask 2018-08-24 robertphillips@google.com Suppress failing Vulkan test on IntelHD405 2018-08-24 kjlubick@google.com [PathKit] Write more complete docs and clean up API to be consistent Created with: gclient setdep -r src/third_party/skia@92bc476c8c49 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: Ib5356de96cb02bd534c76b2a390ef6212fdb6144 Reviewed-on: https://chromium-review.googlesource.com/1188924Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586057}
-
Dimitri Glazkov authored
This clarifies dependency on test filter data, since it is only used by the "test" template. Also, it paves the path for building v8 on Fuchsia standalone: the "fuchsia_package_runner" template can be used directly in v8 repo, and in v8-only checkout. Change-Id: Ibe171c48ee818cc5b722294f682f83c3ae240908 Reviewed-on: https://chromium-review.googlesource.com/1180731Reviewed-by:
-
John Z Wu authored
CSP can prevent eval and will cause this error: "refused to evaluate a string as javascript because 'unsafe-eval'" This fails silently on iOS so we need to catch it. Bug: 686364 Change-Id: I5de275576670846dffc29f9f2c3916259196e70f Reviewed-on: https://chromium-review.googlesource.com/1183944Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#586055}
-
Brandon Wylie authored
Bug: 875088 Change-Id: Ic5edb56d0621c6685d6cb1cfe03f54e57990c068 Reviewed-on: https://chromium-review.googlesource.com/1182670 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#586054}
-
Lukasz Anforowicz authored
Bug: 848821 Change-Id: I5e0dd225cdf7163e159286352a096c9cffe1d32b Reviewed-on: https://chromium-review.googlesource.com/1188965Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#586053}
-
Sergey Volk authored
Previously Chromecast used to upload crash reports from debug/eng builds to crash-staging/ server. But according to crash-users@ the staging server was only meant for internal testing, we shouldn't be using it. Instead we should upload all our crashes to the main crash/ server. Chrome and ChromeOS already upload all their crashes, from all channels including dev and canary, to the main server. And this CL will make Chromecast to always use the main server as well. Bug: 112111490 Change-Id: Ic94ba1ba7d52d7188bb2fcfb6149cb734715b7d4 Reviewed-on: https://chromium-review.googlesource.com/1161004 Commit-Queue: Sergey Volk <servolk@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#586052}
-
Reid Kleckner authored
There is no extra 'cmake' path component after bin on Linux. Hopefully this will resurrect the Linux Clang ToT bots after https://crrev.com/585976. TBR=hans@chromium.org NOTRY=True Bug: 797991 Change-Id: I7e1e38e824c8986303a9ec1972bb5f57a2cd9bea Reviewed-on: https://chromium-review.googlesource.com/1189034Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#586051}
-
Yue Cen authored
Bug: 835029 Change-Id: I6b483f66203120d3684c0da6ba29bf9997116cee Reviewed-on: https://chromium-review.googlesource.com/1164251 Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#586050}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ce26d7d03d6c..e6ff2ebfaa19 git log ce26d7d03d6c..e6ff2ebfaa19 --date=short --no-merges --format='%ad %ae %s' 2018-08-24 tsepez@chromium.org Rename CFX_DIBSource to CFX_DIBBase. 2018-08-24 tsepez@chromium.org Use span<uint8_t> in more fxcodec code. 2018-08-24 npm@chromium.org Cleanup CalculateBaseSpace in CPDF_TextPage Created with: gclient setdep -r src/third_party/pdfium@e6ff2ebfaa19 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id69be6a3555fb225e9caff406ea93da4c669b176 Reviewed-on: https://chromium-review.googlesource.com/1188925Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586049}
-
GauthamBanasandra authored
As per the browser protocol, the field scriptResponseTime is optional. Hence adding a check to see if it present before displaying it. Bug: 767790 Change-Id: I2638328aeec901419e48977ba40a15971da43f8b Reviewed-on: https://chromium-review.googlesource.com/1180623 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#586048}
-
Joel Einbinder authored
Change-Id: Ib3b65c377de9b6fed273bbf6d41daf7d6f275f66 Reviewed-on: https://chromium-review.googlesource.com/1188878Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#586047}
-
Nate Fischer authored
This only changes debugging pages in Chrome, not general Safe Browsing behavior. This adds two new pages to chrome://interstitials for Loud and Quiet Malicious Unwanted Software warnings (AKA "MUwS", "UwS", "Harmful"). R=jialiul@chromium.org Unwanted Software links" --gtest_filter=InterstitialUITest.UnwantedSoftwareInterstitial* Bug: 729271 Test: Manual - open chrome://interstitials and click the new "Malicious Test: out/Desktop/browser_tests \ Change-Id: Iab28f8099e184a747c7589ffda19098126d25c86 Reviewed-on: https://chromium-review.googlesource.com/1188948Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#586046}
-
Joel Einbinder authored
When there are too many tabs to fit in the tab list, the button to see more tabs was unlabeled. Change-Id: Iadab77398a6bbf82d788d5a5e1cc0dc53ae1b589 Reviewed-on: https://chromium-review.googlesource.com/1188881Reviewed-by:
-
Scott Little authored
This reverts commit f933e705. Reason for revert: Broke compile on Google Chrome ChromeOS bot: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/55439 Original change's description: > Chrome OS: Add Discover window UI. > > This CL adds Chrome OS Discover UI in separate window. > > Window need further changes to match the specs, but this > change mostly adds infrastructure. > > Bug: 864686 > > Change-Id: I2834d8f9efb3660050a31768508992acb1f3f262 > Reviewed-on: https://chromium-review.googlesource.com/1182880 > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586034} TBR=xiyuan@chromium.org,isherman@chromium.org,alemate@chromium.org Change-Id: Idaaf3bf2adf129d746de7a466d9c433ed52b41c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 864686 Reviewed-on: https://chromium-review.googlesource.com/1189032Reviewed-by:
-
Kevin Marshall authored
TBR=sahel@chromium.org,tdresser@chromium.org Bug: 836996 Change-Id: Ic88f4b3f3ced63a83a25fa9c341ceaec8a7302a0 Reviewed-on: https://chromium-review.googlesource.com/1189026 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#586043}
-
Yuwei Huang authored
MDCAppBar will soon be deprecated. This CL migrates all MDCAppBar code to use MDCAppBarViewController. It is basically following the migration guide here: https://github.com/material-components/material-components-ios/tree/develop/components/AppBar#migration-guide-mdcappbar-to-mdcappbarviewcontroller Bug: 874534 Change-Id: Ibe3ea272763b98bd7ded513111167221f06c9e6b Reviewed-on: https://chromium-review.googlesource.com/1187402Reviewed-by:
-
Eugene But authored
Slim Navigation Manager asynchronously restores the session. During session restoration it's not possible to perform back-forward navigation. This change prevents all delta navigations until the session is restored. Bug: 877671 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I801a99182582118862d03796532588f1495de9c6 Reviewed-on: https://chromium-review.googlesource.com/1187677Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#586041}
-
Sonny Sasaka authored
Currently the page fetches the Bluetooth device list when there is a new Bluetooth device added. This is not quite right, since we can't rely on the expectation that a new Bluetooth device will be discovered often. This problem has become even more visible ever since we implemented Bluetooth device filter that dramatically lowers the probability of new device appearing. As a result users often encounter that the Bluetooth settings page show no devices at all (while actually will eventually show some devices after waiting for very long). The bug is due to race condition that bluetoothToggleState is updated later than adapterStateChanged_. So the solution is to not rely on bluetoothToggleState but adapterStateChanged when updating device list. Bug: 851723 Change-Id: Ib4d0207f04fd938ad1744c453f5bf24b9fd78ad0 Reviewed-on: https://chromium-review.googlesource.com/1187718 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#586040}
-
Eric Karl authored
Surface synchronization has launched on desktop but has not shipped on Android yet. We'd like to attempt to launch it soon. This CL turns on surface sync by default on bots on Android. Bug: 672962 Change-Id: I24e8eda65a090d16aa349167e7b805be924bae1d Reviewed-on: https://chromium-review.googlesource.com/1162438 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#586039}
-
Helen Li authored
Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0d414ef898e5f053afe8d6a884556dee06b06a96 Reviewed-on: https://chromium-review.googlesource.com/1183987Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#586038}
-
CJ DiMeglio authored
This CL adds an a11y button to allow fullscreening into the display cutout area in addition the predefined gesture. Bug: 867955 Change-Id: I7f1b47b11ac40d9d3ede9181c536d433fdeb03ed Reviewed-on: https://chromium-review.googlesource.com/1171724 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#586037}
-
Alex Leung authored
BUG=b:113066827 Change-Id: Ic0e1d434eadbddf38f0fc6b2a5a6b1f364e947af Reviewed-on: https://chromium-review.googlesource.com/1188588Reviewed-by:
-
James Cook authored
Switch everything to: * IsUsingWindowService * IsSingleProcessMash * IsMultiProcessMash Hopefully this makes it clearer when ash really is in the browser process. Fix one keyboard-related conditional too. TBR=kbr@chromium.org Bug: 874468 Test: ash_unittests with SingleProcessMash locally, spot check browser_tests Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0d175240dfff820cbf612fb7e30fec72ba5b81a2 Reviewed-on: https://chromium-review.googlesource.com/1188750 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#586035}
-
Alexander Alekseev authored
This CL adds Chrome OS Discover UI in separate window. Window need further changes to match the specs, but this change mostly adds infrastructure. Bug: 864686 Change-Id: I2834d8f9efb3660050a31768508992acb1f3f262 Reviewed-on: https://chromium-review.googlesource.com/1182880 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#586034}
-
Kevin Bailey authored
Currently we just sort suggestions by relevance and keep the best of several duplicates. This can remove allowed_to_be_default_match's. This change keeps the best default match, if any, and in fact promotes it to the best relevance of the non-default matches (if it's better). Bug: 542780 Change-Id: Ie53f10d421412c390259891290fa15a951a4a2e1 Reviewed-on: https://chromium-review.googlesource.com/1174860 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#586033}
-
Yi Su authored
ImageFetchTabHelper will be able to get image data by both JavaScript and image_fetcher::IOSImageDataFetcherWrapper. The image_fetcher ivar of BVC can be removed once this is completed. Bug: 163201 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie5bb9279c5fb19498d3cde4c37cdf8944baa9e98 Reviewed-on: https://chromium-review.googlesource.com/1181571Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#586032}
-
Yuwei Huang authored
This CL bumps the targetSdkVersion to 28 since our app should be fully supporting Pie features (i.e. cutout adjustments). Bug: 831670 Change-Id: I7e1507f4c3c56ed802de3af75eafea3b9024d826 Reviewed-on: https://chromium-review.googlesource.com/1188897Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#586031}
-
Min Chen authored
it has been snapped. We did defer resetting the transform to identity of the drag window from overview items until it has been snapped. In order to avoid the weird transform if trying to snap an arc window. Previous cl: https://chromium-review.googlesource.com/c/chromium/src/+/910076 We should do the same thing if we try to snap a window through drag from the top. Changes in this cl, - Do not restore the drag window's transform to identity when end window drag if the window should be snapped or drop into overview. - Restore identity transform after window has been snapped. Calculate a starting transform for the to-be-snapped window based on its transformed bounds before to be snapped. - Move the logic of GetTransformedBounds and GetTopInset to overview_util. Bug: 872538 Change-Id: Icc2f034e0752fba4ba8ec673022e1f9306ca35b2 Reviewed-on: https://chromium-review.googlesource.com/1178385 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#586030}
-
Pavel Feldman authored
This reverts commit bab2befc. Reason for revert: test expectations for inspector now include the source code line number. This means that any change to the source requires rebaselining all the tests. Original change's description: > Show Deprecation message for Shadow DOM V0. > > This patch marks them deprecate at M73. > > Bug: 671907 > Change-Id: I0ba155ad98ff0add788b9089e65cb0a3ea03b3f5 > Reviewed-on: https://chromium-review.googlesource.com/1180840 > Reviewed-by: Hayato Ito <hayato@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585764} TBR=hayato@chromium.org,tkent@chromium.org,yoichio@chromium.org Change-Id: I4d6b33052bcdd54f0de25127d4334c35e49bb9e9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 671907 Reviewed-on: https://chromium-review.googlesource.com/1189025Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#586029}
-
Fredrik Söderquist authored
In the paint code (ClipPathClipper), the reference box used is the one computed by LocalReferenceBox(), and the coordinate space is adjusted for that. In the hit-testing code however, the reference box is adjusted instead, leading to incorrect results when the reference box is subjected to an additional transform (a 'transform' on a <clipPath>.) Instead, set up the reference box and coordinate space in the hit- testing code in the same way as for paint, by translating to the correct local coordinate space before performing the actual hit-test. Bug: 876390 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I60acd616964a942893f0e256766aca728d14b494 Reviewed-on: https://chromium-review.googlesource.com/1188302Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#586028}
-
Alex Newcomer authored
The Autohide Shelf context menu option lets the user make the shelf hide when a window is maximized. This option used to have a check mark signifying that autohide was enabled. With touchable app context menus, there is no check mark. To work like a checkmark, we will add a new selection option which toggles with "Autohide Shelf". It is called "Always Show Shelf". Bug: 875781 Change-Id: I6ed9f42cd6ac3e67f70110ea69944cc18a7abba7 Reviewed-on: https://chromium-review.googlesource.com/1188888Reviewed-by:
-
