GitLab

Whitelisting an extension per: crbug.com/374965

BUG=374965
TEST=None
R=miket@chromium.org

Review URL: https://codereview.chromium.org/297603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272547 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=True

Review URL: https://codereview.chromium.org/296153010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272546 0039d316-1c4b-4281-b951-d872f2087c98

Adding automatic tests to the password manager to simulate user interaction with websites.

BUG=369521

Review URL: https://codereview.chromium.org/273523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272545 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354051

Review URL: https://codereview.chromium.org/291893011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272544 0039d316-1c4b-4281-b951-d872f2087c98

Previously PPAPINaClNewlibTest.PostMessage SendInInit was flaking. The problem seems to be that the messages that are sent in Init() may be replied to and handled in HandleMessage() before RunTests() is run (Init() and RunTests() are called asynchronously). When this is the case, WaitForMessages() can return 0, even though the message from Init() is properly received, because the value of message_data_.size() is 1 before and after the function returns. There is actually no need to check the return value of this function, checking the size of message_data_.size() (which we already do) should be sufficient.

BUG=372630

Review URL: https://codereview.chromium.org/299893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272542 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370448
NOTRY=true

Review URL: https://codereview.chromium.org/296983008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272541 0039d316-1c4b-4281-b951-d872f2087c98

On Win7 Tests (dbg)(2) these tests

FocusElementCallsFocusedNodeChanged
GetCompositionCharacterBoundsTest
MessageOrderInDidChangeSelection
OnExtendSelectionAndDelete
OnImeTypeChanged
OnSetTextDirection
SendCandidateWindowEvents
SetEditableSelectionAndComposition

fail with timeout.
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%282%29/builds/21101/steps/content_browsertests/logs/stdio

> Destroy all rtc peer connection handlers before shutting down blink
> 
> The connection handlers will otherwise continue to call into blink which
> is bound to crash after it was shut down.
> 
> BUG=337572
> R=perkj@chromium.org,adamk@chromium.org
> 
> Review URL: https://codereview.chromium.org/292163002

TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/296213007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272540 0039d316-1c4b-4281-b951-d872f2087c98

Add a flag to all of the registry related work items to specify whether to operate on the 64-bit or 32-bit hive on a WOW64 system.

Make DeleteRegKeyWorkItem call down into RegKey so WOW64 support works for delete work items.

All calls changed to use the Wow64_Default (0) parameter, so the behavior is identical.

This is prep for adding 64-bit support to the installer.

BUG=348626,338706
R=grt@chromium.org, grt
TBR=sky
TEST=installer_util_unittests

Review URL: https://codereview.chromium.org/282363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272539 0039d316-1c4b-4281-b951-d872f2087c98

Use stub implementations of all D-Bus clients when
--dbus-stub is passed instead of only using the stub
implementation of PowerManagerClient.

BUG=371289

Review URL: https://codereview.chromium.org/282873005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272538 0039d316-1c4b-4281-b951-d872f2087c98

This will affect the cocoa and views versions of the profile_chooser.


BUG=357693

Review URL: https://codereview.chromium.org/297803007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272537 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370433
TEST=None
R=sky@chromium.org

Review URL: https://codereview.chromium.org/297833006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272536 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272528 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366850

Review URL: https://codereview.chromium.org/276433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272526 0039d316-1c4b-4281-b951-d872f2087c98

The code this is referring to has moved. It's now checked as part of testing
whether metrics reporting is enabled, internally to the metrics code.

BUG=none
TEST=none
R=asvitkine@chromium.org
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/295103010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272525 0039d316-1c4b-4281-b951-d872f2087c98

R=bulach@chromium.org

Review URL: https://codereview.chromium.org/298973005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272524 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272523 0039d316-1c4b-4281-b951-d872f2087c98

a3f590b  Add Matt Giuca to AUTHORS.
4db62f5  Fixed or silenced all warnings and turned on warnings-as-errors.
2c4b046  cf2hints: Fix early loop termination causing hints to be ignored.
4fbe779  Add some blank lines at the end of 3 files to remove the "no newlines at end of file" warning.
6f9095f  Add my @chromium account in the AUTHORS file.
54c1825  Remove "using namespace agg" to make it clear which code is using agg, and also so we can turn compiler warnings into errors.
5ce98f5  Fix warning on Mac.
41f0590  Remove "using namespace v8" in header. This allows us to turn all warnings into errors. It also makes it clearer to find usage of v8 in the library.

R=thestig@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271905

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272277

Review URL: https://codereview.chromium.org/295983005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272522 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272520 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174635:174659&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/296953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272519 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Remove tools/safely-roll-blink now that tools/safely-roll-deps is stable. (https://codereview.chromium.org/291333007/)

Reason for revert:
This removed the wrong file (safely-roll-deps instead of safely-roll-blink).  Now Skia's AutoRoll Bot is broken.

Original issue's description:
> Remove tools/safely-roll-blink now that tools/safely-roll-deps is stable.
> 
> "tools/safely-roll-deps /src blink"
> is the replacemnt syntax.  No need to keep dead code around.
> 
> BUG=242461
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272347

TBR=maruel@google.com,borenet@chromium.org,eseidel@chromium.org,blink-deps-roller@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=242461

Review URL: https://codereview.chromium.org/294163012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272518 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367239

Review URL: https://codereview.chromium.org/296943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272516 0039d316-1c4b-4281-b951-d872f2087c98

The refactoring in the final patchset landed as r269766 got the
condition backwards (the pre-refactoring version worked), so we were
accidentally excluding flag only on *target* builds, instead of host
builds as intended (the target compiler supports this flag). Fix it.

BUG=321833
R=primiano@chromium.org

Review URL: https://codereview.chromium.org/296273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272511 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374758

Review URL: https://codereview.chromium.org/294783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272510 0039d316-1c4b-4281-b951-d872f2087c98

BUG=n/a
TBR=tzik@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/295203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272509 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272508 0039d316-1c4b-4281-b951-d872f2087c98

The implementation of glLoseContextCHROMIUM did not return early
in gl error conditions of invalid enums passed as arguments. Add
the early returns and tests for the invalid enums.

Upon successful glLoseContextCHROMIUM, the subsequent calls
such as glGetError would also fail, because the implementation
would set the decoder error variable as well as return the error
value. Fix this by just setting the decoder error variable. Add
a test for this (LoseContextCHROMIUMValidArgs)

BUG=373159

Review URL: https://codereview.chromium.org/298753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272507 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff jkummerow@chromium.org in case of problems.

TBR=jkummerow@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/299893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272506 0039d316-1c4b-4281-b951-d872f2087c98

The connection handlers will otherwise continue to call into blink which
is bound to crash after it was shut down.

BUG=337572
R=perkj@chromium.org,adamk@chromium.org

Review URL: https://codereview.chromium.org/292163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272504 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Turn GoogleURLTrackerNavigationHelper(Impl) into a per-tab object. (https://codereview.chromium.org/283413002/)

Reason for revert:
Introduced flake on Mac: crbug.com/376550

Original issue's description:
> Turn GoogleURLTrackerNavigationHelper(Impl) into a per-tab object.
> 
> The goal of this CL is to eliminate the dependence of
> GoogleURLTracker(MapEntry) on NavigationController. To accomplish this goal,
> GoogleURLTrackerNavigationHelper is turned into a conceptually per-tab
> interface. GoogleURLTracker::OnNavigationPending() now takes in the
> GoogleURLTrackerNavigationHelper with which the navigation is associated rather
> than the associated NavigationController; GoogleURLTracker performs per-tab
> actions by calling the navigation helper associated with the tab.
> 
> A followup CL will turn GoogleURLTrackerNavigationHelper(Impl) into the
> GoogleURLTrackerDriver interface and ContentURLTrackerDriver implementation.
> 
> BUG=373230
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272094

TBR=pkasting@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=373230

Review URL: https://codereview.chromium.org/294193005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272503 0039d316-1c4b-4281-b951-d872f2087c98

This setting can be configured by device owners to indicate whether
developer mode should be available on their device. session_manager
will take care of configuring the system to behave accordingly.

BUG=chromium:375772
TEST=None

Review URL: https://codereview.chromium.org/293033012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272502 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Update AudioRenderer API to fire changes in BufferingState. (https://codereview.chromium.org/284763002/)

Reason for revert:
Broke blink tests:
mediasource-redundant-seek.html
mediasource-seek-during-pending-seek.html

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6/builds/28147

Original issue's description:
> Update AudioRenderer API to fire changes in BufferingState.
> 
> As a result, Pipeline now handles prerolling and underflow/rebuffering
> by listening for BUFFERING_HAVE_NOTHING/ENOUGH callbacks. Preroll() is
> renamed StartPlayingFrom() and no longer accepts a completion callback.
> In this new model, AudioRenderers immediately enter and remain in
> the "playing" state and fire buffering state callbacks to let Pipeline
> know when to start/stop the clock.
> 
> BUG=144683
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272465

TBR=acolwell@chromium.org,scherkus@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=144683

Review URL: https://codereview.chromium.org/291093013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272501 0039d316-1c4b-4281-b951-d872f2087c98

Previously we did not call onDetached on old native AwContents,
which now no longer cleans up hardware resources correctly.

This also had the side effect that the following onAttach with the new
native AwContents is ignored in java code due to attach/detach mismatch.

As make onDetached more strict with respect to ordering. And lock to
protect variable accessed on multiple threads.

Also need to ensure we never requestDrawGL on the blank native
AwContents that's destroyed during pop up.

BUG=376622

Review URL: https://codereview.chromium.org/288983007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272500 0039d316-1c4b-4281-b951-d872f2087c98

This regressed in r271640.

Review URL: https://codereview.chromium.org/298803013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272499 0039d316-1c4b-4281-b951-d872f2087c98

This method is needed to inject the other DRMs' keysystem and uuid mapping
in MediaDrmBridge.

BUG=322395

Review URL: https://codereview.chromium.org/284183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272498 0039d316-1c4b-4281-b951-d872f2087c98

This is the Mac part of https://codereview.chromium.org/294593004

BUG=360559

Review URL: https://codereview.chromium.org/296503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272497 0039d316-1c4b-4281-b951-d872f2087c98

Make the tests run for every commit to make sure tests and code
stay in sync and are both working.

BUG=

Review URL: https://codereview.chromium.org/296003007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272496 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374648
TEST=unit_tests

Review URL: https://codereview.chromium.org/299623012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272495 0039d316-1c4b-4281-b951-d872f2087c98

 * Replace base class of LocalToRemoteSyncer with SyncTask
 * Add testing SyncTaskToken.
 * Clean up LocalToRemoteSyncer implementation.

BUG=344769

Review URL: https://codereview.chromium.org/297803011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272494 0039d316-1c4b-4281-b951-d872f2087c98

This is a reland of https://chromiumcodereview.appspot.com/255693002/

Race conditions in Skia have been fixed.

BUG=322185

Review URL: https://codereview.chromium.org/286903021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272493 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272492 0039d316-1c4b-4281-b951-d872f2087c98