- 15 Sep, 2020 40 commits
-
-
Becca Hughes authored
BUG=1128462 Change-Id: I78a060c655e7ffd90a636a428e3565bd510f5c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410291 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#807125}
-
Dominic Mazzoni authored
Page info bubbles just display a single string. To match recent UX mocks, the text of these bubbles should be multi-line and the bubbles should be the minimum width for a page info bubble (currently 320px). Bug: 1124489 Change-Id: I5fbe9e3395b450d8f45b7cc55f5bb09aeb95a1e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409136Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#807124}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/534924ed9ee5..93d0ecf3d428 2020-09-14 dpranke@google.com Add test executable API arg equivalents to typ 2020-09-14 fancl@chromium.org auto-triage: Fix None comments in issue If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1127899,chromium:816629 Tbr: zhanliang@google.com Change-Id: I9f8f03ee70ff76fade8fbd1c98d468fba2ba8c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411183Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807123}
-
Bo Liu authored
Set the background color on ContentViewRenderView according to the dark mode, ie set it to black if dark mode is enabled. Then also set the same background on the compositor which is the the part that actually appears to make a difference visually. This is meant to be merged back to 86. Bug: 1127873 Change-Id: Ifcb9fa47af1e578b963f3f47ba5dc2b8252b80b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412189 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#807122}
-
Christian Biesinger authored
Border and padding gets added at the end of the function. R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1083010 Change-Id: Iae51e87f93f8be2906690f888dde898763457bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412128 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#807121}
-
Min Qin authored
There are several issues with this download test: 1. The new download progress info bar will mess up with the duplicate infobar when trying to find the latter. 2. Download update may never go through DownloadManagerService in download's new code paths 3. Only 1 duplicate infobar will show at a time, so the AllowMultipleInfoBars test is no longer valid This CL fixes the above 3 issues. BUG=597230 Change-Id: I9cfbfcd51c040dc77bd4f6e0cb0f6bfaf967a912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411732Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807120}
-
edchin authored
* Moves feature flag file to //ios/chrome/browser/screen_time This was placed in the wrong place to begin with. This ensures that //ios/c/b does not depend on //ios/c/b/ui. Bug: 1123704 Change-Id: I103ad33fc14b56109249ee794c1e52a92f1a8a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393300 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#807119}
-
Evan Stade authored
This change uses the pre-existing GoogleAccountsCallback API to ask the embedder for the active user's email, and extends it to also be able to ask for full name and avatar. This allows WL to identify the active user and promote the associated contact info to the top of the list. If the active user's info is not in their own contacts, the email, name and avatar are used to synthesize contact info. Bug: 1016938 Change-Id: Ib2e6ce38761fc036b2657727775627186f0e7dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392578 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#807118}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/34f5ab82feae..c6dbc5ee8027 2020-09-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2c970cbe..5aa7e239 (806885:807011) 2020-09-15 philipp.hancke@googlemail.com objc: fix rollback 2020-09-15 hmaniar@nvidia.com Adding field trials to control additional quality scaler settings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I523e20f616668d0409d920a49c73e9bea8ad188a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412357Reviewed-by:
-
Elly Fong-Jones authored
The main change here is to remove most of the logic from Accept(). There was code in here to handle when Accept() was called with the accept button disabled, which is actually impossible*. This change also cleans up some other overrides of WidgetDelegate methods in BookmarkEditorView. *: This change also adds a DCHECK to guarantee that AcceptDialog() is never called with the accept button disabled. While this can't happen in production, a misguided test might reasonably call AcceptDialog() without first ensuring that the button is enabled, so enforce the invariant redundantly here. Bug: 1075649 Change-Id: Ib421da682ef3e8d8dc47be8b22d3339229d8068e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380255Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#807116}
-
Victor Fei authored
AXEventGenerator::Iterator iterates over the generated events in std::map<AXNode*, std::set<EventParams>> tree_events_. Often there could be entry with empty event sets (std::set<EventParams) in |tree_events_|, and if these empty event sets happen to be the first entry when we iterate over |tree_events_|, AXEventGenerator::Iterator ::operator++ would increment AXEventGenerator::Iterator::set_iter_ past its end, causing an exception. This CL fixes this issue by looping over |tree_events_| in AXEventGenerator::PostprocessEvents a second time to delete empty empty std::set<EventParams> entry; so AXEventGenerator::Iterator should only iterate over non-empty std::set<EventParams> entry. DCHECKs are also added in AXEventGenerator::Iterator to check the condition that only non-empty event sets remain. AX-Relnotes: n/a Bug: 1120281 Change-Id: I6c049be2cfb786c9777b4b840d598c77a8362e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410925Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#807115}
-
Koji Ishii authored
crbug.com/1111154 discovered that |getBoundingClientRect()| for culled inline has regressed a lot in LayoutNG. r793989 crrev.com/c/2332083 fixed this by traversing |LayoutObject| tree instead of fragments. This change, however, regressed a hit-testing performance case previously raised at crbug.com/1008523, because hit- testing uses |MoveToIncludingCulledInline| for every leaf, by limiting the search range to the containing line. This can easily lead to thousands of |MoveToIncludingCulledInline| for one hit-test request. This patch changes the function to revert the change if the search range is limited. In this case, most of |LayoutObject| descendants may not be in the search range, and that the searching fragments can be faster than searching |LayoutObject| descendants. Case A Case B Before r793989: 19 420 ToT: 2,556 9,064 This CL: 16 403 Numbers in milliseconds Case A: test attached to crbug/1008523 Case B: culled-inline-hittest.html in this CL Note, the design to call |MoveToIncludingCulledInline| so many times is questionable, but this CL does not try to change it to reduce the risk of regressions. Bug: 1127976, 1008523 Change-Id: Id21dd07cba0d0746b779b913ae9f180a77e23c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409734Reviewed-by:Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#807114}
-
Christopher Cameron authored
There are four places where we do basically the same thing, namely, find a profile (or profiles) to launch, and either launch or, if they are already open, focus them. They are - OnShimProcessConnected: When an app shim launches - OnShimOpenedFiles: When files are opened - OnShimSelectedProfile: When the profile menu selects a profile - OnShimReopen: Coming soon for the new x behavior Update OnShimOpenedFiles and OnShimSelectedProfile to use the new path. To enable this, break out a new sub-function LoadAndLaunchApp_TryExistingProfileStates from LoadAndLaunchApp. This function is used to short-circuit loading all profiles for an app, if the app is already open. Bug: 1080729 Change-Id: I314e4d0d80ae8e8b84f605fb16ff23c2680f8b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407976 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#807113}
-
Karandeep Bhatia authored
BUG=1113513 Change-Id: I70e687978361920419b834eb9b4c4cb2112cfc86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368290 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807112}
-
Yuke Liao authored
This reverts commit 48522640. Reason for revert: During the refactoring, 'os.listdir' was somehow accidentally changed to 'list', which resulted in the test failures, and this CL fixes the problem. Original change's description: > Revert "[lacros] Make test runner supports lacros_chrome_browsertests" > > This reverts commit e4eacd09. > > Reason for revert: Suspect for lacros test failures: > https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/2227 > The only lacros-related change in diff with the previous success run. > > Original change's description: > > [lacros] Make test runner supports lacros_chrome_browsertests > > > > This CL makes test runner supports lacros_chrome_browsertests by: > > 1. Appending necessary args to establish mojo connections. > > 2. Always use '--test-launcher-jobs=1' to run tests serially because > > multiple clients crosapis are still not supported yet. > > > > Bug: 1120582 > > Change-Id: I865ace26aa4a86c83912c6660bc433d79e43ef76 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410350 > > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > > Reviewed-by: Erik Chen <erikchen@chromium.org> > > Reviewed-by: Sven Zheng <svenzheng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#806903} > > TBR=erikchen@chromium.org,liaoyuke@chromium.org,svenzheng@chromium.org > > Change-Id: Ie630ade531428e78718127792c4f6ab6b0d55025 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1120582 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410246 > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Commit-Queue: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806980} TBR=erikchen@chromium.org,poromov@chromium.org,liaoyuke@chromium.org,svenzheng@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1120582 Change-Id: Ifaa2235a0a4f9ce8deb9aea5011eda0924e1f051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412253 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#807111}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/28ecfe40d6ae..8b1a5e7995a5 2020-09-15 sigurds@chromium.org Turn layout test into e2e test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110817 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9de1a652c2102a64fed1b6dca0a2d4a2213ec487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412352Reviewed-by:
-
Alex Newcomer authored
Bug: 1112441 Change-Id: If5ea1d536313885fde79f407346db8715789c6ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406681Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#807109}
-
Sebastien Lalancette authored
In a previous CL, I've added logic to disable the Edit and Move actions in the new Context Menus based on the enterprise policy's setting, but forgot about the new Delete action. Bookmarks' deletion is also controlled by this policy, so in this CL we'll be disabling that action as well, based on the policy. Bug: 1128028 Change-Id: I9f7cf4e8fa9e0889657d73a80ce1036d45d46511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410308 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807108}
-
Sven Zheng authored
This is a reland of ee48012a Previously cl got reverted because of crbug.com/1127103. Original change's description: > [lacros] LUCI config for chromeos-amd64-generic-lacros-dbg > > Adds CI bot for chromeos-amd64-generic-lacros-dbg. > Also changes chromeos_amd64-generic_lacros, > chromeos_amd64-generic_lacros_rel to use other pre-defined configs > and it should have no differences. > > Bug: 1121667 > Change-Id: I6405da5c9ec0464fed59effeadcb3758f18ce927 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398976 > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Commit-Queue: Sven Zheng <svenzheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805467} Bug: 1121667 Change-Id: I12a5a12adb16e9fa9181231f5a3d731c6bf32f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410612Reviewed-by:
-
Harkiran Bolaria authored
[bfcache] Update IPC hash setting functionality in mojo and add unit tests + browser test for IPC tracking to frames in cache Currently, IPC hash isn't set for tasks posted on the IO thread; adding IPC to SimpleWatcher when tasks are posted allows for the task posted on the IO thread to be annotated with an IPC hash, so that it can then be tracked in the histograms. ScopedSetIpcHash changes are to allow for tracking of IPCs posted from remote mojo objects. However, calculating the MD5 hash of a char* on every posted task is expensive, so we have also introduced storage of the IPC interface name. The IPC interface name can be used to calculate IPC hash on an as-needed basis (i.e. only in cases where IPC is posted to cached frames/documents). Also includes histogram testing to ensure metrics are recorded. and how ScopedSetIpcHash is set. Bug: 1110344 Change-Id: I26da160b65145f06639c33679ff03872f686e4af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345673 Commit-Queue: Harkiran Bolaria <hbolaria@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807106}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009150800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/7-Fyv71mIOgLZ5UT2rzvAWdbDHOekNFf1CVgl0mHSkkC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/155018433,b/166043485 Tbr: help-app@grotations.appspotmail.com Change-Id: I1181a02aa6df2a05136d3605a5c6bfd929835e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412284Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807105}
-
Jonathan Freed authored
This still works for dark mode, because the color used in the ic_settings_gear_24dp.xml file is adapative (@color/default_icon_color_secondary). Bug: b/166795933 Change-Id: Ia229e019701511ae39642eac4c28525d986212f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406720Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Jonathan Freed <freedjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#807104}
-
behdad authored
Tests skipped on android-pixel-2 and android-nexus-5x: blink_perf.bindings/worker-structured-clone-different-payloads.html blink_perf.owp_storage/idb-load-docs.html blink_perf.owp_storage/idb-put-all.html blink_perf.owp_storage/idb-put.html jetstream2/JetStream2 system_health.common_mobile/load:tools:dropbox:2019 system_health.memory_mobile/load:tools:dropbox:2019 Bug: 1128019 Change-Id: I1f86c29ea8cba6593f03a2498fc496f4ece404cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411649 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Auto-Submit: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#807103}
-
Mohamed Heikal authored
The androidx_test_espresso_espresso_contrib_java target depends on material design navigation classes. Doubledown material design no longer includes navigation classes since they are not used in chrome. Disable bytecode checks. Bug: 1110346 Change-Id: I90f7110ae60c8d84790009d36d6a49ba87cbf0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412135 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#807102}
-
David Bienvenu authored
This reverts commit 90fcdb0a. Reason for revert: <test failures, e.g.,components_unittests failing on builder "Cast Audio Linux> Original change's description: > [Signin] Add ConsentLevel to SetPrimaryAccount in test utils > > First part of adding ConsentLevel support to identity_test_utils. > This CL merges two separate methods SetPrimaryAccount and > SetUnconsentedPrimaryAccount into a single one that takes ConsentLevel > as a parameter. > > Bug: 1046746 > Change-Id: I93f7811414b7c1ee583237681c567a881560ce23 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401140 > Commit-Queue: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807046} TBR=droger@chromium.org,bsazonov@chromium.org Change-Id: If33b0579b09c4bccb5bb144f6299a4821d377269 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412615Reviewed-by:
David Bienvenu <davidbienvenu@google.com> Commit-Queue: David Bienvenu <davidbienvenu@google.com> Cr-Commit-Position: refs/heads/master@{#807101}
-
David Maunder authored
We now enforce that tab attributes cannot be acquired after Tab#destroy() has been called. This part of the code contains an invalid assumption that the tab is ininitialized when calling getUrlString(). Bug: 1117396 Change-Id: I54cc4feb317d302db04538cf006ac82cfaa7e730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410921Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#807100}
-
Jose Dapena Paz authored
GCC fails to compile system memory pressure evaluator, as the linux implementation is in linux namespace. But in GCC, linux is a reserved word, so it should not be used. To fix the problem, we rename the new namespace to os_linux. ../../base/util/memory_pressure/system_memory_pressure_evaluator_linux.h:16:11: error: expected identifier before numeric constant 16 | namespace linux { | ^~~~~ Bug: 819294 Change-Id: I3edcbbbb91fe99aab8c0be952385bb38bb1e27e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394158Reviewed-by:Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#807099}
-
Scott Violet authored
This patch changes the order of calls to the client when a Tab is destroyed. Prior to this patch the order was onTabDestroyed then onTabRemoved. This patch makes the order onTabRemoved() then onTabDestroyed(). The order was like this at one point, but without tests it regressed. This adds a test to ensure that doesn't happen again. Calling onTabDestroyed() first is problematic as it means client code can't call any methods on Tab as it's been destroyed, which is error prone and surprising. This also ensures calling Tab.destroy() removes the Tab from the internal map in the client library. This previously would not happen if Browser.destroyTab() was called. BUG=none TEST=covered by tests Change-Id: Ic3e38cee0eee70ef9b2cfced83deca71729fdd5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411161Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#807098}
-
Gayane Petrosyan authored
This is a reland of 644bba5a Original change's description: > [Shared Highlights] Connect selector generation in renderer to Android frontend. > > Connect selector generation in renderer to Android frontend using mojom > interfaces. > This CL add producer interface implemented in the renderer. > When user selects a text, in the renderer side along with saving the > selection frame and range, TextFragmentSelectorGenerator is registered > for the producer interface and bound when user chooses 'Link to Text'. > > See https://screenshot.googleplex.com/0kb39qFn6JP.png for user flow. > > Bug: 1102382 > Change-Id: I4152b07d3058d4109f3919f285b46b9b2dd82f3e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341662 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Gayane Petrosyan <gayane@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Gayane Petrosyan <gayane@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806875} Bug: 1102382 Change-Id: Ia1247e7f37c6270e5125bc3096b8fe9f49d2ec8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412130Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#807097}
-
Robbie McElrath authored
This CL fixes a mismatch between BuildConfigGenerator.groovy and //third_party/android_deps/BUILD.gn that was introduced in crrev.com/c/2406600. Bug: 1123216 Change-Id: I6c97fd7c6af52f904a4aef7182bea867cea54800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412254Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 86-4240.11-1599471529-benchmark-86.0.4240.36-r1 to 86-4240.27-1600081136-benchmark-86.0.4240.36-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I5b6d618d3a893f97c8b968cb8222fe1172ee5191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412363Reviewed-by:
-
Siye Liu authored
We should check whether |TSFBridge| is initialized before accessing it in |InputMethodWinTSF::OnWillChangeFocusedClient|. Bug: 1126159 Change-Id: If84b28007549c38e33ae947ac7d9dbec627a1ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399454Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#807094}
-
Paula Vidas authored
This is to work around race conditions, between one device enabling a data type (and marking it as "interesting") vs. another device committing some new data for the type. Bug: 1126014 Change-Id: I53cb8f8db17d0595a0ee2400fdc33a0299d0e1c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403640 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#807093}
-
Adrienne Walker authored
These are all separate but different unittests that have grown organically apart from each other, combine into a single typed test so that future file stream reader unittests can reuse this structure. The one unfortunate part about doing it this way is that it requires a lot more `this->` everywhere because of C++ templates. However, the alternative of having a test fixture with a bunch of switch statements for the different types seems strictly worse. Change-Id: Id56bc28391e1a640748691cb383a19291c47fc51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406718 Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#807092}
-
Dave Tapuska authored
Iteration of the frame tree happens inside blink now so we don't have to traverse render_frames_ in RenderWidget anymore. BUG=1097816 Change-Id: Ic5debdf482afaddd823d890cecdb52bf63e3b3e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406538 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#807091}
-
Etienne Pierre-doray authored
queue_time for Jobs is adjusted based on number of workers to put back pressure on Jobs that use many workers. This prioritizes newer work that uses less workers (or simple sequences). To achieve this, GetSortKey is extracted from Transaction and uses atomic load. This is safe since the result of GetSortKey and the queue itself is only modified under lock. Follow-up: consider integrating full TaskSourceSortKey in ShouldYield Change-Id: If26e00b40502b0a4e09f10e3627de8b7e4a52488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377893 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#807090}
-
Pavel Yatsuk authored
The current overlay warning message does not directly address the typical case: when dialer or chat bubble is displayed on the screen. One change in behavior is that "Cancel" button of overlay warning dialog dismisses both overlay warning and permission dialog. BUG=1127455 R=twellington@chromium.org Change-Id: I9d5c13a6c7d4e52a3fa73b3193d1ef463272ab64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406148Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#807089}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009150800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/tmWwsSISDU41lQ4kf4xfmJyf0_fQYQlzfq_1EKE6E5MC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/155134364,b/157694064,b/159851982,b/163418698,b/165421270,b/168262132,b/168423157,b/168428454,b/168428517,b/168433302,b/168455337,b/168560748 Tbr: media-app@grotations.appspotmail.com Change-Id: Ica1148a501956edc686ba700957b29ecd32af268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412282Reviewed-by:
-
manukh authored
This CL fixes a typo introduced in crrev.com/c/2324212 that would prevent the omnibox's width being updated in |LocationBarView::Layout()| if: - RichAutocompletionShowAdditionalText was enabled (default) - RichAutocompletionTwoLineOmnibox was disabled (default) - The omnibox was empty This resulted in - The hint 'Search Google or type a URL' when the omnibox is cleared and blurred or when on the NTP. - The cursor being misplaced when entering keyword mode which clears the user text. Bug: 1128094, 1062446 Change-Id: I073a9c75db1266d02a192675149211bad7615a8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410591Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#807087}
-
manukh authored
These histograms have not been used in a while and we don't expect to use them in the future. They were set to expire 9/19/2020. This CL removes the code logging this histograms and marks the histograms obsolete. Bug: 1037287 Change-Id: Ia0f277ab08e04d31de68b7b4681e18e0ccddcfab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398843Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
