GitLab

This CL corrects the counter values in the cases of allocation failure.

Review URL: https://codereview.chromium.org/710963002

git-svn-id: svn://svn.chromium.org/blink/trunk@185026 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=358074

Review URL: https://codereview.chromium.org/653283006

git-svn-id: svn://svn.chromium.org/blink/trunk@185025 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When the main thread passes a pointer of GarbageCollected object to a
HRTFDatabase thread (via postTask), the HRTFDatabase thread creates
a CrossThreadPersistent handle for the pointer. However, this is not
allowed because the HRTFDatabase thread is not attached to Oilpan.

We should attach the HRTFDatabase thread to Oilpan.

This CL removes MutexLocker from HRTFDatabase's destructor since we don't need to clear m_htrfDatabase in the destructor.

BUG=427303

Review URL: https://codereview.chromium.org/685153005

git-svn-id: svn://svn.chromium.org/blink/trunk@185024 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In the near future, Window.idl will be implemented as DOMWindow, not
LocalDOMWindow. Some of the custom Window bindings try to call
UsageCounter methods using Document as the reference, but DOMWindows
do not have a Document if they are remote.

BUG=425623

Review URL: https://codereview.chromium.org/707333003

git-svn-id: svn://svn.chromium.org/blink/trunk@185023 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Replaces ArrayBuffer with DOMArrayBuffer in core/ and modules/.

This CL is retry of http://crrev.com/708983002
Fixes Windows (64-bit) build.

BUG=235436

Review URL: https://codereview.chromium.org/711763002

git-svn-id: svn://svn.chromium.org/blink/trunk@185022 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=431643
TBR=senorblanco@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/710013002

git-svn-id: svn://svn.chromium.org/blink/trunk@185021 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These tests consistently pass (see bug), and the bug assigned
to them was closed long ago.

TBR=dpranke@chromium.org
BUG=237270
NOTRY=true

Review URL: https://codereview.chromium.org/716483002

git-svn-id: svn://svn.chromium.org/blink/trunk@185020 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These forward references are not needed anymore. After
this patch, core/rendering and core/painting has no unneeded
forward references any more.

This patch also move some forward declarations into correct
header files.

Review URL: https://codereview.chromium.org/713553002

git-svn-id: svn://svn.chromium.org/blink/trunk@185019 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Revert of Fix RemoteFrame detachment to signal its client. (patchset #1 id:1 of https://codereview.chromium.org/699053004/)

Reason for revert:
Reverting the revert. This turned out not to be the cause of https://code.google.com/p/chromium/issues/detail?id=431608

Original issue's description:
> Revert of Fix RemoteFrame detachment to signal its client. (patchset #1 id:1 of https://codereview.chromium.org/712653002/)
> 
> Reason for revert:
> Speculative revert to attempt to fix https://code.google.com/p/chromium/issues/detail?id=431608
> 
> Original issue's description:
> > Fix RemoteFrame detachment to signal its client.
> > 
> > We were seeing crashes in checkFrameCountConsistency() because during
> > RemoteFrame detachment the client was not getting signalled to modify
> > the frame tree, resulting in inconsistent state. This CL corrects that
> > problem.
> > 
> > BUG=430972
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184987
> 
> TBR=japhet@chromium.org,dcheng@chromium.org,kenrb@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=430972
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185015

TBR=japhet@chromium.org,dcheng@chromium.org,kenrb@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=430972

Review URL: https://codereview.chromium.org/709363002

git-svn-id: svn://svn.chromium.org/blink/trunk@185018 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After issue 409435 fixes, both text and image baselines should be
better optimized across blink ports.

BUG=409435, 405803
TBR=dstockwell@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/691943003

git-svn-id: svn://svn.chromium.org/blink/trunk@185017 bbb929c8-8fbe-4397-9dbb-9b2b20218538

select() API is already supported, test cover scenarios for email, number, date, datetime-local, color and file.

While support for selection API does not exists.

BUG=415391
R=tkent, keishi

Review URL: https://codereview.chromium.org/707853002

git-svn-id: svn://svn.chromium.org/blink/trunk@185016 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Fix RemoteFrame detachment to signal its client. (patchset #1 id:1 of https://codereview.chromium.org/712653002/)

Reason for revert:
Speculative revert to attempt to fix https://code.google.com/p/chromium/issues/detail?id=431608

Original issue's description:
> Fix RemoteFrame detachment to signal its client.
> 
> We were seeing crashes in checkFrameCountConsistency() because during
> RemoteFrame detachment the client was not getting signalled to modify
> the frame tree, resulting in inconsistent state. This CL corrects that
> problem.
> 
> BUG=430972
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184987

TBR=japhet@chromium.org,dcheng@chromium.org,kenrb@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=430972

Review URL: https://codereview.chromium.org/699053004

git-svn-id: svn://svn.chromium.org/blink/trunk@185015 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is in preparation for changing Window.idl ImplementedAs to
DOMWindow. These should be the remainder of the methods needed by V8
bindings.

BUG=425623

Review URL: https://codereview.chromium.org/710873003

git-svn-id: svn://svn.chromium.org/blink/trunk@185013 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The reason of that is a difference in URL for TempStorageSharedWorker between the host and the device front-ends
If DevTools window for a host page was opened before DevTools window for a device then the second DevTools
window will fail to run the shared worker and vice versa.

BUG=430794

Review URL: https://codereview.chromium.org/712593002

git-svn-id: svn://svn.chromium.org/blink/trunk@185012 bbb929c8-8fbe-4397-9dbb-9b2b20218538

original search implementation had no idea about flame chart and did search only for data grid nodes.

Also there was a single search box for both types, cpu and heap.

Two separate search view were introduced in the patch.
One for cpu view, the other for heap view.

New code for search in flame chart was written.

Original code for search in cpu data grid was moved to CPUProfileDataGrid.

HeapSnapshot search implementation was slightly tweaked.

BUG=425928

Review URL: https://codereview.chromium.org/696703003

git-svn-id: svn://svn.chromium.org/blink/trunk@185011 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As getPropertyCSSValue is no longer web-exposed we shouldn't require it
in tests so we can delete the interface.

BUG=428595

Review URL: https://codereview.chromium.org/705373004

git-svn-id: svn://svn.chromium.org/blink/trunk@185010 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/bka_hQuzAu0/tjD-GhJ6zDAJ

Attribute::setPrefix() was unused and showed up in grep.

BUG=431552

Review URL: https://codereview.chromium.org/688333002

git-svn-id: svn://svn.chromium.org/blink/trunk@185009 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This will be necessary once Push events support event.waitUntil to keep the
Service Worker alive until the Promise is resolved
(https://github.com/w3c/push-api/issues/85).

Depends on Chromium https://codereview.chromium.org/708913003
Required by Chromium https://codereview.chromium.org/707243003

BUG=430888, 401438

Review URL: https://codereview.chromium.org/709103002

git-svn-id: svn://svn.chromium.org/blink/trunk@185008 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The referenced bug is caused by a composited descendant that has an opacity
animation not having the correct background painted for its ancestor that it needs
to blend with.

However, HasOwnBackingButPaintsIntoAncestor is also just an optimization to reduce
the number of composited layers that draw content, in cases where we think we can
get away with it. (e.g. only existing to pass along preserves-3d state).

In exchange for these optimizations, the feature introduces significant complexity,
and has caused a number of bugs. Let's just kill it.

BUG=418521

Review URL: https://codereview.chromium.org/708213002

git-svn-id: svn://svn.chromium.org/blink/trunk@185007 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Creating container class for nullable union types would generate a lot of
duplications. Suppose we have (A or B) and (A or B)?. The current
implementation will generate two classes: AOrB and AOrBOrNull.
The only difference between them is whether toImpl() checks
isUndefinedOrNull() at first. To avoid duplication, this CL generates
toImpl() only for nullable union types.

This CL includes part of Jens' work[1]

[1] https://codereview.chromium.org/700093002/

BUG=240176

Review URL: https://codereview.chromium.org/698423002

git-svn-id: svn://svn.chromium.org/blink/trunk@185005 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews,haraken
BUG=430507
NOTRY=true

Review URL: https://codereview.chromium.org/709893002

git-svn-id: svn://svn.chromium.org/blink/trunk@185004 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch begins the parser portion of the CSS parser rewrite. To avoid
making a copy of the CSSPropertyParser, we temporarily add a conversion
from the new CSSParserTokens to CSSParserValues. Note the runtime flag
is not marked as test/experimental, so this code is not yet being run.

This patch passes all tests except CSSPropertyParserTest.GridTrackLimits
and fast/css-grid-layout/named-grid-line-get-set.html, which will be
fixed in a later patch. The former fails due to bad handling of large
numbers in the new tokenizer, and the latter fails as the Bison CSS
parser is a bit more restrictive in handling brackets.

BUG=330389

Review URL: https://codereview.chromium.org/647483009

git-svn-id: svn://svn.chromium.org/blink/trunk@185003 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It looks like this test needs to be rebaselined after the changes in
https://crrev.com/303364 are fully implemented.

BUG=384723
TBR=yhirano@chromium.org

Review URL: https://codereview.chromium.org/708103003

git-svn-id: svn://svn.chromium.org/blink/trunk@185002 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL will be followed by chromium side CL which will expose Ruby tag.

BUG=426893

Review URL: https://codereview.chromium.org/710663002

git-svn-id: svn://svn.chromium.org/blink/trunk@185001 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Fix Runtime.executionContextCreated for crafted iframes. (patchset #6 id:100001 of https://codereview.chromium.org/686763002/)

Reason for revert:
Speculatively reverting to fix telemetry_unittests failures.

Original issue's description:
> Fix Runtime.executionContextCreated for crafted iframes.
> 
> BUG=331407
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184995

TBR=vsevik@chromium.org,yurys@chromium.org,sergeyv@chromium.org,aandrey@chromium.org,eustas@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=331407

Review URL: https://codereview.chromium.org/711853002

git-svn-id: svn://svn.chromium.org/blink/trunk@184999 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As getPropertyCSSValue is no longer web-exposed we shouldn't require it
in tests so we can delete the interface.

BUG=428595

Review URL: https://codereview.chromium.org/713613002

git-svn-id: svn://svn.chromium.org/blink/trunk@184998 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As getPropertyCSSValue is no longer web-exposed we should stop testing
it so we can delete the interface.

BUG=428595

Review URL: https://codereview.chromium.org/709193003

git-svn-id: svn://svn.chromium.org/blink/trunk@184997 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=402536

Review URL: https://codereview.chromium.org/709803003

git-svn-id: svn://svn.chromium.org/blink/trunk@184996 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=331407

Review URL: https://codereview.chromium.org/686763002

git-svn-id: svn://svn.chromium.org/blink/trunk@184995 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Android has a feature where if you have headphones plugged in, the screen
reader speaks the password text as you type it. Without headphones, it says
"dot dot dot". To implement this we need to get the password out of Blink.

BUG=399043

Review URL: https://codereview.chromium.org/704363004

git-svn-id: svn://svn.chromium.org/blink/trunk@184994 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this patch the content property parsing did
not allow comma separated values but did use comma
separated value lists for serialization. This patch changes
that behavior to always use space separated lists and
adds a test to make sure roundtripping content works.

BUG=428445

Review URL: https://codereview.chromium.org/707923003

git-svn-id: svn://svn.chromium.org/blink/trunk@184993 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Adding Element.closest() API (patchset #1 id:1 of https://codereview.chromium.org/704733002/)

Reason for revert:
Merged patch from WebKit contains errors.

Original issue's description:
> Adding Element.closest() API
> 
> Implementing Element.closest() API according to specs
> https://dom.spec.whatwg.org/#dom-element-closest
> 
> This API will parse selectors and if fails then throw SyntaxError
> else return closest ancestor that matches selectors
> if there is no ancestor that matches selectors, it will
> return nullptr.
> 
> Blink-Dev Intent to Implement and ship Link :
> https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/yk_Fo6hyvb8
> 
> WebKit Change: http://trac.webkit.org/changeset/174324
> 
> BUG=422731
> R=habib.virji@samsung.com
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184946

TBR=habib.virji@samsung.com,rune@opera.com,l.gombos@samsung.com,paritosh.in@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=422731

Review URL: https://codereview.chromium.org/693203004

git-svn-id: svn://svn.chromium.org/blink/trunk@184992 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=apavlov

Review URL: https://codereview.chromium.org/688513004

git-svn-id: svn://svn.chromium.org/blink/trunk@184991 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=424500

Review URL: https://codereview.chromium.org/706313002

git-svn-id: svn://svn.chromium.org/blink/trunk@184990 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* Don't proxy history navigations through the main frame, there's no need
* Have Source/core interact with history state entirely through FrameLoaderClient. It doesn't need to know that FrameLoaderClientImpl is actually talking to WebViewClient (though that will need to change eventually)
* Remove NavigationScheduler::scheduleHistoryNavigation. History navigations are always asynchronous anyway, since they need to talk to the browser process.

BUG=

Review URL: https://codereview.chromium.org/669013002

git-svn-id: svn://svn.chromium.org/blink/trunk@184989 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As getPropertyCSSValue is no longer web-exposed, we should stop testing
it so we can delete the interface. Instead of using getPropertyCSSValue
and calling cssText on the returned value, we can use getPropertyValue
or the direct accessors.

BUG=428595

Review URL: https://codereview.chromium.org/703323002

git-svn-id: svn://svn.chromium.org/blink/trunk@184988 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We were seeing crashes in checkFrameCountConsistency() because during
RemoteFrame detachment the client was not getting signalled to modify
the frame tree, resulting in inconsistent state. This CL corrects that
problem.

BUG=430972

Review URL: https://codereview.chromium.org/712653002

git-svn-id: svn://svn.chromium.org/blink/trunk@184987 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Triggering custom scrollbar style update and adjusting the scrollbar
rect(this process is done during style recalc).This shall solve other
issues of custom scrollbar during page scale. As when the page is 
scaled the style is recalculated, if the thickness is changed then
owning renderer is set for childneedslayout. This layout shall
happen after style recalc is done, which avoids a re-layout of 
scrollbar while updating scrollbar geometry.

For brief explanation on custom-scrollbar behaviour/issues please check
https://codereview.chromium.org/503583002/#msg46

BUG=430519,406676,390895,375200,424925

Review URL: https://codereview.chromium.org/702913002

git-svn-id: svn://svn.chromium.org/blink/trunk@184986 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This can happen when an onbeforeunload listener calls window.close().

Have a re-entrant invocation pretend that the user blocked the navigation, so
that we can consistently obey the user's intent on the original invocation.

BUG=430507
TEST=http/tests/misc/reentrant-beforeunload.html

Review URL: https://codereview.chromium.org/703383002

git-svn-id: svn://svn.chromium.org/blink/trunk@184985 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When an allocation with the PartitionAllocReturnNull flag fails, we need to
make sure to leave all structures in a valid state when bailing out, since
the process lives on and may call again later.

Specifically, make sure that the bucket's activePagesHead has a valid value,
instead of null, when returning null from partitionAllocSlowPath(). Since
there's no meaningful page to set as the active pages head, set it to its
initial value, &PartitionRootBase::gSeedPage.

This was already necessarily supported by the allocation code paths. The
deallocation code path needs some minor adjustments to handle this state
correctly.

Review URL: https://codereview.chromium.org/645223007

git-svn-id: svn://svn.chromium.org/blink/trunk@184983 bbb929c8-8fbe-4397-9dbb-9b2b20218538