- 07 Feb, 2020 40 commits
-
-
Olivier Robin authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios.git/+log/35aac79c34be..866cee927378 $ git log 35aac79c3..866cee927 --date=short --no-merges --format='%ad %ae %s' 2020-02-06 featherless [FlexibleHeader] Add missing nullability annotation. 2020-02-06 featherless [ButtonBar] Rolling back "Assign the UIBarButtonItem's tintColor to the button's text color." 2020-02-06 featherless [ButtonBar] Assign the UIBarButtonItem's tintColor to the button's text color. 2020-02-06 featherless [ButtonBar] Refactor title color logic to a single location. 2020-02-06 rockland [NavigationDrawer][A11y] Improve behavior when navigating the bottom drawer with Voice Over. This change makes it possible to navigate back and forth between the `headerViewController` and `contentViewController`, without VO getting stuck, by making the view hierarchy's `accessibilityElements` explicit. 2020-02-05 rockland [NavigationDrawer] Improve swipe-down-to-dismiss behavior for drawers where drawer content is less than `160`. This adjustment ensures that for drawer contents that are quite small (ex. 100pt) the drawer contents to not become undismissable. Without this adjustment it is nearly impossible to achieve a scroll offset of (40pt), the current `kVerticalDistanceDismissalThreshold`, making the drawer effectively undismissable. 2020-02-05 codyleeweaver [ActionSheet] Change default header to be 8pt tall instead of 0. 2020-02-05 andrewoverton This change makes rippleColor null_resettable on MDCBaseCell 2020-02-05 andrewoverton Make padding between title label and detail label smaller 2020-02-04 no-reply internal change 2020-02-04 featherless [ButtonBar] Use CGSizeZero instead of CGSizeMake(0, 0). 2020-02-04 featherless [ButtonBar] Add snapshot tests for title color behavior. 2020-02-04 andrewoverton Reevaluate RTL logic because of internal snapshot testing infrastructure 2020-02-04 andrewoverton Remove unwanted animations from filled style. 2020-02-04 andrewoverton Invalidate intrinsic content size in MDCBaseTextField 2020-02-04 featherless [FlexibleHeader] Add hairline support. 2020-02-03 no-reply Adds availability macro for conditionally compiling OS sensitive code. 2020-02-03 galiak [Dialogs] Adding scuba tests for long, short, text and outlined actions in vertical and horizontal layout, in LTR and RTL. Created with: roll-dep src/ios/third_party/material_components_ios/src Change-Id: I8564f2baa2bc5fc077e0b55af7595e32a7ee74c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044090 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#739420}
-
David Maunder authored
histograms.xml and the code in TabSuggestionsOrchestrator Bug: 1043425 Change-Id: Ic3f65e303ffcdbe1a755bca664e976f9ca54117c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040675Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#739419}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bcd98820a91c..139aa7c89450 git log bcd98820a91c..139aa7c89450 --date=short --first-parent --format='%ad %ae %s' 2020-02-07 rsavitski@google.com Merge "traced_perf: add callstack trie, allow it to be purged manually" 2020-02-07 rsavitski@google.com Merge "profiling: factor callstack trie out into p/common/" Created with: gclient setdep -r src/third_party/perfetto@139aa7c89450 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7891524684d1dc1ec1afe6563976b6797be6a95f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043918Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739418}
-
Volodymyr Riazantsev authored
Images rendering is unnecessary in Cast for Audio only configuration. So let's disable them from rendering. Change-Id: Ibd6e0d20c8c6e2473b29fef5cae0cc18128b7599 Signed-off-by:
Volodymyr Riazantsev <riazantsevv@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042765Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#739417}
-
Ali Juma authored
EG2 tests that call triggerRestoreViaTabGridRemoveAllUndo are flaking because sometimes when they try to tap on the close-all-tabs button, EG2 doesn't think that button is visible. This CL follows the approach used in showTabSwitcher, waiting up to 2 seconds for the button to be visible. This CL also uses this approach for the other button taps in triggerRestoreViaTabGridRemoveAllUndo, since these are otherwise likely to become the next sources of flake. Bug: 1048875 Change-Id: Iad92c6e784a27fc1918eff6e8cd6baa313566c50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042541 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#739416}
-
Harald Alvestrand authored
Bug: chromium:1049995 Change-Id: I228a8acb412dd9543f78b91989809e2dc4d21d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043792Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#739415}
-
Xiaocheng Hu authored
This patch plumbs CSSParserContext into ConsumePercent() and ConsumeColor(), so that we can count usage of CSS comparison functions min/max/clamp when they are used in <percent> and <color> values. There are two types of code paths, which are handled differently: 1. A caller takes the CSSParserMode from a CSSParserContext, and passes it through. We change it to pass the CSSParserContext directly. 2. A caller has a CSSParserContext, but passes a possibly different CSSParserMode. We change it to temporarily override the CSSParserMode of the current context. Bug: 1047784 Change-Id: I846ff87f66b444fbcb95f412cdc85d278b2dc5a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036934 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#739414}
-
Xiaocheng Hu authored
This patch plumbs CSSParserContext into ConsumeLength(), so that we can count usage of CSS comparison functions min/max/clamp when they are used in <length> values. There are three types of code paths, which are handled differently: 1. A caller takes the CSSParserMode from a CSSParserContext, and passes it through. We change it to pass the CSSParserContext directly. 2. A caller has a CSSParserContext, but passes a possibly different CSSParserMode. We change it to temporarily override the CSSParserMode of the current context. 3. A caller doesn't necessarily has a CSSParserContext, and passes a CSSParserMode. We change it to pass a fake CSSParserContext with the CSSParserMode but without any document, so that it can still parse. Use counter doesn't work for it yet. Bug: 1047784 Change-Id: Ieeb83063f0a8b0a2d33f8f5e8bf181a21bc75356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033980 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#739413}
-
Colin Blundell authored
This CL componentizes ChromeMetricsHelper and renames it to ContentMetricsHelper, as it is now specific only to //content embedders that use //components/security_interstitials, rather than being specific to //chrome as it was previously. The motivation is to reuse this class in WebLayer (which will happen in an upcoming CL). Bug: 812808, 1030692 Change-Id: I48e533fe7d56bba84bf16c877148aa98a5779ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041625 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#739412}
-
Jan Wilken Dörrie authored
This change adds an UI flag for the Bulk Password Check feature on Desktop. Bug: 1049177 Change-Id: I5ffc4ab33ade02b1a3a9b5181770704e4d3e2af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043834Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#739411}
-
https://crrev.com/c/2037386Matt Falkenhagen authored
The Timeouts look inaccurate, the tests are passing according to the Flakiness Dashboard. The non-Mac 10.10 failures for http2-context were accurate, keep them and make them for all platforms. Bug: 1049875 Change-Id: Iebcd4b01b8ea28eeb6e6760c17eb50268d992cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041689 Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#739410}
-
Istiaque Ahmed authored
This changes ContentVerifier::ShouldVerifyAnyPath to work with relative paths, instead of constructing full paths. This should help in using "canonical" paths in content verifier code. "canonical" paths shouldn't be used as full paths as it isn't safe to to do so on windows. Canonicalization lowercases paths on windows, but for full paths with drive letters, that doesn't seem immediately right. So this CL just make the code in question work with relative paths, which shouldn't need to worry about these caveats. Also, fullpath length is strictly larger than relative path, this gives marginal win. Bug: 796395 Test: No behavior changes expected. Change-Id: I924768805a61726f04ab4c1d64880fb326d8bf47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035497Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#739409}
-
Xiaocheng Hu authored
This patch plumbs CSSParserContext into ConsumeLengthOrPercent(), so that we can count usage of CSS comparison functions min/max/clamp when they are used in <length-percentage> values. There are three types of code paths, which are handled differently: 1. A caller takes the CSSParserMode from a CSSParserContext, and passes it through. We change it to pass the CSSParserContext directly. 2. A caller has a CSSParserContext, but passes a possibly different CSSParserMode. We change it to temporarily override the CSSParserMode of the current context. 3. A caller doesn't necessarily has a CSSParserContext, and passes a CSSParserMode. We change it to pass a newly created CSSParserContext with the underlying document and the CSSParserMode. Bug: 1047784 Change-Id: Iabc5bff859ff2dc302ee2eb9f0b3398f5a1952be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033892Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#739408}
-
Mingjing Zhang authored
This is a reland of 835cde27 that was previously reverted due to crbug/1048145. Now LocalMidnight() is not called on the last report time if the latter was too long ago. This prevents crbug/1048145 where LocalMidnight() may behave unexpectedly for certain regions that historically observed a different local time from their modern timezone. Original change's description: > Add DomainDiversityReporter for domain diversity metrics > > This CL adds DomainDiversityReporter to schedule domain metrics > computation tasks and emit histograms. The reporting task is > executed shortly after startup and then scheduled once per 24 > hours thereafter. > > Bug: 1015424 > Change-Id: Id4b8043c1a9b9ea0ee70d4be68e9c35017a82de1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864522 > Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735713} Bug: 1015424 Change-Id: I364f5a5b136d3816daa8e4d2e3d0496c58e80788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040375Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#739407}
-
Fredrik Söderquist authored
The button says "START REVIEW" these days. Change-Id: Ia285ce8b0b7f8d6698f31e070c60e99f8ffacb8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043814 Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#739406}
-
Finnur Thorarinsson authored
Bug: 1050039 Change-Id: I0b69b666603abd3413ce9e69185d3961a045b942 TBR: mmentovai Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044271Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#739405}
-
Alex Khouderchah authored
Currently, StaticIPConfig settings will be removed entirely if neither of {IPAddress,NameServers}ConfigType is 'Static'. This change causes fields not affected by either of these settings (i.e., not IPAddress, RoutingPrefix, Gateway, or NameServers) to be retained regardless of the {IPAddress,NameServers}ConfigType configuration. Bug: 1048714 Change-Id: Ie3e099bbee9c56788112e6b57b355f998f6ba453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042274 Commit-Queue: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#739404}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/77fdf66946d2..87e3bef6f82f git log 77fdf66946d2..87e3bef6f82f --date=short --first-parent --format='%ad %ae %s' 2020-02-07 brianosman@google.com Reland "Switch runtime SkSL to always sample at explicit coords" 2020-02-07 brianosman@google.com Roll libgifcodec Created with: gclient setdep -r src/third_party/skia@87e3bef6f82f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: I468b5ad1978ce480e633a704a743cba3476ee145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043927Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739403}
-
Omer Katz authored
HeapObjectHeader is poisoned by default. Accesses to its half-words required unpoisoning and repoisoninig. However, repoisoning introduces races between markers. Adding a lock to prevent races will cause serialization (thus missing non-asan-related issues) and will diverge allocation granularity of asan builds from all other builds. Instead, we unpoison the HeapObjectHeader when we first try to access it (usually when we first try to mark it) and leave it unpoisoned for the duration of GC. Sweeping repoisons HeapObjectHeaders for all live objects. This CL: 1) Resolving asan poisoning races in HeapObjectHeader. 2) Adds parenthesis around macro in ifs in heap_page.cc (macro could expand to more than a single line). 3) Removes unused Mark() method (replaced in tests with TryMark). Bug: 986235 Change-Id: I3c574a5e4010671706951a26266c53a0f80d6394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041664 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#739402}
-
Patrick Monette authored
This is a reland of dec0aa0b To make it easier to reland, this CL now only adds the worker nodes to the PM graph but does not set the connection to its client frame. Original change's description: > [PM] Add support for dedicated workers > > The WorkerWatcher observes dedicated workers through the > DedicatedWorkerService interface. > > Change-Id: If62d911e500def7ebb905311485a8d89eeaca8df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992208 > Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736411} Change-Id: I7d11799402eb7871e5b8dcbb1b682996eaf12b6f Bug: 993029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037498Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#739401}
-
Alex Chau authored
- SharingUseDeviceInfo will be extracted to a separate experiment Bug: 1046572 Change-Id: I32b123923df718ec57053ca0b817d8494e2f9ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041760 Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Alex Chau <alexchau@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#739400}
-
Yuki Shiino authored
Stops using |alloca| in FlexibleArrayBufferView and use a simple uint8_t array instead. Also renames FlexibleInt32ArrayView to FlexibleInt32Array and so on so that the names match the standard names defined in Web IDL. Bug: 839389 Change-Id: Ia3e0614bb38fef4ca3a6c1ca3cf2a34b8b657abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043613 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#739399}
-
Armando Miraglia authored
Internally, the Audio Processing Module (APM) needs to treat both Auto Gain Control (AGC) settings as they were one since the implementation does allow to configure different types of AGCs, but rather a single "best possible" AGC. For this reason, this CL merges the two constraints to generate a single AGC setting. The behavior might break applications only when these two conditions are meat: a) both constraints are provided as required, and b) they contradict each other. A followup CL will take care of entirely removing the internal property "goog_experimental_auto_gain_control" when APM does not rely on it any longer. Bug: 924485 Change-Id: I280dff85870e0ce8cf557265f22ec98b6cf0acfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041758Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#739398}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/95c414ffee64..ae59435606fc git log 95c414ffee64..ae59435606fc --date=short --first-parent --format='%ad %ae %s' 2020-02-07 johnkslang@users.noreply.github.com Merge pull request #2081 from kainino0x/split-emscripten-from-glslang.js Created with: gclient setdep -r src/third_party/glslang/src@ae59435606fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: I2b3c5745481aa87678e76ec08df44a3df1a56f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043916Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739397}
-
Gyuyoung Kim authored
This CL migrates the legacy SetPermission IPC message to the new Mojo defined in WebTestClient interface. Bug: 1039247 Change-Id: If6534315b0d1c66dea500c29a17f3ff2d515634d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037178 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#739396}
-
Hans Wennborg authored
This reduces the pre-processed size of the header from 874,775 to 732,443 tokens (linux debug builds), bringing it back down to the size of last October (crrev.com/706388), and shaving 10 CPU minutes off local builds. It also adds a #pragma clang max_tokens_here line to prevent the size from regressing without anyone noticing. See the bug and docs linked from it for more info. Bug: 1049569 TBR=palmer for browser_interface_binders.cc Change-Id: Ia5c16982a0d914d2a1ee6d7c387206d0448d2d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035984 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#739395}
-
Elly Fong-Jones authored
Right now, PermissionRequestManager requires that the PermissionPrompt not call any of the PermissionPrompt::Delegate methods if the PermissionPrompt is being destroyed by the PermissionRequestManager itself. This mainly happens when the user switches tabs, in which case the PRM wants to destroy the bubble but not treat the permission request as handled yet. This CL changes the contract of the PermissionPrompt: now the PermissionPrompt always calls the notification methods on PermissionPrompt::Delegate, and it is up to the PRM to ignore these callbacks if they are not relevant. This centralizes knowledge of this PRM behavior in a single place (PRM itself) and simplifies PermissionPromptBubbleView. Bug: 1011446 Change-Id: Ie023ca572848e26f63cb9287ee216dd738f32473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039730Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#739394}
-
Wez authored
TBR=kmarshall Bug: 1050049, 973095 Change-Id: I71047a5f70b395cf78e9e8b7432b52b39a1f1e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044096Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#739393}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/dd48b7e2d06e..693b8a8d95e3 git log dd48b7e2d06e..693b8a8d95e3 --date=short --first-parent --format='%ad %ae %s' 2020-02-07 bclayton@google.com vscode: Add third_party/benchmark to include dirs Created with: gclient setdep -r src/third_party/swiftshader@693b8a8d95e3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I36bd3a442b9d2231570de002490726c8cf0c440b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043914Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739392}
-
Dominik Röttsches authored
The previous change [1] to always apply opsz to Mac system fonts did not handle a situation in which loading a system font comes back with a null result. Cover this case for the base typeface as well as for the case where instantiating the variable font fails. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2020767 Bug: 1049391 Change-Id: I2aad15c31f7ad793abc389f66afab3fbdf963df7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041667Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#739391}
-
Sam Maier authored
The upstream SDK is now being permanently used as our tools directory. Bug: 1049245 Change-Id: Idffe05b5c10e8d4a468bb2a663b3d438fb63e2b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040113Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#739390}
-
Egor Pasko authored
Discard CachedMetadata from ScriptCachedMetadataHandler after it has been 'consumed': deserialized into objects on v8 heap. This is done behind a base::Feature to allow experimentation. Also record a histogram every time GetCachedMetadata() is called. Reports the extracts of the history of the corresponding member: * present * had never been present * was present but then got discarded As a side effect discarding also ignores subsequent SetCachedMetadata(). This is mostly a precaution against unintentional memory usage and unnecessary disk writes in the future. We expect reuse-after-discard should happen rarely enough not to affect performance (the experiment should prove that). Resetting the CachedMetadata should be even less frequent because in order to reset, the callers must check whether the CachedMetadata exists. The main changes are in: * script_cached_metadata_handler.cc (the new state of being discarded, recording the histogram) * v8_script_runner.cc (asking to discard) Bug: 1045052 Change-Id: I983e1dee913a2816368fc16c92d6b6e6c44c9e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022649 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#739389}
-
Alexandre Courbot authored
The V4L2 device members are currently accessed in the GL/EGL image creation method, which runs on the child thread. But these members belong to the decoder thread and are not thread-safe. Fix this by passing the device used to create the GL/EGL image to the creation method. That way the member is accessed from the decoder thread, and the only thing that happens in the child thread is the call to V4L2Device::Create(E)GLImage, which is supposed to take place there. BUG=None TEST=video.Seek.switch_vp8 passing on Kevin. TEST=video.Seek.switch_vp8 passing on Hana. TEST=video.Seek.switch_h264 passing on Krane. Change-Id: Ie94745c1215989db77e85896ac1fda69cf43a080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026853 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#739388}
-
Oleg Davydov authored
ContentVerifyJob has ability to inject test observer, but before this CL the observer is accessed from different threads, leading to flaky crashes in tests. See https://crrev.com/c/2032998. Now this observer (ContentVerifyJob::TestObserver and pointer to it from g_test_content_verify_gob_observer in content_verify_job.cc) supports thread-safe refcounted pointing, therefore is not destroyed too early. Also it's wrappend into lazy initialized since we need access to it be no-op outside of the tests. Bug: 796395, 958794 Change-Id: I7479216f23083d4fd41dae08cb2e7acb62da0abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033159Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#739387}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/716a808922fb..27380a85d035 Created with: gclient setdep -r src-internal@27380a85d035 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1049079 Tbr: jbudorick@google.com Change-Id: I5c35c4b6a7ecf7620ec80156e5a6fa9edc9b2caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043912Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739386}
-
Fan Yang authored
https://quiche.googlesource.com/quiche.git/+log/5f20251f863498d..d96ecdaaf35ed 2020-02-03 fayang Deprecate gfe2_reloadable_flag_quic_use_handshaker_delegate2. Change-Id: Ibe7d590d32717317f0600fa4029ff5a495f3fa2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042310Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#739385}
-
Istiaque Ahmed authored
This CL partially reverts I1bc55cd5da2cc106e8d74dba172122d2bf943d31 that added support for setIcon from Extension Service workers. This is because setIcon doesn't work for svg images. This CL also disables the relevant tests (*/BrowserActionApiLazyTest.Update with Service workers.) Bug: 1049214 Test: browser_tests -f *BrowserActionApiLazyTest*:*NavigatingExtensionPopupBrowserTest*:*BrowserActionApiCanvasTest* Change-Id: Ie3e755c198477b72d27935a54d934bd86dc79c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042142 Auto-Submit: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#739384}
-
Sam Maier authored
This roll is part one of enabling class merging. The next step would be to actually use it with build rules. Bug: 1040534 Change-Id: Ife82863d74267c44a10bee4d0f427b937ae197ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033752 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#739383}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f3560b680e35..77fdf66946d2 git log f3560b680e35..77fdf66946d2 --date=short --first-parent --format='%ad %ae %s' 2020-02-07 enga@google.com Revert "Cleanup program building a bit" Created with: gclient setdep -r src/third_party/skia@77fdf66946d2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: I3228d1c9c233965f6d9ae9b23e6162330cc19219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043921Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739382}
-
Bo Liu authored
Also remove ericrk who has unfortunately left the chromium project. Change-Id: I7184d88d6cec1c264760d2c01e1301913d43c399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042289 Auto-Submit: Bo <boliu@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#739381}
-