- 25 Sep, 2019 40 commits
-
-
John Chen authored
ChromeDriver was passing --ignore-certificate-errors switch to Chrome, regardless of whether user wants to ignore certificate errors or not. Fixing by stop passing this flag to Chrome, and relying on using Security.setIgnoreCertificateErrors command when user wants to ignore certificate errors. Bug: chromedriver:3148 Change-Id: I5e8493f4cca48ebaeb211c95cd7fd645891c8659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824005Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#699890}
-
Lei Zhang authored
Add bool ReadAndCheck() as a wrapper around int Read() that returns true if and only if the specified amount of data got read. Similarly, add wrappers for ReadAtCurrentPos(), Write(), and WriteAtCurrentPos(). Make use of these wrapper methods in a few places to show how they can make code more robust or more foolproof. Fix nits and lint errors along the way. Change-Id: I956550708eeecee543b2e9b0948ea20de5308b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775233Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#699889}
-
Mark Pearson authored
Correct mis-rendered links and clean up the grammar slightly. Change-Id: I5bbb8af18f40713957625805ae4757a657469d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823800 Auto-Submit: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#699888}
-
Daniel Clark authored
Per https://w3c.github.io/html-aam/#el-mark, update the LocalizedControlType of <mark> from "text" to "highlight". Bug: 996459 Change-Id: I5f435988e16663df295cd195f3de6d97aab0dd70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762581 Commit-Queue: Dan Clark <daniec@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699887}
-
Kurt Horimoto authored
This eliminates the boilerplate code of UIViewController setup in the coordinator, as well as the delegate and datasource capabilities provided to the mediator. Moving to use AlertOverlayCoordinator also converts JS dialogs to use child UIViewControllers, fixing some other issues resulting from the asynchronous nature of UIViewController presentation. Bug: 990070, 979030, 999960, 999962 Change-Id: I6c2465e5bc501540d9b16b60add61045e96ed963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809061 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#699886}
-
Christopher Cameron authored
Make ExtensionAppShimHandler be an AvatarMenuObserver (making it very similar to the existing ProfileMenuControllerInternal::Observer). Package up the profile list into mojo, and send it to AppShimController, where it is un-packed and displayed. Add a mojo method to communicate menu item selection back to the AppShimHost in the browser process. Note that this implementation is not complete yet. - The UI design is that profiles for which the app is not installed should not be included in the menu (left as a TODO) - Selection reaches ExtensionAppShimHandler::OnShimSelectedProfile, which just opens a new app instance -- it will need to load profiles or focus existing windows (and will need tests) - The app shim will need a dock context menu as well Bug: 982024 Change-Id: Ia72bc46b42b4ee3fa2866235c2e681aa690013a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819853 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#699885}
-
Elly Fong-Jones authored
10.15 introduced three new keyboard layouts that this test didn't handle: * Dhivehi-QWERTY, which behaves like DVORAK-QWERTYCMD but with a different base layout * Kyrgyz-Cyrillic, which generates cyrillic characters only and doesn't match any key equivalents * Mongolian-Cyrillic, which is similar This change: 1) Generalizes the DVORAK-QWERTYCMD logic to also handle the new Dhivehi-QWERTY layout (and others if needed later); 2) Skips this test on the two new Cyrillic layouts Bug: 998755 Change-Id: I1527974222b9e962379c70f8a57da5bc9cdba8e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825140 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#699884}
-
Adithya Srinivasan authored
This is a reland of a42225db. I've disabled the test on ChromeOS as it fails due to a known bug. We should still run this on other platforms. Original change's description: > Portals: Add chrome/ browser test for activation > > Bug: 927056 > Change-Id: Ief5a22cf86cd6bdeeae4361e616f66487f589c9c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809115 > Reviewed-by: Lucas Gadani <lfg@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698129} Bug: 927056 Change-Id: I9a05b6086f6d5341a4df30eb2bddf4ea2d07574e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817765Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#699883}
-
Alex Moshchuk authored
This CL will force all future tests that rely on content::NavigateToURL() to check its return value and ensure that the navigation behaves as intended. All existing tests have already been converted to validate the return value. Bug: 425335 Change-Id: I8c7c47a19b9b7beed5546dbe6f38b2dde1aed437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820319Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#699882}
-
Vasilii Sukhanov authored
Bug: 936011 Change-Id: I57095b23d0b5540425cac35f929ced8d7a5c5549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824889 Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
-
Joshua Peraza authored
Bug: 942279 Change-Id: I221431e352f11b40c3bc39bbcd8297b431dd8f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763346 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#699880}
-
Christian Biesinger authored
Tested by running: cups_config_helper.py --libs-for-gn /usr/local/google/home/cbiesinger/chromium/src/build/linux/debian_sid_amd64-sysroot With python2 and python3. Bug: 941669 Change-Id: I88bd4d13039a48b1aafa617e6856b07fdc87ce2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825568Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#699879}
-
Scott Violet authored
RemoteFragmentClient -> BrowserFragment BUG=none TEST=none Change-Id: I7560db41694f766b71bf13c9f6f687d587b93b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825569Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#699878}
-
Yue Li authored
In Chromium build the libassistant might be unavailable. In this case we want to hide the Assistant opt-in flow. Bug: b/141330938 Test: Manual Test Change-Id: I6796cab496892938a7c026e1a72d1fc4a4b25296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817319 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#699877}
-
Tarun Bansal authored
Effective connection type (ECT) is now available from NetworkStateNotifier on the blink side. The logic to pass the ECT from browser side to renderer per frame is no longer needed. The CL also updates the calls on the Blink side to use GetNetworkStateNotifier instead of the per-frame value. This CL introduces one functional difference: Before: The value of ECT was frozen for the frame and that frozen value was propagated to the child frames as well. With this CL: The value is not tied to a frame and may change dynamically with time during the lifetime of frame. Further, the main frame may see a different value than child frames. Change-Id: Id80629142e17f304f7dd53ac3cd25c9837b99955 Bug: 725680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815602Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#699876}
-
Caleb Raitto authored
Create FakeDataSink class to retrieve request body from UploadDataProvider. Add request body byte array as a parameter to ResponseMatcher.getResponse(). Added ResponseMatchers should verify the body of the request if that is necessary for the test before responding. Patched from original CL: crrev.com/c/1742515 (kirchman@'s internship ended). Bug: 669707 Change-Id: I3be8a95e80e82cf74edd7bd5e23e5adf2e5e04cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784978 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#699875}
-
Sergey Ulanov authored
Previously FuchsiaVideoDecoder was was destroying decryptor when re-initializing. This approach wasn't working well because the buffer collection shared between decryptor and decoder is being torn down when decryptor is destroyed, which causes the decoder to fail as well. To avoid this issue FuchsiaVideoDecoder now reuses the decryptor after re-initialization. Bug: 1003529 Change-Id: Ie90d4e5f9d4bbe5d96dafcfc69d19f314080c05c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819945 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#699874}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I65bed07b831dd541dec524562706772f6df33b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824290Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#699873}
-
Fredrik Söderquist authored
This gets rid of the IntervalSelector argument, replacing it with a time which the interval should start after (or at) and end after. With this, ResolveInterval(...) becomes independent of the current interval (previously only used as the internal "begin after"). Fold ResolveNextInterval() into its only user. Bug: 998526 Change-Id: I807327986d5aa7286395ac29019a63d6c8921202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825417Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#699872}
-
Jan Krcal authored
This CL removes and unused notification AutofillMultipleChangedBySync() from the AutofillWebDataServiceObserverOnDBSequence interface. #JointFixit Bug: 900607 Change-Id: I03d32a60f7fbac58a3738767baead7fe61354d34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824091 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#699871}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/edb189d40cb2..9776ca2c2a0d git log edb189d40cb2..9776ca2c2a0d --date=short --no-merges --format='%ad %ae %s' 2019-09-25 tcwang@google.com afdo: Extend AFDO stalenss check to 42 days. Created with: gclient setdep -r src/third_party/chromite@9776ca2c2a0d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I6ce60f657fd2f6dd1d5adbaf3fddc805f73d9636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825618Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699870}
-
Tibor Goldschwendt authored
Bug: 989646 Change-Id: I979e775039aa59087fa3a50b2ad78e8d692ee634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825297 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#699869}
-
Allen Bauer authored
Bug: 1005568 Change-Id: Idd5cec9dea5e717279487a5601c16522c78278c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825458 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#699868}
-
Shakti Sahu authored
This CL adds several fixes: 1 - Adds custom height for full state 2 - Fixes a crash when trying to obtain ChromeActivity by using ActivityWindowAndroid. This is required especially during text input. Bug: 998826 Change-Id: Ib9a7bb370c7c230d2ca22064d92f23d1161ae0e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815053Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#699867}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e32ae4f8fb8f..d63f8f88a1b0 git log e32ae4f8fb8f..d63f8f88a1b0 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b3fb292c..edf70056 (699622:699748) 2019-09-25 srte@webrtc.org Cleanup of target rates in GoogCC/SendSideBandwidthEstimation. 2019-09-25 peah@webrtc.org First step of adding multi-channel support to the echo subtractor 2019-09-25 srte@webrtc.org Converts const methods in BitrateAllocator to non-member functions. Created with: gclient setdep -r src/third_party/webrtc@d63f8f88a1b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I92848bffd3aa6c7e7557e536dac5a3172bd53ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825617Reviewed-by:
-
Tao Bai authored
To prevent unnecessary view Exit/Enter notification, we stopped send them if the position wasn't change. Bug: 1005545 Change-Id: I378a4ca0516ab636dc21eb72a1149613cabbe386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812238Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#699865}
-
Dirk Pranke authored
It wasn't entirely clear who was using //third_party/ply, so this CL documents that (PPAPI, Mojo, and Blink) and adds appropriate OWNERS for the directory. Bug: 998358 Change-Id: Ieda359712adb7b0882ca5ff443e92305440cb14c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824066Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#699864}
-
Peter Kotwicz authored
This CL fixes the modifier ordering in WebappActivityTestRule#jsWindowOpen() BUG=None TBR=yfriedman Change-Id: I2bff99d1b912177fc9ac0fc63b383b6242dd503c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823907Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#699863}
-
Adrienne Walker authored
Per discussion at TPAC, this value that was previously only a parameter on IDBDatabase.transaction is now visible on the IDBTransaction itself. This experimental option is behind the RuntimeEnabledFeatures::IDBRelaxedDurabilityEnabled flag. Bug: 965883 Change-Id: Iace6607b0b28702de3e9bd397f9942e9457f1cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818462Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#699862}
-
Luis Sanchez Padilla authored
Heuristic approaches, which change the weight given to velocity and acceleration depending on the magnitude of direction change, are mentioned in https://dl.acm.org/citation.cfm?id=2984590. Although the Kalman Predictor produces less Jitter than non filtered methods, it is still fairly noticeable. This is addressed by adding a heuristic step in the prediction generation. NIT: Changed InputPredictor::kMinimumTimeInterval to kMinTimeInterval to resemble variables using Max instead of Maximum. Change-Id: I5a3e3366b474bb453930bdddb70c85d9ea0e8a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822657Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Luis Sanchez Padilla <lusanpad@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699861}
-
Peter Boström authored
Prevents use-after-free if ContextMenuController gets destroyed while the context menu is running (nested runloop or as a result of using the context menu). Bug: chromium:1003313 Change-Id: Ib289adf97cd1b5d27507ee4d4c581c1bb3f51bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815828 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#699860}
-
Rohit Agarwal authored
First metric collects stats on bookmark addition sliced on profile. Second and third metric collects stats on the count of open tabs during bookmark all tabs, for regular and incognito users. Bug: 966747, 1006145 Change-Id: I29add57c472cf5344951b4a91be465872db45485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793184 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#699859}
-
Lei Zhang authored
Remove unneeded includes, forward declarations, and method declarations. Change-Id: Ifb4358eb6a886d72a3c472ea0fe1bc222ecd14a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823816Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#699858}
-
John Chen authored
Disable three perf tests that are flaky on the desktop: * system_health.common_desktop/browse:news:hackernews:2018 * v8.browsing_desktop-future/browse:news:hackernews:2018 * v8.browsing_desktop/browse:news:hackernews:2018 TBR=crouleau@chromium.org NOTRY=true Bug: 1008028 Change-Id: Icd3f51a3eaa7e1aa2cd01517c62acfece62c0151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825570Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#699857}
-
Lan Wei authored
When we add default tick duration of two-frame time, we see some tests memory leak which may end the tests when the page is still active, so I add promise to each tests, once the actions are all finished, we will call the test end in the promise callback. Bug: 606367 Change-Id: Ie63b8fd168426b84bedc6c31d5b3bdbb1813ccd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790742Reviewed-by:
-
Tommy Steimel authored
This CL sets the MediaNotificationListView's background to transparent so that white pixels don't peek through in the corners of the dialog. Bug: 1006234 Change-Id: I3cea0c32d4b9ba238d327e219e052265e06a1847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816974Reviewed-by:
Jazz Xu <jazzhsu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#699855}
-
Alex Moshchuk authored
This is hopefully the last step before finally adding WARN_UNUSED_RESULT to NavigateToURL(). Apart from adding straightforward expectations for regular and redirect cases, this fixes a couple more bugs: - AppendingFrameInWebUIDoesNotCrash was broken on Android, because it used chrome://tracing, which doesn't exist on Android. - A couple of tests in WebContentsImplBrowserTest (e.g., ChangeDisplayMode) were navigating to about://blank (instead of about:blank), which results in an error rather than a blank page. Bug: 425335 Change-Id: Id80040de9c3383c517f2df95b819f314e6b29f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819852Reviewed-by:
-
Oksana Zhuravlova authored
Bug: 995422 Change-Id: I384e85321bdc8987e0e39a633833bb242354dfc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811990Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
Removing unity flag check in GoogleServices settings EarlGrey tests. Bug: 951313 Change-Id: Iff3c3fbd1ec285ba05fc9efc838c8fbe904255b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813333 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#699852}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ddfa91df..121f6b79 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0dd35bb14b6205905c8920b3a783b024891b8c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825397Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699851}
-
