- 05 Mar, 2020 40 commits
-
-
Jason Lin authored
Crostini terminal needs to know when a11y spoken feedback is on so that it can also turn on its a11y features. However, the SWA (system web app) terminal cannot access the "accessibilityFeatures" extension API because it does not support SWA. To fix this problem, we add a new function and an event to terminalPrivate API to allow the terminal to get and subscribe to a11y status. Bug: 1019034 Change-Id: Ief4a5edceed470eac8d5b85d72f4ae581ce2dcb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086357 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#747130}
-
Luciano Pacheco authored
Force some tests to run without FilesNg because they depend on the breadcrumb and the new breadcrumb isn't 100% ready: - tabindex* - breadcrumbsNavigate - breadcrumbsLeafNoFocus - showMyFiles Other tests disabled for FilesNg were due to name conflicting when using EnableFilesNg() and without it, both getting the suffix _FilesNg, forced DisableFilesNg() to make it explicit and have no suffix. Bug: 992818 Change-Id: I3737dfdb5bcd46f5fd6952fc38346880950c86e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087880Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#747129}
-
Keishi Hattori authored
Bug: 1058341 Change-Id: I6e94a95be6e09d33da4424a9e228b69386e43783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087240Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#747128}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ca204ee2e1ed..60abb5cb5d28 Created with: gclient setdep -r src-internal@60abb5cb5d28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Idbd88d3f11e43b3fdee29bbdacdecf433407ca0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088807Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747127}
-
Luciano Pacheco authored
Add test helper function that checks if the Files app is running with the flag on/off. Change context_menu.js test to not rely on the breadcrumb for navigation, to be it's compatible with/without FilesNg. Change tests checking to sorting icon to use different query selector depending if is running with/without FilesNg. Change grid_view.js to dismiss Drive welcome banner to be able to display all entries. Bug: 1035691, 992819, 992821, 992822, 992818 Change-Id: Ia7d54e8446a0bb1aaef241525d225ff479533b42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087245 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Noel Gordon authored
The splitter button has no keyboard interaction so no need for it to receive tab focus. Tab focus from directorytree => to breadcrumb, is the behavior we want. Bug: 1002790, 992819 Change-Id: If41272a1edd903be36b858aed211083f2c6ebdd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087204Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Chong Gu authored
Bug: 1058458 Change-Id: Ia1c62fefd1accf999031155a60e7a3493285a0e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088181Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#747124}
-
Luciano Pacheco authored
Bug: 1035691,992819,992821,992818 Change-Id: Ie560caf9f760e0baae734f7d9bcccdb9b73382df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087244 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Miguel Casas authored
This CL replaces the DRM specific XR30 with AR30 where appropriate, and adds the necessary entries to support AR30 with SCANOUT usage. This format started being supported with the recent Mesa uprev. Test: forcing BGRA_1010102 as DisplaySnapshot::PrimaryFormat, and allowing for only an opaque FB (ToT wants both opaque and normal) the primary plane of the device is indeed XR30 as per /sys/kernel/debug/dri/0/state). and gl_unittests --gtest_also_run_disabled_tests and ozone_gl_unittests --gtest_also_run_disabled_tests AR30 test cases passing. Bug: 949260 Change-Id: I852433d30a5243f682b7bb9b9e8bbb0184b1d4d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068825 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747122}
-
Luciano Pacheco authored
This makes the tabindex integration tests failure message more obvious. The test is based on the id of elements receiving focus. Bug: 1035691, 992818 Change-Id: I72ebbeb35927cbfa07c246b6bdf4d0b20f4bc427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088971 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#747121}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/43c76d116441..2e60acad147c git log 43c76d116441..2e60acad147c --date=short --first-parent --format='%ad %ae %s' 2020-03-05 fmeawad@google.com [dashboard] Fix focus selection after onBlur Created with: gclient setdep -r src/third_party/catapult@2e60acad147c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1058488 Tbr: wenbinzhang@google.com Change-Id: Ice93f5eb6182c5f15a6c4600a5ee845c9ea42628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088809Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747120}
-
Yuly Novikov authored
Fix the filter to include patterns like *Vulkan_SwiftShader_NoFixture TBR=kbr Bug: angleproject:4421 Change-Id: Idb893da8696226a86287b32fd6163fa66b173761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088686Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
-
David Schinazi authored
https://quiche.googlesource.com/quiche.git/+log/f6cb54d6b392..7e5e609bc7a1 $ git log f6cb54d6b..7e5e609bc --date=short --no-merges --format='%ad %ae %s' 2020-03-02 vasilvv Add default version for QuicTransport and use it in all unit tests. 2020-03-02 vasilvv Fix QuicEndpointTest failure when using QUIC-over-TLS. 2020-03-02 dschinazi Add support for draft-27 2020-03-02 fayang gfe-relnote: In QUIC, add an option PLE2 to arm 1st PTO at least 1.5 * srtt from latest sent packet. Protected by gfe2_reloadable_flag_quic_arm_pto_with_earliest_sent_time. 2020-03-02 wub gfe-relnote: (n/a) Refactor Bbr2ModeBase::Enter and Bbr2ModeBase::Leave to allow BBR2 to switch modes outside the context of a congestion event. Refactor only, no behavior change. 2020-03-02 dschinazi Deprecate quic_drop_small_initial_packets 2020-03-02 dschinazi Prepare crypto stream tests for reordering versions 2020-03-02 renjietang gfe-relnote: Add QuicSession::WriteCryptoData and move encryption level settings from crypto stream to this method. No functional change expected. not protected. 2020-03-02 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_bbr2_always_count_loss_events. 2020-02-28 dschinazi Remove many uses of QUIC_VERSION_99 in tests 2020-02-28 nharper Rename QuicCryptoServerHandshaker to QuicCryptoServerStream 2020-02-28 fayang gfe-relnote: In QUIC, arm 1st PTO based on the earliest in flight packet sent time. Protected by gfe2_reloadable_flag_quic_arm_pto_with_earliest_sent_time. 2020-02-28 wub gfe-relnote: (n/a) Record number of spurious losses in QuicConnectionStats. Stats only, not protected. 2020-02-28 wub gfe-relnote: (n/a) Merge some functionality in quic_socket_utils to quic_linux_socket_utils. No behavior change. 2020-02-28 wub gfe-relnote: (n/a) Deprecate --gfe2_restart_flag_quic_remove_quic_socket_utils_from_packet_reader. 2020-02-27 bnc Remove QUIC_EXPORT from QuicIntervalDeque and member classes because every symbol is defined in this compilation unit. 2020-02-27 renjietang Allow QuicSession::WritevData() to write data at a specified encryption level. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Bug: 1055027 Change-Id: Ibf814f081dc5c86c1058eb627ba1d12262d12eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083935 Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#747118}
-
Kenneth Russell authored
This reverts commit 22bf6abb. Reason for revert: some widespread failures still seen per https://bugs.chromium.org/p/chromium/issues/detail?id=1019787#c19 Original change's description: > Reland crrev.com/c/2078772: Add Android to SkiaRenderer field trial > > Bug: 1019787 > Change-Id: I82cfdc3c76d0c7e1ef9a9a9939aa8b209ff9dd7c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087428 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Commit-Queue: Jonathan Backer <backer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746940} TBR=backer@chromium.org,rkaplow@chromium.org Change-Id: I400f2eea27fd64055c5d5017678e91adfe78845f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1019787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088953Reviewed-by:
-
Gyuyoung Kim authored
This is a re-land of ec6127ba. The flakiness caused by the original CL doesn't happen after converting WebTestHostMsg_WebTestRuntimeFlagsChanged. Additionally, this CL removes unused WebTestMessageFilter classes. Original change's description: > Convert WebTestHostMsg_InitiateCaptureDump to Mojo > > This CL migrates the legacy InitiateCaptureDump IPC message > to the new Mojo defined in WebTestClient interface. > > Bug: 1039247 > Change-Id: Idd38ecf67d10593f3bfc6f3c48d9832514cec595 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032634 > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739222} Bug: 1039247, 1049919 Change-Id: Ie58a28d6e6dddd26f59849da24579251ad7a970d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043612 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#747116}
-
Keita Suzuki authored
Current websocket handlers used in blink web_test only works with python 2. Update them to python 3 compatible versions to keep them working. Change-Id: I7d8d4f5b858536de25135a05f5ac84643108318c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041378 Commit-Queue: Keita Suzuki <suzukikeita@google.com> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#747115}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e682bc57e190..c55fbc4064aa git log e682bc57e190..c55fbc4064aa --date=short --first-parent --format='%ad %ae %s' 2020-03-05 cnorthrop@google.com Capture/Replay: Fill out more ES 3.0 state in mid-execution capture 2020-03-05 courtneygo@google.com Vulkan: blacklist VK_FORMAT_R8G8B8_UNORM Created with: gclient setdep -r src/third_party/angle@c55fbc4064aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: Iaa7a6006ee31016c785c1687e59263d941dc74f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088805Reviewed-by:
-
Alex Danilo authored
Bug: 1035691 Change-Id: I4aac6e02a90dd7e466f937e7f77a928480fb14e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087860 Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Toni Barzic authored
If the test takes long enough, the contextual nudge will pop up, and add a ChromeVox announcement unexpected by the tests - for now, disable nudges for the test. BUG=1058682 Change-Id: Idfa7d452958c7052435f43d7c8a997fb527d5402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088688Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#747112}
-
Shakti Sahu authored
This CL fixes : 1 - ContentIndex.NumEntriesAvailable - Fixed units 2 - Extended expiration milestone Bug: 1057542 Change-Id: I1a738d5a28ac6ca9f37634cec888330416a609c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082875Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#747111}
-
Yi Xu authored
In my previous cl, "Discard canvas content from frame if canvas is fully repaint", I set the |mode_| to discard canvas content from previous frame if there is some paint command in the current frame. These two are not related. So I removed the dependence in this cl. Bug: 1054666 Change-Id: Icc47a03aced6b0033cfe1b9bc5267aa514b8c456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088122 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#747110}
-
Xiaocheng Hu authored
The unit test framework unnecessarily enables async parsing and complicates the test cases. So this patch stops it. Bug: 1040632 Change-Id: Iabed725367d987c4a852d35facda96678834b4bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088808Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#747109}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f1d78a6c68da..f6ed96d1c23b git log f1d78a6c68da..f6ed96d1c23b --date=short --first-parent --format='%ad %ae %s' 2020-03-05 egdaniel@google.com Revert "Move GrGpuResource GrSurface and GrTexture into src." Created with: gclient setdep -r src/third_party/skia@f6ed96d1c23b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: Icea13ba4f010bd5f91c02ef57bd9bbcbcf0fccbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088803Reviewed-by:
-
John Budorick authored
Bug: 1058570 Change-Id: Icee377f781b9628b9a2683266124531134094c7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088039Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#747107}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/31b40ecf7208..35da12b1c3de git log 31b40ecf7208..35da12b1c3de --date=short --first-parent --format='%ad %ae %s' 2020-03-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-03-05 vidorteg@microsoft.com Sanitizing check_localizable_resources description Created with: gclient setdep -r src/third_party/devtools-frontend/src@35da12b1c3de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I47f5b93fa21e2b40864a8e0b0a683d1e402ba883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088299Reviewed-by:
-
Danyao Wang authored
Before this CL, ManifestIconDownloader always downloads icons from the main frame. This creates a buggy interaction with Content Security Policy, when the manifest icon download is initiated from inside a frame. After this CL, the callers of ManifestIconDownloader can specify an initiator frame (as a GlobalFrameRoutingId) in which to download the image. The frame routing ID is passed to WebContents to find the correct frame that exposes the mojo.ImageDownloader interface. This CL also exposes the mojo.ImageDownloader interface in all frames instead of just the main frame. A subsequent CL will update the callers of ManifestIconDownloader to pass in the correct frame routing ID. Bug: 1055360 Change-Id: I31fd58453392ec4e1165ac20dc3a1284dc05f6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085752 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#747105}
-
Ben Pastene authored
This is mostly a no-op, save for the fact that the hook will populate //build/args/chromeos/ with *.gn files for the affected board. Bug: 937821 Change-Id: I003d601cd463847a1b16c3ec777ea500517e5a70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088331 Auto-Submit: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#747104}
-
Evan Stade authored
Bug: 1058495 Change-Id: Idcc16972171811e9a338fab4659fd38f413158de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088221 Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Liquan (Max) Gu authored
Context: PH UI = Expandable Payment Handler UI Before change: * As users drag the PH UI, the WebContents resize after users stop dragging for 100ms. * As the PH UI opens, the WebContents flashes. It's because the sheet's offset keeps changing as during the opening animation. Each offset call WebContents to resize. After change: * The WebContents is set to its full height all the time (aka non-resizable). * As the PH UI opens, the WebContents no longer flashes. Change: * Set ThinWebView a height only when the toolbar has been laid out or the Tab view layout has changed. * Remove resizing logic Note that: * The WebContents' full height is different from FILL_PARENT, because at bottom-sheet's full height, the content area still have a part extending below the screen. This is why a delicate computation for the the height of the content visible area is still needed. Bug: 1054562, 1037646, 999196, 1058317 Change-Id: I04bab360f65109968a240c095d9c54133ecd9566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083305 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#747102}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/6ffd816ce45b..af823daff93a git log 6ffd816ce45b..af823daff93a --date=short --first-parent --format='%ad %ae %s' 2020-03-05 rwkeane@google.com mDNS: Change MdnsService ctor Created with: gclient setdep -r src/third_party/openscreen/src@af823daff93a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I5374f7c0d7974801d970f08d802ef60cc7cdb88c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088831Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/986058e2b8a4..ca204ee2e1ed Created with: gclient setdep -r src-internal@ca204ee2e1ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iade8cf883a84b08570faad810523c4c1bf9567cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088801Reviewed-by:
-
Eric Willigers authored
WebAppBrowserController is now consistent with HostedAppBrowserController in using a 32x32 icon. Bug: 1057986 Change-Id: I9171ce25cb3591881a30d249f95c19a511c54882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086366Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#747099}
-
Kei Nakashima authored
Implemented NewLinkedHashSetConstIterator, const iterator for NewLinkedHashSet. Also added test for it. Change-Id: I84299d866e0cdb94ac2fbf2c31362a22779e0184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086376 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Kei Nakashima <keinakashima@google.com> Auto-Submit: Kei Nakashima <keinakashima@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#747098}
-
Miguel Casas authored
This CL follows up on the previous by updating the uses of BGRA_1010102 (which used to be BRGX_1010102) in resource_format_utils.cc and gl_image_io_surface.mm, basically allowing for its correct usage now that the gymnastics of pretending that the alpha format is opaque. Of note here is the CGLTexImageIOSurface2D we use for these types: https://github.com/phracker/MacOSX-SDKs/blob/HEAD/MacOSX10.12.sdk/System/Library/Frameworks/OpenGL.framework/Versions/A/Headers/CGLIOSurface.h#L102 TEST=display and gl_unittests passing and http://crosvideo.appspot.com/?codec=vp9.2_30&loop=true&mute=true reproducing correctly on Mac. TBR=kbr@ for gpu/command_buffer/service/feature_info.cc (comment fix) Bug: 949260 Change-Id: I8a422192a27833846482d14a1106d7d662ab9bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072780 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#747097}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/83bc671bd217..3ccfc90f5032 git log 83bc671bd217..3ccfc90f5032 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 ukai@google.com Roll out new goma client binary VERSION=193 2020-03-04 ehmaldonado@google.com gclient: Don't allow duplicate entries on deps 2020-03-04 qyearsley@chromium.org depot_tools: git-cl: Rename try job to tryjob for consistency Created with: gclient setdep -r src/third_party/depot_tools@3ccfc90f5032 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:809671 Tbr: agable@chromium.org Change-Id: Ib148aee158252697f8db869b789a48ff8f410d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088800Reviewed-by:
-
Alex Danilo authored
Files App menus have a number of style properties applied to them. Adds properties to the elided drop-down to match the visual appearance of the frame of the drop down to the existing menu frames. Changes the font used in the drop down buttons to match the font used in our other menus. Style change only so no-try: true No-try: true Bug: 1035691 Change-Id: Ic822b5bccb5f2daca5053630ec3256e7c2399427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087241Reviewed-by:
-
Keita Suzuki authored
This commit updates DEPS file to add pywebsocket3 to //third_party. Change-Id: I41a402d7d640f365712e93db01dbd85618fe082e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059041Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Keita Suzuki <suzukikeita@google.com> Cr-Commit-Position: refs/heads/master@{#747094}
-
kylechar authored
It's expired and not useful. Bug: 1043702 Change-Id: If5dcb23c5daa084c1cf524b18ac5c3e28483d920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083222Reviewed-by:
-
sauski authored
As part of the Privacy Settings Redesign, controls which are currently present on the main privacy card have been moved to subpages. This CL adjusts the main privacy card to contain links to these subpages and remove any now duplicated controls. All of the changes in this CL are hidden behind the privacySettingsRedesign flag. Test have been added to ensure the existing behaviour is preserved when the flag is off. Bug: 1032584 Change-Id: I174cd6b404c9d704165e3a8d7991e8429088dbe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088233 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#747092}
-
Danan S authored
Includes methods to: - Show Parent Permission Dialog - Record addition or removal of parental approval for specific extensions - Check whether a specific extension can be installed/enabled - Check whether a child user can install extensions at all. - Verify that a user is a child - Verify that a child user has custodians The factory has a new method to: - Get a service instance from a browser context. Needed because some APIs that depend on this code can't access the browser profile. Bug:957832 Change-Id: I15259c8f27b0b44d579615f1f312cb2a42bcb217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070598 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#747091}
-
