- 06 Nov, 2018 40 commits
-
-
Luna Lu authored
Change-Id: Ib8e1aba6d56ee257664aef39aed635490f25f2e1 Reviewed-on: https://chromium-review.googlesource.com/c/1320019Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#605759}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7a305a2ef715..5d3deb7301b1 git log 7a305a2ef715..5d3deb7301b1 --date=short --no-merges --format='%ad %ae %s' 2018-11-06 fmalita@chromium.org [skottie] Preserve image aspect ratio 2018-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 3d86e89bce7a..77b2436e28f4 (1 commits) 2018-11-06 mtklein@google.com Revert "make enum santizer fatal" 2018-11-06 reed@google.com change MakeRecAndEffects to take SkFont Created with: gclient setdep -r src/third_party/skia@5d3deb7301b1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I7fbdbbd49fc71bc437e93c2339aa01386aae0c8b Reviewed-on: https://chromium-review.googlesource.com/c/1320151Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605758}
-
Alexandre Frechette authored
Fixing logic bug in IPH triggering logic. Adding a variation for "force trigger on english" experiment as a flag to automatically trigger it. Bug: 883456 Change-Id: Ice024580601fdfe5debb862bb7cfeff956b04dbc Reviewed-on: https://chromium-review.googlesource.com/c/1318631Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#605757}
-
Mario Sanchez Prada authored
Rely on the IdentityManager's API instead of SigninManager's one, and implement identity::IdentityManager::Observer to monitor for signed-in and signed-out events. Bug: 890824, 887463 Change-Id: Ic8a7d46ba91c0824d8949475c04fa75131c5cf70 Reviewed-on: https://chromium-review.googlesource.com/c/1315213 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#605756}
-
Evan Stade authored
It's flaky everywhere, not just mash. TBR=caseq@chromium.org Bug: 889878 Change-Id: Iae5bdc6625102ad5dc59707a68f1f67db2a53dcd Reviewed-on: https://chromium-review.googlesource.com/c/1318801Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#605755}
-
Takuto Ikuta authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/155f802a6be3..4169b31090db $ git log 155f802a6..4169b3109 --date=short --no-merges --format='%ad %ae %s' 2018-11-05 tikuta Fix for unused-lambda-capture warning 2018-11-05 gordana.cmiljanovic [MIPS] Add support for 64b MIPS architecture 2018-11-03 tikuta Revert "Fix for unused-lambda-capture warning" 2018-10-23 tikuta Fix for unused-lambda-capture warning Created with: roll-dep src/third_party/swiftshader Bug: 681136 Change-Id: I74a53ae11edbd50fb69c95764a7c77dc54b473c1 Reviewed-on: https://chromium-review.googlesource.com/c/1318511Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#605754}
-
Seth Hampson authored
As part of the effort to add read/write to the P2PQuicTransportStream, some of the stream level tests need to be moved into their own more isolated testing environment. This includes using a MockQuicSession. This change moves the stream unit tests to this new environment, and also updates the p2p_quic_transport_test.cc to use Mock objects instead of the fake objects for the delegates. Bug: 874296 Change-Id: Ifdfd30f753a2b6090c8f73330978c5feed2b9cf6 Reviewed-on: https://chromium-review.googlesource.com/c/1312971Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Seth Hampson <shampson@chromium.org> Cr-Commit-Position: refs/heads/master@{#605753}
-
Dan Sanders authored
Experiments have been uneventful for many weeks. Enable by default for M72. TimeToFirstFrame is negatively impacted by this change, as the startup IPC now hops throught the browser where before it went directly over the GPU channel. The cost is typically less than 30ms. Reconfigurations are faster because PictureBuffer allocation no longer requires any IPC. Bug: 522298 Change-Id: I40ea00150f7dadfe2319e2cdb27e3be5f29a702c Reviewed-on: https://chromium-review.googlesource.com/c/1315940 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#605752}
-
Xi Cheng authored
Change-Id: I5059c4f7e1351ea62749fd381fd6fea3a812f749 Reviewed-on: https://chromium-review.googlesource.com/c/1319345Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#605751}
-
Sebastien Marchand authored
The fact that the LIVE_STATE_USING_WEB_SOCKETS reason exists might confuse some devs who could assume that using a WebSocket will protect their page, this add a comment to specify that this heuristic isn't currently used. Change-Id: Ibc6034a53c87291993dfa66094b69a2fa55aa0cf Reviewed-on: https://chromium-review.googlesource.com/c/1319771Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#605750}
-
Peng Huang authored
WebGL may use GL_RGB texture, and choose viz::RGBA_8888 as resource format. So to make WebGL work, we should not consider it an invalid combination. Bug: 901822 Change-Id: I4b6678492b2fb847d66de3fe8ec7b0049ca8eaff Reviewed-on: https://chromium-review.googlesource.com/c/1318076Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#605749}
-
Vladislav Kaznacheev authored
On some scale factors the bottom most pixel is outside of the display bounds. Snapping shelf region to display edge fixes the problem. Bug: 899007 Test: manual Change-Id: I1eeb342756b46e683d0f30f96f1c428fbb74d7ca Reviewed-on: https://chromium-review.googlesource.com/c/1320013Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#605748}
-
James Hawkins authored
R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I300f9e21a19abdfff93b8a70a21cec6dac00db31 Reviewed-on: https://chromium-review.googlesource.com/c/1319338Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#605747}
-
Robert Ma authored
The application default credential belongs to the default Swarming bot account, not the dedicated service account for wpt-importer. As suggested by LUCI task force, we need to use `luci-auth token` instead. Bug: 790503 Change-Id: I3257db9a49196fd427c6f2371d00dcabab7ee3a6 Reviewed-on: https://chromium-review.googlesource.com/c/1315931 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#605746}
-
Scott Graham authored
Previously the body of structs was traversed in-order, but out-of-line items were deferred to a queue, making traversal mostly breadth-first. Instead, fix encoding by emitting any out-of-line items by allocating (and filling) directly following the current item. Bug: 883496 Change-Id: If157930521e4cf5f89f702207defe91beb862def Reviewed-on: https://chromium-review.googlesource.com/c/1316429 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#605745}
-
Alexandre Frechette authored
be translated or not. Bug: 872096 Change-Id: I9cd2df787c46f6b95f3918adaf8023a030c0b480 Reviewed-on: https://chromium-review.googlesource.com/c/1313416 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#605744}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a8f54617c08d..277b6ea8508e git log a8f54617c08d..277b6ea8508e --date=short --no-merges --format='%ad %ae %s' 2018-11-06 alessiob@webrtc.org Isolating APM API build target: adding dummy :api target. 2018-11-06 phoglund@webrtc.org Revert "Add support for screen sharing with PipeWire on Wayland" 2018-11-06 ilnik@webrtc.org Tune huge video frames detection threshold for GetStats googHugeFramesSent stat 2018-11-06 sprang@webrtc.org Make VideoSendStreamTest.NoPaddingWhenVideoIsMuted less flaky Created with: gclient setdep -r src/third_party/webrtc@277b6ea8508e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:682122,chromium:901319,chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6dadb5c6014d55b6065ea8c415045b3854688c65 Reviewed-on: https://chromium-review.googlesource.com/c/1319810Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605743}
-
Tarun Bansal authored
Expand an existing function in network quality estimator (NQE) to more accurately determine the cause of crash. This CL does not make any functionality change. Bug: 899808 Change-Id: I77c8aa07ca23ea92f99775a36393431f4ebf8cb4 Reviewed-on: https://chromium-review.googlesource.com/c/1319339Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#605742}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/04f1c7dac0fd..d85a5094684e Created with: gclient setdep -r src-internal@d85a5094684e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Icca8193d5c78d30a72193cbce0912c2e67e96d88 Reviewed-on: https://chromium-review.googlesource.com/c/1319812Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605741}
-
Luna Lu authored
moved current test expects to platform/linux added new test expects to platform/win Bug: 889185 Change-Id: Ifdd0e9c4f0389967756e5dcc2fe3512da40e8e41 Reviewed-on: https://chromium-review.googlesource.com/c/1318375 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#605740}
-
Khushal authored
We currently keep a counter on the raster buffer provider for sampling this metric, which can result in bias in some cases. R=vmiura@chromium.org Bug: 894200 Change-Id: I943afeaf5653ca30baee611f7d1f8ebb50a3030c Reviewed-on: https://chromium-review.googlesource.com/c/1319029Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#605739}
-
Kush Sinha authored
Design doc and sequence diagrams are linked in the bug id. Add Mojo API: - OnAccountUpdated Add functionality to listen for account modifications in Chrome OS and pass these notifications to ARC, only if ARC provisioning has been reported to be successful. Add functionality to push accounts from Chrome OS to ARC when the first successful provisioning is reported, and at startup, if ARC has already been successfully provisioned. Bug: 871690 Test: browser_tests --gtest_filter="*Arc*AuthService*Test*" Change-Id: I9e5610c8a00cdd4179328156d2a11540878986b2 Reviewed-on: https://chromium-review.googlesource.com/c/1238913 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#605738}
-
Yusuf Ozuysal authored
In openInChrome, we had a past fix to check if Chrome can handle a VIEW intent and pass back to the system if not. But this seems to have come back with a smaller crash segment that fails because there are no handlers. This CL handles that one last exception and lets Chrome do nothing as a graceful failure. BUG=891640 Change-Id: I9ad7146c5cf8a77e59527b909521460668717818 Reviewed-on: https://chromium-review.googlesource.com/c/1300104Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#605737}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3d86e89bce7a..77b2436e28f4 git log 3d86e89bce7a..77b2436e28f4 --date=short --no-merges --format='%ad %ae %s' 2018-11-06 jmadill@chromium.org Vulkan: Reduce PipelineDesc size. Created with: gclient setdep -r src/third_party/angle@77b2436e28f4 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I8de0956ebe8b1b133ae308c17a0d2470033f50ee Reviewed-on: https://chromium-review.googlesource.com/c/1319949Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605736}
-
Mario Sanchez Prada authored
Use identity::IdentityManager::HasPrimaryAccount() instead of SigninManagerBase::IsAuthenticated, and remove unneeded includes. Bug: 890826 Change-Id: Iabe09231fa684e8249475ba9dcd8782d7ecd90d5 Reviewed-on: https://chromium-review.googlesource.com/c/1315969Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#605735}
-
Jun Mukai authored
This CL fixes DragBrowserWindowWhenMajorityOfBoundsInSecondDisplay of tab-dragging for Mash; - SetBounds are not great for testing with Mash since it may not reflect the correct location in Ash, or it may cause moving the browser window to the secondary display. Instead, dragging events to move the browser window which still resides in the primary display but covers on the secondary display. - Creates a mouse move event on the warped pointer; as far as I debugged, this is not happening in the classic environment too, but the test was passing somehow (the newly added expectation of browser bounds at the end fails even without Mash). BUG=901543 TEST=trybot Change-Id: Id4826673975535e0dc12460cda4a62b060a328db Reviewed-on: https://chromium-review.googlesource.com/c/1318794Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#605734}
-
Evan Stade authored
Currently, ImmersiveGestureHandlerClassic installs itself as a pretarget handler on Shell. This is necessary to get events from bezel sensors, which have bounds outside the immersive fs window. It also forwards gesture events to ImmersiveFullscreenController. Keep the part of ImmersiveGestureHandlerClassic that handles drag- triggering gesture events in tablet mode (i.e. most of the class) and run that within Ash in both Classic and Mash configurations. Make ImmersiveFullscreenController a pretarget handler for the toplevel window when it's in immersive mode. This works in either Ash or client as ImmersiveFullscreenController doesn't need to get events outside of the window's bounds. ImmersiveFullscreenController is now both an EventHandler (for gesture events) and an EventObserver (for mouse and touch events). Bug: 624157,640374 Change-Id: I83536cb407b4ac890db63d4c6a0fe98b7912a3f4 Reviewed-on: https://chromium-review.googlesource.com/c/1300678 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#605733}
-
Antonio Gomes authored
BUG=889873 Change-Id: I3abc3bffc987333d9e0919a722c2d6a9f18815be Reviewed-on: https://chromium-review.googlesource.com/c/1316929Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#605732}
-
Theresa authored
BUG= Change-Id: I9624ac7d0b47cd79925576d604fefd6f82fec6f7 Reviewed-on: https://chromium-review.googlesource.com/c/1313743Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#605731}
-
Arthur Sonzogni authored
What we know about the bug: * URLLoaderClient::OnStartLoadingResponseBody is sent before URLLoaderClient::OnReceiveResponse. * Users have one or more ad blocking extensions. * The NetworkService is enabled. * Websites are loading content inside an iframe that has never navigated. Its URL is still about:blank or javascript:* This CL Instrument WebRequestProxyingUrlLoader. The goal is to confirm this bug is about extensions. Bug: 882661 Change-Id: I1ce33cdb703adb1a854c37f46cafd80a85649388 Reviewed-on: https://chromium-review.googlesource.com/c/1319710 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#605730}
-
Lukasz Suder authored
If there are no details inside parameters nothing is being displayed. Bug: 806868 Change-Id: I50ddbbedbe171fbc4d2af0af5426ac334b877d5d Reviewed-on: https://chromium-review.googlesource.com/c/1319591 Commit-Queue: Lukasz Suder <lsuder@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#605729}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5b640e3d331b..cc7964918f7c git log 5b640e3d331b..cc7964918f7c --date=short --no-merges --format='%ad %ae %s' 2018-11-06 rsavitski@google.com Merge "Reduce verbosity of build tool/dep fetching. Mainly to declutter Kokoro logs." Created with: gclient setdep -r src/third_party/perfetto@cc7964918f7c The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I664b7216a1500d240037e63782680c5aae3b2321 Reviewed-on: https://chromium-review.googlesource.com/c/1319813Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605728}
-
David Quiroz Marin authored
Also adding histogram functions to the allowed list of identifiers for third_party/blink/renderer/ to be able to use those functions instead of the macro versions. Change-Id: I9759c075ce2eff5face0d6c4af9758a64b7e1f68 Reviewed-on: https://chromium-review.googlesource.com/c/1308762 Commit-Queue: David Quiroz Marin <davidqu@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#605727}
-
Josh Karlin authored
This is leftover from previous cleanup work to remove the registration id. This corruption checker checked to make sure that the registration id was valid, but since the id is gone the corruption checker should go as well. Change-Id: I226e2ac388c2163d12ad6dbfe8edb95b3682b7fd Reviewed-on: https://chromium-review.googlesource.com/c/1319690Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#605726}
-
Troy Hildebrandt authored
Adds metrics collection at the LevelDB wrapper level for ProtoDatabase, so any current clients of ProtoDatabase will have new metrics recorded for successes/failures and the error status of various LevelDB operations. To allow gathering metrics on the LevelDB status for failures, the parameters to many of the functions have been modified so we can get the leveldb::Status back in addition to the boolean return value. Bug: 870813 Change-Id: I5d8175dbd4e3b3531532d2f3fc0b33ca155f1336 Reviewed-on: https://chromium-review.googlesource.com/c/1288904Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#605725}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f2cc71e5cbea..398f37a2e0e6 git log f2cc71e5cbea..398f37a2e0e6 --date=short --no-merges --format='%ad %ae %s' 2018-11-06 jajones@nvidia.com Add explicit void parameter in libspirv.h again (#2032) 2018-11-06 jbolz@nvidia.com Enable precompiled headers for spirv-tools(-shared) and some unit tests (#2026) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@398f37a2e0e6 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ibc895ce4295c9dcf50ca7e46872685111f04aa0d Reviewed-on: https://chromium-review.googlesource.com/c/1319814Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605724}
-
Findit authored
This reverts commit d4860fed. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 605719 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Q0ODYwZmVkZTBlMmRjNjNkNjUwMGY5OGJmZTkxMzkyMTk1OWM3OTUM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/Linux%20ChromiumOS%20Full/109223 Sample Failed Step: compile Original change's description: > Update existing Switch Access tests > > Bug: 897365 > Change-Id: Ic8ff1ea5511f3d6cc907a880fffdffa7c5fdbcc9 > Reviewed-on: https://chromium-review.googlesource.com/c/1306787 > Reviewed-by: David Tseng <dtseng@chromium.org> > Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605719} Change-Id: I582f1a3f539ad62742fd4f39e3b004fbc00b974b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897365 Reviewed-on: https://chromium-review.googlesource.com/c/1320014 Cr-Commit-Position: refs/heads/master@{#605723}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/00b29398901e..7a305a2ef715 git log 00b29398901e..7a305a2ef715 --date=short --no-merges --format='%ad %ae %s' 2018-11-06 halcanary@google.com Enums: specify base 2018-11-06 kjlubick@google.com Add skia-wasm-release image. 2018-11-06 mtklein@google.com make enum santizer fatal Created with: gclient setdep -r src/third_party/skia@7a305a2ef715 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: Id10dc905ccf14abbc8f0c5a65329d7c3edbe926a Reviewed-on: https://chromium-review.googlesource.com/c/1319811Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605722}
-
Daniel Rubery authored
As part of initial data collection for vision-based phishing protection, it would be useful to know how much users zoom in/out. This CL adds a histogram to track that. Bug: 900743 Change-Id: I649bff7213c12c7f9bc37f7cb5ebb4061e43a66a Reviewed-on: https://chromium-review.googlesource.com/c/1311130 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#605721}
-
Daniel Vogelheim authored
With a default policy defined, assignments implicitly call createXXX on the default policy Added ScriptState* to the accessors visible from JavaScript Tests were updated to check string assignment when trusted-types are needed before and after the default policy is defined Bug: 739170 Change-Id: I9bb841d69f324b841602d41abd71f753a9858af8 Reviewed-on: https://chromium-review.googlesource.com/c/1207530Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#605720}
-