- 01 Nov, 2019 40 commits
-
-
Marina Sakai authored
This CL removes a macro-generated fucntion for a private property of IDBCursor, and replaces it with the new API GetSymbol, which uses an instance address of V8PrivateProperty::SymbolKey as a key to get Symbol. Bug: 715418 Change-Id: Ic35389c4b1e0e8d38aff73186bd5db10ed1a1e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890521 Commit-Queue: Marina Sakai <marinasakai@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#711607}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b131630e7c74..48233ad3d45b git log b131630e7c74..48233ad3d45b --date=short --no-merges --format='%ad %ae %s' 2019-11-01 johnkslang@users.noreply.github.com Merge pull request #1949 from corporateshark/master Created with: gclient setdep -r src/third_party/glslang/src@48233ad3d45b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Bug: None Change-Id: If57a7070233d6152a0f9d93a99f7e4ae349e5335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893686Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711606}
-
Xinghui Lu authored
Launch bug: crbug.com/1000331 Bug: 995926 Change-Id: If68dd89ce3bbcddaa0ce2c6553eedf9f6d263216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894297 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#711605}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ba65c156cf76..e96039218e9d git log ba65c156cf76..e96039218e9d --date=short --no-merges --format='%ad %ae %s' 2019-11-01 jmadill@chromium.org Capture/Replay: Correct a few GLenum replay issues. Created with: gclient setdep -r src/third_party/angle@e96039218e9d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: Icfc2f7c19eaf3570f2b25644ab2e7ea017656011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893685Reviewed-by:
-
Rakina Zata Amni authored
Unload events never fire for documents that are put into the BackForwardCache, so these tests won't work with bfcache turned on. Change-Id: I5db67e2d014f993e27764bae841323207191a72a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883352Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#711603}
-
Julie Jeongeun Kim authored
This CL converts ProxyResolvingSocketFactoryPtr to new Mojo types using PendingRemote and Remote. Bug: 955171 Change-Id: Ib92e2fd3f2103568e70c50699a5d2b573056594c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889271Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#711602}
-
Gyuyoung Kim authored
This CL converts old Mojo types of CdmService interface to new Mojo types. Major changes are as below, - Convert connector()->BindInterface to connector()->Connect - Convert FooPtr to mojo::Remote Bug: 955171 Change-Id: Ic754b8747258f941afc249d5c628906d3ef43675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890453Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#711601}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I4835364353e6493df87ce6fc273a70b6a6e12ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894504Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fa2b7d8d16c4..95bb5f86b1c0 Created with: gclient setdep -r src-internal@95bb5f86b1c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1019931,chromium:None Change-Id: I03a522098472a6002ccdc64f9a66c8a0699a625b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894063Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711599}
-
Nate Fischer authored
No change to production logic. This adds tests for already-implemented UMA proto fields (specifically, the hardware.* fields). This intentionally skips fields which don't apply to Android OS (ex. hardware.form_factor, hardare.max_dpi_*). This also skips fields where we're not logging a meaningful value (ex. gpu.vendor_id), since such fields are effectively empty anyway. Bug: 1011991, 1008534 Test: run_webview_instrumentation_test_apk -f AwMetricsMetadataTest.* Change-Id: I871d81b1b669ddef4169744715fe9f043f7573be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888399Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#711598}
-
Alice Boxhall authored
The :focus-visible pseudo-selector emulates the existing behaviour of native elements like buttons by only showing a focus ring when focus is moved using the keyboard. This change modifies that behaviour to always match :focus-visible on the focused element, regardless of how focus was moved (effectively making :focus-visible equivalent to :focus) if the user has enabled the "Highlight the object with keyboard focus when it changes" setting on Chrome OS. This plumbs through the ash::prefs::kAccessibilityFocusHighlightEnabled preference on Chrome OS to a new web setting on Blink, and checks that setting when computing whether :focus-visible matches on the focused element. Bug: 817199 Change-Id: I072e24eba525e5f62507fb5ab7a369d618067c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886075 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#711597}
-
Justin Cohen authored
For some reason this button constantly gets a long press when it should be a tap. Consolidate this hack. Change-Id: Ia6f0f36d9e2aea79673ac0c74fc0d95289d0b043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892220Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#711596}
-
Peter Kasting authored
Calling logically-const methods like GetHeightForWidth() would change the layout. This resulted in graphical bugs unless Layout() got called after each such case, which in theory shouldn't be necessary (and was not happening after crrev.com/699335 ). Bug: 1015717 Change-Id: I06bd35f273a9192b29fbaabfae9b5cc1aba66532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884455 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#711595}
-
Hector Carmona authored
This is a followup to https://crrev.com/c/1874816 that brings the same a11y fix to browser settings. Bug: 987406 Change-Id: I6a22bd509ffcf75312c2897af4374ce5bf418718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888315 Auto-Submit: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#711594}
-
Austin Eng authored
FlexibleArrayBufferView allows small ArrayBufferViews to be passed as a temporary on the stack. This saves creating global handles and weak roots in V8. Bug: 852089 Change-Id: Ic0e8ee941c5175ac5232d5b6a2c1f3f1a315bf9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894409Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#711593}
-
Jacques Newman authored
Bug: 1019947 Change-Id: Ie19d410e0fc5e07b1ebc1fcdf3d94a94dfce9a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888188Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#711592}
-
Alexey Baskakov authored
This is a reland of 5a0adcbe Looks like some platforms don't support sophisticated fonts to render fancy unicode characters. Let's use simple "+" ASCII character. Original change's description: > WebApp: Check pixel at the center of the generated icon. > > We generate an icon placeholder using a letter with some solid > background color. > > Let the test check if letter_color is actually presented in the icon. > > This is a follow up test enhancement for the previous CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1888234 > > Bug: 1019102 > Change-Id: I10e196926dff78032dcd8f00e93e24715d1be913 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891816 > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711143} Bug: 1019102 Change-Id: I25f09ff941b8256d7fae9a7121aa439dc2ef2b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893596Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#711591}
-
Xiaohan Wang authored
The new test case verifies that pipeline initialization of encrypted playback waits for a CDM to be set, and a CDM that doesn't support a Decryptor or a valid CDM ID will cause initialization error. Bug: 1018854 Test: New test cases Change-Id: I67fe51fb5012059533a5113ac929b89f47fdfe29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885022Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#711590}
-
Daniel Hosseinian authored
Rename shadowed variables in PDFiumPage::GetLinkTarget() Bug: 993548 Change-Id: I88e660b6df99c4f3e2140014e1bb5e6626d56ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893504 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#711589}
-
Matt Mueller authored
Bug: 635205 Change-Id: Ia35549688605986b88eb06b373f9d63c3bd3a26b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882761 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#711588}
-
Dominic Farolino authored
R=gab@chromium.org Bug: N/A Change-Id: Ie4779514a78a37f5fdf55d17e713eea46138a8ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892551Reviewed-by:
-
Justin Cohen authored
Adds tests for opening and restoring various sites. Also tests that only the activate webState is restored. Currently there is no support for background/restore in EG2, so those portions of the test suite are #ifdefed out. Change-Id: I5a8e4e3d019ba1598ec806175e369b7dae3cba84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874447 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
blink::WebThreadType is only used in //third_party/blink. This CL moves it to //third_party/blink/renderer/platform/scheduler/{public,common} as blink::ThreadType. Bug: 919392 Change-Id: I8dffa04c3c7be7dd1c31c4c5714461494b5a534c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886859 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Alex Danilo authored
Circular progress indicators default to radius 10, stroke width of 3. This increases the stroke width to 4 if the radius of the indicator is set to any value above 10. Bug: 1014771 Tests: browser_tests --gtest_filter=FileManagerJsTest.FilesDisplayPanel Change-Id: I48b602cebcdad709c64b7e39094cb03602ac118a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893594 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#711584}
-
Julie Jeongeun Kim authored
This CL converts SpeakerIdEnrollmentClient to new Mojo types using PendingRemote, Remote, and Receiver. Bug: 955171 Change-Id: I1132efd95d7a748e27903698bb2c45d22b5d3f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871594Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Austin Tankiang authored
Bug: 1003238 Change-Id: Ic4f462e62d5642cb4122b2d98d2b79d7dcacdddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890400Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#711582}
-
Matt Menke authored
It's much clearer to have a single include rule than to include everything in a single list, and then have exclude rules at the bottom of the file. Bug: None Change-Id: Ife0cd5b984c6422f47b5e4caa99593ff4b48816f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890722 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#711581}
-
Toni Barzic authored
Updates swipe_home_to_overview_controller to start overview session if: * user drags the pointer far enough above the shelf * holds for 350 ms As the user is dragging up, the home view is scaled down, with minimum scale being 0.92 (the home will have the target scale at a poing little above the transition threshold line - if the user keeps going up, the home scale will remain at 92). If the gesture ends before the the hold time-out has exipred, or below the minimal vertical distance from the shelf, the gesture is canceled, and the home screen. Note that the transition might trigger before the drag finger is lifted (in that case subsequent drag events will be ignored). BUG=1005366 Change-Id: I89be582f91322595031d699dc0d335d9c97b1ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894316 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#711580}
-
Alfonso Garza authored
https://screenshot.googleplex.com/ihaqzrJ6nyG.png https://screenshot.googleplex.com/D1Y74zXf1UM.png BUG=993850 Change-Id: I22c9cddd60625f6620cc329f269a46d8ab379459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888539 Commit-Queue: Alfonso Garza <alfonsogarza@google.com> Auto-Submit: Alfonso Garza <alfonsogarza@google.com> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#711579}
-
Xiaohan Wang authored
In MojoCdm, if a remote CDM supports a Decryptor directly, it should be returned via |decryptor_ptr_info_|. Otherwise, the Decryptor may be supported via CdmProxy, and MojoCdm can request the Decryptor using |cdm_id_|. This CL puts the second part under #if BUILDFLAG(ENABLE_CDM_PROXY) to avoid complicating decoder selection logic when CdmProxy is not enabled, e.g. the DecoderSelector may assume there is a Decryptor available and setup the media pipeline to use DecryptingDemuxerStream. Bug: 785563 Change-Id: Id0c3557620f22c443cad0cd79a9ae0236b4e4575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894187Reviewed-by:
-
Ricky Liang authored
We support GpuMemoryBuffer-based buffer in FakeVideoCaptureDevice now [1], so update the comment accordingly. [1]: https://crrev.com/c/1863055 Bug: 982201 Change-Id: I8108e3f45caf4d9eead3d3c88ea1a8e5f31adc1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890381Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#711577}
-
Collin Baker authored
This is a cleanup in prepration for performing the changes laid out in crbug.com/995131#c24 Bug: 995131 Change-Id: I177069c21782ccd38231c483da5469bc47932158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891119 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#711576}
-
Yusuke Sato authored
We no longer need the code. BUG=b:136128691 TEST=try Change-Id: Ifd2440ee7e913530954899516234f3e4244553cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894325 Auto-Submit: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#711575}
-
Daniel Rubery authored
This CL re-introduces the code allowing the MultipartUploadRequest to function. It also removes the old endpoint for the BinaryUploadService. This reverts https://crrev.com/c/1869028 Bug: 1020434 Change-Id: Ie8c652d1e4b53facd03dfdbe858394c0873286f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892092 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#711574}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f016a6633058..a936069d60ce git log f016a6633058..a936069d60ce --date=short --no-merges --format='%ad %ae %s' 2019-10-31 fmayer@google.com Merge "Proto format fixes." Created with: gclient setdep -r src/third_party/perfetto@a936069d60ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ibb91572ae68b7563a8e535d8fa39c32b420cbf2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894059Reviewed-by:
-
Ken MacKay authored
When not receving into a buffer pool, it was not accounting for the padding correctly. Also, make sure connection error only happens once. Change-Id: I04d3b171828fc8f35b6cfa2ac5872e02f6f2145e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894811 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Auto-Submit: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711572}
-
Bailey Berro authored
This change hides the arrangement section of Display settings when there is only one display connected to the device. Since no action can be taken in this section when there is only one Display, we hide it to avoid wasting space. Bug: 997471 Change-Id: Idf367efbeac835b77e99b70671741a60dd42ae58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881335 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#711571}
-
David Tseng authored
Removes unneeded parameter and mistaken firing of location changes for every call to FireEvent. Change-Id: Id1e3e75980d6c3459485cb2e02dd184e499fd936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893355Reviewed-by:
-
arthursonzogni authored
To check whether the BackForwardCache is enabled or not, we choosed from the beginning not to check the content::feature directly, but use a function wrapping it. It means everyone is checking against IsBackForwardCacheEnabled() instead of using the feature::kBackForwardCache flag. The goal was to be future-proof. If the decision should not be entirely based of the feature flag, we would just have to update the implementation of the function instead of every callers. One future patch: https://chromium-review.googlesource.com/c/chromium/src/+/1875091 will modify the implementation of this function. So far so good! The problem is that patch: https://chromium-review.googlesource.com/c/chromium/src/+/1654739 landed using the content::feature directly instead of the "canonical" function. It means the blink/ part may be using the BackForwardCache while the content/ isn't. Moreover, this might forces users with low-memory devices to be reported in one of the enabled or control group. Bug: 511340 Change-Id: I68da6c7ca4cd48716b9ba092a0c5d84bb59b7073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893262Reviewed-by:
-
Jinsuk Kim authored
The public method is used for test only. Moved it to ChromeTabUtils, one of the call sites. Bug: 995903 Change-Id: Icc03cefc3b289a5fb20722d4aec77c2f4755ba08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888862Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#711568}
-
