- 22 Jan, 2021 40 commits
-
-
Miriam Polzer authored
A recent bug (crbug/1155533) caused enrollment failures because StorePolicyEx took longer than expected. Record timings for StorePolicyEx to find a reasonable timeout value (or reset it to default). Bug: 1166126 Change-Id: I00376aa1057998f5d2887f71e0fa20285775d335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639838 Commit-Queue: Miriam Polzer <mpolzer@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#846050}
-
Rushan Suleymanov authored
OnDeviceInfoChange() should be called on each change of the device info list. Some observers expect that this callback will be invoked on each change, even after loading from the persistent storage when the list hasn't been actually changed on browser startup. This CL slightly changes this behaviour. Observers will be notified when the metadata is fully loaded and the local device hasn't been changed. Bug: 1023457 Change-Id: I8012e5dda272bab7d218d9d51dca6ca5af5053ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633623 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#846049}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ic1dc22536f9073029518170554c4a372d192909c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644486Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846048}
-
Greg Guterman authored
linux-rel-rts is directly comparable to linux-rel, except it has rts. Bug: 1159191 Change-Id: I36c4a63c7b86ea60eeb4f1f3da81dcee1156bf6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630246 Commit-Queue: Gregory Guterman <guterman@google.com> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#846047}
-
Christos Froussios authored
It is flaky Change-Id: I0a1f011768ddef79c16bd0945231fe3b96dd7146 BUG: 1168464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640037Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#846046}
-
Maksim Moskvitin authored
Bug: 1152279 Change-Id: Ib6e9b3f4987fe7c39d372059db2b775540c197d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643318 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#846045}
-
Greg Thompson authored
r830353 tried to reduce refcount bumps, but perhaps that was wrong. R=fdoray@chromium.org Bug: 1156603 Change-Id: Ib9a3daa6ea1f087fef14ddeb5e49e74ef875dba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596305 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#846044}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3f555b808fbf..b6e28b60dec0 2021-01-22 chrche@microsoft.com [Loc] Migrate css_overview to localization V2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0a8e0cf9f550daede1b051a78d9794ad44411a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644487Reviewed-by:
-
Simon Zünd authored
The test expectation now account for the recently added Trust Token panel. R=sigurds@chromium.org Bug: chromium:1126824 Change-Id: I63ee32f88bd8ac3772cdbb4579f8fb2475ab3814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644616 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#846042}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I4bc6a1588542d3fcbb33d6ad81f4763a0c604215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643184Reviewed-by:
-
Luca Hunkeler authored
When the script enters an error, we automatically append a "Send Feedback" button. Bug: b/173401004 Change-Id: I62b47a0fb2f332cf74d4aaa1f287d1452c588d42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575034Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#846040}
-
Maksim Moskvitin authored
Bug: 1152279 Change-Id: I852b35673e8f5fcf8fa71bcf90f8cd26a3d7c6d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642683 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Aya ElAttar authored
- Added warn as one of the restriction levels, and add the required unittests. - Renamed the urls and patterns in the unittests to reduce confusion. Bug: 1169080 Change-Id: I806d1fb7aa8a4c94cd47b02e5be3a8636b2e26ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642776 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#846038}
-
Maksim Moskvitin authored
Bug: 1152279 Change-Id: I82e09683a3af5ed10e1653cc2f743c1a5c639346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643278 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Victor Hugo Vianna Silva authored
This CL attempts to make the implementation of this class clearer via some renames, added comments and other minor changes. Some related code in SyncSettingsUtils is also touched: - Rename SyncSettingsUtils.getMessageId() to make it clear the returned value is the same as the sync status summary used in settings, only restricted to the special case of auth errors. The signature is also made more consistent with other methods in the same file. - Use Context.getString() consistently in getSyncStatusSummary(), rather than alternate between this and Resources.getString(). - Add more protective code to getSyncStatusSummaryForAuthError(). The method now guards against the case of no error, or an unknown auth error being passed. This doesn't influence any of the existing callsites. Bug: None Change-Id: I30dd52d2a3af66cc62e2037bc94bd1738f109766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632751 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#846036}
-
chrome://appsdpapad authored
Previously because of the long history of this page (which at some point served as the NTP, aka NTP4) it was served by a custom class which delegated logic to NTPResourceCache. There is no good reason to use the NTPResourceCache for chrome://apps anymore, AFAIK. Using a WebUIDataSource makes a lot of things simpler, like registering resources, localized strings, load time data, and many more. This is in preparation of possibly migrating chrome://apps to JS modules (TBD). Regardless, moving away from NTPResourceCache is a positive step. Bug: 1168053 Change-Id: If82d634c8d7e699dc1c906517c23c40bfaa0b6b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629855Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#846035}
-
Antonio Sartori authored
This is a refactoring converting the class content::FrameReplicationState to a mojo struct, allowing to get rid of some legacy IPC traits. Bug: 1165841 Change-Id: I76e32f3e05db77685e35f3ed93d64ebd1e859588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640116 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#846034}
-
Hiroki Nakagawa authored
This CL mechanically renames classes as follows: - PrerenderContents to NoStatePrefetchContents - PrerenderContentsDelegate to NoStatePrefetchContentsDelegate - ChromePrerenderContentsDelegate to ChromeNoStatePrefetchContentsDelegate Design doc: https://docs.google.com/document/d/1e_8buEEhqgY72R2_kjGC3ChBRbA9lt5jEAZr8RLc-5Q/edit?usp=sharing Bug: 1144577 Change-Id: I3d7aeb8479a2d0e96a0a99a22dd4806a4487becd Tbr: kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640313 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#846033}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611262248-acebbca4ed738fd78c31627253df071e74108512.profdata to chrome-win32-master-1611284384-cbab22d10b31440218b066d1280e2c1fdae62cdc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9235239284fd023162dee74dfb4a9ba40dce3bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643527Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1611272973-8e4032da22e18455d35fc6237c90007c71899d37.profdata to chrome-linux-master-1611294737-27b810d0fa6cfabfc1ee245c9b50455ece63f3ea.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I90366396f29a33c8f6cffb18558add5e93d6d1b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643472Reviewed-by:
-
Benoit Lize authored
This reverts commit bb25c608. Reason for revert: WIP DO NOT LAND Original change's description: > Revert "[PartitionAlloc] Better freelist corruption detection." > > This reverts commit ac10443d. > > Reason for revert: Probably breaking mini_installer_tests and ProcessSnapshotTest.CrashpadInfoChild > https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/112543 > > Original change's description: > > [PartitionAlloc] Better freelist corruption detection. > > > > Some PartitionAlloc crashes are likely due to freelist > > corruption. PartitionAlloc has two types of freelists: in the central > > allocator, and in the thread cache. The central allocator one already > > has a DCHECK() to verify that subsequent entries belong the same > > superpage, which doesn't hold for the thread cache freelists. > > > > This CL: > > - Makes these crash lead to a NOINLINE function > > - Add an interity check to all freelists. > > > > This is not meant to be a security mitigation, but to prevent against > > accidental issues. > > > > Bug: 998048 > > Change-Id: I21aedfe2b6363069362514a8edd6cd5bdea1acfc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582218 > > Commit-Queue: Benoit L <lizeb@chromium.org> > > Reviewed-by: Chris Palmer <palmer@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#840587} > > TBR=palmer@chromium.org,haraken@chromium.org,lizeb@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: Idd7f8213dae35146d4ada835cd443505f88749ce > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 998048 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612968 > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840622} TBR=palmer@chromium.org,haraken@chromium.org,lizeb@chromium.org,mstensho@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because this is a reland. Bug: 998048 Change-Id: I799d98335b5617d52a3eeb1e254d64f487144f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613267Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#846030}
-
Jason Lin authored
This CL does not change the logic, but moves notification controlling logic into VmInfo. The reason is that we are going to implement some notification debounce logic into each VmInfo. This makes thing a bit simpler. It also merges `VmNotificationObserver` into `VmInfo` because we don't really need a separate class. A few notes: * `vm_info_map_`'s type is changed from `base::flat_map` to `std::map` because VmInfo is not copyable now. * VmCameraMicManager::{Open,Close}Notification() is moved into `VmInfo` with only some trivial changes. Bug: b/167491603 Change-Id: Ib41f68c67887e71563b90aeda37ef54ee60b1138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641827 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#846029}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dc8ef8034344..5b2a5204087d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9bc6597dffd08b06b081bec61ae72f7821db65c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643034Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dc8ef8034344..5b2a5204087d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If33e7c1f6087cf1f80863b34d66014b0b34211ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643867Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1611272973-25501ceb667d7bff805b8f0169ae53268fd6f0a5.profdata to chrome-mac-master-1611294737-a15fe97a1063cd1d1146cd301b05a844b1e4cfe8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib5baf9b50bbe08ecfaca4e9f4baafacadc17e010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643474Reviewed-by:
-
Michael Lippautz authored
- Introduce LivenessBroker - Fix IWYU - Fix LSAN scope Bug: 1056170 Change-Id: I7e685d0833932fa0e3e1a14dcf64e1fc48349461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642334 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f84a78cf..49fd77f3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifd722d57067d0ae971a2321dcaa5ce067243d62e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643035Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846024}
-
Aya ElAttar authored
- Added the required strings for the clipboard warning bubble. - Created the warning bubble which should be shown before paste. Bug: 1167228 Change-Id: If4563426fff95ab74722e41283c7184b2a6929c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637639 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
-
Colin Blundell authored
When SafeBrowsingTokenFetchTracker is destroyed, it runs all of its outstanding client callbacks. However, when an access token is fetched SafeBrowsingTokenFetchTracker calls the corresponding client callback (which is a base::OnceCallback) *before* it removes that callback from the set of outstanding callbacks. The combination of these facts means that if the SafeBrowsingTokenFetchTracker is destroyed from within a client callback, a crash will occur. This indeed occurs in production (see crashes linked in bug, and note that this is behavior that dates back from the introduction of this code in SafeBrowsingTokenFetcher). This CL adds a test that exhibits the problematic flow and fixes the crash by removing the callback from the set of outstanding callbacks *before* running that callback on access token fetch. The test crashes without the fix. Bug: 1168599 Change-Id: I006bde8e48531b9912fa779a5c6c6a27acaf6fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640375Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#846022}
-
Rushan Suleymanov authored
This CL slightly optimizes the code by changing the order of some operations during the initial merge. When trying to find the local matching node by semantics, the new order is: check matching GUID, check URL and then check for the same title (before current CL the order was reversed). In the real scenarios it should be more efficient because most of bookmarks already have GUID. This CL doesn't change behaviour. Bug: 1163257 Change-Id: If9a2371c7c3f28962c8565513487175482ce4104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640398 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#846021}
-
rbpotter authored
No more need to manage a top toolbar, so support only a zoom toolbar in the toolbar manager. Also move toolbar manager to Print Preview build only, and move corresponding test to c/t/d/webui/print_preview. Remove isPrintPreview property from the zoom toolbar and related styles. Bug: 1164004 Change-Id: Icdc1eb894195d09d9913383c62d34786afcdee42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644291 Auto-Submit: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#846020}
-
Tomasz Śniatowski authored
Add a null check in DownloadAsStreamBodyHandler::Resume to protect against a rare case where Resume is called right after hitting the timeout. To demonstrate the crash, add a unit test that explicitly keeps hold of the resume closure until after a timeout is hit. Without the added fix, the test crashes accessing body_reader_. While it looks odd in the test, this case seems possible in valid-looking SimpleURLLoaderStreamConsumer code that happens to get tasks queued in an unlucky way right when the timeout is hit. Credit to mruszczynski@vewd.com for investigation and initial UT. Bug: 1169018 Change-Id: Iff38fb1e3a4404ae006e1f6b76479cdf6ffafa85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641033 Commit-Queue: Tomasz Śniatowski <tsniatowski@vewd.com> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Tomasz Śniatowski <tsniatowski@vewd.com> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#846019}
-
Mitsuru Oshima authored
Bug: b/169014289 Test: covered by unittest Change-Id: I769addac4e172eb16d5c363c8edca96c1877a346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637415Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#846018}
-
Corentin Wallez authored
While compiling Dawn with MSVC python3 complained that startswith's arguments needed to be bytes. Bug: None Change-Id: Id6d1a1d536e4e235eacf1818d31e59a6b5b7e122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643277 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611262248-73432c89b66dbe2013eb2cab3a4d4391b3f9edd9.profdata to chrome-win64-master-1611284384-7c6617d93ef1b9fc70abe71fb9acc556bc65d8e5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If2010c143857e639ce9e9bf8a93bc693064ee3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643524Reviewed-by:
-
Ken Rockot authored
Bug: 1004256 Change-Id: Iabfb2720513f11d539b51458e87a323e95f4b513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640932Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#846015}
-
John L Chen authored
They are not being used. BUG=b:177880754 TEST=build & unit tests Change-Id: Ice1d862d56cc6ebdb288515d7f941330e201ace6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639069 Commit-Queue: John L Chen <zuan@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#846014}
-
Michael Lippautz authored
Add mlippautz to - blink/ for BlinkGC.* - v8/ for general reviews Change-Id: I6957c8cdbb7e7dc9ecbd60e39192ba095aff3730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642324Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/57fd09e1aad2..9a1550b6e356 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yosin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yosin@google.com Change-Id: I2fb7fae41e7dfa6b56042c0b82b0152b3f0fd413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643470Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846012}
-
Peter E Conn authored
Change-Id: Ib05e1ed766a8348086bda2e794d37823764c1858 Bug: 1146206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642361Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#846011}
-
