- 03 Dec, 2018 40 commits
-
-
Mike Wasserman authored
Register Ash's root windows and aura::Env in single-process mash. Keep a warning & TODOs for multi-process Mash ui_devtools support. Encapsulate server init and the switch and port definitions. An earlier CL was incorrect and caused a crash (uploaded here as PS1): https://chromium-review.googlesource.com/c/chromium/src/+/1324373 Bug: 896977 Test: ui_devtools works well on Chrome OS single-process Mash. Change-Id: Ie962343b1e121529933b5118791b767e80507684 Reviewed-on: https://chromium-review.googlesource.com/c/1334006 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#613278}
-
Thomas Guilbert authored
This CL turns on the new RemotePlayback pipeline by default. There are still some issues to address, but none of them are blocking. Due to the relatively small use of this feature, it is best to turn the feature on by default, to get the coverage we need. The extended period of time between M72 branch cut and M72 stable cut will be used to merge back any unforeseen regressions that pop-up. NOTE: This change might lead to regressions or improvements of various tests. Bug: 790766 Change-Id: I3e2ed2073da6a28b5ec6cb1ee6d2dd1851df1fde Reviewed-on: https://chromium-review.googlesource.com/c/1338887 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#613277}
-
Roger McFarlane authored
This CL adds unittests which validate that a collection of independent randomized encodings of a given input string can be decoded to recover the portions common to most/all users. Bug: 896719 Change-Id: Ibe3305b62ddcf643bef6979589a1011427cfcbd2 Reviewed-on: https://chromium-review.googlesource.com/c/1357642 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#613276}
-
Eric Karl authored
Fixes two small issues preventing SkiaRenderer from running on Android: - Enablment flags not forwarded via RendererSettings. - gles2::FeatureInfo not available on SkiaOutputSurfaceImplOnGpu. Bug: 809726 Change-Id: I66de6c577eaa4d4b1eb6e6ae45c5036ae0b098f0 Reviewed-on: https://chromium-review.googlesource.com/c/1352248 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#613275}
-
Anastasia Helfinstein authored
Bug: None Change-Id: I9ffe55a11ba54c6c56694b166b762254cc19d4c1 Reviewed-on: https://chromium-review.googlesource.com/c/1355919Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#613274}
-
Antoine Labour authored
Bug: None Change-Id: Icb435aae59f43ace9c52af6a67ddcb331181ad91 Reviewed-on: https://chromium-review.googlesource.com/c/1359318Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#613273}
-
Brian Sheedy authored
This reverts commit 06b8660d. Reason for revert: Hitting DCHECK: [FATAL:latency_tracker.cc(399)] Check failed: (event_timestamp - last_event_timestamp_).InMilliseconds() >= 0 Original change's description: > Use mocked VR controller for scrolling > > Switches all VR instrumentation tests for scrolling using the Daydream > controller to use the Chrome-side controller mock instead of the > VrCore-side emulation via intents. The latter has always been somewhat > flaky, so this should help reduce VR test flakiness. > > Bug: 902938 > Change-Id: I560cda2129357c49bdfa3d095836e6ebd1b23da8 > Reviewed-on: https://chromium-review.googlesource.com/c/1341061 > Reviewed-by: Christopher Grant <cjgrant@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Commit-Queue: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#613107} TBR=vollick@chromium.org,cjgrant@chromium.org,bsheedy@chromium.org Change-Id: I40d8cf660d35a14ee4269010f5da749a2e91daad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902938 Reviewed-on: https://chromium-review.googlesource.com/c/1359311Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#613272}
-
Bailey Berro authored
This change removes the attached method override from the smb-share-dialog component. Bug: chromium:887135 Change-Id: Id6a7b06a2b2b9ea4d0da5dc04cb14f7143c0c312 Reviewed-on: https://chromium-review.googlesource.com/c/1340860 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#613271}
-
Gauthier Ambard authored
This CL removes the cap on the font size used to display the instructions on the empty TableView background in ReadingList. Bug: 911174 Change-Id: Iaadd7cd0e9d070a0052847daa513e3f1ae1b50b7 Reviewed-on: https://chromium-review.googlesource.com/c/1358465 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#613270}
-
Lei Zhang authored
PrinterCapabilitiesTest is in printer_capabilities_unittest.cc inside components/, but is not built as part of components_unittests. Instead, it it built as part of components_browsertests, but does not appear in the list of tests. Fix the build rules so it builds in components_unittests as a proper test. Move printer_capabilities_unittest.cc next to printer_capabilities.cc. Change-Id: I6be9606a97968e26de5528ee395e044d92f1ed9c Reviewed-on: https://chromium-review.googlesource.com/c/1357616Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#613269}
-
Jinsuk Kim authored
https://crrev.com/c/1135874 left out checking gamepad events by mistake. This CL fixes it by adding the check against GenericMotionEvent in the content ui event handler. Tested on https://html5gamepad.com with a USB gamepad. Bug: 906347 Change-Id: I2bd0890f2533e70a772dbb0b005d69bf086d1595 Reviewed-on: https://chromium-review.googlesource.com/c/1356727Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#613268}
-
rbpotter authored
- Delete ticket items and other unused files in data/ - Complete TODOs in handler - Remove unused strings Bug: 908705 Change-Id: Ie02a00ad6b8ada56b3d327d75e2ad841e534cb9f Reviewed-on: https://chromium-review.googlesource.com/c/1357527 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#613267}
-
braveyao authored
This checkbox is set as checked by default at present. With some new features, as getDisplayMedia and dynamic change capture source, it's more reasonalbe to set it as unchecked by default. Also it will help to count the requirement of audio capture during presenting. Bug: 892201 Change-Id: I36c253bf1c862a31d99927be79c2072332cb1622 Reviewed-on: https://chromium-review.googlesource.com/c/1356713Reviewed-by:
Qiang Chen <qiangchen@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#613266}
-
Danyao Wang authored
This makes it more clear which WebStateObserver callbacks are called when. This change does not contain any function changes. Bug: 903497 Change-Id: Ie774c191ffc2681a7cf1df90089ea25e90a381ac Reviewed-on: https://chromium-review.googlesource.com/c/1359296Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#613265}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f1684ef61ea6..eec53b64a610 git log f1684ef61ea6..eec53b64a610 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 djmm@google.com Update luci schedule with M72 branch info Created with: gclient setdep -r src/third_party/chromite@eec53b64a610 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic6e1cf287cd77d28501648600c530f725c6569d4 Reviewed-on: https://chromium-review.googlesource.com/c/1358807Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613264}
-
jonross authored
RenderWidgetHostViewBrowserTestBase.CompositorWorksWhenReusingRenderer was disabled due to high flakiness on Android. However the bug report is older, and the logs are all gone. I cannot reproduce the flakes locally. Going to speculatively re-enable to see if the flakes are gone. If not I'll at least have error stacks to go off of. TBR=samans@chromium.org TEST=RenderWidgetHostViewBrowserTestBase.CompositorWorksWhenReusingRenderer Bug: 896466 Change-Id: Ifa2abecc2c429641a10519c866294edce5354820 Reviewed-on: https://chromium-review.googlesource.com/c/1359050Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#613263}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/056f9738bf7a..ec0f45be1144 git log 056f9738bf7a..ec0f45be1144 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 solenberg@webrtc.org Revert "Remove CodecInst pt.1" 2018-12-03 gustaf@webrtc.org AEC3: Fix ENR threshold for WebRTC-Aec3UseLegacyNormalSuppressorTuning Created with: gclient setdep -r src/third_party/webrtc@ec0f45be1144 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:911141 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Idd7032f0791826747a1499fd8112dafb701551ef Reviewed-on: https://chromium-review.googlesource.com/c/1358761Reviewed-by:
-
Jan Krcal authored
This CL adds two more sync integration tests for autofill wallet sync. Bug: 894001 Change-Id: I00e1db0e44aba311a0872e88eddf50f395d33fb7 Reviewed-on: https://chromium-review.googlesource.com/c/1358508 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#613261}
-
Mohamed Amir Yosef authored
Bug: 911232 Change-Id: I4813401d73ae6281fd044882c8e61869223c0911 Reviewed-on: https://chromium-review.googlesource.com/c/1359034 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#613260}
-
Lei Zhang authored
Give setup() a more distinctive name, and add a missing <html> tag. Change-Id: I81e42c231afdce5cf574e14927621a959c19c5b1 Reviewed-on: https://chromium-review.googlesource.com/c/1357728Reviewed-by:
-
Jan Wilken Dörrie authored
This change modifies the people section to only show the "Manage other people" row on Chrome OS. On other platforms this option will still be accessible from the Profile Chooser. Bug: 907035 Change-Id: I7c2ab9ee97658e37a11f9d9a6d9ac0736ed2a1d2 Reviewed-on: https://chromium-review.googlesource.com/c/1349336Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d2eb15071cfa..1fbed8388ab1 Created with: gclient setdep -r src-internal@1fbed8388ab1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I07138aaaa4a8026fd7403d0288acf6c2d3c5bde8 Reviewed-on: https://chromium-review.googlesource.com/c/1358760Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613257}
-
sczs authored
- Renames TableViewAccessoryItem/Cell to TableViewImageItem/Cell, and adds a property that makes the chevron optional. - Adds tests for the new behavior. - Uses this new property to hide the chevron on Show Full History in Recent Tabs. Bug: 910738 Change-Id: I9aeee17ebab52cbfcedb1c56b5e54221a5d7b2dd Reviewed-on: https://chromium-review.googlesource.com/c/1358967Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#613256}
-
Christopher Cameron authored
This is a step toward supporting shortcut keys and menu interface items in PWAs. This breaks the function -[BrowserWindowCommandHandler validateUserInterfaceItem] into two parts - The part to look up the browser command and to update the interface item still remains in BrowserWindowCommandHandler (which will be in the in the PWA process). - The part to access the Browser*, which will be in the browser process, which is - routed through mojo to the BridgedNativeWidgetHostImpl - to the NativeWidgetMac - which is subclassed as BrowserFrameMac - which calls BrowserWindowCommandHandlerValidateUserInterfaceItem to implemented the parts that used to be in BrowserWindowCommandHandler Also add required interface to look up a BridgedNativeWidgetImpl from an NSWindow. Bug: 895169 Change-Id: Ie81a1e5a44537b07183d4c29b89d2da1951137c0 Reviewed-on: https://chromium-review.googlesource.com/c/1357829 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:Robert Sesek <rsesek@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#613255}
-
Ivan Sandrk authored
Locked fullscreen is supposed to be a secure mode where the user cannot do anything outside of the current browser window, but ARC apps can currently draw on top of it. To fix this, we disable ARC when entering the mode, and we re-enable it upon exiting the mode. Bug: 888611 Change-Id: I84cda87a260a42108f1ef6c4767c174bc8b1fb61 Reviewed-on: https://chromium-review.googlesource.com/c/1356813Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#613254}
-
Chris Palmer authored
A foolish consistency is the hobgoblin of little minds. #welp Bug: None Change-Id: Ia174e3fa99252a7931429c22d769872bc2f0c3bd Reviewed-on: https://chromium-review.googlesource.com/c/1357625 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#613253}
-
Dana Fried authored
Also removes code associated with "show close button on hover" in non-touch situations because showing of close button on inactive tabs is now purely a function of tab size and the code had no effect. Previously, tabs were relying on invalidation of the tabstrip to repaint when active status changed. This resulted in cases where when the number of tabs at minimum size exceded the size of the browser window, pinned tabs would not repaint when a new tab was added, resulting in them appearing to still be active (until something else invalidated the tabstrip, like a mouse event or resize). Now we're using InvalidateLayout() and SchedulePaint() correctly to make sure things which could change the render or layout state of a tab result in the tab being laid out and/or repainted. Bug: 896849 Change-Id: If2fcdafe80a0d22dc1d7c5c2c4a703729b8ed55b Reviewed-on: https://chromium-review.googlesource.com/c/1357329 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#613252}
-
Eric Foo authored
This is a reland of 7d53bc24 Original change's description: > Remove incorrect named builders ("_" underscores) > > Bug: 868202 > Change-Id: I807807511df39b7a4eac3b699fcd2274d4d24138 > Reviewed-on: https://chromium-review.googlesource.com/c/1343081 > Reviewed-by: Ryan Tseng <hinoka@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Eric Foo <efoo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609559} Bug: 868202 Change-Id: I26a75c2226e910637c677b28598865ad31fb67e2 Reviewed-on: https://chromium-review.googlesource.com/c/1357720Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#613251}
-
Philip Rogers authored
In https://crrev.com/612683 the blink-gen-property-trees flag was changed from --enable-blink-gen-property-trees to --enable-blink-features=BlinkGenPropertyTrees. This patch updates the bot configuration to use the new flag. Bug: 910859 Change-Id: I75bd3b947cf6fe5e8ec43a34a60e9cb7d61152c5 Reviewed-on: https://chromium-review.googlesource.com/c/1359131Reviewed-by:
-
Ovidio Henriquez authored
The small-caps-aat.html was failing on the WebKit Mac10.13 (retina) builder. Tbr: drott@chromium.org Bug: 910263 Change-Id: Idbe95ab8055f53b777c03c7e6a5d283abf691074 Reviewed-on: https://chromium-review.googlesource.com/c/1359063Reviewed-by:
Ovidio Henriquez <odejesush@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#613249}
-
Martin Kreichgauer authored
The Windows WebAuthNGetAssertion API call allows setting the allow list parameter via two separate fields/types: `WEBAUTHN_CREDENTIALS CredentialList` and `PWEBAUTHN_CREDENTIAL_LIST pAllowCredentialList`. The latter is newer and allows setting transport restrictions on each credential descriptor. However, using it appears to prevent GetAssertion from falling back to the CTAP1 device protocol in cases where (a) the authenticator does not speak CTAP2, or (b) it speaks CTAP1 and CTAP2 but the credential was created via CTAP1. This change works around the issue by using the older field instead. WebAuthNMakeCredential does not seem to suffer from the same issue and reliably sticks to U2F if the authenticator is CTAP1-only or dwAuthenticatorAttachment is WEBAUTHN_AUTHENTICATOR_ATTACHMENT_CROSS_PLATFORM_U2F_V2. Hence, nothing changes for it. Bug: 898718 Change-Id: I5e06cd48a3dd424b4763753d8e4d41d8c6680c68 Reviewed-on: https://chromium-review.googlesource.com/c/1357621 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#613248}
-
Becca Hughes authored
This adds MEIPreload version v1.0.4.0 to Chromium so that it is boostrapped with new installs. BUG=910647 Change-Id: I5b8128a7043b30610c3a62ea6c3f71adc96dbf89 Reviewed-on: https://chromium-review.googlesource.com/c/1357299Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a44efb76a8a4..0cfefd1a1e98 git log a44efb76a8a4..0cfefd1a1e98 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 tsepez@chromium.org Replace wide literals with narrow ones in WideTextBuf operations. Created with: gclient setdep -r src/third_party/pdfium@0cfefd1a1e98 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id61ea4ba07b8b4ecc9e7455a9b00017f1af0d2e5 Reviewed-on: https://chromium-review.googlesource.com/c/1358806Reviewed-by:
-
Kevin McNee authored
Unlike touchscreen pinch events, touchpad pinch events don't occur within a gesture scroll sequence. If a touchpad pinch update couldn't be directly coalesced with a previous pinch update, we now just enqueue the pinch update rather than producing a scroll update. We also now allow for pinch updates to be coalesced if their anchors are approximately equal to accommodate OOPIF coordinate conversion imprecision. Bug: 897791 Change-Id: I3331fc5761b5ca11d4b05386e5ab4468ac2291d7 Reviewed-on: https://chromium-review.googlesource.com/c/1349851Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#613245}
-
Jacob Dufault authored
Reason for revert: the failing test was flaky without this change and has since been disabled (crbug.com/911154) Original change's description: > Revert "cros: Remove WizardInProcessBrowserTest" > > This reverts commit 92925c66. > > Reason for revert: WizardControllerDeviceState*Test timing out on linux-chromeos-dbg > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9248 > > rowserTestBase received signal: Terminated. Backtrace: > #0 0x7feb2e8b3fed base::debug::StackTrace::StackTrace() > #1 0x7feb2e5addfa base::debug::StackTrace::StackTrace() > #2 0x563fac6dc0f2 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #3 0x7feafb349cb0 <unknown> > #4 0x7feafb4116d3 epoll_wait > #5 0x7feb2e96353f epoll_dispatch > #6 0x7feb2e956cc5 event_base_loop > #7 0x7feb2e9073c9 base::MessagePumpLibevent::Run() > #8 0x7feb2e63fbe6 base::MessageLoopImpl::Run() > #9 0x7feb2e6eb322 base::RunLoop::Run() > #10 0x563fa6018304 chromeos::WizardControllerDeviceStateTest::WaitForAutoEnrollmentState() > #11 0x563fa5ffeb8f chromeos::WizardControllerDeviceStateExplicitRequirementTest_ControlFlowForcedReEnrollment_Test::RunTestOnMainThread() > > Original change's description: > > cros: Remove WizardInProcessBrowserTest > > > > The base class convoluted the inheritance structure and it is simpler to > > directly derive from InProcessBrowserTest. > > > > Bug: 899777 > > Change-Id: I04b8e4d48d0a28a8d4481891d5379456df32d0d6 > > Reviewed-on: https://chromium-review.googlesource.com/c/1345244 > > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#612394} > > TBR=xiyuan@chromium.org,emaxx@chromium.org,jdufault@chromium.org > > Change-Id: I06cfea778c8246795a8bb8fdc9878812a1ab5d52 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 899777 > Reviewed-on: https://chromium-review.googlesource.com/c/1356168 > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612523} TBR=xiyuan@chromium.org,emaxx@chromium.org,jdufault@chromium.org,ortuno@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 899777 Change-Id: Id6a54d588736969830db39963f5cc4560d1068b9 Reviewed-on: https://chromium-review.googlesource.com/c/1359135Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#613244}
-
khachatryan authored
We are adding ChromeDriver support for Chrome v72 and dropping support for Chrome v69 Change-Id: I3424e451bf596eeab5052cbe6f1c79557d11649b Reviewed-on: https://chromium-review.googlesource.com/c/1359061Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#613243}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/45723ac93149..0a1293c2e432 git log 45723ac93149..0a1293c2e432 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 kjlubick@google.com [canvaskit] Add drawImage support 2018-12-03 michaelludwig@google.com Reland "Share GP implementation between GrFillRectOp and GrTextureOp" 2018-12-03 michaelludwig@google.com Reland "Send max coverage limit for subpixel rects" 2018-12-03 reed@google.com change Run to store bool_aa instead of flags_only_aa 2018-12-03 herb@google.com Make fallback descriptors explicit 2018-12-03 egdaniel@google.com Pass in actual sampled texture and sample params to gpu uniform builders. 2018-12-03 mtklein@google.com clean up TODO Created with: gclient setdep -r src/third_party/skia@0a1293c2e432 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I8e5a2dd701200e72caa27b7b89100345795f6ad4 Reviewed-on: https://chromium-review.googlesource.com/c/1358805Reviewed-by:
-
Sergey Ulanov authored
content_unittests are failing on Fuchsia. TBR=thakis@chromium.org Bug: 910029 Change-Id: Ie567ad03904e3ec27143c3a1bec1a86562c74c18 Reviewed-on: https://chromium-review.googlesource.com/c/1359057Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#613241}
-
Lukasz Anforowicz authored
The test has been fixed in r613184 and therefore doesn't need separate expectations for site-per-process and not-site-per-process. Therefore this CL removes this test from virtual/not-site-per-process suite. Bug: 619662 Change-Id: Idf80b42401df5aa0c78c5b76654a9915e111bfe2 Reviewed-on: https://chromium-review.googlesource.com/c/1359090 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#613240}
-
Erik Luo authored
Keyboard navigation in Console presents new interactions that our stick-to-bottom (STB) logic should care about. Prompt - Before, STB only cared about TextChanged events, but now cares about focusin, since users can Tab from messages to prompt Objects - Expanding an object results in noticeable scroll-anchoring jumps, STB should turn off due to expanding. Expanding a small object that can fit in viewport should guarantee it is visible. Bug: 865674 Change-Id: I47872110d4bf2261b4940b565f8c926333b66836 Reviewed-on: https://chromium-review.googlesource.com/c/1330350 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#613239}
-
