GitLab

Bug: 878541
Change-Id: I2501fa03d737154697346a76c1a7e20758debd7f
Reviewed-on: https://chromium-review.googlesource.com/1214075Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590018}

Give the info button a label read by screen readers when it is in focus:
"No Cast destinations found. Need help?"

Bug: 869600
Change-Id: I90af935d528f7aa128469b98ecb691f6d13228a0
Reviewed-on: https://chromium-review.googlesource.com/1214044Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590017}

Problems have been fixed by:
- https://webrtc-review.googlesource.com/97620
- https://webrtc-review.googlesource.com/97622

Bug: 824831
Change-Id: Ibe2f12f6d935c61a37cd253d22960a1ccba9f50a
Reviewed-on: https://chromium-review.googlesource.com/1203773Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590016}

The access patterns work fine with std::vector. There is no need to use
std::list. Make changed files free of lint and presubmit errors as well.

Change-Id: I7cbc19dde51c3c400a55263771b7322709b266bf
Reviewed-on: https://chromium-review.googlesource.com/1215051Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590015}

Replaced deprecated WaitUntilCondition with WaitUntilConditionOrTimeout
(the former method wait 2 days before DCHECKing).

Replaced DCHECK with EXPECT in test helper.

Bug: 784735
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I823b1671280ed4d52133009af75691c044c06f9e
Reviewed-on: https://chromium-review.googlesource.com/1212267Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590014}

These are used from chrome, so they need to sent over as properties.

BUG=none
TEST=none

Change-Id: Ia06f53ae461cff7b5c3f7af87ab4200839dd81bd
Reviewed-on: https://chromium-review.googlesource.com/1212707
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590013}

This reverts commit 17500caa.

Reason for revert: Tests do not pass in official builds (https://crbug.com/882397)

Original change's description:
> [tabCapture] add a new getMediaStreamId method
>
> This cl is to add a new getMediaStreamId method to tabCapture API.
> The object is to offer easy access to the content of current tab for
> sharing/recording together with mic/cam by web apps, by returning an
> encrypted device id from extension to web app.
> See design doc: https://docs.google.com/document/d/1YWFmFJaN-bbAxh01JP5qczERW9vda62vLInO32WvCM8/edit?ts=5ac7ebd8
>
> TEST = autotests and a modified tab_capture example.
>
> Bug: 867533
> Change-Id: I03283b2c6ce5187224e45370f8ca9b27881d570a
> Reviewed-on: https://chromium-review.googlesource.com/1167659
> Commit-Queue: Weiyong Yao <braveyao@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: Yuri Wiitala <miu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589762}

TBR=miu@chromium.org,rdevlin.cronin@chromium.org,braveyao@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 867533, 882397
Change-Id: Ie45fd4c08a07b1c1b45e36be144340a7e8d8c1df
Reviewed-on: https://chromium-review.googlesource.com/1216807
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590012}

Currently, we have different behaviors for the "having a provisional
document loader" state versus the "having a queued navigation" state. In
the first case, we call FrameLoader::StopAllLoaders(), which cancels the
ongoing navigation as well as fetches on the current page (e.g.
XMLHttpRequest). In the second, we merely cancel the task to navigate,
but do NOT cancel fetches.

Indeed, it is recognized that the spec is currently unclear about
canceling queued navigation vs. direct navigation (see [1]). However, it
is worth noting that Chrome does not always follow the spec with this
distinction in the first place (through location.href, for example,
which queues a navigation task in Chrome but navigates directly in
spec).

Additionally, since even the current code cancels navigation in both
circumstances (the only disagreement being if peripheral fetches are
also canceled), we see no reason to have an inconsistency in this regard
(see [2]).

This CL now always calls FrameLoader::StopAllLoaders(), for both when we
have a provisional loader and when we have a queued navigation, thus
ridding ourselves of the inconsistency.

By doing so, we implement the "ideal 2" plan laid out in [2], which
recently became part of the HTML Standard in [3]. Tests for this new
behavior (which this CL fully passes) are in [4], which was imported
into our tree by the WPT Importer bot, whose expectations this CL now
change.

[1]: https://github.com/whatwg/html/issues/3447
[2]: https://github.com/whatwg/html/issues/3975
[3]: https://github.com/whatwg/html/pull/3999
[4]: https://github.com/web-platform-tests/wpt/pull/10789

Bug: 866274
Change-Id: I4e3ffac6b7c07bc8da812f6f210ab5d6933bdfd1
Reviewed-on: https://chromium-review.googlesource.com/1195837
Commit-Queue: Timothy Gu <timothygu@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590011}

Advances should be store as doubles, but the previous code
was using a float as a part of their computation.

Bug: 880169
Change-Id: I47fd70bf947c9b1e0fdb827eba69108bd938a72a
Reviewed-on: https://chromium-review.googlesource.com/1213516Reviewed-by: Stephen White <senorblanco@chromium.org>
Commit-Queue: David Quiroz Marin <davidqu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590010}

Bug: 811661
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8a6e18dd431384efd1fef06fb93beab93343e8ef
Reviewed-on: https://chromium-review.googlesource.com/1216065Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590009}

The logic for parsing intrinsicSize attribute is shared among
HTML{Image,Video}Element and SVGImageElement. Moving it to
blink/core/html/media/media_element_parser_helpers to avoidredundant
code.

Bug: 874629
Change-Id: I20e1dc6b626eb86e8919c621b1c98401eaa9d201
Reviewed-on: https://chromium-review.googlesource.com/1217163Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590008}

Method getCameraParameters() in file VideoCaptureCamera.java may return
null on failure. But several call sites assume that this never happens.
Crash reports show that it does happen.

This CL adds null checks and performs the appropriate failure action.

Bug: 879678
Change-Id: I978f45c04696c9a5b272932a945da033bafc6a77
Reviewed-on: https://chromium-review.googlesource.com/1214072Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590007}

Migrate all callers to the variant of Add() that takes std::unique_ptr.

Change-Id: I95249807357b8d8a867d509a6f45290964a40106
Reviewed-on: https://chromium-review.googlesource.com/1198569Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590006}

Bug: 832933
Change-Id: I337a74c898d55070933f73254a57d9f4ec17de94
Reviewed-on: https://chromium-review.googlesource.com/1208943Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590005}

ViewHostMsg_ResizeOrRepaint_ACK_Flags is no longer used. This removes it and
updates the comments on ViewMsg_SynchronizeVisualProperties to reflec the
current reality.

TBR=piman@chromium.org

Bug: 655231
Change-Id: I388ab96bd0bdf46a84f4e1e92bd8378fcc4dd834
Reviewed-on: https://chromium-review.googlesource.com/1216069
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590004}

1. Add query params pgcl=14 and sclient=cros-launcher for launcher queries to completion server.
2. Enable ZeroSuggestProvider to process empty queries from cros launcher.
3. The above changes are only enabled when zero state is enabled by flag, which by default is off.

Bug: 854242
Change-Id: I9ca99a668b74ab642ff1d020eb14565fb4af12ff
Reviewed-on: https://chromium-review.googlesource.com/1178971Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590003}

This reverts commit e966ecca.

Reason for revert: Broke two DumpAccessibilityEventsTest tests. See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/3172 

Original change's description:
> Emit state-changed:selected events for ATK on Aura Linux
> 
> * Add an event notifier in AXPlatformNodeAuraLinux for browser chrome.
> * Check to see if focus should follow selection. If it should, also
>   emit state-changed:focused events.
> * Ensure that the correct states (focusable and selectable) wind up
>   in the state set of elements where focus should follow selection.
> * Forward events from Blink content to AXPlatformNodeAuraLinux.
> * Create an event listener so that DumpAccessibilityEventsTest tests
>   can be run. Add expectations for tests for which events are now
>   emitted. At the present time, that is only focus and selected.
> 
> R=​dmazzoni@google.com
> 
> Bug: 866340
> Change-Id: I0d3334c39b064afc75ac5e051969fb43a79a0d8a
> Reviewed-on: https://chromium-review.googlesource.com/1163724
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Commit-Queue: Joanmarie Diggs <joanmarie.diggs@gmail.com>
> Cr-Commit-Position: refs/heads/master@{#589951}

TBR=dmazzoni@chromium.org,dtseng@chromium.org,aboxhall@chromium.org,nektar@chromium.org,aleventhal@chromium.org,joanmarie.diggs@gmail.com

Change-Id: If194799a765415ba34229b5315c54584021078e2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 866340
Reviewed-on: https://chromium-review.googlesource.com/1217069Reviewed-by: Ojan Vafai <ojan@chromium.org>
Commit-Queue: Ojan Vafai <ojan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590002}

There is no logic change - this just move the code around for
optimization.

Android's VM does run-time verification for all the methods in a class
if any of the methods fails in AOT compilation time. Therefore,
splitting out failing methods into a separate class containing it there
help reduce the overall time taken in the run-time verification.

Landing all 6 CLs saves up the startup time for WebView
(5% when locally tested), at the expense of slightly increasing method
count and increasing apk size.

See crbug.com/838702 for more information about run-time verification
issue.

Bug: 868250
Change-Id: Ibcf67a14882414a6fecad254378c9015d30cf6da
Reviewed-on: https://chromium-review.googlesource.com/1175444Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590001}

TBR=rbpotter@chromium.org

Bug: 881685
Change-Id: I26cf5783d26d7dfadd53b1db890b09d14fb09a7e
Reviewed-on: https://chromium-review.googlesource.com/1216625
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590000}

Change-Id: I8b811528e1708ac63c5ae66fff9f057e0499adec
Reviewed-on: https://chromium-review.googlesource.com/1215048Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589999}

There's been some more flakiness with VR instrumentation tests that use
the VrCore-side emulated controller. Increasing the amount of time
that's waited before sending the first input event seems to fix this
from some limited testing, so speculatively commit to see if it fixes
the issue on the bots.

Change-Id: If438358d14f410911831911a3b0880902b57ddda
Reviewed-on: https://chromium-review.googlesource.com/1217027Reviewed-by: Aldo Culquicondor <acondor@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589998}

This change updates usb_blocklist.cc with the latest devices as of this
pull request:

https://github.com/WICG/webusb/pull/149

Change-Id: I8669d03dbe2893045e77664d4fa68721d71c01d9
Reviewed-on: https://chromium-review.googlesource.com/1213938Reviewed-by: Jun Cai <juncai@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589997}

The FeedNewTabPage previously added a context menu close listener to the
WindowAndroid without removing it, causing a memory leak. Remove the
context menu close listener in #destroy().

Also make BasicSnackbarApi static so that if the Feed session cache
holds on to it the entire FeedNewTabPage isn't kept in memory.

BUG=881954

Change-Id: I55c86e66c785c7ce70157454575a16bd8e5d15c6
Reviewed-on: https://chromium-review.googlesource.com/1217102Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589996}

Add rather than replace icons since the shelf UI is still protected
by a flag and we want to keep supporting both cases for a few more
weeks.

Bug: 880598
Change-Id: If11bbad338b4113f3e9724a729451e159c4b5964
Reviewed-on: https://chromium-review.googlesource.com/1214695
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589995}

Also remove corresponding header, and add some missing headers for used
classes.

Bug: None
Change-Id: I2439a13b7995569a50a1f7f62aa5836589988c32
Reviewed-on: https://chromium-review.googlesource.com/1216622Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589994}

https://pdfium.googlesource.com/pdfium.git/+log/5fea8ca820be..a5078b7c17f7


git log 5fea8ca820be..a5078b7c17f7 --date=short --no-merges --format='%ad %ae %s'
2018-09-10 hnakashima@chromium.org Save and reload document in RemoveMarkedObjectsPrime test.


Created with:
  gclient setdep -r src/third_party/pdfium@a5078b7c17f7

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I55dfbe41082f22e43f2ae3f440342d088aa6dcd8
Reviewed-on: https://chromium-review.googlesource.com/1216804Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589993}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/25c380cf9d2d..a68660d0bb5d


git log 25c380cf9d2d..a68660d0bb5d --date=short --no-merges --format='%ad %ae %s'
2018-09-10 cwallez@chromium.org gclient: add use_relative_hooks


Created with:
  gclient setdep -r src/third_party/depot_tools@a68660d0bb5d

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:875245
TBR=agable@chromium.org

Change-Id: I25d022673caafa13a1f410b6c2a8ba5643d7766f
Reviewed-on: https://chromium-review.googlesource.com/1217144Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589992}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f62d7978fc50..75c1bf28431e


git log f62d7978fc50..75c1bf28431e --date=short --no-merges --format='%ad %ae %s'
2018-09-10 31666470+s-perron@users.noreply.github.com Add option for the max id bound. (#1870)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@75c1bf28431e

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I2d9b580568dff1ed60469876d0160007cba31c91
Reviewed-on: https://chromium-review.googlesource.com/1216862Reviewed-by: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589991}

Change-Id: I3716899d74877992ad3b85a82eda82a17dcf142e
Reviewed-on: https://chromium-review.googlesource.com/1215049
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589990}

Auto hide option is enabled in tablet mode. Thus remove this DCHECK.

Bug: None
Change-Id: I5833ed4f104dd5ba4eae589d4458ec85d774f676
Reviewed-on: https://chromium-review.googlesource.com/1216626Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589989}

https://skia.googlesource.com/skia.git/+log/cd9d074578e0..10494e34e453


git log cd9d074578e0..10494e34e453 --date=short --no-merges --format='%ad %ae %s'
2018-09-10 brianosman@google.com Restore lazy image cache key logic
2018-09-10 reed@google.com implement onMakeFromData for FontConfigInterface
2018-09-10 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 a735ee2f6df8..480edb8c1d7d (1 commits)
2018-09-10 bsalomon@google.com Relax hairline requirement that all non-quadratic cubics are split once.
2018-09-10 fmalita@chromium.org [skottie] Add support for explicit image asset sizing
2018-09-10 bsalomon@google.com Simplify GrResourceCache/GrDrawingManager flush interaction.
2018-09-10 reed@google.com Revert "remove legacy google3 flag"


Created with:
  gclient setdep -r src/third_party/skia@10494e34e453

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=caryclark@chromium.org

Change-Id: I8eeaa6a7f959a8b66d7d3be958204b844af1e6b8
Reviewed-on: https://chromium-review.googlesource.com/1217142Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589988}

ChromeVox recently began to "stutter" or duplicate output. This occurs most frequently when navigating by headings.

The underlying issue.

ChromeVox requests focus whenever it navigates. This, in turn, triggers actions in Blink. This correctly emits a focus event, along with the correct event from action annotation.

Once it finally arrives in automation, we dispatch the event in js.

In js, we suppress focus events in favor of tracking the focus computation given by AutomationInternalCustomBindings. Unfortunately, if, within the same event bundle, there is an event immediately before the focus event (either generated or not), the event triggers a synthesized focus event, before the actual focus event.

In the end, the incorrect event from value is associated with the synthesized focus event.

This has enormous impact on users as we unpredictably flood users with duplicate feedback. This seems worse on some devices (depending on the event bundle's contents and ordering).

Technical details.
What's happening:

we receive events (in order) like:
1. layout complete (event from page)
2. blur (event from action)
3. focus (event from action)
in the same event bundle.

Before any of these get fired, we unserialize all of the tree data, so the focused node is already updated as far as the tree data is concerned.

After this, we proceed to fire events.

The first one, is the layout complete. This translates into a *focus* event js-side, along with event from page, because that's what the layout complete event had set.

If we honored the actual focus event first, then we would pick up on the right event from action value.

Bug: 881495
Change-Id: I73b1afc3f1b224ade0cef29a89e00c179438a575
Reviewed-on: https://chromium-review.googlesource.com/1211106Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589987}

WaitUntilConditionOrTimeout replaces deprecated WaitUntilCondition.

Bug: 784735
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I7be4ef5e89e72e2bdee8721a6be7fcaba96107a8
Reviewed-on: https://chromium-review.googlesource.com/1214425
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589986}

1. Revert the change where we decided to ignore eTLDs
(https://crrev.com/c/644491). We figured that none of these would allow
"www" or "m" as a subdomain but the m.tumblr.com case proves this
wrong.
2. Only strip leading trivial subdomains.

Bug: 881694
Change-Id: Ia8b7bb02611edc4d6c6c2c634f428dee0bff11e2
Reviewed-on: https://chromium-review.googlesource.com/1215420Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589985}

Posted blocking ScriptStreamer tasks can end up in a queue, and have
their Resource complete loading before the task even starts. When this
happens, these tasks will no longer block on network input, but they
will still be posted to the blocking task runner, which does not spin up
new threads if the running task is not blocked. When there are a lot of
small functions posted for streaming, this results in a slightly
paradoxical starvation, where the blocking task runner is processing
lots of no-longer-blocking tasks all in one thread, as it has no reason
to spin up new threads.

To avoid this, if a streaming task isn't started before the resource
finishes loading, we can cancel this posted task, and instead post a new
non-blocking task to the non-blocking thread pool. This frees up the
blocking task runner to process only blocking tasks (and thus allows it
to spin up new threads for them).

TBR=kouhei@chromium.org

Bug: chromium:865098
Bug: chromium:866868
Change-Id: Ia955fb7a5fd7a6dfdac6a21d8d866b1d1699054d
Reviewed-on: https://chromium-review.googlesource.com/1216963Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589984}

Currently there are no widevine cdm libraries for arm64 builds.
Disable it to avoid build errors when building ARM64 Chrome
in Chrome OS.

Bug: 881022
Test: No more missing widevinecdm files errors.
Change-Id: I476415cef0c435cb50e113de4e576cb6d3006951
Reviewed-on: https://chromium-review.googlesource.com/1211974Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589983}

These builders take a long time to finish.

Bug: 868213
Change-Id: I532603b76a6a724bbdf36f5d27e93223d6f5d2de
Reviewed-on: https://chromium-review.googlesource.com/1217223Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589982}

This reverts commit e67557cd.

Reason for revert: Issue 864351 has been traced to a bug in ThirdPartyModulesBlocking.

Original change's description:
> Copy some more BlobReader state to the stack and alias it.
> 
> Temporarily add some values to minidumps, to help diagnose BlobReader
> crash reports.
> 
> Bug: 864351
> Change-Id: I048600d890496247fc966442d8f533d4b9eb51c8
> Reviewed-on: https://chromium-review.googlesource.com/1196041
> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
> Commit-Queue: Wez <wez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587476}

TBR=wez@chromium.org,mek@chromium.org,brucedawson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 864351
Change-Id: Ibb9809ce230a615ec18a36708d45635fc40ca8c1
Reviewed-on: https://chromium-review.googlesource.com/1216711Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589981}

The test recently and unexpectedly became so flaky (timing out) that
it was failing its 3 retries.

Bug: 882323
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I79865837adcab6553693cdf3cb37db356a7d3816
No-Try: True
Tbr: ynovikov@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1216085
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589980}

Bug: 875461
Change-Id: If447041f60540c338a368a94900632693d1a18d3
Reviewed-on: https://chromium-review.googlesource.com/1217162Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589979}