- 24 Jul, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/87259987f65e..efe03fe27df3 Created with: gclient setdep -r src-internal@efe03fe27df3 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I6d5b6478c3c8afbf763f0b9f2dc07d687d74cbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716932Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680608}
-
Becca Hughes authored
Set default position. BUG=987381 Change-Id: I12fa8599c6b5a9630a252412261fc0edd24aadf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717306 Auto-Submit: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#680607}
-
Kayce Basques authored
Bug: 986998 Change-Id: Ib01f7cdfd2f9d47833695f62b7baad7b759c0eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716153 Auto-Submit: Kayce Basques <kayce@google.com> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#680606}
-
rbpotter authored
Port tests for the shared JS resources migrated to modules in https://crrev.com/c/1682889. Note: Tests only run if optimize_webui is false, since these resources only exist in this case. Bug: 965770 Change-Id: Ic98c7fcf47149a96a21311fbc52cc8192cc60bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716947 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#680605}
-
Sinan Sahin authored
Bug: 987101 Change-Id: I46a33fcad060551b9f6216efab47147b0dfe8baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716261Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#680604}
-
Matthew Mourgos authored
- This change will ensure proper spacing with shelf constants that have been changed for the new dense shelf ui. Bug: 973483 Change-Id: I4790a9e602ee592c15637f4a7cd300bb52dda3a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708011Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#680603}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/776f729a..6c48f74f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id7d4bf02257cbd720c154b01902d070bf3ba5cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715421Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680602}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a76f3b0bce96..397e783df69a git log a76f3b0bce96..397e783df69a --date=short --no-merges --format='%ad %ae %s' 2019-07-24 fmayer@google.com Merge "Change "Frame too large" from DLOG to LOG." Created with: gclient setdep -r src/third_party/perfetto@397e783df69a The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I19bdd48d788360a41e12a924eaf41828c0ba4939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715260Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680601}
-
Rakesh Soma authored
Bug: 987291 Change-Id: Ibdb1dfa5de51aa130c7853f12290889740ea7b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715742 Auto-Submit: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#680600}
-
Yue Li authored
Bug: None Test: Manual test Change-Id: Ib88c098855428a0e96e66ba4fe18988afec05ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717234Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#680599}
-
Steve Kobes authored
We treat tap but not scroll as an excluding input for the purposes of cumulative layout shift calculation and the hadRecentInput bit on the performance entry. NotifyInput looks at WebInputEvent types to determine exclusion status. If kPointerDown is followed by kPointerUp, the pending shifts are excluded. But if followed by kPointerCancel or kPointerCausedUaAction, the pending shifts are not excluded. Bug: 978027 Change-Id: I43f48b0001df168a46e2b44955742144f22c691b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715232 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#680598}
-
Kyle Milka authored
Bug: None Change-Id: Ibb168d611ccff39740aa422a8d251fbb053407a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717155 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#680597}
-
Brian Sheedy authored
This reverts commit 0fbaf768. Reason for revert: Blocking revert of https://chromium-review.googlesource.com/c/chromium/src/+/1708418 Original change's description: > viz: Create SchedulerSequence for SkiaOutputSurfaceDependency > > Share SchedulerSequence implementation between command buffer task > executor and skia output surface dependency. Also refactor Android > WebView to make sure skia output surface dependency there does not > need to be depended on command buffer task executor. > > Bug: 979788 > Change-Id: I0ae966397a93cd82945ffa249328b28fc6da7dd8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715084 > Commit-Queue: weiliangc <weiliangc@chromium.org> > Reviewed-by: Peng Huang <penghuang@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680474} TBR=penghuang@chromium.org,boliu@chromium.org,weiliangc@chromium.org,ericrk@chromium.org Change-Id: I76e694f1030ab526d91f8a2d62d55ea3a2da3650 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 979788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715473Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#680596}
-
Anders Hartvoll Ruud authored
According to a recent spec change, the syntax of a registered custom property must be ignored until computed-value time. This means that we can unfortunately not reify specified values according to the syntax; instead all custom properties reify as CSSUnparsedValue, regardless of their registration status. This means that we can remove large parts of the Typed OM code which deals with PropertyRegistation for specified values and matching of incoming CSSStyleValues against registered syntax. The typedom.html test was also mostly re-written, as most of the things it tested are now not relevant anymore, or at least no longer as interesting as before. (The new reworked test basically verifies that registered custom properties behave as unregistered for attributeStyleMap and styleMap. For computedStyleMap, we should of course still reify according to the syntax). Bug: 641877 Change-Id: I4da7c25b8f066dd01388b6229bebe181513e9fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713557 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#680595}
-
David Bokan authored
Unneeded without touch. Bug: 986559 Change-Id: I9243f915924cc36e304ce5e864c708b5045638ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717264 Auto-Submit: David Bokan <bokan@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#680594}
-
Kristi Park authored
Start the reorder flow on dragstart instead of mousedown. This will prevent the tile from showing its elevated state when the user clicks it. As a side effect, the elevated state will not appear until the user starts dragging the tile. Screencast: https://drive.google.com/open?id=1Oy6dK-2r8TwdC1XW6ka0LRy676mpDXTG Bug: 986741 Change-Id: Iada5fefcade302b815b9fbaf1582ae00cac57b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717146 Auto-Submit: Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#680593}
-
Peter Boström authored
Makes sure that the installation bubble can show when the extensions-menu experiment is enabled. This code will likely need to be changed to pop out the installed extension. With this fix it will at least show the extension-installed dialog. Bug: chromium:987312 Change-Id: Ib46bffe3022407fb1cbc96596d055e46c7c4750c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715469Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#680592}
-
Nick Diego Yamane authored
This CL adds event handling for XRandR |XEvent|s, re-fetching and updating display list dynamically and communicating |DisplayObserver|s about the changes. No unit tests are added due to the current dependency on XRandR/Xlib API. Bug: 891175 Test: None Change-Id: I96c5fe83fc4f1792503b34b0676b778b601d42d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709491 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#680591}
-
David Benjamin authored
This is in preparation for moving SSLConfigService lookups and other state management into SSLClientSocketContext, which will have an observer interface and such. For now, just change everything directly adjacent to where the object is created and used. Since every mention of SSLClientSocketContext is being touched anyway, take this opportunity to rename it to the short SSLClientContext, matching SSLServerContext. Bug: 951205 Change-Id: I4845f4302dd1c5a6655f4fc7bab7daf8b3ae5a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708314Reviewed-by:
Steven Valdez <svaldez@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#680590}
-
Ben Mason authored
This reverts commit a45cf506. Reason for revert: Breaking official build. Original change's description: > Enable VR DFM conditional install for DD-ready devices > > The CL uses the new 'conditional modules' feature to auto-install the > VR DFM upon updating Chrome on supported devices. This should provide a > much better experience when launching Chrome from the DDH for the first > time on devices where the cost of having the VR DFM unused is minimal. > > This is only used on monochrome_bundle builds. > > Bug: 961796 > Change-Id: I79b095205b5dd947484738034bf50a2a0c4c8ca8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714144 > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Commit-Queue: Will Cassella <cassew@google.com> > Cr-Commit-Position: refs/heads/master@{#680060} TBR=tiborg@chromium.org,cassew@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 961796 Change-Id: I9ca741bb68f1d91c6b65e314fc2dc3c9f0cf5128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717265Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#680589}
-
Mike Dougherty authored
Increase the wait time to use standard constants for JS and UI waits. The tests previously used a custom timeout of one second which is too short to detect the change on iOS 13. Bug: 983355 Change-Id: Iec4fb542aa5fc9094651c45e7d20a4680a901570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717232 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#680588}
-
Kyle Milka authored
Bug: 987076 Change-Id: I95b263f6cd8fd970b3a90a88660a0fcf06b4b5af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717192Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#680587}
-
James Cook authored
This reverts commit b0f26697. Reason for revert: After more PM/UX discussion, we want to restore the search engine select menu in OS settings. Original change's description: > SplitSettings: Change OS search engine menu to link to browser setting > > After PM/UX discussion, we don't want to duplicate the search engine > drop-down between browser and OS settings. Instead, OS settings uses > an info label with a link to browser settings. > > Screenshots on bug: > https://bugs.chromium.org/p/chromium/issues/detail?id=960937#c7 > > Bug: 960937 > Change-Id: I622558c4c7238dc8f3d36d3a63305e7abc0f473a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640601 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665641} TBR=jamescook@chromium.org,xiyuan@chromium.org Bug: 960937 Change-Id: I463e11f209afedc885fb07b1a12593f7450c1629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716968Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#680586}
-
Justin Cohen authored
Also fixes missing shard:1 on chromium.mac. Change-Id: If42a81850eac21afee5dd737bbd7c4030b06189a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715422 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#680585}
-
Ken MacKay authored
Bug: internal b/137439407 Change-Id: Ia316552cfd0d884f1c55ce32603b426778f08cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715765Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#680584}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7bf6d365. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" 6a6b173b "Add type option to showToast helper" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hbos@chromium.org, hta@chromium.org: external/wpt/webrtc mkwst@chromium.org: external/wpt/upgrade-insecure-requests msisov@igalia.com: external/wpt/webvtt NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ief9c34fea91b2e0a0562533883905a0422c6203a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716600Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680583}
-
Peng Huang authored
This is a revert of a temporary fix https://chromium-review.googlesource.com/c/chromium/src/+/1594780 Bug: 958055 Change-Id: Ie00a41007512fef7f01492f851e96c14e5e54bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717201Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#680582}
-
Justin Miron authored
These metric have been replaced by the new AdsPageLoadMetrics PeakWindowedPercent and have been marked obsolete in histograms.xml. This removes the population of the metric's histograms, and modifies unit/browser tests to use PeakWindowedPercent. BUG=979215 Change-Id: I6b5b4d6e57169a6571c916de8fd8faa3a1a3bdb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709977 Commit-Queue: Justin Miron <justinmiron@google.com> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#680581}
-
Mehran Mahmoudi authored
This changes the key functions In-Product Help layout. It also no longer shows the IPH for changes in cursor visibility. Bug: 983734 Change-Id: I8bffcb150e1d34a37c284db37c448c91f9f251a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716952 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#680580}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fb9acba203f7..594fe855a360 git log fb9acba203f7..594fe855a360 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 halcanary@google.com gm: simplify several onName 2019-07-24 csmartdalton@google.com Add a workaround for PowerVRRogue to never disable color writes 2019-07-24 csmartdalton@google.com Add a gm for the labyrinth bug Created with: gclient setdep -r src/third_party/skia@594fe855a360 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: chromium:913223 Change-Id: I0d911f0ba700198ac8529ed15957a91b7946b4f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717226Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680579}
-
Sam Goto authored
Bug: 670299 Change-Id: Ia1a4a387641c5c515537f2cc126e887f98c61be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715768 Commit-Queue: Sam Goto <goto@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#680578}
-
Nick Diego Yamane authored
After crrev.com/c/1712955, //ui/base/x code can depend on X11EventSource directly (without causing GN circular deps), making GetTimestampForXWindow ui::XWindow::Delegate's function unneeded. So this CL removes it. Bug: 981606 Test: None (no behavior change) Change-Id: Ied47c2cd7bf0cccd45c0212d84de341145d89779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715308 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#680577}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/97321b687b38..672a48d0d2b9 git log 97321b687b38..672a48d0d2b9 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 sprang@webrtc.org Add sprang@ as owner in modules/rtp_rtcp 2019-07-24 alessiob@webrtc.org Reland "Reland "Add plumbing of RtpPacketInfos to each AudioFrame as input for SourceTracker."" 2019-07-24 alessiob@webrtc.org Revert "Reland "Add plumbing of RtpPacketInfos to each AudioFrame as input for SourceTracker."" Created with: gclient setdep -r src/third_party/webrtc@672a48d0d2b9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:982260,chromium:982260 Change-Id: I579b6cb9fae6ec594ed5ad9846c63454fca9f30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717211Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680576}
-
Ayu Ishii authored
This change adds UMA tracking for SMSReceiver to help measure user experience of the API. Specifically, when a site calls navigator.sms.receive() this change will track the following. 1. Time from when the API is called, to when the API times out. 2. Time from when the API is called, to when the user manually cancels the call. More details on metrics and its motivation here in the API Design Doc [1]. [1] https://docs.google.com/document/d/1dB5UM9x8Ap2-bs6Xn0KnbC_B1KNLIUv4W05MunuXYh0/edit#heading=h.bbporvvwzoo7 Bug: 976332 Change-Id: Ica64097d2b759130eb349c8a37cfef2e4a303ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713706Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#680575}
-
Jack Steinberg authored
This change allows users to show() toasts that will persist indefinitely by passing through duration: Infinity. The change also adds range boundaries to duration, so the value must be greater than 0. Bug: 985468, 972945 Change-Id: I694edab74aff7f99e770e7d37373329f5e663c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713684 Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#680574}
-
Tommy Steimel authored
This CL adds an 8px border radius to the GMC dialog to match the specs. Bug: 982925 Change-Id: Ib72984982cbe7f5874176ef325aecfb9a80734b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716603Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#680573}
-
Emil A Eklund authored
Bug: 785230 Tbr: drott@chromium.org Change-Id: I1c258d841a667749e25f4c55bcf278da9f00a52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717198Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#680572}
-
Simeon Anfinrud authored
This will print the keys of validators that were not properly unregistered before the DeviceCapabilitiesImpl destructor on debug builds. Bug: Internal b/138262808 Test: cast_shell_browsertests Change-Id: Ifda5d7f37844dceebc43902fabac0da86212e95a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715552Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#680571}
-
Nektarios Paisios authored
Accessibility selection returns tree positions that are adjusted taking into account ignored children. However, some ignored children are now included in the accessibility tree, and ax selection doesn't account for those. This is just a workaround to avoid crashes and unblock users from using GSuite until a re-write of the selection calculations in IA2 hypertext is undertaken using AXPosition. R=aleventhal@chromium.org Change-Id: I94287b344d0f8a6a0459ca0f769b9921a332d033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715752Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#680570}
-
Nicolas Ouellet-Payeur authored
This reverts commit d9dbade3. Reason for revert: python_script backend fails on waterfall, making the bots red (crbug/949382) Original change's description: > [Traffic Annotations] Run extractor.py on waterfall > > linux-annotator-rel and win-annotator-rel will now test traffic > annotations with extractor.py, as well as the clang tool. > > Also updates a traffic annotation in management_ui_handler.cc, since > extractor.py doesn't understand #ifdefs. As a workaround, this > CrOS-specific annotation is moved to a CrOS-only file. > > TESTED= > Ran traffic_annotation_auditor_tests.py locally, excluding the > --no-filtering configs. > > Bug: 966883 > Change-Id: I7848877f67635b50d8ce2a841019e49136a33b11 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692970 > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Cr-Commit-Position: refs/heads/master@{#675994} TBR=hcarmona@chromium.org,rhalavati@chromium.org,nicolaso@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 966883 Change-Id: Ic283e1ba2cd5720cfbb85553f2f1a482cbf28a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715896Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#680569}
-