- 11 Oct, 2019 18 commits
-
-
Tim Song authored
Certain feature pod buttons (e.g. accesibility) are not togglable, but are currently announced as such for ChromeVox spoken feedback. BUG=1009727 Change-Id: I2db6c3a53bb04ba677457ff5590574d2c384b503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848454 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#704913}
-
David Black authored
Previously the timer notification message was manually constructed. Now we rely on ICU APIs for better I18N support. Tested in en_US, fr_CA, ja. Bug: b:122475245 Change-Id: Idf8f375adee0aba198ad7091a2aa96bbe283c6df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660261 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#704912}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7fd7a8aef06c..9f765966461e git log 7fd7a8aef06c..9f765966461e --date=short --no-merges --format='%ad %ae %s' 2019-10-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@9f765966461e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: Iec9e20f8214f85192ed6a2727f7ce179c24f64d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854918Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704911}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d372b6c1..f505d9d8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I487f46cee3819e4726cd26322520ed1585d03ce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853951Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704910}
-
John Lee authored
Previously, the tab strip was using favicon by using chrome://favicon, which depends on history and consequently did not work in incognito mode for sites the user did not visit in a normal window. Bug: 992972 Change-Id: I6407353c649876fe78c4ffb2425ebcd761e5d0fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850965 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#704909}
-
Christopher Cameron authored
The profile_storage_ member of AvatarMenu is commented as "weak", but the lifetime relationship is not discussed. Use an actual weak pointer (ProfileAttributesStorage supports it already), and avoid dereferencing profile_storage_ if it is gone. Bug: 1008947, 1001215 Change-Id: I0e8a2fbb55465f1680c064c7cdb6193c93eb3e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853647Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#704908}
-
Marijn Kruisselbrink authored
This is in preparation for migrating native file system code to the UI thread, and decoupling it from whatever thread file system backend code actually wants to be called on. Bug: 1011534 Change-Id: I9d956dac5761380654842cdd07b67e1c7c2000d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841764 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#704907}
-
Regan Hsu authored
Bug: 1013094 Change-Id: I27d3fd476d3c747ac7eb7a90eb179c3b787baec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852420Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#704906}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/383a4e801d41..788d15f52867 git log 383a4e801d41..788d15f52867 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 rmhasan@google.com [typ] Makes changes so that Host or FakeHost can be used as file manager Created with: gclient setdep -r src/third_party/catapult@788d15f52867 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:982208 Change-Id: Ieb924d5fd330cc75976b6a6c2764e1a25506a2cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854759Reviewed-by:
-
Christopher Thompson authored
This will make all sites be treated as "control" (no warnings shown) when the control site config has not yet been loaded. This will prevent control sites from accidentally showing the warnings, at the expense of occasionally not showing warnings on non-control sites near browser startup time. Bug: 1011089 Change-Id: I32ebb7affc0d0a4bc2a3f6b280c9e5943f9118eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845488 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#704904}
-
Antonio Gomes authored
This CL wraps up Onion souping of webrtc_media_stream_track_adapter_map.cc|h that happened in [1], but was blocked on [2] - now fixed. [1] https://crrev.com/c/1816780 [2] https://crrev.com/c/1816789 BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: If134aed18197306d43cbdfa18430b9aab11e6fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816796 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#704903}
-
Tommy Steimel authored
This CL adds a ScopedFeatureList to the MediaDialogView interactive browser tests to ensure that Global Media Controls are enabled. This fixes an issue where the tests were failing on official builds. Bug: 1012549 Change-Id: I8c3fcb815811353f059f988bdffe0c336059f005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854860 Commit-Queue: Tommy Steimel <steimel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Auto-Submit: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#704902}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/847b3f98194e..586f2bea5b1f Created with: gclient setdep -r src-internal@586f2bea5b1f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ib34ddcf30f544c7dbd0b57c66c31cb8b7fbedc53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854758Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704901}
-
Kyle Horimoto authored
Each button on the keypad includes space for a number as well as the letters which represent the numbers (e.g., "ABC" for 2, "DEF" for 3). However, since 1 does not have any associated letters, its alignment was incorrect and noticeably different from the rest of the buttons. This CL fixes this alignment issue by aligning the number to the top of the button and the letters to the bottom of the button. Fixed: 1004974 TBR: stevenjb@chromium.org Change-Id: I9be7be402b853cbf6ba76985151f77a0696ac13b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854638Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#704900}
-
Hiroki Sato authored
Some member functions are unnecessarily declared as protected, and they should be private. Also this CL fixes a lambda function from by-copy capture to by-reference capture. Bug: None Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*:ArcAccessibilityHelperBridgeTest.*" Change-Id: I183174a922b6d57ea3b41a04053785b936b655b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850687 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#704899}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f1f2e8606a69..c9af0e8a6ace git log f1f2e8606a69..c9af0e8a6ace --date=short --no-merges --format='%ad %ae %s' 2019-10-10 jclinton@chromium.org Remove excelsior temporarily to improve LCQ runtimes Created with: gclient setdep -r src/third_party/chromite@c9af0e8a6ace If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ie63ec2d1da58c780ef30ad537ed846efb8aa3dcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854698Reviewed-by:
-
Moe Ahmadi authored
Remote zero-prefix suggestions are supported only when Google is the default search engine and the user is signed in (based on the existing experiments). This CL disallows remote zero-prefix suggestions when those conditions are not met. Bug: 996516,1012340 Change-Id: I7f077a79f85c0a72523fd307afe58318ed63a372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848052 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#704897}
-
danakj authored
Only the main frame RenderWidget should have modified values from the emulator, so only it should be able to see it. In particular, popups and child frames should not see the emulator. R=avi@chromium.org Bug: 419087 Change-Id: I34cca337c8b9590824f681cf32475ba0a67c78b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850573 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
- 10 Oct, 2019 22 commits
-
-
Thomas Guilbert authored
An empty directory was accidentally committed in 0f14062b... as part of the dav1d roll. This CL cleans up the mistake. Bug: 1010547 Change-Id: I29fd4793b817d64adf9832df67f7a82a6dfde1cf TBR: sky@chromium.org Change-Id: I29fd4793b817d64adf9832df67f7a82a6dfde1cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841666 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#704895}
-
Julie Jeongeun Kim authored
This CL converts UserId from user_id.mojom to new Mojo types using ReceiverSet and PendingReceiver. Bug: 955171 Change-Id: I15a7b25d0debc781387f8f3dbc9e9ce637fdb6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849746Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#704894}
-
Julie Jeongeun Kim authored
This CL converts OriginPolicyManagerRequest and OriginPolicyManagerPtr to new Mojo types using PendingRemote, Remote, PendingReceiver, and ReceiverSet. Bug: 955171 Change-Id: I370ef0d56a0fee3d358233f49d85f31e7233e0df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846630Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#704893}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1e9b892b. With Chromium commits locally applied on WPT: 23748e60 "Change text directive to text=" 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I5e8d81bbd056fc244496527fe6fbebbb4e0592af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853950Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704892}
-
danakj authored
Each RenderWidget/local root should have its own scope for the ScreenInfo, since emulation causes the ScreenInfo to change only for the main frame. In the future if all widgets get the emulated ScreenInfo, the updates should propagate through the VisualProperties update waterfall which requires going through and storing the values on RenderWidget. R=dcheng@chromium.org Bug: 419087 Change-Id: Iaa333665acf4dc9990d92105ce8631377e0fd93b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852423Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Emil A Eklund authored
Bug: 1011885 Change-Id: Iab49fc210c341602897b5e2bf07d56e257adb100 Tbr: ikilpatrick@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853884Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#704890}
-
dpapad authored
- Fix newly found JSC_HIDDEN_INTERFACE_PROPERTY_MISMATCH, as a result of the interface checking overhaul at [1] - Fix/suppress newly found JSC_CONSTANT_PROPERTY_REASSIGNED_VALUE errors. This is in preparation of rolling a newer compiler version at a later CL. [1] https://github.com/google/closure-compiler/commit/86acbd5e3ec78f08a1804df5f1efbea129d29c0e Bug: 1012840 Change-Id: I8c356c9d2d3df03120f04614eafa555de488c8fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850312 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#704889}
-
Michael Liao authored
Re-upload of https://chromium-review.googlesource.com/c/chromium/src/+/1636250 This is a shared control between Timeline, Network, Memory, JS Profiler and Layers tools 1. This PR adds the ability to use keyboard to navigate sliders in the Overview grid. - Can tab into the sliders - Can use left and right arrow keys to navigate the grid sliders (step by 2 pixels) - Can use Ctrl + left and right arrow keys to navigate the grid sliders faster (step by 10 pixels) Gif: https://imgur.com/Im7m6su Bug: 963183 Change-Id: I64ec60864165d9cca6e7a76c6849ed1cf1beee61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676677Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Michael Liao <michael.liao@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704888}
-
Chris Harrelson authored
This is necessary to make sure the values get through to the compositor thread. It regressed accidentally in earlier CLs. Bug: 1013000 Change-Id: Ia6de23a10180abb5e41fc8d48f790359f826c6f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854218Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#704887}
-
siyua authored
Did some manual testings to make sure it is working correctly. Bug: 991037 Change-Id: Icceddefdee99f0ba252f5ce161e4b42813ee1c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848751Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#704886}
-
Haiyang Pan authored
This would help local development with emulator Bug: 922145 Change-Id: Ie107381b80e3c0acae1145cf4078a327e38ffa3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849434Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#704885}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3481902904a9..6a1d77869d77 git log 3481902904a9..6a1d77869d77 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 ehmaldonado@chromium.org gsutil: Bump asn1crypto version to 1.0.1 Created with: gclient setdep -r src/third_party/depot_tools@6a1d77869d77 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1012612 Change-Id: I965e614a9ae1ddc5dfeab2bef26e7db27ff663bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854363Reviewed-by:
-
Brandon Wylie authored
The current histogram that's in place doesn't fit our needs here. Bug: 1001839 Change-Id: Ie1a0e897c86bfa88fbb5eb901fb7f57c7f4b1bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846249Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#704883}
-
Zoe Clifford authored
String parking can be fairly expensive in terms of CPU, which makes it undesirable for certain headless use-cases, such as those with many short-lived pages, or where RAM is more plentiful than CPU. The option to disable string parking was removed in [1]. This CL re-adds a similar option so it may be disabled once more. (Google Internal) screenshot of CPU profiling: https://screenshot.googleplex.com/cFXiZq1ydBN [1] https://chromium-review.googlesource.com/c/chromium/src/+/1697649 Change-Id: Ib05e79a009fb70565011bd8aa9ba6238c6a8c617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820023 Commit-Queue: Zoe Clifford <zoeclifford@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d0704ce5c6a1..d62ac3f0b830 git log d0704ce5c6a1..d62ac3f0b830 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 kcwu@google.com Use fake clock for replay fuzzing Created with: gclient setdep -r src/third_party/webrtc@d62ac3f0b830 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:959836,chromium:1009073 Change-Id: Id67092bd1507ca2c61443a8db8bdd8b2ac3a2337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854377Reviewed-by:
-
Dmitry Gozman authored
This moves some logic for previews state from RenderFrameImpl to FrameFetchContext, which already knows about previews state. Bug: none Change-Id: I6cf8febb27d88ab078ccb2101496f83ab613bddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849142 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#704880}
-
gogerald authored
Screenshot https://drive.google.com/file/d/1qg8pxjuJdN_d4YxeIpyssp-xFxbPjV1I/view?usp=sharing Bug: 982018 Change-Id: Id334c4b2b279e130703ce99a9e76f81ef1735920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854461Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#704879}
-
Elly Fong-Jones authored
The Tab menu in the Mac system menu bar has some options that target the foreground tab, like "Mute Site" and such. This change introduces alternates that show up for those items when Option is held which instead target the tab that has keyboard focus. This allows the user to perform those operations on a tab without having to activate it. There are no key equivalents for these new options (yet?), but they are still usable two ways: 1) By focusing a tab, then using Ctrl-F2 to move native focus to the system menu bar and navigating to the Tab menu, 2) By adding a user key equivalent corresponding to these items by name and invoking that at any time The main implementation complexity in this CL is that TabStripModel doesn't know about keyboard focus for tabs, and has no easy way of finding out about it without depending on implementation details of the TabStrip View. As such, this CL directly binds TabStrip (the View class) to BrowserCommandController. This change: 1) Has TabStrip (the Views View of the TabStripModel) observe its Tabs for keyboard focus changes and propagate these into the BrowserCommandController. 2) Adds new menu items to the MainMenu builder as alternates to the existing commands in the Tab menu. 3) Adds implementations of these commands in browser_commands. Bug: 818261 Change-Id: Ia222e412c53e19dde3cb19f38b18a8507f11f7e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829804 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#704878}
-
Antonio Gomes authored
This CL wraps up Onion souping of media_stream_remote_video_source.cc|h that happened in [1], but was blocked on [2] - now fixed. [1] https://crrev.com/c/1667727 [2] https://crrev.com/c/1816789 BUG=787254 R=guidou@chromium.org, haraken@chromium.org hange-Id: I4b184a271b2b894d1b7d34e305a9fdf625404d9a Change-Id: Ic48da9a50cbe8a369850b4eb70a7b5896b0a6b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816795 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Bryan Clark authored
This allows callers to deference the result of CastMediaShlib::GetVideoPlane() without crashing cast_shell. Change-Id: I09b8a761359736195e42bec1708174a4e939a69f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854186Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Bryan Clark <bryanclark@google.com> Cr-Commit-Position: refs/heads/master@{#704876}
-
Emil A Eklund authored
Bug: 1011885 Change-Id: Ibd96773c271a5a7021069cdee3676d9248783c7d Tbr: dgrogan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853287Reviewed-by:
-
Sergey Ulanov authored
Encrypted media streams may contain unencrypted flames. That case wasn't handled correctly in FuchsiaSecureStreamDecryptor. Now it generates input packet with a single subsample entry with encrypted_bytes = 0. fuchsia.media.drm API currently needs key_id even for clear frames, see fxb/38253. To workaround this bug FuchsiaSecureStreamDecryptor now stores a key_id from the last OnNewKey() and then sets that key_id in the FormatDetails for clear frames. Bug: 1012525, b/141148085 Change-Id: I185e3a89086a3613b383b9ef75e59ef5e151cb75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846323 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#704874}
-
