- 20 Mar, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bf995d913927..4432f93ff194 Created with: gclient setdep -r src-internal@4432f93ff194 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:995903 Tbr: jbudorick@google.com Change-Id: I92854a65d4fcb54abddc6f00ab1e62d86135f4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112392Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751981}
-
Karandeep Bhatia authored
Currently the ruleset checksum for each extension using the declarativeNetRequest API is stored as an entry corresponding to the "dnr_ruleset_checksum" or "dnr_dynamic_ruleset_checksum" key. This CL replaces them with the "dnr_static_ruleset" and "dnr_dynamic_ruleset" keys respectively, corresponding to which we store a dictionary mapping ruleset IDs to their prefs. The prefs for each ruleset is a dictionary storing just the ruleset checksum for now. This CL helps move the code away from the assumption of a single static ruleset and will aid in the transition towards multiple static rulesets. A side effect of this change is that existing extensions using declarativeNetRequest will fail to load their rulesets with an install warning. Users will have to reinstall the extension. However that's ok given that the API is only in beta and has seen limited usage as of now. BUG=754526 Change-Id: Iaa77fca18322320dea4c7b02b0b9d6edea123975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103547 Commit-Queue: Sergey Poromov <poromov@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751980}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0e069b42b334..12a1c373822e git log 0e069b42b334..12a1c373822e --date=short --first-parent --format='%ad %ae %s' 2020-03-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 18d3896a15fc..60104cd97446 (2 commits) 2020-03-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader bc98fbeec99b..1c9f24263e6c (2 commits) Created with: gclient setdep -r src/third_party/angle@12a1c373822e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I8c62e29a53fece57d300cf9e765399459c635ffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112394Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751979}
-
Nico Weber authored
(But not in use_libfuzzer builds.) Suppress the last few issues. This doesn't always go for the nicest fix for now, but instead for the simplest behavior-preserving change. The hope is to get this in while the codebase builds with the warning on, to make sure that no new regressions land. I'll then clean things up a bit on linux (e.g. make nice conversion functions for skia to libyuv and libpng color formats), and gradually enable on androidchromeosfuchsiaiosmacwindows in follow-ups. Bug: 346399 Change-Id: Ic920d3b63ac83aa59c2bf862f60662196d0b28e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093537 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#751978}
-
Jinsuk Kim authored
For some of the callsites of TabImpl.getActivity(), what they actually need is not ChromeActivity, but either Context or Activity. This CL replaces them with Tab.getContext(). TabImpl.getActivity() and Tab.getContext() is different in that the former returns null if the tab is not attached to ChromeActivity (or not attached at all) while the latter returns the application context for such case. The callsites updated in this CL are not affected by the difference due to one of following reasons: - a null check to see if the tab is detached is already in place (ModuleInstallUi) - it is okay to proceed with the application context (ContextualSearchTabHelper - works for ChromeActivity only. For non-ChromeActivity, its scaleFactor could be set wrongly but CS won't be activated anyway) - getActivity() is always returning a non-null activity i.e. Tab.getContext() returns activity contenxt (LayerTitleCache, ExploreSitesPage, SurveyInfoBar, PictureInPictureActivity, TabParentIntent, ArConteInstallUtils) - a null check was added newly to check if the tab is in the detached state (AddToHomescreenInstaller - it is used by ChromeActivity-inherited activity only, therefore TabImpl.getActivity() returning null due to the tab being attached to non-ChromeActivity won't happen). Bug: 995903 Change-Id: I763787c57db62e3af61ee7f88bf172b1b93c45ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109392 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#751977}
-
Jan Wilken Dörrie authored
This change modifies StartPasswordCheck to wait for the initialization of the PasswordCheckDelegate, which requires waiting for the initial response from the PasswordStore. In order to support this async API, the method now takes a callback, rather than synchronously returning a value. Bug: 1062985 Change-Id: I878bade15d06d1a564836566898a3d748fe82590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110230 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#751976}
-
Side Yilmaz authored
|Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates ConsentAuditorBridge class. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: I5b4908a03d576ebfccfeb83bae4ac84baf455daa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107488Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#751975}
-
Fredrik Söderqvist authored
* Const qualify referenced objects (SVGPreserveAspectRatio, TreeScope). * Have ReferencedLayoutObject() return a const LayoutObject. * Rearrange the code in FEImage::MapInputs() and CreateImageFilter() to get the same general structure (element reference, external image, failure). * Reorder PaintRecord recording in CreateImageFilterForLayoutObject(). * Mark local helper MakeMapBetweenRects() static. Split out "magic viewport"-mapping into a helper function. * Use DynamicTo<>() where applicable. Change-Id: If9fe1cf076257cd680c05bb1c97e14ab2fe7c1c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110013 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#751974}
-
David Jean authored
Bug: 1045455 Change-Id: I8e72c9466ae00d87141c4fcea30ee817a1fbfb55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106166 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#751973}
-
Tanmoy Mollik authored
This cl removes ChromeSigninController code from the ClearBrowsingDataFragmentBasic and cleans up a test for it. Bug: 1049540, 1051000 Change-Id: Iaa8feb9a7f951f147a484e520462a90570c650a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044111 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Reviewed-by:
-
Vadym Doroshenko authored
This reverts commit 39bb3cd1. Reason for revert: It looks it breaks test CrSettingsPasswordsCheckTest.All on Windows https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29 Original change's description: > [Passwords] No result view fix in password check > > This CL changes the way visibility of 'No result view' is calculated. > The label will be shown only if: > - user had successful check with 0 compromised passwords found > - user is signed in > - breach detection is turned on in settings > > Bug: 1061496 > Change-Id: I9f1e4b5f7aef51749b970964c2b701ee2193ba53 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108501 > Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751674} TBR=jdoerrie@chromium.org,vsemeniuk@google.com Change-Id: I20479f59c5a3e97c2f8d70a3a96179faff861624 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1061496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111294Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#751971}
-
Rohit Agarwal authored
We currently don't have extensive tests on java side which checks any leakage of data across activities. This CL adds browser tests to check browsing and navigation history leaks. Browsing history leaks are checked from incognito to regular mode. Navigation history leaks are checked across all tabbed and CCT activity types. Bug: 1035770 Change-Id: Ideb21008b901b0e1297d2a845602e7a9865b9b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096641Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7c24b6b2ff19..69c5dd70e796 git log 7c24b6b2ff19..69c5dd70e796 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 cwallez@chromium.org Fix depth-only render pipeline creation on Metal. Created with: gclient setdep -r src/third_party/dawn@69c5dd70e796 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I0a5b4e7e9b57657f3131eec9ed876b8c48964a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112393Reviewed-by:
-
Vadym Doroshenko authored
This reverts commit 034be017. Reason for revert: it looks that it breaks tests: OutOfProcessPPAPITest.BrowserFont FontList.GetFontList FontList.GetFontListDoesNotIncludeHiddenFonts https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/52253?blamelist=1#blamelist-tab Original change's description: > fonts: Use Core Text in macOS version of GetFontList_SlowBlocking(). > > Bug: 1062925 > Change-Id: I075bd135bf334f511480bcdccd04e91f99ad54ea > Tested: Compared old and new output on macOS 10.15.3, via DLOGs. > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104102 > Commit-Queue: Victor Costan <pwnall@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751919} TBR=drott@chromium.org,rsesek@chromium.org,pwnall@chromium.org Change-Id: I10c8098f5d2b361a5aacd69c562fd15f372169c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1062925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111093Reviewed-by:
-
Mark Cogan authored
This CL is the eighth in a series of changes needed to complete this refactor: 1. (crrev.com/c/2089687) Add a new provider API upstream that passes both a Browser and temporary URL loading shim to CreateLogoVendor. 2. Implement this new API downstream and add support for initializing the LogoController with both Browser and the loading shim. Use the loading shim for loading URLs if it is present. 3. (crrev.com/c/2089785) Upstream, call the new CreateLogoVendor() API. 4. Downstream, remove support for the old CreateLogoVendor() API and update LogoController to only be initialized with a Browser and the shim loader. Remove downstream use of the URLLoadingService. 5. (crrev.com/c/2105314) Upstream, refactor URLLoadingService to be URLLoadingBrowserAgent, updating the upstream implementation of the loading shim passed downstream in CreateLogoVendor(). 6. (crrev.com/c/2106182) Upstream, add a new provider API that no longer passes the loading shim into CreateLogoVendor(). Delete the now- unused provider API that was removed downstream in step 4. 7. Downstream, remove use of the loading shim from LogoController and have it fetch the URLLoadingBrowserAgent from its Browser parameter. Implement the new shim-less CreateLogoVendor() API. Have the old shimmed API call the new shimless one. 8. Upstream, call only the new shimless API. Remove the shim implemen- tation in calling code. 9. Downstream, remove the shimmed API. 10.Upstream, remove the shimmed API, including the shim definition. Specifically, this CL removes the implementation of the URLLoadingBridge protocol in ContentSuggestionsCoordinator, and has it call the bridge- less CreateLogoVendor() API. Bug: 1046374 Change-Id: I071659526f5e54842ed865ad4cfb8d04f3b788b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106578 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751967}
-
Mikel Astiz authored
In the error-handling codepath where a mismatch is found on the cache GUID, when sync is starting for Nigori, the new cache GUID should be stored in the ModelTypeState. Otherwise, it would remain empty, which means the next sync start the mismatch detection doesn't take place. This can explain cache-GUID mismatches being ignored, and bad consequences such as violating the sync protocol by sending a non-empty progress marker despite the sync birthday being empty. Change-Id: I48d4b35a61dd20f56c416779bee686e1d582606d Bug: 1063021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111090 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#751966}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/362becca1ff2..eb7bd643ef43 git log 362becca1ff2..eb7bd643ef43 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 jiawei.shao@intel.com Extract texture dimension for storage textures (#1008) Created with: gclient setdep -r src/third_party/shaderc/src@eb7bd643ef43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I754b3ada297d6b2496222fba2151f316e1371c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112391Reviewed-by:
-
Felipe Andrade authored
The AuthpolicyErrorType UMA enum was missing the value ERROR_OU_CONSTRAINT_VIOLATION, in order to match the ErrorType message defined in active_directory_info.proto. Bug: 1063026 Change-Id: Id0b36a8a43d5e02bf9d3d360e93c11f713820b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109702Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Cr-Commit-Position: refs/heads/master@{#751964}
-
Alex Danilo authored
The action icon buttons and open button have an active color when the menu is shown - suppresses the background color on hover when the 'menu-shown' attribute is set. Add a TODO about the placement of :focus. Bug: 1061819 Change-Id: I70cc84784f1e8025f2dcc064c3ce52ca936add66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111513 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#751963}
-
Morten Stenshorne authored
TBR=kojii@chromium.org Change-Id: I1ec54bfce0e20ee267808575f49a1f3842805f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111672Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#751962}
-
Gauthier Ambard authored
This CL enables the feature flag to have the BVC being contained instead of presented. Fixed: 1038034 Change-Id: Id764ee5b8fd26c8c71ae694ea69b8394a8507c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108734Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#751961}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/18d3896a15fc..60104cd97446 git log 18d3896a15fc..60104cd97446 --date=short --first-parent --format='%ad %ae %s' 2020-03-19 dneto@google.com Add opt::Operand::AsCString and AsString (#3240) 2020-03-19 lujiao@amd.com Add RayQueryProvisionalKHR to opt types (#3239) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@60104cd97446 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: Idaa32d5d1e9cfb3f27472fa825fd5e77ea8c1a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111889Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/69fe8eaba083..03867b5533b7 git log 69fe8eaba083..03867b5533b7 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 szuend@chromium.org Add missing return types to InspectorBackend.js Created with: gclient setdep -r src/third_party/devtools-frontend/src@03867b5533b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib37b9c24f75e0b985d31c420edf7610dac707c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111887Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c9453ffe96c1..bf995d913927 Created with: gclient setdep -r src-internal@bf995d913927 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I09a2888340a95619f0fa04a90ef09380b1e627f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111880Reviewed-by:
-
Mark Brand authored
This means that if a mojom file contains an acronym in a field name, that name will now be CamelCased; ie field_name_ACRONYM will become FieldNameAcronym instead of FieldNameACRONYM. This change also adds two new helper functions to generator.py that convert from CamelCase to lower_snake_case and UPPER_SNAKE_CASE, and changes the existing generators to use those new functions. This is a cherrypick/split from https://chromium-review.googlesource.com/c/chromium/src/+/2108507 Change-Id: I0a981929db664644a06c03f84ca36fbf8ae66d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108551Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mark Brand <markbrand@google.com> Cr-Commit-Position: refs/heads/master@{#751957}
-
Mark Brand authored
This is a cherrypick/split from https://chromium-review.googlesource.com/c/chromium/src/+/2108507 Change-Id: Ib7cc2e5dc93f507726cb417446cb1ad6e1ba6a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109696Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Mark Brand <markbrand@google.com> Cr-Commit-Position: refs/heads/master@{#751956}
-
Johann authored
Make the class GarbageCollected so that the mojo::Re{mote,ceiver} objects can be managed as well. Change-Id: I7d0919d900eb54c557cceda07e496bd4920b2b42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106989Reviewed-by:Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#751955}
-
Lin Sun authored
The data type GpuSeriesType seems like it apply to all GPU vendors, but currently it represents Intel's GPU only. Since this name is ambiguous and there is no intention to use it for other GPU vendors, this patch renames it to IntelGpuSeriesType to make explicit. Bug: 896932 Change-Id: I5b2e92ac622d254015d3669ab9e234dbe8c5a551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015423 Commit-Queue: Lin Sun <lin.sun@intel.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#751954}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 82-4044.42-1584352428-benchmark-82.0.4085.12-r1 to 82-4044.42-1584352428-benchmark-82.0.4085.13-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ic3dc69736a5231a527f64b851e3a765a2f635314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112390Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3bf1dab23d9a..9659831766f1 git log 3bf1dab23d9a..9659831766f1 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 johnkslang@users.noreply.github.com Merge pull request #2141 from courtney-g/bug_2140 Created with: gclient setdep -r src/third_party/glslang/src@9659831766f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I674080fc95a921c36824dff0d9a5ec0031c7752a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111875Reviewed-by:
-
chromium-autoroll authored
Roll silvermont AFDO profile from 82-4079.0-1584354054-benchmark-82.0.4085.12-r1 to 82-4079.0-1584354054-benchmark-82.0.4085.13-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I6752a8965eac985ef3654e314e8bd5744dd822e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112273Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ca45852d0907..0e069b42b334 git log ca45852d0907..0e069b42b334 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 ynovikov@chromium.org Skip SwANGLE GLES31 tests which crash with 32-bit Subzero only on Windows Created with: gclient setdep -r src/third_party/angle@0e069b42b334 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: Ia9692b09636eea164c58001b8f9493d1355f1902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111878Reviewed-by:
-
Eugene But authored
This header is not used outside of ios/web, so this CL moves the file closer to the usage place (ios/web/web_state/ui). Bug: None Change-Id: I778ef707b3db2e2e77927e309e91ebf49f839aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109826 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#751949}
-
Ted Meyer authored
Plumb MediaError through VideoDecoder::Initialize so that we can start refining its usage everywhere. Bug: 1043289 Change-Id: I3c4d7517901a8d186a045b7c9774ddad33859d0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042915 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#751948}
-
chromium-autoroll authored
Roll airmont AFDO profile from 82-4079.0-1584355719-benchmark-82.0.4085.12-r1 to 82-4079.0-1584355719-benchmark-82.0.4085.13-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I3769a73319cb6e30e5491f20720fc3047b06c253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111888Reviewed-by:
-
Mirko Bonadei authored
Bug: None Change-Id: Icaee5fb53e4e9542fb8e156f1adbee0abe123cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107982Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#751946}
-
Dominic Mazzoni authored
Original: http://crrev.com/c/2109458 Reverted: http://crrev.com/c/2111771 This change depended on fixing all of the -expected*.txt files in content/test/data/accessibility, but another one landed before this one. The DumpAccessibilityTree tests generate an output text file and diff the results against an expected file. Previously, the way that the algorithm handled files of different lengths was by adding an end-of-file sentinel to the end. This resulted in that sentinel getting checked in, which was just confusing. Fix this by modifying the DiffLines helper function to properly compare files that don't have the same number of lines. Add full unit tests for DiffLines so we can be confident it works. Continue to LOG the end-of-file sentinel, because it's needed by running rebase_dump_accessibility_tree_test.py to parse actual output files from remote logs. Bug: 1063167 Tbr: aleventhal@chromium.org Change-Id: I6c52bc77c3e4bb6e07d77971a5d748d9bf0d1f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112116Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#751945}
-
Jinsuk Kim authored
Moved the method from clank/javatests/../TabUtils.java. This CL needs landing before the clank side change happens to keep the build green. https://crrev.com/i/2788136 TBR=tedchoc@chromium.org Bug: 995903 Change-Id: I43df78505c99ee60d3fb11df44a25a7e6e02c776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111812Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#751944}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/566d53f9a533..69fe8eaba083 git log 566d53f9a533..69fe8eaba083 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@69fe8eaba083 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I658d7167009846fa7b9e3866c142f74b00620ae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111876Reviewed-by:
-
Wei Lee authored
Bug: 980846 Test: Manually tested Change-Id: Icbc8788df1c58b90f7676e6de365899d6e07d943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064231Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#751942}
-
