- 10 Mar, 2018 40 commits
-
-
Ovidio Henriquez authored
Adds a Mojo typemap to properly handle the UUID strings in the service_data field of ScanRecord. The typemap allows the service_data field to map to a device::BluetoothDevice::ServiceDataMap object in C++. BUG=817603 Change-Id: Ie4d5785e8b04098fda76ca8bc99c58141c9b5b82 Reviewed-on: https://chromium-review.googlesource.com/942307 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#542344}
-
Xiaohan Wang authored
This gn arg should only be enabled when component updated CDM is supported, which is only the case on Windows and Mac for now. Bug: 663554 Change-Id: I8d6e6dfdfba8b53bef80d84f376f1ebd36fb4605 Reviewed-on: https://chromium-review.googlesource.com/957707Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#542343}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I61e462bd1cb5d92f74fd619e4d9142418ebfcf55 Reviewed-on: https://chromium-review.googlesource.com/958228 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542342}
-
https://skia.googlesource.com/skia.git/+log/8c4cbf4cfb6d..0c51eeada6a9 $ git log 8c4cbf4cf..0c51eeada --date=short --no-merges --format='%ad %ae %s' 2018-03-09 bsalomon Add GrMockRenderTarget and mock backend render targets Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I9ff039a3a2f7441ebe9d70ad8f5e365356bace5f Reviewed-on: https://chromium-review.googlesource.com/957965 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542341}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I8e7f69af46113860c077f2d1811d442d7c914bdd Reviewed-on: https://chromium-review.googlesource.com/958182Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#542340}
-
Findit authored
This reverts commit b513507c. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 542315 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I1MTM1MDdjZTQ5ZDhjMWU2ZWYwNThmNDUwODJmOGQyMzMxYzk4MzMM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/4635 Sample Failed Step: compile Original change's description: > tablet: Remove minimum time between taps for quick switch. > > Previously relied on using tap_count in GestureEvent which has a minimum > time between taps of 40ms for consecutive taps to have tap_count of 2. > Remove that and track double taps in overview button tray.cc. Allows > double tap from mice now. > > Test: ash_unittests OverviewButtonTrayTest.* > Bug: 817883 > Change-Id: Icce2e668223f938a7f8194c5f0a03279abff9907 > Reviewed-on: https://chromium-review.googlesource.com/956769 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542315} Change-Id: If15964ea1fab006fc7420d708dc08f0f6b5ca03f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 817883 Reviewed-on: https://chromium-review.googlesource.com/958132 Cr-Commit-Position: refs/heads/master@{#542339}
-
Ken Rockot authored
If a message is read from a port and then re-transmitted over another port, it currently retains its previous sequence number. This is problematic and can trivially lead to the message being lost (or rather, queued invisibly forever). This CL resets a message object's sequence number immediately before passing it out to the user reading the port. Bug: None Change-Id: I31604b341c55eee0c7ad6e1fd21e385fb945cf60 Reviewed-on: https://chromium-review.googlesource.com/955555Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#542338}
-
Chris Palmer authored
Bug: 817982 Change-Id: I823b9203db0f549c19f9de7f5ac742ba358b8858 Reviewed-on: https://chromium-review.googlesource.com/952187 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
-
Benjamin Pastene authored
Bug: 817779 Change-Id: Ie45ebfb14d2bdeeb80724ec94d1fce74cc64b8a8 Reviewed-on: https://chromium-review.googlesource.com/957648Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#542336}
-
Kim Paulhamus authored
This updates the filtering preferences (AuthenticatorSelectionCriteria, AttestationConveyancePreference, UserVerificationRequirement) in blink and plumbs the options through authenticator.mojom, along with typeconverters. These preferences are used to determine the types of authenticators the relying party wants/needs to use. Bug: 803832 Change-Id: I070ec4bc04de81ad955e878df45a716e3f9083b9 Reviewed-on: https://chromium-review.googlesource.com/947038 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
-
Nate Fischer authored
This fixes a bug related to the implementation of AwContentsIoThreadClient::FromID(frame_tree_node_id). This function is implemented using a map to keep track of the AwContentsIoThreadClient for a particular FrameTreeNode. Before this change, we would remove a map entry for a frame_tree_node_id whenever we destroy an associated RenderFrameHost. This is incorrect in multiprocess mode however, because a FrameTreeNode may have multiple associated RenderFrameHosts in its lifetime (such as swapping RenderFrameHosts for cross-site navigations). When we swap, we would first overwrite the map entry for the new RenderFrameHost, then erase the map entry when we destroy the old RenderFrameHost. The issue manifests most visibly for Safe Browsing, because FromID() returns nullptr, and Safe Browsing logic defaults to disabling the feature. However, this issue is not specific to Safe Browsing, and this would bug would cause a bad state whenever we trigger multiple cross-site browser-initiated navigations. With this change, we keep track of live RenderFrameHosts for a given FrameTreeNode, and only remove an entry from the map if we've destroyed the last associated RenderFrameHost. Bug: 818025 Test: manual - see bug for repro steps Change-Id: I2ae81fdb5338084cdf253582206144b4f45704b1 Reviewed-on: https://chromium-review.googlesource.com/956411Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#542334}
-
Chris Harrelson authored
If a paint invalidation container returns true from IsPaintInvalidationContainer(), that means it is composited, which in turn must mean the containing LayoutView is composited. This allows us to simplify the code and avoid a call to View(), which may be expensive because it has to first dereference the document. Bug: 814251 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I79cc37ee79271c2030a9f5c832ba5640ca8445c9 Reviewed-on: https://chromium-review.googlesource.com/957962Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#542333}
-
Brandon Jones authored
Should prevent crashes due to the matrix info not being sent properly. Bug: 820377 Change-Id: I36ee0af1f60333e55b3a076e72123fe4f5f3099f Reviewed-on: https://chromium-review.googlesource.com/957808Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#542332}
-
Jared Saul authored
Bug: 800588, 800997 Change-Id: I8312deae3c1e4d1f3a16169e4b875538c5cb610d Reviewed-on: https://chromium-review.googlesource.com/956682 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#542331}
-
Andrii Shyshkalov authored
R=hinoka@chromium.org, iannucci@chromium.org, jchinlee@chromium.org, smut@google.com, vadimsh@chromium.org Change-Id: Iaf3c26162afbd8cdefcf49073f3c8900bc23911e Reviewed-on: https://chromium-review.googlesource.com/957964Reviewed-by:
smut <smut@google.com> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#542330}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=xdai@google.com Change-Id: I229e43c8818b6ae91e26074dd1e617456f544404 Reviewed-on: https://chromium-review.googlesource.com/958142 Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#542329}
-
Jared Saul authored
This allows the dialog to use Harmony defaults. Bug: 820619 Change-Id: I814012b85324f27cd8b95346513f1b3d630aae24 Reviewed-on: https://chromium-review.googlesource.com/957818Reviewed-by:
-
https://chromium.googlesource.com/angle/angle.git/+log/33140409810f..e2995cce7161 $ git log 331404098..e2995cce7 --date=short --no-merges --format='%ad %ae %s' 2018-03-09 jmadill Vulkan: Fix layers not being enabled on the bots. 2018-03-09 geofflang Use full type names instead of auto for simple structs. 2018-03-09 geofflang Rename syncRendererState methods to syncImplementationState. 2018-03-09 cwallez cq.cfg: Add equivalent_to to ramp-up during LUCI migration 2018-03-09 ynovikov Skip TransformFeedbackLifetimeTest.DeletedBuffer on Win Intel GL 2018-03-09 jmadill Vulkan: Add Vk format overrides table. 2018-03-09 jmadill Vulkan: Use free descriptor set bits in pool. 2018-03-09 lucferron Vulkan: Fix issue in blending factor conversions 2018-03-08 jmadill Nuke ValidationContext. 2017-09-22 geofflang Reorder state synchronization for resource init. Created with: roll-dep src/third_party/angle BUG=815092 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I6a77383ed0bda7bb90494f0af30d7bf39b620819 Reviewed-on: https://chromium-review.googlesource.com/957884Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542327}
-
Saman Sami authored
Currently snapshots in DevTools are letterboxed if the renderer is resized multiple times. Although this might be desirable for other usages of FrameSinkVideoCapturer, we definitely don't want this for DevTools, so add a method to configure resize throttling period. Bug: 813929 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I12807e57a0b9a4a2131c46a97c004fb2d577ea2f Reviewed-on: https://chromium-review.googlesource.com/954012Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#542326}
-
Paul Miller authored
This will be needed to start loading the variations seed earlier. Also clean up the places where we were passing the package name around. BUG=954058 Change-Id: Ia5345688cc6e1cac6451f1ddeda248d1f504d81d Reviewed-on: https://chromium-review.googlesource.com/957862Reviewed-by:
-
Scott Violet authored
And instead changes GetRootWindowForEventDispatch() to return null if not in a valid hierarchy for event dispatch. BUG=none TEST=none Change-Id: I9e8d23d3607fb600d2cf0c80ff1086688a4b6c13 Reviewed-on: https://chromium-review.googlesource.com/956849Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#542324}
-
Dale Curtis authored
This removes the hardcoded setup of the decrypting audio and video decoders out of the DecoderSelector and into the standard decoder list. This functions similarly to the old behavior, but instead of knowing except for the following differences: - All decoders are checked for encrypted support first now. - If no decoder succeeds in initialization with an encrypted configuration, we'll try creating a DecryptingDemuxerStream, if this succeeds we'll check the decoder list again, if it fails, we'll abort as before. Mainly this implies that falling back to decrypt-only will take slightly longer than before. This also adds back support for EME to use GpuMemoryBuffers. BUG=801245 TEST=updated lots of unittests... Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I578809aeebaa59d81f65a5be2f2f1f76713d0f68 Reviewed-on: https://chromium-review.googlesource.com/952207Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#542323}
-
Zhongyi Shi authored
migration. Also add more granular histograms to collect data on PacketReader errors. Bug: 818050 Change-Id: I39d736967f1a3347e964c09862982941e4f0d60d Reviewed-on: https://chromium-review.googlesource.com/956663 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#542322}
-
kylechar authored
The order of methods has gotten pretty messy over the years. Reorder source file so its free functions, public functions then private functions and follows the order in header. Also fix header to be more style guide compliant. No change to any code beyond order and formatting. This is an initial step before refactoring resource allocation code. Bug: 730660 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I6b36a8119c7c70e6981a24c56562b7e0ac2a504c Reviewed-on: https://chromium-review.googlesource.com/957556Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#542321}
-
https://pdfium.googlesource.com/pdfium.git/+log/69da36c5f841..0d0d3ad30ca8 $ git log 69da36c5f..0d0d3ad30 --date=short --no-merges --format='%ad %ae %s' 2018-03-09 dsinclair Remove default params from CPDF_DefaultAppearance methods Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I97a36d18bd78b98171c0f1951ff52fabe9be9705 Reviewed-on: https://chromium-review.googlesource.com/957661 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542320}
-
https://webrtc.googlesource.com/src.git/+log/a5aa68b73f1d..ba907f00581e $ git log a5aa68b73..ba907f005 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I549e3613c6ea3f8a775f83e9d641e0d404e53e1c Reviewed-on: https://chromium-review.googlesource.com/957557Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542319}
-
Takashi Toyoshima authored
Current slow-loading.html requires at least 5 seconds to finish. This may easily exceeds 6 seconds timeout of LayoutTests. To stabilize the test, let me change the result check timing from 5 seconds to 4 seconds. Bug: 818387 Change-Id: Id6b9b62c8bda3187850b71c57b3895ebca524bf2 Reviewed-on: https://chromium-review.googlesource.com/956828Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#542318}
-
https://chromium.googlesource.com/catapult.git/+log/21ff400bb488..1537dcedd27d $ git log 21ff400bb..1537dcedd --date=short --no-merges --format='%ad %ae %s' 2018-03-10 nednguyen Cleanup numpy & cv2 cloud storage binary from Telemetry Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I7f53a3863e427cac1d9f3cbaa93ca75173233bc9 Reviewed-on: https://chromium-review.googlesource.com/957715Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542317}
-
Ian Kilpatrick authored
As above. Removes all relevant code, and layout-tests for this feature. See intent to deprecate and remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/-e92az54B4I/SZdhGR19DgAJ Bug: 818691 Change-Id: Ib39061c2181e142d3122ec0892746266ab06ccda Reviewed-on: https://chromium-review.googlesource.com/956619 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#542316}
-
Sammie Quon authored
Previously relied on using tap_count in GestureEvent which has a minimum time between taps of 40ms for consecutive taps to have tap_count of 2. Remove that and track double taps in overview button tray.cc. Allows double tap from mice now. Test: ash_unittests OverviewButtonTrayTest.* Bug: 817883 Change-Id: Icce2e668223f938a7f8194c5f0a03279abff9907 Reviewed-on: https://chromium-review.googlesource.com/956769 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
-
Scott Chen authored
Bug: 817117 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I69996a0a30fba0dbedba95745dd396eb1500769b Reviewed-on: https://chromium-review.googlesource.com/954292 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#542314}
-
Karan Bhatia authored
This CL bumps the Docserver version to 3.55.0. We uploaded new templates to the chrome webstore GCS bucket and this is required to see whether the update works. BUG=796031 Change-Id: Ibfeb8e549c642390f47918bb6c0a8e1a1279577c Reviewed-on: https://chromium-review.googlesource.com/957813Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#542313}
-
Chandan Padhi authored
Bug: 817769 Change-Id: Iae2abc17aee26c5586c38412140f18fbacc66568 Reviewed-on: https://chromium-review.googlesource.com/945590Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#542312}
-
James Darpinian authored
Bug: 696345 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id534cd0169d02311c808cd7803a86d63c5e1329b Reviewed-on: https://chromium-review.googlesource.com/924825 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#542311}
-
Jiaquan He authored
Design doc: go/mustash Design doc: go/move-applist AppList consists of two parts: Apps and Search. Everything is currently initiated in Chrome. This commit does a few things: - initiates all AppList UI in Ash; - removes all AppList UI from Chrome; - bridges Ash and Chrome with AppListController and AppListClient in //ash/public/interfaces/app_list.mojom; - modifies all affected tests to apply to the new AppList architecture; - cleans up old AppList stuff, e.g. AppList presenter mojo interfaces. With this commit we're expecting: - all AppList models, views are initiated in Ash; - all other AppList logic, e.g. sync and search, still live in Chrome since they depend on user profile data; - in Mus+Ash mode, where Ash and Chrome are two different processes, we have Search disabled; - in classic mode, where Ash and Chrome are in the same process, we get SearchModel from Ash in Chrome and have Search enabled. Bug: 733662 Change-Id: I0e1e04e832ba74f8328af40deabf930b53d70bdd Reviewed-on: https://chromium-review.googlesource.com/954355Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#542310}
-
Jun Cai authored
This CL removes unnecessary comment characters in //services/device/generic_sensor/orientation_util.cc Bug: None Change-Id: I7354767c0a982bdad19522363a2a58be9dee4ca8 Reviewed-on: https://chromium-review.googlesource.com/957805Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#542309}
-
James Cook authored
Make it use DeleteDelegate() to be more consistent with StatusAreaWidgetDelegate. Defer closing the widget until all the top-level windows are closed. Don't try to close all windows more than once during shutdown, which simplifies the shelf cleanup code. Originally landed as cc4be1cb. That version exposed a use-after-free in ash drag and drop code, which was fixed separately. See https://crbug.com/818603 TBR=sadrul@chromium.org Bug: 628655, 818603 Test: ash_unittests Change-Id: I4a8ade351456b476a19225f2c740e031f6b0e122 Reviewed-on: https://chromium-review.googlesource.com/956924 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#542308}
-
Kyle Horimoto authored
Previously, the link added a board parameter to the URL, but this was not correct for this particular link. Bug: 788897 Change-Id: I2e29bdbe61f27ecf1b868c3633c793152d2d587f Reviewed-on: https://chromium-review.googlesource.com/957598Reviewed-by:
-
Robert Ma authored
Starting from 10.12, system_profiler no longer contains the line "Retina: Yes" (or No), so we need to detect Retina by looking at the Resolution field instead. Besides, we now realize that our Retina bots are actually running 10.12 (despite their names saying 10.11, which will be fixed in other CLs), so Retina is changed to fall back to Mac 10.12 instead of 10.11. Lastly, rebaseline. Bug: 818558, 819851 Change-Id: Ie3ed6ef7d090590f411a1701b72be920498c9769 Reviewed-on: https://chromium-review.googlesource.com/957306 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#542306}
-
Erik Chen authored
The ownership semantics for LoginHandler are very confusing. The class is self-owned, and is only destroyed when LoginHandler::ReleaseSoon() is called. But this relies on the assumption that the LoginHandlerView is shown, which isn't always the case. This CL adds tracking for whether the LoginHandlerView has been shown, and if it has never been shown but CancelAuth() is called, then LoginHandler::ReleaseSoon() will also be called. This relies on the assumption that all codes paths must either show the LoginHandlerView or else call CancelAuth(). Ideally, the whole class should be refactored to have saner ownership semantics. Bug: 814334 Change-Id: I28085ca948a5629f11e6263153938e5c87f42518 Reviewed-on: https://chromium-review.googlesource.com/957283Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#542305}
-
